Re: [PATCH v4 net-next 5/6] net: dsa: microchip: break KSZ9477 DSA driver into two files

2018-12-03 Thread Sørensen , Stefan
On Tue, 2018-11-20 at 15:55 -0800, tristram...@microchip.com wrote: > From: Tristram Ha > > Break KSZ9477 DSA driver into two files in preparation to add more > KSZ switch drivers. > Add common functions in ksz_common.h so that other KSZ switch drivers > can access code in ksz_common.c. > Add ksz

PTP: PHY timestamping when MAC is PTP capable

2017-08-28 Thread Sørensen , Stefan
Hi, I have run into a problem with packet timestamping on a platform (cpsw + dp83640) where both the PHY and the MAC is PTP capable and I need the PHY to perform the timestamping. In the current code, SIOCGHWTSTAMP is passed to the MAC driver and only if it does not support PTP itself will it pass

Re: [PATCH] dp83640: don't recieve time stamps twice

2017-04-19 Thread Sørensen , Stefan
On Wed, 2017-04-19 at 12:31 +0200, Richard Cochran wrote: > Can we please fix this in another way?  There is no need to hold the > spin lock during the callback into the networking stack.  Instead, > how about the following diff, which also fixes the other call site... I agree that this is a bett

Re: [PATCH] dp83640: don't recieve time stamps twice

2017-04-19 Thread Sørensen , Stefan
On Tue, 2017-04-18 at 22:14 +0300, Dan Carpenter wrote: > This patch is prompted by a static checker warning about a potential > use after free.  The concern is that netif_rx_ni() can free "skb" and > we > call it twice. > > When I look at the commit that added this, it looks like some stray > lin

Re: [PATCH net-next 2/5] dp83640: Delay scheduled work.

2015-11-01 Thread Sørensen , Stefan
On Fri, 2015-10-30 at 21:37 +0100, Richard Cochran wrote: >  > NAK.  We want to have the time stamp ASAP, because the delay between > the transmission of the Sync and its application in the servo > degrades or even spoils synchronization.  Think of an ARM SoC with > HZ=100.  Two jiffies are 20 mill