Re: phys_port_id in switchdev mode?

On 9/4/2018 3:20 AM, Jakub Kicinski wrote: On Mon, 3 Sep 2018 12:40:22 +0300, Or Gerlitz wrote: On Tue, Aug 28, 2018 at 9:05 PM, Jakub Kicinski wrote: Hi! Hi Jakub and sorry for the late reply, this crazigly hot summer refuses to die, Note I replied couple of minutes ago but it didn't get to

Re: [PATCH v2 net-next] failover: Add missing check to validate 'slave_dev' in net_failover_slave_unregister

On 9/3/2018 7:56 PM, YueHaibing wrote: Fixes gcc '-Wunused-but-set-variable' warning: drivers/net/net_failover.c: In function 'net_failover_slave_unregister': drivers/net/net_failover.c:598:35: warning: variable 'primary_dev' set but not used [-Wunused-but-set-variable] There should check

Re: [PATCH net-next] failover: remove set but not used variable 'primary_dev'

On 8/30/2018 8:46 PM, YueHaibing wrote: Fixes gcc '-Wunused-but-set-variable' warning: drivers/net/net_failover.c: In function 'net_failover_slave_unregister': drivers/net/net_failover.c:598:35: warning: variable 'primary_dev' set but not used [-Wunused-but-set-variable] Actually this gcc

Re: virtio_net failover and initramfs

On 8/17/2018 2:56 AM, Harald Hoyer wrote: On 17.08.2018 11:51, Harald Hoyer wrote: On 16.08.2018 00:17, Siwei Liu wrote: On Wed, Aug 15, 2018 at 12:05 PM, Samudrala, Sridhar wrote: On 8/14/2018 5:03 PM, Siwei Liu wrote: Are we sure all userspace apps skip and ignore slave interfaces by just

Re: virtio_net failover and initramfs (was: Re: [PATCH net-next v11 2/5] netvsc: refactor notifier/event handling code to use the failover framework)

On 8/14/2018 5:03 PM, Siwei Liu wrote: Are we sure all userspace apps skip and ignore slave interfaces by just looking at "IFLA_MASTER" attribute? When STANDBY is enabled on virtio-net, a failover master interface will appear, which automatically enslaves the virtio device. But it is found out

Re: [patch net-next v2 0/9] net: sched: introduce chain templates support with offloading to mlxsw

On 6/29/2018 6:05 AM, Jiri Pirko wrote: Fri, Jun 29, 2018 at 02:54:36PM CEST, dsah...@gmail.com wrote: On 6/29/18 6:48 AM, Jiri Pirko wrote: Fri, Jun 29, 2018 at 02:12:21PM CEST, j...@mojatatu.com wrote: On 29/06/18 04:39 AM, Jiri Pirko wrote: Fri, Jun 29, 2018 at 12:25:53AM CEST,

Re: [patch net-next 0/9] net: sched: introduce chain templates support with offloading to mlxsw

On 6/27/2018 12:50 AM, Jiri Pirko wrote: Tue, Jun 26, 2018 at 11:18:58PM CEST, jakub.kicin...@netronome.com wrote: On Tue, 26 Jun 2018 09:12:17 +0200, Jiri Pirko wrote: Tue, Jun 26, 2018 at 09:00:45AM CEST, jakub.kicin...@netronome.com wrote: On Mon, Jun 25, 2018 at 11:43 PM, Jiri Pirko

Re: [patch net-next v2 0/9] net: sched: introduce chain templates support with offloading to mlxsw

On 6/26/2018 11:05 PM, Jiri Pirko wrote: Wed, Jun 27, 2018 at 02:04:31AM CEST, xiyou.wangc...@gmail.com wrote: On Tue, Jun 26, 2018 at 1:01 AM Jiri Pirko wrote: Create dummy device with clsact first: # ip link add type dummy # tc qdisc add dev dummy0 clsact There is no template assigned by

Re: [virtio-dev] Re: [Qemu-devel] [PATCH] qemu: Introduce VIRTIO_NET_F_STANDBY feature bit to virtio_net

On 6/22/2018 5:17 PM, Siwei Liu wrote: On Fri, Jun 22, 2018 at 4:40 PM, Siwei Liu wrote: On Fri, Jun 22, 2018 at 3:25 PM, Michael S. Tsirkin wrote: On Fri, Jun 22, 2018 at 02:51:11PM -0700, Siwei Liu wrote: On Fri, Jun 22, 2018 at 2:29 PM, Michael S. Tsirkin wrote: On Fri, Jun 22, 2018 at

Re: [PATCH net] failover: eliminate callback hell

On 6/11/2018 12:34 PM, Samudrala, Sridhar wrote: On 6/11/2018 11:10 AM, Michael S. Tsirkin wrote: On Mon, Jun 04, 2018 at 08:42:31PM -0700, Stephen Hemminger wrote:    * Set permanent and current address of net_failover device to match the primary. We copy the dev_addr of standby dev

Re: [PATCH net] failover: eliminate callback hell

On 6/11/2018 11:10 AM, Michael S. Tsirkin wrote: On Mon, Jun 04, 2018 at 08:42:31PM -0700, Stephen Hemminger wrote: * Set permanent and current address of net_failover device to match the primary. * Carrier should be marked off before registering device the net_failover

Re: [PATCH net] failover: eliminate callback hell

On 6/6/2018 2:24 PM, Stephen Hemminger wrote: On Wed, 6 Jun 2018 15:30:27 +0300 "Michael S. Tsirkin" wrote: On Wed, Jun 06, 2018 at 09:25:12AM +0200, Jiri Pirko wrote: Tue, Jun 05, 2018 at 05:42:31AM CEST, step...@networkplumber.org wrote: The net failover should be a simple library, not

Re: [net-next PATCH v3 3/5] net: Enable Tx queue selection based on Rx queues

On 6/6/2018 11:56 AM, Willem de Bruijn wrote: On Tue, Jun 5, 2018 at 4:38 AM, Amritha Nambiar wrote: This patch adds support to pick Tx queue based on the Rx queue(s) map configuration set by the admin through the sysfs attribute for each Tx queue. If the user configuration for receive

Re: [PATCH net] failover: eliminate callback hell

On 6/5/2018 11:00 PM, Stephen Hemminger wrote: On Tue, 5 Jun 2018 22:39:12 -0700 "Samudrala, Sridhar" wrote: On 6/5/2018 8:51 PM, Stephen Hemminger wrote: On Tue, 5 Jun 2018 16:52:22 -0700 "Samudrala, Sridhar" wrote: On 6/5/2018 2:52 PM, Stephen Hemminger wrote:

Re: [PATCH net] failover: eliminate callback hell

On 6/5/2018 8:51 PM, Stephen Hemminger wrote: On Tue, 5 Jun 2018 16:52:22 -0700 "Samudrala, Sridhar" wrote: On 6/5/2018 2:52 PM, Stephen Hemminger wrote: On Tue, 5 Jun 2018 22:38:43 +0300 "Michael S. Tsirkin" wrote: See: https://patchwork.ozlabs.org/patch

Re: [PATCH net] failover: eliminate callback hell

On 6/5/2018 2:52 PM, Stephen Hemminger wrote: On Tue, 5 Jun 2018 22:38:43 +0300 "Michael S. Tsirkin" wrote: See: https://patchwork.ozlabs.org/patch/851711/ Let me try to summarize that: You wanted to speed up the delayed link up. You had an idea to additionally take

Re: [PATCH net] failover: eliminate callback hell

On 6/4/2018 8:42 PM, Stephen Hemminger wrote: The net failover should be a simple library, not a virtual object with function callbacks (see callback hell). The code is simpler is smaller both for the netvsc and virtio use case. I quickly tried this patch and it breaks virtio-net in standby

Re: [PATCH 1/2 net-next] net_failover: fix net_failover_compute_features()

On 5/31/2018 5:01 AM, Dan Carpenter wrote: This has an '&' vs '|' typo so it starts with vlan_features set to none. Also a u32 type isn't large enough to hold all the feature bits, it should be netdev_features_t. Fixes: cfc80d9a1163 ("net: Introduce net_failover driver") Signed-off-by: Dan

Re: [PATCH 2/2 net-next] net_failover: fix error code in net_failover_create()

On 5/31/2018 5:04 AM, Dan Carpenter wrote: We forgot to set the error code on this path. This function is supposed to return error pointers, so with this bug it accidentally returns NULL and the caller doesn't check for that. Fixes: cfc80d9a1163 ("net: Introduce net_failover driver")

Re: [PATCH net-next 1/3] net: Add support to configure SR-IOV VF minimum and maximum queues.

On 5/30/2018 3:53 PM, Jakub Kicinski wrote: On Wed, 30 May 2018 14:23:06 -0700, Samudrala, Sridhar wrote: On 5/29/2018 11:33 PM, Jakub Kicinski wrote: On Tue, 29 May 2018 23:08:11 -0700, Michael Chan wrote: On Tue, May 29, 2018 at 10:56 PM, Jakub Kicinski wrote: On Tue, 29 May 2018 20:19:54

Re: [PATCH net-next 1/3] net: Add support to configure SR-IOV VF minimum and maximum queues.

On 5/29/2018 11:33 PM, Jakub Kicinski wrote: On Tue, 29 May 2018 23:08:11 -0700, Michael Chan wrote: On Tue, May 29, 2018 at 10:56 PM, Jakub Kicinski wrote: On Tue, 29 May 2018 20:19:54 -0700, Michael Chan wrote: On Tue, May 29, 2018 at 1:46 PM, Samudrala, Sridhar wrote: Isn't ndo_set_vf_xxx

Re: [PATCH net-next 1/3] net: Add support to configure SR-IOV VF minimum and maximum queues.

On 5/29/2018 1:18 AM, Michael Chan wrote: VF Queue resources are always limited and there is currently no infrastructure to allow the admin. on the host to add or reduce queue resources for any particular VF. With ever increasing number of VFs being supported, it is desirable to allow the

Re: [PATCH net-next v12 2/5] netvsc: refactor notifier/event handling code to use the failover framework

'On 5/26/2018 12:51 AM, Jiri Pirko wrote: Sat, May 26, 2018 at 09:22:18AM CEST, sridhar.samudr...@intel.com wrote: On 5/25/2018 4:28 PM, Stephen Hemminger wrote: On Fri, 25 May 2018 16:11:47 -0700 "Samudrala, Sridhar" <sridhar.samudr...@intel.com> wrote: On 5/25/2018

Re: [PATCH net-next v12 2/5] netvsc: refactor notifier/event handling code to use the failover framework

On 5/25/2018 4:28 PM, Stephen Hemminger wrote: On Fri, 25 May 2018 16:11:47 -0700 "Samudrala, Sridhar" <sridhar.samudr...@intel.com> wrote: On 5/25/2018 3:34 PM, Stephen Hemminger wrote: On Thu, 24 May 2018 09:55:14 -0700 Sridhar Samudrala <sridhar.samudr.

Re: [PATCH net-next v12 2/5] netvsc: refactor notifier/event handling code to use the failover framework

On 5/25/2018 3:34 PM, Stephen Hemminger wrote: On Thu, 24 May 2018 09:55:14 -0700 Sridhar Samudrala wrote: --- a/drivers/net/hyperv/Kconfig +++ b/drivers/net/hyperv/Kconfig @@ -2,5 +2,6 @@ config HYPERV_NET tristate "Microsoft Hyper-V virtual network

Re: [PATCH net-next v12 1/5] net: Introduce generic failover module

On 5/25/2018 3:38 PM, Stephen Hemminger wrote: On Thu, 24 May 2018 09:55:13 -0700 Sridhar Samudrala wrote: diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h index 03ed492c4e14..0f4ba52b641d 100644 --- a/include/linux/netdevice.h +++

Re: [PATCH net-next 0/8] nfp: offload LAG for tc flower egress

On 5/24/2018 10:04 AM, Or Gerlitz wrote: On Thu, May 24, 2018 at 5:22 AM, Jakub Kicinski wrote: Hi! This series from John adds bond offload to the nfp driver. Patch 5 exposes the hash type for NETDEV_LAG_TX_TYPE_HASH to make sure nfp hashing matches that of the

Re: [PATCH net-next v11 2/5] netvsc: refactor notifier/event handling code to use the failover framework

On 5/22/2018 11:27 PM, Jiri Pirko wrote: Tue, May 22, 2018 at 10:54:29PM CEST, sridhar.samudr...@intel.com wrote: On 5/22/2018 9:12 AM, Jiri Pirko wrote: Fixing the subj, sorry about that. Tue, May 22, 2018 at 05:46:21PM CEST, m...@redhat.com wrote: On Tue, May 22, 2018 at 05:36:14PM +0200,

Re: [PATCH net-next v11 2/5] netvsc: refactor notifier/event handling code to use the failover framework

On 5/22/2018 9:12 AM, Jiri Pirko wrote: Fixing the subj, sorry about that. Tue, May 22, 2018 at 05:46:21PM CEST, m...@redhat.com wrote: On Tue, May 22, 2018 at 05:36:14PM +0200, Jiri Pirko wrote: Tue, May 22, 2018 at 05:28:42PM CEST, sridhar.samudr...@intel.com wrote: On 5/22/2018 2:08 AM,

Re: [PATCH net-next v11 2/5] netvsc: refactor notifier/event handling code to use the failover framework

On 5/22/2018 2:08 AM, Jiri Pirko wrote: Tue, May 22, 2018 at 11:06:37AM CEST, j...@resnulli.us wrote: Tue, May 22, 2018 at 04:06:18AM CEST, sridhar.samudr...@intel.com wrote: Use the registration/notification framework supported by the generic failover infrastructure. Signed-off-by: Sridhar

Re: [PATCH net-next v10 2/4] net: Introduce generic failover module

On 5/7/2018 3:39 PM, Randy Dunlap wrote: Hi, On 05/07/2018 03:10 PM, Sridhar Samudrala wrote: Signed-off-by: Sridhar Samudrala --- MAINTAINERS|7 + include/linux/netdevice.h | 16 + include/net/net_failover.h | 52 +++ net/Kconfig

Re: [PATCH net-next v10 2/4] net: Introduce generic failover module

On 5/7/2018 4:46 PM, Stephen Hemminger wrote: On Mon, 7 May 2018 15:10:44 -0700 Sridhar Samudrala wrote: This provides a generic interface for paravirtual drivers to listen for netdev register/unregister/link change events from pci ethernet devices with the same

Re: [PATCH net-next v10 2/4] net: Introduce generic failover module

On 5/7/2018 4:53 PM, Stephen Hemminger wrote: On Mon, 7 May 2018 15:10:44 -0700 Sridhar Samudrala wrote: +static struct net_device *net_failover_get_bymac(u8 *mac, +struct net_failover_ops **ops) +{ + struct

Re: [PATCH net-next v10 2/4] net: Introduce generic failover module

On 5/7/2018 4:59 PM, Stephen Hemminger wrote: On Mon, 7 May 2018 15:10:44 -0700 Sridhar Samudrala wrote: + if (netif_running(failover_dev)) { + err = dev_open(slave_dev); + if (err && (err != -EBUSY)) { +

Re: [PATCH net-next v9 2/4] net: Introduce generic failover module

On 5/2/2018 1:30 PM, Michael S. Tsirkin wrote: On Wed, May 02, 2018 at 10:51:12AM -0700, Samudrala, Sridhar wrote: On 5/2/2018 9:15 AM, Jiri Pirko wrote: Sat, Apr 28, 2018 at 11:06:01AM CEST, j...@resnulli.us wrote: Fri, Apr 27, 2018 at 07:06:58PM CEST, sridhar.samudr...@intel.com wrote

Re: [PATCH net-next v9 2/4] net: Introduce generic failover module

On 5/2/2018 9:15 AM, Jiri Pirko wrote: Sat, Apr 28, 2018 at 11:06:01AM CEST, j...@resnulli.us wrote: Fri, Apr 27, 2018 at 07:06:58PM CEST, sridhar.samudr...@intel.com wrote: [...] + + err = netdev_rx_handler_register(slave_dev, net_failover_handle_frame, +

Re: [PATCH net-next v9 3/4] virtio_net: Extend virtio to use VF datapath when available

On 5/2/2018 12:50 AM, Jiri Pirko wrote: Wed, May 02, 2018 at 02:20:26AM CEST, sridhar.samudr...@intel.com wrote: On 4/30/2018 12:20 AM, Jiri Pirko wrote: Now I try to change mac of the failover master: [root@test1 ~]# ip link set ens3 addr 52:54:00:b2:a7:f3 RTNETLINK answers: Operation not

Re: [PATCH net-next v9 3/4] virtio_net: Extend virtio to use VF datapath when available

On 4/30/2018 12:20 AM, Jiri Pirko wrote: Now I try to change mac of the failover master: [root@test1 ~]# ip link set ens3 addr 52:54:00:b2:a7:f3 RTNETLINK answers: Operation not supported That I did expect to work. I would expect this would change the mac of the master and both standby and

Re: [PATCH net-next v9 3/4] virtio_net: Extend virtio to use VF datapath when available

On 4/30/2018 12:12 AM, Jiri Pirko wrote: Mon, Apr 30, 2018 at 05:00:33AM CEST, sridhar.samudr...@intel.com wrote: On 4/28/2018 1:24 AM, Jiri Pirko wrote: Fri, Apr 27, 2018 at 07:06:59PM CEST, sridhar.samudr...@intel.com wrote: This patch enables virtio_net to switch over to a VF datapath when

Re: [PATCH net-next v9 1/4] virtio_net: Introduce VIRTIO_NET_F_STANDBY feature bit

On 4/30/2018 12:03 AM, Jiri Pirko wrote: Mon, Apr 30, 2018 at 04:47:03AM CEST, sridhar.samudr...@intel.com wrote: On 4/28/2018 12:50 AM, Jiri Pirko wrote: Fri, Apr 27, 2018 at 07:06:57PM CEST,sridhar.samudr...@intel.com wrote: This feature bit can be used by hypervisor to indicate

Re: [PATCH net-next v9 2/4] net: Introduce generic failover module

On 4/28/2018 2:06 AM, Jiri Pirko wrote: Fri, Apr 27, 2018 at 07:06:58PM CEST, sridhar.samudr...@intel.com wrote: This provides a generic interface for paravirtual drivers to listen for netdev register/unregister/link change events from pci ethernet devices with the same MAC and takeover their

Re: [PATCH net-next v9 3/4] virtio_net: Extend virtio to use VF datapath when available

On 4/28/2018 1:24 AM, Jiri Pirko wrote: Fri, Apr 27, 2018 at 07:06:59PM CEST, sridhar.samudr...@intel.com wrote: This patch enables virtio_net to switch over to a VF datapath when a VF netdev is present with the same MAC address. It allows live migration of a VM with a direct attached VF

Re: [PATCH net-next v9 0/4] Enable virtio_net to act as a standby for a passthru device

On 4/27/2018 10:45 AM, Jiri Pirko wrote: Fri, Apr 27, 2018 at 07:06:56PM CEST, sridhar.samudr...@intel.com wrote: v9: Select NET_FAILOVER automatically when VIRTIO_NET/HYPERV_NET are enabled. (stephen) Tested live migration with virtio-net/AVF(i40evf) configured in failover mode while running

Re: [PATCH net-next v8 4/4] netvsc: refactor notifier/event handling code to use the failover framework

On 4/26/2018 5:09 PM, Michael S. Tsirkin wrote: On Thu, Apr 26, 2018 at 03:33:26PM -0700, Stephen Hemminger wrote: On Thu, 26 Apr 2018 05:30:05 +0300 "Michael S. Tsirkin" wrote: On Wed, Apr 25, 2018 at 05:08:37PM -0700, Stephen Hemminger wrote: On Wed, 25 Apr 2018 16:59:28

Re: [PATCH v7 net-next 2/4] net: Introduce generic failover module

On 4/22/2018 10:06 AM, Michael S. Tsirkin wrote: On Thu, Apr 19, 2018 at 06:42:02PM -0700, Sridhar Samudrala wrote: +#if IS_ENABLED(CONFIG_NET_FAILOVER) + +int failover_create(struct net_device *standby_dev, + struct failover **pfailover); Should we rename all these structs

Re: [PATCH v7 net-next 4/4] netvsc: refactor notifier/event handling code to use the failover framework

On 4/20/2018 8:28 AM, Stephen Hemminger wrote: On Thu, 19 Apr 2018 18:42:04 -0700 Sridhar Samudrala wrote: Use the registration/notification framework supported by the generic failover infrastructure. Signed-off-by: Sridhar Samudrala

Re: [PATCH v7 net-next 2/4] net: Introduce generic failover module

On 4/19/2018 7:44 PM, Michael S. Tsirkin wrote: On Thu, Apr 19, 2018 at 06:42:02PM -0700, Sridhar Samudrala wrote: This provides a generic interface for paravirtual drivers to listen for netdev register/unregister/link change events from pci ethernet devices with the same MAC and takeover

Re: [virtio-dev] Re: [RFC PATCH 2/3] netdev: kernel-only IFF_HIDDEN netdevice

On 4/18/2018 10:07 PM, Michael S. Tsirkin wrote: On Wed, Apr 18, 2018 at 10:00:51PM -0700, Samudrala, Sridhar wrote: On 4/18/2018 9:41 PM, Michael S. Tsirkin wrote: On Wed, Apr 18, 2018 at 04:33:34PM -0700, Samudrala, Sridhar wrote: On 4/17/2018 5:26 PM, Siwei Liu wrote: I ran

Re: [virtio-dev] Re: [RFC PATCH 2/3] netdev: kernel-only IFF_HIDDEN netdevice

On 4/18/2018 9:41 PM, Michael S. Tsirkin wrote: On Wed, Apr 18, 2018 at 04:33:34PM -0700, Samudrala, Sridhar wrote: On 4/17/2018 5:26 PM, Siwei Liu wrote: I ran this with a few folks offline and gathered some good feedbacks that I'd like to share thus revive the discussion. First of all

Re: [virtio-dev] Re: [RFC PATCH 2/3] netdev: kernel-only IFF_HIDDEN netdevice

On 4/17/2018 5:26 PM, Siwei Liu wrote: I ran this with a few folks offline and gathered some good feedbacks that I'd like to share thus revive the discussion. First of all, as illustrated in the reply below, cloud service providers require transparent live migration. Specifically, the main

Re: [RFC PATCH net-next v6 2/4] net: Introduce generic bypass module

On 4/18/2018 1:32 PM, Jiri Pirko wrote: You still use "active"/"backup" names which is highly misleading as it has completely different meaning that in bond for example. I noted that in my previous review already. Please change it. I guess the issue is with only the 'active'  name. 'backup'

Re: [RFC PATCH net-next v6 2/4] net: Introduce generic bypass module

On 4/18/2018 2:25 AM, Jiri Pirko wrote: Wed, Apr 11, 2018 at 09:13:52PM CEST, sridhar.samudr...@intel.com wrote: On 4/11/2018 8:51 AM, Jiri Pirko wrote: Tue, Apr 10, 2018 at 08:59:48PM CEST, sridhar.samudr...@intel.com wrote: This provides a generic interface for paravirtual drivers to listen

Re: [PATCH RFC net-next 00/11] udp gso

On 4/18/2018 6:51 AM, Willem de Bruijn wrote: On Wed, Apr 18, 2018 at 9:47 AM, Sowmini Varadhan wrote: On (04/18/18 06:35), Eric Dumazet wrote: There is no change at all. This will only be used as a mechanism to send X packets of same size. So instead of X

Re: [PATCH RFC net-next 00/11] udp gso

On 4/17/2018 2:07 PM, Willem de Bruijn wrote: On Tue, Apr 17, 2018 at 4:48 PM, Sowmini Varadhan wrote: On (04/17/18 16:23), Willem de Bruijn wrote: Assuming IPv4 with an MTU of 1500 and the maximum segment size of 1472, the receiver will see three datagrams with

Re: SRIOV switchdev mode BoF minutes

On 4/17/2018 7:47 AM, Andy Gospodarek wrote: On Tue, Apr 17, 2018 at 04:58:05PM +0300, Or Gerlitz wrote: On Tue, Apr 17, 2018 at 4:30 PM, Andy Gospodarek <andrew.gospoda...@broadcom.com> wrote: On Mon, Apr 16, 2018 at 07:08:39PM -0700, Samudrala, Sridhar wrote: On 4/16/2018 5:39 AM

Re: SRIOV switchdev mode BoF minutes

On 4/16/2018 5:39 AM, Andy Gospodarek wrote: On Sun, Apr 15, 2018 at 09:01:16AM +0300, Or Gerlitz wrote: On Sat, Apr 14, 2018 at 2:03 AM, Samudrala, Sridhar <sridhar.samudr...@intel.com> wrote: I meant between PFs on 2 compute nodes. If the PF serves as uplink rep, it functions as a

Re: SRIOV switchdev mode BoF minutes

On 4/13/2018 1:16 PM, Or Gerlitz wrote: On Fri, Apr 13, 2018 at 7:49 PM, Samudrala, Sridhar <sridhar.samudr...@intel.com> wrote: On 4/13/2018 1:57 AM, Or Gerlitz wrote: in overlay networks scheme, the uplink rep has the VTEP ip and is not connected to the bridge, e.g you use ovs you h

Re: SRIOV switchdev mode BoF minutes

On 4/13/2018 1:57 AM, Or Gerlitz wrote: On Fri, Apr 13, 2018 at 11:56 AM, Or Gerlitz <gerlitz...@gmail.com> wrote: On Thu, Apr 12, 2018 at 11:33 PM, Samudrala, Sridhar <sridhar.samudr...@intel.com> wrote: On 4/12/2018 1:20 PM, Or Gerlitz wrote: On Thu, Apr 12, 2018 at 8:05 P

Re: SRIOV switchdev mode BoF minutes

On 4/12/2018 1:20 PM, Or Gerlitz wrote: On Thu, Apr 12, 2018 at 8:05 PM, Samudrala, Sridhar <sridhar.samudr...@intel.com> wrote: On 11/12/2017 11:49 AM, Or Gerlitz wrote: Hi Dave and all, During and after the BoF on SRIOV switchdev mode, we came into a consensus among the developers fro

Re: SRIOV switchdev mode BoF minutes

On 11/12/2017 11:49 AM, Or Gerlitz wrote: Hi Dave and all, During and after the BoF on SRIOV switchdev mode, we came into a consensus among the developers from four different HW vendors (CC audience) that a correct thing to do would be to disallow any new extensions to the legacy mode. The

Re: [RFC PATCH net-next v6 2/4] net: Introduce generic bypass module

On 4/11/2018 8:51 AM, Jiri Pirko wrote: Tue, Apr 10, 2018 at 08:59:48PM CEST, sridhar.samudr...@intel.com wrote: This provides a generic interface for paravirtual drivers to listen for netdev register/unregister/link change events from pci ethernet devices with the same MAC and takeover their

Re: [RFC PATCH net-next v5 3/4] virtio_net: Extend virtio to use VF datapath when available

On 4/10/2018 11:03 PM, Jiri Pirko wrote: Tue, Apr 10, 2018 at 05:59:02PM CEST, sridhar.samudr...@intel.com wrote: On 4/10/2018 8:43 AM, Jiri Pirko wrote: Tue, Apr 10, 2018 at 05:27:48PM CEST, sridhar.samudr...@intel.com wrote: On 4/10/2018 8:22 AM, Jiri Pirko wrote: Tue, Apr 10, 2018 at

Re: [RFC PATCH net-next v6 4/4] netvsc: refactor notifier/event handling code to use the bypass framework

On 4/10/2018 2:26 PM, Stephen Hemminger wrote: On Tue, 10 Apr 2018 11:59:50 -0700 Sridhar Samudrala wrote: Use the registration/notification framework supported by the generic bypass infrastructure. Signed-off-by: Sridhar Samudrala

Re: [RFC PATCH net-next v5 3/4] virtio_net: Extend virtio to use VF datapath when available

On 4/10/2018 8:43 AM, Jiri Pirko wrote: Tue, Apr 10, 2018 at 05:27:48PM CEST, sridhar.samudr...@intel.com wrote: On 4/10/2018 8:22 AM, Jiri Pirko wrote: Tue, Apr 10, 2018 at 05:13:40PM CEST, sridhar.samudr...@intel.com wrote: On 4/10/2018 3:55 AM, Jiri Pirko wrote: Mon, Apr 09, 2018 at

Re: [RFC PATCH net-next v5 3/4] virtio_net: Extend virtio to use VF datapath when available

On 4/10/2018 8:22 AM, Jiri Pirko wrote: Tue, Apr 10, 2018 at 05:13:40PM CEST, sridhar.samudr...@intel.com wrote: On 4/10/2018 3:55 AM, Jiri Pirko wrote: Mon, Apr 09, 2018 at 08:47:06PM CEST, sridhar.samudr...@intel.com wrote: On 4/9/2018 1:07 AM, Jiri Pirko wrote: Sat, Apr 07, 2018 at

Re: [RFC PATCH net-next v5 3/4] virtio_net: Extend virtio to use VF datapath when available

On 4/10/2018 3:55 AM, Jiri Pirko wrote: Mon, Apr 09, 2018 at 08:47:06PM CEST, sridhar.samudr...@intel.com wrote: On 4/9/2018 1:07 AM, Jiri Pirko wrote: Sat, Apr 07, 2018 at 12:59:14AM CEST, sridhar.samudr...@intel.com wrote: On 4/6/2018 5:48 AM, Jiri Pirko wrote: Thu, Apr 05, 2018 at

Re: [RFC PATCH net-next v5 3/4] virtio_net: Extend virtio to use VF datapath when available

On 4/9/2018 1:07 AM, Jiri Pirko wrote: Sat, Apr 07, 2018 at 12:59:14AM CEST, sridhar.samudr...@intel.com wrote: On 4/6/2018 5:48 AM, Jiri Pirko wrote: Thu, Apr 05, 2018 at 11:08:22PM CEST, sridhar.samudr...@intel.com wrote: [...] +static int virtnet_bypass_join_child(struct net_device

Re: [RFC PATCH net-next v5 2/4] net: Introduce generic bypass module

On 4/6/2018 5:57 AM, Jiri Pirko wrote: Thu, Apr 05, 2018 at 11:08:21PM CEST, sridhar.samudr...@intel.com wrote: This provides a generic interface for paravirtual drivers to listen for netdev register/unregister/link change events from pci ethernet devices with the same MAC and takeover their

Re: [RFC PATCH net-next v5 3/4] virtio_net: Extend virtio to use VF datapath when available

On 4/6/2018 5:48 AM, Jiri Pirko wrote: Thu, Apr 05, 2018 at 11:08:22PM CEST, sridhar.samudr...@intel.com wrote: + +static void virtnet_bypass_set_rx_mode(struct net_device *dev) +{ + struct virtnet_bypass_info *vbi = netdev_priv(dev); + struct net_device *child_netdev;

Re: [PATCH v4 2/2] virtio_net: Extend virtio to use VF datapath when available

On 3/12/2018 2:08 PM, Jiri Pirko wrote: Mon, Mar 12, 2018 at 09:58:06PM CET, sridhar.samudr...@intel.com wrote: On 3/12/2018 1:12 PM, Jiri Pirko wrote: Thu, Mar 01, 2018 at 09:08:43PM CET, sridhar.samudr...@intel.com wrote: This patch enables virtio_net to switch over to a VF datapath when a

Re: [PATCH v4 2/2] virtio_net: Extend virtio to use VF datapath when available

On 3/12/2018 3:44 PM, Siwei Liu wrote: Apologies, still some comments going. Please see inline. On Thu, Mar 1, 2018 at 12:08 PM, Sridhar Samudrala wrote: This patch enables virtio_net to switch over to a VF datapath when a VF netdev is present with the same MAC

Re: [PATCH v4 2/2] virtio_net: Extend virtio to use VF datapath when available

On 3/12/2018 1:12 PM, Jiri Pirko wrote: Thu, Mar 01, 2018 at 09:08:43PM CET, sridhar.samudr...@intel.com wrote: This patch enables virtio_net to switch over to a VF datapath when a VF netdev is present with the same MAC address. It allows live migration of a VM with a direct attached VF

Re: [virtio-dev] Re: [PATCH v4 2/2] virtio_net: Extend virtio to use VF datapath when available

On 3/7/2018 12:11 PM, Michael S. Tsirkin wrote: On Wed, Mar 07, 2018 at 10:06:30AM -0800, Stephen Hemminger wrote: On Wed, 7 Mar 2018 09:50:50 -0800 Alexander Duyck wrote: On Tue, Mar 6, 2018 at 6:38 PM, Michael S. Tsirkin wrote: On Tue, Mar 06,

Re: [PATCH v4 2/2] virtio_net: Extend virtio to use VF datapath when available

On 3/4/2018 10:50 AM, Jiri Pirko wrote: Sun, Mar 04, 2018 at 07:24:12PM CET, alexander.du...@gmail.com wrote: On Sat, Mar 3, 2018 at 11:13 PM, Jiri Pirko wrote: Sun, Mar 04, 2018 at 01:26:53AM CET, alexander.du...@gmail.com wrote: On Sat, Mar 3, 2018 at 1:25 PM, Jiri

Re: [virtio-dev] Re: [PATCH v4 2/2] virtio_net: Extend virtio to use VF datapath when available

On 3/2/2018 1:11 PM, Siwei Liu wrote: On Thu, Mar 1, 2018 at 12:08 PM, Sridhar Samudrala wrote: This patch enables virtio_net to switch over to a VF datapath when a VF netdev is present with the same MAC address. It allows live migration of a VM with a direct

Re: [virtio-dev] Re: [PATCH v4 2/2] virtio_net: Extend virtio to use VF datapath when available

On 3/2/2018 12:44 PM, Siwei Liu wrote: On Fri, Mar 2, 2018 at 12:10 PM, Michael S. Tsirkin <m...@redhat.com> wrote: On Fri, Mar 02, 2018 at 11:52:27AM -0800, Samudrala, Sridhar wrote: On 3/2/2018 11:41 AM, Michael S. Tsirkin wrote: On Fri, Mar 02, 2018 at 07:26:25AM -0800, Alexander

Re: [PATCH v4 2/2] virtio_net: Extend virtio to use VF datapath when available

On 3/2/2018 11:41 AM, Michael S. Tsirkin wrote: On Fri, Mar 02, 2018 at 07:26:25AM -0800, Alexander Duyck wrote: The design limits things to a 1:1 relationship since we just have the child and backup pointers, but I don't think I am seeing exception handling to prevent us from overwriting the

Re: [RFC PATCH v3 0/3] Enable virtio_net to act as a backup for a passthru device

On 2/21/2018 6:35 PM, Samudrala, Sridhar wrote: On 2/21/2018 5:59 PM, Siwei Liu wrote: On Wed, Feb 21, 2018 at 4:17 PM, Alexander Duyck <alexander.du...@gmail.com> wrote: On Wed, Feb 21, 2018 at 3:50 PM, Siwei Liu <losewe...@gmail.com> wrote: I haven't checked emails for

Re: [RFC PATCH v3 0/3] Enable virtio_net to act as a backup for a passthru device

On 2/21/2018 5:59 PM, Siwei Liu wrote: On Wed, Feb 21, 2018 at 4:17 PM, Alexander Duyck wrote: On Wed, Feb 21, 2018 at 3:50 PM, Siwei Liu wrote: I haven't checked emails for days and did not realize the new revision had already came out. And

Re: [RFC PATCH v3 0/3] Enable virtio_net to act as a backup for a passthru device

On 2/21/2018 6:02 PM, Jakub Kicinski wrote: On Wed, 21 Feb 2018 12:57:09 -0800, Alexander Duyck wrote: I don't see why the team cannot be there always. It is more the logistical nightmare. Part of the goal here was to work with the cloud base images that are out there such as

Re: [RFC PATCH v3 0/3] Enable virtio_net to act as a backup for a passthru device

On 2/20/2018 8:29 AM, Jiri Pirko wrote: Tue, Feb 20, 2018 at 05:04:29PM CET, alexander.du...@gmail.com wrote: On Tue, Feb 20, 2018 at 2:42 AM, Jiri Pirko wrote: Fri, Feb 16, 2018 at 07:11:19PM CET, sridhar.samudr...@intel.com wrote: Patch 1 introduces a new feature bit

Re: [RFC PATCH v3 0/3] Enable virtio_net to act as a backup for a passthru device

On 2/18/2018 10:11 PM, Jakub Kicinski wrote: On Sat, 17 Feb 2018 09:12:01 -0800, Alexander Duyck wrote: We noticed a couple of issues with this approach during testing. - As both 'bypass' and 'backup' netdevs are associated with the same virtio pci device, udev tries to rename both of them

Re: [virtio-dev] Re: [RFC PATCH net-next v2 2/2] virtio_net: Extend virtio to use VF datapath when available

On 1/28/2018 12:18 PM, Alexander Duyck wrote: On Sun, Jan 28, 2018 at 11:18 AM, Samudrala, Sridhar <sridhar.samudr...@intel.com> wrote: On 1/28/2018 9:35 AM, Alexander Duyck wrote: On Fri, Jan 26, 2018 at 9:58 PM, Jakub Kicinski <kubak...@wp.pl> wrote: On Fri, 26 Jan 2018 21

Re: [virtio-dev] Re: [RFC PATCH net-next v2 2/2] virtio_net: Extend virtio to use VF datapath when available

On 1/28/2018 9:35 AM, Alexander Duyck wrote: On Fri, Jan 26, 2018 at 9:58 PM, Jakub Kicinski <kubak...@wp.pl> wrote: On Fri, 26 Jan 2018 21:33:01 -0800, Samudrala, Sridhar wrote: 3 netdev model breaks this configuration starting with the creation and naming of the 2 devices to udev n

Re: [virtio-dev] Re: [RFC PATCH net-next v2 2/2] virtio_net: Extend virtio to use VF datapath when available

On 1/26/2018 6:30 PM, Jakub Kicinski wrote: On Fri, 26 Jan 2018 15:30:35 -0800, Samudrala, Sridhar wrote: On 1/26/2018 2:47 PM, Jakub Kicinski wrote: On Sat, 27 Jan 2018 00:14:20 +0200, Michael S. Tsirkin wrote: On Fri, Jan 26, 2018 at 01:46:42PM -0800, Siwei Liu wrote: and the VM

Re: [virtio-dev] Re: [RFC PATCH net-next v2 2/2] virtio_net: Extend virtio to use VF datapath when available

On 1/26/2018 2:47 PM, Jakub Kicinski wrote: On Sat, 27 Jan 2018 00:14:20 +0200, Michael S. Tsirkin wrote: On Fri, Jan 26, 2018 at 01:46:42PM -0800, Siwei Liu wrote: and the VM is not expected to do any tuning/optimizations on the VF driver directly, i think the current patch that follows the

Re: [RFC PATCH net-next v2 2/2] virtio_net: Extend virtio to use VF datapath when available

On 1/26/2018 8:58 AM, Michael S. Tsirkin wrote: On Thu, Jan 11, 2018 at 09:58:39PM -0800, Sridhar Samudrala wrote: @@ -2859,6 +3123,42 @@ static struct virtio_driver virtio_net_driver = { #endif }; +static int virtio_netdev_event(struct notifier_block *this, +

Re: [virtio-dev] Re: [RFC PATCH net-next v2 2/2] virtio_net: Extend virtio to use VF datapath when available

On 1/26/2018 12:14 AM, Siwei Liu wrote: On Tue, Jan 23, 2018 at 2:58 PM, Michael S. Tsirkin wrote: On Tue, Jan 23, 2018 at 12:24:47PM -0800, Siwei Liu wrote: On Mon, Jan 22, 2018 at 1:41 PM, Michael S. Tsirkin wrote: On Mon, Jan 22, 2018 at 12:27:14PM

Re: [RFC PATCH net-next v2 2/2] virtio_net: Extend virtio to use VF datapath when available

On 1/23/2018 2:33 AM, Jason Wang wrote: On 2018年01月12日 13:58, Sridhar Samudrala wrote:   static netdev_tx_t start_xmit(struct sk_buff *skb, struct net_device *dev)   {   struct virtnet_info *vi = netdev_priv(dev);   int qnum = skb_get_queue_mapping(skb);   struct send_queue *sq

Re: [virtio-dev] [RFC PATCH net-next v2 1/2] virtio_net: Introduce VIRTIO_NET_F_BACKUP feature bit

On 1/22/2018 4:02 PM, Stephen Hemminger wrote: In the case of SwitchDev it should be possible for the port representors and the switch to provide data on which interfaces are bonded on the host side and which aren't. With that data it would be pretty easy to just put together a list of

Re: [virtio-dev] [RFC PATCH net-next v2 1/2] virtio_net: Introduce VIRTIO_NET_F_BACKUP feature bit

On 1/22/2018 4:05 PM, Michael S. Tsirkin wrote: On Mon, Jan 22, 2018 at 03:27:40PM -0800, Samudrala, Sridhar wrote: You could probably even handle the Tx queue selection via a simple eBPF program and map since the input for whatever is used to select Tx should be pretty simple, destination MAC

Re: [virtio-dev] [RFC PATCH net-next v2 1/2] virtio_net: Introduce VIRTIO_NET_F_BACKUP feature bit

On 1/22/2018 1:31 PM, Michael S. Tsirkin wrote: On Wed, Jan 17, 2018 at 01:49:58PM -0800, Alexander Duyck wrote: On Wed, Jan 17, 2018 at 11:57 AM, Michael S. Tsirkin <m...@redhat.com> wrote: On Wed, Jan 17, 2018 at 11:25:41AM -0800, Samudrala, Sridhar wrote: On 1/17/2018 11:02 AM, Mic

Re: [RFC PATCH net-next v2 2/2] virtio_net: Extend virtio to use VF datapath when available

On 1/22/2018 12:27 PM, Siwei Liu wrote: First off, as mentioned in another thread, the model of stacking up virt-bond functionality over virtio seems a wrong direction to me. Essentially the migration process would need to carry over all guest side configurations previously done on the VF/PT and

Re: [virtio-dev] [RFC PATCH net-next v2 1/2] virtio_net: Introduce VIRTIO_NET_F_BACKUP feature bit

On 1/17/2018 11:02 AM, Michael S. Tsirkin wrote: On Wed, Jan 17, 2018 at 10:15:52AM -0800, Alexander Duyck wrote: On Thu, Jan 11, 2018 at 9:58 PM, Sridhar Samudrala wrote: This feature bit can be used by hypervisor to indicate virtio_net device to act as a

Re: [PATCH net-next 0/2] Enable virtio to act as a master for a passthru device

On 1/3/2018 10:28 AM, Alexander Duyck wrote: On Wed, Jan 3, 2018 at 10:14 AM, Samudrala, Sridhar <sridhar.samudr...@intel.com> wrote: On 1/3/2018 8:59 AM, Alexander Duyck wrote: On Tue, Jan 2, 2018 at 6:16 PM, Jakub Kicinski <kubak...@wp.pl> wrote: On Tue, 2 Jan 2018 16:35:36 -0

Re: [PATCH net-next 1/2] virtio_net: Introduce VIRTIO_NET_F_MASTER feature bit

On 1/3/2018 9:43 AM, Michael S. Tsirkin wrote: On Tue, Jan 02, 2018 at 04:35:37PM -0800, Sridhar Samudrala wrote: This feature bit can be used by hypervisor to indicate virtio_net device to act as a master for a directly attached passthru device with the same MAC address. Signed-off-by:

Re: [PATCH net-next 0/2] Enable virtio to act as a master for a passthru device

On 1/3/2018 8:59 AM, Alexander Duyck wrote: On Tue, Jan 2, 2018 at 6:16 PM, Jakub Kicinski wrote: On Tue, 2 Jan 2018 16:35:36 -0800, Sridhar Samudrala wrote: This patch series enables virtio to switch over to a VF datapath when a VF netdev is present with the same MAC

Re: [RFC PATCH] virtio_net: Extend virtio to use VF datapath when available

On 12/19/2017 2:53 PM, Stephen Hemminger wrote: On Tue, 19 Dec 2017 14:37:50 -0800 "Samudrala, Sridhar" <sridhar.samudr...@intel.com> wrote: On 12/19/2017 11:46 AM, Stephen Hemminger wrote: On Tue, 19 Dec 2017 11:42:33 -0800 "Samudrala, Sridhar" <sridhar.samudr..

Re: [RFC] hv_netvsc: automatically name slave VF network device

On 12/19/2017 11:35 AM, Stephen Hemminger wrote: Rename the VF device to ethX_vf based on the ethX as the synthetic device. This eliminates the need for delay on setup, and the PCI (udev based) naming is not reproducible on Hyper-V anyway. The name of the VF does not matter since all control

Re: [RFC PATCH] virtio_net: Extend virtio to use VF datapath when available

On 12/19/2017 11:46 AM, Stephen Hemminger wrote: On Tue, 19 Dec 2017 11:42:33 -0800 "Samudrala, Sridhar" <sridhar.samudr...@intel.com> wrote: On 12/19/2017 10:41 AM, Stephen Hemminger wrote: On Tue, 19 Dec 2017 13:21:17 -0500 (EST) David Miller <da...@davemloft.net> wr

  1   2   >