cleanup and unify command error handling")
> Signed-off-by: Arnd Bergmann
Thanks for the patch! And for reminding me that I forgot to enable
gcc warnings in CI builds in addition to sparse checks.
Reviewed-by: Sergey Matyukevich
Regards,
Sergey
t
> +static netdev_tx_t
> qtnf_netdev_hard_start_xmit(struct sk_buff *skb, struct net_device *ndev)
> {
> struct qtnf_vif *vif;
Previous ACK from Igor slipped through the cracks due to
outlook/exchange issues. So here is another one.
Reviewed-by: Sergey Matyukevich <sergey.matyukevich...@quantenna.com>
Thanks for the fix !
Regards,
Sergey
gned-off-by: Gustavo A. R. Silva <gust...@embeddedor.com>
> ---
> drivers/net/wireless/quantenna/qtnfmac/pearl/pcie.c | 4
> 1 file changed, 4 insertions(+)
Thanks for the patch!
Reviewed-by: Sergey Matyukevich <sergey.matyukevich...@quantenna.com>
Regards,
Sergey
vina...@quantenna.com>
> Cc: Sergey Matyukevich <smatyukev...@quantenna.com>
> Cc: Kalle Valo <kv...@codeaurora.org>
> Cc: Kamlesh Rath <kr...@quantenna.com>
> Cc: linux-wirel...@vger.kernel.org
> Cc: netdev@vger.kernel.org
> Signed-off-by: Kees Cook <k
Hi Johannes and all,
> > In a way this feature seems mis-designed - you never have 802.1Q tags
> > over the air, but you're inserting them on RX and stripping them on
> > TX, probably in order to make bridging to ethernet easier and not
> > have to have 802.1Q acceleration on the ethernet port,
rform anyway.
> In fact, the whole qtnf_pcie_init_dma_mask() function is nothing more
> than a rather long-winded implementation of dma_set_mask_and_coherent(),
> so let's just use that directly.
>
> Signed-off-by: Robin Murphy <robin.mur...@arm.com>
Nice, thanks yo
d qtnf_pcie_devid_table[] = {
> +static const struct pci_device_id qtnf_pcie_devid_table[] = {
> {
> PCIE_VENDOR_ID_QUANTENNA, PCIE_DEVICE_ID_QTN_PEARL,
> PCI_ANY_ID, PCI_ANY_ID, 0, 0,
> --
> 2.7.4
Thanks !
Reviewed-by: Sergey Matyukevich <sergey.matyukevich...@quantenna.com>
> Not related to your patch but qtnf_map_bar() should be changed not to
> return NULL. When functions return both NULL and error pointers the
> NULL is supposed to be a special type of success return. Here it is
> just a fail return where we forgot to set the error code to
> ERR_PTR(-ENOMEM).
*mac = mac = wiphy_priv(vif->wdev.wiphy);
> + struct qtnf_wmac *mac = wiphy_priv(vif->wdev.wiphy);
Thanks !
Acked-by: Sergey Matyukevich <sergey.matyukevich...@quantenna.com>
