Re: [Intel-wired-lan] [jkirsher/next-queue PATCH 3/5] ixgbe: Fix handling of macvlan Tx offload

On 11/2/2017 4:34 PM, Alexander Duyck wrote: From: Alexander Duyck This update makes it so that we report the actual number of Tx queues via real_num_tx_queues but are still restricted to RSS on only the first pool by setting num_tc equal to 1. Doing this locks us

Re: [jkirsher/next-queue PATCH v5 0/6] tc-flower based cloud filters in i40e

based on Shannon's comments. Authors: Amritha Nambiar <amritha.namb...@intel.com> Kiran Patil <kiran.pa...@intel.com> Anjali Singhai Jain <anjali.sing...@intel.com> Jingjing Wu <jingjing...@intel.com> Acked-by: Shannon Nelson <shannon.nel...@oracle.com> --- A

Re: [Intel-wired-lan] [jkirsher/next-queue PATCH v4 6/6] i40e: Enable cloud filters via tc-flower

On 10/26/2017 2:29 PM, Nambiar, Amritha wrote: On 10/11/2017 4:30 PM, Shannon Nelson wrote: On 10/10/2017 5:24 PM, Amritha Nambiar wrote: [...] + /* For Geneve, the VNI should be placed in offset shifted by a +* byte than the offset for the Tenant ID for rest

Re: [RFC PATCH 05/12] net: Create and use new helper xfrm_dst_child().

return dst->child; > +#endif > + return NULL; > +} > + -- == Mr. Shannon Nelson Parents can't afford to be squeamish.

Re: [Intel-wired-lan] [RFC PATCH next 2/2] i40e: add support for macvlan hardware offload

On 10/17/2017 2:32 PM, Alexander Duyck wrote: So the select_queue function being needed is the deal breaker on all of this as far as I am concerned. We aren't allowed to use it under other cases so why should macvlan be an exception to the rule? I realize that the stack is pretty good at

[RFC PATCH next 1/2] i40e: add ToQueue specific handling for mac filters

will use a non-zero queue. Signed-off-by: Shannon Nelson <shannon.nel...@oracle.com> --- drivers/net/ethernet/intel/i40e/i40e.h | 17 +++-- drivers/net/ethernet/intel/i40e/i40e_debugfs.c |4 +- drivers/net/ethernet/intel/i40e/i40e_main.c| 72 --- d

[RFC PATCH next 2/2] i40e: add support for macvlan hardware offload

the next macvlan devices are created on ethX, the macvlan driver will automatically attempt to setup the hardweare offload. Signed-off-by: Shannon Nelson <shannon.nel...@oracle.com> --- drivers/net/ethernet/intel/i40e/i40e.h | 10 + drivers/net/ethernet/intel/i40e/i40e_ethtool.c

[RFC PATCH next 0/2] Add support for macvlan offload

le testing. In the spirit of fail fast, I wanted to get this out quickly for comments and get the rework cycle started. Shannon Nelson (2): i40e: add ToQueue specific handling for mac filters i40e: add support for macvlan hardware offload drivers/net/ethernet/intel/i40e/i40e.h

Re: [PATCH 44/58] net: ethernet: sun: Convert timers to use timer_setup()

Philippe Reynes <trem...@gmail.com> Cc: Jarod Wilson <ja...@redhat.com> Cc: Shannon Nelson <shannon.nel...@oracle.com> Cc: Rob Herring <r...@kernel.org> Cc: chris hyser <chris.hy...@oracle.com> Cc: Tushar Dave <tushar.n.d...@oracle.com> Cc: Tobias Klauser <tkl

Re: [Intel-wired-lan] [jkirsher/next-queue PATCH v4 5/6] i40e: Clean up of cloud filters

On 10/10/2017 5:24 PM, Amritha Nambiar wrote: Introduce the cloud filter datastructure and cleanup of cloud filters associated with the device. v2: Moved field comments in struct i40e_cloud_filter to the right. Removed hlist_empty check from i40e_cloud_filter_exit() Signed-off-by: Amritha

Re: [Intel-wired-lan] [jkirsher/next-queue PATCH v4 4/6] i40e: Admin queue definitions for cloud filters

On 10/10/2017 5:24 PM, Amritha Nambiar wrote: Add new admin queue definitions and extended fields for cloud filter support. Define big buffer for extended general fields in Add/Remove Cloud filters command. v3: Shortened some lengthy struct names. v2: Added I40E_CHECK_STRUCT_LEN check to AQ

Re: [Intel-wired-lan] [jkirsher/next-queue PATCH v4 6/6] i40e: Enable cloud filters via tc-flower

On 10/10/2017 5:24 PM, Amritha Nambiar wrote: This patch enables tc-flower based hardware offloads. tc flower filter provided by the kernel is configured as driver specific cloud filter. The patch implements functions and admin queue commands needed to support cloud filters in the driver and

Re: [Intel-wired-lan] [jkirsher/next-queue PATCH v4 3/6] i40e: Cloud filter mode for set_switch_config command

On 10/10/2017 5:24 PM, Amritha Nambiar wrote: Add definitions for L4 filters and switch modes based on cloud filters modes and extend the set switch config command to include the additional cloud filter mode. Signed-off-by: Amritha Nambiar Signed-off-by: Kiran Patil

[PATCH] i40e: only redistribute MSI-X vectors when needed

. This restores an earlier check to be sure we only redistribute if we didn't get the full count we requested. Fixes: 4ce20abc645f (i40e: fix MSI-X vector redistribution if hw limit is reached) Signed-off-by: Shannon Nelson <shannon.nel...@oracle.com> --- drivers/net/ethernet/inte

Re: [Intel-wired-lan] [RFC PATCH v3 0/6] Configuring traffic classes via new hardware offload mechanism in tc/mqprio

On 9/7/2017 10:22 AM, Nambiar, Amritha wrote: On 9/7/2017 9:45 AM, Shannon Nelson wrote: [...] It would be nice to know what has changed since the last review, either summarized here or in the individual patch files. [...] For all those patch files that have changed since the last

Re: [Intel-wired-lan] [RFC PATCH v3 0/6] Configuring traffic classes via new hardware offload mechanism in tc/mqprio

On 9/7/2017 4:00 AM, Amritha Nambiar wrote: The following series introduces a new hardware offload mode in tc/mqprio where the TCs, the queue configurations and bandwidth rate limits are offloaded to the hardware. The existing mqprio framework is extended to configure the queue counts and layout

[PATCH net-next] ixgbe: restore normal RSS after last macvlan offload is removed

type macvlan mode bridge ip link set dev mv1 up ip link del mv1 ethtool -l eth1 # are we back to the same # of queues, or stuck on 1? Signed-off-by: Shannon Nelson <shannon.nel...@oracle.com> --- drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 11 +++ 1 files changed, 11 inse

Re: [net-next 15/15] i40e: synchronize nvmupdate command and adminq subtask

} Perhaps I missed a patch somewhere, but I think there is still a return statement in the middle of this switch() (INIT_WAIT and WRITE_WAIT) that means you can leave the mutex locked. I thought I had seen a newer version of this patch that had this fixed sln > + mutex_unlock(>aq.arq_mutex); > return status; > } > > -- > 2.14.0 > -- == Mr. Shannon Nelson Parents can't afford to be squeamish.

Re: [Intel-wired-lan] [PATCH net-next RFC 0/6] Configure cloud filters in i40e via tc/flower classifier

If this is an RFC patchset, then all the patches should have RFC in them. On 7/31/2017 5:36 PM, Amritha Nambiar wrote: This patch series enables configuring cloud filters in i40e using the tc/flower classifier. The only tc-filter action supported is to redirect packets to a traffic class on the

Re: [Intel-wired-lan] [PATCH 6/6] [net-next]net: i40e: Enable cloud filters in i40e via tc/flower classifier

On 7/31/2017 5:38 PM, Amritha Nambiar wrote: This patch enables tc-flower based hardware offloads. tc/flower filter provided by the kernel is configured as driver specific cloud filter. The patch implements functions and admin queue commands needed to support cloud filters in the driver and adds

Re: [Intel-wired-lan] [PATCH 5/6] [net-next]net: i40e: Clean up of cloud filters

On 7/31/2017 5:38 PM, Amritha Nambiar wrote: Introduce the cloud filter datastructure and cleanup of cloud filters associated with the device. Signed-off-by: Amritha Nambiar --- drivers/net/ethernet/intel/i40e/i40e.h | 11 +++

Re: [Intel-wired-lan] [PATCH 4/6] [net-next]net: i40e: Admin queue definitions for cloud filters

On 7/31/2017 5:37 PM, Amritha Nambiar wrote: Add new admin queue definitions and extended fields for cloud filter support. Define big buffer for extended general fields in Add/Remove Cloud filters command. Signed-off-by: Amritha Nambiar Signed-off-by: Kiran Patil

[PATCH net-next] i40e: limit lan queue count in large cpu count machine

some left for FD and other features. Signed-off-by: Shannon Nelson <shannon.nel...@oracle.com> --- drivers/net/ethernet/intel/i40e/i40e_main.c | 11 +++ 1 files changed, 7 insertions(+), 4 deletions(-) diff --git a/drivers/net/ethernet/intel/i40e/i40e_main.c b/drivers/net/ethernet

[PATCH net-next] sunvnet: add support for IPv6 checksum offloads

The original code didn't handle non-IPv4 packets very well, so the offload advertising had to be scaled back down to just IP. Here we add the bits needed to support TCP and UDP packets over IPv6 and turn the offload advertising back on. Orabug: 26289579 Signed-off-by: Shannon Nelson

Re: [PATCH net-next 2/2] sunvnet: implement basic ethtool get_settings

On 6/21/2017 12:06 PM, David Miller wrote: From: Shannon Nelson <shannon.nel...@oracle.com> Date: Wed, 21 Jun 2017 09:09:54 -0700 Add the get_settings callback so that both the ldmvsw and sunvnet drivers will give a little more information when asked for its basic settings. These

Re: [PATCH net-next 1/2] ldmvsw: add vio version and remote-mac to ethtool info

On 6/21/2017 12:05 PM, David Miller wrote: From: Shannon Nelson <shannon.nel...@oracle.com> Date: Wed, 21 Jun 2017 09:09:53 -0700 In the ethtool -i output print the vio version and the remote-mac of the ldom that the vif device is serving as this vif info is not exposed elsewhere. The

[PATCH net-next 1/2] ldmvsw: add vio version and remote-mac to ethtool info

In the ethtool -i output print the vio version and the remote-mac of the ldom that the vif device is serving as this vif info is not exposed elsewhere. The remote-mac address is most useful for tracking which client ldom is being served by the vif. Orabug: 26316362 Signed-off-by: Shannon Nelson

[PATCH net-next 2/2] sunvnet: implement basic ethtool get_settings

readable, which makes a couple of the ldom management tools happier. Orabug: 26175474 Signed-off-by: Shannon Nelson <shannon.nel...@oracle.com> --- drivers/net/ethernet/sun/ldmvsw.c |1 + drivers/net/ethernet/sun/sunvnet.c|1 + drivers/net/ethernet/sun/sunvnet_common.c

[PATCH net-next 0/2] sunvnet: add to ethtool data

specific example is that the /sys/class/net//speed attribute becomes readable. Shannon Nelson (2): ldmvsw: add vio version and remote-mac to ethtool info sunvnet: implement basic ethtool get_settings drivers/net/ethernet/sun/ldmvsw.c |8 drivers/net/ethernet/sun/sunvnet.c

Re: [PATCH net-next] sunvnet: restrict advertized checksum offloads to just IP

On 6/15/2017 11:23 AM, David Miller wrote: Applied, but this bug must be fixed properly and ipv6 checksumming properly supported. Thanks. Understood - we just wanted first to stop the bleeding while we think about how to do this right. Thanks, sln

[PATCH net-next] sunvnet: restrict advertized checksum offloads to just IP

we can't yet do. Orabug: 26175391, 26259755 Signed-off-by: Shannon Nelson <shannon.nel...@oracle.com> --- drivers/net/ethernet/sun/ldmvsw.c |2 +- drivers/net/ethernet/sun/sunvnet.c |2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/sun/ld

[PATCH net-next 2/2] ldmvsw: stop the clean timer at beginning of remove

Stop the clean timer earlier to be sure there's no asynchronous interference while stopping the port. Orabug: 25748241 Signed-off-by: Shannon Nelson <shannon.nel...@oracle.com> --- drivers/net/ethernet/sun/ldmvsw.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff

[PATCH net-next 0/2] ldmvsw: port removal stability

Under heavy reboot stress testing we found a couple of timing issues when removing the device that could cause the kernel great heartburn, addressed by these two patches. Shannon Nelson (1): ldmvsw: stop the clean timer at beginning of remove Thomas Tai (1): ldmvsw: unregistering netdev

[PATCH net-next 1/2] ldmvsw: unregistering netdev before disable hardware

omas@oracle.com> Signed-off-by: Shannon Nelson <shannon.nel...@oracle.com> --- drivers/net/ethernet/sun/ldmvsw.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/net/ethernet/sun/ldmvsw.c b/drivers/net/ethernet/sun/ldmvsw.c index 5a90fed..309747c 10064

[PATCH v2 net-next] bnxt: add dma mapping attributes

On the SPARC platform we need to use the DMA_ATTR_WEAK_ORDERING attribute in our Rx path dma mapping in order to get the expected performance out of the receive path. Adding it to the Tx path has little effect, so that's not a part of this patch. Signed-off-by: Shannon Nelson <shannon.

Re: [PATCH net-next] bnxt: add dma mapping attributes

On 5/9/2017 5:49 PM, David Miller wrote: From: Shannon Nelson <shannon.nel...@oracle.com> Date: Tue, 9 May 2017 13:37:33 -0700 @@ -66,6 +66,12 @@ MODULE_DESCRIPTION("Broadcom BCM573xx network driver"); MODULE_VERSION(DRV_MODULE_VERSION); +#ifdef CONFIG_SPARC +#defin

Re: [PATCH net-next] bnxt: add dma mapping attributes

On 5/9/2017 2:05 PM, Michael Chan wrote: On Tue, May 9, 2017 at 1:37 PM, Shannon Nelson <shannon.nel...@oracle.com> wrote: On the SPARC platform we need to use the DMA_ATTR_WEAK_ORDERING attribute in our Rx path dma mapping in order to get the expected performance out of the receiv

[PATCH net-next] bnxt: add dma mapping attributes

On the SPARC platform we need to use the DMA_ATTR_WEAK_ORDERING attribute in our Rx path dma mapping in order to get the expected performance out of the receive path. Adding it to the Tx path has little effect, so that's not a part of this patch. Signed-off-by: Shannon Nelson <shannon.

Re: [PATCH v2 net-next 4/5] sunvnet: count multicast packets

On 3/15/2017 1:50 AM, David Laight wrote: From: Shannon Nelson Sent: 14 March 2017 17:25 ... + if (unlikely(is_multicast_ether_addr(eth_hdr(skb)->h_dest))) + dev->stats.multicast++; I'd guess that: dev->stats.multicast += is_multicast_ether_addr(et

[PATCH v2 net-next 1/5] ldmvsw: better use of link up and down on ldom vswitch

the underlying LDC protocol. Similarly, we take the link down when we see the LDC_EVENT_RESET. Now when we see the ndo_open(), we reset the link to get things talking again. Orabug: 25525312 Signed-off-by: Shannon Nelson <shannon.nel...@oracle.com> --- drivers/net/ethernet/sun/ldmvsw.c

[PATCH v2 net-next 3/5] sunvnet: track port queues correctly

Track our used and unused queue indexies correctly. Otherwise, as ports dropped out and returned, they all eventually ended up with the same queue index. Orabug: 25190537 Signed-off-by: Shannon Nelson <shannon.nel...@oracle.com> --- drivers/net/ethernet/sun/sunvnet_common.c

[PATCH v2 net-next 2/5] sunvnet: add stats to track ldom to ldom packets and bytes

dual queue/port stats. This patch breaks out the traffic counts for the individual ports and gives us a little view into the state of those connections. Orabug: 25190537 Signed-off-by: Shannon Nelson <shannon.nel...@oracle.com> --- drivers/net/ethernet/sun/sunvnet

[PATCH v2 net-next 4/5] sunvnet: count multicast packets

Make sure multicast packets get counted in the device. Orabug: 25190537 Signed-off-by: Shannon Nelson <shannon.nel...@oracle.com> --- drivers/net/ethernet/sun/sunvnet_common.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/drivers/net/ethernet/sun/sunvnet_commo

[PATCH v2 net-next 5/5] sunvnet: xoff not needed when removing port link

e driver's tx_timeout handler. Simply removing these takes care of the problem. Orabug: 25190537 Signed-off-by: Shannon Nelson <shannon.nel...@oracle.com> --- drivers/net/ethernet/sun/sunvnet_common.c |4 1 files changed, 0 insertions(+), 4 deletions(-) diff --git a/drivers/

[PATCH v2 net-next 0/5] sunvnet: better connection management

These patches remove some problems in handling of carrier state with the ldmvsw vswitch, remove an xoff misuse in sunvnet, and add stats for debug and tracking of point-to-point connections between the ldom VMs. v2: - added ldmvsw ndo_open to reset the LDC channel - updated copyrights Shannon

Re: [PATCH net-next 0/5] sunvnet: better connection management

On 3/6/2017 3:15 PM, Shannon Nelson wrote: These patches remove some problems in handling of carrier state with the ldmvsw vswitch, remove an xoff misuse in sunvnet, and add stats for debug and tracking of point-to-point connections between the ldom VMs. Further testing shows a problem in one

Re: [PATCH net-next 1/5] ldmvsw: better use of link up and down on ldom vswitch

On 3/6/2017 3:53 PM, Florian Fainelli wrote: On 03/06/2017 03:15 PM, Shannon Nelson wrote: When an ldom VM is bound, the network vswitch infrastructure is set up for it, but was being forced 'UP' by the userland switch configuration script. When 'UP' but not actually connected to a running VM

[PATCH net-next 0/5] sunvnet: better connection management

These patches remove some problems in handling of carrier state with the ldmvsw vswitch, remove an xoff misuse in sunvnet, and add stats for debug and tracking of point-to-point connections between the ldom VMs. Shannon Nelson (5): ldmvsw: better use of link up and down on ldom vswitch

[PATCH net-next 4/5] sunvnet: count multicast packets

Make sure multicast packets get counted in the device. Signed-off-by: Shannon Nelson <shannon.nel...@oracle.com> --- drivers/net/ethernet/sun/sunvnet_common.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/drivers/net/ethernet/sun/sunvnet_common.c b/drive

[PATCH net-next 2/5] sunvnet: add stats to track ldom to ldom packets and bytes

dual queue/port stats. This patch breaks out the traffic counts for the individual ports and gives us a little view into the state of those connections. Signed-off-by: Shannon Nelson <shannon.nel...@oracle.com> --- drivers/net/ethernet/sun/sunvnet.c| 114 ++

[PATCH net-next 5/5] sunvnet: xoff not needed when removing port link

e driver's tx_timeout handler. Simply removing these takes care of the problem. Orabug: 25190537 Signed-off-by: Shannon Nelson <shannon.nel...@oracle.com> --- drivers/net/ethernet/sun/sunvnet_common.c |4 1 files changed, 0 insertions(+), 4 deletions(-) diff --git a/drivers/

[PATCH net-next 1/5] ldmvsw: better use of link up and down on ldom vswitch

the underlying LDC protocol. Similarly, we take the link down when we see the LDC_EVENT_RESET. Orabug: 25525312 Signed-off-by: Shannon Nelson <shannon.nel...@oracle.com> --- drivers/net/ethernet/sun/ldmvsw.c | 10 +++--- drivers/net/ethernet/sun/sunvnet_common.c | 14 +++

[PATCH net-next 3/5] sunvnet: track port queues correctly

Track our used and unused queue indices correctly. Otherwise, as ports dropped out and returned, they all eventually ended up with the same queue index. Signed-off-by: Shannon Nelson <shannon.nel...@oracle.com> --- drivers/net/ethernet/sun/sunvnet_common.c

Re: [PATCH v4 net-next 5/8] sunvnet: straighten up message event handling logic

On 2/13/2017 11:06 AM, Joe Perches wrote: On Mon, 2017-02-13 at 10:57 -0800, Shannon Nelson wrote: The use of gotos for handling the incoming events made this code harder to read and support than it should be. This patch straightens out and clears up the logic. Signed-off-by: Shannon Nelson

[PATCH v4 net-next 0/8] sunvnet driver updates

module doesn't need module_init or _exit v4: - dropped the statistics patch - fixed up "default" tag for SUNVNET_COMMON Shannon Nelson (7): sunvnet: make sunvnet common code dynamically loadable sunvnet: update version and version printing sunvnet: add memory barrier before ch

[PATCH v4 net-next 2/8] sunvnet: remove unused variable in maybe_tx_wakeup

nother START message at the next TX and trigger the consumer to drain the dring. Signed-off-by: Sowmini Varadhan <sowmini.varad...@oracle.com> Signed-off-by: Shannon Nelson <shannon.nel...@oracle.com> --- drivers/net/ethernet/sun/sunvnet_common.c |6 +- 1 files changed,

[PATCH v4 net-next 1/8] sunvnet: make sunvnet common code dynamically loadable

in kernels that aren't running the LDoms. This patch makes the sunvnet_common into a dynamically loadable module and makes sunvnet and ldmvsw dependent on sunvnet_common. Signed-off-by: Shannon Nelson <shannon.nel...@oracle.com> --- drivers/net/ethernet/sun/Kconfig |8 ++-- drive

[PATCH v4 net-next 3/8] sunvnet: update version and version printing

There have been several changes since the first version of this code, so we bump the version number. While we're at it, we can simplify the version printing a bit and drop a couple lines of code. Signed-off-by: Shannon Nelson <shannon.nel...@oracle.com> --- drivers/net/ethernet/sun/sun

[PATCH v4 net-next 4/8] sunvnet: add memory barrier before check for tx enable

In order to allow the underlying LDC and outstanding memory operations to potentially catch up with the driver's Tx requests, add a memory barrier before checking again for available tx descriptors. Signed-off-by: Shannon Nelson <shannon.nel...@oracle.com> --- drivers/net/ethern

[PATCH v4 net-next 5/8] sunvnet: straighten up message event handling logic

The use of gotos for handling the incoming events made this code harder to read and support than it should be. This patch straightens out and clears up the logic. Signed-off-by: Shannon Nelson <shannon.nel...@oracle.com> --- drivers/net/ethernet/sun/sunvnet_common.c

[PATCH v4 net-next 7/8] ldmvsw: update and simplify version string

New version and simplify the print code. Signed-off-by: Shannon Nelson <shannon.nel...@oracle.com> --- drivers/net/ethernet/sun/ldmvsw.c | 14 -- 1 files changed, 4 insertions(+), 10 deletions(-) diff --git a/drivers/net/ethernet/sun/ldmvsw.c b/drivers/net/ethernet/sun/ld

[PATCH v4 net-next 8/8] ldmvsw: disable tso and gso for bridge operations

by delayed packets, enough to begin triggering retransmits and affecting overall throughput. By turning off advertised support for TSO and GSO we restore stable traffic flow through the bridge. Orabug: 23293104 Signed-off-by: Shannon Nelson <shannon.nel...@oracle.com> --- drivers/net/ethern

[PATCH v4 net-next 6/8] sunvnet: remove extra rcu_read_unlocks

ahe...@oracle.com> Signed-off-by: Shannon Nelson <shannon.nel...@oracle.com> --- drivers/net/ethernet/sun/sunvnet_common.c |8 ++-- 1 files changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/net/ethernet/sun/sunvnet_common.c b/drivers/net/ethernet/sun/sunvnet_common.c i

Re: [PATCH v3 net-next 1/9] sunvnet: make sunvnet common code dynamically loadable

On 2/12/2017 3:16 AM, Sergei Shtylyov wrote: Hello! On 2/10/2017 8:38 PM, Shannon Nelson wrote: When the sunvnet_common code was split out for use by both sunvnet and the newer ldmvsw, it was made into a static kernel library, which limits the usefulness of sunvnet and ldmvsw as loadables

Re: [PATCH v3 net-next 4/9] sunvnet: add driver stats for ethtool support

On 2/11/2017 6:01 PM, David Miller wrote: From: Stephen Hemminger <step...@networkplumber.org> Date: Fri, 10 Feb 2017 16:22:08 -0800 On Fri, 10 Feb 2017 09:38:20 -0800 Shannon Nelson <shannon.nel...@oracle.com> wrote: +static void vsw_get_ethtool_stats(struct net

[PATCH v3 net-next 1/9] sunvnet: make sunvnet common code dynamically loadable

in kernels that aren't running the LDoms. This patch makes the sunvnet_common into a dynamically loadable module and makes sunvnet and ldmvsw dependent on sunvnet_common. Signed-off-by: Shannon Nelson <shannon.nel...@oracle.com> --- drivers/net/ethernet/sun/Kconfig |8 ++-- drive

[PATCH v3 net-next 6/9] sunvnet: straighten up message event handling logic

The use of gotos for handling the incoming events made this code harder to read and support than it should be. This patch straightens out and clears up the logic. Signed-off-by: Shannon Nelson <shannon.nel...@oracle.com> --- drivers/net/ethernet/sun/sunvnet_common.c

[PATCH v3 net-next 9/9] ldmvsw: disable tso and gso for bridge operations

by delayed packets, enough to begin triggering retransmits and affecting overall throughput. By turning off advertised support for TSO and GSO we restore stable traffic flow through the bridge. Orabug: 23293104 Signed-off-by: Shannon Nelson <shannon.nel...@oracle.com> --- drivers/net/ethern

[PATCH v3 net-next 0/9] sunvnet driver updates

module doesn't need module_init or _exit Shannon Nelson (8): sunvnet: make sunvnet common code dynamically loadable sunvnet: update version and version printing sunvnet: add driver stats for ethtool support sunvnet: add memory barrier before check for tx enable sunvnet: straighten up

[PATCH v3 net-next 8/9] ldmvsw: update and simplify version string

New version and simplify the print code. Signed-off-by: Shannon Nelson <shannon.nel...@oracle.com> --- drivers/net/ethernet/sun/ldmvsw.c | 14 -- 1 files changed, 4 insertions(+), 10 deletions(-) diff --git a/drivers/net/ethernet/sun/ldmvsw.c b/drivers/net/ethernet/sun/ld

[PATCH v3 net-next 7/9] sunvnet: remove extra rcu_read_unlocks

ahe...@oracle.com> Signed-off-by: Shannon Nelson <shannon.nel...@oracle.com> --- drivers/net/ethernet/sun/sunvnet_common.c |8 ++-- 1 files changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/net/ethernet/sun/sunvnet_common.c b/drivers/net/ethernet/sun/sunvnet_common.c i

[PATCH v3 net-next 2/9] sunvnet: remove unused variable in maybe_tx_wakeup

nother START message at the next TX and trigger the consumer to drain the dring. Signed-off-by: Sowmini Varadhan <sowmini.varad...@oracle.com> Signed-off-by: Shannon Nelson <shannon.nel...@oracle.com> --- drivers/net/ethernet/sun/sunvnet_common.c |6 +- 1 files changed,

[PATCH v3 net-next 4/9] sunvnet: add driver stats for ethtool support

Since we're collecting some stats in the driver code, let's support use of the ethtool driver stats facility in both sunvnet and ldmvsw. Signed-off-by: Shannon Nelson <shannon.nel...@oracle.com> --- drivers/net/ethernet/sun/ldmvsw.c | 63 + drive

[PATCH v3 net-next 3/9] sunvnet: update version and version printing

There have been several changes since the first version of this code, so we bump the version number. While we're at it, we can simplify the version printing a bit and drop a couple lines of code. Signed-off-by: Shannon Nelson <shannon.nel...@oracle.com> --- drivers/net/ethernet/sun/sun

[PATCH v3 net-next 5/9] sunvnet: add memory barrier before check for tx enable

In order to allow the underlying LDC and outstanding memory operations to potentially catch up with the driver's Tx requests, add a memory barrier before checking again for available tx descriptors. Signed-off-by: Shannon Nelson <shannon.nel...@oracle.com> --- drivers/net/ethern

Re: [PATCH v2 net-next 1/9] sunvnet: make sunvnet common code dynamically loadable

On 2/8/2017 11:29 AM, David Miller wrote: From: Shannon Nelson <shannon.nel...@oracle.com> Date: Tue, 7 Feb 2017 14:12:54 -0800 +static int __init sunvnet_common_init(void) +{ + pr_info("%s\n", version); + return 0; +} +module_init(sunvnet_common_init); + +st

Re: [PATCH v2 net-next 6/9] sunvnet: straighten up message event handling logic

On 2/8/2017 7:59 AM, Sowmini Varadhan wrote: On (02/07/17 14:12), Shannon Nelson wrote: + + /* we don't expect any other bits */ + BUG_ON(port->rx_event & ~(LDC_EVENT_DATA_READY | + LDC_EVENT_RESET | + LDC_E

[PATCH v2 net-next 7/9] sunvnet: remove extra rcu_read_unlocks

ahe...@oracle.com> Signed-off-by: Shannon Nelson <shannon.nel...@oracle.com> --- drivers/net/ethernet/sun/sunvnet_common.c |8 ++-- 1 files changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/net/ethernet/sun/sunvnet_common.c b/drivers/net/ethernet/sun/sunvnet_common.c i

[PATCH v2 net-next 2/9] sunvnet: remove unused variable in maybe_tx_wakeup

nother START message at the next TX and trigger the consumer to drain the dring. Signed-off-by: Sowmini Varadhan <sowmini.varad...@oracle.com> Signed-off-by: Shannon Nelson <shannon.nel...@oracle.com> --- drivers/net/ethernet/sun/sunvnet_common.c |6 +- 1 files changed,

[PATCH v2 net-next 6/9] sunvnet: straighten up message event handling logic

The use of gotos for handling the incoming events made this code harder to read and support than it should be. This patch straightens out and clears up the logic. Signed-off-by: Shannon Nelson <shannon.nel...@oracle.com> --- drivers/net/ethernet/sun/sunvnet_common.c

[PATCH v2 net-next 1/9] sunvnet: make sunvnet common code dynamically loadable

in kernels that aren't running the LDoms. This patch makes the sunvnet_common into a dynamically loadable module and makes sunvnet and ldmvsw dependent on sunvnet_common. Signed-off-by: Shannon Nelson <shannon.nel...@oracle.com> --- drivers/net/ethernet/sun/Kconfig |8 ++-- drive

[PATCH v2 net-next 9/9] ldmvsw: disable tso and gso for bridge operations

by delayed packets, enough to begin triggering retransmits and affecting overall throughput. By turning off advertised support for TSO and GSO we restore stable traffic flow through the bridge. Orabug: 23293104 Signed-off-by: Shannon Nelson <shannon.nel...@oracle.com> --- drivers/net/ethern

[PATCH v2 net-next 5/9] sunvnet: add memory barrier before check for tx enable

In order to allow the underlying LDC and outstanding memory operations to potentially catch up with the driver's Tx requests, add a memory barrier before checking again for available tx descriptors. Signed-off-by: Shannon Nelson <shannon.nel...@oracle.com> --- drivers/net/ethern

[PATCH v2 net-next 4/9] sunvnet: add driver stats for ethtool support

Since we're collecting some stats in the driver code, let's support use of the ethtool driver stats facility in both sunvnet and ldmvsw. Signed-off-by: Shannon Nelson <shannon.nel...@oracle.com> --- drivers/net/ethernet/sun/ldmvsw.c | 63 + drive

[PATCH v2 net-next 0/9] sunvnet driver updates

The sunvnet ldom virtual network driver was due for some updates and a bugfix or two. These patches address a few items left over from last year's make-over. v2: - changed memory barrier fix to use smp_wmb - put NETIF_F_SG back into the advertised ldmvsw hw_features Shannon Nelson (8

[PATCH v2 net-next 8/9] ldmvsw: update and simplify version string

New version and simplify the print code. Signed-off-by: Shannon Nelson <shannon.nel...@oracle.com> --- drivers/net/ethernet/sun/ldmvsw.c | 14 -- 1 files changed, 4 insertions(+), 10 deletions(-) diff --git a/drivers/net/ethernet/sun/ldmvsw.c b/drivers/net/ethernet/sun/ld

[PATCH v2 net-next 3/9] sunvnet: update version and version printing

There have been several changes since the first version of this code, so we bump the version number. While we're at it, we can simplify the version printing a bit and drop a couple lines of code. Signed-off-by: Shannon Nelson <shannon.nel...@oracle.com> --- drivers/net/ethernet/sun/sun

Re: [PATCH net-next 5/9] sunvnet: add memory barrier before check for tx enable

On 2/3/2017 2:11 PM, Eric Dumazet wrote: Transmit completion might happen on another cpu, regardless of ldom. Therefore you need smp_rmb() here ( like mellanox/mlx4/en_tx.c) , or even smp_mb() as bnx2x does. dma_rmb() is never used in this context. In that case, it looks like there are a

Re: [PATCH net-next 9/9] ldmvsw: disable tso and gso for bridge operations

On 2/3/2017 9:59 AM, Eric Dumazet wrote: On Fri, 2017-02-03 at 09:42 -0800, Shannon Nelson wrote: The ldmvsw driver is specifically for supporting the ldom virtual networking by running in the primary ldom and using the LDC to connect the remaining ldoms to the outside world via a bridge

Re: [PATCH net-next 5/9] sunvnet: add memory barrier before check for tx enable

On 2/3/2017 9:56 AM, Eric Dumazet wrote: On Fri, 2017-02-03 at 09:42 -0800, Shannon Nelson wrote: In order to allow the underlying LDC and outstanding memory operations to potentially catch up with the driver's Tx requests, add a memory barrier before checking again for available tx descriptors

[PATCH net-next 9/9] ldmvsw: disable tso and gso for bridge operations

by delayed packets, enough to begin triggering retransmits and affecting overall throughput. By turning off advertised support for TSO and GSO we restore stable traffic flow through the bridge. Orabug: 23293104 Signed-off-by: Shannon Nelson <shannon.nel...@oracle.com> --- drivers/net/ethern

[PATCH net-next 7/9] sunvnet: remove extra rcu_read_unlocks

ahe...@oracle.com> Signed-off-by: Shannon Nelson <shannon.nel...@oracle.com> --- drivers/net/ethernet/sun/sunvnet_common.c |8 ++-- 1 files changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/net/ethernet/sun/sunvnet_common.c b/drivers/net/ethernet/sun/sunvnet_common.c i

[PATCH net-next 1/9] sunvnet: make sunvnet common code dynamically loadable

in kernels that aren't running the LDoms. This patch makes the sunvnet_common into a dynamically loadable module and makes sunvnet and ldmvsw dependent on sunvnet_common. Signed-off-by: Shannon Nelson <shannon.nel...@oracle.com> --- drivers/net/ethernet/sun/Kconfig |9 ++--- drive

[PATCH net-next 6/9] sunvnet: straighten up message event handling logic

The use of gotos for handling the incoming events made this code harder to read and support than it should be. This patch straightens out and clears up the logic. Signed-off-by: Shannon Nelson <shannon.nel...@oracle.com> --- drivers/net/ethernet/sun/sunvnet_common.c

[PATCH net-next 4/9] sunvnet: add driver stats for ethtool support

Since we're collecting some stats in the driver code, let's support use of the ethtool driver stats facility in both sunvnet and ldmvsw. Signed-off-by: Shannon Nelson <shannon.nel...@oracle.com> --- drivers/net/ethernet/sun/ldmvsw.c | 63 + drive

[PATCH net-next 3/9] sunvnet: update version and version printing

There have been several changes since the first version of this code, so we bump the version number. While we're at it, we can simplify the version printing a bit and drop a couple lines of code. Signed-off-by: Shannon Nelson <shannon.nel...@oracle.com> --- drivers/net/ethernet/sun/sun

[PATCH net-next 8/9] ldmvsw: update and simplify version string

New version and simplify the print code. Signed-off-by: Shannon Nelson <shannon.nel...@oracle.com> --- drivers/net/ethernet/sun/ldmvsw.c | 14 -- 1 files changed, 4 insertions(+), 10 deletions(-) diff --git a/drivers/net/ethernet/sun/ldmvsw.c b/drivers/net/ethernet/sun/ld

[PATCH net-next 5/9] sunvnet: add memory barrier before check for tx enable

In order to allow the underlying LDC and outstanding memory operations to potentially catch up with the driver's Tx requests, add a memory barrier before checking again for available tx descriptors. Signed-off-by: Shannon Nelson <shannon.nel...@oracle.com> --- drivers/net/ethern

[PATCH net-next 0/9] sunvnet driver updates

The sunvnet ldom virtual network driver was due for some updates and a bugfix or two. These patches address a few items left over from last year's make-over. Shannon Nelson (8): sunvnet: make sunvnet common code dynamically loadable sunvnet: update version and version printing sunvnet: add

[PATCH net-next 2/9] sunvnet: remove unused variable in maybe_tx_wakeup

nother START message at the next TX and trigger the consumer to drain the dring. Signed-off-by: Sowmini Varadhan <sowmini.varad...@oracle.com> Signed-off-by: Shannon Nelson <shannon.nel...@oracle.com> --- drivers/net/ethernet/sun/sunvnet_common.c |6 +- 1 files changed,

<    1   2   3   4   >