Re: [PATCH x86/urgent] bpf: emulate push insns for uprobe on x86

On 11/8/17 4:06 PM, David Miller wrote: From: Yonghong Song <y...@fb.com> Date: Wed, 8 Nov 2017 13:37:12 -0800 Uprobe is a tracing mechanism for userspace programs. Typical uprobe will incur overhead of two traps. First trap is caused by replaced trap insn, and the second trap is to e

[PATCH x86/urgent] bpf: emulate push insns for uprobe on x86

1.754.0 You can see that this patch significantly reduced the overhead, 50% for uprobe and 44% for uretprobe on x86_64, and even more on x86_32. Signed-off-by: Yonghong Song <y...@fb.com> --- arch/x86/include/asm/uprobes.h | 10 arch/x86/kernel/uprobes.c | 115 +++

[RFC 2/6] perf: copy new perf_event.h to tools/include/uapi

perf_event.h is updated in previous patch, this patch applies same changes to the tools/ version. This is part is put in a separate patch in case the two files are back ported separately. Signed-off-by: Song Liu <songliubrav...@fb.com> Reviewed-by: Yonghong Song <y...@fb.com> Review

[RFC 6/6] bpf: add new test test_many_kprobe

) takes 5.077558 seconds Cleaning 1000 kprobes with PERF_TYPE_PROBE (function name) takes 81.241354 seconds Creating 1000 kprobes with PERF_TYPE_PROBE (function addr) takes 5.218255 seconds Cleaning 1000 kprobes with PERF_TYPE_PROBE (function addr) takes 80.010731 seconds Signed-off-by: Song Liu

[RFC] bcc: Try use new API to create [k,u]probe with perf_event_open

New kernel API allows creating [k,u]probe with perf_event_open. This patch tries to use the new API. If the new API doesn't work, we fall back to old API. bpf_detach_probe() looks up the event being removed. If the event is not found, we skip the clean up procedure. Signed-off-by: Song Liu

[RFC 1/6] perf: Add new type PERF_TYPE_PROBE

with the pointer, we will (in the following patches) copy probe_desc to __aligned_u64 before using it as pointer. Signed-off-by: Song Liu <songliubrav...@fb.com> Reviewed-by: Yonghong Song <y...@fb.com> Reviewed-by: Josef Bacik <jba...@fb.com> Acked-by: Alexei Starovoitov <a...@kernel.o

[RFC 4/6] perf: implement uprobe support to PERF_TYPE_PROBE

-by: Song Liu <songliubrav...@fb.com> Reviewed-by: Yonghong Song <y...@fb.com> Reviewed-by: Josef Bacik <jba...@fb.com> --- kernel/trace/trace_event_perf.c | 33 ++- kernel/trace/trace_probe.h | 4 ++ kernel/trace/trace_uprobe.c | 90 ++

[RFC 0/6] enable creating [k,u]probe with perf_event_open

ub.com/liu-song-6/bcc/tree/new_perf_event_opn Thanks, Song man-pages patch: perf_event_open.2: add new type PERF_TYPE_PROBE bcc patch: bcc: Try use new API to create [k,u]probe with perf_event_open kernel patches: Song Liu (6): perf: Add new type PERF_TYPE_PROBE perf: copy new perf_event.

[RFC] perf_event_open.2: add new type PERF_TYPE_PROBE

are not included in this patch. write_backward : 1 namespaces : 1 Signed-off-by: Song Liu <songliubrav...@fb.com> --- man2/perf_event_open.2 | 82 -- 1 file changed, 80 insertions(+), 2 deletions(-) diff --git

[RFC 5/6] bpf: add option for bpf_load.c to use PERF_TYPE_PROBE

Function load_and_attach() is updated to be able to create kprobes with either old text based API, or the new PERF_TYPE_PROBE API. A global flag use_perf_type_probe is added to select between the two APIs. Signed-off-by: Song Liu <songliubrav...@fb.com> Reviewed-by: Josef Bacik <jba.

[RFC 3/6] perf: implement kprobe support to PERF_TYPE_PROBE

, create_local_trace_kprobe() and destroy_local_trace_kprobe() are added to created and destroy these local trace_kprobe. Signed-off-by: Song Liu <songliubrav...@fb.com> Reviewed-by: Yonghong Song <y...@fb.com> Reviewed-by: Josef Bacik <jba...@fb.com> --- include/linux/trace_events.h|

Re: [RFC PATCH] bpf: Add helpers to read useful task_struct members

On Tue, Nov 7, 2017 at 4:29 PM, Atish Patra <atish.pa...@oracle.com> wrote: > On 11/07/2017 04:42 PM, Y Song wrote: >> >> On Tue, Nov 7, 2017 at 2:04 PM, Alexei Starovoitov <a...@fb.com> wrote: >>> >>> On 11/8/17 6:47 AM, Y Song wrote: >>

Re: [RFC PATCH] bpf: Add helpers to read useful task_struct members

On Tue, Nov 7, 2017 at 2:04 PM, Alexei Starovoitov <a...@fb.com> wrote: > On 11/8/17 6:47 AM, Y Song wrote: >> >> On Tue, Nov 7, 2017 at 1:39 PM, Alexei Starovoitov <a...@fb.com> wrote: >>> >>> On 11/8/17 6:14 AM, Y Song wrote: >>>>

Re: [RFC PATCH] bpf: Add helpers to read useful task_struct members

On Tue, Nov 7, 2017 at 1:39 PM, Alexei Starovoitov <a...@fb.com> wrote: > On 11/8/17 6:14 AM, Y Song wrote: >> >> On Tue, Nov 7, 2017 at 12:37 AM, Naveen N. Rao >> <naveen.n@linux.vnet.ibm.com> wrote: >>> >>> Alexei Starovoitov wrote: >

Re: [RFC PATCH] bpf: Add helpers to read useful task_struct members

On Tue, Nov 7, 2017 at 1:31 PM, Atish Patra <atish.pa...@oracle.com> wrote: > On 11/07/2017 03:14 PM, Y Song wrote: >> >> On Tue, Nov 7, 2017 at 12:37 AM, Naveen N. Rao >> <naveen.n@linux.vnet.ibm.com> wrote: >>> >>> Alexei Starovoitov wrote

Re: [RFC PATCH] bpf: Add helpers to read useful task_struct members

On Tue, Nov 7, 2017 at 12:37 AM, Naveen N. Rao wrote: > Alexei Starovoitov wrote: >> >> On 11/7/17 12:55 AM, Naveen N. Rao wrote: I thought such struct shouldn't change layout. If it is we need to fix include/linux/compiler-clang.h to do that

Re: [lkp-robot] [bpf] 76cdd39f41: WARNING:trinity-c0_still_has_locks_held

is fixed in subsequent patch set. FYI, we noticed the following commit (built with gcc-4.8): commit: 76cdd39f4117a6cbd520b5d09993ac87acbdcfd8 ("bpf: permit multiple bpf attachments for a single perf event") url: https://github.com/0day-ci/linux/commits/Yonghong-Song/bpf-permit-mu

Re: [PATCH v2 net-next] tcp: add tracepoint trace_tcp_retransmit_synack()

CCing key audience of the patch. Thanks, Song > On Oct 30, 2017, at 2:41 PM, Song Liu <songliubrav...@fb.com> wrote: > > This tracepoint can be used to trace synack retransmits. It maintains > pointer to struct request_sock. > > We cannot simply reuse trace_tcp_retran

[PATCH v2 net-next] tcp: add tracepoint trace_tcp_retransmit_synack()

these warnings. To the best of our knowledge, these warnings are harmless. Signed-off-by: Song Liu <songliubrav...@fb.com> Acked-by: Alexei Starovoitov <a...@kernel.org> Acked-by: Martin KaFai Lau <ka...@fb.com> --- include/trace/events/tcp.h | 56 ++

[PATCH v2 net-next] tcp: add tracepoint trace_tcp_retransmit_synack

Change from v1: Updated commit message to highlight potential sparse warning. Song Liu (1): tcp: add tracepoint trace_tcp_retransmit_synack() include/trace/events/tcp.h | 56 ++ net/ipv4/tcp_output.c | 1 + 2 files changed, 57 insertions

[PATCH net-next] bpf: avoid rcu_dereference inside bpf_event_mutex lock region

dering. Verified through "make C=2" that sparse locking check still happy with the new change. Also change the label name in perf_event_{attach,detach}_bpf_prog from "out" to "unlock" to reflect the code action after the label. Signed-off-by: Yonghong Song <y.

Re: [PATCH net-next] tcp: add tracepoint trace_tcp_retransmit_synack()

> On Oct 26, 2017, at 7:01 PM, Cong Wang <xiyou.wangc...@gmail.com> wrote: > > On Thu, Oct 26, 2017 at 4:50 PM, Song Liu <songliubrav...@fb.com> wrote: >> In this case, we are putting CONFIG_IPV6 in TRACE_EVENT macro, which >> generates >> warnings like:

Re: [PATCH net-next] tcp: add tracepoint trace_tcp_retransmit_synack()

> On Oct 25, 2017, at 8:13 PM, kbuild test robot <l...@intel.com> wrote: > > Hi Song, > > [auto build test WARNING on net-next/master] > > url: > https://github.com/0day-ci/linux/commits/Song-Liu/tcp-add-tracepoint-trace_tcp_retransmit_synack/20171026-010651 &

Re: [PATCH net-next 2/3] bpf: permit multiple bpf attachments for a single perf event

On 10/26/17 6:56 AM, Peter Zijlstra wrote: On Mon, Oct 23, 2017 at 10:58:04AM -0700, Yonghong Song wrote: This patch enables multiple bpf attachments for a kprobe/uprobe/tracepoint single trace event. This forgets to explain _why_ this is a good thing to do. Before this patch, each perf

Re: [PATCH net-next] tcp: add tracepoint trace_tcp_retransmit_synack()

CCing key audience of the patch. Thanks, Song > On Oct 24, 2017, at 4:57 PM, Song Liu <songliubrav...@fb.com> wrote: > > This tracepoint can be used to trace synack retransmits. It maintains > pointer to struct request_sock. > > We cannot simply reuse trace_tcp_retran

[PATCH net-next] tcp: add tracepoint trace_tcp_retransmit_synack()

This tracepoint can be used to trace synack retransmits. It maintains pointer to struct request_sock. We cannot simply reuse trace_tcp_retransmit_skb() here, because the sk here is the LISTEN socket. The IP addresses and ports should be extracted from struct request_sock. Signed-off-by: Song Liu

[PATCH net-next v3 3/3] bpf: add a test case to test single tp multiple bpf attachment

The bpf sample program syscall_tp is modified to show attachment of more than bpf programs for a particular kernel tracepoint. Signed-off-by: Yonghong Song <y...@fb.com> Acked-by: Alexei Starovoitov <a...@kernel.org> Acked-by: Martin KaFai Lau <ka...@fb.com> --- samples/bpf

[PATCH net-next v3 1/3] bpf: use the same condition in perf event set/free bpf handler

This is a cleanup such that doing the same check in perf_event_free_bpf_prog as we already do in perf_event_set_bpf_prog step. Signed-off-by: Yonghong Song <y...@fb.com> Acked-by: Alexei Starovoitov <a...@kernel.org> Acked-by: Martin KaFai Lau <ka...@fb.com> --- kernel

[PATCH net-next v3 2/3] bpf: permit multiple bpf attachments for a single perf event

, a dummy do-nothing program will replace to-be-detached program in-place. Signed-off-by: Yonghong Song <y...@fb.com> Acked-by: Alexei Starovoitov <a...@kernel.org> Acked-by: Martin KaFai Lau <ka...@fb.com> --- include/linux/bpf.h | 30 +--- include/linux/tr

[PATCH net-next v3 0/3] bpf: permit multiple bpf attachments for a single perf tracepoint event

v3: . fix compilation error. v1 -> v2: . fix a potential deadlock issue discovered by Daniel. . fix some coding style issues. Yonghong Song (3): bpf: use the same condition in perf event set/free bpf handler bpf: permit multiple bpf attachments for a single perf event bpf: add a tes

[PATCH net-next v2 1/3] bpf: use the same condition in perf event set/free bpf handler

This is a cleanup such that doing the same check in perf_event_free_bpf_prog as we already do in perf_event_set_bpf_prog step. Signed-off-by: Yonghong Song <y...@fb.com> Acked-by: Alexei Starovoitov <a...@kernel.org> Acked-by: Martin KaFai Lau <ka...@fb.com> --- kernel

[PATCH net-next v2 3/3] bpf: add a test case to test single tp multiple bpf attachment

The bpf sample program syscall_tp is modified to show attachment of more than bpf programs for a particular kernel tracepoint. Signed-off-by: Yonghong Song <y...@fb.com> Acked-by: Alexei Starovoitov <a...@kernel.org> Acked-by: Martin KaFai Lau <ka...@fb.com> --- samples/bpf

[PATCH net-next v2 0/3] bpf: permit multiple bpf attachments for a single perf tracepoint event

v2: . fix a potential deadlock issue discovered by Daniel. . fix some coding style issues. Yonghong Song (3): bpf: use the same condition in perf event set/free bpf handler bpf: permit multiple bpf attachments for a single perf event bpf: add a test case to test single tp multiple

[PATCH net-next v2 2/3] bpf: permit multiple bpf attachments for a single perf event

, a dummy do-nothing program will replace to-be-detached program in-place. Signed-off-by: Yonghong Song <y...@fb.com> Acked-by: Alexei Starovoitov <a...@kernel.org> Acked-by: Martin KaFai Lau <ka...@fb.com> --- include/linux/bpf.h | 30 +--- include/linux/tr

Re: [PATCH net-next 2/3] bpf: permit multiple bpf attachments for a single perf event

On 10/23/17 1:52 PM, Daniel Borkmann wrote: On 10/23/2017 07:58 PM, Yonghong Song wrote: [...]   __this_cpu_dec(bpf_prog_active); @@ -741,3 +754,63 @@ const struct bpf_verifier_ops perf_event_verifier_ops = {   const struct bpf_prog_ops perf_event_prog_ops = {   }; + +static

[PATCH net-next 0/3] bpf: permit multiple bpf attachments for a single perf tracepoint event

This patch set adds support to permit multiple bpf prog attachments for a single perf tracepoint event. Patch 1 does some cleanup such that perf_event_{set|free}_bpf_handler is called under the same condition. Patch 2 has the core implementation, and Patch 3 adds a test case. Yonghong Song (3

[PATCH net-next 3/3] bpf: add a test case to test single tp multiple bpf attachment

The bpf sample program syscall_tp is modified to show attachment of more than bpf programs for a particular kernel tracepoint. Signed-off-by: Yonghong Song <y...@fb.com> Acked-by: Alexei Starovoitov <a...@kernel.org> Acked-by: Martin KaFai Lau <ka...@fb.com> --- samples/bpf

[PATCH net-next 2/3] bpf: permit multiple bpf attachments for a single perf event

, a dummy do-nothing program will replace to-be-detached program in-place. Signed-off-by: Yonghong Song <y...@fb.com> Acked-by: Alexei Starovoitov <a...@kernel.org> Acked-by: Martin KaFai Lau <ka...@fb.com> --- include/linux/bpf.h | 30 +--- include/linux/tr

[PATCH net-next 1/3] bpf: use the same condition in perf event set/free bpf handler

This is a cleanup such that doing the same check in perf_event_free_bpf_prog as we already do in perf_event_set_bpf_prog step. Signed-off-by: Yonghong Song <y...@fb.com> Acked-by: Alexei Starovoitov <a...@kernel.org> Acked-by: Martin KaFai Lau <ka...@fb.com> --- kernel

Re: [PATCH v2 net-next 0/6] add a set of tracepoints to tcp stack

CCing key audience of these patches. Thanks, Song > On Oct 23, 2017, at 9:20 AM, Song Liu <songliubrav...@fb.com> wrote: > > Changes from v1: > > Fix build error (with ipv6 as ko) by adding EXPORT_TRACEPOINT_SYMBOL_GPL > for trace_tcp_send_reset. > > T

[PATCH v2 net-next 1/6] tcp: add trace event class tcp_event_sk_skb

Introduce event class tcp_event_sk_skb for tcp tracepoints that have arguments sk and skb. Existing tracepoint trace_tcp_retransmit_skb() falls into this class. This patch rewrites the definition of trace_tcp_retransmit_skb() with tcp_event_sk_skb. Signed-off-by: Song Liu <songliubrav...@fb.

[PATCH v2 net-next 3/6] tcp: add tracepoint trace_tcp_send_reset

New tracepoint trace_tcp_send_reset is added and called from tcp_v4_send_reset(), tcp_v6_send_reset() and tcp_send_active_reset(). Signed-off-by: Song Liu <songliubrav...@fb.com> --- include/trace/events/tcp.h | 11 +++ net/core/net-traces.c | 2 ++ net/ipv4/tcp_ipv4.c

[PATCH v2 net-next 5/6] tcp: add tracepoint trace_tcp_destroy_sock

This patch adds trace event trace_tcp_destroy_sock. Signed-off-by: Song Liu <songliubrav...@fb.com> --- include/trace/events/tcp.h | 7 +++ net/ipv4/tcp_ipv4.c| 2 ++ 2 files changed, 9 insertions(+) diff --git a/include/trace/events/tcp.h b/include/trace/events/tcp.h index c

[PATCH v2 net-next 4/6] tcp: add tracepoint trace_tcp_receive_reset

New tracepoint trace_tcp_receive_reset is added and called from tcp_reset(). This tracepoint is define with a new class tcp_event_sk. Signed-off-by: Song Liu <songliubrav...@fb.com> --- include/trace/events/tcp.h | 66 ++ net/ipv4/tcp_i

[PATCH v2 net-next 6/6] tcp: add tracepoint trace_tcp_set_state()

This patch adds tracepoint trace_tcp_set_state. Besides usual fields (s/d ports, IP addresses), old and new state of the socket is also printed with TP_printk, with __print_symbolic(). Signed-off-by: Song Liu <songliubrav...@fb.com> --- include/trace/events/tcp.

[PATCH v2 net-next 2/6] tcp: mark trace event arguments sk and skb as const

Some functions that we plan to add trace points require const sk and/or skb. So we mark these fields as const in the tracepoint. Signed-off-by: Song Liu <songliubrav...@fb.com> --- include/trace/events/tcp.h | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/i

[PATCH v2 net-next 0/6] add a set of tracepoints to tcp stack

int kprobe__tcp_v6_send_reset int kprobe__tcp_v4_destroy_sock int kprobe__tcp_set_state int kprobe__tcp_retransmit_skb These tracepoints will help us simplify this work. Thanks, Song Song Liu (6): tcp: add trace event class tcp_event_sk_skb tcp: mark trace event arguments sk and skb as const

Re: [PATCH net-next 0/6] add a set of tracepoints to tcp stack

CCing key audience of these patches. I am really sorry if I have spammed your inbox multiple times with the same set of patches. I have been struggling to get git-send-email sending email to netdev. The only solution I found is to be reduce CC list. Best Regards, Song > On Oct 20, 2

[PATCH net-next 0/6] add a set of tracepoints to tcp stack

kprobe__tcp_v4_destroy_sock int kprobe__tcp_set_state int kprobe__tcp_retransmit_skb These tracepoints will help us simplify this work. Thanks, Song Song Liu (6): tcp: add trace event class tcp_event_sk_skb tcp: mark trace event arguments sk and skb as const tcp: add tracepoint

[PATCH net-next 1/6] tcp: add trace event class tcp_event_sk_skb

Introduce event class tcp_event_sk_skb for tcp tracepoints that have arguments sk and skb. Existing tracepoint trace_tcp_retransmit_skb() falls into this class. This patch rewrites the definition of trace_tcp_retransmit_skb() with tcp_event_sk_skb. Signed-off-by: Song Liu <songliubrav...@fb.

[PATCH net-next 6/6] tcp: add tracepoint trace_tcp_set_state()

This patch adds tracepoint trace_tcp_set_state. Besides usual fields (s/d ports, IP addresses), old and new state of the socket is also printed with TP_printk, with __print_symbolic(). Signed-off-by: Song Liu <songliubrav...@fb.com> --- include/trace/events/tcp.

[PATCH net-next 3/6] tcp: add tracepoint trace_tcp_send_reset

New tracepoint trace_tcp_send_reset is added and called from tcp_v4_send_reset(), tcp_v6_send_reset() and tcp_send_active_reset(). Signed-off-by: Song Liu <songliubrav...@fb.com> --- include/trace/events/tcp.h | 11 +++ net/ipv4/tcp_ipv4.c| 6 +- net/ipv4/tcp_ou

[PATCH net-next 2/6] tcp: mark trace event arguments sk and skb as const

Some functions that we plan to add trace points require const sk and/or skb. So we mark these fields as const in the tracepoint. Signed-off-by: Song Liu <songliubrav...@fb.com> --- include/trace/events/tcp.h | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/i

[PATCH net-next 5/6] tcp: add tracepoint trace_tcp_destroy_sock

This patch adds trace event trace_tcp_destroy_sock. Signed-off-by: Song Liu <songliubrav...@fb.com> --- include/trace/events/tcp.h | 7 +++ net/ipv4/tcp_ipv4.c| 2 ++ 2 files changed, 9 insertions(+) diff --git a/include/trace/events/tcp.h b/include/trace/events/tcp.h index c

[PATCH net-next 4/6] tcp: add tracepoint trace_tcp_receive_reset

New tracepoint trace_tcp_receive_reset is added and called from tcp_reset(). This tracepoint is define with a new class tcp_event_sk. Signed-off-by: Song Liu <songliubrav...@fb.com> --- include/trace/events/tcp.h | 66 ++ net/ipv4/tcp_i

Re: [PATCH net-next] tcp: Remove use of inet6_sk and add IPv6 checks to tracepoint

;> Signed-off-by: David Ahern <dsah...@gmail.com> >> --- > > Reviewed-by: Eric Dumazet <eduma...@google.com> > > Thanks ! > Tested-by: Song Liu <songliubrav...@fb.com>

Re: [PATCH v3 net-next] tcp: Remove use of daddr_cache in tracepoint

> > Remove use of ipv6_pinfo in favor of data in sock_common. > > > > Fixes: e086101b150a ("tcp: add a tracepoint for tcp retransmission") > > Signed-off-by: David Ahern <dsah...@gmail.com> > > --- > > Reviewed-by: Eric Dumazet <edum

[PATCH net-next v7 4/5] bpf: add helper bpf_perf_prog_read_value

. In such cases, if it is desirable to get scaling factor between two bpf invocations, users can can save the time values in a map, and use the value from the map and the current value to calculate the scaling factor. Signed-off-by: Yonghong Song <y...@fb.com> Acked-by: Alexei Starovoitov <a.

[PATCH net-next v7 5/5] bpf: add a test case for helper bpf_perf_prog_read_value

The bpf sample program trace_event is enhanced to use the new helper to print out enabled/running time. Signed-off-by: Yonghong Song <y...@fb.com> Acked-by: Alexei Starovoitov <a...@fb.com> Acked-by: Daniel Borkmann <dan...@iogearbox.net> --- samples/bpf/trace_event_kern

[PATCH net-next v7 0/5] bpf: add two helpers to read perf event enabled/running time

he logic to ensure the result is valid. Yonghong Song (5): bpf: perf event change needed for subsequent bpf helpers bpf: add helper bpf_perf_event_read_value for perf event array map bpf: add a test case for helper bpf_perf_event_read_value bpf: add helper bpf_perf_prog_read_value bpf: add a te

[PATCH net-next v7 1/5] bpf: perf event change needed for subsequent bpf helpers

This patch does not impact existing functionalities. It contains the changes in perf event area needed for subsequent bpf_perf_event_read_value and bpf_perf_prog_read_value helpers. Signed-off-by: Yonghong Song <y...@fb.com> --- include/linux/perf_event.h | 7 +-- kernel/bpf/arra

[PATCH net-next v7 3/5] bpf: add a test case for helper bpf_perf_event_read_value

The bpf sample program tracex6 is enhanced to use the new helper to read enabled/running time as well. Signed-off-by: Yonghong Song <y...@fb.com> Acked-by: Alexei Starovoitov <a...@fb.com> Acked-by: Daniel Borkmann <dan...@iogearbox.net> --- samples/bpf/tracex6_kern.c

[PATCH net-next v7 2/5] bpf: add helper bpf_perf_event_read_value for perf event array map

and do the calculation inside the bpf program. Signed-off-by: Yonghong Song <y...@fb.com> Acked-by: Alexei Starovoitov <a...@fb.com> Acked-by: Daniel Borkmann <dan...@iogearbox.net> --- include/uapi/linux/bpf.h | 21 +++-- kernel/bpf/verifier.c| 4 +++- kernel

[PATCH net-next v6 0/4] bpf: add two helpers to read perf event enabled/running time

which contains the logic to ensure the result is valid. Yonghong Song (4): bpf: add helper bpf_perf_event_read_value for perf event array map bpf: add a test case for helper bpf_perf_event_read_value bpf: add helper bpf_perf_prog_read_value bpf: add a test case for helper bpf_perf_prog_read_

[PATCH net-next v6 2/4] bpf: add a test case for helper bpf_perf_event_read_value

The bpf sample program tracex6 is enhanced to use the new helper to read enabled/running time as well. Signed-off-by: Yonghong Song <y...@fb.com> --- samples/bpf/tracex6_kern.c| 26 ++ samples/bpf/tracex6_user.c| 13 -

[PATCH net-next v6 1/4] bpf: add helper bpf_perf_event_read_value for perf event array map

and do the calculation inside the bpf program. Signed-off-by: Yonghong Song <y...@fb.com> --- include/linux/perf_event.h | 6 -- include/uapi/linux/bpf.h | 20 ++-- kernel/bpf/arraymap.c | 2 +- kernel/bpf/verifier.c | 4 +++- kernel/events/core.c

[PATCH net-next v6 4/4] bpf: add a test case for helper bpf_perf_prog_read_value

The bpf sample program trace_event is enhanced to use the new helper to print out enabled/running time. Signed-off-by: Yonghong Song <y...@fb.com> --- samples/bpf/trace_event_kern.c| 10 ++ samples/bpf/trace_event_user.c| 13 - tools/include/uapi

[PATCH net-next v6 3/4] bpf: add helper bpf_perf_prog_read_value

. In such cases, if it is desirable to get scaling factor between two bpf invocations, users can can save the time values in a map, and use the value from the map and the current value to calculate the scaling factor. Signed-off-by: Yonghong Song <y...@fb.com> --- include/linux/perf_event.

Re: [PATCH net-next v5 1/4] bpf: add helper bpf_perf_event_read_value for perf event array map

On 9/21/17 8:15 AM, Alexei Starovoitov wrote: On 9/20/17 4:07 PM, David Miller wrote: From: Peter Zijlstra Date: Wed, 20 Sep 2017 19:26:51 +0200 Dave, could we have this in a topic tree of sorts, because I have a pending series to rework all the timekeeping and it

Re: [PATCH net-next] bpf/verifier: improve disassembly of BPF_END instructions

On Fri, Sep 22, 2017 at 9:23 AM, Edward Cree wrote: > On 22/09/17 16:16, Alexei Starovoitov wrote: >> looks like we're converging on >> "be16/be32/be64/le16/le32/le64 #register" for BPF_END. >> I guess it can live with that. I would prefer more C like syntax >> to match the

Re: [PATCH net-next] bpf/verifier: improve disassembly of BPF_END instructions

On Fri, Sep 22, 2017 at 7:11 AM, Y Song <ys114...@gmail.com> wrote: > On Fri, Sep 22, 2017 at 6:46 AM, Edward Cree <ec...@solarflare.com> wrote: >> On 22/09/17 00:11, Y Song wrote: >>> On Thu, Sep 21, 2017 at 12:58 PM, Edward Cree <ec...@solarflare.com> w

Re: [PATCH net-next] bpf/verifier: improve disassembly of BPF_END instructions

On Fri, Sep 22, 2017 at 6:46 AM, Edward Cree <ec...@solarflare.com> wrote: > On 22/09/17 00:11, Y Song wrote: >> On Thu, Sep 21, 2017 at 12:58 PM, Edward Cree <ec...@solarflare.com> wrote: >>> On 21/09/17 20:44, Alexei Starovoitov wrote: >>>> On Thu

Re: [PATCH net-next] bpf/verifier: improve disassembly of BPF_END instructions

On Thu, Sep 21, 2017 at 12:58 PM, Edward Cree wrote: > On 21/09/17 20:44, Alexei Starovoitov wrote: >> On Thu, Sep 21, 2017 at 09:29:33PM +0200, Daniel Borkmann wrote: >>> More intuitive, but agree on the from_be/le. Maybe we should >>> just drop the "to_" prefix altogether,

Re: [PATCH net-next] bpf/verifier: improve disassembly of BPF_END instructions

On Thu, Sep 21, 2017 at 9:24 AM, Edward Cree wrote: > On 21/09/17 16:52, Alexei Starovoitov wrote: >> On Thu, Sep 21, 2017 at 04:09:34PM +0100, Edward Cree wrote: >>> print_bpf_insn() was treating all BPF_ALU[64] the same, but BPF_END has a >>> different structure: it has a

Re: [PATCH net-next] bpf/verifier: improve disassembly of BPF_END instructions

On Thu, Sep 21, 2017 at 8:52 AM, Alexei Starovoitov wrote: > On Thu, Sep 21, 2017 at 04:09:34PM +0100, Edward Cree wrote: >> print_bpf_insn() was treating all BPF_ALU[64] the same, but BPF_END has a >> different structure: it has a size in insn->imm (even if it's

Re: [PATCH net] bpf: one perf event close won't free bpf program attached by another perf event

On 9/20/17 10:17 PM, Yonghong Song wrote: On 9/20/17 6:41 PM, Steven Rostedt wrote: On Mon, 18 Sep 2017 16:38:36 -0700 Yonghong Song <y...@fb.com> wrote: This patch fixes a bug exhibited by the following scenario:    1. fd1 = perf_event_open with attr.config = ID1    2. attach bpf p

Re: [PATCH net] bpf: one perf event close won't free bpf program attached by another perf event

On 9/20/17 6:41 PM, Steven Rostedt wrote: On Mon, 18 Sep 2017 16:38:36 -0700 Yonghong Song <y...@fb.com> wrote: This patch fixes a bug exhibited by the following scenario: 1. fd1 = perf_event_open with attr.config = ID1 2. attach bpf program prog1 to fd1 3. fd2 = perf_even

[PATCH net-next v5 2/4] bpf: add a test case for helper bpf_perf_event_read_value

The bpf sample program tracex6 is enhanced to use the new helper to read enabled/running time as well. Signed-off-by: Yonghong Song <y...@fb.com> --- samples/bpf/tracex6_kern.c| 26 ++ samples/bpf/tracex6_user.c| 13 -

[PATCH net-next v5 0/4] bpf: add two helpers to read perf event enabled/running time

time should be together with reading counters which contains the logic to ensure the result is valid. Yonghong Song (4): bpf: add helper bpf_perf_event_read_value for perf event array map bpf: add a test case for helper bpf_perf_event_read_value bpf: add helper bpf_perf_prog_read_value bpf

[PATCH net-next v5 4/4] bpf: add a test case for helper bpf_perf_prog_read_value

The bpf sample program trace_event is enhanced to use the new helper to print out enabled/running time. Signed-off-by: Yonghong Song <y...@fb.com> --- samples/bpf/trace_event_kern.c| 10 ++ samples/bpf/trace_event_user.c| 13 - tools/include/uapi

[PATCH net-next v5 1/4] bpf: add helper bpf_perf_event_read_value for perf event array map

and do the calculation inside the bpf program. Signed-off-by: Yonghong Song <y...@fb.com> --- include/linux/perf_event.h | 6 -- include/uapi/linux/bpf.h | 19 ++- kernel/bpf/arraymap.c | 2 +- kernel/bpf/verifier.c | 4 +++- kernel/events/core.c

[PATCH net-next v5 3/4] bpf: add helper bpf_perf_prog_read_value

. In such cases, if it is desirable to get scaling factor between two bpf invocations, users can can save the time values in a map, and use the value from the map and the current value to calculate the scaling factor. Signed-off-by: Yonghong Song <y...@fb.com> --- include/linux/perf_event.

[PATCH net-next v4 4/4] bpf: add a test case for helper bpf_perf_prog_read_value

The bpf sample program trace_event is enhanced to use the new helper to print out enabled/running time. Signed-off-by: Yonghong Song <y...@fb.com> --- samples/bpf/trace_event_kern.c| 10 ++ samples/bpf/trace_event_user.c| 13 - tools/include/uapi

[PATCH net-next v4 3/4] bpf: add helper bpf_perf_prog_read_value

. In such cases, if it is desirable to get scaling factor between two bpf invocations, users can can save the time values in a map, and use the value from the map and the current value to calculate the scaling factor. Signed-off-by: Yonghong Song <y...@fb.com> --- include/linux/perf_event.

[PATCH net-next v4 0/4] bpf: add two helpers to read perf event enabled/running time

o read enabled/running time. This is to prevent that counters and enabled/running time may be read separately. v1->v2: . reading enabled/running time should be together with reading counters which contains the logic to ensure the result is valid. Yonghong Song (4): bpf: a

[PATCH net-next v4 1/4] bpf: add helper bpf_perf_event_read_value for perf event array map

and do the calculation inside the bpf program. Signed-off-by: Yonghong Song <y...@fb.com> --- include/linux/perf_event.h | 6 -- include/uapi/linux/bpf.h | 18 +- kernel/bpf/arraymap.c | 2 +- kernel/bpf/verifier.c | 4 +++- kernel/events/core.c

[PATCH net-next v4 2/4] bpf: add a test case for helper bpf_perf_event_read_value

The bpf sample program tracex6 is enhanced to use the new helper to read enabled/running time as well. Signed-off-by: Yonghong Song <y...@fb.com> --- samples/bpf/tracex6_kern.c| 26 ++ samples/bpf/tracex6_user.c| 13 -

[PATCH net] bpf: one perf event close won't free bpf program attached by another perf event

fix is to free tp_event->prog only when the closing fd corresponds to the one which registered the program. Signed-off-by: Yonghong Song <y...@fb.com> --- Additional context: discussed with Alexei internally but did not find a solution which can avoid introducing the additional field in trac

[PATCH net-next v3 2/4] bpf: add a test case for helper bpf_perf_event_read_value

The bpf sample program tracex6 is enhanced to use the new helper to read enabled/running time as well. Signed-off-by: Yonghong Song <y...@fb.com> --- samples/bpf/tracex6_kern.c| 26 ++ samples/bpf/tracex6_user.c| 13 -

[PATCH net-next v3 1/4] bpf: add helper bpf_perf_event_read_value for perf event array map

and do the calculation inside the bpf program. Signed-off-by: Yonghong Song <y...@fb.com> --- include/linux/perf_event.h | 3 ++- include/uapi/linux/bpf.h | 18 +- kernel/bpf/arraymap.c | 2 +- kernel/bpf/verifier.c | 4 +++- kernel/events/core.c

[PATCH net-next v3 3/4] bpf: add helper bpf_perf_prog_read_value

. In such cases, if it is desirable to get scaling factor between two bpf invocations, users can can save the time values in a map, and use the value from the map and the current value to calculate the scaling factor. Signed-off-by: Yonghong Song <y...@fb.com> --- include/linux/perf_event.

[PATCH net-next v3 0/4] bpf: add two helpers to read perf event enabled/running time

ime. This is to prevent that counters and enabled/running time may be read separately. v1->v2: . reading enabled/running time should be together with reading counters which contains the logic to ensure the result is valid. Yonghong Song (4): bpf: add helper bpf_perf_event_read_value for perf

[PATCH net-next v3 4/4] bpf: add a test case for helper bpf_perf_prog_read_value

The bpf sample program trace_event is enhanced to use the new helper to print out enabled/running time. Signed-off-by: Yonghong Song <y...@fb.com> --- samples/bpf/trace_event_kern.c| 10 ++ samples/bpf/trace_event_user.c| 13 - tools/include/uapi

Re: Bug with BPF_ALU64 | BPF_END?

On Thu, Sep 14, 2017 at 11:14 AM, David Miller wrote: > From: Edward Cree > Date: Thu, 14 Sep 2017 18:53:17 +0100 > >> Is BPF_END supposed to only be used with BPF_ALU, never with BPF_ALU64? Yes, only BPF_ALU. The below is LLVM bpf swap insn encoding:

[PATCH net] perf/bpf: fix a clang compilation issue

args[sys_data->nb_args]; ^ The fix is to use a fixed array length instead. Reported-by: Nick Desaulniers <ndesaulni...@google.com> Signed-off-by: Yonghong Song <y...@fb.com> --- include/linux/syscalls.h | 2 ++ kernel/trace/trace_syscalls.c | 2 +-

[PATCH v2 net-next 4/4] bpf: add a test case for helper bpf_perf_prog_read_time

The bpf sample program trace_event is enhanced to use the new helper to print out enabled/running time. Signed-off-by: Yonghong Song <y...@fb.com> --- samples/bpf/trace_event_kern.c| 10 ++ samples/bpf/trace_event_user.c| 13 - tools/testing/sel

[PATCH v2 net-next 1/4] bpf: add helper bpf_perf_read_counter_time for perf event array map

and do the calculation inside the bpf program. Signed-off-by: Yonghong Song <y...@fb.com> --- include/linux/perf_event.h | 3 ++- include/uapi/linux/bpf.h | 21 - kernel/bpf/arraymap.c | 2 +- kernel/bpf/verifier.c | 4 +++- kernel/events/core.c

[PATCH v2 net-next 0/4] bpf: add two helpers to read perf event enabled/running time

bpf_perf_read_counter_time reads counter/time_enabled/time_running for perf event array map. The helper bpf_perf_prog_read_time read time_enabled/time_running for bpf prog with type BPF_PROG_TYPE_PERF_EVENT. Yonghong Song (4): bpf: add helper bpf_perf_read_counter_time for perf event array map bpf: add

[PATCH v2 net-next 3/4] bpf: add helper bpf_perf_prog_read_time

, if it is desirable to get scaling factor between two bpf invocations, users can can save the time values in a map, and use the value from the map and the current value to calculate the scaling factor. Signed-off-by: Yonghong Song <y...@fb.com> --- include/linux/perf_event.h | 1 + include/uapi

[PATCH v2 net-next 2/4] bpf: add a test case to read enabled/running time for perf array

The bpf sample program tracex6 is enhanced to use the new helper to read enabled/running time as well. Signed-off-by: Yonghong Song <y...@fb.com> --- samples/bpf/tracex6_kern.c| 26 ++ samples/bpf/tracex6_user.c| 13 -

<    5   6   7   8   9   10   11   >