Re: [PATCH] net: Use dma_pool_zalloc()

2018-03-08 Thread Souptick Joarder
On Thu, Mar 8, 2018 at 7:15 PM, Krzysztof Hałasa <khal...@piap.pl> wrote: > Souptick Joarder <jrdr.li...@gmail.com> writes: > >> Any comment for this patch. > > I thought something like this was already aplied. I am not seeing anything similar till 4.16-rc4. Is i

Re: [PATCH] net: Use dma_pool_zalloc()

2018-03-06 Thread Souptick Joarder
Any comment for this patch. On Fri, Feb 16, 2018 at 9:58 PM, Souptick Joarder <jrdr.li...@gmail.com> wrote: > Use dma_pool_zalloc() instead of dma_pool_alloc + memset > > Signed-off-by: Souptick Joarder <jrdr.li...@gmail.com> > --- > drivers/net/ethernet/xscale/ixp4

Re: [PATCH v4 7/8] netdev: octeon-ethernet: Add Cavium Octeon III support.

2017-11-29 Thread Souptick Joarder
Hi David, Dan, On Thu, Nov 30, 2017 at 12:50 AM, David Daney <dda...@caviumnetworks.com> wrote: > On 11/29/2017 08:07 AM, Souptick Joarder wrote: >> >> On Wed, Nov 29, 2017 at 4:00 PM, Souptick Joarder <jrdr.li...@gmail.com> >> wrote: >>> >&g

Re: [PATCH v4 7/8] netdev: octeon-ethernet: Add Cavium Octeon III support.

2017-11-29 Thread Souptick Joarder
On Wed, Nov 29, 2017 at 4:00 PM, Souptick Joarder <jrdr.li...@gmail.com> wrote: > On Wed, Nov 29, 2017 at 6:25 AM, David Daney <david.da...@cavium.com> wrote: >> From: Carlos Munoz <cmu...@cavium.com> >> >> The Cavium OCTEON cn78xx and cn73xx S

Re: [PATCH] net: wan: Use dma_pool_zalloc

2016-12-16 Thread Souptick Joarder
On Fri, Dec 16, 2016 at 11:40 AM, Joe Perches <j...@perches.com> wrote: > On Fri, 2016-12-16 at 11:33 +0530, Souptick Joarder wrote: >> On Thu, Dec 15, 2016 at 10:18 PM, Joe Perches <j...@perches.com> wrote: >> > On Thu, 2016-12-15 at 10:41 +0530, Souptick Joarde

Re: [PATCH] net: wan: Use dma_pool_zalloc

2016-12-15 Thread Souptick Joarder
On Thu, Dec 15, 2016 at 10:18 PM, Joe Perches <j...@perches.com> wrote: > On Thu, 2016-12-15 at 10:41 +0530, Souptick Joarder wrote: >> On Mon, Dec 12, 2016 at 10:12 AM, Souptick Joarder <jrdr.li...@gmail.com> >> wrote: >> > On Fri, Dec 9, 2016 at 6:33 PM, Krzy

Re: [PATCH] net: wan: Use dma_pool_zalloc

2016-12-14 Thread Souptick Joarder
On Mon, Dec 12, 2016 at 10:12 AM, Souptick Joarder <jrdr.li...@gmail.com> wrote: > On Fri, Dec 9, 2016 at 6:33 PM, Krzysztof Hałasa <khal...@piap.pl> wrote: >> Souptick Joarder <jrdr.li...@gmail.com> writes: >> >>> We should use dma_pool_zalloc instead o

Re: [PATCH] net: wan: Use dma_pool_zalloc

2016-12-11 Thread Souptick Joarder
On Fri, Dec 9, 2016 at 6:33 PM, Krzysztof Hałasa <khal...@piap.pl> wrote: > Souptick Joarder <jrdr.li...@gmail.com> writes: > >> We should use dma_pool_zalloc instead of dma_pool_alloc/memset >> >> Signed-off-by: Souptick joarder <jrdr.li...@gmail.com> &

[PATCH v2] ethernet :mellanox :mlx5: Replace pci_pool_alloc by pci_pool_zalloc

2016-11-29 Thread Souptick Joarder
In alloc_cmd_box(), pci_pool_alloc() followed by memset will be replaced by pci_pool_zalloc() Signed-off-by: Souptick joarder <jrdr.li...@gmail.com> --- v2: - Address comments from Sergei Alignment was not proper drivers/net/ethernet/mellanox/mlx5/core/cmd.c | 5 ++--- 1 file chan

Re: [PATCH v3] ethernet :mellanox :mlx4: Replace pci_pool_alloc by pci_pool_zalloc

2016-11-29 Thread Souptick Joarder
d, Nov 30, 2016 at 01:16:12AM +0530, Souptick Joarder wrote: >> In mlx4_alloc_cmd_mailbox(), pci_pool_alloc() followed by memset will be >> replaced by pci_pool_zalloc() >> >> Signed-off-by: Souptick joarder <jrdr.li...@gmail.com> >> --- >> v3: >>

[PATCH v3] ethernet :mellanox :mlx4: Replace pci_pool_alloc by pci_pool_zalloc

2016-11-29 Thread Souptick Joarder
In mlx4_alloc_cmd_mailbox(), pci_pool_alloc() followed by memset will be replaced by pci_pool_zalloc() Signed-off-by: Souptick joarder <jrdr.li...@gmail.com> --- v3: - Fixed alignment issues v2: - Address comment from sergei Alignment was not proper drivers/net/ethernet/mellano

Re: [PATCH v2] ethernet :mellanox :mlx4: Replace pci_pool_alloc by pci_pool_zalloc

2016-11-29 Thread Souptick Joarder
, Nov 29, 2016 at 12:55 PM, Souptick Joarder <jrdr.li...@gmail.com> wrote: > Please ignore this v2 patch. > > On Tue, Nov 29, 2016 at 12:29 PM, Souptick Joarder <jrdr.li...@gmail.com> > wrote: >> In mlx4_alloc_cmd_mailbox(), pci_pool_alloc() followed by memset wi

Re: [PATCH v2] ethernet :mellanox :mlx4: Replace pci_pool_alloc by pci_pool_zalloc

2016-11-28 Thread Souptick Joarder
Please ignore this v2 patch. On Tue, Nov 29, 2016 at 12:29 PM, Souptick Joarder <jrdr.li...@gmail.com> wrote: > In mlx4_alloc_cmd_mailbox(), pci_pool_alloc() followed by memset will be > replaced by pci_pool_zalloc(). > > Signed-off-by: Souptick joarder <jrdr.li...@

[PATCH v2] ethernet :mellanox :mlx4: Replace pci_pool_alloc by pci_pool_zalloc

2016-11-28 Thread Souptick Joarder
In mlx4_alloc_cmd_mailbox(), pci_pool_alloc() followed by memset will be replaced by pci_pool_zalloc(). Signed-off-by: Souptick joarder <jrdr.li...@gmail.com> --- v2: - Address comment from sergei Alignment was not proper drivers/net/ethernet/mellanox/mlx4/cmd.c | 5 ++--- 1 file c

Re: [PATCH] ethernet :mellanox :mlx4: Replace pci_pool_alloc by pci_pool_zalloc

2016-11-28 Thread Souptick Joarder
On Tue, Nov 29, 2016 at 12:36 AM, Sergei Shtylyov <sergei.shtyl...@cogentembedded.com> wrote: > Hello. > > On 11/28/2016 04:28 PM, Souptick Joarder wrote: > >> In mlx4_alloc_cmd_mailbox(), pci_pool_alloc() followed by memset will be >> replaced by pci_pool_zalloc()

[PATCH] ethernet :mellanox :mlx5: Replace pci_pool_alloc by pci_pool_zalloc

2016-11-28 Thread Souptick Joarder
In alloc_cmd_box(), pci_pool_alloc() followed by memset will be replaced by pci_pool_zalloc() Signed-off-by: Souptick joarder <jrdr.li...@gmail.com> --- drivers/net/ethernet/mellanox/mlx5/core/cmd.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/et

[PATCH] ethernet :mellanox :mlx4: Replace pci_pool_alloc by pci_pool_zalloc

2016-11-28 Thread Souptick Joarder
In mlx4_alloc_cmd_mailbox(), pci_pool_alloc() followed by memset will be replaced by pci_pool_zalloc() Signed-off-by: Souptick joarder <jrdr.li...@gmail.com> --- drivers/net/ethernet/mellanox/mlx4/cmd.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/et

Re: [PATCH 3/3] net-iwlegacy: Another refactoring for il_eeprom_init()

2016-01-02 Thread Souptick Joarder
On Sat, Jan 2, 2016 at 2:02 AM, SF Markus Elfring wrote: > From: Markus Elfring > Date: Fri, 1 Jan 2016 21:16:01 +0100 > > Rename a jump label according to the current Linux coding style convention. > > Signed-off-by: Markus Elfring

Re: [PATCH] mac80211: Make addr const in SET_IEEE80211_PERM_ADDR()

2015-12-30 Thread Souptick Joarder
On Wed, Dec 30, 2015 at 10:35 PM, Bjorn Andersson <bj...@kryo.se> wrote: > On Wed, Dec 30, 2015 at 8:47 AM, Souptick Joarder <jrdr.li...@gmail.com> > wrote: >> >> HI Bjorn, >> >> On Thu, Dec 24, 2015 at 2:03 PM, Bjorn Andersson <bj...@kryo.

Re: [PATCH] mac80211: Make addr const in SET_IEEE80211_PERM_ADDR()

2015-12-30 Thread Souptick Joarder
HI Bjorn, On Thu, Dec 24, 2015 at 2:03 PM, Bjorn Andersson wrote: > Make the addr parameter const in SET_IEEE80211_PERM_ADDR() to save > clients from having to cast away a const qualifier. > > Signed-off-by: Bjorn Andersson > --- >

Re: [PATCH] ath6kl: Use vmalloc to allocate ar->fw for api1 method

2015-12-29 Thread Souptick Joarder
Brent, On Tue, Dec 22, 2015 at 2:42 PM, Kalle Valo <kv...@qca.qualcomm.com> wrote: > Souptick Joarder <jrdr.li...@gmail.com> writes: > >> Hi Brent, >> >> On Tue, Dec 22, 2015 at 3:23 AM, Brent Taylor <moto...@gmail.com> wrote: >>> On Mon,

Re: [PATCH] ath6kl: Use vmalloc to allocate ar->fw for api1 method

2015-12-22 Thread Souptick Joarder
Hi Brent, On Tue, Dec 22, 2015 at 3:23 AM, Brent Taylor <moto...@gmail.com> wrote: > On Mon, Dec 21, 2015 at 1:23 PM, Souptick Joarder <jrdr.li...@gmail.com> > wrote: >> Hi Brent, >> >> On Tue, Dec 1, 2015 at 11:11 AM, Brent Taylor <mot

Re: [PATCH] ath6kl: Use vmalloc to allocate ar->fw for api1 method

2015-12-21 Thread Souptick Joarder
Hi Brent, On Tue, Dec 1, 2015 at 11:11 AM, Brent Taylor wrote: > Since commit 8437754c83351d6213c1a47ff029c1126d6042a7, ar->fw is expected to > be pointing to memory allocated by vmalloc. If the api1 method (via > ath6kl_fetch_fw_api1) is used to allocate memory for ar->fw,

Re: [PATCH] wlcore: consolidate kmalloc + memset 0 into kzalloc

2015-12-21 Thread Souptick Joarder
On Mon, Dec 21, 2015 at 10:17 PM, Nicholas Mc Guire wrote: > This is an API consolidation only. The use of kmalloc + memset to 0 > is equivalent to kzalloc. > > Signed-off-by: Nicholas Mc Guire > --- > > Found by coccinelle script (relaxed version of >