[PATCH] i40e: fix mac filter delete when setting mac address

lly that makes the code easier to read. Fixes: 458867b2ca0c ("i40e: don't remove netdev->dev_addr when syncing uc list") Signed-off-by: Stefan Assmann --- drivers/net/ethernet/intel/i40e/i40e_main.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --g

Re: Issue with driver i40e stat strings count mismatch

n into the same issue. Here's my proposed fix. >From 46c74c25496bab06712641c7b2b6b34e365397a2 Mon Sep 17 00:00:00 2001 From: Stefan Assmann Date: Mon, 30 Jul 2018 21:38:43 +0200 Subject: [PATCH] i40e: fix i40e_get_stat_strings strings count warning The current code calculates p - data, which res

Re: [Intel-wired-lan] SRIOV on Intel x710 fail to get attached both at VM creation time and VM runtime

On 2018-03-01 19:40, Alexander Duyck wrote: > On Thu, Mar 1, 2018 at 8:12 AM, wrote: > > + intel-wired-...@lists.osuosl.org > > > > > > On 2018-03-01 21:41, p...@codeaurora.org wrote: > >> > >> Hi All, > >> > >> I am facing the following issue on kernel 4.14.14. > >> > >>

[PATCH 2/2] Revert "i40e: remove WQ_UNBOUND and the task limit of our workqueue"

disabled The NIC is fully operational after the flash and even after a cold boot any follow-up eeprom checks succeed. This needs to be investigated, but for now it should be more important to make sure the firmware update works as expected. Signed-off-by: Stefan Assmann <sassm...@kpanic.de> --- d

[PATCH 0/2] i40e: fix firmware update

to a recent workqueue change. Haven't gotten to the bottom of this yet, but for the sake of a smooth firmware update experience let's revert the commit for now. Stefan Assmann (2): i40e: use non-locking i40e_read_nvm_word() function during nvmupdate Revert "i40e: remove WQ_UNBOUND and the

[PATCH 1/2] i40e: use non-locking i40e_read_nvm_word() function during nvmupdate

working again. Fixes: ("96a39aed25e6 i40e: Acquire NVM lock before reads on all devices") Signed-off-by: Stefan Assmann <sassm...@kpanic.de> --- drivers/net/ethernet/intel/i40e/i40e_nvm.c | 24 ++-- 1 file changed, 22 insertions(+), 2 deletions(-) diff --git a/driv

[PATCH 1/2] i40e/i40evf: rename vf_offload_flags to vf_cap_flags in struct virtchnl_vf_resource

The current name of vf_offload_flags indicates that the bitmap is limited to offload related features. Make this more generic by renaming it to vf_cap_flags, which allows for other capabilities besides offloading to be added. Signed-off-by: Stefan Assmann <sassm...@kpanic.de> --- drive

[PATCH 2/2] i40e/i40evf: add virtchnl flag to indicate trusted VF

address change without the VF trust hint. Signed-off-by: Stefan Assmann <sassm...@kpanic.de> --- drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c | 3 +++ drivers/net/ethernet/intel/i40evf/i40evf_main.c| 3 ++- include/linux/avf/virtchnl.h | 1 + 3 files chan

[PATCH 0/2] i40e/i40evf: fix override of administratively set MAC address in trusted mode

patch then adds a flag to vf_cap_flags to give the VF information on whether it runs in trusted mode and makes use of the flag in i40evf. Patches are against jkirshers dev-queue branch. Stefan Assmann (2): i40e/i40evf: rename vf_offload_flags to vf_cap_flags in struct virtchnl_vf_resource

Re: [PATCH] i40e: handle setting administratively set MAC address back to zero

On 25.06.2017 08:21, Leon Romanovsky wrote: > On Fri, Jun 23, 2017 at 09:46:24AM +0200, Stefan Assmann wrote: >> When an administratively set MAC was previously set and should now be >> switched back to 00:00:00:00:00:00 the pf_set_mac flag did not get >> toggled back to fals

[PATCH] i40e: handle setting administratively set MAC address back to zero

When an administratively set MAC was previously set and should now be switched back to 00:00:00:00:00:00 the pf_set_mac flag did not get toggled back to false. As a result VFs were still treated as if an administratively set MAC was present. Signed-off-by: Stefan Assmann <sassm...@kpanic

Re: [PATCH] i40e: limit client interface to X722 hardware

On 04.04.2017 18:56, Or Gerlitz wrote: > On Tue, Apr 4, 2017 at 5:34 PM, Stefan Assmann <sassm...@kpanic.de> wrote: >> The client interface is meant for X722 iWARP support. Modprobing i40iw >> on systems with X710/XL710 NICs currently may crash the system. > > just cu

[PATCH] i40e: limit client interface to X722 hardware

The client interface is meant for X722 iWARP support. Modprobing i40iw on systems with X710/XL710 NICs currently may crash the system. Adding a check which limits client interface access to the appropriate hardware. Signed-off-by: Stefan Assmann <sassm...@kpanic.de> --- drivers/net/et

Re: [net-next PATCH] i40e: Clean up handling of msg_enable flags and debug parameter

On 29.09.2016 14:05, Alexander Duyck wrote: > So the i40e driver had a really convoluted configuration for how to handle > the debug flags contained in msg_enable. Part of the issue is that the > driver has its own 32 bit mask that it was using to track a separate set of > debug features. From

Re: [Intel-wired-lan] [PATCH net-next v2 1/2] i40e: remove superfluous I40E_DEBUG_USER statement

On 24.09.2016 04:48, Alexander Duyck wrote: > On Fri, Sep 23, 2016 at 6:30 AM, Stefan Assmann <sassm...@kpanic.de> wrote: >> This debug statement is confusing and never set in the code. Any debug >> output should be guarded by the proper I40E_DEBUG_* statement which can >&g

[PATCH net-next v2 0/2] i40e: clean-up and fix for the i40e debug code

v2 fixes setting the debug_mask in i40e_set_msglevel(). Stefan Assmann (2): i40e: remove superfluous I40E_DEBUG_USER statement i40e: fix setting debug parameter early drivers/net/ethernet/intel/i40e/i40e_common.c | 3 -- drivers/net/ethernet/intel/i40e/i40e_debugfs.c | 6 drivers

[PATCH net-next v2 2/2] i40e: fix setting debug parameter early

itmask as that's what the driver actually uses in i40e_debug(). Otherwise the debug parameter is just a noop. Fixes: 5b5faa4 ("i40e: enable debug earlier") Signed-off-by: Stefan Assmann <sassm...@kpanic.de> --- drivers/net/ethernet/intel/i40e/i40e_main.c | 16 +++- 1

[PATCH net-next v2 1/2] i40e: remove superfluous I40E_DEBUG_USER statement

in i40e_set_msglevel() so that the debug level can still be altered via ethtool msglvl. Signed-off-by: Stefan Assmann <sassm...@kpanic.de> --- drivers/net/ethernet/intel/i40e/i40e_common.c | 3 --- drivers/net/ethernet/intel/i40e/i40e_debugfs.c | 6 - drivers/net/ethernet/inte

[PATCH net-next 2/3] i40e: fix MSI-X vector redistribution if hw limit is reached

, attempting to redistribute vectors i40e 00.0 MSI-X vector distribution: PF 78, VMDq 8, FDSB 0, iWARP 42 Signed-off-by: Stefan Assmann <sassm...@kpanic.de> --- drivers/net/ethernet/intel/i40e/i40e_main.c | 38 + 1 file changed, 22 insertions(+), 16 deletions(-) diff

[PATCH net-next 1/3] i40e: check if vectors are already depleted when doing VMDq allocation

During MSI-X vector allocation for VMDq, a check for "no vectors left" was missing, add it. This prevents more vectors to be allocated than available. Signed-off-by: Stefan Assmann <sassm...@kpanic.de> --- drivers/net/ethernet/intel/i40e/i40e_main.c | 27 ---

[PATCH net-next 0/3] i40e: fix MSI-X vector allocation for > 128 CPU threads

Stefan Assmann (3): i40e: check if vectors are already depleted when doing VMDq allocation i40e: fix MSI-X vector redistribution if hw limit is reached i40e: fix sideband flow director vector allocation drivers/net/ethernet/intel/i40e/i40e_main.c | 76 ++--- 1 file

[PATCH net-next 3/3] i40e: fix sideband flow director vector allocation

Currently if the MSI-X vector limit is reached the sideband flow director gets disabled. A bit too early to make that decision, as vectors may get re-distributed. So move the check further back. Signed-off-by: Stefan Assmann <sassm...@kpanic.de> --- drivers/net/ethernet/intel/i40e/i40e_

[PATCH net-next 0/2] i40e: clean-up and fix for the i40e debug code

Stefan Assmann (2): i40e: remove superfluous I40E_DEBUG_USER statement i40e: fix setting debug parameter early drivers/net/ethernet/intel/i40e/i40e_common.c | 3 -- drivers/net/ethernet/intel/i40e/i40e_debugfs.c | 6 drivers/net/ethernet/intel/i40e/i40e_ethtool.c | 2 -- drivers/net

[PATCH net-next 2/2] i40e: fix setting debug parameter early

itmask as that's what the driver actually uses in i40e_debug(). Otherwise the debug parameter is just a noop. Fixes: 5b5faa4 ("i40e: enable debug earlier") Signed-off-by: Stefan Assmann <sassm...@kpanic.de> --- drivers/net/ethernet/intel/i40e/i40e_main.c | 16 +++- 1

[PATCH net-next 1/2] i40e: remove superfluous I40E_DEBUG_USER statement

This debug statement is confusing and never set in the code. Any debug output should be guarded by the proper I40E_DEBUG_* statement which can be enabled via the debug module parameter. Remove or convert the I40E_DEBUG_USER cases to I40E_DEBUG_INIT. Signed-off-by: Stefan Assmann <sa

[PATCH net-next] i40e: add missing link advertise setting

-negotiation: No Advertised link modes: 1baseT/Full [...] Signed-off-by: Stefan Assmann <sassm...@kpanic.de> --- drivers/net/ethernet/intel/i40e/i40e_ethtool.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ethernet/intel/i40e/i40e_ethtool.c b/drivers/net/et

Re: [net-next] igb: assume MSI-X interrupts during initialization

On 06.02.2016 00:13, Stefan Assmann wrote: > On 02/05/2016 10:24 PM, Laine Stump wrote: >> Stefan, >> >> I have an AMD 990FX system with an Intel 82576 card that could not >> successfully boot with any kernel starting somewhere prior to 4.2, but >> does boot prop

Re: [net-next] igb: assume MSI-X interrupts during initialization

: https://www.mail-archive.com/iommu@lists.linux-foundation.org/msg10687.html On 09/17/2015 08:46 AM, Stefan Assmann wrote: In igb_sw_init() the sequence of calls was changed from igb_init_queue_configuration() igb_init_interrupt_scheme() igb_probe_vfs() to igb_probe_vfs

[PATCH net-next V2 5/6] e1000: call ndo_stop() instead of dev_close() when running offline selftest

is inconsistent. Instead call the net_device_ops ndo_stop function directly and avoid touching IFF_UP at all. Signed-off-by: Stefan Assmann <sassm...@kpanic.de> --- drivers/net/ethernet/intel/e1000/e1000.h | 2 ++ drivers/net/ethernet/intel/e1000/e1000_ethtool.c | 4 ++-- drivers/net/et

[PATCH net-next V2 2/6] ixgbe: call ndo_stop() instead of dev_close() when running offline selftest

is inconsistent. Instead call the net_device_ops ndo_stop function directly and avoid touching IFF_UP at all. Signed-off-by: Stefan Assmann <sassm...@kpanic.de> --- drivers/net/ethernet/intel/ixgbe/ixgbe.h | 2 ++ drivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.c | 4 ++-- drivers/net/et

[PATCH net-next V2 4/6] igb: call ndo_stop() instead of dev_close() when running offline selftest

is inconsistent. Instead call the net_device_ops ndo_stop function directly and avoid touching IFF_UP at all. Signed-off-by: Stefan Assmann <sassm...@kpanic.de> --- drivers/net/ethernet/intel/igb/igb.h | 2 ++ drivers/net/ethernet/intel/igb/igb_ethtool.c | 4 ++-- drivers/net/ethernet/int

[PATCH net-next V2 6/6] e1000e: call ndo_stop() instead of dev_close() when running offline selftest

is inconsistent. Instead call the net_device_ops ndo_stop function directly and avoid touching IFF_UP at all. V2: rename e1000_open(), e1000_close() to e1000e_open(), e1000e_close() to avoid name clash with e1000. Signed-off-by: Stefan Assmann <sassm...@kpanic.de> --- drivers/net/ethernet/intel/

[PATCH net-next V2 0/6] net/intel: call ndo_stop() instead of dev_close() when running offline selftest

(), e1000e_close() to avoid name clash with e1000. Stefan Assmann (6): i40e: call ndo_stop() instead of dev_close() when running offline selftest ixgbe: call ndo_stop() instead of dev_close() when running offline selftest ixgbevf: call ndo_stop() instead of dev_close() when running

[PATCH net-next V2 1/6] i40e: call ndo_stop() instead of dev_close() when running offline selftest

is inconsistent. Instead call the net_device_ops ndo_stop function directly and avoid touching IFF_UP at all. Signed-off-by: Stefan Assmann <sassm...@kpanic.de> --- drivers/net/ethernet/intel/i40e/i40e.h | 2 +- drivers/net/ethernet/intel/i40e/i40e_ethtool.c | 4 ++-- drivers/net/ethernet

[PATCH net-next V2 3/6] ixgbevf: call ndo_stop() instead of dev_close() when running offline selftest

is inconsistent. Instead call the net_device_ops ndo_stop function directly and avoid touching IFF_UP at all. Signed-off-by: Stefan Assmann <sassm...@kpanic.de> --- drivers/net/ethernet/intel/ixgbevf/ethtool.c | 4 ++-- drivers/net/ethernet/intel/ixgbevf/ixgbevf.h | 2 ++ drivers/net/et

Re: [PATCH net-next 6/6] e1000e: call ndo_stop() instead of dev_close() when running offline selftest

On 02.02.2016 22:28, David Miller wrote: > > Always, when sending an updated version of a patch which is part of a > series, always resubmit the entire series rather than just the patch > which is changing. > > Thanks. > Sorry Dave, going to send out a complete V2 right away. Stefan

[PATCH net-next 1/6] i40e: call ndo_stop() instead of dev_close() when running offline selftest

is inconsistent. Instead call the net_device_ops ndo_stop function directly and avoid touching IFF_UP at all. Signed-off-by: Stefan Assmann <sassm...@kpanic.de> --- drivers/net/ethernet/intel/i40e/i40e.h | 2 +- drivers/net/ethernet/intel/i40e/i40e_ethtool.c | 4 ++-- drivers/net/ethernet

[PATCH net-next 5/6] e1000: call ndo_stop() instead of dev_close() when running offline selftest

is inconsistent. Instead call the net_device_ops ndo_stop function directly and avoid touching IFF_UP at all. Signed-off-by: Stefan Assmann <sassm...@kpanic.de> --- drivers/net/ethernet/intel/e1000/e1000.h | 2 ++ drivers/net/ethernet/intel/e1000/e1000_ethtool.c | 4 ++-- drivers/net/et

[PATCH net-next 2/6] ixgbe: call ndo_stop() instead of dev_close() when running offline selftest

is inconsistent. Instead call the net_device_ops ndo_stop function directly and avoid touching IFF_UP at all. Signed-off-by: Stefan Assmann <sassm...@kpanic.de> --- drivers/net/ethernet/intel/ixgbe/ixgbe.h | 2 ++ drivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.c | 4 ++-- drivers/net/et

[PATCH net-next 0/6] net/intel: call ndo_stop() instead of dev_close() when running offline selftest

is inconsistent. Instead call the net_device_ops ndo_stop function directly and avoid touching IFF_UP at all. Tested this with igb, e1000e, ixgbe and i40e. All drivers now are able to resume operation without restoring the IP address, gateway or such. Stefan Assmann (6): i40e: call ndo_stop() instead

[PATCH net-next 3/6] ixgbevf: call ndo_stop() instead of dev_close() when running offline selftest

is inconsistent. Instead call the net_device_ops ndo_stop function directly and avoid touching IFF_UP at all. Signed-off-by: Stefan Assmann <sassm...@kpanic.de> --- drivers/net/ethernet/intel/ixgbevf/ethtool.c | 4 ++-- drivers/net/ethernet/intel/ixgbevf/ixgbevf.h | 2 ++ drivers/net/et

[PATCH net-next 4/6] igb: call ndo_stop() instead of dev_close() when running offline selftest

is inconsistent. Instead call the net_device_ops ndo_stop function directly and avoid touching IFF_UP at all. Signed-off-by: Stefan Assmann <sassm...@kpanic.de> --- drivers/net/ethernet/intel/igb/igb.h | 2 ++ drivers/net/ethernet/intel/igb/igb_ethtool.c | 4 ++-- drivers/net/ethernet/int

[PATCH net-next 6/6] e1000e: call ndo_stop() instead of dev_close() when running offline selftest

is inconsistent. Instead call the net_device_ops ndo_stop function directly and avoid touching IFF_UP at all. Signed-off-by: Stefan Assmann <sassm...@kpanic.de> --- drivers/net/ethernet/intel/e1000e/e1000.h | 2 ++ drivers/net/ethernet/intel/e1000e/ethtool.c | 4 ++-- drivers/net/ethernet/intel/

Re: [PATCH net-next 6/6] e1000e: call ndo_stop() instead of dev_close() when running offline selftest

Here's a V2 that fixes the name collision. >From 8f617672b97324058adf5b8981c4b91defad8c3a Mon Sep 17 00:00:00 2001 From: Stefan Assmann <sassm...@kpanic.de> Date: Mon, 1 Feb 2016 13:18:24 +0100 Subject: [PATCH net-next] e1000e: call ndo_stop() instead of dev_close() when running offline

[PATCH net-next] igb: assume MSI-X interrupts during initialization

e calling igb_probe_vfs(). The real interrupt capabilities will be checked during igb_init_interrupt_scheme() so this is safe to do. Signed-off-by: Stefan Assmann <sassm...@kpanic.de> --- drivers/net/ethernet/intel/igb/igb_main.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drive

[PATCH] igbvf: clear buffer_info-dma after dma_unmap_single()

] [...] Signed-off-by: Stefan Assmann sassm...@kpanic.de --- drivers/net/ethernet/intel/igbvf/netdev.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ethernet/intel/igbvf/netdev.c b/drivers/net/ethernet/intel/igbvf/netdev.c index 95af14e..686fa71 100644 --- a/drivers/net/ethernet

[PATCH] igb: do not re-init SR-IOV during probe

-by: Stefan Assmann sassm...@kpanic.de --- drivers/net/ethernet/intel/igb/igb_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/intel/igb/igb_main.c b/drivers/net/ethernet/intel/igb/igb_main.c index f287186..7f41237 100644 --- a/drivers/net/ethernet/intel

VM guest bridging issue with i40e

There's some trouble with a kvm guest that is bridged to the host networks i40e (X710) NIC. The guest no longer receives DHCP replies and probably other traffic as well. I bisected this back to the following commit. commit 79c21a827e98081895a8b9650f1b0a8b37b16125 Author: Anjali Singhai Jain