Re: [PATCH iproute2] bridge/mdb: fix missing new line when show bridge mdb

On Wed, 5 Sep 2018 11:33:43 +0800 Hangbin Liu wrote: > The bridge mdb show is broken on current iproute2. e.g. > ]# bridge mdb show > 34: br0 veth0_br 224.1.1.2 temp 34: br0 veth0_br 224.1.1.1 temp > > After fix: > ]# bridge mdb show > 34: br0 veth0_br 224.1.1.2 temp > 34: br0

Re: [PATCH iproute2] tc/mqprio: Print extra info on invalid args.

On Wed, 5 Sep 2018 13:24:19 -0700 Caleb Raitto wrote: > From: Caleb Raitto > > Print the name of the argument that wasn't understood, and also print > the usage string. > > Signed-off-by: Caleb Raitto The standard code pattern in iproute2 is to use invarg(). Why not use that?

Re: [PATCH v3 3/3] IB/ipoib: Log sysfs 'dev_id' accesses from userspace

On Mon, 3 Sep 2018 19:13:16 +0300 Arseny Maslennikov wrote: > + if (ndev->dev_id == ndev->dev_port) { > + netdev_info_once(ndev, > + "\"%s\" wants to know my dev_id. " > + "Should it look at dev_port instead?\n", > +

Re: [PATCH RFC net-next 18/18] net/ipv4: Optimization for fib_info lookup

On Fri, 31 Aug 2018 17:49:53 -0700 dsah...@kernel.org wrote: > +static inline unsigned int fib_info_hashfn_cfg(const struct fib_config *cfg) > +{ > + unsigned int mask = (fib_info_hash_size - 1); > + unsigned int val = 0; > + > + val ^= (cfg->fc_protocol << 8) | cfg->fc_scope; Why do

Re: [PATCH iproute2-next] ip: Add support for nexthop objects

On Fri, 31 Aug 2018 17:49:54 -0700 dsah...@kernel.org wrote: > From: David Ahern > > Signed-off-by: David Ahern > --- > include/uapi/linux/nexthop.h | 56 > include/uapi/linux/rtnetlink.h | 8 + > ip/Makefile| 3 +- > ip/ip.c| 3 +- >

Re: [PATCH iproute2] tc/htb: remove unused variable

On Thu, 30 Aug 2018 16:38:54 +0200 Florent Fourcot wrote: > Since introduction of htb module, this variable has never been used. > > Signed-off-by: Florent Fourcot Looks good. Applied

Re: [PATCHv3 iproute2 0/2] clang + misc changes

On Wed, 22 Aug 2018 18:01:30 -0700 Mahesh Bandewar wrote: > From: Mahesh Bandewar > > The primary theme is to make clang compile the iproute2 package without > warnings. Along with this there are two other misc patches in the series. > > First patch uses the preferred_family when operating

Re: [Patch iproute2 v2] ss: add UNIX_DIAG_VFS and UNIX_DIAG_ICONS for unix sockets

On Wed, 29 Aug 2018 10:09:27 -0700 Cong Wang wrote: > UNIX_DIAG_VFS and UNIX_DIAG_ICONS are never used by ss, > make them available in ss -e output. > > Cc: Stephen Hemminger > Signed-off-by: Cong Wang Applied, thanks

Re: [iproute PATCH] iprule: Fix for incorrect space between dst and prefix

On Wed, 29 Aug 2018 15:52:57 +0200 Phil Sutter wrote: > This was added by accident when introducing JSON support. > > Fixes: 0dd4ccc56c0e3 ("iprule: add json support") > Signed-off-by: Phil Sutter Applied, thanks.

Re: Kernel warnings from tcp.c

On Wed, 29 Aug 2018 14:38:38 -0400 Adam Mitchell wrote: > Anyone with experience in tcp.c have an idea what's causing this on > our busy database server? Comes from this macro at line 2278: > WARN_ON(sock_owned_by_user(sk)); > > > [726780.788201] WARNING: CPU: 15 PID: 52245 at

[PATCH net-next 2/2] hv_netvsc: pair VF based on serial number

Matching network device based on MAC address is problematic since a non-VF network device can be created with a duplicate MAC address causing confusion and problems. The VMBus API provides a serial number that is a better matching method. Signed-off-by: Stephen Hemminger --- drivers/net/hyperv

[PATCH net-next 0/2] hv_netvsc: associate VF and PV device by serial number

together here for better review. The PCI changes were submitted previously, but the main review comment was "why do you need this?". This is why. Stephen Hemminger (2): PCI: hv: support reporting serial number as slot information hv_netvsc: pair VF based on serial number drivers/

[PATCH net-next 1/2] PCI: hv: support reporting serial number as slot information

names for VF devices. It does not break applications or startup because the VF device must never be configured directly. Signed-off-by: Stephen Hemminger --- drivers/pci/controller/pci-hyperv.c | 30 + 1 file changed, 30 insertions(+) diff --git a/drivers/pci/controller/pci

Re: [Patch iproute2] ss: add UNIX_DIAG_VFS and UNIX_DIAG_ICONS for unix sockets

On Tue, 28 Aug 2018 16:16:49 -0700 Cong Wang wrote: > On Mon, Aug 27, 2018 at 3:27 PM Stephen Hemminger > wrote: > > > > On Mon, 27 Aug 2018 14:46:52 -0700 > > Cong Wang wrote: > > > > > UNIX_DIAG_VFS and UNIX_DIAG_ICONS are never used by ss, &g

Re: [PATCH] rtnetlink: expose value from SET_NETDEV_DEVTYPE via IFLA_DEVTYPE attribute

On Wed, 29 Aug 2018 09:18:55 +0200 Jiri Pirko wrote: > Tue, Aug 28, 2018 at 10:58:11PM CEST, mar...@holtmann.org wrote: > >The name value from SET_NETDEV_DEVTYPE only ended up in the uevent sysfs > >file as DEVTYPE= information. To avoid any kind of race conditions > >between netlink messages

Re: [PATCH v2 iproute2-next 2/5] bridge: colorize output and use JSON print library

On Sat, 14 Jul 2018 18:41:03 -0700 Roopa Prabhu wrote: > On Tue, Feb 20, 2018 at 11:24 AM, Stephen Hemminger > wrote: > > From: Stephen Hemminger > > > > Use new functions from json_print to simplify code. > > Provide standard flag for colorizing output.

Fw: [Bug 200943] New: Repeating tcp_mark_head_lost in dmesg

Begin forwarded message: Date: Sun, 26 Aug 2018 22:24:12 + From: bugzilla-dae...@bugzilla.kernel.org To: step...@networkplumber.org Subject: [Bug 200943] New: Repeating tcp_mark_head_lost in dmesg https://bugzilla.kernel.org/show_bug.cgi?id=200943 Bug ID: 200943

Fw: [Bug 200967] New: No network with U.S. Robotics USR997902

Begin forwarded message: Date: Wed, 29 Aug 2018 04:36:20 + From: bugzilla-dae...@bugzilla.kernel.org To: step...@networkplumber.org Subject: [Bug 200967] New: No network with U.S. Robotics USR997902 https://bugzilla.kernel.org/show_bug.cgi?id=200967 Bug ID: 200967

Re: [Patch iproute2] ss: add UNIX_DIAG_VFS and UNIX_DIAG_ICONS for unix sockets

On Mon, 27 Aug 2018 14:46:52 -0700 Cong Wang wrote: > UNIX_DIAG_VFS and UNIX_DIAG_ICONS are never used by ss, > make them available in ss -e output. > > Cc: Stephen Hemminger > Signed-off-by: Cong Wang > --- > misc/ss.c | 25 + > 1 fil

Re: [PATCH RFC net-next] net/fib: Poptrie based FIB lookup

On Sun, 26 Aug 2018 22:28:48 -0400 "Md. Islam" wrote: > This patch implements Poptrie [1] based FIB lookup. It exhibits pretty > impressive lookup performance compared to LC-trie. This poptrie > implementation however somewhat deviates from the original > implementation [2]. I tested this patch

Re: [PATCH v2 iproute2-next 1/3] tc: support conversions to or from 64 bit nanosecond-based time

On Sun, 26 Aug 2018 19:42:28 -0700 Yousuk Seung wrote: > +int get_time(unsigned int *time, const char *str) > +{ > + double t; > + char *p; > + > + t = strtod(str, ); > + if (p == str) > + return -1; > + > + if (*p) { > + if (strcasecmp(p, "s") == 0 ||

Re: confusing comment, explanation of @IFF_RUNNING in if.h

On Sun, 26 Aug 2018 15:20:24 -0400 (EDT) "Robert P. J. Day" wrote: > On Sun, 26 Aug 2018, Andrew Lunn wrote: > > > > i ask since, in my testing, when the interface should have been > > > up, the attribute file "operstate" for that interface showed > > > "unknown", and i wondered how worried i

Re: followup: what's responsible for setting netdev->operstate to IF_OPER_DOWN?

On Sun, 26 Aug 2018 11:14:33 -0400 (EDT) "Robert P. J. Day" wrote: > apologies for the constant pleas for assistance, but i think i'm > zeroing in on the problem that started all this. recap: custom > FPGA-based linux box with multiple ports, where the current symptom is > that there is no

Re: is "volatile" the cause of ifconfig flags not matching sysfs flags?

On Wed, 22 Aug 2018 18:32:36 -0400 (EDT) "Robert P. J. Day" wrote: > almost certainly another dumb question, but i was poking around the > sysfs, particularly /sys/class/net//*, to familiarize myself > with what i can glean (or set) re interfaces under /sys, and i noticed > "flags", but what i

Fw: [Bug 200879] New: Poor network performance using CX-5 Mellanox card

Begin forwarded message: Date: Tue, 21 Aug 2018 18:37:01 + From: bugzilla-dae...@bugzilla.kernel.org To: step...@networkplumber.org Subject: [Bug 200879] New: Poor network performance using CX-5 Mellanox card https://bugzilla.kernel.org/show_bug.cgi?id=200879 Bug ID: 200879

Re: [PATCHv2 iproute2 2/3] tc: remove extern from prototype declarations

On Tue, 21 Aug 2018 10:48:54 -0700 Mahesh Bandewar wrote: > From: Mahesh Bandewar > > Signed-off-by: Mahesh Bandewar I already did this yesterday. Patch was on mailing list.

[PATCH net] hv_netvsc: ignore devices that are not PCI

Registering another device with same MAC address (such as TAP, VPN or DPDK KNI) will confuse the VF autobinding logic. Restrict the search to only run if the device is known to be a PCI attached VF. Fixes: e8ff40d4bff1 ("hv_netvsc: improve VF device matching") Signed-off-by: Stephen

Re: [PATCH iproute2] iproute: make clang happy

On Mon, 20 Aug 2018 16:44:28 -0700 Mahesh Bandewar (महेश बंडेवार) wrote: > On Mon, Aug 20, 2018 at 4:38 PM, Mahesh Bandewar (महेश बंडेवार) > wrote: > > On Mon, Aug 20, 2018 at 3:52 PM, Stephen Hemminger > > wrote: > >> On Mon, 20 Aug 2018 14:42:15 -0700

[PATCH iproute2 3/4] genl: drop extern from function prototypes

Signed-off-by: Stephen Hemminger --- genl/genl_utils.h | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/genl/genl_utils.h b/genl/genl_utils.h index 6e6f44501aba..3de0da34bdba 100644 --- a/genl/genl_utils.h +++ b/genl/genl_utils.h @@ -10,9 +10,10 @@ struct genl_util

[PATCH iproute2 1/4] ip: drop extern from function prototype

Signed-off-by: Stephen Hemminger --- ip/ip_common.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ip/ip_common.h b/ip/ip_common.h index 4d3227cbc389..200be5e23dd1 100644 --- a/ip/ip_common.h +++ b/ip/ip_common.h @@ -82,7 +82,7 @@ int do_netns(int argc, char **argv); int

[PATCH iproute2 0/4] drop extern from function prototypes

iproute2 uses kernel style guidelines Stephen Hemminger (4): ip: drop extern from function prototype bridge: drop extern from function prototypes genl: drop extern from function prototypes tc: drop extern from function prototypes bridge/br_common.h | 18 +- genl

[PATCH iproute2 2/4] bridge: drop extern from function prototypes

Signed-off-by: Stephen Hemminger --- bridge/br_common.h | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/bridge/br_common.h b/bridge/br_common.h index 2f1cb8fd9f3d..7bf15e9548fc 100644 --- a/bridge/br_common.h +++ b/bridge/br_common.h @@ -6,20 +6,20

[PATCH iproute2 4/4] tc: drop extern from function prototypes

Signed-off-by: Stephen Hemminger --- tc/m_ematch.h | 35 +++ tc/m_pedit.h | 31 +++ tc/tc_common.h | 30 +++--- tc/tc_red.h| 7 --- 4 files changed, 49 insertions(+), 54 deletions(-) diff --git a/tc

Re: [PATCH iproute2] iproute: make clang happy

On Mon, 20 Aug 2018 14:42:15 -0700 Mahesh Bandewar wrote: > diff --git a/tc/m_ematch.c b/tc/m_ematch.c > index ace4b3dd738b..a524b520b276 100644 > --- a/tc/m_ematch.c > +++ b/tc/m_ematch.c > @@ -277,6 +277,7 @@ static int flatten_tree(struct ematch *head, struct > ematch *tree) > return

Re: [PATCH iproute2] iproute: make clang happy

On Mon, 20 Aug 2018 14:42:15 -0700 Mahesh Bandewar wrote: > > if (is_json_context()) { > + json_writer_t *jw; > + > open_json_object("bittiming"); > print_int(PRINT_ANY, "bitrate", NULL, bt->bitrate); > -

Re: [PATCH] sunhme: convert printk to pr_cont

On Fri, 17 Aug 2018 15:12:22 -0400 (EDT) Mikulas Patocka wrote: > === > --- linux-stable.orig/drivers/net/ethernet/sun/sunhme.c 2018-04-20 > 18:11:00.0 +0200 > +++ linux-stable/drivers/net/ethernet/sun/sunhme.c

Re: [PATCH iproute2] ipmaddr: use preferred_family when given

On Wed, 15 Aug 2018 16:08:55 -0700 Mahesh Bandewar wrote: > From: Mahesh Bandewar > > When creating socket() AF_INET is used irrespective of the family > that is given at the command-line (with -4, -6, or -0). This change > will open the socket with the preferred family. > > Signed-off-by:

Re: [iproute PATCH v4] Make colored output configurable

On Thu, 16 Aug 2018 11:37:03 +0200 Phil Sutter wrote: > Allow for -color={never,auto,always} to have colored output disabled, > enabled only if stdout is a terminal or enabled regardless of stdout > state. > > Signed-off-by: Phil Sutter > --- > Changes since v1: > - Allow to override isatty()

Re: [PATCH iproute2-next] iproute_lwtunnel: allow specifying 'src' for 'encap ip' / 'encap ip6'

On Fri, 17 Aug 2018 10:31:34 +0300 Shmulik Ladkani wrote: > This allows the user to specify the LWTUNNEL_IP_SRC/LWTUNNEL_IP6_SRC > when setting an lwtunnel encapsulation route. > > Signed-off-by: Shmulik Ladkani > --- > ip/iproute_lwtunnel.c | 22 -- > 1 file changed, 20

Re: [iproute PATCH 00/10] Review help texts and man pages

On Thu, 16 Aug 2018 12:27:52 +0200 Phil Sutter wrote: > This series fixes a number of issues identified by an automated scan > over man pages and help texts. > > Phil Sutter (10): > man: bridge.8: Document -oneline option > bridge: trivial: Make help text consistent > devlink: trivial:

Re: [iproute PATCH 0/3] Fix and test ssfilter

On Tue, 14 Aug 2018 14:18:05 +0200 Phil Sutter wrote: > This series contains a fix for ssfilter and introduces a testscript to > verify correct functionality. > > Phil Sutter (3): > ss: Review ssfilter > testsuite: Prepare for ss tests > testsuite: Add a first ss test validating ssfilter

Re: [iproute PATCH] man: ip-route: Clarify referenced versions are Linux ones

On Wed, 15 Aug 2018 11:18:26 +0200 Phil Sutter wrote: > Versioning scheme of Linux and iproute2 is similar, therefore the > referenced kernel versions are likely to confuse readers. Clarify this > by prefixing each kernel version by 'Linux' prefix. > Sure, makes sense applied.

[PATCH 1/2] ip: convert monitor to switch

From: Stephen Hemminger The decoding of netlink message types is natural for a C switch statement. Signed-off-by: Stephen Hemminger --- ip/ipmonitor.c | 63 ++ 1 file changed, 38 insertions(+), 25 deletions(-) diff --git a/ip/ipmonitor.c b/ip

[PATCH 2/2] ipmonitor: decode DELNETCONF message

From: Stephen Hemminger When device is deleted DELNETCONF is sent, but ipmonitor was unable to decode it. Signed-off-by: Stephen Hemminger --- ip/ipmonitor.c | 1 + ip/ipnetconf.c | 6 +- 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/ip/ipmonitor.c b/ip/ipmonitor.c index

[PATCH iproute2 0/2] ip monitor fixes

While debugging another problem noticed that ip monitor does not decode all the netconf messages. Stephen Hemminger (2): ip: convert monitor to switch ipmonitor: decode DELNETCONF message ip/ipmonitor.c | 64 ++ ip/ipnetconf.c | 6 - 2

Re: [iproute PATCH v2 4/4] lib: Enable colored output only for TTYs

On Wed, 15 Aug 2018 18:51:15 +0200 Phil Sutter wrote: > On Wed, Aug 15, 2018 at 10:43:25AM -0600, David Ahern wrote: > > On 8/15/18 10:39 AM, Phil Sutter wrote: > > > On Wed, Aug 15, 2018 at 10:24:31AM -0600, David Ahern wrote: > > >> On 8/15/18 10:21 AM, Phil Sutter wrote: > > >>> Add an

Re: [iproute PATCH 4/4] lib: Enable colored output only for TTYs

On Wed, 15 Aug 2018 08:40:20 -0600 David Ahern wrote: > On 8/15/18 3:06 AM, Phil Sutter wrote: > > Add an additional prerequisite to check_enable_color() to make sure > > stdout actually points to an open TTY device. Otherwise calls like > > > > | ip -color a s >/tmp/foo > > > > will print

Re: [PATCH] hv/netvsc: Fix NULL dereference at single queue mode fallback

> mode") > Cc: > Signed-off-by: Takashi Iwai Reviewed-by: Stephen Hemminger

Re: [PATCH iproute2/net-next v2] tc_util: Add support for showing TCA_STATS_BASIC_HW statistics

On Fri, 10 Aug 2018 07:59:30 -0400 Eelco Chaudron wrote: > + if (bs.bytes >= bs_hw.bytes && bs.packets >= bs_hw.packets) { > + print_string(PRINT_FP, NULL, "%s", _SL_); > + print_string(PRINT_FP, NULL, "%s", prefix); > +

Re: [PATCH iproute2/net-next] tc_util: Add support for showing TCA_STATS_BASIC_HW statistics

On Thu, 9 Aug 2018 11:16:02 -0400 Eelco Chaudron wrote: > > +static void print_tcstats_basic_hw(struct rtattr **tbs, char *prefix) > +{ > + struct gnet_stats_basic bs = {0}; If not present don't print it rather than printing zero. > + struct gnet_stats_basic bs_hw = {0}; This

Re: [PATCH iproute2] ip link: don't stop batch processing

On Fri, 3 Aug 2018 19:49:33 +0200 Matteo Croce wrote: > When 'ip link show dev DEVICE' is processed in a batch mode, ip exits > and stop processing further commands. > This because ipaddr_list_flush_or_save() calls exit() to avoid printing > the link information twice. > Replace the exit with a

Re: [PATCH iproute2] ip link: don't stop batch processing

On Fri, 3 Aug 2018 11:08:58 -0700 Dave Taht wrote: > On Fri, Aug 3, 2018 at 10:50 AM Matteo Croce wrote: > > > > When 'ip link show dev DEVICE' is processed in a batch mode, ip exits > > and stop processing further commands. > > This because ipaddr_list_flush_or_save() calls exit() to avoid

Re: [PATCH] net/bridge/br_multicast: remove redundant variable "err"

On Sun, 5 Aug 2018 22:18:43 +0800 zhong jiang wrote: > The err is not used after initalization, So remove it and make > it void function. > > Signed-off-by: zhong jiang Makes sense to me. Acked-by: Stephen Hemminger

Re: consequences of setting net_device_ops ndo_change_carrier()?

On Sat, 4 Aug 2018 07:57:56 -0400 (EDT) "Robert P. J. Day" wrote: > On Sat, 4 Aug 2018, Jiri Pirko wrote: > > > Sat, Aug 04, 2018 at 01:06:58PM CEST, rpj...@crashcourse.ca wrote: > > > > > > i'll try to keep this (relatively) short as there may be a simple > > >answer to this, or it could

Re: [PATCH nf-next v2 1/1] ipv6: defrag: drop non-last frags smaller than min mtu

On Fri, 3 Aug 2018 02:05:39 +0200 Florian Westphal wrote: > + if (-skb_network_offset(skb) + skb->len < IPV6_MIN_MTU && Is there a reason to write the arithmetic expression in this order? Why not: if (skb->len - skb_network_offset(skb) < IPV6_MIN_MTU &&

Re: [PATCH v2 net-next 1/3] ip: discard IPv4 datagrams with overlapping segments.

rlapping IPv6 Fragments Acked-by: Stephen Hemminger

Re: [PATCH net-next 1/3] ip: discard IPv4 datagrams with overlapping segments.

On Thu, 2 Aug 2018 16:33:55 -0700 Eric Dumazet wrote: > On 08/02/2018 03:54 PM, Stephen Hemminger wrote: > > On Thu, 2 Aug 2018 22:45:58 + > > Peter Oskolkov wrote: > > > >> diff --git a/include/uapi/linux/snmp.h b/include/uapi/linux/snmp.h > >>

Re: [PATCH net-next 1/3] ip: discard IPv4 datagrams with overlapping segments.

On Thu, 2 Aug 2018 22:45:58 + Peter Oskolkov wrote: > diff --git a/include/uapi/linux/snmp.h b/include/uapi/linux/snmp.h > index e5ebc83827ab..da1a144f1a51 100644 > --- a/include/uapi/linux/snmp.h > +++ b/include/uapi/linux/snmp.h > @@ -40,6 +40,7 @@ enum > IPSTATS_MIB_REASMREQDS,

Re: [PATCH net-next 2/4] tcp: add data bytes retransmitted stats

On Mon, 30 Jul 2018 14:59:09 -0700 Wei Wang wrote: > + stats = alloc_skb(9 * nla_total_size_64bit(sizeof(u64)) + > 7 * nla_total_size(sizeof(u32)) + > 3 * nla_total_size(sizeof(u8)), GFP_ATOMIC); This is getting a bit awkward. Maybe use the

Re: [PATCH net-next] virtio_net: force_napi_tx module param.

On Sun, 29 Jul 2018 09:00:27 -0700 (PDT) David Miller wrote: > From: Caleb Raitto > Date: Mon, 23 Jul 2018 16:11:19 -0700 > > > From: Caleb Raitto > > > > The driver disables tx napi if it's not certain that completions will > > be processed affine with tx service. > > > > Its heuristic

Re: [net-next 04/13] net/mlx5e: Vxlan, replace spinlock with read-write lock

On Fri, 27 Jul 2018 14:15:09 -0700 Saeed Mahameed wrote: > From: Gal Pressman > > The VXLAN database is mainly used by readers in data path, and rarely > used by control path writers. > Multiple readers (threads) should not block each other and cause an > unnecessary contention on the lock. >

Re: [iproute PATCH] lib/namespace: avoid double-mounting a /sys

On Tue, 24 Jul 2018 19:26:38 +0200 Lubomir Rintel wrote: > This partly reverts 8f0807023d067e2bb585a2ae8da93e59689d10f1, bringing > back the umount(/sys) attempt. > > In a LXC container we're unable to umount the sysfs instance, nor mount > a read-write one. We still are able to create a new

[PATCHi iproute2-next] ip: show min and max mtu

From: Stephen Hemminger Add min/max MTU to the link details Signed-off-by: Stephen Hemminger --- include/uapi/linux/if_link.h | 2 ++ ip/ipaddress.c | 10 ++ 2 files changed, 12 insertions(+) diff --git a/include/uapi/linux/if_link.h b/include/uapi/linux/if_link.h

[PATCH net-next 0/3] mtu related changes

While looking at other MTU issues, noticed a couple oppurtunties for improving user experience. Stephen Hemminger (3): failover: change mtu has RTNL net: report min and max mtu network device settings net: report invalid mtu value via netlink extack drivers/net/net_failover.c | 4

[PATCH net-next 1/3] failover: change mtu has RTNL

When changing MTU, RTNL is held so use rtnl_dereference instead of rcu_dereference. Signed-off-by: Stephen Hemminger --- drivers/net/net_failover.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/net_failover.c b/drivers/net/net_failover.c index d00d42c845b7

[PATCH net-next 3/3] net: report invalid mtu value via netlink extack

maximum. # ifconfig enp12s0 mtu 1 SIOCSIFMTU: Invalid argument # dmesg | tail -1 [ 2047.795467] enp12s0: mtu greater than device maximum Signed-off-by: Stephen Hemminger --- include/linux/netdevice.h | 2 ++ net/core/dev.c| 23

[PATCH net-next 2/3] net: report min and max mtu network device settings

Report the minimum and maximum MTU allowed on a device via netlink so that it can be displayed by tools like ip link. Signed-off-by: Stephen Hemminger --- include/uapi/linux/if_link.h | 2 ++ net/core/rtnetlink.c | 6 ++ 2 files changed, 8 insertions(+) diff --git a/include/uapi

Re: Deadlock with restart_syscall()

On Mon, 16 Jul 2018 09:31:06 +0200 André Pribil wrote: > Hello, > > I'm using kernel 4.14.52-rt34 on a single core ARM system and I'm seeing a > deadlock inside the kernel when two RT processes make calls in the right > temporal distance. The first process is trying to bring the Ethernet >

Re: [PATCH iproute2 0/3] l2tp: remove unused fields in struct l2tp_parm

On Fri, 27 Jul 2018 12:26:28 +0200 Guillaume Nault wrote: > Several fields of struct l2tp_parm are handled by create_session() but > can't actually be set by user. > Most of these fields can also be set by get_response(), but are ignored > afterwards. > > Since these fields can't have any

Re: [PATCH net-next] virtio_net: force_napi_tx module param.

On Mon, 23 Jul 2018 16:11:19 -0700 Caleb Raitto wrote: > From: Caleb Raitto > > The driver disables tx napi if it's not certain that completions will > be processed affine with tx service. > > Its heuristic doesn't account for some scenarios where it is, such as > when the queue pair count

Re: [PATCH iproute2] devlink: CTRL_ATTR_FAMILY_ID is a u16

On Fri, 20 Jul 2018 09:35:26 -0700 dsah...@kernel.org wrote: > From: David Ahern > > CTRL_ATTR_FAMILY_ID is a u16, not a u32. Update devlink accordingly. > > Fixes: a3c4b484a1edd ("add devlink tool") > Signed-off-by: David Ahern Applied

Re: [PATCH iproute2] ipaddress: Fix and make consistent label match handling

On Sun, 15 Jul 2018 00:36:34 +0300 Serhey Popovych wrote: > Since commit 9516823051ce ("ipaddress: Improve print_linkinfo()") we > return -1 instead of 0 when ip-address(8) label does not match network > device name as we did before change. This causes regression when trying > to output ip

Re: [PATCH iproute2 v2] ip: add support for seg6local End.BPF action

On Tue, 17 Jul 2018 14:49:52 + Mathieu Xhonneux wrote: > This patch adds support for the End.BPF action of the seg6local > lightweight tunnel. Functions from the BPF lightweight tunnel are > re-used in this patch. Example: > > $ ip -6 route add fc00::18 encap seg6local action End.BPF

Re: [net-next, v6, 6/7] net-sysfs: Add interface for Rx queue(s) map per Tx queue

On Wed, 18 Jul 2018 11:22:36 -0700 Andrei Vagin wrote: > On Tue, Jul 10, 2018 at 07:28:49PM -0700, Nambiar, Amritha wrote: > > On 7/4/2018 12:20 AM, Andrei Vagin wrote: > > > Hello Amritha, > > > > > > I see a following warning on 4.18.0-rc3-next-20180703. > > > It looks like a problem is in

[PATCH net 2/2] openvswitch: check for null return for nla_nest_start in datapath

: 8f0aad6f35f7 ("openvswitch: Extend packet attribute for egress tunnel info") Signed-off-by: Stephen Hemminger --- net/openvswitch/datapath.c | 8 1 file changed, 8 insertions(+) diff --git a/net/openvswitch/datapath.c b/net/openvswitch/datapath.c index 0f5ce77460d4..93c3eb635

[PATCH net 1/2] openvswitch: check for null return for nla_nest_start

("openvswitch: Support conntrack zone limit") Signed-off-by: Stephen Hemminger --- net/openvswitch/conntrack.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/net/openvswitch/conntrack.c b/net/openvswitch/conntrack.c index 284aca2a252d..2e316f641df8 100644 --- a/net/openvswitch/conntra

[PATCH net 0/2] openvswitch tests for nla_nest_start

Coverity is looking for bugs here, and a couple of new bugzilla reports showed up where nla_nest_start return is not checked for NULL. Stephen Hemminger (2): openvswitch: check for null return for nla_nest_start openvswitch: check for null return for nla_nest_start in datapath net

Re: [PATCH next] bonding: pass link-local packets to bonding master also.

On Mon, 16 Jul 2018 16:57:22 -0700 Mahesh Bandewar (महेश बंडेवार) wrote: > On Mon, Jul 16, 2018 at 4:33 PM, Stephen Hemminger > wrote: > > On Sun, 15 Jul 2018 18:12:46 -0700 > > Mahesh Bandewar wrote: > > > >> From: Mahesh Bandewar > >> > >>

Re: [PATCH next] bonding: pass link-local packets to bonding master also.

On Sun, 15 Jul 2018 18:12:46 -0700 Mahesh Bandewar wrote: > From: Mahesh Bandewar > > Commit b89f04c61efe ("bonding: deliver link-local packets with > skb->dev set to link that packets arrived on") changed the behavior > of how link-local-multicast packets are processed. The change in > the

Re: [PATCH iproute2] ip: add support for seg6local End.BPF action

On Mon, 16 Jul 2018 14:47:41 + Mathieu Xhonneux wrote: > This patch adds support for the End.BPF action of the seg6local > lightweight tunnel. Functions from the BPF lightweight tunnel are > re-used in this patch. Example: > > $ ip -6 route add fc00::18 encap seg6local action End.BPF obj

Re: [RFC iproute2-next v1 5/5] tc: Add support for configuring the taprio scheduler

On Fri, 13 Jul 2018 17:06:11 -0700 Vinicius Costa Gomes wrote: > + while (fscanf(f, "%ms %x %" PRIu32 "\n", _str, , > ) != EOF) { > + struct rtattr *entry; > + > + err = str_to_entry_cmd(cmd_str); > + free(cmd_str); > + > + if (err < 0) > +

Re: [PATCH iproute2-next] iplink: add support for reporting multiple XDP programs

On Fri, 13 Jul 2018 14:20:37 -0700 Jakub Kicinski wrote: > On Fri, 13 Jul 2018 13:59:41 -0700, Stephen Hemminger wrote: > > On Fri, 13 Jul 2018 13:43:59 -0700 > > Jakub Kicinski wrote: > > > > > > > > +static void xdp_dump_prog_one(FILE *fp, st

Re: [PATCH iproute2-next 0/9] TC more JSON support

On Fri, 13 Jul 2018 14:29:42 -0700 Jakub Kicinski wrote: > On Fri, 13 Jul 2018 16:48:28 -0400, David Ahern wrote: > > On 7/9/18 3:48 PM, Stephen Hemminger wrote: > > > From: Stephen Hemminger > > > > > > Update core of TC command and library to do mor

Re: [PATCH iproute2-next] iplink: add support for reporting multiple XDP programs

On Fri, 13 Jul 2018 13:43:59 -0700 Jakub Kicinski wrote: > > +static void xdp_dump_prog_one(FILE *fp, struct rtattr *tb[IFLA_XDP_MAX + 1], > + __u32 attr, bool link, bool details, char *pfx) > +{ > + __u32 prog_id; > + > + if (!tb[attr]) > +

[PATCH net] hv/netvsc: fix handling of fallback to single queue mode

Signed-off-by: Stephen Hemminger --- drivers/net/hyperv/rndis_filter.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/hyperv/rndis_filter.c b/drivers/net/hyperv/rndis_filter.c index 9b4e3c3787e5..408ece27131c 100644 --- a/drivers/net/hyperv/rndis_filter.c +++ b/drivers/

Re: [PATCH iproute2-next v2] net:sched: add action inheritdsfield to skbedit

On Thu, 12 Jul 2018 12:09:26 -0400 Qiaobin Fu wrote: > + if (*flags & SKBEDIT_F_INHERITDSFIELD) > + print_string(PRINT_ANY, "inheritdsfield", " %s", > + "inheritdsfield"); Flags should be represented in JSON output as a null value

Re: [PATCH iproute2-next] ipaddress: fix label matching

On Wed, 11 Jul 2018 13:36:03 +0200 Vincent Bernat wrote: > Since 9516823051ce, "ip addr show label lo:1" doesn't work > anymore (doesn't show any address, despite a matching label). > Reverting to return 0 instead of -1 fix the issue. > > However, the condition says: "if we filter by label

[PATCH v2 iproute2-next 19/31] tc/tbf: implement JSON output format

From: Stephen Hemminger Signed-off-by: Stephen Hemminger --- tc/q_tbf.c | 48 ++-- 1 file changed, 26 insertions(+), 22 deletions(-) diff --git a/tc/q_tbf.c b/tc/q_tbf.c index b9465b20d2be..2695b4fb00e6 100644 --- a/tc/q_tbf.c +++ b/tc/q_tbf.c

[PATCH v2 iproute2-next 15/31] tc/multiq: implement JSON output

From: Stephen Hemminger Signed-off-by: Stephen Hemminger --- tc/q_multiq.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tc/q_multiq.c b/tc/q_multiq.c index 8ad9e0b2fa3c..fd2d301bb0c6 100644 --- a/tc/q_multiq.c +++ b/tc/q_multiq.c @@ -70,7 +70,8 @@ static int

[PATCH v2 iproute2-next 10/31] tc/mqprio: implement JSON output

From: Stephen Hemminger Output queue options in JSON if requested. Signed-off-by: Stephen Hemminger --- tc/q_mqprio.c | 134 +++--- 1 file changed, 72 insertions(+), 62 deletions(-) diff --git a/tc/q_mqprio.c b/tc/q_mqprio.c index 207d6441d8fa

[PATCH v2 iproute2-next 11/31] tc/drr: implement JSON output

From: Stephen Hemminger Signed-off-by: Stephen Hemminger --- tc/q_drr.c | 10 +++--- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/tc/q_drr.c b/tc/q_drr.c index f9c90f3035f3..882cd4a37ec7 100644 --- a/tc/q_drr.c +++ b/tc/q_drr.c @@ -84,16 +84,14 @@ static int drr_print_opt

[PATCH v2 iproute2-next 28/31] tc/atm: convert to JSON output

From: Stephen Hemminger Signed-off-by: Stephen Hemminger --- tc/q_atm.c | 38 +++--- 1 file changed, 23 insertions(+), 15 deletions(-) diff --git a/tc/q_atm.c b/tc/q_atm.c index f8215f06507a..d5ab7a06b28f 100644 --- a/tc/q_atm.c +++ b/tc/q_atm.c @@ -194,37

[PATCH v2 iproute2-next 14/31] tc/sfb: implement JSON output

From: Stephen Hemminger Signed-off-by: Stephen Hemminger --- tc/q_sfb.c | 56 +- 1 file changed, 34 insertions(+), 22 deletions(-) diff --git a/tc/q_sfb.c b/tc/q_sfb.c index 7f48c6e0ef39..d58ce71f83ce 100644 --- a/tc/q_sfb.c +++ b/tc/q_sfb.c

[PATCH v2 iproute2-next 03/31] tc: convert stats print to json

From: Stephen Hemminger Convert compatiablity statistics to print in JSON. Signed-off-by: Stephen Hemminger --- tc/tc_util.c | 32 ++-- 1 file changed, 22 insertions(+), 10 deletions(-) diff --git a/tc/tc_util.c b/tc/tc_util.c index e8e1241d083d..05b6c97563b3

[PATCH v2 iproute2-next 27/31] tc/cbq: convert to JSON output

From: Stephen Hemminger Signed-off-by: Stephen Hemminger --- tc/q_cbq.c | 73 ++ 1 file changed, 40 insertions(+), 33 deletions(-) diff --git a/tc/q_cbq.c b/tc/q_cbq.c index ad0170c41858..525a5823b808 100644 --- a/tc/q_cbq.c +++ b/tc/q_cbq.c

[PATCH v2 iproute2-next 31/31] tc/fq_codel: use JSON helpers

From: Stephen Hemminger New routines make doing JSON output of time and size easier and consistent. Signed-off-by: Stephen Hemminger --- tc/q_fq_codel.c | 38 +- 1 file changed, 9 insertions(+), 29 deletions(-) diff --git a/tc/q_fq_codel.c b/tc

[PATCH v2 iproute2-next 12/31] tc/rr: implement JSON output

From: Stephen Hemminger Signed-off-by: Stephen Hemminger --- tc/q_rr.c | 16 +++- 1 file changed, 11 insertions(+), 5 deletions(-) diff --git a/tc/q_rr.c b/tc/q_rr.c index 843a4faeef41..dcc58ac98ba2 100644 --- a/tc/q_rr.c +++ b/tc/q_rr.c @@ -101,13 +101,19 @@ static int

[PATCH v2 iproute2-next 17/31] tc/codel: implement JSON output

From: Stephen Hemminger Signed-off-by: Stephen Hemminger --- tc/q_codel.c | 35 +-- 1 file changed, 17 insertions(+), 18 deletions(-) diff --git a/tc/q_codel.c b/tc/q_codel.c index 8a2a871671cb..de5c514fc49c 100644 --- a/tc/q_codel.c +++ b/tc/q_codel.c

[PATCH v2 iproute2-next 22/31] tc/pie: implement JSON output

From: Stephen Hemminger Signed-off-by: Stephen Hemminger --- tc/q_pie.c | 33 ++--- 1 file changed, 18 insertions(+), 15 deletions(-) diff --git a/tc/q_pie.c b/tc/q_pie.c index f7924ef5e76c..086785588d64 100644 --- a/tc/q_pie.c +++ b/tc/q_pie.c @@ -135,8 +135,6

[PATCH v2 iproute2-next 16/31] tc/util: allow signed value for time

From: Stephen Hemminger The codel algorithm wants a signed value for time when outputting values. Allow it for other uses as well. Signed-off-by: Stephen Hemminger --- tc/tc_util.c | 6 +++--- tc/tc_util.h | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/tc/tc_util.c b

<    1   2   3   4   5   6   7   8   9   10   >