[PATCH v2 iproute2-next 26/31] tc/cbs: convert to JSON output

2018-07-10 Thread Stephen Hemminger
From: Stephen Hemminger Signed-off-by: Stephen Hemminger --- tc/q_cbs.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/tc/q_cbs.c b/tc/q_cbs.c index a2ffb1db3852..1518a79cd733 100644 --- a/tc/q_cbs.c +++ b/tc/q_cbs.c @@ -125,11 +125,11 @@ static int

[PATCH v2 iproute2-next 06/31] tc/util: add print helpers for JSON

2018-07-10 Thread Stephen Hemminger
From: Stephen Hemminger Add a helper to print rate, time and size in numeric or pretty format based on JSON flag. Signed-off-by: Stephen Hemminger --- tc/tc_util.c | 83 +--- tc/tc_util.h | 6 2 files changed, 59 insertions(+), 30

[PATCH v2 iproute2-next 21/31] tc/hhf: implement JSON output

2018-07-10 Thread Stephen Hemminger
From: Stephen Hemminger Signed-off-by: Stephen Hemminger --- tc/q_hhf.c | 24 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/tc/q_hhf.c b/tc/q_hhf.c index 21186a92c017..daea6bbcdd65 100644 --- a/tc/q_hhf.c +++ b/tc/q_hhf.c @@ -127,8 +127,6 @@ static

[PATCH v2 iproute2-next 05/31] tc/util: remove unused print functions

2018-07-10 Thread Stephen Hemminger
From: Stephen Hemminger The functions for printing rate/time/size, etc are not used by current code. Next patch will repurpose these for JSON format output. Signed-off-by: Stephen Hemminger --- tc/tc_util.c | 49 ++--- tc/tc_util.h | 4 2

[PATCH v2 iproute2-next 29/31] tc/hfsc: convert to JSON output

2018-07-10 Thread Stephen Hemminger
From: Stephen Hemminger Signed-off-by: Stephen Hemminger --- tc/q_hfsc.c | 26 +- 1 file changed, 13 insertions(+), 13 deletions(-) diff --git a/tc/q_hfsc.c b/tc/q_hfsc.c index f34b1b2fe2a9..e2f366b8a189 100644 --- a/tc/q_hfsc.c +++ b/tc/q_hfsc.c @@ -113,7 +113,8

[PATCH v2 iproute2-next 08/31] tc/sfq: add json support

2018-07-10 Thread Stephen Hemminger
From: Stephen Hemminger Convert to use JSON Signed-off-by: Stephen Hemminger --- tc/q_sfq.c | 65 -- 1 file changed, 39 insertions(+), 26 deletions(-) diff --git a/tc/q_sfq.c b/tc/q_sfq.c index 6a1d853b7c93..a813c055b92e 100644 --- a/tc

[PATCH v2 iproute2-next 25/31] tc/dsmark: implement JSON output

2018-07-10 Thread Stephen Hemminger
From: Stephen Hemminger Signed-off-by: Stephen Hemminger --- tc/q_dsmark.c | 27 ++- 1 file changed, 18 insertions(+), 9 deletions(-) diff --git a/tc/q_dsmark.c b/tc/q_dsmark.c index d3e8292d777c..d2b9e3885377 100644 --- a/tc/q_dsmark.c +++ b/tc/q_dsmark.c @@ -131,28

[PATCH v2 iproute2-next 09/31] tc/fq: support JSON output

2018-07-10 Thread Stephen Hemminger
From: Stephen Hemminger Output parameters optionally in JSON. Signed-off-by: Stephen Hemminger --- tc/q_fq.c | 103 +++--- 1 file changed, 60 insertions(+), 43 deletions(-) diff --git a/tc/q_fq.c b/tc/q_fq.c index f3dbf2ba0c6f..fa546c6ae500

[PATCH v2 iproute2-next 07/31] tc/red: use new JSON helpers

2018-07-10 Thread Stephen Hemminger
From: Stephen Hemminger Now have simplier way to print size. Signed-off-by: Stephen Hemminger --- tc/q_red.c | 13 +++-- 1 file changed, 3 insertions(+), 10 deletions(-) diff --git a/tc/q_red.c b/tc/q_red.c index 49fd4ac80513..9e4124befdb7 100644 --- a/tc/q_red.c +++ b/tc/q_red.c

[PATCH v2 iproute2-next 13/31] tc/qfq: implement JSON

2018-07-10 Thread Stephen Hemminger
From: Stephen Hemminger Signed-off-by: Stephen Hemminger --- tc/q_qfq.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/tc/q_qfq.c b/tc/q_qfq.c index eb8fa4b84927..0bb52ad6340b 100644 --- a/tc/q_qfq.c +++ b/tc/q_qfq.c @@ -94,13 +94,13 @@ static int qfq_print_opt

[PATCH v2 iproute2-next 23/31] tc/gred: implement JSON output

2018-07-10 Thread Stephen Hemminger
From: Stephen Hemminger Signed-off-by: Stephen Hemminger --- tc/q_gred.c | 73 - 1 file changed, 38 insertions(+), 35 deletions(-) diff --git a/tc/q_gred.c b/tc/q_gred.c index e63fac72a883..957d3c0950f1 100644 --- a/tc/q_gred.c +++ b/tc

[PATCH v2 iproute2-next 30/31] tc/htb: implement JSON output

2018-07-10 Thread Stephen Hemminger
From: Stephen Hemminger Signed-off-by: Stephen Hemminger --- tc/q_htb.c | 53 ++--- 1 file changed, 30 insertions(+), 23 deletions(-) diff --git a/tc/q_htb.c b/tc/q_htb.c index 7d5f6ce44773..e7026ad017a4 100644 --- a/tc/q_htb.c +++ b/tc/q_htb.c

[PATCH v2 iproute2-next 18/31] tc/fifo: implement JSON output

2018-07-10 Thread Stephen Hemminger
From: Stephen Hemminger Signed-off-by: Stephen Hemminger --- tc/q_fifo.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/tc/q_fifo.c b/tc/q_fifo.c index 5fd6c1b1107d..65a7b0e218f2 100644 --- a/tc/q_fifo.c +++ b/tc/q_fifo.c @@ -67,11 +67,10 @@ static int

[PATCH v2 iproute2-next 04/31] tc/cbq: use sprint_rate

2018-07-10 Thread Stephen Hemminger
From: Stephen Hemminger All other places in tc use sprint_rate. Signed-off-by: Stephen Hemminger --- tc/q_cbq.c | 15 ++- 1 file changed, 6 insertions(+), 9 deletions(-) diff --git a/tc/q_cbq.c b/tc/q_cbq.c index e7f1a3bfaf5d..ad0170c41858 100644 --- a/tc/q_cbq.c +++ b/tc/q_cbq.c

[PATCH v2 iproute2-next 24/31] tc/netem: implement JSON output

2018-07-10 Thread Stephen Hemminger
From: Stephen Hemminger Also, fix a spelling error in usage message. Signed-off-by: Stephen Hemminger --- tc/q_netem.c | 94 +--- 1 file changed, 46 insertions(+), 48 deletions(-) diff --git a/tc/q_netem.c b/tc/q_netem.c index 623ec9038ad3

[PATCH v2 iproute2-next 20/31] tc/choke: implement JSON output

2018-07-10 Thread Stephen Hemminger
From: Stephen Hemminger Signed-off-by: Stephen Hemminger --- tc/q_choke.c | 25 - 1 file changed, 16 insertions(+), 9 deletions(-) diff --git a/tc/q_choke.c b/tc/q_choke.c index b269b1338b6d..718743f4a998 100644 --- a/tc/q_choke.c +++ b/tc/q_choke.c @@ -185,19 +185,23

[PATCH v2 iproute2-next 01/31] tc: use JSON in error handling

2018-07-10 Thread Stephen Hemminger
From: Stephen Hemminger If option or qdisc is unknown, still output in JSON. Signed-off-by: Stephen Hemminger --- tc/tc.c | 19 +++ 1 file changed, 11 insertions(+), 8 deletions(-) diff --git a/tc/tc.c b/tc/tc.c index 0d223281ba25..b6d2a6151793 100644 --- a/tc/tc.c +++ b/tc

[PATCH v2 iproute2-next 02/31] tc: use const char in util

2018-07-10 Thread Stephen Hemminger
From: Stephen Hemminger For prefix and path, can use const char. Signed-off-by: Stephen Hemminger --- tc/tc_util.c | 8 +--- tc/tc_util.h | 6 +++--- 2 files changed, 8 insertions(+), 6 deletions(-) diff --git a/tc/tc_util.c b/tc/tc_util.c index e0c96291ade0..e8e1241d083d 100644 --- a/tc

[PATCH v2 iproute2-next 00/31] tc use JSON in all qdisc

2018-07-10 Thread Stephen Hemminger
From: Stephen Hemminger This patch set adds some utility routines and then converts all the remaining TC queue discipline managers to support JSON output. v2 - consolidate the utility patches - do all the remaining qdisc's Stephen Hemminger (31): tc: use JSON in error handling tc: use

[PATCH iproute2-next 3/9] tc: convert stats print to json

2018-07-09 Thread Stephen Hemminger
From: Stephen Hemminger Convert compatiablity statistics to print in JSON. Signed-off-by: Stephen Hemminger --- tc/tc_util.c | 32 ++-- 1 file changed, 22 insertions(+), 10 deletions(-) diff --git a/tc/tc_util.c b/tc/tc_util.c index e8e1241d083d..05b6c97563b3

[PATCH iproute2-next 5/9] tc/util: remove print_rate

2018-07-09 Thread Stephen Hemminger
From: Stephen Hemminger This function is not used, only sprint_rate is used. Signed-off-by: Stephen Hemminger --- tc/tc_util.c | 10 +++--- tc/tc_util.h | 1 - 2 files changed, 3 insertions(+), 8 deletions(-) diff --git a/tc/tc_util.c b/tc/tc_util.c index 05b6c97563b3..f5ffe3443892

[PATCH iproute2-next 7/9] tc/util: remove unused print_time

2018-07-09 Thread Stephen Hemminger
From: Stephen Hemminger Only sprint_time is used. Signed-off-by: Stephen Hemminger --- tc/tc_util.c | 8 ++-- tc/tc_util.h | 1 - 2 files changed, 2 insertions(+), 7 deletions(-) diff --git a/tc/tc_util.c b/tc/tc_util.c index 01e131b5c5d7..95cb49b98612 100644 --- a/tc/tc_util.c +++ b/tc

[PATCH iproute2-next 1/9] tc: use JSON in error handling

2018-07-09 Thread Stephen Hemminger
From: Stephen Hemminger If option or qdisc is unknown, still output in JSON. Signed-off-by: Stephen Hemminger --- tc/tc.c | 19 +++ 1 file changed, 11 insertions(+), 8 deletions(-) diff --git a/tc/tc.c b/tc/tc.c index 0d223281ba25..b6d2a6151793 100644 --- a/tc/tc.c +++ b/tc

[PATCH iproute2-next 6/9] tc/util: remove unused print_size

2018-07-09 Thread Stephen Hemminger
From: Stephen Hemminger Only sprint_size is used, so fold it in. Signed-off-by: Stephen Hemminger --- tc/tc_util.c | 7 ++- tc/tc_util.h | 1 - 2 files changed, 2 insertions(+), 6 deletions(-) diff --git a/tc/tc_util.c b/tc/tc_util.c index f5ffe3443892..01e131b5c5d7 100644 --- a/tc

[PATCH iproute2-next 8/9] tc/util: add print helpers for JSON

2018-07-09 Thread Stephen Hemminger
From: Stephen Hemminger Add a helper to print rate and size in numeric or pretty format based on JSON flag. Signed-off-by: Stephen Hemminger --- tc/tc_util.c | 59 ++-- tc/tc_util.h | 2 ++ 2 files changed, 31 insertions(+), 30 deletions

[PATCH iproute2-next 2/9] tc: use const char in util

2018-07-09 Thread Stephen Hemminger
From: Stephen Hemminger For prefix and path, can use const char. Signed-off-by: Stephen Hemminger --- tc/tc_util.c | 8 +--- tc/tc_util.h | 6 +++--- 2 files changed, 8 insertions(+), 6 deletions(-) diff --git a/tc/tc_util.c b/tc/tc_util.c index e0c96291ade0..e8e1241d083d 100644 --- a/tc

[PATCH iproute2-next 4/9] tc/cbq: use sprint_rate

2018-07-09 Thread Stephen Hemminger
From: Stephen Hemminger All other places in tc use sprint_rate. Signed-off-by: Stephen Hemminger --- tc/q_cbq.c | 15 ++- 1 file changed, 6 insertions(+), 9 deletions(-) diff --git a/tc/q_cbq.c b/tc/q_cbq.c index e7f1a3bfaf5d..ad0170c41858 100644 --- a/tc/q_cbq.c +++ b/tc/q_cbq.c

[PATCH iproute2-next 0/9] TC more JSON support

2018-07-09 Thread Stephen Hemminger
From: Stephen Hemminger Update core of TC command and library to do more JSON. Most of this patch set is about getting tc utility functions to be more friendly to the json_print infrastructure. Stephen Hemminger (9): tc: use JSON in error handling tc: use const char in util tc: convert

[PATCH iproute2-next 9/9] tc/sfq: add json support

2018-07-09 Thread Stephen Hemminger
From: Stephen Hemminger Convert to use JSON Signed-off-by: Stephen Hemminger --- tc/q_sfq.c | 65 -- 1 file changed, 39 insertions(+), 26 deletions(-) diff --git a/tc/q_sfq.c b/tc/q_sfq.c index 6a1d853b7c93..cc8ce0dddf7e 100644 --- a/tc

[PATCH iproute2] tc: don't double print rate

2018-07-09 Thread Stephen Hemminger
Conversion to print stats in JSON forgot to remove existing fprintf. Fixes: 4fcec7f3665b ("tc: jsonify stats2") Signed-off-by: Stephen Hemminger --- tc/tc_util.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/tc/tc_util.c b/tc/tc_util.c index e0c96291ade0..d7578528a31b 10064

Re: [PATCH iproute2] tc: Fix the bug not to display prio and quantum options of htb

2018-07-07 Thread Stephen Hemminger
On Wed, 4 Jul 2018 12:32:33 +0900 fumihiko kakuma wrote: > A commandline like 'tc -d class show dev dev-name' does not > display value of prio and quantum option when we use htb qdisc. > This patch fixes the bug. > > Signed-off-by: Fumihiko Kakuma Applied

Re: [PATCH iproute2] tc: Fix output of ip attributes

2018-07-07 Thread Stephen Hemminger
On Tue, 3 Jul 2018 15:54:32 +0300 Roi Dayan wrote: > Example output is of tos and ttl. > Befoe this fix the format used %x caused output of the pointer > instead of the intended string created in the out variable. > > Fixes: e28b88a464c4 ("tc: jsonify flower filter") > Signed-off-by: Roi Dayan

Re: [PATCH v2 iproute2] man: Fix typos on tc-cbs

2018-07-07 Thread Stephen Hemminger
On Thu, 5 Jul 2018 08:20:09 -0700 Jesus Sanchez-Palencia wrote: > Fix 2 typos on the man page of the CBS qdisc. > > Signed-off-by: Jesus Sanchez-Palencia > Reviewed-by: Simon Horman Applied

Re: [PATCH v2 iproute2] net:sched: add action inheritdsfield to skbedit

2018-07-07 Thread Stephen Hemminger
On Sat, 7 Jul 2018 12:40:01 -0400 Qiaobin Fu wrote: > The new action inheritdsfield copies the field DS of > IPv4 and IPv6 packets into skb->priority. This enables > later classification of packets based on the DS field. > > v2: > *Use optional flags, so that it won't break old versions of tc.

Re: [PATCH v2 net-next 00/14] Scheduled packet Transmission: ETF

2018-07-06 Thread Stephen Hemminger
On Tue, 3 Jul 2018 15:42:46 -0700 Jesus Sanchez-Palencia wrote: > Changes since v1: > - moved struct sock_txtime from socket.h to uapi net_tstamp.h; > - sk_clockid was changed from u16 to u8; > - sk_txtime_flags was changed from u16 to a u8 bit field in struct sock; > - the socket

Re: [PATCH v3 iproute2 2/3] tc: Add support for the ETF Qdisc

2018-07-06 Thread Stephen Hemminger
> diff --git a/tc/q_etf.c b/tc/q_etf.c > new file mode 100644 > index ..5db1dd6f > --- /dev/null > +++ b/tc/q_etf.c > @@ -0,0 +1,168 @@ > +/* > + * q_etf.c Earliest TxTime First (ETF). > + * > + * This program is free software; you can redistribute it and/or > + *

Fw: [Bug 200315] New: [Regression] Wired network does not come back after reboot

2018-07-06 Thread Stephen Hemminger
Begin forwarded message: Date: Thu, 28 Jun 2018 01:59:30 + From: bugzilla-dae...@bugzilla.kernel.org To: step...@networkplumber.org Subject: [Bug 200315] New: [Regression] Wired network does not come back after reboot https://bugzilla.kernel.org/show_bug.cgi?id=200315 Bug

Fw: [Bug 200215] New: UBSAN: Undefined behaviour in net/core/sock.c:LINE

2018-07-06 Thread Stephen Hemminger
Begin forwarded message: Date: Sat, 23 Jun 2018 00:00:25 + From: bugzilla-dae...@bugzilla.kernel.org To: step...@networkplumber.org Subject: [Bug 200215] New: UBSAN: Undefined behaviour in net/core/sock.c:LINE https://bugzilla.kernel.org/show_bug.cgi?id=200215 Bug ID: 200215

Fw: [Bug 200239] New: RTL8211E lockup when having heavy tx traffic

2018-07-06 Thread Stephen Hemminger
Begin forwarded message: Date: Sun, 24 Jun 2018 10:26:02 + From: bugzilla-dae...@bugzilla.kernel.org To: step...@networkplumber.org Subject: [Bug 200239] New: RTL8211E lockup when having heavy tx traffic https://bugzilla.kernel.org/show_bug.cgi?id=200239 Bug ID: 200239

Fw: [Bug 200033] stack-out-of-bounds in __xfrm_dst_hash net/xfrm/xfrm_hash.h

2018-07-06 Thread Stephen Hemminger
Begin forwarded message: Date: Sat, 23 Jun 2018 14:24:30 + From: bugzilla-dae...@bugzilla.kernel.org To: step...@networkplumber.org Subject: [Bug 200033] stack-out-of-bounds in __xfrm_dst_hash net/xfrm/xfrm_hash.h https://bugzilla.kernel.org/show_bug.cgi?id=200033 --- Comment #1 from

Fw: [Bug 200195] New: [Regression] Network does not come back after suspend

2018-07-06 Thread Stephen Hemminger
Begin forwarded message: Date: Fri, 22 Jun 2018 18:04:00 + From: bugzilla-dae...@bugzilla.kernel.org To: step...@networkplumber.org Subject: [Bug 200195] New: [Regression] Network does not come back after suspend https://bugzilla.kernel.org/show_bug.cgi?id=200195 Bug ID:

Fw: [Bug 200187] New: UBSAN: Undefined behaviour in net/sunrpc/xprt.c:568

2018-07-06 Thread Stephen Hemminger
Begin forwarded message: Date: Fri, 22 Jun 2018 15:09:48 + From: bugzilla-dae...@bugzilla.kernel.org To: step...@networkplumber.org Subject: [Bug 200187] New: UBSAN: Undefined behaviour in net/sunrpc/xprt.c:568 https://bugzilla.kernel.org/show_bug.cgi?id=200187 Bug ID:

Re: [PATCH v1 iproute2 1/2] uapi pkt_sched: Add etf info - DO NOT COMMIT

2018-07-06 Thread Stephen Hemminger
On Wed, 27 Jun 2018 15:09:11 -0700 Jesus Sanchez-Palencia wrote: > This should come from the next uapi headers update. > Sending it now just as a convenience so anyone can build tc with etf > and taprio support. > > Signed-off-by: Jesus Sanchez-Palencia This should be targeted at

Fw: [Bug 200191] New: UBSAN: Undefined behaviour in ./include/net/xfrm.h:894

2018-06-22 Thread Stephen Hemminger
Begin forwarded message: Date: Fri, 22 Jun 2018 15:20:06 + From: bugzilla-dae...@bugzilla.kernel.org To: step...@networkplumber.org Subject: [Bug 200191] New: UBSAN: Undefined behaviour in ./include/net/xfrm.h:894 https://bugzilla.kernel.org/show_bug.cgi?id=200191 Bug ID:

Re: [PATCH] tc, bpf: add option to dump bpf verifier as C program fragment

2018-06-20 Thread Stephen Hemminger
On Wed, 20 Jun 2018 00:13:52 +0200 Daniel Borkmann wrote: > On 06/18/2018 11:44 PM, David Ahern wrote: > > On 6/18/18 2:18 PM, Jakub Kicinski wrote: > >> On Sun, 17 Jun 2018 08:48:41 +, Ophir Munk wrote: > >>> Similar to cbpf used within tcpdump utility with a "-d" option to dump > >>>

Re: [PATCH] tc: fix batch force option

2018-06-20 Thread Stephen Hemminger
On Wed, 20 Jun 2018 10:24:21 +0300 Vlad Buslov wrote: > When sending accumulated compound command results an error, check 'force' > option before exiting. Move return code check after putting batch bufs and > freeing iovs to prevent memory leak. Break from loop, instead of returning > error code

Re: Incomplete fix for be9c798 / 7b2ee50 hv_netvsc: common detach logic?

2018-06-19 Thread Stephen Hemminger
about bisecting which landed on: > > > > commit be9c798d0d13ae609a91177323ac816545c39d28 > > Author: Stephen Hemminger > > Date: Mon May 14 15:32:18 2018 -0700 > > > > hv_netvsc: common detach logic > > > > [ Commit 7b2ee50c0cd513a176a26a71f2989facdd75bfea upstream. ] >

Re: Incomplete fix for be9c798 / 7b2ee50 hv_netvsc: common detach logic?

2018-06-19 Thread Stephen Hemminger
about bisecting which landed on: > > > > commit be9c798d0d13ae609a91177323ac816545c39d28 > > Author: Stephen Hemminger > > Date: Mon May 14 15:32:18 2018 -0700 > > > > hv_netvsc: common detach logic > > > > [ Commit 7b2ee50c0cd513a176a26a71f2989facdd75bfea upstream. ] >

Re: [PATCH net 5/5] net sched actions: fix misleading text strings in pedit action

2018-06-19 Thread Stephen Hemminger
On Tue, 19 Jun 2018 12:56:08 -0400 Roman Mashak wrote: > Change "tc filter pedit .." to "tc actions pedit .." in error > messages to clearly refer to pedit action. > > Signed-off-by: Roman Mashak > --- > net/sched/act_pedit.c | 10 +- > 1 file changed, 5 insertions(+), 5 deletions(-)

Re: iproute2 won't compile without AF_VSOCK

2018-06-19 Thread Stephen Hemminger
On Tue, 19 Jun 2018 10:17:45 -0500 Steve Wise wrote: > Hey David, > > I'm trying to compile the latest iproute2 on an RHEL-7.3 distro, and it > fails to compile because AF_VSOCK is not defined.  Should this > functionality be a configure option to disable it on older distros? > > > Thanks, >

Re: [PATCH iproute2 v3] ipaddress: strengthen check on 'label' input

2018-06-15 Thread Stephen Hemminger
name appears at the beginning of the label > string. > > This commit adds an additional check to ensure label == dev or > continues with a colon. > > Signed-off-by: Patrick Talbert > Suggested-by: Stephen Hemminger Sure applied

Fw: [Bug 200083] New: kernel panic: fatal exception in interrupt

2018-06-15 Thread Stephen Hemminger
The screenshot shows: RIP: xfrm_lookup+0x17/0x676 Begin forwarded message: Date: Fri, 15 Jun 2018 12:35:21 + From: bugzilla-dae...@bugzilla.kernel.org To: step...@networkplumber.org Subject: [Bug 200083] New: kernel panic: fatal exception in interrupt

Re: [PATCH iproute2-next v2] ip-xfrm: Add support for OUTPUT_MARK

2018-06-12 Thread Stephen Hemminger
On Wed, 13 Jun 2018 12:14:53 +0900 Lorenzo Colitti wrote: > On Wed, Jun 13, 2018 at 3:48 AM Subash Abhinov Kasiviswanathan > wrote: > > > > src 192.168.1.1 dst 192.168.1.2 > > proto esp spi 0x4321 reqid 0 mode tunnel > > replay-window 0 flag af-unspec > > mark

Re: Problems in tc-matchall.8, tc-sample.8

2018-06-12 Thread Stephen Hemminger
On Tue, 12 Jun 2018 19:41:03 -0400 "Eric S. Raymond" wrote: > Stephen Hemminger : > > On Tue, 12 Jun 2018 18:00:03 -0400 > > "Eric S. Raymond" wrote: > > > > > Stephen Hemminger : > > > > Please resubmit as real patch w

Re: [PATCH 1/1] ip: add rmnet initial support

2018-06-12 Thread Stephen Hemminger
On Tue, 12 Jun 2018 16:12:57 +0200 Daniele Palmas wrote: > This patch adds basic support for Qualcomm rmnet devices. > > Signed-off-by: Daniele Palmas > --- > ip/Makefile | 2 +- > ip/iplink.c | 2 +- > ip/iplink_rmnet.c | 70 >

Re: Problems in tc-matchall.8, tc-sample.8

2018-06-12 Thread Stephen Hemminger
On Tue, 12 Jun 2018 18:00:03 -0400 "Eric S. Raymond" wrote: > Stephen Hemminger : > > Please resubmit as real patch with signed-off-by > > I would like to follow your intructions, but that description leaves me > not quite certain what you want. A git format-patc

Re: Problems in tc-matchall.8, tc-sample.8

2018-06-12 Thread Stephen Hemminger
On Tue, 12 Jun 2018 15:16:14 -0400 (EDT) e...@thyrsus.com wrote: > This is automatically generated email about markup problems in a man > page for which you appear to be responsible. If you are not the right > person or list, please tell me so I can correct my database. > > See

Re: [jkirsher/next-queue PATCH v2 0/7] Add support for L2 Fwd Offload w/o ndo_select_queue

2018-06-12 Thread Stephen Hemminger
On Tue, 12 Jun 2018 11:18:25 -0400 Alexander Duyck wrote: > This patch series is meant to allow support for the L2 forward offload, aka > MACVLAN offload without the need for using ndo_select_queue. > > The existing solution currently requires that we use ndo_select_queue in > the transmit path

Fw: [Bug 200033] New: stack-out-of-bounds in __xfrm_dst_hash net/xfrm/xfrm_hash.h

2018-06-12 Thread Stephen Hemminger
Begin forwarded message: Date: Tue, 12 Jun 2018 01:44:36 + From: bugzilla-dae...@bugzilla.kernel.org To: step...@networkplumber.org Subject: [Bug 200033] New: stack-out-of-bounds in __xfrm_dst_hash net/xfrm/xfrm_hash.h https://bugzilla.kernel.org/show_bug.cgi?id=200033 Bug

Re: [PATCH net 2/3] hv_netvsc: fix network namespace issues with VF support

2018-06-12 Thread Stephen Hemminger
On Tue, 12 Jun 2018 12:51:28 +0300 Dan Carpenter wrote: > On Mon, Jun 11, 2018 at 12:44:55PM -0700, Stephen Hemminger wrote: > > When finding the parent netvsc device, the search needs to be across > > all netvsc device instances (independent of network namespace). > > &

Re: [PATCH iproute2-next] ip-xfrm: Add support for OUTPUT_MARK

2018-06-11 Thread Stephen Hemminger
On Mon, 11 Jun 2018 20:11:33 -0600 Subash Abhinov Kasiviswanathan wrote: > This patch adds support for OUTPUT_MARK in xfrm state to exercise the > functionality added by kernel commit 077fbac405bf > ("net: xfrm: support setting an output mark."). > > Sample output with output-mark - > > src

[PATCH net 1/3] hv_netvsc: drop common code until callback model fixed

2018-06-11 Thread Stephen Hemminger
. This reverts commit 9c6ffbacdb57 ("hv_netvsc: fix error return code in netvsc_probe()") and commit 1ff78076d8dd ("netvsc: refactor notifier/event handling code to use the failover framework") Signed-off-by: Stephen Hemminger --- drivers/net/hyperv/Kconfig | 1 - drivers/net

[PATCH net 0/3] hv_netvsc: notification and namespace fixes

2018-06-11 Thread Stephen Hemminger
This set of patches addresses two set of fixes. First it backs out the common callback model which was merged in net-next without completing all the review feedback or getting maintainer approval. Then it fixes the transparent VF management code to handle network namespaces. Stephen Hemminger (3

[PATCH net 3/3] hv_netvsc: move VF to same namespace as netvsc device

2018-06-11 Thread Stephen Hemminger
. The user can move it later (if desired). Signed-off-by: Stephen Hemminger --- drivers/net/hyperv/netvsc_drv.c | 21 - 1 file changed, 20 insertions(+), 1 deletion(-) diff --git a/drivers/net/hyperv/netvsc_drv.c b/drivers/net/hyperv/netvsc_drv.c index 8cb21e013d1d

[PATCH net 2/3] hv_netvsc: fix network namespace issues with VF support

2018-06-11 Thread Stephen Hemminger
Signed-off-by: Stephen Hemminger netns aware byref --- drivers/net/hyperv/hyperv_net.h | 2 ++ drivers/net/hyperv/netvsc_drv.c | 43 +++-- 2 files changed, 22 insertions(+), 23 deletions(-) diff --git a/drivers/net/hyperv/hyperv_net.h b/drivers/net/hyperv/hyperv_n

Re: [PATCH net] failover: eliminate callback hell

2018-06-11 Thread Stephen Hemminger
On Fri, 8 Jun 2018 17:42:21 -0700 Siwei Liu wrote: > On Fri, Jun 8, 2018 at 5:02 PM, Stephen Hemminger > wrote: > > On Fri, 8 Jun 2018 16:44:12 -0700 > > Siwei Liu wrote: > > > >> On Fri, Jun 8, 2018 at 4:18 PM, Stephen Hemminger > >> wrote:

Re: [PATCH net] failover: eliminate callback hell

2018-06-11 Thread Stephen Hemminger
On Fri, 8 Jun 2018 15:54:38 -0700 Siwei Liu wrote: > On Wed, Jun 6, 2018 at 2:54 PM, Samudrala, Sridhar > wrote: > > > > > > On 6/6/2018 2:24 PM, Stephen Hemminger wrote: > >> > >> On Wed, 6 Jun 2018 15:30:27 +0300 > >> "Michael S. Tsi

Re: [iproute2-next v2 1/2] tipc: JSON support for showing nametable

2018-06-11 Thread Stephen Hemminger
On Mon, 11 Jun 2018 09:16:59 +0700 Hoang Le wrote: > @@ -33,6 +35,8 @@ static void about(struct cmdl *cmdl) > "\n" > "Options:\n" > " -h, --help \t\tPrint help for last given command\n" > + " -j, --json \t\tJson format printouts\n" > +

Re: [PATCH net] failover: eliminate callback hell

2018-06-08 Thread Stephen Hemminger
On Fri, 8 Jun 2018 16:44:12 -0700 Siwei Liu wrote: > On Fri, Jun 8, 2018 at 4:18 PM, Stephen Hemminger > wrote: > > On Fri, 8 Jun 2018 15:25:59 -0700 > > Siwei Liu wrote: > > > >> On Wed, Jun 6, 2018 at 2:24 PM, Stephen Hemminger > >> wrote:

Re: [PATCH net] failover: eliminate callback hell

2018-06-08 Thread Stephen Hemminger
On Fri, 8 Jun 2018 15:25:59 -0700 Siwei Liu wrote: > On Wed, Jun 6, 2018 at 2:24 PM, Stephen Hemminger > wrote: > > On Wed, 6 Jun 2018 15:30:27 +0300 > > "Michael S. Tsirkin" wrote: > > > >> On Wed, Jun 06, 2018 at 09:25:12AM +0200, Jiri Pirko wrot

Re: [PATCH net] failover: eliminate callback hell

2018-06-08 Thread Stephen Hemminger
On Thu, 7 Jun 2018 20:22:15 +0300 "Michael S. Tsirkin" wrote: > On Thu, Jun 07, 2018 at 09:17:42AM -0700, Stephen Hemminger wrote: > > On Thu, 7 Jun 2018 18:41:31 +0300 > > "Michael S. Tsirkin" wrote: > > > > > > > Why would DP

Re: netdevice notifier and device private data

2018-06-08 Thread Stephen Hemminger
On Fri, 8 Jun 2018 13:34:55 -0400 Alexander Aring wrote: > Hey netdev community, > > I am trying to solve some issue which Eric Dumazet points to me by > commit ca0edb131bdf ("ieee802154: 6lowpan: fix possible NULL deref in > lowpan_device_event()"). > > The issue is that dev->type can be

Re: [PATCH 1/2] iproute2: Add support for a few routing protocols

2018-06-08 Thread Stephen Hemminger
On Fri, 8 Jun 2018 08:46:37 -0400 Donald Sharp wrote: > Add support for: > > BGP > ISIS > OSPF > RIP > EIGRP > > Routing protocols to iproute2. > > Signed-off-by: Donald Sharp > --- > etc/iproute2/rt_protos| 5 + > include/linux/rtnetlink.h | 5 + > lib/rt_names.c|

Re: [PATCH iproute2 v2 0/2] display netns name instead of nsid

2018-06-08 Thread Stephen Hemminger
On Tue, 5 Jun 2018 15:08:29 +0200 Nicolas Dichtel wrote: > After these patches, the iproute2 name of netns is displayed instead of > the nsid. It's easier to read/understand. > > v1 -> v2: > - open netns socket and init netns map only when needed > > ip/ip_common.h | 3 +++ >

Re: [PATCH 2/2] iproute2: Remove leftover gated RT_PROT defines

2018-06-08 Thread Stephen Hemminger
On Fri, 8 Jun 2018 08:46:38 -0400 Donald Sharp wrote: > These values are not being used nor maintained, so remove. > > Signed-off-by: Donald Sharp > --- > etc/iproute2/rt_protos | 13 - > 1 file changed, 13 deletions(-) > > diff --git a/etc/iproute2/rt_protos

Fw: [Bug 199995] New: Ramdomly sent TCP Reset from Kernel with bonding mode "brodcast"

2018-06-08 Thread Stephen Hemminger
Begin forwarded message: Date: Fri, 08 Jun 2018 16:06:40 + From: bugzilla-dae...@bugzilla.kernel.org To: step...@networkplumber.org Subject: [Bug 15] New: Ramdomly sent TCP Reset from Kernel with bonding mode "brodcast" https://bugzilla.kernel.org/show_bug.cgi?id=15

Re: [PATCH net] failover: eliminate callback hell

2018-06-07 Thread Stephen Hemminger
On Thu, 7 Jun 2018 18:41:31 +0300 "Michael S. Tsirkin" wrote: > > > Why would DPDK care what we do in the kernel? Isn't it just slapping > > > vfio-pci on the netdevs it sees? > > > > Alex, you are correct for Intel devices; but DPDK on Azure is not Intel > > based.,. > > The DPDK support

Fw: [Bug 199963] New: UDP rx_queue incorrect calculation in /proc/net/udp

2018-06-07 Thread Stephen Hemminger
Begin forwarded message: Date: Thu, 07 Jun 2018 13:21:23 + From: bugzilla-dae...@bugzilla.kernel.org To: step...@networkplumber.org Subject: [Bug 199963] New: UDP rx_queue incorrect calculation in /proc/net/udp https://bugzilla.kernel.org/show_bug.cgi?id=199963 Bug ID:

Re: [PATCH net] failover: eliminate callback hell

2018-06-07 Thread Stephen Hemminger
On Thu, 7 Jun 2018 17:57:50 +0300 "Michael S. Tsirkin" wrote: > On Wed, Jun 06, 2018 at 03:24:08PM -0700, Stephen Hemminger wrote: > > On Thu, 7 Jun 2018 00:47:52 +0300 > > "Michael S. Tsirkin" wrote: > > > > > On Wed, Jun 06,

Re: [PATCH net] failover: eliminate callback hell

2018-06-07 Thread Stephen Hemminger
On Thu, 7 Jun 2018 07:17:51 -0700 Alexander Duyck wrote: > On Wed, Jun 6, 2018 at 3:25 PM, Stephen Hemminger > wrote: > > On Wed, 6 Jun 2018 14:54:04 -0700 > > "Samudrala, Sridhar" wrote: > > > >> On 6/6/2018 2:24 PM, Stephen Hemminger wrote:

Re: [PATCH net] failover: eliminate callback hell

2018-06-06 Thread Stephen Hemminger
On Wed, 6 Jun 2018 15:19:30 +0300 "Michael S. Tsirkin" wrote: > On Tue, Jun 05, 2018 at 08:51:18PM -0700, Stephen Hemminger wrote: > > > I think the push back was with the usage of the delay, not bringing up > > > the primary/standby > > > device in th

Re: [PATCH net] failover: eliminate callback hell

2018-06-06 Thread Stephen Hemminger
On Wed, 6 Jun 2018 14:54:04 -0700 "Samudrala, Sridhar" wrote: > On 6/6/2018 2:24 PM, Stephen Hemminger wrote: > > On Wed, 6 Jun 2018 15:30:27 +0300 > > "Michael S. Tsirkin" wrote: > > > >> On Wed, Jun 06, 2018 at 09:25:12AM +0200, Jiri Pirko w

Re: [PATCH net] failover: eliminate callback hell

2018-06-06 Thread Stephen Hemminger
On Thu, 7 Jun 2018 00:47:52 +0300 "Michael S. Tsirkin" wrote: > On Wed, Jun 06, 2018 at 02:24:47PM -0700, Stephen Hemminger wrote: > > On Wed, 6 Jun 2018 15:30:27 +0300 > > "Michael S. Tsirkin" wrote: > > > > > On Wed, Jun 06, 2018 at 09:25:1

Re: [PATCH net] failover: eliminate callback hell

2018-06-06 Thread Stephen Hemminger
On Thu, 7 Jun 2018 00:30:21 +0300 "Michael S. Tsirkin" wrote: > On Wed, Jun 06, 2018 at 02:16:20PM -0700, Stephen Hemminger wrote: > > On Tue, 5 Jun 2018 23:11:37 -0700 > > "Samudrala, Sridhar" wrote: > > > > > On 6/5/2018 11:00 PM, Stephen H

Re: [PATCH net] failover: eliminate callback hell

2018-06-06 Thread Stephen Hemminger
On Wed, 6 Jun 2018 09:25:12 +0200 Jiri Pirko wrote: > Tue, Jun 05, 2018 at 05:42:31AM CEST, step...@networkplumber.org wrote: > >The net failover should be a simple library, not a virtual > >object with function callbacks (see callback hell). > > Why just a library? It should do a common

Re: [PATCH net] failover: eliminate callback hell

2018-06-06 Thread Stephen Hemminger
On Wed, 6 Jun 2018 15:30:27 +0300 "Michael S. Tsirkin" wrote: > On Wed, Jun 06, 2018 at 09:25:12AM +0200, Jiri Pirko wrote: > > Tue, Jun 05, 2018 at 05:42:31AM CEST, step...@networkplumber.org wrote: > > >The net failover should be a simple library, not a virtual > > >object with function

Re: [PATCH net] failover: eliminate callback hell

2018-06-06 Thread Stephen Hemminger
On Tue, 5 Jun 2018 23:11:37 -0700 "Samudrala, Sridhar" wrote: > On 6/5/2018 11:00 PM, Stephen Hemminger wrote: > > On Tue, 5 Jun 2018 22:39:12 -0700 > > "Samudrala, Sridhar" wrote: > > > >> On 6/5/2018 8:51 PM, Stephen Hemminge

Fw: [Bug 199951] New: Packets send with libpcap via veth started to have trailer, (incorrect) FCS and are dropped

2018-06-06 Thread Stephen Hemminger
Begin forwarded message: Date: Wed, 06 Jun 2018 18:39:54 + From: bugzilla-dae...@bugzilla.kernel.org To: step...@networkplumber.org Subject: [Bug 199951] New: Packets send with libpcap via veth started to have trailer, (incorrect) FCS and are dropped

Re: [PATCH net] failover: eliminate callback hell

2018-06-06 Thread Stephen Hemminger
On Tue, 5 Jun 2018 22:39:12 -0700 "Samudrala, Sridhar" wrote: > On 6/5/2018 8:51 PM, Stephen Hemminger wrote: > > On Tue, 5 Jun 2018 16:52:22 -0700 > > "Samudrala, Sridhar" wrote: > > > >> On 6/5/2018 2:52 PM, Stephen Hemminger wrote: > &

Re: [PATCH net] failover: eliminate callback hell

2018-06-05 Thread Stephen Hemminger
On Tue, 5 Jun 2018 16:52:22 -0700 "Samudrala, Sridhar" wrote: > On 6/5/2018 2:52 PM, Stephen Hemminger wrote: > > On Tue, 5 Jun 2018 22:38:43 +0300 > > "Michael S. Tsirkin" wrote: > > > >>> See: > >>> https://

Re: [PATCH net] failover: eliminate callback hell

2018-06-05 Thread Stephen Hemminger
On Tue, 5 Jun 2018 22:38:43 +0300 "Michael S. Tsirkin" wrote: > > > > See: > >https://patchwork.ozlabs.org/patch/851711/ > > Let me try to summarize that: > > You wanted to speed up the delayed link up. You had an idea to > additionally take link up when userspace renames

Re: [PATCH iproute2-next v2 1/1] tc: add json support in csum action

2018-06-05 Thread Stephen Hemminger
On Tue, 5 Jun 2018 16:44:19 -0400 Keara Leibovitz wrote: > diff --git a/tc/m_csum.c b/tc/m_csum.c > index 8391071d73f2..0bdbcf361a28 100644 > --- a/tc/m_csum.c > +++ b/tc/m_csum.c > @@ -162,6 +162,7 @@ print_csum(struct action_util *au, FILE *f, struct rtattr > *arg) > char *uflag_5 =

Re: [PATCH net] failover: eliminate callback hell

2018-06-05 Thread Stephen Hemminger
was eliminating the callbacks. > > On Mon, Jun 04, 2018 at 08:42:31PM -0700, Stephen Hemminger wrote: > > * The matching of secondary device to primary device policy > > is up to the network device. Both net_failover and netvsc > > will use MAC for now but can change se

Re: [PATCH net] failover: eliminate callback hell

2018-06-05 Thread Stephen Hemminger
On Tue, 5 Jun 2018 10:22:13 -0700 "Samudrala, Sridhar" wrote: > On 6/4/2018 8:42 PM, Stephen Hemminger wrote: > > The net failover should be a simple library, not a virtual > > object with function callbacks (see callback hell). > > The code is simpler is smaller

Re: [PATCH iproute2 v2 1/2] ip: display netns name instead of nsid

2018-06-05 Thread Stephen Hemminger
On Tue, 5 Jun 2018 15:08:30 +0200 Nicolas Dichtel wrote: > > +char *get_name_from_nsid(int nsid) > +{ > + struct nsid_cache *c; > + > + netns_nsid_socket_init(); > + netns_map_init(); > + > + c = netns_map_get_by_nsid(nsid); > + if (c) > + return c->name; > + >

[PATCH net] failover: eliminate callback hell

2018-06-04 Thread Stephen Hemminger
ested only on virtio. Fixes: 30c8bd5aa8b2 ("net: Introduce generic failover module") Signed-off-by: Stephen Hemminger --- Although this patch needs to go into 4.18 (linux-net), this version is based against net-next because net-next hasn't been merged into linux-net yet. drivers/net/hyper

Re: [PATCH iproute2 1/2] ip: display netns name instead of nsid

2018-06-04 Thread Stephen Hemminger
On Mon, 4 Jun 2018 14:12:52 +0200 Nicolas Dichtel wrote: > diff --git a/ip/ipaddress.c b/ip/ipaddress.c > index c7c7e7df4e81..aee09c7ff6df 100644 > --- a/ip/ipaddress.c > +++ b/ip/ipaddress.c > @@ -819,6 +819,9 @@ int print_linkinfo(const struct sockaddr_nl *who, > unsigned int m_flag =

Re: [PATCH] iproute2: fix 'ip xfrm monitor all' command

2018-06-01 Thread Stephen Hemminger
On Wed, 30 May 2018 12:11:32 -0700 Nathan Harold wrote: > Currently, calling 'ip xfrm monitor all' will > actually invoke the 'all-nsid' command because the > soft-match for 'all-nsid' occurs before the precise > match for 'all'. This patch rearranges the checks > so that the 'all' command,

Re: [PATCH iproute2] ip: IFLA_NEW_NETNSID/IFLA_NEW_IFINDEX support

2018-06-01 Thread Stephen Hemminger
On Fri, 1 Jun 2018 17:02:18 +0200 Nicolas Dichtel wrote: > Le 31/05/2018 à 17:51, Nicolas Dichtel a écrit : > > Le 31/05/2018 à 17:46, Stephen Hemminger a écrit : > >> On Thu, 31 May 2018 16:28:48 +0200 > > [snip] > >> This makes sense. All of linkinfo th

Re: [PATCH v2 iproute2-next] ip route: print RTA_CACHEINFO if it exists

2018-06-01 Thread Stephen Hemminger
d-off-by: David Ahern Acked-by: Stephen Hemminger

<    1   2   3   4   5   6   7   8   9   10   >