Re: [PATCH net-next v8 4/4] netvsc: refactor notifier/event handling code to use the failover framework

On Wed, 25 Apr 2018 16:59:28 -0700 Sridhar Samudrala wrote: > Use the registration/notification framework supported by the generic > failover infrastructure. > > Signed-off-by: Sridhar Samudrala NAK unless you prove this works on

Re: [PATCH iproute2 v3] json_print: Fix hidden 64-bit type promotion

On Wed, 25 Apr 2018 17:28:57 +0200 Toke Høiland-Jørgensen wrote: > print_uint() will silently promote its variable type to uint64_t, but there > is nothing that ensures that the format string specifier passed along with > it fits (and the function name suggest to pass "%u"). > >

Re: [PATCH iproute2] ingress: Don't break JSON output

On Wed, 25 Apr 2018 11:29:46 +0200 Toke Høiland-Jørgensen wrote: > The dash printed by the ingress qdisc breaks JSON output, so only print it > in regular output mode. > > Signed-off-by: Toke Høiland-Jørgensen Applied, thanks.

Re: [PATCH iproute2 v2] json_print: Fix hidden 64-bit type promotion

On Wed, 25 Apr 2018 16:57:52 +0200 Toke Høiland-Jørgensen <t...@toke.dk> wrote: > Stephen Hemminger <step...@networkplumber.org> writes: > > > On Wed, 25 Apr 2018 16:30:22 +0200 > > Toke Høiland-Jørgensen <t...@toke.dk> wrote: > > > >> p

Re: [PATCH iproute2 v2] json_print: Fix hidden 64-bit type promotion

On Wed, 25 Apr 2018 16:30:22 +0200 Toke Høiland-Jørgensen wrote: > print_uint() will silently promote its variable type to uint64_t, but there > is nothing that ensures that the format string specifier passed along with > it fits (and the function name suggest to pass "%u"). > >

Re: [Cake] [PATCH net-next v2] Add Common Applications Kept Enhanced (cake) qdisc

On Tue, 24 Apr 2018 13:44:06 +0200 Toke Høiland-Jørgensen wrote: > +static const u8 precedence[] = {0, 0, 0, 0, 0, 0, 0, 0, > + 1, 1, 1, 1, 1, 1, 1, 1, > + 2, 2, 2, 2, 2, 2, 2, 2, > + 3, 3, 3, 3, 3,

Re: [Cake] [PATCH net-next v2] Add Common Applications Kept Enhanced (cake) qdisc

On Tue, 24 Apr 2018 13:44:06 +0200 Toke Høiland-Jørgensen wrote: > +struct tc_cake_xstats { > + __u16 version; > + __u16 tin_stats_size; /* == sizeof(struct tc_cake_tin_stats) */ > + __u32 capacity_estimate; > + __u32 memory_limit; > + __u32 memory_used; > +

Re: [Cake] [PATCH iproute2-next v3] Add support for cake qdisc

On Tue, 24 Apr 2018 16:52:57 +0200 Toke Høiland-Jørgensen wrote: > Well, this is leftover from keeping track of different versions of the > out-of-tree patch, and we already broke compatibility pretty thoroughly > as a preparation for upstreaming. So I'm fine with dropping the

Re: [Cake] [PATCH iproute2-next v3] Add support for cake qdisc

On Tue, 24 Apr 2018 14:30:46 +0200 Toke Høiland-Jørgensen wrote: > +static void cake_print_json_tin(struct tc_cake_tin_stats *tst, uint version) > +{ > + open_json_object(NULL); > + print_uint(PRINT_JSON, "threshold_rate", NULL, tst->threshold_rate); > +

Re: [Cake] [PATCH iproute2-next v3] Add support for cake qdisc

On Tue, 24 Apr 2018 14:30:46 +0200 Toke Høiland-Jørgensen wrote: > diff --git a/tc/q_cake.c b/tc/q_cake.c > new file mode 100644 > index ..12263361 > --- /dev/null > +++ b/tc/q_cake.c > @@ -0,0 +1,778 @@ > +/* SPDX-License-Identifier: (GPL-2.0 OR BSD-3-Clause) */ > +/* > +

Re: [PATCH v7 net-next 4/4] netvsc: refactor notifier/event handling code to use the failover framework

On Tue, 24 Apr 2018 04:42:22 +0300 "Michael S. Tsirkin" <m...@redhat.com> wrote: > On Mon, Apr 23, 2018 at 06:25:03PM -0700, Stephen Hemminger wrote: > > On Mon, 23 Apr 2018 12:44:39 -0700 > > Siwei Liu <losewe...@gmail.com> wrote: > > > > >

Re: [PATCH v7 net-next 4/4] netvsc: refactor notifier/event handling code to use the failover framework

On Mon, 23 Apr 2018 23:06:55 +0300 "Michael S. Tsirkin" <m...@redhat.com> wrote: > On Mon, Apr 23, 2018 at 12:44:39PM -0700, Siwei Liu wrote: > > On Mon, Apr 23, 2018 at 10:56 AM, Michael S. Tsirkin <m...@redhat.com> > > wrote: > > > On Mon, Apr 2

Re: [PATCH v7 net-next 4/4] netvsc: refactor notifier/event handling code to use the failover framework

On Mon, 23 Apr 2018 12:44:39 -0700 Siwei Liu <losewe...@gmail.com> wrote: > On Mon, Apr 23, 2018 at 10:56 AM, Michael S. Tsirkin <m...@redhat.com> wrote: > > On Mon, Apr 23, 2018 at 10:44:40AM -0700, Stephen Hemminger wrote: > >> On Mon, 23 Apr 2018 20:24:56 +030

Re: [PATCH v7 net-next 4/4] netvsc: refactor notifier/event handling code to use the failover framework

On Mon, 23 Apr 2018 20:24:56 +0300 "Michael S. Tsirkin" <m...@redhat.com> wrote: > On Mon, Apr 23, 2018 at 10:04:06AM -0700, Stephen Hemminger wrote: > > > > > > > >I will NAK patches to change to common code for netvsc especially the > > > >

Re: [PATCH v7 net-next 4/4] netvsc: refactor notifier/event handling code to use the failover framework

On Fri, 20 Apr 2018 18:00:58 +0200 Jiri Pirko wrote: > Fri, Apr 20, 2018 at 05:28:02PM CEST, step...@networkplumber.org wrote: > >On Thu, 19 Apr 2018 18:42:04 -0700 > >Sridhar Samudrala wrote: > > > >> Use the registration/notification framework

Fw: [Bug 199469] New: Regression in 32-bit-compat dev_ioctl due to bf4405737f9f85a06db2b0ce5d76a818b61992e2

I think this has already been addressed. But forwarding for sure. Begin forwarded message: Date: Mon, 23 Apr 2018 01:26:46 + From: bugzilla-dae...@bugzilla.kernel.org To: step...@networkplumber.org Subject: [Bug 199469] New: Regression in 32-bit-compat dev_ioctl due to

[RFC iproute 2/5] json: make json print_uint take unsigned int

of these necessary. Signed-off-by: Stephen Hemminger <step...@networkplumber.org> --- include/json_print.h | 16 +--- lib/json_print.c | 33 ++--- 2 files changed, 43 insertions(+), 6 deletions(-) diff --git a/include/json_print.h b/include/json_print.h

[RFC iproute 4/5] tcp_metrics: use print_luint

Metrics are long unsigned, so use correct print function. Signed-off-by: Stephen Hemminger <step...@networkplumber.org> --- ip/tcp_metrics.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ip/tcp_metrics.c b/ip/tcp_metrics.c index 72dc980c92a6..3b82a4e1d2f2 100644 --

[RFC iproute 0/5] print_uint issues

, but that got ugly. Stephen Hemminger (5): ipneigh: fix missing format specifier json: make json print_uint take unsigned int flower: use 16 bit format where possible tcp_metrics: use print_luint mroute: use print_uint64 include/json_print.h | 16 +--- ip/ipmroute.c

[RFC iproute 5/5] mroute: use print_uint64

The values from multicast stats are 64 bit always. Signed-off-by: Stephen Hemminger <step...@networkplumber.org> --- ip/ipmroute.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/ip/ipmroute.c b/ip/ipmroute.c index 59c5b7718e18..eb6b2816324f 100644 --

[RFC iproute 3/5] flower: use 16 bit format where possible

Should use print_hu not print_uint for 16 bit value. Signed-off-by: Stephen Hemminger <step...@networkplumber.org> --- tc/f_flower.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tc/f_flower.c b/tc/f_flower.c index 9d4bfd2f808b..ba8eb66cdd11 100644 --- a/tc/f_flower.c

[RFC iproute 1/5] ipneigh: fix missing format specifier

Signed-off-by: Stephen Hemminger <step...@networkplumber.org> --- ip/ipneigh.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ip/ipneigh.c b/ip/ipneigh.c index 4748381701e4..bd6e5c5e18ca 100644 --- a/ip/ipneigh.c +++ b/ip/ipneigh.c @@ -204,7 +204,7 @@ stati

[PATCH] hv_netvsc: select needed ucs2_string routine

Signed-off-by: Stephen Hemminger <sthem...@microsoft.com> --- drivers/net/hyperv/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/hyperv/Kconfig b/drivers/net/hyperv/Kconfig index 936968d23559..0765d5f61714 100644 --- a/drivers/net/hyperv/Kconfig +++ b/drivers/net/hyperv

Re: [PATCH v7 net-next 4/4] netvsc: refactor notifier/event handling code to use the failover framework

On Thu, 19 Apr 2018 18:42:04 -0700 Sridhar Samudrala wrote: > Use the registration/notification framework supported by the generic > failover infrastructure. > > Signed-off-by: Sridhar Samudrala Do what you want to other devices but

Re: [Bug 199429] New: smc_shutdown(net/smc/af_smc.c) has a UAF causing null pointer vulnerability.

On Wed, 18 Apr 2018 13:46:20 +0200 Ursula Braun <ubr...@linux.ibm.com> wrote: > On 04/18/2018 04:56 AM, Stephen Hemminger wrote: > > This may already be fixed. > > > > Begin forwarded message: > > > > Date: Wed, 18 Apr 2018 01:52:59 + > &

Re: [RFC PATCH] net: bridge: multicast querier per VLAN support

On Wed, 18 Apr 2018 16:14:26 +0300 Nikolay Aleksandrov wrote: > On 18/04/18 16:07, Joachim Nilsson wrote: > > On Wed, Apr 18, 2018 at 03:31:57PM +0300, Nikolay Aleksandrov wrote: > >> On 18/04/18 15:07, Joachim Nilsson wrote: > >>> - First of all, is this patch

Re: [PATCH iproute2 net-next] vxlan: fix ttl inherit behavior

On Wed, 18 Apr 2018 13:10:49 +0800 Hangbin Liu wrote: > Hi Stephen, > > The patch's subject contains fix. But the kernel feature is applied on > net-next. > So I'm not sure if iproute2 net-next is suitable. If you are OK with the > patch, > please feel free to apply it

Fw: [Bug 199429] New: smc_shutdown(net/smc/af_smc.c) has a UAF causing null pointer vulnerability.

This may already be fixed. Begin forwarded message: Date: Wed, 18 Apr 2018 01:52:59 + From: bugzilla-dae...@bugzilla.kernel.org To: step...@networkplumber.org Subject: [Bug 199429] New: smc_shutdown(net/smc/af_smc.c) has a UAF causing null pointer vulnerability.

[PATCH net-next] hv_netvsc: propogate Hyper-V friendly name into interface alias

commands. Also requires exporting dev_set_alias in netdev core. Signed-off-by: Stephen Hemminger <sthem...@microsoft.com> --- drivers/net/hyperv/rndis_filter.c | 28 net/core/dev.c| 1 + 2 files changed, 29 insertions(+) diff --git a/drive

Fw: [Bug 199427] New: Wired Network interface goes repeatedly up and down with NetworkManager

Begin forwarded message: Date: Tue, 17 Apr 2018 18:57:20 + From: bugzilla-dae...@bugzilla.kernel.org To: step...@networkplumber.org Subject: [Bug 199427] New: Wired Network interface goes repeatedly up and down with NetworkManager https://bugzilla.kernel.org/show_bug.cgi?id=199427

Re: [PATCH iproute2] utils: Do not reset family for default, any, all addresses

On Fri, 13 Apr 2018 09:36:33 -0700 David Ahern wrote: > Thomas reported a change in behavior with respect to autodectecting > address families. Specifically, 'ip ro add default via fe80::1' > syntax was failing to treat fe80::1 as an IPv6 address as it did in > prior releases.

Re: [iproute PATCH] iproute: Abort if nexthop cannot be parsed

On Wed, 11 Apr 2018 11:43:11 +0200 Jakub Sitnicki wrote: > Attempt to add a multipath route where a nexthop definition refers to a > non-existent device causes 'ip' to crash and burn due to stack buffer > overflow: > > # ip -6 route add fd00::1/64 nexthop dev fake1 > Cannot

Re: Stack smash error in latest version of iproute2's 'ip'

On Mon, 16 Apr 2018 12:58:00 -0400 (EDT) Paul Claessen wrote: > Greetings, > > I'm getting a "*** stack smashing detected ***: ip terminated" error when > using 'ip macsec show'. > > This happens on Ubuntu 16.04.4 (Xemian) on an AMD64 PC. > ip version is 180402 > > Screen

Re: [PATCH iproute2-next 3/3] treewide: Use addattr_nest()/addattr_nest_end() to handle nested attributes

On Fri, 13 Apr 2018 15:57:37 -0700 Vinicius Costa Gomes wrote: > Hi, > > Serhey Popovych writes: > > [...] > > > diff --git a/tc/q_mqprio.c b/tc/q_mqprio.c > > index 89b4600..207d644 100644 > > --- a/tc/q_mqprio.c > > +++ b/tc/q_mqprio.c >

Re: [PATCH net-next] Per interface IPv4 stats (CONFIG_IP_IFSTATS_TABLE)

On Tue, 10 Apr 2018 22:55:35 -0400 Stephen Suryaputra wrote: > This is enhanced from the proposed patch by Igor Maravic in 2011 to > support per interface IPv4 stats. The enhancement is mainly adding a > kernel configuration option CONFIG_IP_IFSTATS_TABLE. > >

Re: [RFC PATCH net-next v6 4/4] netvsc: refactor notifier/event handling code to use the bypass framework

On Tue, 10 Apr 2018 16:44:47 -0700 Siwei Liu <losewe...@gmail.com> wrote: > On Tue, Apr 10, 2018 at 4:28 PM, Michael S. Tsirkin <m...@redhat.com> wrote: > > On Tue, Apr 10, 2018 at 02:26:08PM -0700, Stephen Hemminger wrote: > >> On Tue, 10 Apr 2018 11:59:5

Re: [RFC PATCH net-next v6 4/4] netvsc: refactor notifier/event handling code to use the bypass framework

On Tue, 10 Apr 2018 11:59:50 -0700 Sridhar Samudrala wrote: > Use the registration/notification framework supported by the generic > bypass infrastructure. > > Signed-off-by: Sridhar Samudrala > --- Thanks for doing this. Your current

Re: [RFC PATCH 2/3] netdev: kernel-only IFF_HIDDEN netdevice

On Mon, 9 Apr 2018 15:30:42 -0700 Siwei Liu wrote: > On Mon, Apr 9, 2018 at 3:15 PM, Andrew Lunn wrote: > >> No, implementation wise I'd avoid changing the class on the fly. What > >> I'm looking to is a means to add a secondary class or class aliasing > >>

Fw: [Bug 199307] New: kernel panic,call trace,sched_clock,tcp_write_timer_handler

Forwarding to netdev mailing list, it might be a real problem Ugh. Glaring backtrace screenshots. Begin forwarded message: Date: Fri, 06 Apr 2018 16:43:46 + From: bugzilla-dae...@bugzilla.kernel.org To: step...@networkplumber.org Subject: [Bug 199307] New: kernel panic,call

Re: [PATCH iproute2] l2tp: no need to export session offsets in JSON output

On Thu, 5 Apr 2018 19:24:17 +0200 Guillaume Nault wrote: > The offset and peer_offset parameters are only printed to avoid > confusing external scripts that may parse "ip l2tp show session" > output. There's no reason to keep them in JSON. > > Signed-off-by: Guillaume

Re: [PATCH iproute2] ip/l2tp: remove offset and peer-offset options

On Tue, 3 Apr 2018 17:39:54 +0200 Guillaume Nault wrote: > Ignore options "peer-offset" and "offset" when creating sessions. Keep > them when dumping sessions in order to avoid breaking external scripts. > > "peer-offset" has always been a noop in iproute2. "offset" is now

Re: [PATCH iproute2 rdma: Ignore unknown netlink attributes

On Tue, 3 Apr 2018 10:28:42 +0300 Leon Romanovsky wrote: > From: Leon Romanovsky > > The check if netlink attributes supplied more than maximum supported > is to strict and may lead to backward compatibility issues with old > application with a newer

Re: [PATCH iproute2-next] tc: Correct json output for actions

On Wed, 04 Apr 2018 17:09:04 -0400 Roman Mashak wrote: > Yuval Mintz writes: > > > Commit 9fd3f0b255d9 ("tc: enable json output for actions") added JSON > > support for tc-actions at the expense of breaking other use cases that > > reach

Re: [RFC PATCH 2/3] netdev: kernel-only IFF_HIDDEN netdevice

On Wed, 4 Apr 2018 11:37:52 -0600 David Ahern wrote: > Networking vendors have out of tree kernel modules. Those modules use a > netdev (call it a master netdev, a control netdev, cpu port, whatever) > to pull packets from the ASIC and deliver to virtual netdevices >

Re: [RFC PATCH] packet: mark ring entry as in-use inside spin_lock to prevent RX ring overrun

On Tue, 3 Apr 2018 17:55:25 -0400 Jon Rosen wrote: > Fix PACKET_RX_RING bug for versions TPACKET_V1 and TPACKET_V2 which > casues the ring to get corrupted by allowing multiple kernel threads > to claim ownership of the same ring entry, Mark the ring entry as > already being

Re: [RFC PATCH 2/3] netdev: kernel-only IFF_HIDDEN netdevice

On Sun, 1 Apr 2018 05:13:09 -0400 Si-Wei Liu wrote: > Hidden netdevice is not visible to userspace such that > typical network utilites e.g. ip, ifconfig and et al, > cannot sense its existence or configure it. Internally > hidden netdev may associate with an upper level

[ANNOUNCE] iproute 4.16

Fix width calculations when Netid or State columns are missing ss: Replace printf() calls for "main" output by calls to helper ss: Introduce columns lightweight abstraction ss: Buffer raw fields first, then render them as a table ss: Implement automatic column widt

Re: [PATCH v15 ] net/veth/XDP: Line-rate packet forwarding in kernel

On Sun, 1 Apr 2018 20:47:28 -0400 "Md. Islam" wrote: > This patch implements IPv4 forwarding on xdp_buff. I added a new > config option XDP_ROUTER. Kernel would forward packets through fast > path when this option is enabled. But it would require driver support. > Currently it

Re: [PATCH] net: improve ipv4 performances

On Sun, 1 Apr 2018 20:31:21 +0200 Anton Gary Ceph wrote: > As the Linux networking stack is growing, more and more protocols are > added, increasing the complexity of stack itself. > Modern processors, contrary to common belief, are very bad in branch > prediction, so it's

Re: [PATCH iproute2-next] json_print: fix print_uint with helper type extensions

On Thu, 29 Mar 2018 20:32:10 +0100 Kevin Darbyshire-Bryant wrote: > Introduce print helper functions for int, uint, explicit int32, uint32, > int64 & uint64. > > print_int used 'int' type internally, whereas print_uint used 'uint64_t' > > These helper functions

Re: [PATCH iproute2] json_print: fix print_uint hidden type promotion

On Thu, 29 Mar 2018 20:22:20 +0100 Kevin Darbyshire-Bryant wrote: > print_int used 'int' type internally, whereas print_uint used 'uint64_t' > > These helper functions eventually call vfprintf(fp, fmt, args) which is > a variable argument list function and is

Fw: [Bug 199233] New: vxlan: hw csum failure

Begin forwarded message: Date: Wed, 28 Mar 2018 17:08:14 + From: bugzilla-dae...@bugzilla.kernel.org To: step...@networkplumber.org Subject: [Bug 199233] New: vxlan: hw csum failure https://bugzilla.kernel.org/show_bug.cgi?id=199233 Bug ID: 199233 Summary: vxlan:

Re: [PATCH iproute] arrange prefix parsing code after redundant patches

On Wed, 28 Mar 2018 01:57:13 +0200 Alexander Zubkov wrote: > A problem was reported with parsing of prefixes all/any/default. > Commit 7696f1097f79be2ce5984a8a16103fd17391cac2 fixes the problem, > but there were also other pathces applied: >

Fw: [Bug 199243] New: Ethernet doesn't work after sleep

Begin forwarded message: Date: Thu, 29 Mar 2018 15:02:07 + From: bugzilla-dae...@bugzilla.kernel.org To: step...@networkplumber.org Subject: [Bug 199243] New: Ethernet doesn't work after sleep https://bugzilla.kernel.org/show_bug.cgi?id=199243 Bug ID: 199243

RE: [Resend Patch 1/3] Vmbus: Add function to report available ring buffer to write in total ring size percentage

, 2018 3:43 PM To: Martin K. Petersen <martin.peter...@oracle.com>; Long Li <lon...@linuxonhyperv.com> Cc: KY Srinivasan <k...@microsoft.com>; Haiyang Zhang <haiya...@microsoft.com>; Stephen Hemminger <sthem...@microsoft.com>; James E . J . Bottomley <jbottom...@odin.c

Re: [patch net-next RFC 00/12] devlink: introduce port flavours and common phys_port_name generation

On Thu, 22 Mar 2018 11:55:10 +0100 Jiri Pirko wrote: > From: Jiri Pirko > > This patchset resolves 2 issues we have right now: > 1) There are many netdevices / ports in the system, for port, pf, vf >represenatation but the user has no way to see which

[PATCH iproute2-next 0/2] more JSON support

From: Stephen Hemminger <sthem...@microsoft.com> Add JSON to ILA and L2TP display Stephen Hemminger (2): ip/ila: support json and color ip/l2tp: add JSON support ip/ipila.c | 76 +++--- ip/ipl2tp.c

[PATCH iproute2-next 2/2] ip/l2tp: add JSON support

From: Stephen Hemminger <sthem...@microsoft.com> Convert ip l2tp to use JSON output routines. Signed-off-by: Stephen Hemminger <step...@networkplumber.org> --- ip/ipl2tp.c | 152 1 file changed, 103 insertions(+),

[PATCH iproute2-next 1/2] ip/ila: support json and color

From: Stephen Hemminger <sthem...@microsoft.com> Use json print to enhance ila output. Signed-off-by: Stephen Hemminger <step...@networkplumber.org> --- ip/ipila.c | 76 ++ 1 file changed, 37 insertions(+), 39 deletions(-)

Re: [PATCH iproute2 1/1] tc: print index, refcnt & bindcnt for nat action

On Tue, 27 Mar 2018 17:32:31 -0400 Roman Mashak <m...@mojatatu.com> wrote: > Stephen Hemminger <step...@networkplumber.org> writes: > > > On Tue, 20 Mar 2018 14:21:47 -0400 > > Roman Mashak <m...@mojatatu.com> wrote: > > > >> Signed-off-by:

Re: [PATCH iproute2 1/1] tc: print index, refcnt & bindcnt for nat action

On Tue, 27 Mar 2018 17:32:31 -0400 Roman Mashak <m...@mojatatu.com> wrote: > Stephen Hemminger <step...@networkplumber.org> writes: > > > On Tue, 20 Mar 2018 14:21:47 -0400 > > Roman Mashak <m...@mojatatu.com> wrote: > > > >> Signed-off-by:

Re: [PATCH v3 iproute2 1/1] tc: fix conversion types when printing actions unsigned values

On Tue, 27 Mar 2018 17:33:05 -0400 Roman Mashak <m...@mojatatu.com> wrote: > Stephen Hemminger <step...@networkplumber.org> writes: > > > On Mon, 19 Mar 2018 17:05:41 -0400 > > Roman Mashak <m...@mojatatu.com> wrote: > > > >> diff --git

Re: [PATCH iproute2 v1] Drop capabilities if not running ip exec vrf with libcap

On Tue, 27 Mar 2018 18:48:55 +0100 Luca Boccassi wrote: > ip vrf exec requires root or CAP_NET_ADMIN, CAP_SYS_ADMIN and > CAP_DAC_OVERRIDE. It is not possible to run unprivileged commands like > ping as non-root or non-cap-enabled due to this requirement. > To allow users and

Re: [iproute PATCH 2/3] ss: Put filter DB parsing into a separate function

On Sat, 24 Mar 2018 19:18:10 +0100 Phil Sutter wrote: > +#define ENTRY(name, ...) { #name, { __VA_ARGS__, MAX_DB }} > + ENTRY(all, UDP_DB, DCCP_DB, TCP_DB, RAW_DB, \ > +UNIX_ST_DB, UNIX_DG_DB, UNIX_SQ_DB, \ > +PACKET_R_DB,

Re: [iproute PATCH] ssfilter: Eliminate shift/reduce conflicts

On Sat, 24 Mar 2018 18:45:14 +0100 Phil Sutter wrote: > The problematic bit was the 'expr: expr expr' rule. Fix this by making > 'expr' token represent a single filter only and introduce a new token > 'exprlist' to represent a combination of filters. > > Signed-off-by: Phil Sutter

Re: [iproute2 1/1] ss: Add support for TIPC socket diag in ss tool

On Fri, 23 Mar 2018 15:01:02 +0100 GhantaKrishnamurthy MohanKrishna wrote: > For iproute 4.x > Allow TIPC socket statistics to be dumped with --tipc > and tipc specific info with --tipcinfo. > > Acked-by: Jon Maloy >

[PATCH net] hv_netvsc: enable multicast if necessary

etvsc: filter multicast/broadcast") Signed-off-by: Stephen Hemminger <sthem...@microsoft.com> --- drivers/net/hyperv/rndis_filter.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/hyperv/rndis_filter.c b/drivers/net/hyperv/rndis_filter.c index 00ec80c23f

Re: [PATCH iproute2] Revert "iproute: "list/flush/save default" selected all of the routes"

iproute2/iproute2.git/patch/?id=7696f1097f79be2ce5984a8a16103fd17391cac2 > > 27.03.2018, 19:00, "Stephen Hemminger" <step...@networkplumber.org>: > > On Tue, 27 Mar 2018 18:29:31 +0200 > > Alexander Zubkov <gr...@msu.ru> wrote: > > > >>  

Re: [RFC PATCH iproute2] Drop capabilities if not running ip exec vrf with libcap

On Tue, 27 Mar 2018 17:24:19 +0100 Luca Boccassi wrote: > ip vrf exec requires root or CAP_NET_ADMIN, CAP_SYS_ADMIN and > CAP_DAC_OVERRIDE. It is not possible to run unprivileged commands like > ping as non-root or non-cap-enabled due to this requirement. > To allow users and

Re: [PATCH iproute2] ss: Fix rendering of continuous output (-E, --events)

On Fri, 23 Mar 2018 09:30:17 -0400 Roman Mashak wrote: > Stefano Brivio writes: > > > Roman Mashak reported that ss currently shows no output when it > > should continuously report information about terminated sockets > > (-E, --events switch). > > > >

Re: [PATCH iproute2 1/1] tc: print actual action for connmark action

On Tue, 20 Mar 2018 13:45:38 -0400 Roman Mashak wrote: > Signed-off-by: Roman Mashak > --- > tc/m_connmark.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) Applied

Re: [PATCH iproute2] Revert "iproute: "list/flush/save default" selected all of the routes"

.15 > 3) my patch for master - fixes problem, it requires neither revert patch nor > my patch for 4.15, it is standalone patch designed to do things right in > master branch > > 27.03.2018, 18:01, "Stephen Hemminger" <step...@networkplumber.org>: > > On

Re: [patch iproute2] devlink: fix port new monitoring message typo

On Fri, 23 Mar 2018 13:19:13 +0100 Jiri Pirko wrote: > From: Jiri Pirko > > s/net/new/ > > Fixes: a3c4b484a1ed ("add devlink tool") > Signed-off-by: Jiri Pirko > --- > devlink/devlink.c | 2 +- > 1 file changed, 1 insertion(+), 1

Re: [PATCH iproute2 1/1] tc: print index, refcnt & bindcnt for nat action

On Tue, 20 Mar 2018 14:21:47 -0400 Roman Mashak wrote: > Signed-off-by: Roman Mashak > --- > tc/m_nat.c | 5 + > 1 file changed, 5 insertions(+) > > diff --git a/tc/m_nat.c b/tc/m_nat.c > index 1e4ff51fe75a..f6e373957c1b 100644 > --- a/tc/m_nat.c >

Re: [PATCH v3 iproute2 1/1] tc: fix conversion types when printing actions unsigned values

On Mon, 19 Mar 2018 17:05:41 -0400 Roman Mashak wrote: > diff --git a/tc/m_gact.c b/tc/m_gact.c > index 16c4413f4217..52022415db48 100644 > --- a/tc/m_gact.c > +++ b/tc/m_gact.c > @@ -194,7 +194,7 @@ print_gact(struct action_util *au, FILE *f, struct rtattr > *arg) >

Re: [PATCH iproute2] Revert "iproute: "list/flush/save default" selected all of the routes"

On Wed, 14 Mar 2018 21:26:40 +0100 Alexander Zubkov wrote: > Hello, > > For example, it can be fixed in such way (patch is below): > - split handling of default and all/any > - set needed attributes in get_addr: PREFIXLEN_SPECIFIED flag for default > - and AF_UNSPEC for all/any >

Re: [patch iproute2 rfc 1/2] devlink: introduce support for showing port flavours

On Fri, 23 Mar 2018 07:35:57 +0100 Jiri Pirko wrote: > +static const char *port_flavour_name(uint16_t flavour) > +{ > + switch (flavour) { > + case DEVLINK_PORT_FLAVOUR_PHYSICAL: return "physical"; > + case DEVLINK_PORT_FLAVOUR_PF_REP: return "pf_rep"; > + case

Re: [PATCH net-next, 2/2] hv_netvsc: Add range checking for rx packet offset and length

On Thu, 22 Mar 2018 12:01:14 -0700 Haiyang Zhang wrote: > From: Haiyang Zhang > > This patch adds range checking for rx packet offset and length. > It may only happen if there is a host side bug. > > Signed-off-by: Haiyang Zhang

Re: [net-next] intel: add SPDX identifiers to all the Intel drivers

On Tue, 20 Mar 2018 10:13:20 -0700 Jeff Kirsher wrote: > diff --git a/drivers/net/ethernet/intel/e100.c > b/drivers/net/ethernet/intel/e100.c > index 29486478836e..a750a5fe373a 100644 > --- a/drivers/net/ethernet/intel/e100.c > +++

[PATCH PATCH net 3/4] hv_netvsc: change GPAD teardown order on older versions

t;hv_netvsc: netvsc_teardown_gpadl() split") Signed-off-by: Stephen Hemminger <sthem...@microsoft.com> --- drivers/net/hyperv/netvsc.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/net/hyperv/netvsc.c b/drivers/net/hyperv/netvsc.c index 12c044baf1af..37b0a30d6b03 10

[PATCH PATCH net 1/4] hv_netvsc: disable NAPI before channel close

This makes sure that no CPU is still process packets when the channel is closed. Fixes: 76bb5db5c749 ("netvsc: fix use after free on module removal") Signed-off-by: Stephen Hemminger <sthem...@microsoft.com> --- drivers/net/hyperv/netvsc.c | 8 1 file changed, 4

[PATCH PATCH net 4/4] hv_netvsc: common detach logic

Signed-off-by: Stephen Hemminger <sthem...@microsoft.com> --- drivers/net/hyperv/hyperv_net.h | 1 - drivers/net/hyperv/netvsc.c | 20 +-- drivers/net/hyperv/netvsc_drv.c | 278 +- drivers/net/hyperv/rndis_filter.c | 17 +-- 4 files changed

[PATCH PATCH net 0/4] hv_netvsc: fix races during shutdown and changes

This set of patches fixes issues identified by Vitaly Kuznetsov and Mohammed Gamal related to state changes in Hyper-v network driver. A lot of the issues are because setting up the netvsc device requires a second step (in work queue) to get all the sub-channels running. Stephen Hemminger (4

[PATCH PATCH net 2/4] hv_netvsc: use RCU to fix concurrent rx and queue changes

: 0cf737808ae7 ("hv_netvsc: netvsc_teardown_gpadl() split") Signed-off-by: Stephen Hemminger <sthem...@microsoft.com> --- drivers/net/hyperv/netvsc.c | 17 + drivers/net/hyperv/rndis_filter.c | 39 --- 2 files changed, 21 i

[PATCH iproute2 v2 3/9] ip: use strlcpy() to avoid truncation

This fixes gcc-8 warnings about strncpy bounds by using strlcpy instead. Signed-off-by: Stephen Hemminger <step...@networkplumber.org> --- ip/iplink.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/ip/iplink.c b/ip/iplink.c index d401311bcad9..cca530

[PATCH iproute2 v2 2/9] pedit: fix strncpy warning

Newer versions of Gcc warn about string truncation. Fix by using strlcpy. Signed-off-by: Stephen Hemminger <step...@networkplumber.org> --- tc/m_pedit.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tc/m_pedit.c b/tc/m_pedit.c index 26549eeea899..8577f875a7c0

[PATCH iproute2 v2 5/9] namespace: fix warning snprintf buffer

It is possible that user could request really long namespace name and overrun the path buffer. Signed-off-by: Stephen Hemminger <step...@networkplumber.org> --- lib/namespace.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/lib/namespace.c b/lib/namespace.c

[PATCH iproute2 v2 8/9] misc: avoid snprintf warnings in ss and nstat

Gcc 8 checks that target buffer is big enough. Signed-off-by: Stephen Hemminger <step...@networkplumber.org> --- misc/nstat.c | 4 ++-- misc/ss.c| 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/misc/nstat.c b/misc/nstat.c index a4dd405d43a9..433a1f483be3

[PATCH iproute2 v2 7/9] ematch: fix possible snprintf overflow

Fixes gcc 8 warning about possible snprint overflow Signed-off-by: Stephen Hemminger <step...@networkplumber.org> --- tc/m_ematch.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tc/m_ematch.c b/tc/m_ematch.c index d2bb5c380382..0d66dc682314 100644 --- a/tc/m_ematch.c

[PATCH iproute2 v2 6/9] tc_class: fix snprintf warning

Size buffer big enough to avoid any possible overflow. Signed-off-by: Stephen Hemminger <step...@networkplumber.org> --- tc/tc_class.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/tc/tc_class.c b/tc/tc_class.c index 1b214b82c702..91802518bb27 100644 --

[PATCH iproute2 v2 9/9] bpf: avoid compiler warnings about strncpy

Use strlcpy to avoid cases where sizeof(buf) == strlen(buf) Signed-off-by: Stephen Hemminger <step...@networkplumber.org> --- lib/bpf.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/lib/bpf.c b/lib/bpf.c index c38d92d87759..04bc5a5685d5 100644 --- a/lib/bpf.c

[PATCH iproute2 v2 4/9] tunnel: use strlcpy to avoid strncpy warnings

-by: Stephen Hemminger <step...@networkplumber.org> --- ip/tunnel.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/ip/tunnel.c b/ip/tunnel.c index 948d5f7c90f6..abd9fa2ffe0c 100644 --- a/ip/tunnel.c +++ b/ip/tunnel.c @@ -64,7 +64,7 @@ int tnl_get_ioctl(const char *b

[PATCH iproute2 v2 0/9] gcc-8 warning fixes

This fixes most of the warning seen build iproute2 with gcc-8. There are still a couple in namespace and bpf to resolve related to PATH_MAX. Stephen Hemminger (9): bridge: avoid snprint truncation on time pedit: fix strncpy warning ip: use strlcpy() to avoid truncation tunnel: use strlcpy

[PATCH iproute2 v2 1/9] bridge: avoid snprint truncation on time

)tv.tv_sec, ^~~~ Note: already fixed in iproute2-next. Signed-off-by: Stephen Hemminger <step...@networkplumber.org> --- bridge/mdb.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/bridge/mdb.c b/bridge/mdb.c index 58c20b82b8a6..659cac3ff20a 100644 --- a/br

[PATCH iproute2 v2 0/9] gcc-8 warning fixes

This fixes most of the warnings when building with gcc-8. Still have issues with namespace and bpf. Stephen Hemminger (9): bridge: avoid snprint truncation on time pedit: fix strncpy warning ip: use strlcpy() to avoid truncation tunnel: use strlcpy to avoid strncpy warnings namespace

Re: [PATCH iproute2 1/1] tc: fix conversion types when printing actions unsigned values

On Mon, 19 Mar 2018 13:50:07 -0400 Roman Mashak wrote: > Signed-off-by: Roman Mashak > --- > tc/m_action.c | 2 +- > tc/m_gact.c | 2 +- > tc/m_ife.c| 2 +- > tc/m_pedit.c | 2 +- > tc/m_sample.c | 6 +++--- > tc/m_tunnel_key.c |

Re: [PATCH iproute2 net-next] bridge: add option extern_learn to set NTF_EXT_LEARNED on fdb entries

On Mon, 19 Mar 2018 10:20:10 -0700 Roopa Prabhu wrote: > From: Roopa Prabhu > > NTF_EXT_LEARNED can be set by a user on bridge fdb entry. > Provide a bridge command option to allow a user to set > NTF_EXT_LEARNED on a bridge fdb entry. > >

Re: [PATCH RFC iproute2] libnetlink: allow reading more than one message from extack

On Fri, 16 Mar 2018 16:23:09 -0300 Marcelo Ricardo Leitner wrote: > This patch introduces support for reading more than one message from > extack's and to adjust their level (warning/error) accordingly. > > Yes, there is a FIXME tag in the callback call for now. > >

[PATCH iproute2 3/5] bridge: avoid snprint truncation on time

)tv.tv_sec, ^~~~ Note: already fixed in iproute2-next. Signed-off-by: Stephen Hemminger <step...@networkplumber.org> --- bridge/mdb.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/bridge/mdb.c b/bridge/mdb.c index 58c20b82b8a6..659cac3ff20a 100644 --- a/br

[PATCH iproute2 4/5] pedit: fix strncpy warning

Newer versions of Gcc warn about string truncation. Fix by using strlcpy. Signed-off-by: Stephen Hemminger <step...@networkplumber.org> --- tc/m_pedit.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tc/m_pedit.c b/tc/m_pedit.c index 26549eeea899..8577f875a7c0

<    1   2   3   4   5   6   7   8   9   10   >