[PATCH net] ethtool: do not print warning for applications using legacy API

From: Stephen Hemminger <step...@networkplumber.org> In kernel log ths message appears on every boot: "warning: `NetworkChangeNo' uses legacy ethtool link settings API, link modes are only partially reported" When ethtool link settings API changed, it started complaining abo

Re: [PATCH iproute2 2/3] utils: ll_map: Update name and type for existing entry

On Wed, 20 Dec 2017 09:37:30 +0200 Serhey Popovych wrote: > In case of we update existing entry we need not only rehash > but also update name in existing entry. > > Need to update device type too since cached interface might > be deleted and new with same index, but

Re: [PATCH iproute2 3/3] utils: ll_map: Make network device name fixed size array of char

On Wed, 20 Dec 2017 09:37:31 +0200 Serhey Popovych wrote: > Network device names are fixed in size and never exceed > IFNAMSIZ (16 bytes). > > Make name fixed size array to always malloc() same size chunk > of memory and use memcpy()/memcmp() with constant IFNAMSIZ >

Re: [PATCH iproute2 3/3] ip/tunnel: Document "external" parameter

On Thu, 28 Dec 2017 13:11:42 +0200 Serhey Popovych wrote: > Add it to ip-link(8) "type gre" output help message > as well as to ip-link(8) page. > > Signed-off-by: Serhey Popovych Applied. Thanks

Re: [PATCH iproute2 1/3] vxcan,veth: Forbid "type" for peer device

On Thu, 28 Dec 2017 13:01:04 +0200 Serhey Popovych wrote: > It is already given for original device we configure this > peer for. > > Results from following command before/after change applied > are shown below: > > $ ip link add dev veth1a type veth peer name

Fw: [Bug 198297] New: Unable to add ethX to bridge if ethX. is already present in this bridge

I don't think this is ever going to work as expected. Begin forwarded message: Date: Thu, 28 Dec 2017 08:38:37 + From: bugzilla-dae...@bugzilla.kernel.org To: step...@networkplumber.org Subject: [Bug 198297] New: Unable to add ethX to bridge if ethX. is already present in this bridge

Re: [PATCH iproute] qdisc: Print offload indication

On Tue, 26 Dec 2017 11:48:45 +0200 Yuval Mintz wrote: > Use the newly added TCA_HW_OFFLOAD indication from kernel > to print a consistent 'offloaded' message to user when listing qdiscs. > > Signed-off-by: Yuval Mintz Applied to master (since

Re: [PATCH iproute2 0/3] ip/tunnel: Fix noencap- and document "external" parameter handling.

On Wed, 27 Dec 2017 13:28:13 +0200 Serhey Popovych wrote: > In this series I present next set of improvements/fixes: > > 1) Fix noencap- option handling: we need to clear bit, instead > of seting all, but one we expect to clear. > > 2) Document "external"

Re: [patch iproute2 v3 3/4] tc: Add -bs option to batch mode

On Wed, 27 Dec 2017 18:39:29 -0200 Marcelo Ricardo Leitner wrote: > > > + send = false; > > > + else > > > + send = true; > > > + > > > + ret = do_cmd(largc, largv, batch_size, msg_iov_index++, send); > > > > What

Re: [PATCH] hv_netvsc: update VF after name has changed.

On Tue, 26 Dec 2017 17:11:19 -0500 (EST) David Miller <da...@davemloft.net> wrote: > From: Stephen Hemminger <step...@networkplumber.org> > Date: Tue, 26 Dec 2017 13:51:43 -0800 > > > On Tue, 26 Dec 2017 12:25:12 -0500 (EST) > > David Miller <da...@davemloft.n

Re: [PATCH] hv_netvsc: update VF after name has changed.

On Tue, 26 Dec 2017 12:25:12 -0500 (EST) David Miller <da...@davemloft.net> wrote: > From: Stephen Hemminger <step...@networkplumber.org> > Date: Wed, 20 Dec 2017 14:33:23 -0800 > > > Since commit 6123c66854c1 ("netvsc: delay setup of VF device") > >

Re: [PATCH iproute2 0/2] ip/tunnel: Do not free() answer on rtnl_talk() error, correct ip6gre

On Wed, 20 Dec 2017 09:57:08 +0200 Serhey Popovych wrote: > In this series I present next set of improvements/fixes: > > 1) If rtnl_talk(), called with answer != NULL fails it > never returns with allocated answer: no need to > initialize answer and free()

Re: [PATCH iproute2 1/3] vxcan,veth: Forbid "type" for peer device

On Wed, 20 Dec 2017 09:37:29 +0200 Serhey Popovych wrote: > It is already given for original device we configure this > peer for. > > Results from following command before/after change applied > are shown below: > > $ ip link add dev veth1a type veth peer name

Re: iproute2 net-next

On Tue, 26 Dec 2017 06:47:43 +0200 Leon Romanovsky <l...@kernel.org> wrote: > On Mon, Dec 25, 2017 at 10:49:19AM -0800, Stephen Hemminger wrote: > > David Ahern has agreed to take over managing the net-next branch of > > iproute2. > > The new location is: > >

iproute2 net-next

of the merge window (up until -rc1) new features will get put into net-next to get some more review and testing time. This means that things like the proposed batch streaming mode will go through net-next. Thanks Stephen Hemminger pgp7OgxiQatY9.pgp Description: OpenPGP digital signature

Fw: [Bug 198253] New: stopping htb results in null pointer dereference

Begin forwarded message: Date: Mon, 25 Dec 2017 08:25:44 + From: bugzilla-dae...@bugzilla.kernel.org To: step...@networkplumber.org Subject: [Bug 198253] New: stopping htb results in null pointer dereference https://bugzilla.kernel.org/show_bug.cgi?id=198253 Bug ID: 198253

Re: [PATCH net-next] virtio_net: Add ethtool stats

On Wed, 20 Dec 2017 13:40:37 +0900 Toshiaki Makita wrote: > + > +static const struct virtnet_gstats virtnet_gstrings_stats[] = { > + { "rx_packets", VIRTNET_NETDEV_STAT(rx_packets) }, > + { "tx_packets", VIRTNET_NETDEV_STAT(tx_packets) }, >

[PATCH] hv_netvsc: update VF after name has changed.

ce renames device * if netvsc notifier detects rename, it can cancel timer and do immediate setup The delay can also be increased to allow for slower rules. Still need the delayed work to handle the case where rename is not done. Signed-off-by: Stephen Hemminger <sthem...@microsoft.com>

Re: [patch iproute2] tc: add -bs option for batch mode

On Wed, 20 Dec 2017 09:23:34 + Chris Mi wrote: > > Your real performance win is just not asking for ACK for every rule. > No. Even if batch_size > 1, we ack every rule. The real performance win is > to send multiple rules in one system call. If we are not asking for

[PATCH v2] hv_netvsc: automatically name slave VF network device

make the user experience better to associate the names. Based on feedback from all.systems.go talk. Signed-off-by: Stephen Hemminger <sthem...@microsoft.com> --- v2 - also handle case where synthetic device gets renamed and the case where rename causes clash with pre-existing devic

Re: [RFC] hv_netvsc: automatically name slave VF network device

On Tue, 19 Dec 2017 15:20:57 -0800 Jakub Kicinski <jakub.kicin...@netronome.com> wrote: > On Tue, 19 Dec 2017 14:50:17 -0800, Stephen Hemminger wrote: > > On Tue, 19 Dec 2017 14:44:37 -0800 > > "Samudrala, Sridhar" <sridhar.samudr...@intel.com> wrote: > &g

Re: [RFC PATCH] virtio_net: Extend virtio to use VF datapath when available

On Tue, 19 Dec 2017 14:37:50 -0800 "Samudrala, Sridhar" <sridhar.samudr...@intel.com> wrote: > On 12/19/2017 11:46 AM, Stephen Hemminger wrote: > > On Tue, 19 Dec 2017 11:42:33 -0800 > > "Samudrala, Sridhar" <sridhar.samudr...@intel.com> wrote: >

Re: [RFC] hv_netvsc: automatically name slave VF network device

On Tue, 19 Dec 2017 14:24:52 -0800 Jakub Kicinski <kubak...@wp.pl> wrote: > On Tue, 19 Dec 2017 14:06:59 -0800, Stephen Hemminger wrote: > > > > > > I assume you mean the modern application is udev, and it works > > > > > > but the name is

Re: [RFC] hv_netvsc: automatically name slave VF network device

On Tue, 19 Dec 2017 14:44:37 -0800 "Samudrala, Sridhar" wrote: > -static void __netvsc_vf_setup(struct net_device *ndev, > > - struct net_device *vf_netdev) > > -{ > > - int ret; > > + /* set the name of VF device based on upper device

Re: [RFC] hv_netvsc: automatically name slave VF network device

On Tue, 19 Dec 2017 13:55:29 -0800 Jakub Kicinski <kubak...@wp.pl> wrote: > On Tue, 19 Dec 2017 13:29:49 -0800, Stephen Hemminger wrote: > > > > biosdevname is dead, gone and wouldn't work on Azure (it dumpster > > > > dives in /dev/mem). > > >

Re: [RFC] hv_netvsc: automatically name slave VF network device

On Tue, 19 Dec 2017 13:18:16 -0800 Jakub Kicinski <kubak...@wp.pl> wrote: > On Tue, 19 Dec 2017 12:44:25 -0800, Stephen Hemminger wrote: > > On Tue, 19 Dec 2017 12:32:34 -0800 > > Jakub Kicinski <kubak...@wp.pl> wrote: > > > > > On Tue, 19 Dec 20

Re: [RFC] hv_netvsc: automatically name slave VF network device

On Tue, 19 Dec 2017 12:32:34 -0800 Jakub Kicinski <kubak...@wp.pl> wrote: > On Tue, 19 Dec 2017 11:35:37 -0800, Stephen Hemminger wrote: > > Rename the VF device to ethX_vf based on the ethX as the > > synthetic device. This eliminates the need for delay on setup, > &

Re: [RFC PATCH] virtio_net: Extend virtio to use VF datapath when available

On Tue, 19 Dec 2017 11:42:33 -0800 "Samudrala, Sridhar" <sridhar.samudr...@intel.com> wrote: > On 12/19/2017 10:41 AM, Stephen Hemminger wrote: > > On Tue, 19 Dec 2017 13:21:17 -0500 (EST) > > David Miller <da...@davemloft.net> wrote: > > > >>

[RFC] hv_netvsc: automatically name slave VF network device

make the user experience better to associate the names. Based on feedback from all.systems.go talk. The downside is that it requires exporting a symbol from netdev core which makes it harder to backport. Signed-off-by: Stephen Hemminger <sthem...@microsoft.com> --- drivers/net/hyperv/hyperv

Re: [RFC PATCH] virtio_net: Extend virtio to use VF datapath when available

On Tue, 19 Dec 2017 13:21:17 -0500 (EST) David Miller <da...@davemloft.net> wrote: > From: Stephen Hemminger <step...@networkplumber.org> > Date: Tue, 19 Dec 2017 09:55:48 -0800 > > > could be 10ms, just enough to let udev do its renaming > > Please, move to s

Re: [PATCH v1] bridge: Use helpers to handle MAC address

.shevche...@linux.intel.com> Looks good Signed-off-by: Stephen Hemminger <step...@networkplumber.org>

Re: [RFC PATCH] virtio_net: Extend virtio to use VF datapath when available

On Tue, 19 Dec 2017 20:07:01 +0200 "Michael S. Tsirkin" <m...@redhat.com> wrote: > On Tue, Dec 19, 2017 at 09:55:48AM -0800, Stephen Hemminger wrote: > > On Tue, 19 Dec 2017 09:41:39 -0800 > > "Samudrala, Sridhar" <sridhar.samudr...@intel.com> wrote

Re: [RFC PATCH] virtio_net: Extend virtio to use VF datapath when available

>> #define VIRTNET_DRIVER_VERSION "1.0.0" > >> > >> static const unsigned long guest_offloads[] = { > > Why is this delay necessary? And why by 100ms? > > This is based on netvsc implementation and here is the commit that > added this del

Re: [PATCH v3] iproute: list/flush/save filter also by metric

On Sun, 17 Dec 2017 13:02:11 +0100 Alexander Zubkov wrote: > Metric is one of the "unique key" fields of the route in Linux. But > still one can not use its value in filter while running ip list. > Because of this writing checks in scripts for example is incovenient. > >

Re: [PATCH] iproute: "list/flush/save default" selected all of the routes

On Sun, 17 Dec 2017 12:09:00 +0100 Alexander Zubkov wrote: > When running "ip route list default" and not specifying address family, > one will get all of the routes instead of just default only. The same > is for "exact default" and "match default". > > It behaves in such a way

Re: [PATCH iproute2 0/3] ip/tunnels: Reuse code, vti6 zero endpoint support and minor cleanup

On Mon, 18 Dec 2017 19:48:02 +0200 Serhey Popovych wrote: > In this series I present next set of improvements: > > 1) Use tnl_parse_key() to avoid code duplication in tunnel > configuration via netlink code. > > 2) Trivial: use IN6ADDR_ANY_INIT instead of

Re: [PATCH iproute2 1/3] iplink: Improve index parameter handling

On Mon, 18 Dec 2017 23:37:09 +0200 Serhey Popovich <serhe.popov...@gmail.com> wrote: > Stephen Hemminger wrote: > > On Mon, 18 Dec 2017 23:02:07 +0200 > > Serhey Popovich <serhe.popov...@gmail.com> wrote: > > > >> Stephen Hemminger wrote: > >&g

Re: [patch iproute2] tc: add -bs option for batch mode

On Tue, 19 Dec 2017 15:33:46 +0900 Chris Mi wrote: > Currently in tc batch mode, only one command is read from the batch > file and sent to kernel to process. With this patch, we can accumulate > several commands before sending to kernel. The batch size is specified > using

Re: [patch iproute2] tc: add -bs option for batch mode

On Tue, 19 Dec 2017 15:33:46 +0900 Chris Mi wrote: > Currently in tc batch mode, only one command is read from the batch > file and sent to kernel to process. With this patch, we can accumulate > several commands before sending to kernel. The batch size is specified > using

Re: [PATCH iproute2 1/3] iplink: Improve index parameter handling

On Mon, 18 Dec 2017 23:02:07 +0200 Serhey Popovich <serhe.popov...@gmail.com> wrote: > Stephen Hemminger wrote: > > On Mon, 18 Dec 2017 20:54:06 +0200 > > Serhey Popovych <serhe.popov...@gmail.com> wrote: > > > >> diff --git a/ip/iplink.c b/ip/i

Re: [PATCH iproute2 1/3] iplink: Improve index parameter handling

On Mon, 18 Dec 2017 20:54:06 +0200 Serhey Popovych wrote: > diff --git a/ip/iplink.c b/ip/iplink.c > index 1e685cc..4f9c169 100644 > --- a/ip/iplink.c > +++ b/ip/iplink.c > @@ -586,8 +586,10 @@ int iplink_parse(int argc, char **argv, struct > iplink_req *req, >

Re: [PATCH] Staging: irda: Do not check for NOT NULL before kfree()

On Tue, 19 Dec 2017 00:41:30 +0530 Shreeya Patel wrote: > Do not check for NOT NULL before calling kfree because if the > pointer is NULL, no action occurs. > Done using the following semantic patch by coccinelle. > > @@ > expression ptr; > @@ > > - if (ptr !=

[PATCH] utils: fix makeargs stack overflow

The makeargs() function did not handle end of string correctly and would reference past end of string. Signed-off-by: Stephen Hemminger <step...@networkplumber.org> --- lib/utils.c | 23 --- 1 file changed, 16 insertions(+), 7 deletions(-) diff --git a/lib/utils.c

[PATCH] ss: fix crash with invalid command input file

If given an invalid input file with -F flag, ss would crash. Examples of invalid input are line to long, or null file. Signed-off-by: Stephen Hemminger <sthem...@microsoft.com> --- misc/ssfilter.y | 20 ++-- 1 file changed, 14 insertions(+), 6 deletions(-) diff --git

Re: [PATCH iproute2] ip route: broken logic when using default word and family not specified

On Sat, 18 Nov 2017 14:12:48 +0100 Alexander Zubkov wrote: > Hello, > > I have found odd behaviour when using "ip route list" (and other bound > commands) with prefix "default". > > When family not specified, its value is completely ignored and "ip > route list default"

Re: [PATCH net] net: bridge: fix early call to br_stp_change_bridge_id

can be created either with netlink or ioctl. This change is also makes both ways of adding MAC have the same semantics; If bridge is created with ioctl then the bridge_id (and MAC) will not be changed until later device is added or MAC address is set by other operation. Signed-off-by: Stephen Hemminger <step...@networkplumber.org>

Re: [patch iproute2] tc: implement filter block sharing to ingress and clsact qdiscs

On Wed, 13 Dec 2017 16:13:57 +0100 Jiri Pirko wrote: > From: Jiri Pirko > > Signed-off-by: Jiri Pirko This needs to wait until block sharing makes it into net-next upstream.

Re: [PATCH iproute2 0/3] Improve tunnel local/remote endpoint params and gre link attribute handling

On Wed, 13 Dec 2017 21:35:59 +0200 Serhey Popovych wrote: > In this series following problems addressed: > > 1) Size of IFLA_GRE_LINK attribute is 32 bits long in , not 8 bit. > > 2) Use get_addr() instead of get_prefix() to parse local/remote > tunnel

Re: [PATCH] ip: add vxcan/veth to ip-link man page

On Sat, 16 Dec 2017 12:38:57 +0100 Oliver Hartkopp wrote: > veth and vxcan both create a vitual tunnel between a pair of virtual network > devices. This patch adds the content for the now supported vxcan netdevices > and the documentation to create peer devices for vxcan

Re: [PATCH v3 iproute2 1/1] ss: add missing path MTU parameter

On Fri, 15 Dec 2017 09:27:42 -0500 Roman Mashak wrote: > v3: >Rebase and use out() instead of printf(). > v2: >Print the path MTU immediately after the MSS, as it is easier to parse >for humans (suggested by Neal Cardwell). > > Signed-off-by: Roman Mashak

Re: [PATCH v2 0/5] Support for generalized use of make C={1,2} via a wrapper program

On Sat, 16 Dec 2017 15:42:25 +0100 Knut Omang wrote: > This patch series implements features to make it easier to run checkers on the > entire kernel as part of automatic and developer testing. > > This is done by replacing the sparse specific setup for the C={1,2}

Re: [PATCH v2 4/5] rds: Add runchecks.cfg for net/rds

On Sat, 16 Dec 2017 15:42:29 +0100 Knut Omang wrote: > + > +# Important to fix from a quality perspective: > +# > +except AVOID_BUG connection.c ib.c ib_cm.c ib_rdma.c ib_recv.c ib_ring.c > ib_send.c info.c loop.c message.c > +except AVOID_BUG rdma.c recv.c send.c stats.c

Re: [PATCH v4 iproute2 net-next] gre6: add collect metadata support

On Tue, 12 Dec 2017 18:22:52 -0800 William Tu wrote: > The patch adds 'external' option to support collect metadata > gre6 tunnel. The 'external' keyword is already used to set the > device into collect metadata mode such as vxlan, geneve, ipip, > etc. This patch extends

Re: [patch iproute2] tc: fix command "tc actions del" hang issue

On Thu, 14 Dec 2017 18:09:00 +0900 Chris Mi wrote: > If command is RTM_DELACTION, a non-NULL pointer is passed to rtnl_talk(). > Then flag NLM_F_ACK is not set on n->nlmsg_flags and netlink_ack() will > not be called. Command tc will wait for the reply for ever. > > Fixes:

Re: [PATCH v2 iproute2 1/1] ss: add missing path MTU parameter

On Thu, 14 Dec 2017 14:59:11 -0500 Roman Mashak wrote: > v2: >Print the path MTU immediately after the MSS, as it is easier to parse >for humans (suggested by Neal Cardwell). > > Signed-off-by: Roman Mashak Thanks for the patch, it looks like a

Re: [PATCH iproute2] iplink: validate maximum gso_max_size

On Tue, 12 Dec 2017 14:25:22 -0800 Solio Sarabia wrote: > Validate the upper limit for gso_max_size, valid range is [0-65,536] > inclusive. Fix minor whitespace in iplink man page. > > Signed-off-by: Solio Sarabia > --- Applied to net-next

[PATCH iproute] ip: validate vlan value for vlan info

The VLAN tag must be 0..4095 to be valid. Better to trap it here. Signed-off-by: Stephen Hemminger <step...@networkplumber.org> --- ip/iplink.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/ip/iplink.c b/ip/iplink.c index e83f1477e7bc..1e685cc23805 100644 --

Fw: [Bug 198163] New: vpn pptp protocol did not working properly in new kernel release

Begin forwarded message: Date: Thu, 14 Dec 2017 09:41:42 + From: bugzilla-dae...@bugzilla.kernel.org To: step...@networkplumber.org Subject: [Bug 198163] New: vpn pptp protocol did not working properly in new kernel release https://bugzilla.kernel.org/show_bug.cgi?id=198163

Re: [PATCH iproute2] ip: add vxcan to help text

On Wed, 13 Dec 2017 21:21:28 +0100 Oliver Hartkopp wrote: > Add missing tag 'vxcan' inside the help text which was missing in commit > efe459c76d35f ('ip: link add vxcan support'). > > Signed-off-by: Oliver Hartkopp Applied. Could you also fix

Re: [patch iproute2] tc: fix json array closing

On Wed, 13 Dec 2017 20:56:16 +0100 Jiri Pirko wrote: > From: Jiri Pirko > > Fixes: 2704bd625583 ("tc: jsonify actions core") > Signed-off-by: Jiri Pirko Good catch. Applied

Re: [PATCH net-next 0/4] ERSPAN version 2 (type III) support

On Wed, 13 Dec 2017 16:38:54 -0800 William Tu wrote: > ERSPAN has two versions, v1 (type II) and v2 (type III). This patch > series add support for erspan v2 based on existing erspan v1 > implementation. The first patch refactors the existing erspan v1's > header structure,

Re: [PATCH net] vxlan: Restore initial MTU setting based on lower device

uot;vxlan: refactor verification and application of > configuration") > Signed-off-by: Stefano Brivio <sbri...@redhat.com> > --- Good catch. Acked-by: Stephen Hemminger <step...@networkplumber.org>

Re: [PATCH iproute2] Show 'external' link mode in output

On Tue, 12 Dec 2017 12:23:19 -0800 Phil Dibowitz wrote: > Recently `external` support was added to the tunnel drivers, but there is no > way > to introspect this from userspace. This adds support for that. > > Now `ip -details link` shows it: > > ``` > 7: tunl60@NONE: mtu 1452

Re: BUG REPORT: iproute2 seems to have bug with dsfield/tos in ip-rule and ip-route

On Wed, 13 Dec 2017 09:40:08 -0800 Daniel Lakeland wrote: > This same problem as detailed here > > http://lists.openwall.net/netdev/2010/03/26/36 This mail reports an issue from 7 years ago, much nas changed since then. > > or here: > >

Re: [BUG] skge: a possible sleep-in-atomic bug in skge_remove

On Wed, 13 Dec 2017 15:42:56 +0800 Jia-Ju Bai <baijiaju1...@gmail.com> wrote: > On 2017/12/13 13:18, Stephen Hemminger wrote: > > On Tue, 12 Dec 2017 20:57:01 -0500 (EST) > > David Miller <da...@davemloft.net> wrote: > > > >> From: Stephen Hemminger &

Re: [BUG] skge: a possible sleep-in-atomic bug in skge_remove

On Tue, 12 Dec 2017 20:57:01 -0500 (EST) David Miller <da...@davemloft.net> wrote: > From: Stephen Hemminger <step...@networkplumber.org> > Date: Tue, 12 Dec 2017 10:22:40 -0800 > > > On Tue, 12 Dec 2017 08:34:45 -0500 (EST) > > David Miller <da...@davemloft.

Re: [PATCH v3 iproute2 net-next] gre6: add collect metadata support

On Tue, 12 Dec 2017 17:07:23 -0800 William Tu wrote: > +.RB external > +- make this tunnel externally controlled (or not, which is the default). > +This is also known as collect_metadata mode for tunnels. Much better. The man page still needs some work. The phrase "is also

[PATCH net-next 5/6] hv_netvsc: remove open_cnt reference count

There is only ever a single instance of network device object referencing the internal rndis object. Therefore the open_cnt atomic is not necessary. Signed-off-by: Stephen Hemminger <sthem...@microsoft.com> --- drivers/net/hyperv/hyperv_net.h | 2 -- drivers/net/hyperv/netvsc.c

[PATCH net-next 2/6] hv_netvsc: track memory allocation failures in ethtool stats

When skb can not be allocated, update ethtool statisitics rather than rx_dropped which is intended for netif_receive. Signed-off-by: Stephen Hemminger <sthem...@microsoft.com> --- drivers/net/hyperv/hyperv_net.h | 1 + drivers/net/hyperv/netvsc_drv.c | 5 +++-- 2 files changed, 4 inse

[PATCH net-next 1/6] hv_netvsc: copy_to_send buf can be void

Since only caller does not care about return value. Signed-off-by: Stephen Hemminger <sthem...@microsoft.com> --- drivers/net/hyperv/netvsc.c | 22 -- 1 file changed, 8 insertions(+), 14 deletions(-) diff --git a/drivers/net/hyperv/netvsc.c b/drivers/net/hyperv/ne

[PATCH net-next 6/6] hv_netvsc: empty current transmit aggregation if flow blocked

If the transmit queue is known full, then don't keep aggregating data. And the cp_partial flag which indicates that the current aggregation buffer is full can be folded in to avoid more conditionals. Signed-off-by: Stephen Hemminger <sthem...@microsoft.com> --- drivers/net/hyperv/hyperv

[PATCH net-next 4/6] hv_netvsc: pass netvsc_device to receive callback

The netvsc_receive_callback function was using RCU to find the appropriate underlying netvsc_device. Since calling function already had that pointer, this was unnecessary. Signed-off-by: Stephen Hemminger <sthem...@microsoft.com> --- drivers/net/hyperv/hyperv_net.h | 1 + drivers/net/

[PATCH net-next 0/6] hv_netvsc: minor changes

. This has not been seen in the wild, found by inspection. The reference count between net device and internal RNDIS is not needed. Stephen Hemminger (6): hv_netvsc: copy_to_send buf can be void hv_netvsc: track memory allocation failures in ethtool stats hv_netvsc: simplify function args

[PATCH net-next 3/6] hv_netvsc: simplify function args in receive status path

The caller (netvsc_receive) already has the net device pointer, and should just pass that to functions rather than the hyperv device. This eliminates several impossible error paths in the process. Signed-off-by: Stephen Hemminger <sthem...@microsoft.com> --- drivers/net/hyperv/hyperv

Re: [PATCH] veth: Optionally pad packets to minimum Ethernet length

On Tue, 12 Dec 2017 11:00:38 -0800 Ed Swierk <eswi...@skyportsystems.com> wrote: > On Tue, Dec 12, 2017 at 10:34 AM, Stephen Hemminger > <step...@networkplumber.org> wrote: > > Why not add to netdevsim rather than cluttering up a normal driver > > with test su

Re: [PATCH iproute2 net-next v2 0/4] Abstract columns, properly space and wrap fields

On Tue, 12 Dec 2017 01:46:29 +0100 Stefano Brivio wrote: > Currently, 'ss' simply subdivides the whole available screen width > between available columns, starting from a set of hardcoded amount > of spacing and growing column widths. > > This makes the output unreadable in

Re: [PATCH iproute2] tc: bash-completion: add missing 'classid' keyword

On Tue, 12 Dec 2017 16:45:15 +0100 Davide Caratti wrote: > users of 'matchall' filter can specify a value for the class id: update > bash-completion accordingly. > > Fixes: b32c0b64fa2b ("tc: bash-completion: Add support for matchall") > Signed-off-by: Davide Caratti

Re: [PATCH] veth: Optionally pad packets to minimum Ethernet length

On Tue, 12 Dec 2017 16:18:17 -0200 Marcelo Ricardo Leitner wrote: > On Tue, Dec 12, 2017 at 11:32:46AM -0600, Dan Williams wrote: > > On Tue, 2017-12-12 at 08:13 -0800, Ed Swierk wrote: > > > Most physical Ethernet devices pad short packets to the minimum > > >

[PATCH net] skge: remove redundunt free_irq under spinlock

The code to handle multi-port SKGE boards was freeing IRQ twice. The first one was under lock and might sleep. Signed-off-by: Stephen Hemminger <step...@networkplumber.org> --- Given that multi-port SKGE devices are very old and unlikely to still be in use. This patch does not need

Re: [PATCH] drivers/staging/irda: fix max dup length for kstrndup

On Tue, 12 Dec 2017 16:54:44 +0800 Ma Shimiao wrote: > If source string longer than max, kstrndup will alloc max+1 space. > So, we should make sure the result will not over limit. > > Signed-off-by: Ma Shimiao Did you read the TODO

Re: [BUG] skge: a possible sleep-in-atomic bug in skge_remove

and > > checked by my code review. > > This was added by: > > commit a9e9fd7182332d0cf5f3e601df3e71dd431b70d7 > Author: Stephen Hemminger <shemmin...@vyatta.com> > Date: Tue Sep 27 13:41:37 2011 -0400 > > skge: handle irq better on single port card > > I think the free_irq

Re: [PATCH net-next] net: bridge: use rhashtable for fdbs

On Tue, 12 Dec 2017 16:02:50 +0200 Nikolay Aleksandrov wrote: > Before this patch the bridge used a fixed 256 element hash table which > was fine for small use cases (in my tests it starts to degrade > above 1000 entries), but it wasn't enough for medium or large >

Re: [PATCH net-next] net: bridge: use rhashtable for fdbs

On Tue, 12 Dec 2017 16:02:50 +0200 Nikolay Aleksandrov wrote: > + memcpy(__entry->addr, f->key.addr.addr, ETH_ALEN); Maybe use ether_addr_copy() here?

Re: [PATCH] igb: Free IRQs when device is hotplugged

On Mon, 11 Dec 2017 18:45:02 -0500 Lyude Paul wrote: > Recently I got a Caldigit TS3 Thunderbolt 3 dock, and noticed that upon > hotplugging my kernel would immediately crash due to igb: > > [ 680.825801] kernel BUG at drivers/pci/msi.c:352! > [ 680.828388] invalid opcode:

Re: [PATCH iproute2 net-next 0/4] Abstract columns, properly space and wrap fields

On Fri, 8 Dec 2017 18:07:19 +0100 Stefano Brivio wrote: > Currently, 'ss' simply subdivides the whole available screen width > between available columns, starting from a set of hardcoded amount > of spacing and growing column widths. > > This makes the output unreadable in

Re: [PATCH iproute2 1/1] ss: remove duplicate assignment

On Mon, 11 Dec 2017 16:24:31 -0500 Roman Mashak wrote: > Signed-off-by: Roman Mashak Applied and added Fixes: 8250bc9ff4e5 ("ss: Unify inet sockets output")

[PATCH net-next 2/2] hv_netvsc: Fix the TX/RX buffer default sizes

uot;) Signed-off-by: Haiyang Zhang <haiya...@microsoft.com> Signed-off-by: Stephen Hemminger <sthem...@microsoft.com> --- drivers/net/hyperv/hyperv_net.h | 13 - drivers/net/hyperv/netvsc_drv.c | 4 2 files changed, 12 insertions(+), 5 deletions(-) diff --git a/drive

Re: [PATCH net-next 1/2] net: tap: replay while() loop with % operator in tap_get_queue()

On Mon, 11 Dec 2017 21:26:41 +0800 yuan linyu wrote: > From: yuan linyu > > Signed-off-by: yuan linyu > --- > drivers/net/tap.c | 6 +- > 1 file changed, 1 insertion(+), 5 deletions(-) > > diff --git

[PATCH net-next 1/2] hv_netvsc: Fix the receive buffer size limit

sion is only available after negotiation. So, we add the limit checking for legacy hosts in netvsc_init_buf(). Fixes: 5023a6db73196 ("netvsc: increase default receive buffer size") Signed-off-by: Haiyang Zhang <haiya...@microsoft.com> Signed-off-by: Stephen Hemminger <sthem...@microso

[PATCH net-next 0/2] hv_netvsc: Fix default and limit of recv buffe

The default for receive buffer descriptors is not correct, it should match the default receive buffer size and the upper limit of receive buffer size is too low. Also, for older versions of Window servers hosts, different lower limit check is necessary, otherwise the buffer request will be

Re: [PATCH net-next v3 0/2] veth and GSO maximums

On Fri, 8 Dec 2017 15:50:25 -0800 Solio Sarabia <solio.sara...@intel.com> wrote: > On Fri, Dec 08, 2017 at 02:23:23PM -0500, David Miller wrote: > > From: Stephen Hemminger <step...@networkplumber.org> > > Date: Thu, 7 Dec 2017 15:40:18 -0800 > > > > &g

[PATCH] rtnetlink: fix typo in GSO max segments

Fixes: 46e6b992c250 ("rtnetlink: allow GSO maximums to be set on device creation") Signed-off-by: Stephen Hemminger <sthem...@microsoft.com> --- net/core/rtnetlink.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/core/rtnetlink.c b/net/core/rtnetlink.c in

Re: [iproute2] ss: print tcpi_rcv_ssthresh

On Thu, 7 Dec 2017 16:12:00 -0800 Wei Wang wrote: > From: Wei Wang > > tcpi_rcv_ssthresh is an important stats when debugging receive side > behavior. > Add it to the ss output. > > Signed-off-by: Wei Wang > Signed-off-by: Eric

[PATCH net 0/3] netvsc fix buffer size issues

The changes to allow setting buffer size can cause issues on older versions of Windows Server which have smaller limits. And the actual maximum value for WS2016 is 31M not 16M. This is a resend of patchset that didn't make it to netdev correctly. Haiyang Zhang (3): hv_netvsc: Correct the max

[PATCH net 1/3] hv_netvsc: Correct the max receive buffer size

From: Haiyang Zhang <haiya...@microsoft.com> It should be 31 MB on recent host versions. Signed-off-by: Haiyang Zhang <haiya...@microsoft.com> Signed-off-by: Stephen Hemminger <sthem...@microsoft.com> --- drivers/net/hyperv/hyperv_net.h | 6 -- 1 file changed, 4 insertio

[PATCH net 3/3] hv_netvsc: Fix the default receive buffer size

ya...@microsoft.com> Signed-off-by: Stephen Hemminger <sthem...@microsoft.com> --- drivers/net/hyperv/netvsc_drv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/hyperv/netvsc_drv.c b/drivers/net/hyperv/netvsc_drv.c index dc70de674ca9..edfcde5d3621 100

[PATCH net 2/3] hv_netvsc: Limit the receive buffer size for legacy hosts

ang Zhang <haiya...@microsoft.com> Signed-off-by: Stephen Hemminger <sthem...@microsoft.com> --- drivers/net/hyperv/netvsc.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/net/hyperv/netvsc.c b/drivers/net/hyperv/netvsc.c index e4bcd202a56a..e5d16a8cf0d6 100644 --- a/drive

[PATCH net-next v3 0/2] veth and GSO maximums

rtnetlink infrastructure already has the messages and infrastructure to allow changing gso limits. With an updated iproute2 the following already works: # ip li set dev dummy0 gso_max_size 3 These patches are about making it easier with veth. Stephen Hemminger (2): rtnetlink: allow GSO

[PATCH net-next 1/2] rtnetlink: allow GSO maximums to be set on device creation

From: Stephen Hemminger <step...@networkplumber.org> Netlink device already allows changing GSO sizes with ip set command. The part that is missing is allowing overriding GSO settings on device creation. Signed-off-by: Stephen Hemminger <sthem...@microsoft.com> allow set gso on cre

[PATCH net-next 2/2] veth: set peer GSO values

When new veth is created, and GSO values have been configured on one device, clone those values to the peer. For example: # ip link add dev vm1 gso_max_size 65530 type veth peer name vm2 This should create vm1 <--> vm2 with both having GSO maximum size set to 65530. Signed-off-by: S

<    5   6   7   8   9   10   11   12   13   14   >