Re: [PATCH RFC iproute2-next 1/2] rdma: add 'link add/delete' commands

On 11/28/2018 4:25 PM, Jason Gunthorpe wrote: > On Wed, Nov 28, 2018 at 04:21:48PM -0600, Steve Wise wrote: > >>>> It does make sense to not require type.  The name must be unique so that >>>> should be enough.  I'll have to respin the kernel side though... >

Re: [PATCH RFC iproute2-next 1/2] rdma: add 'link add/delete' commands

On 11/28/2018 4:17 PM, Jason Gunthorpe wrote: > On Wed, Nov 28, 2018 at 02:18:55PM -0600, Steve Wise wrote: >> >> On 11/28/2018 2:13 PM, Leon Romanovsky wrote: >>> On Wed, Nov 28, 2018 at 02:07:29PM -0600, Steve Wise wrote: >>>> On 11/28/2018 2:04 PM, Leon Ro

Re: [PATCH RFC iproute2-next 1/2] rdma: add 'link add/delete' commands

On 11/28/2018 2:13 PM, Leon Romanovsky wrote: > On Wed, Nov 28, 2018 at 02:07:29PM -0600, Steve Wise wrote: >> >> On 11/28/2018 2:04 PM, Leon Romanovsky wrote: >>> On Wed, Nov 28, 2018 at 01:08:05PM -0600, Steve Wise wrote: >>>> On 11/28/2018 12:26 PM, Leon

Re: [PATCH RFC iproute2-next 1/2] rdma: add 'link add/delete' commands

On 11/28/2018 2:08 PM, Leon Romanovsky wrote: > On Wed, Nov 28, 2018 at 10:02:04PM +0200, Leon Romanovsky wrote: >> On Wed, Nov 28, 2018 at 01:34:14PM -0600, Steve Wise wrote: >>> ... >>> >>>>>> +rd_prepare_msg(rd, RDMA_NLDEV_CMD_NEWLINK, ,

Re: [PATCH RFC iproute2-next 1/2] rdma: add 'link add/delete' commands

On 11/28/2018 2:04 PM, Leon Romanovsky wrote: > On Wed, Nov 28, 2018 at 01:08:05PM -0600, Steve Wise wrote: >> >> On 11/28/2018 12:26 PM, Leon Romanovsky wrote: >>> On Thu, Sep 13, 2018 at 10:19:21AM -0700, Steve Wise wrote: >>>> Add new 'link' subcommand

Re: [PATCH RFC iproute2-next 1/2] rdma: add 'link add/delete' commands

... >>> + rd_prepare_msg(rd, RDMA_NLDEV_CMD_NEWLINK, , >>> + (NLM_F_REQUEST | NLM_F_ACK)); >>> + mnl_attr_put_strz(rd->nlh, RDMA_NLDEV_ATTR_DEV_NAME, name); >>> + mnl_attr_put_strz(rd->nlh, RDMA_NLDEV_ATTR_LINK_TYPE, type); >>> + mnl_attr_put_strz(rd->nlh,

Re: [PATCH RFC iproute2-next 1/2] rdma: add 'link add/delete' commands

On 11/28/2018 12:26 PM, Leon Romanovsky wrote: > On Thu, Sep 13, 2018 at 10:19:21AM -0700, Steve Wise wrote: >> Add new 'link' subcommand 'add' and 'delete' to allow binding a soft-rdma >> device to a netdev interface. >> >> EG: >> >> rdma link add rxe_eth

[PATCH RFC iproute2-next 2/2] rdma: man page update for link add/delete

Update the 'rdma link' man page with 'link add/delete' info. Signed-off-by: Steve Wise --- man/man8/rdma-link.8 | 51 +++ 1 file changed, 51 insertions(+) diff --git a/man/man8/rdma-link.8 b/man/man8/rdma-link.8 index 97dd8bb994d2..b994c326dc34

[PATCH RFC iproute2-next 1/2] rdma: add 'link add/delete' commands

Add new 'link' subcommand 'add' and 'delete' to allow binding a soft-rdma device to a netdev interface. EG: rdma link add rxe_eth0 type rxe dev eth0 rdma link delete rxe_eth0 Signed-off-by: Steve Wise --- rdma/link.c | 106 +++ rdma

[PATCH RFC iproute2-next 0/2] Dynamic rdma link creation

till under review [1]. Please comment! Thanks, Steve. [1] https://www.spinics.net/lists/linux-rdma/msg71469.html Steve Wise (2): rdma: add 'link add/delete' commands rdma: man page update for link add/delete man/man8/rdma-link.8 | 51 + rdma/link.c

RE: [PATCH iproute2-next] rdma: Refresh help section of resource information

> -Original Message- > From: Leon Romanovsky > Sent: Thursday, November 1, 2018 3:35 AM > To: David Ahern > Cc: Leon Romanovsky ; netdev > ; RDMA mailing list ; > Stephen Hemminger ; Steve Wise > > Subject: [PATCH iproute2-next] rdma: Refresh help sectio

Re: [PATCH rdma-next 1/5] RDMA/core: Provide getter and setter to access IB device name

On 9/20/2018 6:21 AM, Leon Romanovsky wrote: > From: Leon Romanovsky > > Prepare IB device name field to rename operation by ensuring that all > accesses to it are protected with lock and users don't see part of name. > > The protection is done with global device_lock because it is used in >

Re: [PATCH] cxgb4: fix abort_req_rss6 struct

(sorry for the late reply, I was out all last week) On 9/5/2018 5:55 PM, Jason Gunthorpe wrote: > On Fri, Aug 31, 2018 at 11:52:00AM -0700, Steve Wise wrote: >> Remove the incorrect WR_HDR field which can cause a misinterpretation >> of this CPL by ULDs. > > What does th

[PATCH] cxgb4: fix abort_req_rss6 struct

Remove the incorrect WR_HDR field which can cause a misinterpretation of this CPL by ULDs. Fixes: a3cdaa69e4ae ("cxgb4: Adds CPL support for Shared Receive Queues") Signed-off-by: Steve Wise --- Dave, Doug, and Jason, I request this merge through the rdma repo since the

RE: [PATCH mlx5-next] RDMA/mlx5: Don't use cached IRQ affinity mask

> > > > Hey Sagi, > > > > The patch works allowing connections for the various affinity mappings > below: > > > > One comp_vector per core across all cores, starting with numa-local cores: > > Thanks Steve, is this your "Tested by:" tag? Sure: Tested-by: Steve Wise

RE: [PATCH mlx5-next] RDMA/mlx5: Don't use cached IRQ affinity mask

> On 8/16/2018 1:26 PM, Sagi Grimberg wrote: > > > >> Let me know if you want me to try this or any particular fix. > > > > Steve, can you test this one? > > Yes! I'll try it out tomorrow. > > Stevo > Hey Sagi, The patch works allowing connections for the various affinity mappings below:

Re: [PATCH mlx5-next] RDMA/mlx5: Don't use cached IRQ affinity mask

On 8/16/2018 1:26 PM, Sagi Grimberg wrote: > >> Let me know if you want me to try this or any particular fix. > > Steve, can you test this one? Yes!  I'll try it out tomorrow.  Stevo > -- > [PATCH rfc] block: fix rdma queue mapping > > nvme-rdma attempts to map queues based on irq vector

Re: [PATCH mlx5-next] RDMA/mlx5: Don't use cached IRQ affinity mask

On 8/1/2018 9:27 AM, Max Gurtovoy wrote: > > > On 8/1/2018 8:12 AM, Sagi Grimberg wrote: >> Hi Max, > > Hi, > >> >>> Yes, since nvmf is the only user of this function. >>> Still waiting for comments on the suggested patch :) >>> >> >> Sorry for the late response (but I'm on vacation so I have

Re: [PATCH mlx5-next] RDMA/mlx5: Don't use cached IRQ affinity mask

On 7/23/2018 11:53 AM, Max Gurtovoy wrote: > > > On 7/23/2018 7:49 PM, Jason Gunthorpe wrote: >> On Fri, Jul 20, 2018 at 04:25:32AM +0300, Max Gurtovoy wrote: >>> >> [ 2032.194376] nvme nvme0: failed to connect queue: 9 ret=-18 > > queue 9 is not mapped (overlap). > please try

Re: [PATCH mlx5-next] RDMA/mlx5: Don't use cached IRQ affinity mask

On 7/24/2018 10:24 AM, Steve Wise wrote: > > On 7/19/2018 8:25 PM, Max Gurtovoy wrote: >>>>> [ 2032.194376] nvme nvme0: failed to connect queue: 9 ret=-18 >>>> queue 9 is not mapped (overlap). >>>> please try the bellow: >>>> >>&g

Re: [PATCH mlx5-next] RDMA/mlx5: Don't use cached IRQ affinity mask

On 7/19/2018 8:25 PM, Max Gurtovoy wrote: > [ 2032.194376] nvme nvme0: failed to connect queue: 9 ret=-18 >>> >>> queue 9 is not mapped (overlap). >>> please try the bellow: >>> >> >> This seems to work.  Here are three mapping cases:  each vector on its >> own cpu, each vector on 1 cpu

Re: [PATCH mlx5-next] RDMA/mlx5: Don't use cached IRQ affinity mask

On 7/19/2018 9:50 AM, Max Gurtovoy wrote: > > > On 7/18/2018 10:29 PM, Steve Wise wrote: >> >>> >>> On 7/18/2018 2:38 PM, Sagi Grimberg wrote: >>>> >>>>>> IMO we must fulfil the user wish to connect to N queues and not >>&g

RE: [PATCH mlx5-next] RDMA/mlx5: Don't use cached IRQ affinity mask

> > On 7/18/2018 2:38 PM, Sagi Grimberg wrote: > > > >>> IMO we must fulfil the user wish to connect to N queues and not reduce > >>> it because of affinity overlaps. So in order to push Leon's patch we > >>> must also fix the blk_mq_rdma_map_queues to do a best effort > mapping > >>> according

RE: [PATCH mlx5-next] RDMA/mlx5: Don't use cached IRQ affinity mask

> -Original Message- > From: Max Gurtovoy > Sent: Wednesday, July 18, 2018 9:14 AM > To: Sagi Grimberg ; Steve Wise > ; 'Leon Romanovsky' > Cc: 'Doug Ledford' ; 'Jason Gunthorpe' > ; 'RDMA mailing list' ; > 'Saeed Mahameed' ; 'linux-netdev' > > Subje

RE: [PATCH mlx5-next] RDMA/mlx5: Don't use cached IRQ affinity mask

> On 7/16/2018 8:08 PM, Steve Wise wrote: > > Hey Max: > > > > > > Hey, > > > On 7/16/2018 11:46 AM, Max Gurtovoy wrote: > >> > >> > >> On 7/16/2018 5:59 PM, Sagi Grimberg wrote: > >>> > >>>> Hi, >

Re: [PATCH mlx5-next] RDMA/mlx5: Don't use cached IRQ affinity mask

Hey Max: On 7/16/2018 11:46 AM, Max Gurtovoy wrote: > > > On 7/16/2018 5:59 PM, Sagi Grimberg wrote: >> >>> Hi, >>> I've tested this patch and seems problematic at this moment. >> >> Problematic how? what are you seeing? > > Connection failures and same error Steve saw: > > [Mon Jul 16 16:19:11

Re: iproute2 won't compile without AF_VSOCK

On 6/19/2018 3:29 PM, David Ahern wrote: > On 6/19/18 2:27 PM, David Ahern wrote: >> On 6/19/18 9:47 AM, Stephen Hemminger wrote: >>> On Tue, 19 Jun 2018 10:17:45 -0500 >>> Steve Wise wrote: >>> >>>> Hey David, >>>> >>

iproute2 won't compile without AF_VSOCK

Hey David, I'm trying to compile the latest iproute2 on an RHEL-7.3 distro, and it fails to compile because AF_VSOCK is not defined.  Should this functionality be a configure option to disable it on older distros? Thanks, Steve. misc     CC   ss.o ss.c:301:27: error: ‘AF_VSOCK’

[PATCH v3 iproute2-next 3/3] rdma: update man pages

Update the man pages for the resource attributes as well as the driver-specific attributes. Signed-off-by: Steve Wise <sw...@opengridcomputing.com> --- man/man8/rdma-resource.8 | 29 ++--- man/man8/rdma.8 | 2 +- 2 files changed, 27 insertions(+), 4 del

[PATCH v3 iproute2-next 2/3] rdma: print driver resource attributes

idx 171 msn 44 rqt_hwaddr 0x2a8a5d00 rqt_size 256 in_use 128 size 130 Signed-off-by: Steve Wise <sw...@opengridcomputing.com> --- rdma/rdma.c | 9 ++- rdma/rdma.h | 11 rdma/res.c | 30 +++-- rdma/utils.c | 196 +++

[PATCH v3 iproute2-next 1/3] rdma: update rdma_netlink.h to get new driver attributes

Pull in the rdma_netlink.h changes from kernel commits: 25a0ad85156a ("RDMA/nldev: Add explicit pad attribute") da5c85078215 ("RDMA/nldev: add driver-specific resource tracking)" 0d52d803767e ("RDMA/uapi: Fix uapi breakage") Signed-off-by: Steve Wise <sw...

[PATCH v3 iproute2-next 0/3] RDMA tool driver-specific resource tracking

le unknown driver attributes when printing Changes since v0/rfc: - changed "provider" to "driver" based on kernel side changes - updated man pages - removed "RFC" tag Thanks, Steve. [1] https://www.spinics.net/lists/linux-rdma/msg64199.html Steve Wise (3): rdma:

RE: [PATCH v2 iproute2-next 1/3] rdma: update rdma_netlink.h to get new driver attributes

> -Original Message- > From: David Ahern <dsah...@gmail.com> > Sent: Tuesday, May 15, 2018 3:02 PM > To: Doug Ledford <dledf...@redhat.com>; Steve Wise > <sw...@opengridcomputing.com>; l...@kernel.org > Cc: step...@networkplumber.org; netdev@vger.kerne

RE: [PATCH v2 iproute2-next 1/3] rdma: update rdma_netlink.h to get new driver attributes

> -Original Message- > From: linux-rdma-ow...@vger.kernel.org ow...@vger.kernel.org> On Behalf Of Doug Ledford > Sent: Tuesday, May 15, 2018 2:53 PM > To: David Ahern <dsah...@gmail.com>; Steve Wise > <sw...@opengridcomputing.com>; l...@kernel.org &g

RE: [PATCH v2 iproute2-next 1/3] rdma: update rdma_netlink.h to get new driver attributes

> On Tue, 2018-05-15 at 13:37 -0600, David Ahern wrote: > > On 5/14/18 9:42 AM, Steve Wise wrote: > > > diff --git a/rdma/include/uapi/rdma/rdma_netlink.h > b/rdma/include/uapi/rdma/rdma_netlink.h > > > index 60416ed..40be0d8 100644 > > > --- a/rdma/inclu

RE: [PATCH v1 iproute2-next 2/3] rdma: print driver resource attributes

> > On Tue, May 15, 2018 at 12:35:34PM -0400, Doug Ledford wrote: > > On Mon, 2018-05-14 at 09:51 -0500, Steve Wise wrote: > > > > > > On 5/13/2018 8:24 AM, Leon Romanovsky wrote: > > > > On Mon, May 07, 2018 at 08:53:16AM -0700, Steve Wise wrote: >

RE: [PATCH v1 iproute2-next 2/3] rdma: print driver resource attributes

> On Tue, May 15, 2018 at 09:31:27AM -0500, Steve Wise wrote: > > > cap net admin is not high enough privledge to see unhashed kernel > > > pointers. CAP_RAW_IO? Or follow what printk does? > > > > > > > Do you mean CAP_NET_RAW? Here's th

RE: [PATCH v1 iproute2-next 2/3] rdma: print driver resource attributes

> From: Jason Gunthorpe <j...@ziepe.ca> > On Tue, May 15, 2018 at 08:18:51AM -0500, Steve Wise wrote: > > > > > > On Mon, May 14, 2018 at 05:04:26PM -0500, Steve Wise wrote: > > > > > > > > > > > > > > > On 5/14/2018 3:4

RE: [PATCH v1 iproute2-next 2/3] rdma: print driver resource attributes

> On Mon, May 14, 2018 at 05:04:26PM -0500, Steve Wise wrote: > > > > > > On 5/14/2018 3:41 PM, Jason Gunthorpe wrote: > > > On Mon, May 07, 2018 at 08:53:16AM -0700, Steve Wise wrote: > > >> This enhancement allows printing rdma device-specif

RE: [PATCH v1 iproute2-next 2/3] rdma: print driver resource attributes

> > On Mon, May 14, 2018 at 05:04:26PM -0500, Steve Wise wrote: > > > > > > > > > On 5/14/2018 3:41 PM, Jason Gunthorpe wrote: > > > > On Mon, May 07, 2018 at 08:53:16AM -0700, Steve Wise wrote: > > > >> This enhanceme

Re: [PATCH v1 iproute2-next 2/3] rdma: print driver resource attributes

On 5/14/2018 3:41 PM, Jason Gunthorpe wrote: > On Mon, May 07, 2018 at 08:53:16AM -0700, Steve Wise wrote: >> This enhancement allows printing rdma device-specific state, if provided >> by the kernel. This is done in a generic manner, so rdma tool doesn't >> need to k

[PATCH v2 iproute2-next 3/3] rdma: update man pages

Update the man pages for the resource attributes as well as the driver-specific attributes. Signed-off-by: Steve Wise <sw...@opengridcomputing.com> --- man/man8/rdma-resource.8 | 29 ++--- man/man8/rdma.8 | 2 +- 2 files changed, 27 insertions(+), 4 del

[PATCH v2 iproute2-next 0/3] RDMA tool driver-specific resource tracking

nce v0/rfc: - changed "provider" to "driver" based on kernel side changes - updated man pages - removed "RFC" tag Thanks, Steve. [1] https://www.spinics.net/lists/linux-rdma/msg64199.html Steve Wise (3): rdma: update rdma_netlink.h to get new driver attributes

[PATCH v2 iproute2-next 1/3] rdma: update rdma_netlink.h to get new driver attributes

Pull in the rdma_netlink.h changes from kernel commits: 25a0ad85156a ("RDMA/nldev: Add explicit pad attribute") da5c85078215 ("RDMA/nldev: add driver-specific resource tracking)" Signed-off-by: Steve Wise <sw...@opengridcomputing.com> --- rdma/include/uap

[PATCH v2 iproute2-next 2/3] rdma: print driver resource attributes

idx 171 msn 44 rqt_hwaddr 0x2a8a5d00 rqt_size 256 in_use 128 size 130 idx 43 wr_id 0x881057c03408 idx 40 wr_id 0x881057c033f0 Signed-off-by: Steve Wise <sw...@opengridcomputing.com> --- rdma/rdma.c | 9 ++- rdma/rdma.h | 11 rdma/res.c |

Re: [PATCH v1 iproute2-next 1/3] rdma: update rdma_netlink.h to get driver attrs

On 5/13/2018 8:15 AM, Leon Romanovsky wrote: > On Mon, May 07, 2018 at 08:53:10AM -0700, Steve Wise wrote: >> Signed-off-by: Steve Wise <sw...@opengridcomputing.com> >> --- >> rdma/include/uapi/rdma/rdma_netlink.h | 37 >> ++-

Re: [PATCH v1 iproute2-next 2/3] rdma: print driver resource attributes

On 5/13/2018 8:24 AM, Leon Romanovsky wrote: > On Mon, May 07, 2018 at 08:53:16AM -0700, Steve Wise wrote: >> This enhancement allows printing rdma device-specific state, if provided >> by the kernel. This is done in a generic manner, so rdma tool doesn't > Do

Re: [PATCH v1 iproute2-next 2/3] rdma: print driver resource attributes

On 5/9/2018 11:08 PM, David Ahern wrote: > On 5/7/18 9:53 AM, Steve Wise wrote: >> @@ -152,7 +153,10 @@ int main(int argc, char **argv) >> pretty_output = true; >> break; >> case 'd': >> -

[PATCH v1 iproute2-next 3/3] rdma: update man pages

Update the man pages for the resource attributes as well as the driver-specific attributes. Signed-off-by: Steve Wise <sw...@opengridcomputing.com> --- man/man8/rdma-resource.8 | 29 ++--- man/man8/rdma.8 | 2 +- 2 files changed, 27 insertions(+), 4 del

[PATCH v1 iproute2-next 2/3] rdma: print driver resource attributes

idx 171 msn 44 rqt_hwaddr 0x2a8a5d00 rqt_size 256 in_use 128 size 130 idx 43 wr_id 0x881057c03408 idx 40 wr_id 0x881057c033f0 Signed-off-by: Steve Wise <sw...@opengridcomputing.com> --- rdma/rdma.c | 7 ++- rdma/rdma.h | 11 rdma/res.c |

[PATCH v1 iproute2-next 0/3] RDMA tool driver-specific resource tracking

be merged, I think. Changes since v0/rfc: - changed "provider" to "driver" based on kernel side changes - updated man pages - removed "RFC" tag Thanks, Steve. [1] https://www.spinics.net/lists/linux-rdma/msg64199.html Steve Wise (3): rdma: update rdma_netlink.h to

[PATCH v1 iproute2-next 1/3] rdma: update rdma_netlink.h to get driver attrs

Signed-off-by: Steve Wise <sw...@opengridcomputing.com> --- rdma/include/uapi/rdma/rdma_netlink.h | 37 ++- 1 file changed, 36 insertions(+), 1 deletion(-) diff --git a/rdma/include/uapi/rdma/rdma_netlink.h b/rdma/include/uapi/rdma/rdma_netlink.h index 4

[PATCH RFC iproute2-next 2/2] rdma: print provider resource attributes

idx 41 wq_pidx 171 msn 44 rqt_hwaddr 0x2a8a5d00 rqt_size 256 in_use 128 size 130 idx 43 wr_id 0x881057c03408 idx 40 wr_id 0x881057c033f0 Signed-off-by: Steve Wise <sw...@opengridcomputing.com> --- rdma/rdma.c | 7 ++- rdma/rdma.h | 11 rdma/res.c |

[PATCH RFC iproute2-next 1/2] rdma: update rdma_netlink.h to get provider attrs

Signed-off-by: Steve Wise <sw...@opengridcomputing.com> --- rdma/include/uapi/rdma/rdma_netlink.h | 37 ++- 1 file changed, 36 insertions(+), 1 deletion(-) diff --git a/rdma/include/uapi/rdma/rdma_netlink.h b/rdma/include/uapi/rdma/rdma_netlink.h index 4

[PATCH RFC iproute2-next 0/2] RDMA tool provider resource tracking

for-next branch (and all reviewing is complete), I'll post a final version and request merging. Thanks, Steve. [1] https://www.spinics.net/lists/linux-rdma/msg64013.html Steve Wise (2): rdma: update rdma_netlink.h to get provider attrs rdma: print provider resource attributes rdma/include/uapi

RE: [PATCH iproute2 rdma: Ignore unknown netlink attributes

g list r...@vger.kernel.org>; David Ahern <dsah...@gmail.com>; Steve Wise > <sw...@opengridcomputing.com> > Subject: [PATCH iproute2 rdma: Ignore unknown netlink attributes > > From: Leon Romanovsky <leo...@mellanox.com> > > The check if netlink attrib

RE: [PATCH v4 iproute2-next 0/7] cm_id, cq, mr, and pd resource tracking

> > On Sun, Apr 01, 2018 at 09:22:14AM -0600, David Ahern wrote: > > On 3/29/18 3:38 PM, Steve Wise wrote: > > > This series enhances the iproute2 rdma tool to include dumping of > > > connection manager id (cm_id), completion queue (cq), memory region > (mr)

[PATCH v4 iproute2-next 7/7] rdma: Add PD resource tracking information

[ib_srpt] dev mlx4_0 local_dma_lkey 0x8000 users 0 pid 0 comm [ib_srp] dev mlx4_0 local_dma_lkey 0x8000 users 1 pid 0 comm [ib_core] dev cxgb4_0 local_dma_lkey 0x0 users 0 pid 0 comm [ib_srp] Signed-off-by: Steve Wise <sw...@opengridcomputing.com> Reviewed-by: Leon Romanovsky <leo...@mel

[PATCH v4 iproute2-next 6/7] rdma: Add MR resource tracking information

comm [nvme_rdma] dev cxgb4_0 rkey 0x68fe4e9 lkey 0x68fe4e9 iova 0x835b91000 mrlen 65536 pid 0 comm [nvme_rdma] Signed-off-by: Steve Wise <sw...@opengridcomputing.com> Reviewed-by: Leon Romanovsky <leo...@mellanox.com> --- include/json_writer.h | 2 + lib/json_writer.c | 11

[PATCH v4 iproute2-next 5/7] rdma: Add CQ resource tracking information

] # rdma resource show cq pid 30489 dev mlx4_0 cqe 63 users 2 pid 30489 comm rping Signed-off-by: Steve Wise <sw...@opengridcomputing.com> Reviewed-by: Leon Romanovsky <leo...@mellanox.com> --- rdma/res.c | 149 +++ rdma/utils.c

[PATCH v4 iproute2-next 4/7] rdma: Add CM_ID resource tracking information

cxgb4_0/2 lqpn 1040 qp-type RC state CONNECT ps TCP pid 30498 comm rping src-addr 172.16.2.1:38246 dst-addr 172.16.2.1:7174 link mlx4_0/1 lqpn 538 qp-type RC state CONNECT ps TCP pid 30492 comm rping src-addr 172.16.99.1:43670 dst-addr 172.16.99.1:7174 Signed-off-by: Steve Wise <

[PATCH v4 iproute2-next 3/7] rdma: initialize the rd struct

Initialize the rd struct so port_idx is 0 unless set otherwise. Otherwise, strict_port queries end up passing an uninitialized PORT nlattr. Signed-off-by: Steve Wise <sw...@opengridcomputing.com> Reviewed-by: Leon Romanovsky <leo...@mellanox.com> --- rdma/rdma.c | 2 +- 1 fil

[PATCH v4 iproute2-next 1/7] rdma: update rdma_netlink.h

From: Steve Wise <sw...@opengridcomputing.com> Pull in the latest rdma_netlink.h which has support for the rdma nldev resource tracking objects being added with this patch series. Signed-off-by: Steve Wise <sw...@opengridcomputing.com> --- rdma/include/uapi/rdma/rdma_ne

[PATCH v4 iproute2-next 2/7] rdma: add UAPI rdma_user_cm.h

This allows parsing rdma_cm_id UAPI values. Signed-off-by: Steve Wise <sw...@opengridcomputing.com> --- rdma/include/uapi/rdma/rdma_user_cm.h | 324 ++ 1 file changed, 324 insertions(+) create mode 100644 rdma/include/uapi/rdma/rdma_user_cm.h diff --git

[PATCH v4 iproute2-next 0/7] cm_id, cq, mr, and pd resource tracking

sing cm_ids - only filter optional attrs if they are present - remove PGSIZE MR attr to match kernel [1] https://www.spinics.net/lists/linux-rdma/msg61720.html [2] https://www.spinics.net/lists/linux-rdma/msg62979.html https://www.spinics.net/lists/linux-rdma/msg62980.html --- Steve Wise (7):

RE: [PATCH v2 iproute2-next 3/6] rdma: Add CM_ID resource tracking information

> > On Tue, Mar 27, 2018 at 11:20:25AM -0500, Steve Wise wrote: > > > On Tue, Mar 27, 2018 at 10:45:30AM -0500, Steve Wise wrote: > > > > > > > > > > > > > > On Tue, Mar 27, 2018 at 06:15:44PM +0300, Leon Romanovsky wrote: > > &g

RE: [PATCH v2 iproute2-next 3/6] rdma: Add CM_ID resource tracking information

> On Tue, Mar 27, 2018 at 10:45:30AM -0500, Steve Wise wrote: > > > > > > > > On Tue, Mar 27, 2018 at 06:15:44PM +0300, Leon Romanovsky wrote: > > > > On Tue, Mar 27, 2018 at 08:44:55AM -0600, Jason Gunthorpe wrote: > > > > > On Tue, Mar

RE: [PATCH v2 iproute2-next 3/6] rdma: Add CM_ID resource tracking information

33PM -0600, Jason Gunthorpe wrote: > > > > > On Mon, Mar 26, 2018 at 04:34:44PM -0500, Steve Wise wrote: > > > > > > > > > > > > On 3/26/2018 4:15 PM, Jason Gunthorpe wrote: > > > > > > > On Mon, Mar 26, 2018 at 09:30:41AM -0500, Steve Wise w

Re: [PATCH v2 iproute2-next 3/6] rdma: Add CM_ID resource tracking information

On 3/26/2018 4:15 PM, Jason Gunthorpe wrote: > On Mon, Mar 26, 2018 at 09:30:41AM -0500, Steve Wise wrote: >> >> On 3/26/2018 9:17 AM, David Ahern wrote: >>> On 2/27/18 9:07 AM, Steve Wise wrote: >>>> diff --git a/rdma/rdma.h b/rdma/rdma.h >>>> inde

[PATCH v3 iproute2-next 5/8] rdma: Add CM_ID resource tracking information

cxgb4_0/2 lqpn 1040 qp-type RC state CONNECT ps TCP pid 30498 comm rping src-addr 172.16.2.1:38246 dst-addr 172.16.2.1:7174 link mlx4_0/1 lqpn 538 qp-type RC state CONNECT ps TCP pid 30492 comm rping src-addr 172.16.99.1:43670 dst-addr 172.16.99.1:7174 Signed-off-by: Steve Wise <

[PATCH v3 iproute2-next 8/8] rdma: Add PD resource tracking information

pid 0 comm [ib_srpt] link mlx4_0/- local_dma_lkey 0x8000 users 0 pid 0 comm [ib_srp] link mlx4_0/- local_dma_lkey 0x8000 users 1 pid 0 comm [ib_core] link cxgb4_0/- local_dma_lkey 0x0 users 0 pid 0 comm [ib_srp] Signed-off-by: Steve Wise <sw...@opengridcomputing.com> Reviewed-by: Leon Roma

[PATCH v3 iproute2-next 6/8] rdma: Add CQ resource tracking information

comm [ib_core] # rdma resource show cq pid 30489 link mlx4_0/- cqe 63 users 2 pid 30489 comm rping Signed-off-by: Steve Wise <sw...@opengridcomputing.com> Reviewed-by: Leon Romanovsky <leo...@mellanox.com> --- rdma/res.c | 139 +

[PATCH v3 iproute2-next 3/8] rdma: update rdma_netlink.h

From: Steve Wise <sw...@opengridcomputing.com> Pull in the latest rdma_netlink.h which has support for the rdma nldev resource tracking objects being added with this patch series. Signed-off-by: Steve Wise <sw...@opengridcomputing.com> --- rdma/include/uapi/rdma/rdma_ne

[PATCH v3 iproute2-next 4/8] rdma: initialize the rd struct

Initialize the rd struct so port_idx is 0 unless set otherwise. Otherwise, strict_port queries end up passing an uninitialized PORT nlattr. Signed-off-by: Steve Wise <sw...@opengridcomputing.com> Reviewed-by: Leon Romanovsky <leo...@mellanox.com> --- rdma/rdma.c | 2 +- 1 fil

[PATCH v3 iproute2-next 7/8] rdma: Add MR resource tracking information

65536 pid 0 comm [nvme_rdma] link cxgb4_0/- rkey 0x68fe4e9 lkey 0x68fe4e9 iova 0x835b91000 mrlen 65536 pid 0 comm [nvme_rdma] Signed-off-by: Steve Wise <sw...@opengridcomputing.com> Reviewed-by: Leon Romanovsky <leo...@mellanox.com> --- include/json_writer.h | 2 + lib/json_writer

[PATCH v3 iproute2-next 1/8] rdma: include rdma-core

This avoids requiring rdma-core be installed on systems. Signed-off-by: Steve Wise <sw...@opengridcomputing.com> --- rdma/include/rdma/rdma_cma.h | 728 +++ 1 file changed, 728 insertions(+) create mode 100644 rdma/include/rdma/rdma_cma.h diff

[PATCH v3 iproute2-next 2/8] rdma: Makefile change to find

Signed-off-by: Steve Wise <sw...@opengridcomputing.com> --- rdma/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/rdma/Makefile b/rdma/Makefile index 819fcbe..2cb46b6 100644 --- a/rdma/Makefile +++ b/rdma/Makefile @@ -4,7 +4,7 @@ include ../config.mk T

[PATCH v3 iproute2-next 0/8] cm_id, cq, mr, and pd resource tracking

- fixed memory leaks - removed PD_FLAGS attribute - filter on "mrlen" for mrs - filter on "poll-ctx" for cqs - don't require addrs or qp_type for parsing cm_ids - only filter optional attrs if they are present - remove PGSIZE MR attr to match kernel [1] https://www.spinics.net/lists/l

Re: [PATCH v2 iproute2-next 3/6] rdma: Add CM_ID resource tracking information

On 3/26/2018 10:40 AM, David Ahern wrote: > On 2/27/18 9:07 AM, Steve Wise wrote: >> Sample output: >> >> # rdma resource >> 2: cxgb4_0: pd 5 cq 2 qp 2 cm_id 3 mr 7 >> 3: mlx4_0: pd 7 cq 3 qp 3 cm_id 3 mr 7 >> >> # rdma resource show cm_id >> l

Re: [PATCH v2 iproute2-next 3/6] rdma: Add CM_ID resource tracking information

On 3/26/2018 12:06 PM, Leon Romanovsky wrote: > On Mon, Mar 26, 2018 at 10:24:25AM -0500, Steve Wise wrote: >> >> On 3/26/2018 10:08 AM, Leon Romanovsky wrote: >>> On Mon, Mar 26, 2018 at 09:55:46AM -0500, Steve Wise wrote: >>>> On 3/26/2018 9:44 AM, David A

Re: [PATCH v2 iproute2-next 3/6] rdma: Add CM_ID resource tracking information

On 3/26/2018 10:08 AM, Leon Romanovsky wrote: > On Mon, Mar 26, 2018 at 09:55:46AM -0500, Steve Wise wrote: >> >> On 3/26/2018 9:44 AM, David Ahern wrote: >>> On 3/26/18 8:30 AM, Steve Wise wrote: >>>> On 3/26/2018 9:17 AM, David Ahern wrote: >&g

Re: [PATCH iproute2-next 2/2] rdma: Print net device name and index for RDMA device

rd->jw, "netdev", netdev_name); > + jsonw_uint_field(rd->jw, "netdev_index", idx); > + } else { > + pr_out("netdev %s ", netdev_name); > + if (rd->show_details) > + pr_out("netdev_index %u ", id

Re: [PATCH v2 iproute2-next 3/6] rdma: Add CM_ID resource tracking information

On 3/26/2018 9:44 AM, David Ahern wrote: > On 3/26/18 8:30 AM, Steve Wise wrote: >> >> On 3/26/2018 9:17 AM, David Ahern wrote: >>> On 2/27/18 9:07 AM, Steve Wise wrote: >>>> diff --git a/rdma/rdma.h b/rdma/rdma.h >>>> index 5809f70..e55205b 1006

Re: [PATCH v2 iproute2-next 3/6] rdma: Add CM_ID resource tracking information

On 3/26/2018 9:17 AM, David Ahern wrote: > On 2/27/18 9:07 AM, Steve Wise wrote: >> diff --git a/rdma/rdma.h b/rdma/rdma.h >> index 5809f70..e55205b 100644 >> --- a/rdma/rdma.h >> +++ b/rdma/rdma.h >> @@ -18,10 +18,12 @@ >> #include >> #include

Re: [PATCH iproute2-next] rdma: Move RDMA UAPI header file to be under RDMA responsibility

On 3/26/2018 9:03 AM, David Ahern wrote: > On 3/25/18 12:38 AM, Leon Romanovsky wrote: >> From: Leon Romanovsky >> >> In iproute2 package, the updates of UAPIs files are performed >> after the needed feature lands in kernel's net-next tree. >> >> Such development flow

RE: [PATCH iproute2-next] rdma: Move RDMA UAPI header file to be under RDMA responsibility

tree. > > Such development flow created delays to the rdma tool developers, > who uses rdma-next tree as a basis for their work. > > Move RDMA UAPI file to be under rdma/ folder, so whole responsibility > of syncing this file will be on them. > > Signed-off-by: Leon Romano

Re: [PATCH v2 iproute2-next 0/6] cm_id, cq, mr, and pd resource tracking

1:32 AM, Leon Romanovsky wrote: >>>>>> On Mon, Mar 12, 2018 at 10:53:03AM -0700, David Ahern wrote: >>>>>>> On 3/12/18 8:16 AM, Steve Wise wrote: >>>>>>>> Hey all, >>>>>>>> >>>>>>>>

RE: interdependencies with cxgb4 and iw_cxgb4

> > From: "Steve Wise" <sw...@opengridcomputing.com> > Date: Tue, 20 Mar 2018 10:08:44 -0500 > > > For the maintainers, yes. But it avoids setting up k.o accounts and > > git repos for each device driver maintainer that has this issue. > >

RE: interdependencies with cxgb4 and iw_cxgb4

> >> > Let me ask a dumb question:  Why cannot one of the maintaners pull > the > >> > commit from the other mainainer's git repo directly?  IE why have this > >> > third trusted/signed git repo that has to be on k.o, from which both > >> > maintainers pull?  If one of you can pull it in via a

RE: interdependencies with cxgb4 and iw_cxgb4

> From: Steve Wise <sw...@opengridcomputing.com> > Date: Mon, 19 Mar 2018 14:50:57 -0500 > > > Let me ask a dumb question:  Why cannot one of the maintaners pull the > > commit from the other mainainer's git repo directly?  IE why have this > > third trusted/sign

Re: interdependencies with cxgb4 and iw_cxgb4

On 3/16/2018 11:21 AM, David Miller wrote: From: "Steve Wise" <sw...@opengridcomputing.com> Date: Wed, 14 Mar 2018 10:31:24 -0500 This issue has also been dealt-with for Mellanox drivers, I believe. I take it the solution for them was a k.o. signed repo, that they maintain,

RE: [PATCH v3 18/18] infiniband: cxgb4: Eliminate duplicate barriers on weakly-ordered archs

ID_V(wq->rq.bar2_qid), > +wq->rq.bar2_va + SGE_UDB_KDOORBELL); > } > > /* Flush user doorbell area writes. */ > wmb(); > return; > } > - writel(QID_V(wq->rq.qid) | PIDX_V(inc), wq->db); > + __raw_writel(QID_V(wq->rq.qid) | PIDX_V(inc), wq->db); > + mmiowmb(); > } > > Yes, this is what chelsio recommended to me. Reviewed-by: Steve Wise <sw...@opengridcomputing.com>

RE: [PATCH v3 18/18] infiniband: cxgb4: Eliminate duplicate barriers on weakly-ordered archs

> > On 3/16/2018 5:05 PM, Steve Wise wrote: > >> Code includes wmb() followed by writel(). writel() already has a barrier > > on > >> some architectures like arm64. > >> > >> This ends up CPU observing two barriers back to back before executing

RE: [PATCH v3 18/18] infiniband: cxgb4: Eliminate duplicate barriers on weakly-ordered archs

> > On Fri, Mar 16, 2018 at 04:05:10PM -0500, Steve Wise wrote: > > > Code includes wmb() followed by writel(). writel() already has a barrier > > on > > > some architectures like arm64. > > > > > > This ends up CPU observing two barriers back to

RE: [PATCH v3 18/18] infiniband: cxgb4: Eliminate duplicate barriers on weakly-ordered archs

> Code includes wmb() followed by writel(). writel() already has a barrier on > some architectures like arm64. > > This ends up CPU observing two barriers back to back before executing the > register write. > > Since code already has an explicit barrier call, changing writel() to >

interdependencies with cxgb4 and iw_cxgb4

Hey Dave, We've been discussing dependency issues between cxgb4 and the upper layer drivers including iw_cxgb4 on linux-rdma [1], and I want to broaden this discussion to include netdev and you, since this involves both linux-rdma and netdev. (note the SRQ patch submission that triggered this

RE: [PATCH v2 iproute2-next 3/6] rdma: Add CM_ID resource tracking information

> On Tue, Feb 27, 2018 at 08:07:05AM -0800, Steve Wise wrote: > > Sample output: > > > > # rdma resource > > 2: cxgb4_0: pd 5 cq 2 qp 2 cm_id 3 mr 7 > > 3: mlx4_0: pd 7 cq 3 qp 3 cm_id 3 mr 7 > > > > # rdma resource show cm_id > > link cxgb4_0/- l

RE: [PATCH v2 iproute2-next 0/6] cm_id, cq, mr, and pd resource tracking

> > On 3/12/18 8:16 AM, Steve Wise wrote: > > Hey all, > > > > The kernel side of this series has been merged for rdma-next [1]. Let me > > know if this iproute2 series can be merged, of if it needs more changes. > > > > The problem is that iproute2

RE: [PATCH v2 iproute2-next 0/6] cm_id, cq, mr, and pd resource tracking

dma-ow...@vger.kernel.org [mailto:linux-rdma- > ow...@vger.kernel.org] On Behalf Of Steve Wise > Sent: Friday, March 02, 2018 1:56 PM > To: dsah...@gmail.com > Cc: l...@kernel.org; step...@networkplumber.org; netdev@vger.kernel.org; > linux-r...@vger.kernel.org > Subject: [PATCH v2 iproute2

[PATCH v2 iproute2-next 3/6] rdma: Add CM_ID resource tracking information

cxgb4_0/2 lqpn 1040 qp-type RC state CONNECT ps TCP pid 30498 comm rping src-addr 172.16.2.1:38246 dst-addr 172.16.2.1:7174 link mlx4_0/1 lqpn 538 qp-type RC state CONNECT ps TCP pid 30492 comm rping src-addr 172.16.99.1:43670 dst-addr 172.16.99.1:7174 Signed-off-by: Steve Wise <

  1   2   3   4   5   >