Re: [PATCH v2] ath6kl: mark expected switch fall-throughs

2018-05-25 Thread Steve deRosier
band_2gig = true; > break; > case WMI_11AGN_CAP: > ht = true; > + /* fall through */ > case WMI_11AG_CAP: > band_2gig = true; > band_5gig = true; > -- > 2.7.4 Gustavo, Thanks for the adjustment. It now looks good to me. Reviewed-by: Steve deRosier <deros...@cal-sierra.com>

Re: RTL8723BE performance regression

2018-04-04 Thread Steve deRosier
18 That's the most basic setup, check the man page for more options. You will get best results if you can exclude other computers from your test network and other wireless devices from your airspace. - Steve -- Steve deRosier Cal-Sierra Consulting LLC https://www.cal-sierra.com/

Re: [RFC] ethtool: Support ETHTOOL_GSTATS2 command.

2018-03-20 Thread Steve deRosier
On Tue, Mar 20, 2018 at 8:39 AM, Ben Greear wrote: > On 03/20/2018 03:37 AM, Michal Kubecek wrote: >> >> On Wed, Mar 07, 2018 at 11:51:29AM -0800, gree...@candelatech.com wrote: >>> >>> From: Ben Greear >>> >>> This is similar to ETHTOOL_GSTATS,

Re: [PATCH v2 02/20] ath6kl: constify usb_device_id

2017-08-09 Thread Steve deRosier
> > /* table of devices that work with this driver */ > -static struct usb_device_id ath6kl_usb_ids[] = { > +static const struct usb_device_id ath6kl_usb_ids[] = { > {USB_DEVICE(0x0cf3, 0x9375)}, > {USB_DEVICE(0x0cf3, 0x9374)}, > { /* Terminating entry *

Re: [PATCH] ath6kl: fix spelling mistake: "Indicat" -> "Indicate"

2017-06-04 Thread Steve deRosier
t;__func__, packet); > action = ep->ep_cb.tx_full(ep->target, > packet); > if (action == HTC_SEND_FULL_DROP) { > -- > 2.11.0 > Looks good to me. Reviewed-by: Steve deRosier <deros...@gmail.com> - Steve

Re: [PATCH] ath6kl: Add __printf verification to ath6kl_dbg

2017-03-31 Thread Steve deRosier
On Fri, Mar 31, 2017 at 10:45 AM, Joe Perches <j...@perches.com> wrote: > On Fri, 2017-03-31 at 10:34 -0700, Steve deRosier wrote: >> On Fri, Mar 31, 2017 at 10:23 AM, Joe Perches <j...@perches.com> wrote: >> > On Fri, 2017-03-31 at 10:19 -0700, Steve deRosier wrot

Re: [PATCH] ath6kl: Add __printf verification to ath6kl_dbg

2017-03-31 Thread Steve deRosier
On Fri, Mar 31, 2017 at 10:23 AM, Joe Perches <j...@perches.com> wrote: > On Fri, 2017-03-31 at 10:19 -0700, Steve deRosier wrote: >> On Thu, Mar 30, 2017 at 3:57 PM, Joe Perches <j...@perches.com> wrote: >> > Fix fallout too. > [] >> My only ques

Re: [PATCH] ath6kl: Add __printf verification to ath6kl_dbg

2017-03-31 Thread Steve deRosier
intf format verification on the clauses that get compiled out?" So, it looks good to me as is, or if you feel like making the change I'm suggesting, that's fine too. And it builds and runs on my platforms. Reviewed-by: Steve deRosier <deros...@gmail.com> - Steve