[PATCH] net: sch: api: fix tcf_block_get

CONFIG_NET_CLS is not defined. Fixes: 8d1a77f974ca ("net: sch: api: add extack support in tcf_block_get") Signed-off-by: Sudip Mukherjee <sudipm.mukher...@gmail.com> --- The build log of next-20171222 is at: https://travis-ci.org/sudipm-mukherjee/parport/jobs/320089922 include/n

[PATCH] hamradio: baycom_par: use new parport device model

Modify baycom driver to use the new parallel port device model. Signed-off-by: Sudip Mukherjee <sudipm.mukher...@gmail.com> --- Not tested on real hardware, only tested on kvm with 32 bit guest and verified that the device is binding to the driver properly in par96_open but then unb

[PATCH] hamradio: baycom: use new parport device model

Modify baycom driver to use the new parallel port device model. Signed-off-by: Sudip Mukherjee <sudipm.mukher...@gmail.com> --- Not tested on real hardware, only tested on qemu and verified that the device is binding to the driver properly in epp_open but then unbinding as the

[PATCH] net: sched: fix mips build failure

: In function 'tcf_action_goto_chain_fini': ../net/sched/act_api.c:45:2: error: implicit declaration of function 'tcf_chain_put' [-Werror=implicit-function-declaration] Add two inline helpers for the case where CONFIG_NET_CLS is not enabled. Signed-off-by: Sudip Mukherjee <sudipm.muk

[PATCH] net: mv643xx_eth: fix build failure

safely use #if defined(CONFIG_OF_IRQ) in the code. Signed-off-by: Sudip Mukherjee <sudip.mukher...@codethink.co.uk> --- build log of next-20161216 is at: https://travis-ci.org/sudipm-mukherjee/parport/jobs/184652820 drivers/net/ethernet/marvell/mv643xx_eth.c | 2 +- 1 file changed, 1 insertio

[PATCH] net: bcm63xx_enet: fix build failure

ilize phy_ethtool_nway_reset") Signed-off-by: Sudip Mukherjee <sudip.mukher...@codethink.co.uk> --- build log is at: https://travis-ci.org/sudipm-mukherjee/parport/jobs/176269457 drivers/net/ethernet/broadcom/bcm63xx_enet.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/driv

[PATCH v2] net: smsc: remove build warning of duplicate definition

definition #define SMC_outb(v, a, r) outb(v, ((u32)a) + (r)) Signed-off-by: Sudip Mukherjee <sudip.mukher...@codethink.co.uk> --- v2: +#ifdef of v1 is removed. drivers/net/ethernet/smsc/smc91x.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/ethernet/smsc/smc91x.h b

[PATCH] net: smsc: remove build warning of duplicate definition

definition #define SMC_outb(v, a, r) outb(v, ((u32)a) + (r)) Signed-off-by: Sudip Mukherjee <sudip.mukher...@codethink.co.uk> --- m32r allmodconfig build of next-20160825 is at: https://travis-ci.org/sudipm-mukherjee/parport/jobs/154943795 drivers/net/ethernet/smsc/smc91x.h | 7

[PATCH] net: lantiq_etop: remove unused variable

The variable i was declared but was never used and we were getting a build warning for that. Signed-off-by: Sudip Mukherjee <sudip.mukher...@codethink.co.uk> --- drivers/net/ethernet/lantiq_etop.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/ethernet/lantiq_etop.c b/d

Re: ath9k gpio request

0x000F solves the problem. Tested-by: Sudip Mukherjee <sudip.mukher...@codethink.co.uk> Done, https://patchwork.kernel.org/patch/9151847/ But the patch 9151847 is different from what Sudip tested above? Why? And if you modify something _after_ the reporter has tested the patch cle

Re: ath9k gpio request

-by: Sudip Mukherjee <sudip.mukher...@codethink.co.uk> Regards Sudip

Re: ath9k gpio request

On Wednesday 01 June 2016 12:24 PM, Pan, Miaoqing wrote: which chip ? And what's the GPIO number ? lspci -v reports: 09:00.0 Network controller: Qualcomm Atheros AR9462 Wireless Network Adapter (rev 01) Subsystem: Foxconn International, Inc. Device e052 Flags: bus master,

Re: linux-next: Tree for May 30

On Monday 30 May 2016 08:52 AM, Stephen Rothwell wrote: Hi all, Changes since 20160527: Hi All, I have just built and booted with next-20160530 and my dmesg is full of warnings from ath9k. Last kernel tested was v4.6 and there was no problem with that. The traces are like: Call Trace: []

Re: [PATCH v2] mwifiex: fix possible NULL dereference

On Tuesday 12 April 2016 05:20 PM, Arend van Spriel wrote: On 12-04-16 13:46, Sudip Mukherjee wrote: From: Sudip Mukherjee <sudip.mukher...@codethink.co.uk> We have a check for card just after dereferencing it. So if it is NULL we have already dereferenced it before its check

[PATCH v2] mwifiex: fix possible NULL dereference

From: Sudip Mukherjee <sudip.mukher...@codethink.co.uk> We have a check for card just after dereferencing it. So if it is NULL we have already dereferenced it before its check. Lets dereference it after checking card for NULL. Signed-off-by: Sudip Mukherjee <sudip.mukher...@codeth

[PATCH] mwifiex: fix possible NULL dereference

From: Sudip Mukherjee <sudip.mukher...@codethink.co.uk> We have a check for card just after dereferencing it. So if it is NULL we have already dereferenced it before its check. Lets dereference it after checking card for NULL. Signed-off-by: Sudip Mukherjee <sudip.mukher...@codeth

[PATCH] ieee802154/adf7242: fix memory leak of firmware

If the firmware upload or the firmware verification fails then we printed the error message and exited but we missed releasing the firmware. Signed-off-by: Sudip Mukherjee <sudip.mukher...@codethink.co.uk> --- drivers/net/ieee802154/adf7242.c | 2 ++ 1 file changed, 2 insertions(+) diff

[PATCH] b43: Fix memory leaks in b43_bus_dev_ssb_init and b43_bus_dev_bcma_init

estion. Signed-off-by: Jia-Ju Bai <baijiaju1...@163.com> Acked-by: Michael Büsch <m...@bues.ch> Signed-off-by: Sudip Mukherjee <sudip.mukher...@codethink.co.uk> --- drivers/net/wireless/broadcom/b43/main.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drive

Re: [v2, resend] b43: Fix memory leaks in b43_bus_dev_ssb_init and b43_bus_dev_bcma_init

> > Thanks Michael for his suggestion. > > Signed-off-by: Jia-Ju Bai <baijiaju1...@163.com> The patch did not apply cleanly. I had to edit the patch to point to drivers/net/wireless/broadcom/b43/main.c For CONFIG_B43_SSB part- Tested-by: Sudip Mukherjee <sudip.mukher...@codethink.co.uk> regards sudip

Re: [PATCH] b43: fix memory leak

On Thursday 10 March 2016 11:13 PM, Michael Büsch wrote: On Fri, 19 Feb 2016 20:37:18 +0530 Sudip Mukherjee <sudipm.mukher...@gmail.com> wrote: https://patchwork.kernel.org/patch/8049041/ I have an old laptop running on 800Mhz CPU. It has "Broadcom BCM4311 [14e4:4311] (rev 01)&q

[PATCH] netfilter: xt_osf: remove unused variable

was not removed so that it will serve as a reminder to us that we can do something in that particular case. Signed-off-by: Sudip Mukherjee <sudip.mukher...@codethink.co.uk> --- net/netfilter/xt_osf.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/net/netfilter/xt_osf.c b/net/netfilter/xt

[PATCH] netcp: use pointer to fix build fail

operand") CC: John Fastabend <john.r.fastab...@intel.com> Signed-off-by: Sudip Mukherjee <sudip.mukher...@codethink.co.uk> --- build log at: https://travis-ci.org/sudipm-mukherjee/parport/jobs/110890068 drivers/net/ethernet/ti/netcp_core.c | 2 +- 1 file changed, 1 insertion(+), 1 dele

Re: [PATCH v2] net: phy: spi_ks8995: add dependency on GPIO

On Friday 19 February 2016 09:43 PM, David Miller wrote: From: Sudip Mukherjee <sudipm.mukher...@gmail.com> Date: Fri, 19 Feb 2016 13:59:09 +0530 On Tue, Feb 16, 2016 at 08:36:06PM -0500, David Miller wrote: From: Sudip Mukherjee <sudipm.mukher...@gmail.com> Date: Sat, 13 Feb 2

Re: [PATCH] b43: fix memory leak

On Friday 19 February 2016 01:14 PM, Kalle Valo wrote: Michael Büsch <m...@bues.ch> writes: On Thu, 18 Feb 2016 18:04:36 +0530 Sudip Mukherjee <sudipm.mukher...@gmail.com> wrote: From: Sudip Mukherjee <su...@vectorindia.org> On error we jumped to the label bcma_out and

Re: [PATCH v2] net: phy: spi_ks8995: add dependency on GPIO

On Tue, Feb 16, 2016 at 08:36:06PM -0500, David Miller wrote: > From: Sudip Mukherjee <sudipm.mukher...@gmail.com> > Date: Sat, 13 Feb 2016 19:33:15 +0530 > > > The builds of allmodconfig of s390, m68k, tilegx, tilepro is failing > > with the error: > > drivers/

[PATCH] b43: fix memory leak

From: Sudip Mukherjee <su...@vectorindia.org> On error we jumped to the label bcma_out and returned the error code but we missed freeing dev. Signed-off-by: Sudip Mukherjee <su...@vectorindia.org> --- drivers/net/wireless/broadcom/b43/main.c | 1 + 1 file changed, 1 insertion(+)

[PATCH] igmp: fix build warning

CONFIG_IP_MULTICAST is defined. Mark them as '__maybe_unused'. Signed-off-by: Sudip Mukherjee <su...@vectorindia.org> --- net/ipv4/igmp.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/net/ipv4/igmp.c b/net/ipv4/igmp.c index 7c95335..0ba241b 100644 --- a/net/ipv4/igmp.c +++ b/ne

[PATCH v2] net: phy: spi_ks8995: add dependency on GPIO

to reset the switch so we should have a dependency on GPIOLIB. While adding the dependency also add COMPILE_TEST so that we can build test it. Fixes: cd6f288cbaab ("net: phy: spi_ks8995: add support for resetting switch using GPIO") Cc: Helmut Buchsbaum <helmut.buchsb...@gmail.com> Sign

Re: [PATCH] net: phy: spi_ks8995: add dependency on GPIO

On Saturday 13 February 2016 03:42 PM, Geert Uytterhoeven wrote: On Fri, Feb 12, 2016 at 11:18 AM, Sudip Mukherjee <sudipm.mukher...@gmail.com> wrote: The builds of allmodconfig of s390, m68k, tilegx, tilepro is failing with the error: drivers/net/phy/spi_ks8995.c:477:3: error: im

[PATCH] net: phy: spi_ks8995: add dependency on GPIO

to reset the switch so we should have a dependency on GPIOLIB. Fixes: cd6f288cbaab ("net: phy: spi_ks8995: add support for resetting switch using GPIO") Cc: Helmut Buchsbaum <helmut.buchsb...@gmail.com> Signed-off-by: Sudip Mukherjee <su...@vectorindia.org> --- drivers/net/phy/

Re: [PATCH v3] rtlwifi: Fix improve function 'rtl_addr_delay()' in core.c

On Wed, Feb 03, 2016 at 02:21:46PM +0900, Byeoungwook Kim wrote: > Conditional codes in rtl_addr_delay() were improved in readability and > performance by using switch codes. > > Reviewed-by: Julian Calaby > Signed-off-by: Byeoungwook Kim >

Re: [v2,2/3] net: wireless: b43: Coding Style

On Mon, Oct 19, 2015 at 05:02:22PM +0100, Paul Mcquade wrote: > Fixed Pointer Coding Style > > Signed-off-by: Paul McQuade > Acked-by: Michael Buesch Please fix the From: name like i just replied in another of your patch and this patch will not apply anymore

Re: [RESEND,01/10] net: wireless: ath: Remove unnecessary semicolon

On Wed, Oct 28, 2015 at 12:32:36AM +0530, punit vara wrote: > This patch is to the htt_rx.c that removes unneeded semicolon which is > reported by coccicheck. > > Here semicolon just create empty statement so please remote it. s/remote/remove Instead of "net: wireless: ath: Remove unnecessary

Re: [1/3] net: wireless: rsi: Coding Spaces

On Sun, Oct 18, 2015 at 12:01:36AM +0100, Paul Mcquade wrote: > Removed space before that ',' > > Signed-off-by: Paul McQuade The From: name and Signed-off-by: name should be same else some of the stats generating tools will break. It should be Paul McQuade, not Paul

Re: net: wireless: rt2x00: Fixed Spacing issues

On Sat, Oct 17, 2015 at 09:04:39PM +0100, Paul Mcquade wrote: > Removed empty spaces before/after parenthesis > > Signed-off-by: Paul McQuade > Acked-by: Helmut Schaa > > --- > drivers/net/wireless/rt2x00/rt61pci.h | 20 ++-- >

Re: [PATCH] mac80211: fix memory leak

On Mon, Feb 01, 2016 at 11:28:37AM +0200, Kalle Valo wrote: > Sudip Mukherjee <sudipm.mukher...@gmail.com> writes: > > > On Mon, Feb 01, 2016 at 11:03:35AM +1100, Julian Calaby wrote: > >> Hi Sudip, > >> > >> On Fri, Jan 29, 2016 at 8:49 PM, Sud

[PATCH] ath10k: remove impossible code

From: Sudip Mukherjee <su...@vectorindia.org> len has been initialized with a value of 0 and buf_len with 4096. There is no way that this condition (len > buf_len) can be true now. Signed-off-by: Sudip Mukherjee <su...@vectorindia.org> --- drivers/net/wireless/ath/ath10k/debug.c

Re: [PATCH] mac80211: fix memory leak

On Mon, Feb 01, 2016 at 11:03:35AM +1100, Julian Calaby wrote: > Hi Sudip, > > On Fri, Jan 29, 2016 at 8:49 PM, Sudip Mukherjee > <sudipm.mukher...@gmail.com> wrote: > > On error we jumped to the error label and returned the error code but we > > missed relea

[PATCH] mac80211: fix memory leak

On error we jumped to the error label and returned the error code but we missed releasing sinfo. Signed-off-by: Sudip Mukherjee <su...@vectorindia.org> --- net/mac80211/sta_info.c | 1 + 1 file changed, 1 insertion(+) diff --git a/net/mac80211/sta_info.c b/net/mac80211/sta_info.c index 6

[PATCH 1/3] i40e: fix build warning

then we are having unused empty functions. Lets have these functions under CONFIG_GENEVE as the callback is already defined under CONFIG_GENEVE there is no chance of any failure. Signed-off-by: Sudip Mukherjee <su...@vectorindia.org> --- drivers/net/ethernet/intel/i40e/i40e_main.c | 6 ++-

[PATCH 3/3] defxx: fix build warning

We are getting many build warning about: 'bar_start' may be used uninitialized and 'bar_len' may be used uninitialized They are not actually uninitialized as dfx_get_bars() will initialize them properly. But still lets have them initialized just to satisfy the compiler. Signed-off-by: Sudip

[PATCH v2] defxx: fix build warning

-by: Sudip Mukherjee <su...@vectorindia.org> --- v2: only the first element is zeroed. drivers/net/fddi/defxx.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/net/fddi/defxx.c b/drivers/net/fddi/defxx.c index 7f975a2..de5eaa6 100644 --- a/drivers/ne

[PATCH 2/3] net: macb: fix build warning

the warning. Signed-off-by: Sudip Mukherjee <su...@vectorindia.org> --- drivers/net/ethernet/cadence/macb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/cadence/macb.c b/drivers/net/ethernet/cadence/macb.c index 9d9984a..50c9410 100644 --- a/drive

[PATCH] net/irda: bfin_sir: remove duplicate defines

ious definition port_membase, get_lsr_cache, put_lsr_cache are already defined in the architecture files, no need to define them again in the driver. Signed-off-by: Sudip Mukherjee <su...@vectorindia.org> --- drivers/net/irda/bfin_sir.h | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/ne

[PATCH] net: plip: use new parport device model

Modify plip driver to use the new parallel port device model. Signed-off-by: Sudip Mukherjee <su...@vectorindia.org> --- drivers/net/plip/plip.c | 36 1 file changed, 28 insertions(+), 8 deletions(-) diff --git a/drivers/net/plip/plip.c b/drivers/ne

Re: [PATCH] net/macb: add proper header file

On Thu, Dec 17, 2015 at 01:41:59PM +0100, Gregory CLEMENT wrote: > Hi Sudip, > > On jeu., déc. 17 2015, Sudip Mukherjee <sudipm.mukher...@gmail.com> wrote: > > > mips allmodconfig build fails with the error: > > > > drivers/net/ethernet/cadence/macb.c: In fu

[PATCH] net/macb: add proper header file

header file to resolve it. Fixes: 5833e0526820 ("net/macb: add support for resetting PHY using GPIO") Cc: Gregory CLEMENT <gregory.clem...@free-electrons.com> Signed-off-by: Sudip Mukherjee <su...@vectorindia.org> --- build log with next-20151217 is at: https://travis-c

Re: [PATCH] NFC: nci: fix memory leak

On Mon, Nov 16, 2015 at 06:27:15PM +0530, Sudip Mukherjee wrote: > In case of invalid number_destination_params we were returning error but > we missed releasing cmd. Lets check for the number of parameter before > allocating memory so that we don't have a memory leak. > > Signe

Re: Fixing full name in patchwork

On Tue, Dec 08, 2015 at 09:54:41AM +0200, Kalle Valo wrote: > Sudip Mukherjee <sudipm.mukher...@gmail.com> writes: > > > On Mon, Dec 07, 2015 at 08:03:54PM +0200, Kalle Valo wrote: > >> Hi Sudip, > >> > >> Sudip Mukherjee <sudipm.mukher...@gmail

Re: Fixing full name in patchwork

On Mon, Dec 07, 2015 at 08:03:54PM +0200, Kalle Valo wrote: > Hi Sudip, > > Sudip Mukherjee <sudipm.mukher...@gmail.com> writes: > > > We were dereferencing cmd first and checking for NULL later. Lets first > > check for NULL. > > > > Signed-off-by: Sudi

Re: [PATCH 3/4] staging: rtl8712: Make error handling check for failure

On Tue, Nov 24, 2015 at 10:19:41AM -0200, Mauro Dreissig wrote: > Some error handling paths are checking for success > instead of error on rtl871x_ioctl_rtl.c. > > Signed-off-by: Mauro Dreissig > --- > drivers/staging/rtl8712/rtl871x_ioctl_rtl.c | 239 >

[PATCH v2] libertas: check for NULL before use

If kzalloc fails it will return NULL. Lets check for NULL first before using the pointer. Signed-off-by: Sudip Mukherjee <su...@vectorindia.org> --- v2: commit message changed drivers/net/wireless/marvell/libertas/cfg.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff

[PATCH] net: dsa: fix build failure

We were getting build failure with allmodconfig of tile, tilegx, m32r and m68k with the error: implicit declaration of function 'gpio_to_desc' implicit declaration of function 'gpiod_direction_output' Fixes: cc30c16344fc ("net: dsa: Add support for a switch reset gpio") Signed-off

[PATCH] libertas: fix possible NULL dereference

We were dereferencing cmd first and checking for NULL later. Lets first check for NULL. Signed-off-by: Sudip Mukherjee <su...@vectorindia.org> --- drivers/net/wireless/marvell/libertas/cfg.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/wireless/m

Re: [PATCH] libertas: fix possible NULL dereference

On Tue, Nov 24, 2015 at 01:43:38AM +0200, Andy Shevchenko wrote: > On Mon, Nov 23, 2015 at 2:32 PM, Sudip Mukherjee > <sudipm.mukher...@gmail.com> wrote: > > We were dereferencing cmd first and checking for NULL later. Lets first > > check for NULL. > > However the

[PATCH] NFC: nci: fix memory leak

In case of invalid number_destination_params we were returning error but we missed releasing cmd. Lets check for the number of parameter before allocating memory so that we don't have a memory leak. Signed-off-by: Sudip Mukherjee <su...@vectorindia.org> --- net/nfc/nci/core.c | 6 +++---

Re: linux-next: Tree for Oct 6

On Tue, Oct 06, 2015 at 04:46:53PM +0200, Hans-Peter Nilsson wrote: > > From: Sudip Mukherjee <sudipm.mukher...@gmail.com> > > Date: Tue, 6 Oct 2015 14:33:46 +0200 > > > On Tue, Oct 06, 2015 at 06:25:22PM +1100, Stephen Rothwell wrote: > > > Hi all,

Re: linux-next: Tree for Oct 6

On Tue, Oct 06, 2015 at 06:25:22PM +1100, Stephen Rothwell wrote: > Hi all, > > Changes since 20151002: The build for cris allmodconfig is failing with the error: net/sched/sch_dsmark.c: In function 'dsmark_dequeue': net/sched/sch_dsmark.c:316:1: error: unrecognizable insn: (insn 245 244 119 15

[PATCH] net: via/Kconfig: GENERIC_PCI_IOMAP required if PCI not selected

both are not defined. Signed-off-by: Sudip Mukherjee <su...@vectorindia.org> --- Failed build log is at: https://travis-ci.org/sudipm-mukherjee/parport/jobs/81127188 An exactly similar patch has been posted earlier and relevant discussion is at: https://patchwork.ozlabs.org/patch/498722/ I

vhost: build failure

Hi, While crosscompiling the kernel for openrisc with allmodconfig the build failed with the error: drivers/vhost/vhost.c: In function 'vhost_vring_ioctl': drivers/vhost/vhost.c:818:3: error: call to '__compiletime_assert_818' declared with attribute error: BUILD_BUG_ON failed: __alignof__

Re: vhost: build failure

On Wed, Sep 16, 2015 at 11:36:45AM +0300, Michael S. Tsirkin wrote: > On Wed, Sep 16, 2015 at 01:50:08PM +0530, Sudip Mukherjee wrote: > > Hi, > > While crosscompiling the kernel for openrisc with allmodconfig the build > > failed with the error: > > drivers

Re: [PATCH] at86rf230: fix build warning

On Fri, Sep 11, 2015 at 03:16:04PM +0530, Sudip Mukherjee wrote: > e616a00ce786 ("drivers/net/ieee802154/at86rf230.c: seq_printf() now returns > NULL") > has removed the usage of the integer "ret" but missed removing the > variable. And we were getting a buil

[PATCH] at86rf230: fix build warning

02154/at86rf230.c: seq_printf() now returns NULL") Signed-off-by: Sudip Mukherjee <su...@vectorindia.org> --- drivers/net/ieee802154/at86rf230.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/ieee802154/at86rf230.c b/drivers/net/ieee802154/at86rf230.c index a9f3af

[PATCH] net: wan: sbni: fix device usage count

dev_get_by_name() will increment the usage count if the matching device is found. But we were not decrementing the count if we have got the device and the device is non-active. Signed-off-by: Sudip Mukherjee <su...@vectorindia.org> --- drivers/net/wan/sbni.c | 2 ++ 1 file changed, 2 inse

Re: [PATCH V3 3/7] Drivers: hv: vmbus: add APIs to send/recv hvsock packet and get the r/w-ability

On Thu, Jul 23, 2015 at 01:24:50PM +0300, Dan Carpenter wrote: On Thu, Jul 23, 2015 at 01:10:57PM +0300, Dan Carpenter wrote: In this specific case, writing it as if (ret != 0) caused the bug. If we had written it as if (ret) return ret; then there are no zeroes so wouldn't have been any

Re: [PATCH] staging: r8712u: Fix kernel warning for improper call of del_timer_sync()

On Mon, May 25, 2015 at 10:07:59PM -0700, Joe Perches wrote: On Tue, 2015-05-26 at 10:32 +0530, Sudip Mukherjee wrote: On Mon, May 25, 2015 at 09:55:08PM -0700, Joe Perches wrote: On Tue, 2015-05-26 at 10:16 +0530, Sudip Mukherjee wrote: On Mon, May 25, 2015 at 10:37:28AM -0700, Joe

Re: [PATCH] staging: r8712u: Fix kernel warning for improper call of del_timer_sync()

On Mon, May 25, 2015 at 10:37:28AM -0700, Joe Perches wrote: It'd be better if the approved patches from the intern list (no idea what that is) were sent to lkml/devel@driverdev lists for review before actually being applied. Its the outreachy program. And

Re: [PATCH] staging: r8712u: Fix kernel warning for improper call of del_timer_sync()

On Mon, May 25, 2015 at 09:55:08PM -0700, Joe Perches wrote: On Tue, 2015-05-26 at 10:16 +0530, Sudip Mukherjee wrote: On Mon, May 25, 2015 at 10:37:28AM -0700, Joe Perches wrote: It'd be better if the approved patches from the intern list (no idea what that is) were sent to lkml/devel

Re: [PATCH] staging: r8712u: Fix kernel warning for improper call of del_timer_sync()

I haven't been using kernel v4.1 so I haven't seen this warning, but looking at the code it seems to originate from the two recent patches to remove _cancel_timer and _cancel_timer_ex. I see that there's another patch in lkml [1] that changes del_timer_sync back to del_timer in more places.