[PATCH v2 2/2] batman-adv: Drop "experimental" from BATMAN_V Kconfig

The Kconfig option BATMAN_ADV_BATMAN_V is now enabled by default when the BATMAN_ADV is enabled. A feature which is enabled by default for a module should not be considered experimental. Reported-by: Joe Perches <j...@perches.com> Signed-off-by: Sven Eckelmann <s...@narfation.or

[PATCH v2 1/2] batman-adv: Remove "default n" in Kconfig

The "default n" is the default value for any bool or tristate Kconfig setting. It is therefore not necessary to add it to a config entry. Reported-by: Sergei Shtylyov <sergei.shtyl...@cogentembedded.com> Signed-off-by: Sven Eckelmann <s...@narfation.org> --- v2: change

[PATCH 2/2] batman-adv: Drop "experimental" from BATMAN_V Kconfig

The Kconfig option BATMAN_ADV_BATMAN_V is now enabled by default when the BATMAN_ADV is enabled. A feature which is enabled by default for a module should not be considered experimental. Reported-by: Joe Perches <j...@perches.com> Signed-off-by: Sven Eckelmann <s...@narfation.org> ---

[PATCH 1/2] batman-adv: Remove "default n" in Kconfig

The "default n" is the default value for any bool or tristate Kconfig setting. It is therefore not necessary to add it to the an config entry. Reported-by: Sergei Shtylyov <sergei.shtyl...@cogentembedded.com> Signed-off-by: Sven Eckelmann <s...@narfation.org> --- net/

Re: [PATCH 2/8] batman-adv: Disable CONFIG_BATMAN_ADV_DEBUGFS by default

On Freitag, 25. Mai 2018 14:13:40 CEST Sergei Shtylyov wrote: > > [...] > >>> --- a/net/batman-adv/Kconfig > >>> +++ b/net/batman-adv/Kconfig > >>> @@ -94,13 +94,13 @@ config BATMAN_ADV_DEBUGFS > >>> bool "batman-adv debugfs entries" > >>> depends on BATMAN_ADV > >>> depends on DEBUG_FS > >>> -

Re: [PATCH 2/8] batman-adv: Disable CONFIG_BATMAN_ADV_DEBUGFS by default

On Freitag, 25. Mai 2018 13:33:59 CEST Sergei Shtylyov wrote: [...] > > --- a/net/batman-adv/Kconfig > > +++ b/net/batman-adv/Kconfig > > @@ -94,13 +94,13 @@ config BATMAN_ADV_DEBUGFS > > bool "batman-adv debugfs entries" > > depends on BATMAN_ADV > > depends on DEBUG_FS > > - default y > >

Re: [B.A.T.M.A.N.] [PATCH 03/17] batman-adv: Add network_coding and mcast sysfs files to README

Hi Jiri, seems like you still haven't answered Linus' question. On Montag, 7. Mai 2018 08:34:16 CEST Sven Eckelmann wrote: > On Dienstag, 27. März 2018 17:43:08 CEST Linus Lüssing wrote: > > On Sat, Oct 29, 2016 at 12:56:28PM +0200, Jiri Pirko wrote: > > > >> I stron

Re: [B.A.T.M.A.N.] [PATCH 03/17] batman-adv: Add network_coding and mcast sysfs files to README

On Dienstag, 27. März 2018 17:43:08 CEST Linus Lüssing wrote: > On Sat, Oct 29, 2016 at 12:56:28PM +0200, Jiri Pirko wrote: > > >> I strongly believe it is a huge mistake to use sysfs for things like > > >> this. This should be done via generic netlink api. > > > > > >This doesn't change the

Re: [B.A.T.M.A.N.] [PATCH] batman-adv: fix batadv_interface_tx()'s return type

On Dienstag, 24. April 2018 15:18:46 CEST Luc Van Oostenryck wrote: > The method ndo_start_xmit() is defined as returning an 'netdev_tx_t', > which is a typedef for an enum type, but the implementation in this > driver returns an 'int'. > > Fix this by returning 'netdev_tx_t' in this driver too.

Re: [PATCH] batman-adv: fix batadv_interface_tx()'s return type

On Dienstag, 24. April 2018 15:18:46 CEST Luc Van Oostenryck wrote: [...] > -static int batadv_interface_tx(struct sk_buff *skb, > +static netdev_tx_t batadv_interface_tx(struct sk_buff *skb, > struct net_device *soft_iface) > { > struct ethhdr *ethhdr; >

Re: [B.A.T.M.A.N.] [PATCH][next] batman-adv: don't pass a NULL hard_iface to batadv_hardif_put

On Freitag, 23. März 2018 23:53:50 CET Colin King wrote: > From: Colin Ian King > > In the case where hard_iface is NULL, the error path may pass a null > pointer to batadv_hardif_put causing a null pointer dereference error. > Avoid this by only calling the function if

Re: [B.A.T.M.A.N.] [RFC] batman-adv: always assume 2-byte packet alignment

On Mittwoch, 24. Januar 2018 14:40:03 CET Sven Eckelmann wrote: [...] > I know your intentions and I understand the problem. But there is the chance > that David Miller will reject this patch - like he did it some years ago > with a similar (not the same) patch: > > &q

Re: [RFC] batman-adv: always assume 2-byte packet alignment

On Mittwoch, 24. Januar 2018 12:21:37 CET Matthias Schiffer wrote: > NIC drivers generally try to ensure that the "network header" is aligned > to a 4-byte boundary. This is not always possible: When Ethernet frames are > encapsulated in other packets with 4-byte aligned headers, the inner >

[PATCH v4 1/5] batman-adv: Let packet.h include its headers directly

The headers used by packet.h should also be included by it directly. main.h is currently dealing with it in batman-adv, but this will no longer work when this header is moved to include/uapi/linux/. Signed-off-by: Sven Eckelmann <sven.eckelm...@openmesh.com> --- net/batman-adv/main.h

[PATCH v4 4/5] batman-adv: Convert packet.h to uapi header

ETH_P_BATMAN ethernet packets. Signed-off-by: Sven Eckelmann <sven.eckelm...@openmesh.com> --- MAINTAINERS | 1 + net/batman-adv/packet.h => include/uapi/linux/batadv_packet.h | 8 net/batman-adv/bat_iv_ogm.c

[PATCH v4 3/5] batman-adv: Remove kernel fixed width types in packet.h

The uapi headers use the __u8/__u16/... version of the fixed width types instead of u8/u16/... The use of the latter must be avoided before packet.h is copied to include/uapi/linux/. Signed-off-by: Sven Eckelmann <sven.eckelm...@openmesh.com> --- net/batman-adv/packet.h

[PATCH v4 0/5] flow_dissector: Provide basic batman-adv unicast handling

vide the correct definitions to flow_dissector.c Kind regards, Sven Sven Eckelmann (5): batman-adv: Let packet.h include its headers directly batman-adv: Remove usage of BIT(x) in packet.h batman-adv: Remove kernel fixed width types in packet.h batman-adv: Convert packet.h to uapi header fl

[PATCH v4 5/5] flow_dissector: Parse batman-adv unicast headers

the same neighbor to different cores. Signed-off-by: Sven Eckelmann <sven.eckelm...@openmesh.com> --- net/core/flow_dissector.c | 57 +++ 1 file changed, 57 insertions(+) diff --git a/net/core/flow_dissector.c b/net/core/flow_dissector.c

[PATCH v4 2/5] batman-adv: Remove usage of BIT(x) in packet.h

The BIT(x) macro is no longer available for uapi headers because it is defined outside of it (linux/bitops.h). The use of it must therefore be avoided and replaced by an appropriate other representation. Signed-off-by: Sven Eckelmann <sven.eckelm...@openmesh.com> --- net/batman-adv/packet.

Re: [B.A.T.M.A.N.] [PATCH 00/19] pull request for net-next: batman-adv 2017-12-20

On Mittwoch, 20. Dezember 2017 14:39:46 CET David Miller wrote: [...] > Pulled, but there was a minor docbook annotation conflict I had to > address. > > This pull added () to the function names in the docbook comments, > but this overlapped with the fix of a variable name in the docbook > info

Re: [B.A.T.M.A.N.] [RFC v3 0/4] flow_dissector: Provide basic batman-adv unicast handling

On Freitag, 15. Dezember 2017 17:51:19 CET Willem de Bruijn wrote: [] > Thanks for making these changes. The flow dissection looks good to me. > > One possible issue is that this exposes kernel fixed width types u8/u16/.. > to userspace. For posix compatibility reasons, uapi headers use the >

[RFC v3 1/4] batman-adv: Let packet.h include its headers directly

The headers used by packet.h should also be included by it directly. main.h is currently dealing with it in batman-adv, but this will no longer work when this header is moved to include/uapi/linux/. Signed-off-by: Sven Eckelmann <sven.eckelm...@openmesh.com> --- net/batman-adv/main.h

[RFC v3 3/4] batman-adv: Convert packet.h to uapi header

ETH_P_BATMAN ethernet packets. Signed-off-by: Sven Eckelmann <sven.eckelm...@openmesh.com> --- MAINTAINERS | 1 + net/batman-adv/packet.h => include/uapi/linux/batadv_packet.h | 8 net/batman-adv/bat_iv_ogm.c

[RFC v3 2/4] batman-adv: Remove usage of BIT(x) in packet.h

The BIT(x) macro is no longer available for uapi headers because it is defined outside of it (linux/bitops.h). The use of it must therefore be avoided and replaced by an appropriate other representation. Signed-off-by: Sven Eckelmann <sven.eckelm...@openmesh.com> --- net/batman-adv/packet.

[RFC v3 4/4] flow_dissector: Parse batman-adv unicast headers

the same neighbor to different cores. Signed-off-by: Sven Eckelmann <sven.eckelm...@openmesh.com> --- net/core/flow_dissector.c | 57 +++ 1 file changed, 57 insertions(+) diff --git a/net/core/flow_dissector.c b/net/core/flow_dissector.c

[RFC v3 0/4] flow_dissector: Provide basic batman-adv unicast handling

et.h/uapi headers around to provide the correct definitions to flow_dissector.c Kind regards, Sven [1] https://patchwork.open-mesh.org/patch/17162/ Sven Eckelmann (4): batman-adv: Let packet.h include its headers directly batman-adv: Remove usage of BIT(x) in packet.h batman-adv: Convert

Re: [B.A.T.M.A.N.] [RFC v2 2/6] batman-adv: Rename batman-adv.h to batadv_genl.h

On Freitag, 15. Dezember 2017 11:57:55 CET Willem de Bruijn wrote: > > No, this is also bad because batman_adv.h is MIT license and packet.h is > > GPL-2. So what other name would you suggest for packet.h? > > batman_adv_packet.h? > > Sure, that sounds great. Thanks. Really? Isn't

Re: [PATCH 09/20] batman-adv: include build_bug.h for BUILD_BUG_ON define

On Freitag, 15. Dezember 2017 12:43:09 CET Simon Wunderlich wrote: > compat-include/linux/build_bug.h | 34 ++ This backport change slipped in. Sorry, this was my fault when I initially integrating it. Kind regards, Sven signature.asc Description: This is a

Re: [B.A.T.M.A.N.] [RFC v2 2/6] batman-adv: Rename batman-adv.h to batadv_genl.h

On Freitag, 15. Dezember 2017 11:32:05 CET Sven Eckelmann wrote: > On Mittwoch, 6. Dezember 2017 11:58:14 CET Willem de Bruijn wrote: > [...] > > >> > --- > > >> > MAINTAINERS| 2 +- > > >> > inc

Re: [B.A.T.M.A.N.] [RFC v2 2/6] batman-adv: Rename batman-adv.h to batadv_genl.h

On Mittwoch, 6. Dezember 2017 11:58:14 CET Willem de Bruijn wrote: [...] > >> > --- > >> > MAINTAINERS| 2 +- > >> > include/uapi/linux/{batman_adv.h => batadv_genl.h} | 6 +++--- > >> > >> This and the previous patch changes uapi. That might break userspace

Re: [RFC v2 6/6] flow_dissector: Parse batman-adv unicast headers

On Mittwoch, 6. Dezember 2017 11:54:13 CET Willem de Bruijn wrote: > Perhaps it can even be behind a static key depending on whether any > devices are active, adjusted in batadv_hardif_(en|dis)able_interface. I don't like that because we don't need batman-adv loaded to simply forward (bridge)

Re: [B.A.T.M.A.N.] [RFC v2 2/6] batman-adv: Rename batman-adv.h to batadv_genl.h

On Mittwoch, 6. Dezember 2017 11:42:33 CET Willem de Bruijn wrote: > On Tue, Dec 5, 2017 at 9:35 AM, Sven Eckelmann > <sven.eckelm...@openmesh.com> wrote: > > This file contains the relevant information to let userspace communicate > > with batman-adv over generic netlink.

Re: [RFC v2 6/6] flow_dissector: Parse batman-adv unicast headers

On Dienstag, 5. Dezember 2017 09:19:45 CET Tom Herbert wrote: [...] > Switch statements with cases having many LOC is hard to read and > __skb_flow_dissect is aleady quite convoluted to begin with. > > I suggest putting this in a static function similar to how MPLS and > GRE are handled. Thanks

[RFC v2 0/6] flow_dissector: Provide basic batman-adv unicast handling

und to provide the correct definitions to flow_dissector.c Kind regards, Sven [1] https://patchwork.open-mesh.org/patch/17162/ [2] https://git.open-mesh.org/linux-merge.git/shortlog/refs/heads/batadv/net-next Sven Eckelmann (6): batman-adv: Change nl references to genl batman-adv: Rename batman-

[RFC v2 2/6] batman-adv: Rename batman-adv.h to batadv_genl.h

with the file which will contain the packet format definitions. Signed-off-by: Sven Eckelmann <sven.eckelm...@openmesh.com> --- MAINTAINERS| 2 +- include/uapi/linux/{batman_adv.h => batadv_genl.h} | 6 +++--- net/batman-adv/bat_algo.c

[RFC v2 3/6] batman-adv: Let packet.h include its headers directly

The headers used by packet.h should also be included by it directly. main.h is currently dealing with it in batman-adv, but this will no longer work when this header is moved to include/uapi/linux/. Signed-off-by: Sven Eckelmann <sven.eckelm...@openmesh.com> --- net/batman-adv/main.h

[RFC v2 4/6] batman-adv: Remove usage of BIT(x) in packet.h

The BIT(x) macro is no longer available for uapi headers because it is defined outside of it (linux/bitops.h). The use of it must therefore be avoided and replaced by an appropriate other representation. Signed-off-by: Sven Eckelmann <sven.eckelm...@openmesh.com> --- net/batman-adv/packet.

[RFC v2 5/6] batman-adv: Convert packet.h to uapi header

ETH_P_BATMAN ethernet packets. Signed-off-by: Sven Eckelmann <sven.eckelm...@openmesh.com> --- MAINTAINERS| 1 + net/batman-adv/packet.h => include/uapi/linux/batadv.h | 9 + net/batman-adv/bat_iv_ogm.c| 2 +- net/b

[RFC v2 6/6] flow_dissector: Parse batman-adv unicast headers

the same neighbor to different cores. Signed-off-by: Sven Eckelmann <sven.eckelm...@openmesh.com> --- net/core/flow_dissector.c | 30 ++ 1 file changed, 30 insertions(+) diff --git a/net/core/flow_dissector.c b/net/core/flow_dissector.c index 15ce30063765..784cc0

[RFC v2 1/6] batman-adv: Change nl references to genl

The batman-adv netlink functionality is actually not pure netlink but is using NETLINK_GENERIC and related API. The code should therefore also use this "genl" instead of "nl" to make this more clear. Signed-off-by: Sven Eckelmann <sven.eckelm...@openmesh.com> --- inclu

Re: [PATCH 3/3] batman-adv: Add missing kerneldoc for extack

On Samstag, 7. Oktober 2017 20:59:52 CEST David Miller wrote: > From: Sven Eckelmann <s...@narfation.org> > Date: Sat, 7 Oct 2017 14:21:22 +0200 > > > The parameter extack was added to batadv_softif_slave_add without adding > > the kernel-doc for it. This

[PATCH 3/3] batman-adv: Add missing kerneldoc for extack

The parameter extack was added to batadv_softif_slave_add without adding the kernel-doc for it. This caused kernel-doc warnings. Signed-off-by: Sven Eckelmann <s...@narfation.org> Cc: David Ahern <dsah...@gmail.com> --- net/batman-adv/soft-interface.c | 1 + 1 file changed, 1 insert

Re: [B.A.T.M.A.N.] [PATCH][V2] batman-adv: fix various spelling mistakes

On Montag, 26. Juni 2017 11:26:44 CEST Colin King wrote: > From: Colin Ian King > > Trivial fix to spelling mistakes in batadv_dbg debug messages and > also in a comment and ensure comment line is not wider than 80 > characters > > "ourselve" -> "ourselves" >

Re: [PATCH] batman-adv: Remove unnecessary length qualifier in %14pM

On Mittwoch, 14. Juni 2017 02:33:52 CEST Joe Perches wrote: > It's misleading and unnecessary. > > Signed-off-by: Joe Perches > --- > net/batman-adv/distributed-arp-table.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) The patch was applied and is currently queued

Re: [B.A.T.M.A.N.] Odd use of %14pM in net/batman-adv/distributed-arp-table.c

On Dienstag, 13. Juni 2017 14:51:41 CEST Joe Perches wrote: > An output mac address is 17 bytes [...] > but in net/batman-adv/distributed-arp-table.c [...] > %14pM is odd as this should not emit the last byte of the > mac address. So given the example above, it would output > 00:11:22:33:44 [...]

Re: [B.A.T.M.A.N.] [PATCH net] net: batman-adv: Fix possible memleaks when fail to register_netdevice

On Dienstag, 25. April 2017 20:03:20 CEST gfree.w...@foxmail.com wrote: > From: Gao Feng > > Because the func batadv_softif_init_late allocate some resources and > it would be invoked in register_netdevice. So we need to invoke the > func batadv_softif_free instead of

Re: [B.A.T.M.A.N.] [PATCH 0/2] batman-adv: Fine-tuning for three function implementations

On Samstag, 6. Mai 2017 18:12:46 CEST SF Markus Elfring wrote: > From: Markus Elfring > Date: Sat, 6 May 2017 18:03:45 +0200 > > Two update suggestions were taken into account > from static source code analysis. > > Markus Elfring (2): > Replace a seq_puts()

Re: [B.A.T.M.A.N.] [PATCH net] net: batman-adv: Fix possible memleaks when fail to register_netdevice

On Mittwoch, 26. April 2017 14:44:24 CEST Gao Feng wrote: [...] > I get it now, thanks. [...] > BTW, I think although the batadv_softif_create is legacy, we should fix it > when it still exists :) I didn't meant that we should not fix it. I just said that it looks to me like the fix should look

Re: [B.A.T.M.A.N.] [PATCH net] net: batman-adv: Fix possible memleaks when fail to register_netdevice

On Mittwoch, 26. April 2017 08:41:30 CEST Gao Feng wrote: > On Dienstag, 25. April 2017 20:03:20 CEST gfree.w...@foxmail.com wrote: > > From: Gao Feng > > > > Because the func batadv_softif_init_late allocate some resources and > > it would be invoked in register_netdevice. So

Re: [B.A.T.M.A.N.] [PATCH net] net: batman-adv: Fix possible memleaks when fail to register_netdevice

On Dienstag, 25. April 2017 20:03:20 CEST gfree.w...@foxmail.com wrote: > From: Gao Feng > > Because the func batadv_softif_init_late allocate some resources and > it would be invoked in register_netdevice. So we need to invoke the > func batadv_softif_free instead of

Re: [B.A.T.M.A.N.] [PATCH] batman-adv: Use net_device_stats from struct net_device

On Mittwoch, 5. April 2017 13:46:31 CEST Tobias Klauser wrote: > Instead of using a private copy of struct net_device_stats in struct > batadv_priv, use stats from struct net_device. > > Signed-off-by: Tobias Klauser > --- > net/batman-adv/distributed-arp-table.c | 9

Re: [B.A.T.M.A.N.] [PATCH] net: batman-adv: use new api ethtool_{get|set}_link_ksettings

On Samstag, 1. April 2017 08:40:54 CEST Sven Eckelmann wrote: [...] > Btw. the code you are modifying will most likely be dropped. Your patch will > get rejected because of this. But thanks for submitting the api conversion > patch (even when it will be rejected). The patch was n

Re: [B.A.T.M.A.N.] [PATCH] net: batman-adv: use new api ethtool_{get|set}_link_ksettings

On Freitag, 31. März 2017 22:33:34 CEST Philippe Reynes wrote: > > Do you know if anyone already prepared the get_link_ksettings support for > > kernels older than 4.6 for backports.git? > > Sorry, I don't know this repo. Do you have an url please ? > But I suppose that nobody works on such

Re: [B.A.T.M.A.N.] [PATCH] net: batman-adv: use new api ethtool_{get|set}_link_ksettings

On Donnerstag, 30. März 2017 23:01:27 CEST Philippe Reynes wrote: > The ethtool api {get|set}_settings is deprecated. > We move this driver to new api {get|set}_link_ksettings. > > I've only compiled this change. If someone may test it, > it would be very nice. > > Signed-off-by: Philippe Reynes

Re: [REGRESSION] mac80211: IBSS vif queue stopped when started after 11s vif

On Mittwoch, 29. März 2017 13:53:06 CEST Johannes Berg wrote: [...] > > Not sure whether removing it in ieee80211_propagate_queue_wake will > > have other odd side effects with software queuing. Maybe Michal > > Kazior can tell us if it is safe to remove it. > > No, it's the other way around. >

Re: [REGRESSION] mac80211: IBSS vif queue stopped when started after 11s vif

On Mittwoch, 29. März 2017 09:49:21 CEST Johannes Berg wrote: > > But I could be completely wrong about it. It would therefore be > > interesting for me to know who would be responsible to start the > > queues when ieee80211_do_open rejected it for IBSS. > > Well, once

[REGRESSION] mac80211: IBSS vif queue stopped when started after 11s vif

Hi, I had following "simple" setup with LEDE with a single ath9k phy and multiple vif: * encrypted AP * encrypted 802.11s meshpoint * encrypted IBSS Everything was started in the order by hostapd/wpa_supplicant (but immediately after each other). The problem which I've experienced was

Re: [B.A.T.M.A.N.] [PATCH] batman-adv: Omit unnecessary memset of netdev private data

On Freitag, 17. März 2017 12:08:59 CET Tobias Klauser wrote: > The memory for netdev_priv is allocated using kzalloc in alloc_netdev > (or alloc_netdev_mq respectively) so there is no need to set it to 0 > again. > > Signed-off-by: Tobias Klauser > --- >

[PATCH] ath9k: Access rchan::buf only with per_cpu helper

.@fit.fraunhofer.de> Signed-off-by: Sven Eckelmann <s...@narfation.org> --- drivers/net/wireless/ath/ath9k/common-spectral.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/ath/ath9k/common-spectral.c b/drivers/net/wireless/ath/ath9k/common-spectral.c

Re: [B.A.T.M.A.N.] [PATCH net-next 1/2] net: batman-adv: Treat NET_XMIT_CN as transmit successfully

On Montag, 21. November 2016 23:00:32 CET f...@ikuai8.com wrote: > From: Gao Feng > > The tc could return NET_XMIT_CN as one congestion notification, but > it does not mean the packet is lost. Other modules like ipvlan, > macvlan, and others treat NET_XMIT_CN as success

Re: [B.A.T.M.A.N.] [PATCH net 1/1] net: batman-adv: Treat NET_XMIT_CN as transmit successfully

On Montag, 21. November 2016 16:21:52 CET Feng Gao wrote: > Hi Sven, > > On Mon, Nov 21, 2016 at 4:16 PM, Sven Eckelmann <s...@narfation.org> wrote: > > On Montag, 21. November 2016 08:39:39 CET f...@ikuai8.com wrote: > >> From: Gao Feng <f...@ikuai8.com> >

Re: [B.A.T.M.A.N.] [PATCH net 1/1] net: batman-adv: Treat NET_XMIT_CN as transmit successfully

On Montag, 21. November 2016 08:39:39 CET f...@ikuai8.com wrote: > From: Gao Feng > > The tc could return NET_XMIT_CN as one congestion notification, but > it does not mean the packe is lost. Other modules like ipvlan, s/packe/packet/ > macvlan, and others treat NET_XMIT_CN as

Re: [PATCH 13/17] batman-adv: Consume skb in receive handlers

On Dienstag, 8. November 2016 09:43:01 CET Eric Dumazet wrote: [...] > Sure, but your patch 13/17 should address this right away. [...] Fair enough. I've asked Simon to resubmit the patches with the "consume_skb -> conditional kfree_skb/consume_skb" patch squashed into patch 13. Kind regards,

Re: [PATCH 13/17] batman-adv: Consume skb in receive handlers

On Dienstag, 8. November 2016 08:59:49 CET Eric Dumazet wrote: [...] > > +free_skb: > > consume_skb(skb); > > - return NET_RX_SUCCESS; > > + > > + return ret; > > } > > > Okay, but we do have kfree_skb() and consume_skb() and they should be > used appropriately. Yes, this patch is one

Re: [PATCH 03/17] batman-adv: Add network_coding and mcast sysfs files to README

On Samstag, 29. Oktober 2016 12:56:28 CEST Jiri Pirko wrote: [...] > >> I strongly believe it is a huge mistake to use sysfs for things like > >> this. This should be done via generic netlink api. > > > >This doesn't change the problem that it is already that way. This patch > >only adds the list

Re: [PATCH 03/17] batman-adv: Add network_coding and mcast sysfs files to README

On Samstag, 29. Oktober 2016 12:33:01 CEST Jiri Pirko wrote: [...] > >--- a/Documentation/networking/batman-adv.txt > >+++ b/Documentation/networking/batman-adv.txt > >@@ -71,10 +71,11 @@ All mesh wide settings can be found in batman's own > >interface > > folder: > > > > # ls

Re: [PATCH 17/17] batman-adv: Avoid precedence issues in macros

On Freitag, 28. Oktober 2016 18:56:24 CEST Joe Perches wrote: [...] > > But yes, looks to me like it is missing. Do you want to propose a patch or > > should I do? > > As you are working on this file, perhaps you should. Ok, I will submit a patch with you as Reported-by to the batman-adv mailing

Re: [PATCH 17/17] batman-adv: Avoid precedence issues in macros

On Freitag, 28. Oktober 2016 14:13:06 CEST Joe Perches wrote: > On Thu, 2016-10-27 at 21:01 +0200, Simon Wunderlich wrote: > > From: Sven Eckelmann <s...@narfation.org> > > > > It must be avoided that arguments to a macro are evaluated ungrouped (which > > enf

Re: [PATCH] batman-adv: Revert "use core MTU range checking in misc drivers"

On Samstag, 22. Oktober 2016 21:08:26 CEST Jarod Wilson wrote: [...] > You're going to > need more than just this revert though, since batman-adv calls > ether_setup, which will set min_mtu = 68, max_mtu = 1500, unless > batadv_hardif_min_mtu() always returns something 1500 or less. It does only

[PATCH] batman-adv: Revert "use core MTU range checking in misc drivers"

("net: use core MTU range checking in misc drivers") Signed-off-by: Sven Eckelmann <s...@narfation.org> --- Original patch + my comment: https://patchwork.ozlabs.org/patch/684722/ I just got informed about this patch when it was already applied in net-next. So I can only ask for

Re: [net-next,v2,7/9] net: use core MTU range checking in misc drivers

On Donnerstag, 20. Oktober 2016 13:55:22 CEST Jarod Wilson wrote: [...] > batman-adv: > - set max_mtu > - remove batadv_interface_change_mtu > - initialization is a little async, not 100% certain that max_mtu is set > in the optimal place, don't have hardware to test with batman-adv is creating

Re: [B.A.T.M.A.N.] [PATCH 1086/1285] Replace numeric parameter like 0444 with macro

On Dienstag, 2. August 2016 20:15:13 CEST Baole Ni wrote: [...] > diff --git a/net/batman-adv/main.c b/net/batman-adv/main.c > index 5f2974b..25759b9 100644 > --- a/net/batman-adv/main.c > +++ b/net/batman-adv/main.c > @@ -1313,7 +1313,7 @@ static struct kparam_string batadv_param_string_ra = { >

Re: [B.A.T.M.A.N.] [PATCH 00/11] pull request for net-next: batman-adv 2016-07-04

On Monday 04 July 2016 23:37:25 David Miller wrote: [...] > I have no idea why you guys were using debugfs for anything that > actually matters like configuration. :-/ It wasn't used for configuration. rtnl/sysfs is used for configuration. Kind regards, Sven signature.asc Description:

[PATCH net 3/5] batman-adv: Fix double-put of vlan object

Fixes: a33d970d0b54 ("batman-adv: Fix reference counting of vlan object for tt_local_entry") Signed-off-by: Ben Hutchings <b...@decadent.org.uk> Signed-off-by: Marek Lindner <mareklind...@neomailbox.ch> Signed-off-by: Sven Eckelmann <s...@narfation.org> --- net/batma

[PATCH net 4/5] batman-adv: Fix ICMP RR ethernet access after skb_linearize

. Fixes: da6b8c20a5b8 ("batman-adv: generalize batman-adv icmp packet handling") Signed-off-by: Sven Eckelmann <s...@narfation.org> Signed-off-by: Marek Lindner <mareklind...@neomailbox.ch> --- net/batman-adv/routing.c | 1 + 1 file changed, 1 insertion(+) diff --git a/net/

[PATCH net 5/5] batman-adv: Clean up untagged vlan when destroying via rtnl-link

The untagged vlan object is only destroyed when the interface is removed via the legacy sysfs interface. But it also has to be destroyed when the standard rtnl-link interface is used. Fixes: 5d2c05b21337 ("batman-adv: add per VLAN interface attribute framework") Signed-off-by: Sven Ec

[PATCH net 2/5] batman-adv: Fix use-after-free/double-free of tt_req_node

05b8d4c7 ("batman-adv: improved client announcement mechanism") Signed-off-by: Sven Eckelmann <s...@narfation.org> Tested-by: Martin Weinelt <mar...@darmstadt.freifunk.net> Tested-by: Amadeus Alfa <amad...@chemnitz.freifunk.net> Signed-off-by: Marek Li

[PATCH net 1/5] batman-adv: replace WARN with rate limited output on non-existing VLAN

placed by a rate limited output. Fixes: 354136bcc3c4 ("batman-adv: fix kernel crash due to missing NULL checks") Signed-off-by: Simon Wunderlich <s...@simonwunderlich.de> Signed-off-by: Marek Lindner <mareklind...@neomailbox.ch> Signed-off-by: Sven Eckelmann <s...@narfation.org&g

[PATCH net 0/5] batman-adv: Fixes for Linux 4.7

evelopment tree for v4.8 but I will leave them to Antonio because these are cleanups and features and therefore for net- next. Ben Hutchings (1): batman-adv: Fix double-put of vlan object Simon Wunderlich (1): batman-adv: replace WARN with rate limited output on non-existing VLAN Sven Ec

Re: [PATCH next] sched: remove NET_XMIT_POLICED

submitted a fix for it and Antonio should just know that it is related to this one. But to your patch: Reviewed-by: Sven Eckelmann <s...@narfation.org> Kind regards, Sven signature.asc Description: This is a digitally signed message part.

Re: [B.A.T.M.A.N.] pull request: batman-adv 20160518

On Wednesday 18 May 2016 13:04:44 Antonio Quartulli wrote: > I also have a question: I have another bugfix that should only be > applied to 4.6 and not to 4.7/net-next - should I directly send it > to sta...@vger.kernel.org ? Allow me to give some background info: The bug was (accidentally)

Re: [PATCH 4/5] batman-adv: Reduce refcnt of removed router when updating route

On Tuesday 26 April 2016 17:42:54 Sergei Shtylyov wrote: > > _batadv_update_route rcu_derefences orig_ifinfo->router outside of a > > spinlock protected region to print some information messages to the debug > > log. But this pointer is not checked again when the new pointer is assigned > > in the

Re: [B.A.T.M.A.N.] ibss.c backtrace when batman-adv adds wireless interface

On Wednesday 03 February 2016 16:41:30 Johannes Berg wrote: > On Wed, 2016-02-03 at 10:26 -0500, Josh Boyer wrote: > > On Wed, Feb 3, 2016 at 10:24 AM, Josh Boyer > g> wrote: > > > Hi All, > > > > > > We've had a user report the backtrace below when loading batman-adv

Re: [B.A.T.M.A.N.] ibss.c backtrace when batman-adv adds wireless interface

On Wednesday 03 February 2016 18:09:40 Sven Eckelmann wrote: > > AFAICT this should be a driver (or perhaps mac80211) issue, but I don't > > see any information about the driver used. > > It doesn't really look like it is batman-adv specific. batman-adv also doesn't &

Re: [B.A.T.M.A.N.] ibss.c backtrace when batman-adv adds wireless interface

On Wednesday 03 February 2016 10:24:43 Josh Boyer wrote: > Hi All, > > We've had a user report the backtrace below when loading batman-adv on > his machine. It looks like the cfg80211 layer is complaining about a > null bss returned, but I cannot tell if the rtlwifi driver or > batman-adv is in

[PATCH net] batman-adv: Fix memory leak on tt add with invalid vlan

due to missing NULL checks) Signed-off-by: Sven Eckelmann s...@narfation.org --- Hi, sorry for sending the patch directly to you. But Marek told me that neither he or Antonio have currently time to prepare/send a patch for this problem. Instead he told me that it would be ok to send the patch

Re: [PATCH 1/2] batman-adv: Avoid u32 overflow during gateway select

On Sunday 21 June 2015 09:37:13 David Miller wrote: From: Antonio Quartulli anto...@meshcoding.com Date: Tue, 16 Jun 2015 21:06:23 +0200 @@ -133,7 +133,7 @@ batadv_gw_get_best_gw_node(struct batadv_priv *bat_priv) struct batadv_neigh_node *router; struct batadv_neigh_ifinfo