Re: [RFC] ipvs: Cleanup sync daemon code

2008-02-10 Thread Sven Wegener
On Sat, 9 Feb 2008, Christoph Hellwig wrote: On Sun, Feb 10, 2008 at 12:38:11AM +0100, Sven Wegener wrote: struct ip_vs_sync_thread_data { - struct completion *startup; + struct completion *startup; /* set to NULL once completed */ This is not needed anmore. kthread_run

[RFC] ipvs: Cleanup sync daemon code

2008-02-09 Thread Sven Wegener
Hi all, I'd like to get your feedback on this: - Use kthread_run instead of doing a double-fork via kernel_thread() - Return proper error codes to user-space on failures Currently ipvsadm --start-daemon with an invalid --mcast-interface will silently suceed. With these changes we get an

[PATCH] ipvs: Make the synchronization interval controllable

2008-02-06 Thread Sven Wegener
controllable by a sysctl variable so that users can tune it. Signed-off-by: Sven Wegener [EMAIL PROTECTED] --- Documentation/networking/ipvs-sysctl.txt |9 + net/ipv4/ipvs/ip_vs_ctl.c|9 - net/ipv4/ipvs/ip_vs_sync.c |6 -- 3 files changed

Re: [PATCH] ipvs: Make the synchronization interval controllable

2008-02-06 Thread Sven Wegener
On Wed, 6 Feb 2008, David Rientjes wrote: On Wed, 6 Feb 2008, Sven Wegener wrote: diff --git a/net/ipv4/ipvs/ip_vs_sync.c b/net/ipv4/ipvs/ip_vs_sync.c index 948378d..9b57ad3 100644 --- a/net/ipv4/ipvs/ip_vs_sync.c +++ b/net/ipv4/ipvs/ip_vs_sync.c @@ -143,6 +143,8 @@ char

[PATCH] ipvs: Make the synchronization interval controllable

2008-02-06 Thread Sven Wegener
controllable by a sysctl variable so that users can tune it. We enforce a lower limit of 0 and an upper limit of 2000 ms on the interval. A too large interval can make the synchronization buffer consume too much memory and will also delay the exit of the kernel threads. Signed-off-by: Sven Wegener

[PATCH] ipvs: Make wrr no available servers error message rate-limited

2008-02-05 Thread Sven Wegener
No available servers is more an error message than something informational. It should also be rate-limited, else we're going to flood our logs on a busy director, if all real servers are out of order with a weight of zero. Signed-off-by: Sven Wegener [EMAIL PROTECTED] --- Actually, do we need