On 06/03/15 at 12:58pm, Tom Herbert wrote:
> diff --git a/drivers/net/ipvlan/ipvlan_main.c
> b/drivers/net/ipvlan/ipvlan_main.c
> index 1acc283..e029fad 100644
> --- a/drivers/net/ipvlan/ipvlan_main.c
> +++ b/drivers/net/ipvlan/ipvlan_main.c
> @@ -9,6 +9,10 @@
>
> #include "ipvlan.h"
>
> +boo
On 06/03/15 at 12:58pm, Tom Herbert wrote:
> +static struct genl_family ila_nl_family = {
> + .id = GENL_ID_GENERATE,
> + .hdrsize= 0,
> + .name = ILA_GENL_NAME,
> + .version= ILA_GENL_VERSION,
> + .maxattr= ILA_ATTR_MAX,
> + .ne
On 06/03/15 at 05:29pm, Jiri Benc wrote:
> On Mon, 1 Jun 2015 16:27:32 +0200, Thomas Graf wrote:
> > --- a/net/openvswitch/flow.h
> > +++ b/net/openvswitch/flow.h
> > @@ -45,6 +45,11 @@ struct sk_buff;
> > #define TUN_METADATA_OPTS(flow_key, opt_len) \
> >
On 06/02/15 at 06:23pm, Eric W. Biederman wrote:
> Thomas I may have misunderstood what you are trying to do.
>
> Is what you were aiming for roughly the existing RTA_FLOW so you can
> transmit packets out one network device and have enough information to
> know which of a set of tunnels of a give
On 06/02/15 at 02:28pm, Robert Shearman wrote:
> Nesting attributes inside the RTA_ENCAP blob should be supported by the
> patch series today. Something like this:
Sure. I'm not seeing such a construct for the MPLS case yet.
I'm happy to rebase my patches on top of your nexthop implementation.
It
On 06/02/15 at 01:26pm, Eric W. Biederman wrote:
> What we really want here is xfrm-lite. By lite I mean the tunnel
> selection criteria is simple enough that it fits into the normal
> routing table instead of having to do weird flow based magic that
> is rarely needed.
>
> I believe what we want
On 06/01/15 at 05:46pm, Robert Shearman wrote:
> In order to be able to function as a Label Edge Router in an MPLS
> network, it is necessary to be able to take IP packets and impose an
> MPLS encap and forward them out. The traditional approach of setting
> up an interface for each "tunnel" endpoi
On 06/01/15 at 05:51pm, Robert Shearman wrote:
> On 01/06/15 15:27, Thomas Graf wrote:
> >Introduces a new Netlink attribute RTA_TUNNEL which allows routes
> >to set tunnel transmit metadata and specify the tunnel endpoint or
> >tunnel id on a per route basis. The route m
With the removal of the special treating of OVS VXLAN vports, the
indirect call to vxlan_rcv() can be avoided and the VNI member
in vxlan_metadata can be removed.
Signed-off-by: Thomas Graf
---
drivers/net/vxlan.c | 225 +---
include/net/vxlan.h
From: Pravin Shelar
Removes all of the OVS specific GRE code and makes OVS use a
GRE net_device .
Signed-off-by: Pravin B Shelar
---
net/core/dev.c | 5 +-
net/ipv4/ip_gre.c | 161 -
net/openvswitch/Makefile | 1 -
net/openvswitch/vpor
This add the ability to select a routing table based on the tunnel
id which allows to maintain separate routing tables for each virtual
tunnel network.
ip rule add from all tunnel-id 100 lookup 100
ip rule add from all tunnel-id 200 lookup 200
Signed-off-by: Thomas Graf
---
include/net
-off-by: Thomas Graf
---
include/net/ip_fib.h | 3 +++
include/net/ip_tunnels.h | 1 -
include/net/route.h| 10
include/uapi/linux/rtnetlink.h | 16
net/ipv4/fib_frontend.c| 57 ++
net/ipv4
.
Signed-off-by: Thomas Graf
Signed-off-by: Pravin B Shelar
---
net/openvswitch/actions.c | 8 +-
net/openvswitch/datapath.c | 8 +++---
net/openvswitch/flow.h | 5
net/openvswitch/flow_netlink.c | 59 +-
net/openvswitch
tunnel
endpoints and virtual networks using a single tunnel net_device.
TODO:
- Geneve support
- IPv6 support
- Benchmarks
Pravin Shelar (1):
openvswitch: Use regular GRE net_device instead of vport
Thomas Graf (13):
ip_tunnel: Make ovs_tunnel_info and ovs_key_ipv4_tunnel generic
ip_tunnel
This factors out the device configuration out of the RTNL newlink
API which allows for in-kernel creation of VXLAN net_devices.
Signed-off-by: Thomas Graf
---
drivers/net/vxlan.c | 332
include/net/vxlan.h | 59 ++
2 files changed
(), vxlan_xmit_skb()
since they are no longer needed.
Signed-off-by: Thomas Graf
Signed-off-by: Pravin B Shelar
---
drivers/net/vxlan.c| 23 +--
include/net/vxlan.h| 14 +-
net/openvswitch/Kconfig| 12 --
net/openvswitch/Makefile | 1 -
net/openvswitch/flow_netlink.c
This allows to get rid of the get_name() vport ops later on.
Signed-off-by: Thomas Graf
---
net/openvswitch/datapath.c | 4 ++--
net/openvswitch/vport-internal_dev.c | 1 -
net/openvswitch/vport-netdev.c | 6 --
net/openvswitch/vport-netdev.h | 1 -
net/openvswitch
This is the first step in representing all OVS vports as regular
struct net_devices. Move the net_device pointer into the vport
structure itself to get rid of struct vport_netdev.
Signed-off-by: Thomas Graf
Signed-off-by: Pravin B Shelar
---
net/openvswitch/datapath.c | 7 +--
net
encapsulation for a large number of tunnel
endpoints and tunnel ids through a single net_device which improves
the scalability of current VXLAN tunnels.
Signed-off-by: Thomas Graf
Signed-off-by: Pravin B Shelar
---
drivers/net/vxlan.c | 147 ---
include
Since ARP performs its own route lookup call, eventually
returned tunnel metadata must be attached manually.
Signed-off-by: Thomas Graf
---
net/ipv4/arp.c | 8
1 file changed, 8 insertions(+)
diff --git a/net/ipv4/arp.c b/net/ipv4/arp.c
index 933a928..6cf0502 100644
--- a/net/ipv4
extend/modify
these structures without affecting user ABI.
Signed-off-by: Thomas Graf
---
include/net/ip_tunnels.h | 63 +
include/uapi/linux/openvswitch.h | 2 +-
net/openvswitch/actions.c| 2 +-
net/openvswitch/datapath.h | 5 +--
net
Add a new flowi_tunnel structure which is a subset of ip_tunnel_key
to allow routes to match on tunnel metadata. For now, the tunnel id
is added to flowi_tunnel which allows for routes to be bound to
specific virtual tunnels.
Signed-off-by: Thomas Graf
---
include/net/flow.h | 7
, it will only
have to allocate the metadata once and can simply increment the
reference counter for each packet that uses that instruction set.
Signed-off-by: Thomas Graf
---
include/linux/skbuff.h| 1 +
include/net/ip_tunnels.h | 45 +
net/core
On 05/15/15 at 08:06am, Herbert Xu wrote:
> On Thu, May 14, 2015 at 07:37:56AM -0700, Eric Dumazet wrote:
> >
> > This solves the corruption thanks Herbert.
>
> Great.
>
> > But wasn't rhashtable meant to be faster ? ;)
>
> Is it, that's news to me :)
Eric, can you share the scripts you used to
On 05/06/15 at 11:58am, Nicolas Dichtel wrote:
> More accurately, listen all netns that have a nsid assigned into the netns
> where the netlink socket is opened.
> For this purpose, a netlink socket option is added:
> NETLINK_LISTEN_ALL_NSID. When this option is set on a netlink socket, this
> sock
On 04/24/15 at 04:12pm, Herbert Xu wrote:
> On Fri, Apr 24, 2015 at 09:06:08AM +0100, Thomas Graf wrote:
> >
> > Which users are you talking about? Both Netlink and TIPC still
> > have an upper limit. nft sets are controlled by privileged users.
>
> There is no
On 04/24/15 at 08:57am, Herbert Xu wrote:
> It seems that I lost track somewhere along the line. I meant
> to add an explicit limit on the overall number of entries since
> that was what users like netlink expected but never got around
> to doing it. Instead it seems that we're currently relying
interval in this situation or just leave this up to the user
to setup a timer himself.
> This fixes the "lost insertion" issue and consequently allows my
> code to display its error (and verify my fix for it.)
>
> Signed-off-by: Johannes Berg
Acked-by: Thomas Graf
--
To unsub
On 04/22/15 at 04:38pm, Cong Wang wrote:
> On Wed, Apr 22, 2015 at 3:27 PM, Alexei Starovoitov wrote:
> > On 4/21/15 10:05 PM, Cong Wang wrote:
> >>
> >> On Tue, Apr 21, 2015 at 12:27 PM, Alexei Starovoitov
> >> wrote:
> >>>
> >>> introduce tc_classify_act() and qdisc_drop_bypass() helper functio
On 04/22/15 at 04:29pm, Cong Wang wrote:
> On Wed, Apr 22, 2015 at 3:04 PM, Alexei Starovoitov wrote:
> > On 4/21/15 9:59 PM, Cong Wang wrote:
> >>
> >> On Tue, Apr 21, 2015 at 12:27 PM, Alexei Starovoitov
> >> wrote:
> >>>
> >>> ingress qdisc should return NET_XMIT_* values just like all other q
rehashes
scheduled which lead to thousands of spinlocks to be taken
sequentially.
Instead, only allow either a series of resizes or a single rehash.
Drop any further rehashes and return -EBUSY.
Fixes: ccd57b1bd324 ("rhashtable: Add immediate rehash during insertion")
Signed-off-by: Thomas G
more likely to succeed. The insertion itself
will still fail to indicate pressure.
This fixes a bug where the table would never continue growing once the
utilization is above 100%.
Fixes: ccd57b1bd324 ("rhashtable: Add immediate rehash during insertion")
Signed-off-by: Thomas Graf
---
l
Some rhashtable rehashing bugs found while testing with the
next rhashtable self-test queued up for the next devel cycle:
https://github.com/tgraf/net-next/commits/rht
v2:
- Moved schedule_work() call into rhashtable_insert_rehash()
Thomas Graf (2):
rhashtable: Schedule async resize when
On 04/21/15 at 10:10pm, David Miller wrote:
> From: Herbert Xu
> Date: Wed, 22 Apr 2015 08:36:34 +0800
>
> > On Tue, Apr 21, 2015 at 02:55:34PM +0200, Thomas Graf wrote:
> >> When rhashtable_insert_rehash() fails with ENOMEM, this indicates that
> >> we can'
Hi,
Tom and myself will be running another iteration of a networking
focused microconference [0] at LPC, Aug 19-21 in Seattle. Given that
a bunch of us will be in Seattle anyway we might as well have a
general networking session and spend some time together.
This year's focus is on: IPv6, Network
more likely to succeed. The insertion itself
will still fail to indicate pressure.
This fixes a bug where the table would never continue growing once the
utilization is above 100%.
Fixes: ccd57b1bd324 ("rhashtable: Add immediate rehash during insertion")
Signed-off-by: Thomas Graf
---
rehashes
scheduled which lead to thousands of spinlocks to be taken
sequentially.
Instead, only allow either a series of resizes or a single rehash.
Drop any further rehashes and return -EBUSY.
Fixes: ccd57b1bd324 ("rhashtable: Add immediate rehash during insertion")
Signed-off-by: T
Some rhashtable rehashing bugs found while testing with the
next rhashtable self-test queued up for the next devel cycle:
https://github.com/tgraf/net-next/commits/rht
Thomas Graf (2):
rhashtable: Schedule async resize when sync realloc fails
rhashtable: Do not schedule more than one rehash
ub_packet don't matter, the
> netfilter mark must be preserved.
>
> This patch rearranges skb_scrub_packet to preserve the mark field.
>
> Fixes: ea23192e8e57 ("tunnels: harmonize cleanup done on skb on rx path")
> Signed-off-by: Herbert Xu
Acked-by: Thomas G
On 04/16/15 at 04:12pm, Herbert Xu wrote:
> On Thu, Apr 16, 2015 at 05:02:15PM +1000, James Morris wrote:
> >
> > They don't support namespaces, and maintaining the label is critical for
> > SELinux, at least, which mediates security for the system as a whole.
>
> Thanks for the confirmation Jam
* Jeff Garzik <[EMAIL PROTECTED]> 2008-02-25 12:30
> However, I would think it inconsistent to only do SSET/GSET. If others
> are OK with this patch, are you open to implementing the full set of
> ethtool operations?
Of course, I would also provide a documented userspace api within libnl.
--
To
Hello,
Before I continue to finish this work I'd like to get a few comments
on my implementation attempt.
The following patch implements the ETHTOOL_SSET and ETHTOOL_GSET
command via netlink. The individual commands are implemented as
separate functions and hooked into a table holding a validate,
ned-off-by: Thomas Graf <[EMAIL PROTECTED]>
Index: net-2.6.26/net/core/rtnetlink.c
===
--- net-2.6.26.orig/net/core/rtnetlink.c2008-02-22 01:50:53.0
+0100
+++ net-2.6.26/net/core/rtnetlink.c 2008-02
IFLA_LINK is no longer a write-only attribute on the kernel
side and must thus be validated. Same goes for the newly
introduced IFLA_LINKINFO.
Fixes undefined behaviour if either of the attributes are
not well formed.
Signed-off-by: Thomas Graf <[EMAIL PROTECTED]>
Index: net-2.6.26/ne
* Mark Seger <[EMAIL PROTECTED]> 2007-12-18 08:37
> Anyhow, I just wanted to let people know that ALL tools that monitor
> once a second on older counters will get the wrong numbers and tools
> that correct for the wrong number by using fractional intervals (and I
> suspect mine is the only one
* Patrick McHardy <[EMAIL PROTECTED]> 2007-12-18 00:51
> Chris Friesen wrote:
> >Patrick McHardy wrote:
> >
> >> From a kernel perspective there are only complete dumps, the
> >>filtering is done by iproute. So the fact that it shows them
> >>when querying specifically implies there is a bug in the
* Joerg Pommnitz <[EMAIL PROTECTED]> 2007-12-11 06:52
> I think the leak comes from addr_msg_parser. The newly created address object
> gets added to the cache with nl_cache_add wich takes a reference, so the
> reference in addr_msg_parser should be dropped, e.g. the following patch
> might be c
RFC4303 introduces dummy packets with a nexthdr value of 59
to implement traffic confidentiality. Such packets need to
be dropped silently and the payload may not be attempted to
be parsed as it consists of random chunk.
Signed-off-by: Thomas Graf <[EMAIL PROTECTED]>
Index: net-2.6.25/ne
RFC4303 introduces dummy packets with a nexthdr value of 59
to implement traffic confidentiality. Such packets need to
be dropped silently and the payload may not be attempted to
be parsed as it consists of random chunk.
Signed-off-by: Thomas Graf <[EMAIL PROTECTED]>
Index: net-2.6.25/ne
* Dan Williams <[EMAIL PROTECTED]> 2007-10-23 10:10
> Should I make NM disable ACKs for now until it gets fixed?
The reason libnl enables ACKs by default is to give the
application using it clear synchronisation points. For
change requests that means the interface function won't
return until the c
* Denis V. Lunev <[EMAIL PROTECTED]> 2007-10-23 18:40
> Revert to original netlink behavior. Do not reply with ACK if the
> netlink dump has bees successfully started.
>
> libnl has been broken by the cd40b7d3983c708aabe3d3008ec64ffce56d33b0
> The following command reproduce the problem:
>/nl-
* Denis V. Lunev <[EMAIL PROTECTED]> 2007-10-23 17:09
> I have reproduced the problem with one-line test.
> ./nl-route-get 192.168.1.1
> The problem is with this message:
>
> -- Debug: Sent Message:
> -- BEGIN NETLINK MESSAGE
> ---
> [HEADER
rk Manager and all
> > libraries related + provide us an output of strace with full buffers
> > send/received from netlink. Something like
> > strace -v -x -s 32768
>
> NM uses netlink in two places; libnl (from Thomas Graf) and some custom
> code for listening for
* Joe Perches <[EMAIL PROTECTED]> 2007-09-19 23:53
> In the same vein as print_mac, the implementations
> introduce declaration macros:
> DECLARE_IP_BUF(var)
> DECLARE_IPV6_BUF(var)
> and functions:
> print_ip
> print_ipv6
> print_ipv6_nofmt
>
> IPV4 Use:
>
> D
* Joe Perches <[EMAIL PROTECTED]> 2007-09-19 23:53
> This removes the uses of NIPQUAD and HIPQUAD in
> drivers/net and net
>
> IPV4 Use:
>
> DECLARE_IP_BUF(ipbuf);
> __be32 addr;
> print_ip(ipbuf, addr)
>
> Signed-off-by: Joe Perches <[EMAIL PROTECTED]>
>
> please pull from:
* Milan Kocian <[EMAIL PROTECTED]> 2007-09-12 16:50
> However I still think that this notitfication is redundant. I tried to look
> at XORP, bird, USAGI , quagga and to see RTM_DELLINK handling. And imho
> nobody depends on RTM_DELLINK message from ipv6.
Send a patch to remove and we'll see if any
This change allows the generic attribute interface to be used within
the netfilter subsystem where this flag was initially introduced.
The byte-order flag is yet unused, it's intended use is to
allow automatic byte order convertions for all atomic types.
Signed-off-by: Thomas Graf &l
* Milan Kocian <[EMAIL PROTECTED]> 2007-09-06 23:05
> I agree but ipv6 sends on device change (NETDEV_DOWN) RTM_DELLINK message.
> BTW when ipv6 send LINK message on NETDEV_UNREGISTER event, why doesn't
> send message on NETDEV_REGISTER event? No symmetry ?
You should be seeing two RTM_DELLINK up
* Stephen Hemminger <[EMAIL PROTECTED]> 2007-09-06 16:10
> Bug: http://bugzilla.kernel.org/show_bug.cgi?id=8876
>
> Not all ips are shown by "ip addr show" command when IPs number assigned to an
> interface is more than 60-80 (in fact it depends on broadcast/label etc
> presence on each address).
* Milan Kocian <[EMAIL PROTECTED]> 2007-08-29 23:51
> Because RTM_NEWLINK is used to notify about device status change
> (as I see in net/core/rtnetlink.c) and RTM_DELLINK to inform about
> NETDEV_UNREGISTER. Why should it be else in ipv6 subsystem ? And
> userspace programs (quagga) suppose it. No
* Herbert Xu <[EMAIL PROTECTED]> 2007-09-04 07:05
> Thomas Graf <[EMAIL PROTECTED]> wrote:
> >
> > I've been trying to reproduce this, what happens on my system
> > is that when the ISAKMP SA lifetime is exceeded the rekeying
> > fails and my c
* David Miller <[EMAIL PROTECTED]> 2007-08-30 22:39
>
> Every so often some piece of userland dies, and often it's
> bad enough that my desktop session logs out.
>
> I've been trying to find some clues and it seems to happen
> about as often as openswan rekeys my VPN, so one suspect
> area is the
Signed-off-by: Thomas Graf <[EMAIL PROTECTED]>
Index: net-2.6.24/drivers/net/82596.c
===
--- net-2.6.24.orig/drivers/net/82596.c 2007-08-27 14:43:16.0 +0200
+++ net-2.6.24/drivers/net/82596.c 2007-08-27
Fixes ancient ATM debug code to at least compile again.
Signed-off-by: Thomas Graf <[EMAIL PROTECTED]>
Index: net-2.6.24/net/atm/signaling.c
===
--- net-2.6.24.orig/net/atm/signaling.c 2007-08-27 09:53:40.0 +0200
+
Signed-off-by: Thomas Graf <[EMAIL PROTECTED]>
Index: net-2.6.24/net/xfrm/xfrm_policy.c
===
--- net-2.6.24.orig/net/xfrm/xfrm_policy.c 2007-08-24 13:11:17.0
+0200
+++ net-2.6.24/net/xfrm/xfrm_policy.c 2007-08
* Masahide NAKAMURA <[EMAIL PROTECTED]> 2007-08-24 19:05
> This is minor fix about sizeof argument using with kmemdup().
Thanks for catching this!
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.k
* Paul Moore <[EMAIL PROTECTED]> 2007-08-22 16:31
> We're currently talking about several different ideas to solve the problem,
> including leveraging the sk_buff.secmark field, and one of the ideas was to
> add an additional field to the sk_buff structure. Knowing how well that idea
> would go
Moves all of the SUB_POLICY ifdefs related to the attribute size
calculation into a function.
Signed-off-by: Thomas Graf <[EMAIL PROTECTED]>
Index: net-2.6.24/net/xfrm/xfrm_user.c
===
--- net-2.6.24.orig/net/xfrm/xfrm_
This simplifies successful return codes from >0 to 0.
Signed-off-by: Thomas Graf <[EMAIL PROTECTED]>
Index: net-2.6.24/net/xfrm/xfrm_user.c
===
--- net-2.6.24.orig/net/xfrm/xfrm_user.c2007-08-21 16:13:57.000
Signed-off-by: Thomas Graf <[EMAIL PROTECTED]>
Index: net-2.6.24/net/xfrm/xfrm_user.c
===
--- net-2.6.24.orig/net/xfrm/xfrm_user.c2007-08-21 16:12:20.0
+0200
+++ net-2.6.24/net/xfrm/xfrm_user.c 2007-08-21
Signed-off-by: Thomas Graf <[EMAIL PROTECTED]>
Index: net-2.6.24/net/xfrm/xfrm_user.c
===
--- net-2.6.24.orig/net/xfrm/xfrm_user.c2007-08-21 17:36:59.0
+0200
+++ net-2.6.24/net/xfrm/xfrm_user.c 2007-08-21
Signed-off-by: Thomas Graf <[EMAIL PROTECTED]>
Index: net-2.6.24/net/xfrm/xfrm_user.c
===
--- net-2.6.24.orig/net/xfrm/xfrm_user.c2007-08-21 17:34:29.0
+0200
+++ net-2.6.24/net/xfrm/xfrm_user.c 2007-08-21
Also makes use of copy_sec_ctx() in another place and removes
duplicated code.
Signed-off-by: Thomas Graf <[EMAIL PROTECTED]>
Index: net-2.6.24/net/xfrm/xfrm_user.c
===
--- net-2.6.24.orig/net/xfrm/xfrm_user.c2007-08
nlmsg_parse() puts attributes at array[type] so the indexing
method can be simpilfied by removing the obscuring "- 1".
Signed-off-by: Thomas Graf <[EMAIL PROTECTED]>
Index: net-2.6.24/net/xfrm/xfrm_user.c
===
--- net
-by: Thomas Graf <[EMAIL PROTECTED]>
Index: net-2.6.24/net/xfrm/xfrm_user.c
===
--- net-2.6.24.orig/net/xfrm/xfrm_user.c2007-08-21 17:31:04.0
+0200
+++ net-2.6.24/net/xfrm/xfrm_user.c 2007-08-21 17:31:56.000
Signed-off-by: Thomas Graf <[EMAIL PROTECTED]>
Index: net-2.6.24/net/xfrm/xfrm_user.c
===
--- net-2.6.24.orig/net/xfrm/xfrm_user.c2007-08-21 17:35:13.0
+0200
+++ net-2.6.24/net/xfrm/xfrm_user.c 2007-08-21
Adds alg_len() to calculate the properly padded length of an
algorithm attribute to simplify the code.
Signed-off-by: Thomas Graf <[EMAIL PROTECTED]>
Index: net-2.6.24/net/xfrm/xfrm_user.c
===
--- net-2.6.24.orig/ne
Increases readability a lot.
Signed-off-by: Thomas Graf <[EMAIL PROTECTED]>
Index: net-2.6.24/net/xfrm/xfrm_user.c
===
--- net-2.6.24.orig/net/xfrm/xfrm_user.c2007-08-21 17:34:10.0
+0200
+++ net-2.6.24/ne
Signed-off-by: Thomas Graf <[EMAIL PROTECTED]>
Index: net-2.6.24/net/xfrm/xfrm_user.c
===
--- net-2.6.24.orig/net/xfrm/xfrm_user.c2007-08-21 16:10:34.0
+0200
+++ net-2.6.24/net/xfrm/xfrm_user.c 2007-08-21
These functions are only used once and are a lot easier to understand if
inlined directly into the function.
Signed-off-by: Thomas Graf <[EMAIL PROTECTED]>
Index: net-2.6.24/net/xfrm/xfrm_user.c
===
--- net-2.6.24.orig/ne
Uses nlmsg_parse() to parse the attributes. This actually changes
behaviour as unknown attributes (type > MAXTYPE) no longer cause
an error. Instead unknown attributes will be ignored henceforth
to keep older kernels compatible with more recent userspace tools.
Signed-off-by: Thomas Graf <
Moves all complex message size calculation into own inlined helper
functions and makes use of the type-safe netlink interface.
Using nlmsg_new() simplifies the calculation itself as it takes care
of the netlink header length by itself.
Signed-off-by: Thomas Graf <[EMAIL PROTECTED]>
Inde
This patchset converts the xfrm netlink bits over to the type
safe netlink interface and does some cleanups.
xfrm_user.c | 1041
1 file changed, 433 insertions(+), 608 deletions(-)
-
To unsubscribe from this list: send the line "unsubs
Signed-off-by: Thomas Graf <[EMAIL PROTECTED]>
Index: net-2.6.24/net/xfrm/xfrm_user.c
===
--- net-2.6.24.orig/net/xfrm/xfrm_user.c2007-08-20 17:09:48.0
+0200
+++ net-2.6.24/net/xfrm/xfrm_user.c 2007-08-21
* Andrew Morton <[EMAIL PROTECTED]> 2007-08-21 22:54
> Which used to be a BUG. It later oopsed via a null-pointer deref in
> net_rx_action(), which is a much preferable result.
I fixed this already
Index: net-2.6.24/include/linux/netpoll.h
The per cpu backlog napi struct can't do netpoll and has the
dev member set to NULL. Fixes an oops on boot when netpoll is
enabled.
Signed-off-by: Thomas Graf <[EMAIL PROTECTED]>
Index: net-2.6.24/include/linux/netpoll.h
* Varun Chandramohan <[EMAIL PROTECTED]> 2007-08-21 16:52
> I know its a bit confusing but let me explain the reason. In my first
> version patch i used fn_hash_insert() (place where alias is created)as
> place to insert my current time in the age field.
> This will eventually call fib_dump_info()
* Varun Chandramohan <[EMAIL PROTECTED]> 2007-08-20 13:46
> The age field is filled with the current time at the time of creation of the
> route. When the routes are dumped
> then the age value stored in the route structure is subtracted from the
> current time value and the difference is the age
* Felix Marti <[EMAIL PROTECTED]> 2007-08-20 12:02
> These graphic adapters provide a wealth of features that you can take
> advantage of to bring these amazing graphics to life. General purpose
> CPUs cannot keep up. Chelsio offload devices do the same thing in the
> realm of networking. - Will th
* Richard MUSIL <[EMAIL PROTECTED]> 2007-07-24 13:09
> Thomas Graf wrote:
> > Please provide a new overall patch which is not based on your
> > initial patch so I can review your idea properly.
>
> Here it goes (merging two previous patches). I have diffed
> aga
* Waskiewicz Jr, Peter P <[EMAIL PROTECTED]> 2007-08-15 11:02
> > There is this very horrible way of using the u32 classifier
> > with a negative offset to look into the ethernet header.
>
> Based on this, it sounds like u32 using protocol 802_3 is broken?
You might be expecting too much from u3
* Waskiewicz Jr, Peter P <[EMAIL PROTECTED]> 2007-08-09 18:07
> My big question is: Has anyone recently used the 802_3 protocol in tc
> with u32 and actually gotten it to work? I can't see how the
> u32_classify() code can look at the mac header, since it is using the
> network header accessor to
* Richard MUSIL <[EMAIL PROTECTED]> 2007-08-10 10:45
> I have noticed that although ops for each family are the same (each
> device is functionally same) I cannot use same genl_ops struct for
> registration, because it uses internal member to link in list. Therefore
> it is necessary to allocate ne
replay label is unused otherwise.
Signed-off-by: Thomas Graf <[EMAIL PROTECTED]>
Index: net-2.6/net/core/rtnetlink.c
===
--- net-2.6.orig/net/core/rtnetlink.c 2007-07-22 11:41:46.0 +0200
+++ net-2.6/net/core/rtnet
Introduces neigh_cleanup_and_release() to be used after a
neighbour has been removed from its neighbour table. Serves
as preparation to add event notifications.
Signed-off-by: Thomas Graf <[EMAIL PROTECTED]>
Index: net-2.6/net/core/neigh
allows to keep
track of neighbour states without periodically fetching the
complete neighbour table.
Signed-off-by: Thomas Graf <[EMAIL PROTECTED]>
Index: net-2.6/net/core/neighbour.c
===
--- net-2.6.orig/net/core/neighbour.c 2007
family->mcast_groups is protected by genl_lock so it must
be held while accessing the list in genl_unregister_mc_groups().
Requires adding a non-locking variant of genl_unregister_mc_group().
Signed-off-by: Thomas Graf <[EMAIL PROTECTED]>
Index: net-2.6/net/netlink/ge
* Brian Haley <[EMAIL PROTECTED]> 2007-07-24 12:14
> Thomas Graf wrote:
> >@@ -217,14 +229,8 @@ EXPORT_SYMBOL(genl_register_mc_group);
> > void genl_unregister_mc_group(struct genl_family *family,
> > struct genl_multicast_group *grp)
>
family->mcast_groups is protected by genl_lock so it must
be held while accessing the list in genl_unregister_mc_groups().
Requires adding a non-locking variant of genl_unregister_mc_group().
Signed-off-by: Thomas Graf <[EMAIL PROTECTED]>
Index: net-2.6/net/netlink/ge
Signed-off-by: Thomas Graf <[EMAIL PROTECTED]>
Index: net-2.6/net/netlink/genetlink.c
===
--- net-2.6.orig/net/netlink/genetlink.c2007-07-23 21:54:35.0
+0200
+++ net-2.6/net/netlink/genetlink.c 2007-07-23
401 - 500 of 1030 matches
Mail list logo