* [EMAIL PROTECTED] <[EMAIL PROTECTED]> 2006-09-21 12:57
> At the suggestion of Thomas Graf, rewrite NetLabel's use of Netlink attributes
> to better follow the common Netlink attribute usage.
>
> Signed-off-by: Paul Moore <[EMAIL PROTECTED]>
> ---
> net/n
* [EMAIL PROTECTED] <[EMAIL PROTECTED]> 2006-09-21 12:57
> -int netlbl_netlink_snd_multicast(struct sk_buff *skb, u32 pid, u32 group)
> +int netlbl_netlink_snd_multicast(struct sk_buff *skb,
> + void *buf,
> + u32 pid,
> +
* YOSHIFUJI Hideaki / ?$B5HF#1QL@ <[EMAIL PROTECTED]> 2006-09-21 14:30
> In article <[EMAIL PROTECTED]> (at Mon, 18 Sep 2006 20:57:46 +0200), Thomas
> Graf <[EMAIL PROTECTED]> says:
> > Same here, it doesn't make sense to export macros only of functional
> &
* Johannes Berg <[EMAIL PROTECTED]> 2006-09-20 09:03
> > Just use a nested attribute here, this new array format you introduce
> > having 1 byte ID, 1 byte len is equivalent to using a set of nested
> > attributes with nla_type=id, nla_len=len.
>
> No, it is only validated, it is then supposed to
* Johannes Berg <[EMAIL PROTECTED]> 2006-09-14 12:53
> This is some preliminary code how I'm currently thinking (and that might
> change radically :) ) configuration might look like.
>
> It uses the patch I previously posted to make genetlink attributes
> custom-definable.
>
> --- wireless-dev.or
* Johannes Berg <[EMAIL PROTECTED]> 2006-09-14 11:21
> On Thu, 2006-09-14 at 10:14 +0200, Thomas Graf wrote:
>
> > Looks good, we have to watch the size of struct nla_policy though.
> > This bumps the size from 4 bytes to 16 bytes on 64bit architectures
> > which m
* David Miller <[EMAIL PROTECTED]> 2006-09-18 14:22
> From: Alexey Kuznetsov <[EMAIL PROTECTED]>
> Date: Tue, 19 Sep 2006 01:03:21 +0400
>
> > 1. It even does not disable possibility to record timestamp inside
> >driver, which Alan was afraid of. The sequence is:
> >
> > if (!skb->tstamp.
* YOSHIFUJI Hideaki / ?$B5HF#1QL@ <[EMAIL PROTECTED]> 2006-09-19 00:08
> [NET]: Move netlink interface bits to linux/if_link.h.
>
> Moving netlink interface bits to linux/if.h is rather troublesome for
> applications including both linux/if.h (which was changed to be included
>
* Johannes Berg <[EMAIL PROTECTED]> 2006-09-14 09:44
> This patch adds an NLA_CUSTOM_CHECK type for netlink attributes
> in order to be able to centrally define new attribute structures
> instead of having to check these special types in each function
> that uses such an attribute.
>
> nl80211 wil
* H. Peter Anvin <[EMAIL PROTECTED]> 2006-09-07 15:28
> Thomas Graf wrote:
> >What about adding blackhole device to be used for such routes.
> >I believe it would be good architecture to always use devices
> >to state directions packets are being received from and sen
Replaces INET6_IFADDR_RTA_SPACE with a new function calculating
the total required message size for all address messages.
Signed-off-by: Thomas Graf <[EMAIL PROTECTED]>
Index: net-2.6.19/net/ipv6/addrconf.c
===
--- net-2.6.1
Signed-off-by: Thomas Graf <[EMAIL PROTECTED]>
Index: net-2.6.19/net/ipv6/addrconf.c
===
--- net-2.6.19.orig/net/ipv6/addrconf.c 2006-09-01 23:15:19.0 +0200
+++ net-2.6.19/net/ipv6/addrconf.c 2006-09-01
e the NLM_F_CREATE check is removed.
Signed-off-by: Thomas Graf <[EMAIL PROTECTED]>
Index: net-2.6.19/net/ipv6/addrconf.c
===
--- net-2.6.19.orig/net/ipv6/addrconf.c 2006-09-01 23:15:25.0 +0200
+++ net-2.6.19/net/ipv6/addrconf.c
Same behaviour as IPv4, using IFF_UP is a no-no anyway.
Signed-off-by: Thomas Graf <[EMAIL PROTECTED]>
Index: net-2.6.19/net/ipv6/addrconf.c
===
--- net-2.6.19.orig/net/ipv6/addrconf.c 2006-09-01 23:15:24.0 +0200
+
Signed-off-by: Thomas Graf <[EMAIL PROTECTED]>
Index: net-2.6.19/net/ipv6/addrconf.c
===
--- net-2.6.19.orig/net/ipv6/addrconf.c 2006-09-01 23:15:21.0 +0200
+++ net-2.6.19/net/ipv6/addrconf.c 2006-09-01
Signed-off-by: Thomas Graf <[EMAIL PROTECTED]>
Index: net-2.6.19/net/ipv6/addrconf.c
===
--- net-2.6.19.orig/net/ipv6/addrconf.c 2006-09-01 23:14:47.0 +0200
+++ net-2.6.19/net/ipv6/addrconf.c 2006-09-01
Signed-off-by: Thomas Graf <[EMAIL PROTECTED]>
Index: net-2.6.19/net/ipv6/addrconf.c
===
--- net-2.6.19.orig/net/ipv6/addrconf.c 2006-09-01 23:15:18.0 +0200
+++ net-2.6.19/net/ipv6/addrconf.c 2006-09-01
Signed-off-by: Thomas Graf <[EMAIL PROTECTED]>
Index: net-2.6.19/net/ipv6/addrconf.c
===
--- net-2.6.19.orig/net/ipv6/addrconf.c 2006-09-01 23:15:14.0 +0200
+++ net-2.6.19/net/ipv6/addrconf.c 2006-09-01
Converts all of the IPv6 address configuration code to the new
netlink api and removes a bogus check on IFF_UP when adding
new addresses.
--
VGER BF report: U 0.467674
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo
A typo introduced by myself which leads to freeing the skb
containing the netlink message when it should free the newly
allocated skb for the reply.
Signed-off-by: Thomas Graf <[EMAIL PROTECTED]>
Index: net-2.6.19/net/core/rtnet
]
op unknown (0x03) [DOIT]
Signed-off-by: Thomas Graf <[EMAIL PROTECTED]>
Index: net-2.6.19/include/linux/genetlink.h
===
--- net-2.6.19.orig/include/linux/genetlink.h 2006-08-31 16:01:16.0
* Olaf Kirch <[EMAIL PROTECTED]> 2006-08-29 10:24
> we had bug reports from people seeing lots of spurious messages
> like the following:
>
> kernel: peth0: received packet with own address as source address.
>
> and
>
> xenbr0: duplicate address detected!
>
> This is on a Xen enabled machine,
* Andrew Morton <[EMAIL PROTECTED]> 2006-08-29 09:16
>
>
> Begin forwarded message:
>
> Date: Tue, 29 Aug 2006 10:25:07 -0400
> From: [EMAIL PROTECTED]
> To: Andrew Morton <[EMAIL PROTECTED]>
> Cc: linux-kernel@vger.kernel.org
> Subject: 2.6.18-rc4-mm3: BUG: warning at include/net/dst.h:154/dst_
* YOSHIFUJI Hideaki / ?$B5HF#1QL@ <[EMAIL PROTECTED]> 2006-08-26 00:08
> Hello.
>
> Here's some IPv6 policy rouging fixes on top of net-2.6.19 tree.
>
> [PATCH 1/3] [IPV6] ROUTE: Fix FWMARK support.
> [PATCH 2/3] [IPV6] ROUTE: Fix size of fib6_rule_policy.
>
> If we accept Patrick's IPv4 fwm
* YOSHIFUJI Hideaki / ?$B5HF#1QL@ <[EMAIL PROTECTED]> 2006-08-25 17:21
> commit 10204d532f5f8bb379009ba0bee2113bafda72be
> Author: YOSHIFUJI Hideaki <[EMAIL PROTECTED]>
> Date: Mon Aug 21 19:22:01 2006 +0900
>
> [IPV6] ROUTE: Routing by FWMARK.
>
> Based on patch by Jean Lorchat <[E
* Patrick McHardy <[EMAIL PROTECTED]> 2006-08-25 12:29
> This patch adds support to mask the nfmark value before the lookup
> the the fw classifier. Unfortunately it has some drawbacks, so I'd
> be interested if anyone can think of a better way.
>
> The problem is that in order to avoid walking th
* Johannes Berg <[EMAIL PROTECTED]> 2006-08-25 11:04
> I completely reworked that now so it will:
> * create a nested NL80211_ATTR_INTERFACE_LIST with nested {
>* 1..N attributes, with nested {
> * ATTR_IFINDEX and
> * ATTR_IFNAME
>}
> }
>
> how does that sound? Maybe I should
* Michael Buesch <[EMAIL PROTECTED]> 2006-08-24 19:09
> On Thursday 24 August 2006 18:07, Johannes Berg wrote:
> > + pkt = alloc_skb(framelen, GFP_KERNEL);
>
> if (!pkt)
> return -ENOMEM;
>
> > + pktdata = skb_put(pkt, framelen);
> > + memcpy(pktdata, frame, framelen);
>
> having two
* Johannes Berg <[EMAIL PROTECTED]> 2006-08-24 18:07
> +static int nl80211_get_cmdlist(struct sk_buff *skb, struct genl_info *info)
> +{
> + struct nl80211_registered_driver *drv;
> + struct sk_buff *msg;
> + void *hdr;
> + int err;
> + struct nlattr *start;
> + u8 *data;
>
* Johannes Berg <[EMAIL PROTECTED]> 2006-08-22 15:52
> +static struct nla_policy nl80211_policy[NL80211_ATTR_MAX+1] __read_mostly = {
> + [NL80211_ATTR_IFINDEX] = { .type = NLA_U32 },
> + [NL80211_ATTR_WIPHY] = { .type = NLA_U32 },
> + [NL80211_ATTR_FLAGS] = { .type = NLA_U32 },
> +
* David Miller <[EMAIL PROTECTED]> 2006-08-23 15:14
> From: Thomas Graf <[EMAIL PROTECTED]>
> Date: Wed, 23 Aug 2006 21:14:25 +0200
>
> > * H. Peter Anvin <[EMAIL PROTECTED]> 2006-08-22 17:31
> > > Specifically, Linux will not ProxyARP for an address
* H. Peter Anvin <[EMAIL PROTECTED]> 2006-08-22 17:31
> Specifically, Linux will not ProxyARP for an address unless it has a
> route for it, *and* that route either has a DNAT marking or points to a
> different interface than the input interface:
I can think of a very ugly way: Use netfilter to
t required to be NUL terminated
is extended to provide means to specify a maximum length of the
string.
Aims at easing the pain with using nla_strlcpy() on temporary
buffers.
Signed-off-by: Thomas Graf <[EMAIL PROTECTED]>
Index: net-2.6.19
ify a maximum length of the
string.
Aims at easing the pain with using nla_strlcpy() on temporary
buffers.
Signed-off-by: Thomas Graf <[EMAIL PROTECTED]>
Index: net-2.6.19.git/include/net/netlink.h
===
--- net-2.6.19.git.orig/
Validation of netlink string attributes was weak, forcing everyone
to use nla_strlcpy() to copy the attribute into a temporary buffer.
This patchset implements length validation checks for existing
NLA_STRING attributes and adds a new type NLA_NUL_STRING for
NUL terminated strings.
-
To unsubscri
Converts existing NLA_STRING attributes to use the new
validation features, saving a couple of temporary buffers.
Signed-off-by: Thomas Graf <[EMAIL PROTECTED]>
Index: net-2.6.19.git/net/core/rtnetlink.c
===
--- net-2.6.19.gi
Same approach as for IPv4, simplifies the interface
and makes it extendable without breaking the ioctl
interface.
Same memory corruption fixes in RTM_GETROUTE as for IPv4.
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majord
Fixes various unvalidated netlink attributes causing memory
corruptions when left empty by userspace applications.
Signed-off-by: Thomas Graf <[EMAIL PROTECTED]>
Index: net-2.6.19.git/net/ipv6/route.c
===
--- net-2.6.19.git.or
Provide a simple ip6_del_rt() for the majority of users and
an alternative for the exception via netlink. Avoids code
obfuscation.
Signed-off-by: Thomas Graf <[EMAIL PROTECTED]>
Index: net-2.6.19.git/include/net/ip6_r
Signed-off-by: Thomas Graf <[EMAIL PROTECTED]>
Index: net-2.6.19.git/net/core/rtnetlink.c
===
--- net-2.6.19.git.orig/net/core/rtnetlink.c
+++ net-2.6.19.git/net/core/rtnetlink.c
@@ -188,22 +188,27 @@ void rtnl_set_sk_err(u32
Provide a simple ip6_ins_rt() for the majority of users and
an alternative for the exception via netlink. Avoids code
obfuscation.
Signed-off-by: Thomas Graf <[EMAIL PROTECTED]>
Index: net-2.6.19.git/include/net/ip6_r
authorship information for notifications.
Signed-off-by: Thomas Graf <[EMAIL PROTECTED]>
Index: net-2.6.19.git/include/net/ip6_fib.h
===
--- net-2.6.19.git.orig/include/net/ip6_fib.h
+++ net-2.6.19.git/include/net/ip6_fib.h
@@
* Herbert Xu <[EMAIL PROTECTED]> 2006-08-16 21:39
> For a broadcast notification, the nlmsg_pid field is meaningless
> because the nlmsg_seq field is also meaningless. I'm not denying
> that it wouldn't be useful to have the originator's socket address
> in there. What I'm saying is that it's the
* jamal <[EMAIL PROTECTED]> 2006-08-16 08:04
> current->pid i think is coming out to be a bad idea. Thomas' patches
> revert it out. Again this has everything to do with the original idea
> what maps to pid now changing to socketid.
It probably developed from autobind using current->tid.
-
To unsu
* Herbert Xu <[EMAIL PROTECTED]> 2006-08-16 21:57
> On Wed, Aug 16, 2006 at 01:40:03PM +0200, Thomas Graf wrote:
> >
> > It was added to help quagga identify which route modifications
> > are self caused. It's not possible to use rtm_protocol for this
> > pu
* Herbert Xu <[EMAIL PROTECTED]> 2006-08-16 21:12
> On Wed, Aug 16, 2006 at 12:58:56PM +0200, Thomas Graf wrote:
> >
> > All route and tc notifications already use the pid so applications
> > can decide whether the event was caused by them. A notification
> > is a
* Herbert Xu <[EMAIL PROTECTED]> 2006-08-16 12:58
> I'm not comfortable with that change since it implies the message
> originated from a user-space process.
>
> The netlink header pid is really akin to sadb_msg_pid from RFC 2367.
> IMHO it should always be zero if the kernel is the originator of
Fixes various unvalidated netlink attributes causing memory
corruptions when left empty by userspace applications.
Signed-off-by: Thomas Graf <[EMAIL PROTECTED]>
Index: net-2.6.19.git/include/net/ip_fib.h
===
--- net-2.6.19.gi
will be used to carry the necessary netlink
information to be used for notifications later on.
Signed-off-by: Thomas Graf <[EMAIL PROTECTED]>
Index: net-2.6.19.git/include/net/ip_fib.h
===
--- net-2.6.19.git.orig/include/net/ip
Signed-off-by: Thomas Graf <[EMAIL PROTECTED]>
Index: net-2.6.19.git/net/ipv4/fib_semantics.c
===
--- net-2.6.19.git.orig/net/ipv4/fib_semantics.c
+++ net-2.6.19.git/net/ipv4/fib_semantics.c
@@ -286,7 +286,7 @@ void rtmsg_f
Replaces the rather ugly struct kern_rta + rtmsg with a new
struct fib_config while converting everything to the new netlink
api. Simplifies the FIB module interface quite a bit and allows
changing internals while keeping a stable netlink interface.
Gets rid of things like passing on netlink_skb_p
* Hasso Tepper <[EMAIL PROTECTED]> 2006-08-15 15:08
> Thomas Graf wrote:
> > However, I changed IPv4 addresses to provide the pid and support
> > NLM_F_ECHO and the same will follow for IPv6 address notifications
> > which will mean that quagga sees a di
* Alexey Kuznetsov <[EMAIL PROTECTED]> 2006-08-15 04:36
> > Some of these removals of current->pid will affect users such as quagga,
> > zebra, vrrpd etc.
>
> If they survived cleanup in IPv4, they definitely will not feel cleanup
> in IPv6.
That was exactly my thought, the notifications in quest
* jamal <[EMAIL PROTECTED]> 2006-08-14 19:43
> On Mon, 2006-14-08 at 00:00 +0200, Thomas Graf wrote:
> > plain text document attachment (rtnl_convert_ip6_addr)
> > Fixes a wrong use of current->pid as netlink pid.
>
> If i am not mistaken:
> Some of these rem
* Stephen Hemminger <[EMAIL PROTECTED]> 2006-08-14 15:37
> On Tue, 15 Aug 2006 00:22:20 +0200
> Thomas Graf <[EMAIL PROTECTED]> wrote:
> > Don't you need to pull in order to undo the push that probably
> > happened in dev->hard_header()?
>
> Proba
* Stephen Hemminger <[EMAIL PROTECTED]> 2006-08-14 14:20
> --- net-2.6.19.orig/net/core/neighbour.c
> +++ net-2.6.19/net/core/neighbour.c
> @@ -1160,19 +1164,24 @@ int neigh_resolve_output(struct sk_buff
> if (!neigh_event_send(neigh, skb)) {
> int err;
> struct n
Fixes a wrong use of current->pid as netlink pid.
Signed-off-by: Thomas Graf <[EMAIL PROTECTED]>
Index: net-2.6.19.git/net/ipv6/addrconf.c
===
--- net-2.6.19.git.orig/net/ipv6/addrconf.c
+++ net-2.6.19.git/net/ipv6/a
Adds support for NLM_F_ECHO allowing applications to easly
see which address have been deleted, added, or promoted.
Signed-off-by: Thomas Graf <[EMAIL PROTECTED]>
Index: net-2.6.19.git/net/ipv4/devinet.c
===
--- net-2.6.19.gi
Adds support for NLM_F_ECHO to simplify the process of identifying
inserted rules with an auto generated priority.
Signed-off-by: Thomas Graf <[EMAIL PROTECTED]>
Index: net-2.6.19.git/net/core/fib_rules.c
===
--- net-2.6.19.gi
Signed-off-by: Thomas Graf <[EMAIL PROTECTED]>
Index: net-2.6.19.git/net/decnet/dn_dev.c
===
--- net-2.6.19.git.orig/net/decnet/dn_dev.c
+++ net-2.6.19.git/net/decnet/dn_dev.c
@@ -746,20 +746,23 @@ rtattr_failure:
stati
Fixes a wrong use of current->pid as netlink pid.
Signed-off-by: Thomas Graf <[EMAIL PROTECTED]>
Index: net-2.6.19.git/net/ipv6/route.c
===
--- net-2.6.19.git.orig/net/ipv6/route.c
+++ net-2.6.19.git/net/ipv6/route.c
@@ -3
.
nlmsg_multicast() is extended to take allocation flags to
allow notification in atomic contexts.
Signed-off-by: Thomas Graf <[EMAIL PROTECTED]>
Index: net-2.6.19.git/include/net/netlink.h
===
--- net-2.6.19.git.orig/include/net/net
Fixes a wrong use of current->pid as netlink pid.
Signed-off-by: Thomas Graf <[EMAIL PROTECTED]>
Index: net-2.6.19.git/net/bridge/br_netlink.c
===
--- net-2.6.19.git.orig/net/bridge/br_netlink.c
+++ net-2.6.19.git/n
Fixes a wrong use of current->pid as netlink pid.
Signed-off-by: Thomas Graf <[EMAIL PROTECTED]>
Index: net-2.6.19.git/net/ipv6/addrconf.c
===
--- net-2.6.19.git.orig/net/ipv6/addrconf.c
+++ net-2.6.19.git/net/ipv6/a
Signed-off-by: Thomas Graf <[EMAIL PROTECTED]>
Index: net-2.6.19.git/net/core/rtnetlink.c
===
--- net-2.6.19.git.orig/net/core/rtnetlink.c
+++ net-2.6.19.git/net/core/rtnetlink.c
@@ -630,20 +630,22 @@ static int rtnl_dump_all(
Fixes a wrong use of current->pid as netlink pid.
Signed-off-by: Thomas Graf <[EMAIL PROTECTED]>
Index: net-2.6.19.git/net/ipv6/addrconf.c
===
--- net-2.6.19.git.orig/net/ipv6/addrconf.c
+++ net-2.6.19.git/net/ipv6/a
Adds rtnl_notify() to send rtnetlink notification messages and
rtnl_set_sk_err() to report notification errors as socket
errors in order to indicate the need of a resync due to loss
of events.
nlmsg_report() is added to properly document the meaning of
NLM_F_ECHO.
Signed-off-by: Thomas Graf
Signed-off-by: Thomas Graf <[EMAIL PROTECTED]>
Index: net-2.6.19.git/include/linux/rtnetlink.h
===
--- net-2.6.19.git.orig/include/linux/rtnetlink.h
+++ net-2.6.19.git/include/linux/rtnetlink.h
@@ -574,8 +574,6 @@ exte
Signed-off-by: Thomas Graf <[EMAIL PROTECTED]>
Index: net-2.6.19.git/net/core/wireless.c
===
--- net-2.6.19.git.orig/net/core/wireless.c
+++ net-2.6.19.git/net/core/wireless.c
@@ -85,6 +85,7 @@
#include /*
Signed-off-by: Thomas Graf <[EMAIL PROTECTED]>
Index: net-2.6.19.git/net/ipv4/fib_semantics.c
===
--- net-2.6.19.git.orig/net/ipv4/fib_semantics.c
+++ net-2.6.19.git/net/ipv4/fib_semantics.c
@@ -33,7 +33,6 @@
#include
#i
Signed-off-by: Thomas Graf <[EMAIL PROTECTED]>
Index: net-2.6.19.git/net/core/neighbour.c
===
--- net-2.6.19.git.orig/net/core/neighbour.c
+++ net-2.6.19.git/net/core/neighbour.c
@@ -2406,36 +2406,35 @@ static struct file_oper
Signed-off-by: Thomas Graf <[EMAIL PROTECTED]>
Index: net-2.6.19.git/include/linux/rtnetlink.h
===
--- net-2.6.19.git.orig/include/linux/rtnetlink.h
+++ net-2.6.19.git/include/linux/rtnetlink.h
@@ -584,6 +584,7 @@
This patchset reworks rtnetlink notifications. Notification logic
is fixed and gets hidden behind nlmsg_notify() and the rtnl socket
is no longer directly accessed. All notification paths get
appropriate error handling. NLM_F_ECHO support is added where it
makes sense and no major surgery is requir
* Alexey Kuznetsov <[EMAIL PROTECTED]> 2006-08-12 15:03
> Actually, it was the idea. If requestor asked NLM_F_ECHO and subscribed
> to muticasts, it suppresses double notifications. If it did not ask
> NLM_F_ECHO, he is not interested in results, he knows what's going on
> without this.
>
> F.e. i
* Alexey Kuznetsov <[EMAIL PROTECTED]> 2006-08-11 19:35
> Well, tc was supposed to use it, but this did not happen and
> it remained deficient.
Makes sense, especially for auto generated handles. I've been listening
to the notifications on a separate socket for this purpose. It would
make sense ho
* David Miller <[EMAIL PROTECTED]> 2006-08-10 23:02
> Thomas, there was a conflict which I did expect since I added
> all the 2.6.18 bug fixes into the tree. The conflict is for
> your netlink conversion of the iflink stuff.
>
> I had to fix the -stable tree IFLA_ADDRESS handling because
> dev->s
* Michael Tokarev <[EMAIL PROTECTED]> 2006-08-11 10:56
> And while we're at it... How about using table *names* instead of
> numbers in kernel too, a-la iptables? Once possible number of tables
> is large, and we're using hashes for tables now anyway, keeping a
> name inside the table structure w
Hello
* Alexey Kuznetsov <[EMAIL PROTECTED]> 2006-08-11 00:32
> Nothing! NLM_F_ECHO _is_ listening for notifications without subscription
> to multicast groups and need to figure out what messages are yours.
> But beyond this NLM_F_ECHO is totally subset of this.
> Which still makes much more sens
* Patrick McHardy <[EMAIL PROTECTED]> 2006-08-10 21:08
> The error code (-ENOMEM) gives it a pretty good idea what went
> wrong. Its true that it doesn't know which group was affected
> (that could be fixed), but at least it knows that something
> went wrong and it needs to resync. If that fails du
* Patrick McHardy <[EMAIL PROTECTED]> 2006-08-10 20:09
> Thomas Graf wrote:
> > Setting a socket error on all sockets subscribed to a group
> > if an event notificiation of said group fails due to memory
> > pressure only confuses applications and is of no use.
> &g
* Alexey Kuznetsov <[EMAIL PROTECTED]> 2006-08-10 19:51
> > This patch handles NLM_F_ECHO in netlink_rcv_skb() to
> > handle it in a central point. Most subsystems currently
> > interpret NLM_F_ECHO as to just unicast events to the
> > originator of the change while the real meaning of the
> > flag
* David Miller <[EMAIL PROTECTED]> 2006-08-02 15:18
> From: Stephen Hemminger <[EMAIL PROTECTED]>
> Date: Wed, 2 Aug 2006 12:56:36 -0700
>
> > The HTB scheduler code is a mess, this patch set does some basic
> > house cleaning. The first four should cause no code change, but the
> > last two need
themselves and properly feeds all calls
to netlink_broadcast() with a pid of 0 to not exclude any sockets.
Removes the obsoleted NLM_F_ECHO code.
Some notifications are done in atomic contex, therefore
nlmsg_multicast() had to be extended to take allocation flags.
Signed-off-by: Thomas Graf <[EM
All references to the rtnl sock are now done via wrapper
functions, unexport it.
Signed-off-by: Thomas Graf <[EMAIL PROTECTED]>
Index: net-2.6.19.git/include/linux/rtnetlink.h
===
--- net-2.6.19.git.orig/include/linux/rtnet
Setting a socket error on all sockets subscribed to a group
if an event notificiation of said group fails due to memory
pressure only confuses applications and is of no use.
This patch removes it all together.
Signed-off-by: Thomas Graf <[EMAIL PROTECTED]>
Index: net-2.6.19.git/net/
icast events to the
originator of the change while the real meaning of the
flag is to echo the request.
Signed-off-by: Thomas Graf <[EMAIL PROTECTED]>
Index: net-2.6.19.git/net/netlink/af_netlink.c
===
--- net-2.6.19.git.orig/
netlink_broadcast() with a pid of 0 to not exclude any sockets.
Removes the obsoleted NLM_F_ECHO code.
Some notifications are done in atomic contex, therefore
nlmsg_multicast() had to be extended to take allocation flags.
Signed-off-by: Thomas Graf <[EMAIL PROTECTED]>
Index: net-2.6.19.git/i
Aims at cleaning up rtnetlink event notifications and implements
real NLM_F_ECHO support.
Please disregard my last IPv4 routing related patchset, I'll
resubmit it based on this patchset.
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECT
* Peter Zijlstra <[EMAIL PROTECTED]> 2006-08-09 16:07
> I think Daniel was thinking of adding struct net_device *
> sk_buff::alloc_dev,
> I know I was after reading the first few mails. However if adding a
> field
> there is strict no-no
>
> /me takes a look at struct sk_buff
>
> Hmm, what d
* Steven Whitehouse <[EMAIL PROTECTED]> 2006-08-09 11:03
> On Wed, Aug 09, 2006 at 01:01:25AM -0700, David Miller wrote:
> > From: Steven Whitehouse <[EMAIL PROTECTED]>
> > Date: Wed, 9 Aug 2006 09:01:39 +0100
> >
> > > Is there anything to stop me using RTNLGRP_NOP3 for that? (suitable
> > > rena
* Daniel Phillips <[EMAIL PROTECTED]> 2006-08-08 22:47
> David Miller wrote:
> >From: Daniel Phillips <[EMAIL PROTECTED]>
> >>Can you please characterize the conditions under which skb->dev changes
> >>after the alloc? Are there writings on this subtlety?
> >
> >The packet scheduler and classifie
* Ville Nuorvala <[EMAIL PROTECTED]> 2006-08-09 12:42
> Ok, it might require quite big changes to the existing code, but if
> someone is willing to take a look at it I wouldn't be against it :-)
I'll provide a patch soon.
> You know, I'm starting to think we could perhaps get rid of
> ip6_null_en
* Steven Whitehouse <[EMAIL PROTECTED]> 2006-08-09 09:01
> With your new protocol independent rules code, I see that there is an
> entry in struct fib_rules_ops for a netlink group for notification of
> rule changes. For whatever reason (historical I guess) DECnet has never
> had a nl group assigne
* Ville Nuorvala <[EMAIL PROTECTED]> 2006-08-09 11:36
> Of the three original route lookup functions (ip6_route_input,
> ip6_route_output and rt6_lookup), rt6_lookup was the only one that was
> allowed to produce a NULL entry. Of these three rt6_lookup was also the
> only one not actually being use
* Thomas Graf <[EMAIL PROTECTED]> 2006-08-08 00:00
> Introduces struct fib_config replacing the ugly struct kern_rta
> prone to ordering issues. Avoids creating faked netlink messages
> for auto generated routes or requests via ioctl.
>
> A new interface net/nexthop.h is a
* Ville Nuorvala <[EMAIL PROTECTED]> 2006-08-09 01:05
> [IPV6]: Make sure fib6_rule_lookup doesn't return NULL
>
> The callers of fib6_rule_lookup don't expect it to return NULL,
> therefore it must return ip6_null_entry whenever fib_rule_lookup fails.
>
> Signed-off-by: V
* Peter Zijlstra <[EMAIL PROTECTED]> 2006-08-08 21:33
> +struct sk_buff *__netdev_alloc_skb(struct net_device *dev,
> + unsigned length, gfp_t gfp_mask)
> +{
> + struct sk_buff *skb;
> +
> + if (dev && (dev->flags & IFF_MEMALLOC)) {
> + WARN_ON(gfp_mask & (__GFP_NOME
pid of the requesting process is stored
in fib_config, it is no longer required to pass netlink_skb_parms
all along just for event notification.
Signed-off-by: Thomas Graf <[EMAIL PROTECTED]>
Index: net-2.6.19.git/include/net/ip
Fixes various unvalidated netlink attributes causing memory
corruptions when left empty by userspace applications.
Signed-off-by: Thomas Graf <[EMAIL PROTECTED]>
Index: net-2.6.19.git/include/net/ip_fib.h
===
--- net-2.6.19.gi
Replaces the rather ugly struct kern_rta + rtmsg with a new
struct fib_config while converting everything to the new netlink
api. Simplifies the FIB module interface quite a bit and allows
changing internals while keeping a stable netlink interface.
Gets rid of things like passing on netlink_skb_p
701 - 800 of 1030 matches
Mail list logo
