[iproute2 PATCH] ip: bridge: add mcast to unicast config flag

2019-03-21 Thread Tobias Jungel
This adds configuration for the IFLA_BRPORT_MCAST_TO_UCAST flag that allows multicast packets to be replicated as unicast packets. Signed-off-by: Tobias Jungel --- bridge/link.c| 12 ip/iplink_bridge_slave.c | 9 + man/man8/bridge.8| 5 + man/man8

[iproute2 PATCH] ipneigh: print dst for AF_BRIDGE

2019-01-05 Thread Tobias Jungel
In case a neighbour message is of family AF_BRIDE the NDA_DST attribute was not printed so far. With this patch the family is evaluated to pass the correct family to format_host_rta. Signed-off-by: Tobias Jungel --- ip/ipneigh.c | 12 ++-- 1 file changed, 10 insertions(+), 2 deletions

[PATCH v2] bonding: fix length of actor system

2018-10-28 Thread Tobias Jungel
accesses") Signed-off-by: Tobias Jungel --- Changes in v2: - correct Fixes line drivers/net/bonding/bond_netlink.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/bonding/bond_netlink.c b/drivers/net/bonding/bond_netlink.c index 9697977b80f0..6b9ad8673218

[PATCH] bonding: fix length of actor system

2018-10-27 Thread Tobias Jungel
The attribute IFLA_BOND_AD_ACTOR_SYSTEM is sent to user space having the length of sizeof(bond->params.ad_actor_system) which is 8 byte. This patch aligns the length to ETH_ALEN to have the same MAC address exposed as using sysfs. fixes f87fda00b6ed2 Signed-off-by: Tobias Jungel --- driv

[iproute2 PATCH v2] bridge: fix vlan show stats formatting

2018-10-26 Thread Tobias Jungel
The output of -statistics vlan show was broken previous change for json output. This aligns the format to vlan show. v2: fixed too greedy deletion that caused a -Wmaybe-uninitialized Signed-off-by: Tobias Jungel --- bridge/vlan.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff

[iproute2 PATCH] bridge: fix vlan show stats formatting

2018-10-20 Thread Tobias Jungel
The output of -statistics vlan show was broken previous change for json output. This aligns the format to vlan show. Signed-off-by: Tobias Jungel --- bridge/vlan.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/bridge/vlan.c b/bridge/vlan.c index bdce55ae..85f4a539

Re: [PATCH iproute2 3/3] bridge: fix vlan show formatting

2018-09-10 Thread Tobias Jungel
Hi Stephen, I just have seen this patch, hence please ignore the "bridge: Correct json output" I sent. This one solves the issue in a way more elegant manor. I tested the JSON output in this series and it works as intended. Thanks Reviewed-by: Tobias Jungel On Thu, 2018-09-0

[iproute2 PATCH] bridge: Correct json output

2018-09-07 Thread Tobias Jungel
The current implementation adds configured vlans as "vlan": [ ... ] into an array. This is malformed json and fails to be parsed. This patch creates an object to include this key value pair. Test with: ip l a type bridge ./bridge/bridge -j vlan | jq fixes c7c1a1ef5 Signed-off-by: Tob

[PATCH v4] bridge: netlink: check vlan_default_pvid range

2017-05-17 Thread Tobias Jungel
ridge: netlink: add support for default_pvid") Acked-by: Nikolay Aleksandrov Signed-off-by: Tobias Jungel --- net/bridge/br_netlink.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/net/bridge/br_netlink.c b/net/bridge/br_netlink.c index c5ce774..574f788 100644 --- a/net/bridge/br

[PATCH v3] bridge: netlink: check vlan_default_pvid range

2017-05-16 Thread Tobias Jungel
ridge: netlink: add support for default_pvid") Signed-off-by: Tobias Jungel --- net/bridge/br_netlink.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/net/bridge/br_netlink.c b/net/bridge/br_netlink.c index c5ce774..47cb95b 100644 --- a/net/bridge/br_netlink.c +++ b/net/bridge/br

Re: [PATCH] bridge: netlink: check vlan_default_pvid range

2017-05-15 Thread Tobias Jungel
On Mon, 2017-05-15 at 16:31 +0300, Nikolay Aleksandrov wrote: > On 5/15/17 4:29 PM, Nikolay Aleksandrov wrote: > > On 5/15/17 4:21 PM, Tobias Jungel wrote: > > > Thanks Sabrina and Nik. > > > > > > On Mon, 2017-05-15 at 14:01 +0200, Sabrina Dubroca wrote: >

[PATCH v2] bridge: netlink: check vlan_default_pvid range

2017-05-15 Thread Tobias Jungel
("bridge: netlink: add support for default_pvid") Signed-off-by: Tobias Jungel --- net/bridge/br_vlan.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/net/bridge/br_vlan.c b/net/bridge/br_vlan.c index b838213..95a565e 100644 --- a/net/bridge/br_vlan.c +++ b/net/bridge/br_vlan.c

Re: [PATCH] bridge: netlink: check vlan_default_pvid range

2017-05-15 Thread Tobias Jungel
Thanks Sabrina and Nik. On Mon, 2017-05-15 at 14:01 +0200, Sabrina Dubroca wrote: > Hi Tobias, > > 2017-05-15, 13:08:19 +0200, Tobias Jungel wrote: > > Currently it is allowed to set the default pvid of a bridge to a > > value > > above VLAN_VID_MASK (0xfff). This p

[PATCH] bridge: netlink: check vlan_default_pvid range

2017-05-15 Thread Tobias Jungel
Currently it is allowed to set the default pvid of a bridge to a value above VLAN_VID_MASK (0xfff). This patch checks the passed pvid and disables the pvid in case it is out of bounds. Reproduce by calling: [root@test ~]# ip l a type bridge [root@test ~]# ip l a type dummy [root@test ~]# ip l s b