http://marc.info/?t=14749669155=1=2
http://marc.info/?t=14749669153=1=2
http://marc.info/?t=14749669152=1=2
http://marc.info/?t=14749669154=1=2
http://marc.info/?t=14749669151=1=2
It needs jumbo frame support of NICs though.
Regards,
Toshiaki Makita
# bridge vlan add vid 2 dev port0 [master] self
Actually this is intended behavior, which keeps backward compatibility.
http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=7f1095394918c7058ff81c96c3bab3a897e97a9d
Thanks,
Toshiaki Makita
On 16/09/29 (木) 21:49, Jiri Benc wrote:
On Tue, 27 Sep 2016 17:55:40 +0900, Toshiaki Makita wrote:
This adds support for envhdrlen.
Example:
# ip link set eno1 envhdrlen 8
Thank you for taking a look at this.
I don't see why this should be user visible, let alone requiring user
to set
o the mtu] to this value?
I actually tried it first and realized it is difficult, since so many
drivers use their own initializer instead of ether_setup(). Anyway, I'm
going not to expose envhdrlen when it is not supported.
Thanks,
Toshiaki Makita
was discussed in Netdev 0.1:
http://www.netdevconf.org/0.1/docs/netdev01_bof_8021ad_makita_150212.pdf
This topic is also going to be discussed in Netdev 1.2:
http://www.netdevconf.org/1.2/session.html?toshiaki-makita
[1] http://www.ieee802.org/3/as/public/0607/802.3as_overview.pdf
[2] https://wiki.mef.net/displ
igned-off-by: Toshiaki Makita <makita.toshi...@lab.ntt.co.jp>
---
drivers/net/ethernet/intel/e1000e/netdev.c | 84 +-
1 file changed, 60 insertions(+), 24 deletions(-)
diff --git a/drivers/net/ethernet/intel/e1000e/netdev.c
b/drivers/net/ethernet/intel/e1000e/netdev.
With this change, admin can configure env_hdr_len.
Signed-off-by: Toshiaki Makita <makita.toshi...@lab.ntt.co.jp>
---
include/uapi/linux/if_link.h | 1 +
net/core/rtnetlink.c | 16 ++--
2 files changed, 15 insertions(+), 2 deletions(-)
diff --git a/include/uapi
in terms of max
allowed frame length.
[1] IEEE 802.3-2012, 1.4.334.
[2] IEEE 802.3-2012, 1.4.184.
[3] http://www.ieee802.org/3/as/public/0607/802.3as_overview.pdf
Signed-off-by: Toshiaki Makita <makita.toshi...@lab.ntt.co.jp>
---
include/linux/netdevice.h | 21 +
ne
an RFC, this includes update for kernel headers.
Signed-off-by: Toshiaki Makita <makita.toshi...@lab.ntt.co.jp>
---
include/linux/if_link.h | 1 +
ip/ipaddress.c | 2 ++
ip/iplink.c | 10 ++
3 files changed, 13 insertions(+)
diff --git a/include/linux/if_link
mac after br0 took port1b's one as
> its own.
If the mac address of lower device is changed while vlan device is down,
the address will be synchronized when vlan device becomes up.
Please try "ip li set vlan10 up".
--
Toshiaki Makita
w propagated automatically to vlans created on top of it ?
This should have been addressed at least in kernel 4.7...
http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=308453aa9156a3b8ee382c0949befb507a32b0c1
Which kernel version do you use?
--
Toshiaki Makita
On 16/08/14 (日) 23:58, Hadar Hen Zion wrote:
On Fri, Aug 12, 2016 at 9:36 AM, Toshiaki Makita
<makita.toshi...@lab.ntt.co.jp> wrote:
On 2016/08/10 22:32, Hadar Hen Zion wrote:
Early in the datapath skb_vlan_untag function is called, stripped
the vlan from the skb and set skb->vlan_tc
n skb->data.
So I think you should handle both of skb->vlan_tci and skb->data cases.
Thanks,
Toshiaki Makita
On 16/08/06 (土) 7:26, Stephen Hemminger wrote:
On Thu, 04 Aug 2016 11:27:25 -0700
Roopa Prabhu <ro...@cumulusnetworks.com> wrote:
On 8/4/16, 1:15 AM, Toshiaki Makita wrote:
On 2016/08/04 16:24, Roopa Prabhu wrote:
On 8/3/16, 7:11 PM, Toshiaki Makita wrote:
Adding fdb entries po
On 2016/08/04 17:15, Toshiaki Makita wrote:
> On 2016/08/04 16:24, Roopa Prabhu wrote:
>> On 8/3/16, 7:11 PM, Toshiaki Makita wrote:
>>> Adding fdb entries pointing to the bridge device uses fdb_insert(),
>>> which lacks various checks and does not respect added_by_use
On 2016/08/04 16:24, Roopa Prabhu wrote:
> On 8/3/16, 7:11 PM, Toshiaki Makita wrote:
>> Adding fdb entries pointing to the bridge device uses fdb_insert(),
>> which lacks various checks and does not respect added_by_user flag.
>>
>> As a result, some inconsistent behav
idge: allow adding of fdb entries pointing to the
bridge device")
Signed-off-by: Toshiaki Makita <makita.toshi...@lab.ntt.co.jp>
---
net/bridge/br_fdb.c | 52 +++-
1 file changed, 27 insertions(+), 25 deletions(-)
diff --git a/net/bridge/
On 16/06/13 (月) 20:23, Nikolay Aleksandrov wrote:
On 13/06/16 13:13, Toshiaki Makita wrote:
On 2016/06/12 15:35, Toshiaki Makita wrote:
On 16/06/12 (日) 1:17, Nikolay Aleksandrov via Bridge wrote:
On 06/11/2016 07:35 AM, David Miller wrote:
From: Toshiaki Makita <makita.toshi...@lab.ntt.co
On 2016/06/12 15:35, Toshiaki Makita wrote:
> On 16/06/12 (日) 1:17, Nikolay Aleksandrov via Bridge wrote:
>> On 06/11/2016 07:35 AM, David Miller wrote:
>>> From: Toshiaki Makita <makita.toshi...@lab.ntt.co.jp>
>>> Date: Mon, 6 Jun 2016 21:20:13 +0900
On 16/06/12 (日) 1:17, Nikolay Aleksandrov via Bridge wrote:
On 06/11/2016 07:35 AM, David Miller wrote:
From: Toshiaki Makita <makita.toshi...@lab.ntt.co.jp>
Date: Mon, 6 Jun 2016 21:20:13 +0900
Patrick Schaaf reported that flooding due to a missing fdb entry of
the address of m
ables")
Signed-off-by: Toshiaki Makita <makita.toshi...@lab.ntt.co.jp>
---
net/bridge/br_fdb.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/net/bridge/br_fdb.c b/net/bridge/br_fdb.c
index dcea4f4..c18080a 100644
--- a/net/bridge/br_fdb.c
+++ b/net/bridge/br_fdb.c
@@ -279,
() in br_fdb_sync_uc() as per
Nikolay Aleksandrov.
Reported-by: Patrick Schaaf <net...@bof.de>
Signed-off-by: Toshiaki Makita <makita.toshi...@lab.ntt.co.jp>
---
net/bridge/br_device.c | 7 +--
net/bridge/br_fdb.c | 119
net/bridge/
t;> +
>>> + list_for_each_entry(v, >vlan_list, vlist)
>>> + fdb_insert(br, NULL, ha->addr, v->vid);
>>
>> Since here you’re walking over the bridge’s vlan list, you should test the
>> vlans with br_vlan_should_use()
>> because it can be a global context holder if the vlan was configured only on
>> ports.
Thank you for your feedback.
will fix in v2.
I actually thought that this is the same logic as
br_fdb_change_mac_address() so assumed it should be all right.
Does br_fdb_change_mac_address() need br_vlan_should_use() as well?
Toshiaki Makita
.de>
Signed-off-by: Toshiaki Makita <makita.toshi...@lab.ntt.co.jp>
---
net/bridge/br_device.c | 7 +--
net/bridge/br_fdb.c | 117 +++-
net/bridge/br_private.h | 7 +--
net/bridge/br_vlan.c| 11 +++--
4 files changed, 120 inser
ress Untagged
>
> $bridge -j vlan show
> {
> "swp1": [{
> "vlan": 1,
> "flags": "PVID Egress Untagged"
Shouldn't we split flags?
"swp1": [{
"vlan": 1,
"flags": [
"PVID",
"Egress Untagged"
]
}
--
Toshiaki Makita
its under the
> bridge.
>
> Naive question: shouldn't that work automatically, i.e. macvlan when
> sitting on to of a bridge, doing that internally?
I'll think of this, thank you.
Toshiaki Makita
e more analysis:
- bridge adds the fdb entry of br0 mac address permanently. bridge never
learns source mac addresses of frames sent from br0.
- bridge seems not to have an ability to propagate the mac address of
its upper device into fdb.
- vlan device has the same mac address as its real device by default, so
it does not cause the problem.
--
Toshiaki Makita
t; }
>
>
> +static int set_stp_state(struct net_bridge *br, unsigned long val)
> +{
You forgot to add rtnl lock here?
The missing lock is restored in patch 4, but at this point bisect could
break..
> + br_stp_set_enabled(br, val);
> + return 0;
> +}
Toshiaki Makita
On 15/10/28 (水) 13:58, Stephen Hemminger wrote:
On Mon, 26 Oct 2015 12:40:55 +0900
Toshiaki Makita <makita.toshi...@lab.ntt.co.jp> wrote:
...
Thank you for taking a look at the patch set.
I'm not sure if I fully understand you, so please correct me if I
misread you.
The problem is th
On 2015/10/26 17:13, Toshiaki Makita wrote:
> On 2015/10/26 16:47, Grumbach, Emmanuel wrote:
>> On 10/26/2015 06:03 AM, Toshiaki Makita wrote:
>>> On 2015/10/26 5:02, Emmanuel Grumbach wrote:
>>>> Adding IPv6 for the TSO helper API is trivial:
>>>> * D
On 2015/10/26 16:47, Grumbach, Emmanuel wrote:
> On 10/26/2015 06:03 AM, Toshiaki Makita wrote:
>> On 2015/10/26 5:02, Emmanuel Grumbach wrote:
>>> Adding IPv6 for the TSO helper API is trivial:
>>> * Don't play with the id (which doesn't exist in IPv6)
>>>
truct iphdr *iph = (void *)(hdr + mac_hdr_len);
> +
> + iph->id = htons(tso->ip_id);
> + iph->tot_len = htons(size + hdr_len - mac_hdr_len);
> + tso->ip_id++;
> + } else if (skb->protocol == htons(ETH_P_IPV6)) {
Likewise.
Toshiaki
e1000e has 4 bytes additional room for vlan header, so set default
enc_hdr_len to 4.
Note that e1000e uses mtu to validate frame size in some places, which
are needed to be modified to use max_frame_size as extra header room
became variable.
Signed-off-by: Toshiaki Makita <makita.to
].
This patch set is based on the conclusion of the discussion.
Changes:
v2: Fixed chackpatch warnings
[1] https://wiki.mef.net/display/CESG/ENNI+Frame
[2] https://www.netdev01.org/docs/netdev01_bof_8021ad_makita_150212.pdf
Toshiaki Makita (4):
net: Add ndo_enc_hdr_len to notify extra header room
If vlan is assigned to a port, notify the port of 4 bytes header length,
or 8 bytes if 802.1ad.
Signed-off-by: Toshiaki Makita <makita.toshi...@lab.ntt.co.jp>
---
net/bridge/br_vlan.c | 18 ++
1 file changed, 18 insertions(+)
diff --git a/net/bridge/br_vlan.c b/net/
of needed
encapsulation header size.
Signed-off-by: Toshiaki Makita <makita.toshi...@lab.ntt.co.jp>
---
include/linux/netdevice.h | 9 +
net/core/dev.c| 36
2 files changed, 45 insertions(+)
diff --git a/include/linux/netdevice.h b/i
Reserve extra 4 bytes on real_dev in addition to the length notified
from upper device.
In 802.1ad mode, set enc_hdr_len to 4 bytes by default, since it is
likely to send already tagged frame.
Signed-off-by: Toshiaki Makita <makita.toshi...@lab.ntt.co.jp>
---
net/8021q/vlan.c
H_FRAME_LEN +
> ETH_FCS_LEN) {
>
> total: 0 errors, 3 warnings, 0 checks, 184 lines checked
I was aware of these warnings but my understanding was that lines
without over 80 characters are not mandatory requirement and a short
overrun can be acceptable, like 81 or 82... Not su
On 2015/10/24 17:50, Toshiaki Makita wrote:
> David,
>
> I found my patch set is marked with Changes Requested, but I haven't
> seen any feedback.
>
> Could you give me your feedback?
Somehow the mail from LD Linux CI Server did not reach netdev mailing
list so I could not
David,
I found my patch set is marked with Changes Requested, but I haven't
seen any feedback.
Could you give me your feedback?
Thanks,
Toshiaki Makita
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majord...@vger.kernel.org
More majo
].
This patch set is based on the conclusion of the discussion.
[1] https://wiki.mef.net/display/CESG/ENNI+Frame
[2] https://www.netdev01.org/docs/netdev01_bof_8021ad_makita_150212.pdf
Toshiaki Makita (4):
net: Add ndo_enc_hdr_len to notify extra header room for encapsulated
frames
e1000e: Add
If vlan is assigned to a port, notify the port of 4 bytes header length,
or 8 bytes if 802.1ad.
Signed-off-by: Toshiaki Makita <makita.toshi...@lab.ntt.co.jp>
---
net/bridge/br_vlan.c | 18 ++
1 file changed, 18 insertions(+)
diff --git a/net/bridge/br_vlan.c b/net/
of needed
encapsulation header size.
Signed-off-by: Toshiaki Makita <makita.toshi...@lab.ntt.co.jp>
---
include/linux/netdevice.h | 9 +
net/core/dev.c| 36
2 files changed, 45 insertions(+)
diff --git a/include/linux/netdevice.h b/i
Reserve extra 4 bytes on real_dev in addition to the length notified
from upper device.
In 802.1ad mode, set enc_hdr_len to 4 bytes by default, since it is
likely to send already tagged frame.
Signed-off-by: Toshiaki Makita <makita.toshi...@lab.ntt.co.jp>
---
net/8021q/vlan.c
e1000e has 4 bytes additional room for vlan header, so set default
enc_hdr_len to 4.
Note that e1000e uses mtu to validate frame size in some places, which
are needed to be modified to use max_frame_size as extra header room
became variable.
Signed-off-by: Toshiaki Makita <makita.to
ef brd ff:ff:ff:ff:ff:ff promiscuity 0
bridge forward_delay 0 hello_time 200 max_age 2000 ageing_time 3
stp_state 0 priority 32768 vlan_filtering 0 vlan_protocol 802.1ad
addrgenmode eui64
Signed-off-by: Toshiaki Makita <makita.toshi...@lab.ntt.co.jp>
---
include/linux/if_link.h | 1 +
ip/ipl
On 15/08/28 (金) 0:48, Nikolay Aleksandrov wrote:
On Aug 26, 2015, at 11:00 PM, Toshiaki Makita makita.toshi...@lab.ntt.co.jp
wrote:
This enables bridge vlan_protocol to be configured through netlink.
When CONFIG_BRIDGE_VLAN_FILTERING is disabled, kernel behaves the
same way as this feature
This enables bridge vlan_protocol to be configured through netlink.
When CONFIG_BRIDGE_VLAN_FILTERING is disabled, kernel behaves the
same way as this feature is not implemented.
Signed-off-by: Toshiaki Makita makita.toshi...@lab.ntt.co.jp
---
include/uapi/linux/if_link.h | 1 +
net/bridge
This enables bridge vlan_protocol to be configured through netlink.
When CONFIG_BRIDGE_VLAN_FILTERING is disabled, kernel behaves the
same way as this feature is not implemented.
Signed-off-by: Toshiaki Makita makita.toshi...@lab.ntt.co.jp
---
v2: Fix u16 to __be16
include/uapi/linux/if_link.h
On 2015/08/27 15:00, Toshiaki Makita wrote:
This enables bridge vlan_protocol to be configured through netlink.
When CONFIG_BRIDGE_VLAN_FILTERING is disabled, kernel behaves the
same way as this feature is not implemented.
Signed-off-by: Toshiaki Makita makita.toshi...@lab.ntt.co.jp
Tap devices don't need to segment multiple tagged packets.
Signed-off-by: Toshiaki Makita makita.toshi...@lab.ntt.co.jp
---
drivers/net/tun.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/tun.c b/drivers/net/tun.c
index 06a0394..976aa97 100644
--- a/drivers/net/tun.c
+++ b
Bridge devices don't need to segment multiple tagged packets since thier
ports can segment them.
Signed-off-by: Toshiaki Makita makita.toshi...@lab.ntt.co.jp
---
net/bridge/br_device.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/net/bridge/br_device.c b/net/bridge/br_device.c
index
Macvlan/macvtap devices don't need to segment multiple tagged packets
since the lower devices can segment them.
Signed-off-by: Toshiaki Makita makita.toshi...@lab.ntt.co.jp
---
drivers/net/macvlan.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/macvlan.c b/drivers/net/macvlan.c
Veth devices don't need to segment multiple tagged packets.
Signed-off-by: Toshiaki Makita makita.toshi...@lab.ntt.co.jp
---
drivers/net/veth.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/veth.c b/drivers/net/veth.c
index c8186ff..343592c 100644
--- a/drivers/net/veth.c
+++ b
Basically virtual devices do not need to segment double tagged packets.
This patch set adds TSO feature for double tagged packets to several
virtual devices, which can be realized by simply setting
.ndo_features_check to passthru_features_check.
Toshiaki Makita (4):
macvlan: Don't segment
, and since the header pointer fix
is needed only in tx path, set the appropriate network header on forwarding
packets.
Signed-off-by: Toshiaki Makita makita.toshi...@lab.ntt.co.jp
---
net/bridge/br_forward.c | 29 ++---
1 file changed, 22 insertions(+), 7 deletions(-)
diff
should set network_header after
skb_probe_transport_header(). It calls skb_flow_dissect_flow_keys(),
which seems to expect network_header to be ETH_HLEN.
Toshiaki Makita
--
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to majord...@vger.kernel.org
More
Aleksandrov niko...@cumulusnetworks.com
Fixes: bdced7ef7838 (bridge: support for multiple vlans and vlan ranges in
setlink and dellink requests)
Thank you for fixing this.
Acked-by: Toshiaki Makita toshiaki.maki...@gmail.com
--
To unsubscribe from this list: send the line unsubscribe netdev in
the body
be a bug.
Toshiaki Makita
--
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
with GFP_KERNEL in
__rocker_port_mem_alloc(), but it can be called from IRQ context.
rocker_event_neigh_update()
rocker_port_ipv4_neigh()
rocker_port_kzalloc()
__rocker_port_mem_alloc()
Toshiaki Makita
--
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message
On 15/06/04 (木) 3:41, roopa wrote:
On 6/3/15, 8:43 AM, Toshiaki Makita wrote:
On 15/06/03 (水) 4:01, Scott Feldman wrote:
On Tue, Jun 2, 2015 at 9:58 AM, roopa ro...@cumulusnetworks.com wrote:
On 6/2/15, 7:30 AM, Scott Feldman wrote:
On Tue, Jun 2, 2015 at 4:43 AM, Jamal Hadi Salim j
On 15/06/04 (木) 15:05, Scott Feldman wrote:
On Thu, 4 Jun 2015, Toshiaki Makita wrote:
Bridge's vlan_filtering is handled in master-op-foo(), not in
port-op-foo().
Can't we introduce another switchdev handler that performs MASTER
operation instead of calling SELF operation?
br_afspec
()
nbp_vlan_add()
netdev_switch_port_vlan_add()
rocker-ndo_switch_port_vlan_add() - only used for MASTER operation
I'm wondering why SELF operation (rocker-ndo_bridge_setlink()) does
what should be done in MASTER operation.
Toshiaki Makita
--
To unsubscribe from this list: send the line unsubscribe
On 2015/06/02 14:24, David Miller wrote:
From: Toshiaki Makita makita.toshi...@lab.ntt.co.jp
Date: Tue, 02 Jun 2015 13:51:06 +0900
On 2015/06/02 3:39, sfel...@gmail.com wrote:
From: Scott Feldman sfel...@gmail.com
Remove support for legacy ndo ops
.ndo_vlan_rx_add_vid
bytes bytes bytessecs.10^6bits/sec
87380 16384 1638460.007586.85
Rx side CPU usage:
%usr %sys %irq %soft %idle
0.50 25.83 0.00 59.53 14.14
Signed-off-by: Toshiaki Makita makita.toshi...@lab.ntt.co.jp
---
v2:
- Add compare_vlan_header
On 15/06/01 (月) 23:12, Eric Dumazet wrote:
On Mon, 2015-06-01 at 21:55 +0900, Toshiaki Makita wrote:
@@ -668,6 +753,9 @@ static int __init vlan_proto_init(void)
if (err 0)
goto err5;
+ for (i = 0; i ARRAY_SIZE(vlan_packet_offloads); i
On 2015/06/02 8:51, David Miller wrote:
From: Toshiaki Makita makita.toshi...@lab.ntt.co.jp
Date: Mon, 1 Jun 2015 21:55:06 +0900
Currently packets with non-hardware-accelerated vlan cannot be handled
by GRO. This causes low performance for 802.1ad and stacked vlan, as their
vlan tags
is different from software bridge...
Toshiaki Makita
--
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
On 15/05/28 (木) 21:02, Eric Dumazet wrote:
On Thu, 2015-05-28 at 20:17 +0900, Toshiaki Makita wrote:
Currently packets with non-hardware-accelerated vlan cannot be handled
by GRO. This causes low performance for 802.1ad and stacked vlan, as their
vlan tags are currently not stripped by hardware
bytes bytes bytessecs.10^6bits/sec
87380 16384 1638460.007586.85
Rx side CPU usage:
%usr %sys %irq %soft %idle
0.50 25.83 0.00 59.53 14.14
Signed-off-by: Toshiaki Makita makita.toshi...@lab.ntt.co.jp
---
net/8021q/vlan.c | 94
br_set_state():
- br_stp_rcv() ... - br_set_state() ... - rocker_port_attr_set()
- del_nbp() - br_stp_disable_port() - br_set_state() ...
Thanks,
Toshiaki Makita
--
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to majord...@vger.kernel.org
More majordomo info
On 2015/05/20 16:48, Simon Horman wrote:
On Wed, May 20, 2015 at 03:15:23PM +0900, Toshiaki Makita wrote:
On 2015/05/20 14:48, Simon Horman wrote:
...
static void _rocker_neigh_add(struct rocker *rocker,
+ enum switchdev_trans trans,
struct
;
+ adapter-rx_ring[q_vector-rx.ring-queue_index] = NULL;
netif_napi_del(q_vector-napi);
Hi Cong Wang,
I have already sent a patch to intel's tree.
http://git.kernel.org/cgit/linux/kernel/git/jkirsher/net-queue.git/commit/?h=dev-queueid=02ac4b65689f8df824117395fd8d160c04161a7b
Toshiaki Makita
201 - 273 of 273 matches
Mail list logo
