Re: [PATCH iproute2-net 0/3] devlink: Add devlink reload action limit and stats

2020-12-01 Thread Vasundhara Volam
On Thu, Nov 26, 2020 at 4:46 PM Moshe Shemesh wrote: > > Introduce new options on devlink reload API to enable the user to select > the reload action required and constrains limits on these actions that he > may want to ensure. > > Add reload stats to show the history per reload action per limit.

Re: [net-next v3 1/2] devlink: move request_firmware out of driver

2020-11-18 Thread Vasundhara Volam
t; > * @component: the flash component to update > > * > > - * With the exception of file_name, drivers must opt-in to parameters by > > + * With the exception of fw, drivers must opt-in to parameters by > > * setting the appropriate bit in the supported_flash_update_params field > > in > > * their devlink_ops structure. > > */ > > struct devlink_flash_update_params { > > - const char *file_name; > > + const struct firmware *fw; > > const char *component; > > u32 overwrite_mask; > > }; > > diff --git a/net/core/devlink.c b/net/core/devlink.c > > index ab4b1368904f..b0121d79ac75 100644 > > --- a/net/core/devlink.c > > +++ b/net/core/devlink.c > > @@ -3429,10 +3429,12 @@ > > EXPORT_SYMBOL_GPL(devlink_flash_update_timeout_notify); > > static int devlink_nl_cmd_flash_update(struct sk_buff *skb, > > struct genl_info *info) > > { > > - struct nlattr *nla_component, *nla_overwrite_mask; > > + struct nlattr *nla_component, *nla_overwrite_mask, *nla_file_name; > > struct devlink_flash_update_params params = {}; > > struct devlink *devlink = info->user_ptr[0]; > > + const char *file_name; > > u32 supported_params; > > + int ret; > > > > if (!devlink->ops->flash_update) > > return -EOPNOTSUPP; > > @@ -3442,8 +3444,6 @@ static int devlink_nl_cmd_flash_update(struct sk_buff > > *skb, > > > > supported_params = devlink->ops->supported_flash_update_params; > > > > - params.file_name = > > nla_data(info->attrs[DEVLINK_ATTR_FLASH_UPDATE_FILE_NAME]); > > - > > nla_component = info->attrs[DEVLINK_ATTR_FLASH_UPDATE_COMPONENT]; > > if (nla_component) { > > if (!(supported_params & > > DEVLINK_SUPPORT_FLASH_UPDATE_COMPONENT)) { > > @@ -3467,7 +3467,19 @@ static int devlink_nl_cmd_flash_update(struct > > sk_buff *skb, > > params.overwrite_mask = sections.value & sections.selector; > > } > > > > - return devlink->ops->flash_update(devlink, ¶ms, info->extack); > > + nla_file_name = info->attrs[DEVLINK_ATTR_FLASH_UPDATE_FILE_NAME]; > > + file_name = nla_data(nla_file_name); > > + ret = request_firmware(¶ms.fw, file_name, devlink->dev); > > + if (ret) { > > + NL_SET_ERR_MSG_ATTR(info->extack, nla_file_name, "failed to > > locate the requested firmware file"); > > + return ret; > > + } > > + > > + ret = devlink->ops->flash_update(devlink, ¶ms, info->extack); > > + > > + release_firmware(params.fw); > > + > > + return ret; > > } > > > > static const struct devlink_param devlink_param_generic[] = { > > @@ -10225,12 +10237,16 @@ int devlink_compat_flash_update(struct net_device > > *dev, const char *file_name) > > goto out; > > } > > > > - params.file_name = file_name; > > + ret = request_firmware(¶ms.fw, file_name, devlink->dev); > > + if (ret) > > + goto out; > > > > mutex_lock(&devlink->lock); > > ret = devlink->ops->flash_update(devlink, ¶ms, NULL); > > mutex_unlock(&devlink->lock); > > > > + release_firmware(params.fw); > > + > > out: > > rtnl_lock(); > > dev_put(dev); > > Acked-by: Vasundhara Volam smime.p7s Description: S/MIME Cryptographic Signature

Re: [net-next v3 2/2] devlink: move flash end and begin to core devlink

2020-11-18 Thread Vasundhara Volam
, > ¶ms); > } > -EXPORT_SYMBOL_GPL(devlink_flash_update_end_notify); > > void devlink_flash_update_status_notify(struct devlink *devlink, > const char *status_msg, > @@ -3475,7 +3473,9 @@ static int devlink_nl_cmd_flash_update(struct sk_buff > *skb, > return ret; > } > > + devlink_flash_update_begin_notify(devlink); > ret = devlink->ops->flash_update(devlink, ¶ms, info->extack); > + devlink_flash_update_end_notify(devlink); > > release_firmware(params.fw); > > @@ -10242,7 +10242,9 @@ int devlink_compat_flash_update(struct net_device > *dev, const char *file_name) > goto out; > > mutex_lock(&devlink->lock); > + devlink_flash_update_begin_notify(devlink); > ret = devlink->ops->flash_update(devlink, ¶ms, NULL); > + devlink_flash_update_end_notify(devlink); > mutex_unlock(&devlink->lock); > > release_firmware(params.fw); > -- > 2.29.0 > Acked-by: Vasundhara Volam smime.p7s Description: S/MIME Cryptographic Signature

Re: [PATCH net-next 9/9] bnxt_en: Add stored FW version info to devlink info_get cb.

2020-10-11 Thread Vasundhara Volam
On Mon, Oct 12, 2020 at 4:01 AM Michael Chan wrote: > > On Sun, Oct 11, 2020 at 3:02 PM Jakub Kicinski wrote: > > > > On Sun, 11 Oct 2020 06:23:01 -0400 Michael Chan wrote: > > > + rc = bnxt_hwrm_nvm_get_dev_info(bp, &nvm_dev_info); > > > + if (rc) > > > + return rc; > > > > T

Re: [PATCH net-next v2 03/16] devlink: Add devlink reload limit option

2020-10-07 Thread Vasundhara Volam
On Wed, Oct 7, 2020 at 11:32 AM Moshe Shemesh wrote: > > Add reload limit to demand restrictions on reload actions. > Reload limits supported: > no_reset: No reset allowed, no down time allowed, no link flap and no > configuration is lost. > > By default reload limit is unspecified and s

[PATCH v3 ethtool] bnxt: Add Broadcom driver support.

2020-09-22 Thread Vasundhara Volam
This patch adds the initial support for parsing registers dumped by the Broadcom driver. Currently, PXP and PCIe registers are parsed. Reviewed-by: Andy Gospodarek Reviewed-by: Edwin Peer Signed-off-by: Vasundhara Volam --- v3: - Fix the memcpy to copy to the correct size variable. - Also, fix

Re: [PATCH ethtool] bnxt: Add Broadcom driver support.

2020-09-22 Thread Vasundhara Volam
On Tue, Sep 22, 2020 at 12:22 PM Michal Kubecek wrote: > > On Tue, Sep 22, 2020 at 11:24:24AM +0530, Vasundhara Volam wrote: > > On Mon, Sep 21, 2020 at 2:48 PM Michal Kubecek wrote: > > > > + return -1; > > > > + } > > > >

[PATCH v2 ethtool] bnxt: Add Broadcom driver support.

2020-09-21 Thread Vasundhara Volam
This patch adds the initial support for parsing registers dumped by the Broadcom driver. Currently, PXP and PCIe registers are parsed. Reviewed-by: Andy Gospodarek Reviewed-by: Edwin Peer Signed-off-by: Vasundhara Volam --- v2: - Fix format specifiers in bnxt_pcie_stats[] array. - Use width

Re: [PATCH ethtool] bnxt: Add Broadcom driver support.

2020-09-21 Thread Vasundhara Volam
On Mon, Sep 21, 2020 at 6:11 PM Andrew Lunn wrote: > > > +struct bnxt_pcie_stat { > > + const char *name; > > + u16 offset; > > + u8 size; > > + const char *format; > > +}; > > + > > +static const struct bnxt_pcie_stat bnxt_pcie_stats[] = { > > + { .name = "PL Signal integrity

Re: [PATCH ethtool] bnxt: Add Broadcom driver support.

2020-09-21 Thread Vasundhara Volam
On Mon, Sep 21, 2020 at 2:48 PM Michal Kubecek wrote: > > On Mon, Sep 21, 2020 at 12:09:51PM +0530, Vasundhara Volam wrote: > > This patch adds the initial support for parsing registers dumped > > by the Broadcom driver. Currently, PXP and PCIe registers are > > parsed. &

[PATCH ethtool] bnxt: Add Broadcom driver support.

2020-09-20 Thread Vasundhara Volam
This patch adds the initial support for parsing registers dumped by the Broadcom driver. Currently, PXP and PCIe registers are parsed. Reviewed-by: Andy Gospodarek Reviewed-by: Edwin Peer Signed-off-by: Vasundhara Volam --- Makefile.am | 2 +- bnxt.c | 86

Re: [PATCH net-next RFC v4 01/15] devlink: Add reload action option to devlink reload command

2020-09-14 Thread Vasundhara Volam
On Mon, Sep 14, 2020 at 3:02 PM Jiri Pirko wrote: > > Mon, Sep 14, 2020 at 09:08:58AM CEST, vasundhara-v.vo...@broadcom.com wrote: > >On Mon, Sep 14, 2020 at 11:39 AM Moshe Shemesh wrote: > > [...] > > > >> @@ -1126,15 +1126,24 @@ mlxsw_devlink_core_bus_device_reload_down(struct > >> devlink *de

Re: [PATCH net-next RFC v4 01/15] devlink: Add reload action option to devlink reload command

2020-09-14 Thread Vasundhara Volam
On Mon, Sep 14, 2020 at 11:39 AM Moshe Shemesh wrote: > > Add devlink reload action to allow the user to request a specific reload > action. The action parameter is optional, if not specified then devlink > driver re-init action is used (backward compatible). > Note that when required to do firmwa

Re: [PATCH net-next RFC v3 01/14] devlink: Add reload action option to devlink reload command

2020-09-09 Thread Vasundhara Volam
On Wed, Sep 9, 2020 at 10:51 PM Moshe Shemesh wrote: > > > On 9/7/2020 8:58 PM, Jakub Kicinski wrote: > > On Mon, 7 Sep 2020 16:46:01 +0300 Moshe Shemesh wrote: > >>> In that sense I don't like --live because it doesn't really say much. > >>> AFAIU it means 1) no link flap; 2) < 2 sec datapath dow

Re: Failing to attach bond(created with two interfaces from different NICs) to a bridge

2020-09-07 Thread Vasundhara Volam
Thu, Sep 03, 2020 at 12:14:28PM -0700, Jakub Kicinski wrote: > > > > > On Thu, 3 Sep 2020 12:52:25 +0530 Vasundhara Volam wrote: > > > > > > Hello Jiri, > > > > > > > > > > > > After the following set of upstream comm

Re: Failing to attach bond(created with two interfaces from different NICs) to a bridge

2020-09-06 Thread Vasundhara Volam
On Fri, Sep 4, 2020 at 12:44 AM Jakub Kicinski wrote: > > On Thu, 3 Sep 2020 12:52:25 +0530 Vasundhara Volam wrote: > > Hello Jiri, > > > > After the following set of upstream commits, the user fails to attach > > a bond to the bridge, if the user creates the bon

Failing to attach bond(created with two interfaces from different NICs) to a bridge

2020-09-03 Thread Vasundhara Volam
Hello Jiri, After the following set of upstream commits, the user fails to attach a bond to the bridge, if the user creates the bond with two interfaces from different bnxt_en NICs. Previously bnxt_en driver does not advertise the switch_id for legacy mode as part of ndo_get_port_parent_id cb but

Re: [PATCH net-next RFC 00/13] Add devlink reload level option

2020-08-12 Thread Vasundhara Volam
On Wed, Aug 5, 2020 at 1:51 PM Moshe Shemesh wrote: > > > On 8/5/2020 9:55 AM, Vasundhara Volam wrote: > > On Wed, Aug 5, 2020 at 12:02 PM Moshe Shemesh wrote: > >> > >> On 8/4/2020 1:13 PM, Vasundhara Volam wrote: > >>> On Mon, Aug 3, 2020 at 7:23

Re: [PATCH net-next RFC 00/13] Add devlink reload level option

2020-08-04 Thread Vasundhara Volam
On Wed, Aug 5, 2020 at 12:02 PM Moshe Shemesh wrote: > > > On 8/4/2020 1:13 PM, Vasundhara Volam wrote: > > On Mon, Aug 3, 2020 at 7:23 PM Moshe Shemesh wrote: > >> > >> On 8/3/2020 3:47 PM, Vasundhara Volam wrote: > >>> On Mon, Aug 3, 2020 at 5:47

Re: [PATCH net-next RFC 00/13] Add devlink reload level option

2020-08-04 Thread Vasundhara Volam
On Mon, Aug 3, 2020 at 7:23 PM Moshe Shemesh wrote: > > > On 8/3/2020 3:47 PM, Vasundhara Volam wrote: > > On Mon, Aug 3, 2020 at 5:47 PM Moshe Shemesh wrote: > >> > >> On 8/3/2020 1:24 PM, Vasundhara Volam wrote: > >>> On Tue, Jul 28

Re: [PATCH net-next RFC 00/13] Add devlink reload level option

2020-08-03 Thread Vasundhara Volam
On Mon, Aug 3, 2020 at 5:47 PM Moshe Shemesh wrote: > > > On 8/3/2020 1:24 PM, Vasundhara Volam wrote: > > On Tue, Jul 28, 2020 at 10:13 PM Jacob Keller > > wrote: > >> > >> > >> On 7/27/2020 10:25 PM, Vasundhara Volam wrote: > >&

Re: [PATCH net-next RFC 00/13] Add devlink reload level option

2020-08-03 Thread Vasundhara Volam
On Tue, Jul 28, 2020 at 10:13 PM Jacob Keller wrote: > > > > On 7/27/2020 10:25 PM, Vasundhara Volam wrote: > > On Mon, Jul 27, 2020 at 4:36 PM Moshe Shemesh wrote: > >> > >> Introduce new option on devlink reload API to enable the user to select the > >

[PATCH v3 iproute2-next] devlink: Add board.serial_number to info subcommand.

2020-07-31 Thread Vasundhara Volam
"16D7", "asic.rev": "1" }, "running": { "fw": "216.1.216.0", "fw.psid": "0.0.0", "fw.mgmt": "216.1.192.0",

Re: [PATCH net-next RFC 00/13] Add devlink reload level option

2020-07-27 Thread Vasundhara Volam
On Mon, Jul 27, 2020 at 4:36 PM Moshe Shemesh wrote: > > Introduce new option on devlink reload API to enable the user to select the > reload level required. Complete support for all levels in mlx5. > The following reload levels are supported: > driver: Driver entities re-instantiation only. >

Re: [RFC v2 net-next] devlink: Add reset subcommand.

2020-07-21 Thread Vasundhara Volam
--- > >> >> >1. single - single host. > >> >> >2. multi - Multi host. > >> >> > > >> >> >mode: > >> >> >- > >> >> >1. deferred - Reset will happen after unloading all the host drivers &

Re: [RFC PATCH net-next 6/6] ice: implement devlink parameters to control flash update

2020-07-09 Thread Vasundhara Volam
On Fri, Jul 10, 2020 at 5:56 AM Jakub Kicinski wrote: > > On Thu, 9 Jul 2020 14:26:52 -0700 Jacob Keller wrote: > > The flash update for the ice hardware currently supports a single fixed > > configuration: > > > > * Firmware is always asked to preserve all changeable fields > > * The driver neve

Re: [PATCH v2 iproute2-next] devlink: Add board.serial_number to info subcommand.

2020-07-08 Thread Vasundhara Volam
On Wed, Jul 8, 2020 at 5:05 PM Jiri Pirko wrote: > > Wed, Jul 08, 2020 at 11:40:12AM CEST, vasundhara-v.vo...@broadcom.com wrote: > >On Sun, Jul 5, 2020 at 11:33 PM Stephen Hemminger > > wrote: > >> > >> On Mon, 29 Jun 2020 13:13:04 +0530 > >> Vasundh

Re: [PATCH v2 iproute2-next] devlink: Add board.serial_number to info subcommand.

2020-07-08 Thread Vasundhara Volam
On Sun, Jul 5, 2020 at 11:33 PM Stephen Hemminger wrote: > > On Mon, 29 Jun 2020 13:13:04 +0530 > Vasundhara Volam wrote: > > > Add support for reading board serial_number to devlink info > > subcommand. Example: > > > > $ devlink dev info pci/

Re: [RFC v2 net-next] devlink: Add reset subcommand.

2020-07-01 Thread Vasundhara Volam
e - single host. > >> >> >2. multi - Multi host. > >> >> > > >> >> >mode: > >> >> >- > >> >> >1. deferred - Reset will happen after unloading all the host drivers > >> >> >

Re: [RFC v2 net-next] devlink: Add reset subcommand.

2020-07-01 Thread Vasundhara Volam
rs > >> > on the device. This is be default reset type, if user > >> > does not specify the type. > >> >2. live - Reset will happen immediately with all host drivers loaded > >> > in real time. If the live res

Re: [RFC v2 net-next] devlink: Add reset subcommand.

2020-06-30 Thread Vasundhara Volam
This patch is a proposal in continuation to discussion to the > >following thread: > > > >"[PATCH v3 net-next 0/6] bnxt_en: Add 'enable_live_dev_reset' and > >'allow_live_dev_reset' generic devlink params." > > > >and here is

[RFC v2 net-next] devlink: Add reset subcommand.

2020-06-30 Thread Vasundhara Volam
reset' and 'allow_live_dev_reset' generic devlink params." and here is the URL to the patch series: https://patchwork.ozlabs.org/project/netdev/list/?series=180426&state=* If the proposal looks good, I will re-send the whole patchset including devlink changes and driver usage. Signed-off

Re: [RFC net-next] devlink: Add reset subcommand.

2020-06-29 Thread Vasundhara Volam
On Mon, Jun 29, 2020 at 7:21 PM Jiri Pirko wrote: > > Tue, Jun 23, 2020 at 01:32:49PM CEST, vasundhara-v.vo...@broadcom.com wrote: > >Advanced NICs support live reset of some of the hardware > >components, that resets the device immediately with all the > >host drivers loaded. > > > >Add devlink r

Re: [RFC net-next] devlink: Add reset subcommand.

2020-06-23 Thread Vasundhara Volam
On Wed, Jun 24, 2020 at 2:26 AM Michal Kubecek wrote: > > On Tue, Jun 23, 2020 at 05:02:49PM +0530, Vasundhara Volam wrote: > > Advanced NICs support live reset of some of the hardware > > components, that resets the device immediately with all the > > host drivers loa

[RFC net-next] devlink: Add reset subcommand.

2020-06-23 Thread Vasundhara Volam
ozlabs.org/project/netdev/list/?series=180426&state=* If the proposal looks good, I will re-send the whole patchset including devlink changes and driver usage. Signed-off-by: Vasundhara Volam Reviewed-by: Michael Chan --- Documentation/networking/devlink/devlink-reset.rst | 56 +++

[PATCH v2 net-next 1/2] devlink: Add support for board.serial_number to info_get cb.

2020-06-20 Thread Vasundhara Volam
Board serial number is a serial number, often available in PCI *Vital Product Data*. Also, update devlink-info.rst documentation file. Cc: Jiri Pirko Cc: Jakub Kicinski Signed-off-by: Vasundhara Volam Reviewed-by: Michael Chan Reviewed-by: Jiri Pirko --- v2: Modify board_serial_number to

[PATCH v2 net-next 0/2] devlink: Add board.serial_number field to info_get cb.

2020-06-20 Thread Vasundhara Volam
board.serial_number for maintaining consistency. - Combine 2 lines in second patchset as column limit is 100 now --- Vasundhara Volam (2): devlink: Add support for board.serial_number to info_get cb. bnxt_en: Add board.serial_number field to info_get cb Documentation/networking/devlink/devlink-info.rst | 12

[PATCH v2 net-next 2/2] bnxt_en: Add board.serial_number field to info_get cb

2020-06-20 Thread Vasundhara Volam
Add board.serial_number field info to info_get cb via devlink, if driver can fetch the information from the device. Cc: Jiri Pirko Cc: Jakub Kicinski Signed-off-by: Vasundhara Volam Reviewed-by: Michael Chan --- v2: Combine 2 lines as column limit is increased to 100 now. --- drivers/net

Re: [PATCH net-next 2/2] bnxt_en: Add board_serial_number field to info_get cb

2020-06-20 Thread Vasundhara Volam
i Pirko > >Cc: Jakub Kicinski > >Signed-off-by: Vasundhara Volam > >Reviewed-by: Michael Chan > >--- > > drivers/net/ethernet/broadcom/bnxt/bnxt_devlink.c | 7 +++ > > 1 file changed, 7 insertions(+) > > > >diff --git a/drivers/net/

Re: [PATCH net-next 0/2] devlink: Add board_serial_number field to info_get cb.

2020-06-20 Thread Vasundhara Volam
ify it as board.serial_number in iproute patch. > > > >asic.id 16D7 > >asic.rev 1 > > running: > >fw 216.1.216.0 > > fw.psid 0.0.0 > >fw.mgmt 216.1.192.0 > >fw.mgmt.api 1.10.1 > >fw.ncsi 0.0.0.0

[PATCH net-next 1/2] devlink: Add support for board_serial_number to info_get cb.

2020-06-20 Thread Vasundhara Volam
Board serial number is a serial number, often available in PCI *Vital Product Data*. Also, update devlink-info.rst documentation file. Cc: Jiri Pirko Cc: Jakub Kicinski Signed-off-by: Vasundhara Volam Reviewed-by: Michael Chan --- Documentation/networking/devlink/devlink-info.rst | 12

[PATCH net-next 0/2] devlink: Add board_serial_number field to info_get cb.

2020-06-20 Thread Vasundhara Volam
: fixed: board.id 7339763 Rev 0. asic.id 16D7 asic.rev 1 running: fw 216.1.216.0 fw.psid 0.0.0 fw.mgmt 216.1.192.0 fw.mgmt.api 1.10.1 fw.ncsi 0.0.0.0 fw.roce 216.1.16.0 Vasundhara Volam (2): devlink: Add support for

[PATCH net-next 2/2] bnxt_en: Add board_serial_number field to info_get cb

2020-06-20 Thread Vasundhara Volam
Add board_serial_number field info to info_get cb via devlink, if driver can fetch the information from the device. Cc: Jiri Pirko Cc: Jakub Kicinski Signed-off-by: Vasundhara Volam Reviewed-by: Michael Chan --- drivers/net/ethernet/broadcom/bnxt/bnxt_devlink.c | 7 +++ 1 file changed, 7

Re: [PATCH v3 net-next 0/6] bnxt_en: Add 'enable_live_dev_reset' and 'allow_live_dev_reset' generic devlink params.

2020-06-06 Thread Vasundhara Volam
On Mon, Jun 1, 2020 at 9:01 PM Vasundhara Volam wrote: > > On Mon, Jun 1, 2020 at 3:34 PM Jiri Pirko wrote: > > > > Mon, Jun 01, 2020 at 10:58:09AM CEST, vasundhara-v.vo...@broadcom.com wrote: > > >On Mon, Jun 1, 2020 at 12:13 PM Jiri Pirko wrote: > > >>

Re: [PATCH v3 net-next 0/6] bnxt_en: Add 'enable_live_dev_reset' and 'allow_live_dev_reset' generic devlink params.

2020-06-01 Thread Vasundhara Volam
aviour). This will be default, if the user does not provide the type option. fw-reset - Initiate the reset command for the currently running firmware and wait for the driver reload for completing the reset. (This is similar to the legacy "ethtool --reset all" command). live-fw-reset - Reset

Re: [PATCH v3 net-next 0/6] bnxt_en: Add 'enable_live_dev_reset' and 'allow_live_dev_reset' generic devlink params.

2020-06-01 Thread Vasundhara Volam
On Mon, Jun 1, 2020 at 3:28 PM Jiri Pirko wrote: > > Sun, May 31, 2020 at 09:03:39AM CEST, vasundhara-v.vo...@broadcom.com wrote: > > [...] > > > Documentation/networking/devlink/bnxt.rst | 4 ++ > > .../networking/devlink/devlink-params.rst | 28 ++ > > drivers/net/ethern

Re: [PATCH v3 net-next 0/6] bnxt_en: Add 'enable_live_dev_reset' and 'allow_live_dev_reset' generic devlink params.

2020-06-01 Thread Vasundhara Volam
emporarily. It just not only indicate the support but user can configure it to control the "live reset" at runtime. > > > > > >> > >> I think that you can do the indication in a follow-up patchset. But > >> please remove it from this one where

Re: [PATCH v2 net-next 1/4] devlink: Add new "allow_fw_live_reset" generic device parameter.

2020-06-01 Thread Vasundhara Volam
; >> >> >> >> >> >Add a new "allow_fw_live_reset" generic device bool > >> >> >> >> >> >parameter. When > >> >> >> >> >> >parameter is set, user is allowed to reset the firmware in >

Re: [PATCH v2 net-next 1/4] devlink: Add new "allow_fw_live_reset" generic device parameter.

2020-06-01 Thread Vasundhara Volam
gt; >> >On Wed, May 27, 2020 at 1:14 PM Jakub Kicinski wrote: > >> >> > >> >> On Wed, 27 May 2020 09:07:09 +0530 Vasundhara Volam wrote: > >> >> > Here is a sample sequence of commands to do a "live reset" to get some

Re: [PATCH v3 net-next 0/6] bnxt_en: Add 'enable_live_dev_reset' and 'allow_live_dev_reset' generic devlink params.

2020-06-01 Thread Vasundhara Volam
documentation of each param and update commit messages > >> accordingly. > >>- Separated the permanent configuration mode code to another patch and > >>rename the callbacks of the "allow_live_dev_reset" parameter accordingly. > >> > >

Re: [PATCH v2 net-next 1/4] devlink: Add new "allow_fw_live_reset" generic device parameter.

2020-06-01 Thread Vasundhara Volam
ot; generic device bool parameter. > >> >> >> >> >When > >> >> >> >> >parameter is set, user is allowed to reset the firmware in real > >> >> >> >> >time. > >> >> >&

Re: [PATCH v2 net-next 1/4] devlink: Add new "allow_fw_live_reset" generic device parameter.

2020-06-01 Thread Vasundhara Volam
On Mon, Jun 1, 2020 at 12:09 PM Jiri Pirko wrote: > > Wed, May 27, 2020 at 10:57:11PM CEST, michael.c...@broadcom.com wrote: > >On Wed, May 27, 2020 at 1:14 PM Jakub Kicinski wrote: > >> > >> On Wed, 27 May 2020 09:07:09 +0530 Vasundhara Volam wrote: > >>

[PATCH v3 net-next 6/6] bnxt_en: Check if fw_live_reset is allowed before doing ETHTOOL_RESET

2020-05-31 Thread Vasundhara Volam
If device does not allow fw_live_reset, issue FW_RESET command without graceful flag, which requires a driver reload to reset the firmware. Signed-off-by: Vasundhara Volam Signed-off-by: Michael Chan Reviewed-by: Edwin Peer --- drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c | 17

[PATCH v3 net-next 5/6] bnxt_en: Use 'allow_live_dev_reset' devlink parameter.

2020-05-31 Thread Vasundhara Volam
. Signed-off-by: Vasundhara Volam Signed-off-by: Michael Chan --- v2->v3: Rename parameter name to "allow_live_dev_reset". - Moved permanent configuration mode code to a separate patch as the param is renamed to "enable_live_dev_reset". - Rename the get/set callbacks of the par

[PATCH v3 net-next 3/6] bnxt_en: Use 'enable_live_dev_reset' devlink parameter.

2020-05-31 Thread Vasundhara Volam
When enabled, device will enable the live reset capability in NVRAM configuration. Signed-off-by: Vasundhara Volam Signed-off-by: Michael Chan --- Documentation/networking/devlink/bnxt.rst | 2 ++ drivers/net/ethernet/broadcom/bnxt/bnxt_devlink.c | 6 ++ drivers/net/ethernet

[PATCH v3 net-next 2/6] devlink: Add 'allow_live_dev_reset' generic parameter.

2020-05-31 Thread Vasundhara Volam
n set this parameter to false, to avoid a potential live reset from disrupting it. Cc: Jiri Pirko Cc: Jakub Kicinski Signed-off-by: Vasundhara Volam Signed-off-by: Michael Chan --- Documentation/networking/devlink/devlink-params.rst | 20 include/net

[PATCH v3 net-next 4/6] bnxt_en: Update firmware spec. to 1.10.1.40.

2020-05-31 Thread Vasundhara Volam
Major changes are to add additional flags to configure hot firmware reset. Signed-off-by: Vasundhara Volam Signed-off-by: Michael Chan Reviewed-by: Edwin Peer --- drivers/net/ethernet/broadcom/bnxt/bnxt_hsi.h | 64 --- 1 file changed, 37 insertions(+), 27 deletions

[PATCH v3 net-next 0/6] bnxt_en: Add 'enable_live_dev_reset' and 'allow_live_dev_reset' generic devlink params.

2020-05-31 Thread Vasundhara Volam
cks of the "allow_live_dev_reset" parameter accordingly. v1->v2: Rename param to "allow_fw_live_reset" from "enable_hot_fw_reset". - Update documentation files and commit messages with more details of the feature. Vasundhara Volam (6): devlink: Add 'enable

[PATCH v3 net-next 1/6] devlink: Add 'enable_live_dev_reset' generic parameter.

2020-05-31 Thread Vasundhara Volam
b Kicinski Signed-off-by: Vasundhara Volam Signed-off-by: Michael Chan --- Documentation/networking/devlink/devlink-params.rst | 8 include/net/devlink.h | 4 net/core/devlink.c | 5 + 3 files changed, 17 insertions(+) d

Re: [PATCH v2 net-next 1/4] devlink: Add new "allow_fw_live_reset" generic device parameter.

2020-05-29 Thread Vasundhara Volam
On Fri, May 29, 2020 at 12:35 AM Jakub Kicinski wrote: > > On Thu, 28 May 2020 07:20:00 +0530 Vasundhara Volam wrote: > > > > The permanent value should be the NVRAM value. If the NVRAM value is > > > > false, the feature is always and unconditionally disabled. If

Re: [PATCH v2 net-next 1/4] devlink: Add new "allow_fw_live_reset" generic device parameter.

2020-05-27 Thread Vasundhara Volam
On Thu, May 28, 2020 at 2:46 AM Jakub Kicinski wrote: > > On Wed, 27 May 2020 13:57:11 -0700 Michael Chan wrote: > > On Wed, May 27, 2020 at 1:14 PM Jakub Kicinski wrote: > > > On Wed, 27 May 2020 09:07:09 +0530 Vasundhara Volam wrote: > > > > Here is a sample s

Re: [PATCH v2 net-next 1/4] devlink: Add new "allow_fw_live_reset" generic device parameter.

2020-05-26 Thread Vasundhara Volam
On Tue, May 26, 2020 at 7:53 PM Vasundhara Volam wrote: > > On Tue, May 26, 2020 at 7:10 PM Jiri Pirko wrote: > > > > Tue, May 26, 2020 at 08:42:28AM CEST, vasundhara-v.vo...@broadcom.com wrote: > > >On Tue, May 26, 2020 at 10:17 AM Jiri Pirko wrote: > > >

Re: [PATCH v2 net-next 1/4] devlink: Add new "allow_fw_live_reset" generic device parameter.

2020-05-26 Thread Vasundhara Volam
er. When > >> >> >> >parameter is set, user is allowed to reset the firmware in real > >> >> >> >time. > >> >> >> > > >> >> >> >This parameter is employed to communicate user consent or dissent &g

Re: [PATCH v2 net-next 1/4] devlink: Add new "allow_fw_live_reset" generic device parameter.

2020-05-25 Thread Vasundhara Volam
eset" generic device bool parameter. When > >> >> >parameter is set, user is allowed to reset the firmware in real time. > >> >> > > >> >> >This parameter is employed to communicate user consent or dissent for > >> >> >the

Re: [PATCH v2 net-next 1/4] devlink: Add new "allow_fw_live_reset" generic device parameter.

2020-05-25 Thread Vasundhara Volam
onsent or dissent for > >> >the live reset to happen. A separate command triggers the actual live > >> >reset. > >> > > >> >Cc: Jiri Pirko > >> >Signed-off-by: Vasundhara Volam > >> >Signed-off-by: Michael C

Re: [PATCH v2 net-next 1/4] devlink: Add new "allow_fw_live_reset" generic device parameter.

2020-05-23 Thread Vasundhara Volam
time. > > > >This parameter is employed to communicate user consent or dissent for > >the live reset to happen. A separate command triggers the actual live > >reset. > > > >Cc: Jiri Pirko > >Signed-off-by: Vasundhara Volam > >Signed-off-by:

[PATCH v2 net-next 0/4] bnxt_en: Add new "allow_fw_live_reset" generic devlink parameter

2020-05-22 Thread Vasundhara Volam
live reset capability in NVRAM configuration of the device. Also, firmware spec. is updated to 1.10.1.40. v1->v2: Rename param to "allow_fw_live_reset" from "enable_hot_fw_reset". Update documentation files and commit messages with more details of the feature. Vasundhara Volam (4):

[PATCH v2 net-next 3/4] bnxt_en: Use allow_fw_live_reset generic devlink parameter

2020-05-22 Thread Vasundhara Volam
avoid a potential firmware live reset disrupting it. Signed-off-by: Vasundhara Volam Signed-off-by: Michael Chan --- v2: Update commit message. Rename devlink param name to "allow_fw_live_reset". Add more documentation for param in bnxt.rst file. --- Documentation/networking/devlin

[PATCH v2 net-next 1/4] devlink: Add new "allow_fw_live_reset" generic device parameter.

2020-05-22 Thread Vasundhara Volam
Cc: Jiri Pirko Signed-off-by: Vasundhara Volam Signed-off-by: Michael Chan --- v2: Rename param name to "allow_fw_live_reset" from "enable_hot_fw_reset". Update documentation for the param in devlink-params.rst file. --- Documentation/networking/devlink/devlink-params.rst | 6

[PATCH v2 net-next 4/4] bnxt_en: Check if fw_live_reset is allowed before doing ETHTOOL_RESET

2020-05-22 Thread Vasundhara Volam
If device does not allow fw_live_reset, issue FW_RESET command without graceful flag, which requires a driver reload to reset the firmware. Signed-off-by: Vasundhara Volam Signed-off-by: Michael Chan Reviewed-by: Edwin Peer --- v2: Rephrase the subject and elaborate commit message --- drivers

[PATCH v2 net-next 2/4] bnxt_en: Update firmware spec. to 1.10.1.40.

2020-05-22 Thread Vasundhara Volam
Major changes are to add additional flags to configure hot firmware reset. Signed-off-by: Vasundhara Volam Signed-off-by: Michael Chan Reviewed-by: Edwin Peer --- drivers/net/ethernet/broadcom/bnxt/bnxt_hsi.h | 64 --- 1 file changed, 37 insertions(+), 27 deletions

Re: [PATCH net-next 0/4] bnxt_en: Add new "enable_hot_fw_reset" generic devlink parameter

2020-05-19 Thread Vasundhara Volam
On Tue, May 19, 2020 at 3:11 PM Jiri Pirko wrote: > > Tue, May 19, 2020 at 10:41:44AM CEST, michael.c...@broadcom.com wrote: > >On Tue, May 19, 2020 at 12:30 AM Jiri Pirko wrote: > >> > >> Tue, May 19, 2020 at 07:43:01AM CEST, vasundhara-v.vo...@broadcom.com > >> wrote: > >> >On Tue, May 19, 202

Re: [PATCH net-next 0/4] bnxt_en: Add new "enable_hot_fw_reset" generic devlink parameter

2020-05-18 Thread Vasundhara Volam
On Tue, May 19, 2020 at 10:57 AM Jiri Pirko wrote: > > Tue, May 19, 2020 at 06:31:27AM CEST, vasundhara-v.vo...@broadcom.com wrote: > >On Mon, May 18, 2020 at 4:31 PM Jiri Pirko wrote: > >> > >> Mon, May 18, 2020 at 10:27:15AM CEST, vasundhara-v.vo...@broadcom.com > >> wrote: > >> >This patchset

Re: [PATCH net-next 0/4] bnxt_en: Add new "enable_hot_fw_reset" generic devlink parameter

2020-05-18 Thread Vasundhara Volam
On Mon, May 18, 2020 at 4:31 PM Jiri Pirko wrote: > > Mon, May 18, 2020 at 10:27:15AM CEST, vasundhara-v.vo...@broadcom.com wrote: > >This patchset adds support for a "enable_hot_fw_reset" generic devlink > >parameter and use it in bnxt_en driver. > > > >Also, firmware spec. is updated to 1.10.1.4

[PATCH net-next 4/4] bnxt_en: Check if hot_fw_reset is allowed before doing ETHTOOL_RESET

2020-05-18 Thread Vasundhara Volam
If device does not allow hot_fw_reset, issue firmware reset without graceful flag. Cc: Michael Chan Signed-off-by: Vasundhara Volam Reviewed-by: Edwin Peer --- drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c | 17 + 1 file changed, 9 insertions(+), 8 deletions(-) diff --git

[PATCH net-next 1/4] devlink: Add new "enable_hot_fw_reset" generic device parameter.

2020-05-18 Thread Vasundhara Volam
Add a new "enable_hot_fw_reset" generic device parameter to enable or disable hot firmware reset capability on the device. Cc: Jiri Pirko Cc: Michael Chan Signed-off-by: Vasundhara Volam Reviewed-by: Edwin Peer --- Documentation/networking/devlink/devlink-params.rst | 6 ++ i

[PATCH net-next 0/4] bnxt_en: Add new "enable_hot_fw_reset" generic devlink parameter

2020-05-18 Thread Vasundhara Volam
This patchset adds support for a "enable_hot_fw_reset" generic devlink parameter and use it in bnxt_en driver. Also, firmware spec. is updated to 1.10.1.40. Vasundhara Volam (4): devlink: Add new "enable_hot_fw_reset" generic device parameter. bnxt_en: Update firmwar

[PATCH net-next 2/4] bnxt_en: Update firmware spec. to 1.10.1.40.

2020-05-18 Thread Vasundhara Volam
Major changes are to add additional flags to configure hot firmware reset. Cc: Michael Chan Signed-off-by: Vasundhara Volam Reviewed-by: Edwin Peer --- drivers/net/ethernet/broadcom/bnxt/bnxt_hsi.h | 64 --- 1 file changed, 37 insertions(+), 27 deletions(-) diff --git

[PATCH net-next 3/4] bnxt_en: Use enable_hot_fw_reset generic devlink parameter

2020-05-18 Thread Vasundhara Volam
igned-off-by: Vasundhara Volam Reviewed-by: Edwin Peer --- Documentation/networking/devlink/bnxt.rst | 6 +++ drivers/net/ethernet/broadcom/bnxt/bnxt.c | 28 ++- drivers/net/ethernet/broadcom/bnxt/bnxt.h | 2 + drivers/net/ethernet/broadcom/bnxt/bnxt_devlink.c

[PATCH v2] bnxt_en: use new module_firmware_crashed()

2020-05-16 Thread Vasundhara Volam
annotate when this happens clearly. Cc: Luis Chamberlain Reviewed-by: Michael Chan Signed-off-by: Vasundhara Volam --- v2: Move call module_firmware_crashed() to bnxt_fw_fatal_recover(). This will optimize to make the call at one central place. Please append to the patchset: ("[PATCH v2

[PATCH] bnxt_en: use new module_firmware_crashed()

2020-05-15 Thread Vasundhara Volam
annotate when this happens clearly. Cc: Michael Chan Cc: Luis Chamberlain Signed-off-by: Vasundhara Volam --- Please append to the patchset: ("[PATCH v2 00/15] net: taint when the device driver firmware crashes") --- drivers/net/ethernet/broadcom/bnxt/bnxt.c | 2 ++ 1 file changed, 2

Re: [PATCH v2 04/15] bnxt: use new module_firmware_crashed()

2020-05-15 Thread Vasundhara Volam
ere is no crash. I will propose a patch to use this wrapper in the error recovery path, where the driver may not be able to recover. > #ifdef CONFIG_TEE_BNXT_FW > return tee_bnxt_copy_coredump(buf, 0, dump->len); > #endif > -- > 2.26.2 > Nacked-by: Vasundhara Volam

Re: [PATCH net-next v2 14/22] bnxt_en: Add new FW devlink_health_reporter

2019-10-08 Thread Vasundhara Volam
On Mon, Oct 7, 2019 at 3:26 PM Jiri Pirko wrote: > > Fri, Aug 30, 2019 at 05:54:57AM CEST, michael.c...@broadcom.com wrote: > >From: Vasundhara Volam > > > >Create new FW devlink_health_reporter, to know the current health > >status of FW. > > > >Comma

[PATCH v2 net] devlink: Fix error handling in param and info_get dumpit cb

2019-09-29 Thread Vasundhara Volam
, except for params/info_get op that return -EOPNOTSUPP as suggested by Andrew Lunn. Also, modify commit message to reflect the same. Cc: Andrew Lunn Cc: Jiri Pirko Cc: Michael Chan Signed-off-by: Vasundhara Volam --- net/core/devlink.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions

Re: [PATCH net] devlink: Fix error handling in param and info_get dumpit cb

2019-09-27 Thread Vasundhara Volam
On Fri, Sep 27, 2019 at 6:01 PM Andrew Lunn wrote: > > On Fri, Sep 27, 2019 at 10:28:36AM +0530, Vasundhara Volam wrote: > > On Thu, Sep 26, 2019 at 5:57 PM Andrew Lunn wrote: > > > > > > On Thu, Sep 26, 2019 at 03:05:54PM +0530, Vasundhara Volam wrote: > > &g

Re: [PATCH net] devlink: Fix error handling in param and info_get dumpit cb

2019-09-26 Thread Vasundhara Volam
On Thu, Sep 26, 2019 at 5:57 PM Andrew Lunn wrote: > > On Thu, Sep 26, 2019 at 03:05:54PM +0530, Vasundhara Volam wrote: > > If any of the param or info_get op returns error, dumpit cb is > > skipping to dump remaining params or info_get ops for all the > > drivers. >

[PATCH net] devlink: Fix error handling in param and info_get dumpit cb

2019-09-26 Thread Vasundhara Volam
Cc: Michael Chan Signed-off-by: Vasundhara Volam --- net/core/devlink.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/net/core/devlink.c b/net/core/devlink.c index e48680e..a1dd1b8 100644 --- a/net/core/devlink.c +++ b/net/core/devlink.c @@ -3172,7 +3172,7 @@ static

Re: [patch net-next 02/11] bnxt: add missing net/devlink.h include

2019-03-22 Thread Vasundhara Volam
On Thu, Mar 21, 2019 at 6:50 PM Jiri Pirko wrote: > > From: Jiri Pirko > > devlink functions are in use, so include the related header file. > > Signed-off-by: Jiri Pirko > --- > drivers/net/ethernet/broadcom/bnxt/bnxt_devlink.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/n

[PATCH v2 net-next] Revert "devlink: Add a generic wake_on_lan port parameter"

2019-02-11 Thread Vasundhara Volam
parameter support from bnxt_en driver. Cc: Jiri Pirko Cc: Michael Chan Cc: Michal Kubecek Suggested-by: Jakub Kicinski Signed-off-by: Vasundhara Volam --- drivers/net/ethernet/broadcom/bnxt/bnxt_devlink.c | 19 +-- drivers/net/ethernet/broadcom/bnxt/bnxt_devlink.h | 1 - include

[PATCH v2 net-next] Revert wake_on_lan devlink parameter

2019-02-11 Thread Vasundhara Volam
follow up patches to add some devlink port params for bnxt_en driver. v1->v2: Combine 2 patches into 1 patch to avoid build failures. Vasundhara Volam (1): Revert "devlink: Add a generic wake_on_lan port parameter" drivers/net/ethernet/broadcom/bnxt/bnxt_d

Re: [PATCH net-next 0/2] Revert wake_on_lan devlink parameter

2019-02-11 Thread Vasundhara Volam
On Mon, Feb 11, 2019 at 1:05 PM David Miller wrote: > > From: Vasundhara Volam > Date: Mon, 11 Feb 2019 10:09:23 +0530 > > > On Sat, Feb 9, 2019 at 12:37 PM David Miller wrote: > >> > >> From: Vasundhara Volam > >> Date: Fri, 8 Feb 2019 14:43:08 +

Re: [PATCH net-next 0/2] Revert wake_on_lan devlink parameter

2019-02-10 Thread Vasundhara Volam
On Sat, Feb 9, 2019 at 12:37 PM David Miller wrote: > > From: Vasundhara Volam > Date: Fri, 8 Feb 2019 14:43:08 +0530 > > > As per discussion with Jakub Kicinski and Michal Kubecek, > > this will be better addressed by soon-too-come ethtool netlink > > API with ad

[PATCH net-next 2/2] bnxt_en: Remove wake_on_lan parameter support for devlink

2019-02-08 Thread Vasundhara Volam
Retain the code to register devlink port parameters. There will be followup patchset to add some port parameters. Cc: Michael Chan Cc: Michal Kubecek Cc: Jakub Kicinski Signed-off-by: Vasundhara Volam --- drivers/net/ethernet/broadcom/bnxt/bnxt_devlink.c | 19 +-- drivers/net

[PATCH net-next 1/2] Revert "devlink: Add a generic wake_on_lan port parameter"

2019-02-08 Thread Vasundhara Volam
: Michal Kubecek Suggested-by: Jakub Kicinski Signed-off-by: Vasundhara Volam --- include/net/devlink.h | 8 net/core/devlink.c| 5 - 2 files changed, 13 deletions(-) diff --git a/include/net/devlink.h b/include/net/devlink.h index c12ad6e..1dfdd81 100644 --- a/include/net

[PATCH net-next 0/2] Revert wake_on_lan devlink parameter

2019-02-08 Thread Vasundhara Volam
follow up patches to add some devlink port params for bnxt_en driver. Vasundhara Volam (2): Revert "devlink: Add a generic wake_on_lan port parameter" bnxt_en: Remove wake_on_lan parameter support for devlink drivers/net/ethernet/broadcom/bnxt/bnxt_devlink.c | 19 +-

Re: [PATCH net-next v7 0/8] devlink: Add configuration parameters support for devlink_port

2019-02-06 Thread Vasundhara Volam
On Tue, Feb 5, 2019 at 10:21 PM Michal Kubecek wrote: > > On Tue, Feb 05, 2019 at 09:53:26AM +0530, Vasundhara Volam wrote: > > On Tue, Feb 5, 2019 at 8:26 AM Jakub Kicinski > > > > > > No? We were talking about using the soon-too-come ethtool netlink > > &

Re: [PATCH net-next v7 0/8] devlink: Add configuration parameters support for devlink_port

2019-02-04 Thread Vasundhara Volam
On Tue, Feb 5, 2019 at 8:26 AM Jakub Kicinski wrote: > > On Mon, 4 Feb 2019 12:25:13 +0530, Vasundhara Volam wrote: > > > > IMHO this is not really a problem. We can either use an additional flag > > > > telling kernel/driver if we are setting runtime or persistent W

Re: [PATCH net-next v7 0/8] devlink: Add configuration parameters support for devlink_port

2019-02-03 Thread Vasundhara Volam
On Wed, Jan 23, 2019 at 3:48 AM Jakub Kicinski wrote: > > On Fri, 18 Jan 2019 15:33:19 +0100, Michal Kubecek wrote: > > On Fri, Jan 18, 2019 at 12:39:37PM +0530, Vasundhara Volam wrote: > > > There is difference of opinion on adding WOL parameter to devlink, between >

Re: [PATCH net-next v8 0/8] devlink: Add configuration parameters support for devlink_port

2019-01-31 Thread Vasundhara Volam
On Thu, Jan 31, 2019 at 5:28 AM Jakub Kicinski wrote: > > On Mon, 28 Jan 2019 18:00:19 +0530, Vasundhara Volam wrote: > > This patchset adds support for configuration parameters setting through > > devlink_port. Each device registers supported configuration parameters > >

[PATCH net-next v8 2/8] devlink: Add port param get command

2019-01-28 Thread Vasundhara Volam
Add port param get command which gets data per parameter. It also has option to dump the parameters data per port. v7->v8: Append "Acked-by: Jiri Pirko " Cc: Jiri Pirko Signed-off-by: Vasundhara Volam Acked-by: Jiri Pirko --- include/uapi/linux/devlink.h | 2 + net/c

  1   2   3   >