Re: [PATCH/.24] [NET] fs_enet: check for phydev existence in the ethtool handlers

2007-12-20 Thread Vitaly Bordug
-by: Anton Vorontsov [EMAIL PROTECTED] Acked-by: Vitaly Bordug [EMAIL PROTECTED] Jeff: this fix is important and should be merged if possible. --- drivers/net/fs_enet/fs_enet-main.c | 11 +-- 1 files changed, 9 insertions(+), 2 deletions(-) diff --git a/drivers/net/fs_enet/fs_enet-main.c

Re: [PATCH/RFC] [POWERPC] Add fixed-phy support for fs_enet

2007-12-18 Thread Vitaly Bordug
On Mon, 17 Dec 2007 18:20:14 -0500 Jeff Garzik wrote: Jochen Friedrich wrote: This patch adds support to use the fixed-link property of an ethernet node to fs_enet for the CONFIG_PPC_CPM_NEW_BINDING case. Signed-off-by: Jochen Friedrich [EMAIL PROTECTED] Acked-by: Vitaly Bordug [EMAIL

[PATCH 2/3] [POWERPC] fsl_soc: add support for gianfar for fixed-link property

2007-12-06 Thread Vitaly Bordug
fixed-link says: register new Fixed/emulated PHY, i.e. PHY that not connected to the real MDIO bus. Signed-off-by: Vitaly Bordug [EMAIL PROTECTED] Signed-off-by: Anton Vorontsov [EMAIL PROTECTED] --- Documentation/powerpc/booting-without-of.txt |4 + arch/powerpc/sysdev/fsl_soc.c

[PATCH 3/3] [POWERPC] MPC8349E-mITX: Vitesse 7385 PHY is not connected to the MDIO bus

2007-12-06 Thread Vitaly Bordug
...thus use fixed-link to register proper Fixed PHY Signed-off-by: Anton Vorontsov [EMAIL PROTECTED] Signed-off-by: Vitaly Bordug [EMAIL PROTECTED] --- arch/powerpc/boot/dts/mpc8349emitx.dts | 11 ++- 1 files changed, 2 insertions(+), 9 deletions(-) diff --git a/arch/powerpc/boot

[PATCH 1/3] [NET] phy/fixed.c: rework to not duplicate PHY layer functionality

2007-12-06 Thread Vitaly Bordug
on the platform fixed MDIO bus. There is also no more need to pre-allocate PHYs via .config option, this is all now handled dynamically. Signed-off-by: Anton Vorontsov [EMAIL PROTECTED] Signed-off-by: Vitaly Bordug [EMAIL PROTECTED] Acked-by: Jeff Garzik [EMAIL PROTECTED] --- drivers/net/phy/Kconfig

Re: [PATCH 1/3] [NET] phy/fixed.c: rework to not duplicate PHY layer functionality

2007-12-04 Thread Vitaly Bordug
On Tue, 04 Dec 2007 15:07:49 -0500 Jeff Garzik wrote: Vitaly Bordug wrote: With that patch fixed.c now fully emulates MDIO bus, thus no need to duplicate PHY layer functionality. That, in turn, drastically simplifies the code, and drops down line count. As an additional bonus, now

Re: [PATCH 1/3] [NET] phy/fixed.c: rework to not duplicate PHY layer functionality

2007-12-01 Thread Vitaly Bordug
On Sat, 01 Dec 2007 14:48:54 +0100 Jochen Friedrich wrote: Hi Vitaly, With that patch fixed.c now fully emulates MDIO bus, thus no need to duplicate PHY layer functionality. That, in turn, drastically simplifies the code, and drops down line count. As an additional bonus, now there

Re: [PATCH 1/3] [NET] phy/fixed.c: rework to not duplicate PHY layer functionality

2007-12-01 Thread Vitaly Bordug
On Sat, 01 Dec 2007 16:59:52 -0500 Jeff Garzik wrote: Vitaly Bordug wrote: With that patch fixed.c now fully emulates MDIO bus, thus no need to duplicate PHY layer functionality. That, in turn, drastically simplifies the code, and drops down line count. As an additional bonus, now

Re: [PATCH 1/3] [NET] phy/fixed.c: rework to not duplicate PHY layer functionality

2007-12-01 Thread Vitaly Bordug
On Sun, 2 Dec 2007 00:34:03 +0300 Anton Vorontsov wrote: If i understand your code correctly, you seem to rely on the fact that fixed_phy_add() is called before the fixed MDIO bus is scanned for devices. Yes, indeed. The other name of fixed phys are platform phys or platform MDIO bus

[PATCH 1/3] [NET] phy/fixed.c: rework to not duplicate PHY layer functionality

2007-11-26 Thread Vitaly Bordug
-off-by: Vitaly Bordug [EMAIL PROTECTED] --- drivers/net/phy/Kconfig | 32 +-- drivers/net/phy/fixed.c | 427 - include/linux/phy_fixed.h | 49 ++--- 3 files changed, 176 insertions(+), 332 deletions(-) diff --git a/drivers/net/phy/Kconfig b

[PATCH 2/3] [POWERPC] fsl_soc: add support for gianfar for fixed-link property

2007-11-26 Thread Vitaly Bordug
fixed-link says: register new Fixed/emulated PHY, i.e. PHY that not connected to the real MDIO bus. Signed-off-by: Vitaly Bordug [EMAIL PROTECTED] Signed-off-by: Anton Vorontsov [EMAIL PROTECTED] --- Documentation/powerpc/booting-without-of.txt |3 + arch/powerpc/sysdev/fsl_soc.c

[PATCH 3/3] [POWERPC] MPC8349E-mITX: Vitesse 7385 PHY is not connected to the MDIO bus

2007-11-26 Thread Vitaly Bordug
...thus use fixed-link to register proper Fixed PHY Signed-off-by: Anton Vorontsov [EMAIL PROTECTED] Signed-off-by: Vitaly Bordug [EMAIL PROTECTED] --- arch/powerpc/boot/dts/mpc8349emitx.dts | 11 ++- 1 files changed, 2 insertions(+), 9 deletions(-) diff --git a/arch/powerpc/boot

Re: [PATCH] fs_enet: Update for API changes

2007-10-17 Thread Vitaly Bordug
, thanks! Jeff: this is important fix, and should be applied if possible. These changes have been fixed, and napi is now on by default. Signed-off-by: Scott Wood [EMAIL PROTECTED] Acked-by: Vitaly Bordug [EMAIL PROTECTED] --- drivers/net/fs_enet/fs_enet-main.c | 28

[PATCH 1/2] [FS_ENET] TX stuff should use fep-tx_lock, instead of fep-lock.

2007-09-18 Thread Vitaly Bordug
Signed-off-by: Vitaly Bordug [EMAIL PROTECTED] --- drivers/net/fs_enet/fs_enet-main.c |6 -- 1 files changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/net/fs_enet/fs_enet-main.c b/drivers/net/fs_enet/fs_enet-main.c index a4a2a0e..927cd9e 100644 --- a/drivers/net/fs_enet

[PATCH 2/2] [FS_ENET] Add polling support

2007-09-18 Thread Vitaly Bordug
Signed-off-by: Vitaly Bordug [EMAIL PROTECTED] --- drivers/net/fs_enet/fs_enet-main.c | 16 1 files changed, 16 insertions(+), 0 deletions(-) diff --git a/drivers/net/fs_enet/fs_enet-main.c b/drivers/net/fs_enet/fs_enet-main.c index 927cd9e..0e2d2b2 100644 --- a/drivers

Re: [PATCH 6/7 v2] fs_enet: Be an of_platform device when CONFIG_PPC_CPM_NEW_BINDING is set.

2007-08-22 Thread Vitaly Bordug
On Tue, 21 Aug 2007 11:47:41 -0500 Scott Wood [EMAIL PROTECTED] wrote: Vitaly Bordug wrote: On Fri, 17 Aug 2007 13:17:18 -0500 Scott Wood wrote: The existing OF glue code was crufty and broken. Rather than fix it, it will be removed, and the ethernet driver now talks to the device

Re: [PATCH 2/7] fs_enet: Whitespace cleanup.

2007-08-22 Thread Vitaly Bordug
On Fri, 17 Aug 2007 12:53:59 -0500 Scott Wood wrote: Signed-off-by: Scott Wood [EMAIL PROTECTED] Acked-by: Vitaly Bordug [EMAIL PROTECTED] --- drivers/net/fs_enet/fs_enet-main.c | 85 --- drivers/net/fs_enet/fs_enet.h |4 +- drivers/net/fs_enet

Re: [PATCH 4/7] fs_enet: mac-fcc: Eliminate __fcc-* macros.

2007-08-22 Thread Vitaly Bordug
On Fri, 17 Aug 2007 12:54:02 -0500 Scott Wood wrote: These macros accomplish nothing other than defeating type checking. This patch also fixes one instance of the wrong register size being used that was revealed by enabling type checking. Signed-off-by: Scott Wood [EMAIL PROTECTED] ---

Re: [PATCH 6/7 v2] fs_enet: Be an of_platform device when CONFIG_PPC_CPM_NEW_BINDING is set.

2007-08-21 Thread Vitaly Bordug
On Fri, 17 Aug 2007 13:17:18 -0500 Scott Wood wrote: The existing OF glue code was crufty and broken. Rather than fix it, it will be removed, and the ethernet driver now talks to the device tree directly. A bit short description, I'd rather expect some specific improvements list, that are

[PATCH 1/2] [POWERPC] Add support of platforms without PHY to gianfar driver

2007-07-25 Thread Vitaly Bordug
is in form duplexity speed Signed-off-by: Vitaly Bordug [EMAIL PROTECTED] --- arch/powerpc/sysdev/fsl_soc.c | 39 +++ drivers/net/gianfar.c | 17 ++--- 2 files changed, 37 insertions(+), 19 deletions(-) diff --git a/arch/powerpc

[PATCH 2/2] [POWERPC] Remove dummy network phy from MPC8313E-RDB

2007-07-25 Thread Vitaly Bordug
Cleaned up inexistent network phy from the target dts, added necessary property to gianfar node there. Signed-off-by: Vitaly Bordug [EMAIL PROTECTED] --- arch/powerpc/boot/dts/mpc8313erdb.dts |8 +--- 1 files changed, 1 insertions(+), 7 deletions(-) diff --git a/arch/powerpc/boot/dts

Re: [PATCH] [updated] PHY fixed driver: rework release path and update phy_id notation

2007-07-20 Thread Vitaly Bordug
On Thu, 19 Jul 2007 23:23:37 -0700 Andrew Morton wrote: On Thu, 19 Jul 2007 03:38:04 +0400 Vitaly Bordug [EMAIL PROTECTED] wrote: device_bind_driver() error code returning has been fixed. release() function has been written, so that to free resources in correct way; the release

[PATCH] [updated] PHY fixed driver: rework release path and update phy_id notation

2007-07-18 Thread Vitaly Bordug
changed the notation of the fixed phy definition on mdio bus to the form of speed+duplex to make it able to be used by gianfar and ucc_geth that define phy_id strictly as %d:%d and cleaned up the whitespace issues. Signed-off-by: Vitaly Bordug [EMAIL PROTECTED] --- drivers/net/phy/Kconfig | 14

[PATCH] PHY fixed driver: rework release path and update phy_id notation

2007-07-16 Thread Vitaly Bordug
changed the notation of the fixed phy definition on mdio bus to the form of speed+duplex to make it able to be used by gianfar and ucc_geth that define phy_id strictly as %d:%d and cleaned up the whitespace issues. Signed-off-by: Vitaly Bordug [EMAIL PROTECTED] --- drivers/net/phy/Kconfig | 14

Re: [PATCH] MII bitbang driver should generate MII bus phy_mask dynamically

2007-06-11 Thread Vitaly Bordug
by the platform. Signed-off-by: Mark Zhan [EMAIL PROTECTED] Acked-by: Vitaly Bordug [EMAIL PROTECTED] --- b/drivers/net/fs_enet/mii-bitbang.c |9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/drivers/net/fs_enet/mii-bitbang.c b/drivers/net/fs_enet/mii-bitbang.c

Re: [PATCH] MII bitbang driver should generate MII bus phy_mask dynamically

2007-06-11 Thread Vitaly Bordug
On Mon, Jun 11, 2007 at 03:53:37PM +0800, Mark Zhan wrote: Current MII bitbang bus driver hard-codes the phy mask of mii_bus to ~0x09, which is actually specific to the FSL boards. This patch will make the bitbang driver to generate MII bus phy_mask dynamically, by the PHY irq info provided by

[PATCH] PHY fixed driver: rework release path and update phy_id notation

2007-06-09 Thread Vitaly Bordug
of the fixed phy definition on mdio bus to the form of speed+duplex to make it able to be used by gianfar and ucc_geth that define phy_id strictly as %d:%d Signed-off-by: Vitaly Bordug [EMAIL PROTECTED] Signed-off-by: Vitaly Bordug [EMAIL PROTECTED

[PATCH] PHY fixed driver: rework release path and update phy_id notation

2007-06-09 Thread Vitaly Bordug
of the fixed phy definition on mdio bus to the form of speed+duplex to make it able to be used by gianfar and ucc_geth that define phy_id strictly as %d:%d Signed-off-by: Vitaly Bordug [EMAIL PROTECTED] --- drivers/net/phy/Kconfig |4 ++ drivers/net/phy/fixed.c | 93

Re: STRANGE ERROR

2007-05-20 Thread Vitaly Bordug
On Sat, May 19, 2007 at 16:34 -0700, Andrew Morton wrote: On Sun, 20 May 2007 00:30:55 +0200 Sasa Ostrouska [EMAIL PROTECTED] wrote: Hi everybody, I tried today to upgrade the kernel to 2.6.21.1 and i got the same error during the boot time. Here is the dmesg of the 2.6.20.2, can

[PATCH] [FS_ENET] OF-related fixup for FEC and SCC MAC's

2007-01-24 Thread Vitaly Bordug
Updated direct resource pass with ioremap call, make it grant proper IRQ mapping, stuff incompatible with the new approach were respectively put under #ifndef CONFIG_PPC_MERGE. It is required so that both ppc and powerpc could utilize fs_enet effectively. Signed-off-by: Vitaly Bordug [EMAIL

[PATCH] [FS_ENET] OF-related update for FEC and SCC MAC's

2006-12-11 Thread Vitaly Bordug
Updated direct resource pass with ioremap call, make it grant proper IRQ mapping, stuff incompatible with the new approach were respectively put under #ifndef CONFIG_PPC_MERGE. --- drivers/net/fs_enet/mac-fec.c | 13 + drivers/net/fs_enet/mac-scc.c |6 --

Re: [PATCH] [FS_ENET] OF-related update for FEC and SCC MAC's

2006-12-11 Thread Vitaly Bordug
On Mon, 11 Dec 2006 21:00:49 +0300 Vitaly Bordug [EMAIL PROTECTED] wrote: Updated direct resource pass with ioremap call, make it grant proper IRQ mapping, stuff incompatible with the new approach were respectively put under #ifndef CONFIG_PPC_MERGE. Hrm, Signed-off-by: missed, I'll

[PATCH 3/3] ppc32: board-specific part of fs_enet update

2006-08-08 Thread Vitaly Bordug
board-specific portion to respect driver changes (for 8272ads , 885ads and 866ads). Altered platform_data structures as well as initial setup routines relevant to fs_enet. Signed-off-by: Vitaly Bordug [EMAIL PROTECTED] --- arch/ppc/platforms/85xx/mpc8560_ads.c| 89 arch/ppc

[PATCH 2/3] FS_ENET: use PAL for mii management

2006-08-07 Thread Vitaly Bordug
This patch should update the fs_enet infrastructure to utilize Phy Abstraction Layer subsystem. Along with the abouve, there are apparent bugfixes, rehaul and improvements. Signed-off-by: Vitaly Bordug [EMAIL PROTECTED] --- drivers/net/fs_enet/Makefile |6 drivers/net/fs_enet/fec.h

[PATCH 1/3] PAL: Support of the fixed PHY

2006-08-07 Thread Vitaly Bordug
-by: Vitaly Bordug [EMAIL PROTECTED] --- drivers/net/phy/Kconfig | 17 ++ drivers/net/phy/Makefile |1 drivers/net/phy/fixed.c | 358 ++ drivers/net/phy/phy_device.c | 51 -- include/linux/phy.h |1 5 files changed, 407

[PATCH 3/3] ppc32: board-specific part of fs_enet update

2006-08-07 Thread Vitaly Bordug
This contains board-specific portion to respect driver changes (for 8272ads , 885ads and 866ads). Altered platform_data structures as well as initial setup routines relevant to fs_enet. Signed-off-by: Vitaly Bordug [EMAIL PROTECTED] --- arch/ppc/platforms/85xx/mpc8560_ads.c| 89

[PATCH 0/3] FS_ENET: move to the PAL api

2006-08-07 Thread Vitaly Bordug
These are patches, that utilize Phy Abstraction Layer API in the fs_enet Freescale SoC Ethernet driver. Comments gavered from the community addressed, + minor fixes and improvements. -- Sincerely, Vitaly - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to

[PATCH 2/3] FS_ENET: use PAL for mii management

2006-08-07 Thread Vitaly Bordug
This patch should update the fs_enet infrastructure to utilize Phy Abstraction Layer subsystem. Along with the above, there are apparent bugfixes, overhaul and improvements. Signed-off-by: Vitaly Bordug [EMAIL PROTECTED] --- drivers/net/fs_enet/Makefile |6 drivers/net/fs_enet/fec.h

[PATCH 1/3] PAL: Support of the fixed PHY

2006-08-07 Thread Vitaly Bordug
-by: Vitaly Bordug [EMAIL PROTECTED] --- drivers/net/phy/Kconfig | 17 ++ drivers/net/phy/Makefile |1 drivers/net/phy/fixed.c | 358 ++ drivers/net/phy/phy_device.c | 51 -- include/linux/phy.h |1 5 files changed, 407

[PATCH 3/3] ppc32: board-specific part of fs_enet update

2006-08-07 Thread Vitaly Bordug
support is going to appear in arch/powerpc. Signed-off-by: Vitaly Bordug [EMAIL PROTECTED] --- arch/ppc/platforms/85xx/mpc8560_ads.c| 89 arch/ppc/platforms/85xx/mpc85xx_ads_common.h | 19 +++ arch/ppc/platforms/mpc8272ads_setup.c| 154 - arch/ppc

[PATCH 3/3] FS_ENET: phydev pointer may be dereferenced without NULL check

2006-06-21 Thread Vitaly Bordug
When interface is down, phy is disconnected from the bus and phydev is NULL. But ethtool may try to get/set phy regs even at that time, which results in NULL pointer dereference and OOPS hereby. Signed-off-by: Vitaly Bordug [EMAIL PROTECTED] --- drivers/net/fs_enet/fs_enet-main.c |4

[PATCH 1/3] PAL: Support of the fixed PHY

2006-06-21 Thread Vitaly Bordug
-by: Vitaly Bordug [EMAIL PROTECTED] --- drivers/net/phy/Kconfig | 17 ++ drivers/net/phy/fixed.c | 385 ++ drivers/net/phy/phy_device.c | 51 +++--- include/linux/phy.h |1 4 files changed, 433 insertions(+), 21 deletions(-) diff --git

[PATCH 3/3] FS_ENET: phydev pointer may be dereferenced without NULL check

2006-06-20 Thread Vitaly Bordug
When interface is down, phy is disconnected from the bus and phydev is NULL. But ethtool may try to get/set phy regs even at that time, which results in NULL pointer dereference and OOPS hereby. Signed-off-by: Vitaly Bordug [EMAIL PROTECTED] --- drivers/net/fs_enet/fs_enet-main.c |4

[PATCH 1/3] PAL: Support of the fixed PHY

2006-06-20 Thread Vitaly Bordug
-by: Vitaly Bordug [EMAIL PROTECTED] --- drivers/net/phy/Kconfig | 17 ++ drivers/net/phy/fixed.c | 385 ++ drivers/net/phy/phy_device.c | 51 +++--- include/linux/phy.h |1 4 files changed, 433 insertions(+), 21 deletions(-) diff --git

Re: [RFC: 2.6 patch] remove drivers/net/eepro100.c

2006-01-15 Thread Vitaly Bordug
On Thu, 5 Jan 2006 19:18:26 +0100 Adrian Bunk [EMAIL PROTECTED] wrote: This patch removes the obsolete drivers/net/eepro100.c driver. Is there any known problem in e100 still preventing us from removing this driver (it seems noone was able anymore to verify the ARM problem)? I think I am

[PATCH] fs_enet: fix compilation

2005-11-10 Thread Vitaly Bordug
Fs_enet was compile-broken due to recent platform code update (a number of platform stuff has been moved to the separate header). This fixes the compile issue. Signed-off-by: Vitaly Bordug [EMAIL PROTECTED] --- diff --git a/drivers/net/fs_enet/fs_enet-main.c b/drivers/net/fs_enet/fs_enet