Re: [PATCH net-next] nxp: fix trivial comment typo

Hello Andrea, On 11/14/2018 08:47 PM, Andrea Claudi wrote: > s/rxfliterctrl/rxfilterctrl > > Signed-off-by: Andrea Claudi thank you for the patch, but let me ask you to change the subject line by adding the expected prefixes 'net: lpc_eth: fix trivial comment typo'. Also it would be nice to

[PATCH] net: ethernet: lpc_eth: add device and device node local variables

Trivial non-functional change added to simplify getting multiple references to device pointer in lpc_eth_drv_probe(). Signed-off-by: Vladimir Zapolskiy --- NB, to avoid a merge conflict the change should be applied after https://marc.info/?l=linux-netdev=153990402012273 drivers/net/ethernet

[PATCH] net: ethernet: lpc_eth: remove unused local variable

] struct phy_device *phydev; ^~ Signed-off-by: Vladimir Zapolskiy --- drivers/net/ethernet/nxp/lpc_eth.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/net/ethernet/nxp/lpc_eth.c b/drivers/net/ethernet/nxp/lpc_eth.c index 922b5b5b5c01..e275d64007af

[PATCH] net: ethernet: lpc_eth: remove CONFIG_OF guard from the driver

The MAC controller device is available on NXP LPC32xx platform only, and the LPC32xx platform supports OF builds only, so additional checks in the device driver are not needed. Signed-off-by: Vladimir Zapolskiy --- drivers/net/ethernet/nxp/lpc_eth.c | 4 +--- 1 file changed, 1 insertion(+), 3

[PATCH] net: ethernet: lpc_eth: clean up the list of included headers

The change removes all unnecessary included headers from the driver source code, the remaining list is sorted in alphabetical order. Signed-off-by: Vladimir Zapolskiy --- drivers/net/ethernet/nxp/lpc_eth.c | 28 ++-- 1 file changed, 6 insertions(+), 22 deletions(-) diff

Re: [PATCH 3/6] ravb: remove custom .set_link_ksettings from ethtool ops

Hello Sergei, On 05/26/2018 10:50 PM, Sergei Shtylyov wrote: > On 05/24/2018 02:11 PM, Vladimir Zapolskiy wrote: > >> The change replaces a custom implementation of .set_link_ksettings >> callback with a shared phy_ethtool_set_link_ksettings(), this fixes >> sleep in a

Re: [PATCH 0/6] ravb/sh_eth: fix sleep in atomic by reusing shared ethtool handlers

Hello Sergei, On 05/24/2018 08:24 PM, Sergei Shtylyov wrote: > On 05/24/2018 07:40 PM, Sergei Shtylyov wrote: > >>> For ages trivial changes to RAVB and SuperH ethernet links by means of >>> standard 'ethtool' trigger a 'sleeping function called from invalid >>> context' bug, to visualize it on

Re: [PATCH 1/6] ravb: remove custom .nway_reset from ethtool ops

Hello Sergei, On 05/24/2018 08:01 PM, Sergei Shtylyov wrote: > On 05/24/2018 07:44 PM, Andrew Lunn wrote: > >> The change fixes a sleep in atomic context issue, which can be >> always triggered by running 'ethtool -r' command, because >> phy_start_aneg() protects phydev fields by a

Re: [PATCH 1/6] ravb: remove custom .nway_reset from ethtool ops

On 05/24/2018 04:22 PM, Andrew Lunn wrote: > On Thu, May 24, 2018 at 02:11:53PM +0300, Vladimir Zapolskiy wrote: >> The change fixes a sleep in atomic context issue, which can be >> always triggered by running 'ethtool -r' command, because >> phy_start_aneg() protects phy

Re: [PATCH 3/6] ravb: remove custom .set_link_ksettings from ethtool ops

Hi Andrew, On 05/24/2018 04:29 PM, Andrew Lunn wrote: > On Thu, May 24, 2018 at 02:11:55PM +0300, Vladimir Zapolskiy wrote: >> The change replaces a custom implementation of .set_link_ksettings >> callback with a shared phy_ethtool_set_link_ksettings(), this fixes >> sleep

[PATCH 5/6] sh_eth: remove custom .get_link_ksettings from ethtool ops

The change replaces a custom implementation of .get_link_ksettings callback with a shared phy_ethtool_get_link_ksettings(), note that >lock wrapping is not needed, because the lock does not serialize access to phydev fields. Signed-off-by: Vladimir Zapolskiy <vladimir_zapols...@ment

[PATCH 6/6] sh_eth: remove custom .set_link_ksettings from ethtool ops

() only, also now TX/RX is disabled when link is put down or modifications to E-MAC registers ECMR and GECMR are expected for both cases of checked and ignored link status pin state from E-MAC interrupt handler. Signed-off-by: Vladimir Zapolskiy <vladimir_zapols...@mentor.com> --- drive

[PATCH 1/6] ravb: remove custom .nway_reset from ethtool ops

-by: Vladimir Zapolskiy <vladimir_zapols...@mentor.com> --- drivers/net/ethernet/renesas/ravb_main.c | 17 + 1 file changed, 1 insertion(+), 16 deletions(-) diff --git a/drivers/net/ethernet/renesas/ravb_main.c b/drivers/net/ethernet/renesas/ravb_main.c index 68f122140966..4a043e

[PATCH 4/6] sh_eth: remove custom .nway_reset from ethtool ops

-by: Vladimir Zapolskiy <vladimir_zapols...@mentor.com> --- drivers/net/ethernet/renesas/sh_eth.c | 18 +- 1 file changed, 1 insertion(+), 17 deletions(-) diff --git a/drivers/net/ethernet/renesas/sh_eth.c b/drivers/net/ethernet/renesas/sh_eth.c index d9cadfb1bc4a..6d1fed2b4a4a

[PATCH 0/6] ravb/sh_eth: fix sleep in atomic by reusing shared ethtool handlers

hile running more or less advanced tests. Please note that sh_eth patches from the series were built-tested only. On purpose I do not add Fixes tags, the reused PHY handlers were added way later than the fixed problems were firstly found in the drivers. Vladimir Zapolskiy (6): ravb: remove custom

[PATCH 2/6] ravb: remove custom .get_link_ksettings from ethtool ops

The change replaces a custom implementation of .get_link_ksettings callback with a shared phy_ethtool_get_link_ksettings(), note that >lock wrapping is not needed, because the lock does not serialize access to phydev fields. Signed-off-by: Vladimir Zapolskiy <vladimir_zapols...@ment

[PATCH 3/6] ravb: remove custom .set_link_ksettings from ethtool ops

() only, also now TX/RX is disabled when link is put down or modifications to E-MAC registers ECMR and GECMR are expected for both cases of checked and ignored link status pin state from E-MAC interrupt handler. Signed-off-by: Vladimir Zapolskiy <vladimir_zapols...@mentor.com> --- drive

Re: [PATCH] ARM: dts: add phy-reset property for rk3066a-rayeager emac

Hello Chris, On 11/07/2017 04:49 AM, Chris Zhong wrote: > The ethernet phy of rk3066a-rayeager has a reset pin, it controlled by > GPIO1_D6, this pin should be pull down then pull up to reset the phy. > Add a phy-reset property in emac, make the phy can be reset when emac > power on. for PHY

Re: [PATCH v2] net: lpc_eth: Check clk_prepare_enable() error

enable(pldat->clk); > + if (ret) > + goto err_out_free_dev; > > /* Map IO space */ > pldat->net_base = ioremap(res->start, resource_size(res)); > sorry for nitpicking, would you mind to send v3 with a clk_put(pldat->clk) resource release call on newly added error path? In advance if it is done, please feel free to add my Acked-by: Vladimir Zapolskiy <v...@mleia.com> Thank you for the fix! -- With best wishes, Vladimir

Re: [PATCH] net: lpc_eth: Check clk_prepare_enable() error

Hi Fabio, On 23.08.2016 05:01, Fabio Estevam wrote: > From: Fabio Estevam > > clk_prepare_enable() may fail, so we should better check its return > value and propagate it in the case of failure. > > Signed-off-by: Fabio Estevam > --- >

[PATCH] net: mediatek: fix checking for NULL instead of IS_ERR() in .probe

devm_ioremap_resource() returns ERR_PTR() value on error, it never returns NULL, fix it and propagate the returned error upwards. Fixes: 656e705243fd ("net-next: mediatek: add support for MT7623 ethernet") Signed-off-by: Vladimir Zapolskiy <v...@mleia.com> --- drivers/net/e

Re: [PATCH 2/2] of_mdio: use PTR_ERR_OR_ZERO()

; status.asym_pause = be32_to_cpu(fixed_link_prop[4]); > phy = fixed_phy_register(PHY_POLL, , -1, np); > - return IS_ERR(phy) ? PTR_ERR(phy) : 0; > + return PTR_ERR_OR_ZERO(phy); > } > > return -ENODEV; > Reviewed-by: Vladimir Zapolskiy <v...@mleia.com> -- With best wishes, Vladimir

Re: [PATCH 1/2] of_mdio: use IS_ERR_OR_NULL()

Hello Sergei, On 12.03.2016 00:12, Sergei Shtylyov wrote: > IS_ERR_OR_NULL() is open coded in of_mdiobus_register_{phy|device}(), so > just call it directly... > > Signed-off-by: Sergei Shtylyov > > --- > drivers/of/of_mdio.c |4 ++-- > 1 file changed,

[PATCH] net: lpc_eth: remove irq > NR_IRQS check from probe()

-by: Vladimir Zapolskiy <v...@mleia.com> --- drivers/net/ethernet/nxp/lpc_eth.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/nxp/lpc_eth.c b/drivers/net/ethernet/nxp/lpc_eth.c index b159ef8..0576651 100644 --- a/drivers/net/ethernet/nxp/lpc_eth.c +++ b/d

[PATCH] net: lpc_eth: fix warnings caused by enabling unprepared clock

orm_driver_register+0x50/0x64) [<>] (__platform_driver_register) from [<>] (lpc_eth_driver_init+0x18/0x20) [<>] (lpc_eth_driver_init) from [<>] (do_one_initcall+0x11c/0x1dc) [<>] (do_one_initcall) from [<>] (kernel_init_freeable+0x10c/0x1d4) [<>] (kernel

[PATCH 3.14] net: sysctl_net_core: remove compiler warning about unused variable 'one'

for min length) which made 'one' obsolete (in contrast to recent mainline kernel, which still uses 'one'). Signed-off-by: Dirk Behme dirk.be...@de.bosch.com Signed-off-by: Vladimir Zapolskiy vladimir_zapols...@mentor.com Cc: netdev@vger.kernel.org Cc: sta...@vger.kernel.org # 3.14.x- Fixes: a1d55b36de6b

[PATCH] net: phy: spi_ks8995: clean up ks8995_registers_read/write

The change removes redundant sysfs binary file boundary checks, since this task is already done on caller side in fs/sysfs/file.c Signed-off-by: Vladimir Zapolskiy v...@mleia.com --- drivers/net/phy/spi_ks8995.c | 22 -- 1 file changed, 22 deletions(-) diff --git a/drivers

Re: [PATCH] net: qlcnic: clean up sysfs error codes

Hello David, On 29.05.2015 02:28, David Miller wrote: From: Vladimir Zapolskiy v...@mleia.com Date: Tue, 26 May 2015 03:49:45 +0300 Replace confusing QL_STATUS_INVALID_PARAM == -1 == -EPERM with -EINVAL and QLC_STATUS_UNSUPPORTED_CMD == -2 == -ENOENT with -EOPNOTSUPP, the latter error code

[PATCH] net: netxen: correct sysfs bin attribute return code

offset etc.) Signed-off-by: Vladimir Zapolskiy v...@mleia.com --- drivers/net/ethernet/qlogic/netxen/netxen_nic_main.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/ethernet/qlogic/netxen/netxen_nic_main.c b/drivers/net/ethernet/qlogic/netxen/netxen_nic_main.c

[PATCH] net: qlcnic: clean up sysfs error codes

should not care if userspace gets its EFAULT or not. Signed-off-by: Vladimir Zapolskiy v...@mleia.com --- drivers/net/ethernet/qlogic/qlcnic/qlcnic.h | 3 - drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c | 2 +- drivers/net/ethernet/qlogic/qlcnic/qlcnic_sysfs.c | 77