Re: [PATCH 4/6] net: mvneta: Handle per-cpu interrupts

2015-07-05 Thread Willy Tarreau
Hi Maxime, On Fri, Jul 03, 2015 at 04:25:49PM +0200, Maxime Ripard wrote: Now that our interrupt controller is allowing us to use per-CPU interrupts, actually use it in the mvneta driver. This involves obviously reworking the driver to have a CPU-local NAPI structure, and report for

Re: [PATCH 6/6] net: mvneta: Statically assign queues to CPUs

2015-07-05 Thread Willy Tarreau
Hi Thomas, On Fri, Jul 03, 2015 at 04:46:24PM +0200, Thomas Petazzoni wrote: Maxime, On Fri, 3 Jul 2015 16:25:51 +0200, Maxime Ripard wrote: +static void mvneta_percpu_enable(void *arg) +{ + struct mvneta_port *pp = arg; + + enable_percpu_irq(pp-dev-irq, IRQ_TYPE_NONE); +}

Re: [RFC] [PATCH] net: socket: Fix the wrong returns for recvmsg and sendmsg

2015-06-02 Thread Willy Tarreau
On Tue, Jun 02, 2015 at 02:43:54PM +0800, Junling Zheng wrote: On 2015/6/2 14:27, Greg KH wrote: On Mon, Jun 01, 2015 at 10:23:57PM -0700, David Miller wrote: From: Junling Zheng zhengjunl...@huawei.com Date: Tue, 2 Jun 2015 12:05:32 +0800 So, the problem commit is 281c9c36 (net:

Re: 2.6.32.66 tcp regression OOPs

2015-06-01 Thread Willy Tarreau
Hi, On Mon, Jun 01, 2015 at 09:00:21AM +0200, Frans Klaver wrote: [cc: Willy Tarreau] On Mon, Jun 1, 2015 at 3:26 AM, starlight.201...@binnacle.cx wrote: Hello, Apoligies if I have submitted to the wrong lists. Encountered a regression in 2.6.32.66 relative to 2.6.32.65

Re: 2.6.32.66 tcp regression OOPs

2015-06-01 Thread Willy Tarreau
On Mon, Jun 01, 2015 at 11:32:19AM -0400, starlight.201...@binnacle.cx wrote: Hi, I found the patch late yesterday and applied it. Running fine now for 12 hours under active load. Thank you. Recommend the patch be rolled into the tarball, or a notation added to the release page as this

Re: Fw: [Bug 99161] New: 2.6.32.66 PPC Oops in tcp_send_fin

2015-05-29 Thread Willy Tarreau
Hi Eric, On Fri, May 29, 2015 at 08:52:11AM -0700, Eric Dumazet wrote: On Fri, 2015-05-29 at 08:12 -0700, Stephen Hemminger wrote: I think 2.6.32 is so old no one will care. A few will still, but at least we must ensure the old guy finishes his days nicely :-) (...) I guess a backport went

Re: [PATCH] Add IPv6 support to TCP SYN cookies

2008-02-05 Thread Willy Tarreau
Hi Andi, Alan, I've run extensive tests with/without syn cookies recently. On Tue, Feb 05, 2008 at 05:39:12PM +0100, Andi Kleen wrote: On Tue, Feb 05, 2008 at 03:42:13PM +, Alan Cox wrote: Syncookies are discouraged these days. They disable too many valuable TCP features (window

Re: [PATCH] Add IPv6 support to TCP SYN cookies

2008-02-05 Thread Willy Tarreau
On Wed, Feb 06, 2008 at 12:52:17AM +0300, Evgeniy Polyakov wrote: Hi Alan. On Tue, Feb 05, 2008 at 09:20:17PM +, Alan Cox ([EMAIL PROTECTED]) wrote: Most (if not all) distributions have them enabled and window growing works just fine. Actually I do not see any reason why connection

Re: questions on NAPI processing latency and dropped network packets

2008-01-16 Thread Willy Tarreau
On Wed, Jan 16, 2008 at 07:58:36AM +0100, Jarek Poplawski wrote: On Wed, Jan 16, 2008 at 11:17:08AM +1100, Herbert Xu wrote: ... Well people are always going to operate on this model for commercial reasons. FWIW I used to work for a company that stuck to a specific version of the Linux

Re: [PATCH 2/2] [e1000 VLAN] Disable vlan hw accel when promiscuous mode

2007-11-12 Thread Willy Tarreau
On Mon, Nov 12, 2007 at 02:57:16PM -0800, David Miller wrote: From: Chris Friesen [EMAIL PROTECTED] Date: Mon, 12 Nov 2007 16:43:24 -0600 David Miller wrote: When you select VLAN, you by definition are asking for non-VLAN traffic to be elided. It is like plugging the ethernet cable

Re: [PATCH 2/2] [e1000 VLAN] Disable vlan hw accel when promiscuous mode

2007-11-12 Thread Willy Tarreau
On Mon, Nov 12, 2007 at 03:19:23PM -0800, David Miller wrote: From: Willy Tarreau [EMAIL PROTECTED] Date: Tue, 13 Nov 2007 00:15:16 +0100 I can say that sometimes you'd like to be aware that one of your VLANs is wrong and you'd simply like to sniff the wire to guess the correct tag

Re: ISNs and 2.6.22, Was: Re: haproxy linux firewall (netfilter)

2007-10-20 Thread Willy Tarreau
On Sat, Oct 20, 2007 at 07:23:25PM +0200, Krzysztof Oledzki wrote: (...) So it seems that ISNs are not randomly incremented but rather randomly generated. Adding netdev@vger.kernel.org to the CC list. Eh, I was little to hurry this time. There were not randomly generated but incremented

FWD: 2.4.35 e1000 problems

2007-10-15 Thread Willy Tarreau
Hi, Dmitry, I've forwarded your mail to the netdev mailing list and to the e1000 maintainers. Auke, does it sound like a known problem ? Maybe someone has seen it in 2.6 ? Just for the record, e1000 in 2.4.35 is 7.3.20-k4. Dmitry, if you have time for a test, I think it would be good if you

Re: bnx2 dirver's firmware images

2007-09-18 Thread Willy Tarreau
On Tue, Sep 18, 2007 at 12:21:50PM -0700, David Miller wrote: From: Michael Chan [EMAIL PROTECTED] Date: Tue, 18 Sep 2007 13:05:51 -0700 The bnx2 firmware changes quite frequently. A new driver quite often requires new firmware to work correctly. Splitting them up makes things

Re: bnx2 dirver's firmware images

2007-09-18 Thread Willy Tarreau
On Tue, Sep 18, 2007 at 02:31:34PM -0700, David Miller wrote: From: Willy Tarreau [EMAIL PROTECTED] Date: Tue, 18 Sep 2007 23:30:25 +0200 On Tue, Sep 18, 2007 at 12:21:50PM -0700, David Miller wrote: From: Michael Chan [EMAIL PROTECTED] Date: Tue, 18 Sep 2007 13:05:51 -0700

Re: sk98lin for 2.6.23-rc1

2007-09-11 Thread Willy Tarreau
On Tue, Sep 11, 2007 at 05:03:57PM +0200, Adrian Bunk wrote: On Tue, Sep 11, 2007 at 10:29:47AM -0400, Bill Davidsen wrote: So if you want people to try a new driver, I think it really has to have some benefits to the users, in terms of performance, reliability, or features. Cleaner

Re: [PATCH] e100 module loads 1/2 times

2007-08-28 Thread Willy Tarreau
On Tue, Aug 28, 2007 at 02:43:23PM -0700, Brandeburg, Jesse wrote: Willy Tarreau wrote: --- e100-3.5.17/src/e100.c.orig 2007-08-13 08:53:18 +0200 +++ e100-3.5.17/src/e100.c 2007-08-13 09:24:56 +0200 @@ -2934,13 +2934,13 @@ printk(KERN_INFO PFX %s\n, DRV_COPYRIGHT

[PATCH] fix realtek phy id in forcedeth

2007-08-23 Thread Willy Tarreau
it is. Please apply to mainline then stable. Thanks, Willy -- From a0e2922b99eedd9863232368ea2afe072c52783e Mon Sep 17 00:00:00 2001 From: Willy Tarreau [EMAIL PROTECTED] Date: Thu, 23 Aug 2007 21:35:41 +0200 Subject: [PATCH] fix realtek phy id in forcedeth As noticed by Chuck Ebbert, commit

Re: 2.6.22.5 forcedeth timeout hang

2007-08-23 Thread Willy Tarreau
On Thu, Aug 23, 2007 at 06:48:23PM -0500, Mr. Berkley Shands wrote: 100% reproducible hang on xmit timeout. Just do a make -j4 modules on an nfs mounted kernel source. Most likely you also had the problem with 2.6.22.2 (maybe you have not tested this one, though). There were bug fixes for

Re: [2.6.20.17 review 35/58] forcedeth bug fix: realtek phy

2007-08-22 Thread Willy Tarreau
On Wed, Aug 22, 2007 at 11:56:42AM -0400, Chuck Ebbert wrote: On 08/22/2007 05:39 AM, Willy Tarreau wrote: This patch contains errata fixes for the realtek phy. It only renamed the defines to be phy specific. Signed-off-by: Ayaz Abdulla [EMAIL PROTECTED] Signed-off-by: Greg Kroah

Re: Marvell 88E8056 gigabit ethernet controller

2007-08-18 Thread Willy Tarreau
On Sat, Aug 18, 2007 at 04:45:26AM -0700, Kevin E wrote: --- Willy Tarreau [EMAIL PROTECTED] wrote: No Stephen, look again, he says that moving the video card into the broken system does not change anything. Correct, I've used three different video cards in the broken machine. I've

[PATCH] e100 module loads 1/2 times

2007-08-13 Thread Willy Tarreau
Hi Auke, Jesse, for a long time, I've been annoyed by version 3.5.17 of the e100 driver which refuses to load on first time and only loads on second time. Since I always had the original 2.3.43 driver in kernel 2.4, I did not care that much. Recently, I encountered real troubles with 2.3.43 in a

Re: TCP SACK issue, hung connection, tcpdump included

2007-07-29 Thread Willy Tarreau
Hi, [CCing netdev as it's where people competent on the subject are] On Sun, Jul 29, 2007 at 06:59:26AM +0100, Darryl L. Miles wrote: CLIENT = Linux 2.6.20.1-smp [Customer build] SERVER = Linux 2.6.9-55.ELsmp [Red Hat Enterprise Linux AS release 4 (Nahant Update 5)] The problems start

Re: TCP SACK issue, hung connection, tcpdump included

2007-07-29 Thread Willy Tarreau
On Sun, Jul 29, 2007 at 11:26:00AM +0300, Ilpo Järvinen wrote: On Sun, 29 Jul 2007, Willy Tarreau wrote: On Sun, Jul 29, 2007 at 06:59:26AM +0100, Darryl L. Miles wrote: CLIENT = Linux 2.6.20.1-smp [Customer build] SERVER = Linux 2.6.9-55.ELsmp [Red Hat Enterprise Linux AS release 4

Re: TCP SACK issue, hung connection, tcpdump included

2007-07-29 Thread Willy Tarreau
On Sun, Jul 29, 2007 at 12:28:04PM +0300, Ilpo Järvinen wrote: (...) Limitation for 48 byte segments? You have to be kidding... :-) But yes, it seems that one of the directions is dropping packets for some reason though I would not assume MTU limitation... Or did you mean some other

Re: [IPv4] fib: Fix out of bound access of fib_props[]

2007-04-16 Thread Willy Tarreau
On Mon, Apr 16, 2007 at 10:14:17AM +0200, Thomas Graf wrote: * Willy Tarreau [EMAIL PROTECTED] 2007-04-14 17:48 Finally, I think I have the correct fix below. Please someone confirm or tell me I'm nuts. Looks good, same is needed for DECnet Thank you Thomas. The DECnet stuff was already

Re: [IPv4] fib: Fix out of bound access of fib_props[]

2007-04-14 Thread Willy Tarreau
On Sat, Mar 24, 2007 at 08:33:39PM -0700, David Miller wrote: From: Thomas Graf [EMAIL PROTECTED] Date: Sat, 24 Mar 2007 16:34:36 +0100 Fixes a typo which caused fib_props[] to have the wrong size and makes sure the value used to index the array which is provided by userspace via netlink

Re: [IPv4] fib: Fix out of bound access of fib_props[]

2007-04-14 Thread Willy Tarreau
On Sat, Apr 14, 2007 at 04:26:55PM +0200, Willy Tarreau wrote: On Sat, Mar 24, 2007 at 08:33:39PM -0700, David Miller wrote: From: Thomas Graf [EMAIL PROTECTED] Date: Sat, 24 Mar 2007 16:34:36 +0100 Fixes a typo which caused fib_props[] to have the wrong size and makes sure the value

Re: [PATCH] tcp_cubic: use 32 bit math

2007-03-21 Thread Willy Tarreau
Hi Stephen, On Wed, Mar 21, 2007 at 11:54:19AM -0700, Stephen Hemminger wrote: On Tue, 13 Mar 2007 21:50:20 +0100 Willy Tarreau [EMAIL PROTECTED] wrote: [...] ( cut my boring part ) Here are the results classed by speed : /* Sample output on a Pentium-M 600 MHz : Function

Re: [PATCH] tcp_cubic: use 32 bit math

2007-03-13 Thread Willy Tarreau
lookups only. * Avg err ~= 0.613% */ static uint32_t ncubic_tab0(uint64_t a) { uint32_t b; uint32_t shift; /* * cbrt(x) MSB values for x MSB values in [0..63]. * Precomputed then refined by hand - Willy Tarreau * * For x in [0..63

Re: [PATCH] tcp_cubic: use 32 bit math

2007-03-10 Thread Willy Tarreau
On Wed, Mar 07, 2007 at 07:51:35PM -0800, David Miller wrote: From: Stephen Hemminger [EMAIL PROTECTED] Date: Wed, 07 Mar 2007 19:10:47 -0800 David Miller wrote: What about Willy Tarreau's supposedly even faster variant? Or does this incorporate that set of improvements? That's

Re: [PATCH] tcp_cubic: use 32 bit math

2007-03-07 Thread Willy Tarreau
On Wed, Mar 07, 2007 at 07:10:47PM -0800, Stephen Hemminger wrote: David Miller wrote: From: Stephen Hemminger [EMAIL PROTECTED] Date: Wed, 7 Mar 2007 17:07:31 -0800 The basic calculation has to be done in 32 bits to avoid doing 64 bit divide by 3. The value x is only 22bits max so

Re: [PATCH 2.4 0/3] e1000: update to 7.3.20

2007-02-06 Thread Willy Tarreau
Hi Auke, On Mon, Feb 05, 2007 at 05:01:02PM -0800, Kok, Auke wrote: Willy, Please pull: git-pull git://lost.foo-projects.org/~ahkok/git/linux-2.4 e1000 to receive an update for the e1000 driver. This updates the e1000 driver in the 2.4 kernel to version 7.3.20-k4, roughly the

Re: [PATCH] sky2: flow control off

2007-02-05 Thread Willy Tarreau
Hi Stephen, First, thanks for this detailed explanation. On Mon, Feb 05, 2007 at 09:22:53AM -0800, Stephen Hemminger wrote: Here is what I saw. The transmitter on the Marvell Yukon II (88e8053) hangs when doing transmit flow control under load. There appears to be a bug or race condition

Re: [PATCH] sky2: flow control off

2007-02-03 Thread Willy Tarreau
Hi Stephen, On Fri, Feb 02, 2007 at 03:34:25PM -0800, Stephen Hemminger wrote: Turn flow control off for sky2. When flow control is on, the transmitter may get randomly stuck. Perhaps there is hardware problem, but until Marvell provides errata information for workaround, it should default to

planned driver updates for 2.4.35

2007-01-29 Thread Willy Tarreau
Hi David, As stated with the 2.4.34 announcement, I planned to perform a few updates in two network drivers for 2.4.35 : - e1000: the cards equipped with the not-so old 82546EB chips have completely disappeared from the earth surface, and people replacing hardware are experiencing

Re: [2.4 PATCH] ethernet (net/ethernet/eth.c): eth_header() may produce invalid packets (with dest. addr. = 00:00:00:00:00:00)

2007-01-11 Thread Willy Tarreau
On Wed, Jan 10, 2007 at 12:53:31PM +0100, Christian Praehauser wrote: Hello, and sorry for bothering you with a patch you've already seen ;-). I had not seen it yet, so I'm fine with it :-) From: Christian Praehauser, Department of Computer Sciences, University of Salzburg This patch

Re: SKGE backport to 2.4 : success

2006-11-06 Thread Willy Tarreau
On Mon, Nov 06, 2006 at 10:56:09AM -0800, Stephen Hemminger wrote: On Sat, 4 Nov 2006 22:08:55 +0100 Willy Tarreau [EMAIL PROTECTED] wrote: Hi Stephen, I don't know if you received my mail since I got no reply. Thanks in advance for your comments, Willy On Sat, Oct 28, 2006

SKGE backport to 2.4 : success

2006-10-28 Thread Willy Tarreau
Hi Stephen, In my own kernels, I've added your backport of SKGE to 2.4 that I found here : http://developer.osdl.org/shemminger/releases/skge-sky2-backport.tar.bz2 It seems to work pretty well compared to the original syskonnect driver (up to and including 8.36). Several people around me

Re: [PATCH] getsockopt() early argument sanity checking

2006-08-20 Thread Willy Tarreau
On Sun, Aug 20, 2006 at 10:34:43AM +0200, Andi Kleen wrote: On Sunday 20 August 2006 01:05, Solar Designer wrote: I propose the attached patch (extracted from 2.4.33-ow1) for inclusion into 2.4.34-pre. (2.6 kernels could benefit from the same change, too, but at the moment I am dealing

Re: [PATCH] getsockopt() early argument sanity checking

2006-08-20 Thread Willy Tarreau
Hi David, On Sun, Aug 20, 2006 at 12:44:27PM -0700, David Miller wrote: From: Willy Tarreau [EMAIL PROTECTED] Date: Sun, 20 Aug 2006 02:43:07 +0200 On Sun, Aug 20, 2006 at 02:05:20AM +0200, Michael Buesch wrote: Not to me. It heavily violates codingstyle and screws brains

Re: [PATCH] getsockopt() early argument sanity checking

2006-08-19 Thread Willy Tarreau
On Sun, Aug 20, 2006 at 03:05:32AM +0400, Solar Designer wrote: Willy, I propose the attached patch (extracted from 2.4.33-ow1) for inclusion into 2.4.34-pre. (2.6 kernels could benefit from the same change, too, but at the moment I am dealing with proper submission of generic changes

Re: [PATCH] getsockopt() early argument sanity checking

2006-08-19 Thread Willy Tarreau
On Sun, Aug 20, 2006 at 02:05:20AM +0200, Michael Buesch wrote: On Sunday 20 August 2006 01:48, Willy Tarreau wrote: On Sun, Aug 20, 2006 at 03:05:32AM +0400, Solar Designer wrote: Willy, I propose the attached patch (extracted from 2.4.33-ow1) for inclusion into 2.4.34-pre

Re: Network performance degradation from 2.6.11.12 to 2.6.16.20

2006-06-25 Thread Willy Tarreau
Hi Andi, On Mon, Jun 19, 2006 at 05:24:31PM +0200, Andi Kleen wrote: If you use pmtmr try to reboot with kernel option clock=tsc. That's dangerous advice - when the system choses not to use TSC it often has a reason. On my Opteron AMD system i normally can route 400 kpps, but with

Re: [PATCH-2.4] forcedeth update to 0.50

2006-05-31 Thread Willy Tarreau
On Wed, May 31, 2006 at 07:50:32AM +0200, Manfred Spraul wrote: Hi Willy, Willy Tarreau wrote: I started from the latest backport you sent in september (0.42) and incrementally applied 2.6 updates. I stopped at 0.50 which provides VLAN support, because after this one, there are some 2.4

Re: [PATCH-2.4] forcedeth update to 0.50

2006-05-31 Thread Willy Tarreau
On Wed, May 31, 2006 at 09:50:38PM +0200, Manfred Spraul wrote: Marcelo Tosatti wrote: Since v2.4.33 should be out RSN, my opinion is that applying the one-liner to fix the bringup problem for now is more prudent.. It's attached. Untested, but it should work. Just the relevant hunk

[PATCH-2.6] e1000: fix media_type - phy_type thinko

2006-04-15 Thread Willy TARREAU
Recent patch cb764326dff0ee51aca0d450e1a292de65661055 introduced a thinko in e1000_main.c : e1000_media_type_copper is compared to hw.phy_type instead of hw.media_type. Original patch proposed by Jesse Brandeburg was correct, but what has been merged is not. --- drivers/net/e1000/e1000_main.c

Re: 2.4.32: unresolved symbol unregister_qdisc

2006-04-09 Thread Willy Tarreau
On Sun, Apr 09, 2006 at 08:29:12PM -0700, Randy.Dunlap wrote: On Sun, 9 Apr 2006 23:20:01 -0400 (EDT) George P Nychis wrote: On Sun, 9 Apr 2006 22:49:50 -0400 (EDT) George P Nychis wrote: On Sun, 9 Apr 2006 22:05:33 -0400 (EDT) George P Nychis wrote: On Sun, 9 Apr

Re: Linux v2.6.16-rc6

2006-03-12 Thread Willy Tarreau
On Sat, Mar 11, 2006 at 06:39:04PM -0800, David S. Miller wrote: From: Michal Piotrowski [EMAIL PROTECTED] Date: Sun, 12 Mar 2006 02:51:40 +0100 I have noticed this warnings TCP: Treason uncloaked! Peer 82.113.55.2:11759/50967 shrinks window 148470938:148470943. Repaired. TCP: Treason

Re: 2.6.16, sk98lin out of date

2006-02-13 Thread Willy Tarreau
On Mon, Feb 13, 2006 at 02:03:14PM -0500, Lee Revell wrote: On Mon, 2006-02-13 at 12:06 +0100, Mws wrote: hi, as i do have the same problem i may help you out. at first, syskonnect did send their kernel diffs/patches but they we're rejected caused by coding style, indention and some

Re: [Patch] 2.4.32 - Neighbour Cache (ARP) State machine bug Fixed

2006-02-07 Thread Willy Tarreau
Hi, On Tue, Feb 07, 2006 at 12:57:43AM -0700, Pradeep Vincent wrote: In 2.4.21, arp code uses gc_timer to check for stale arp cache entries. In 2.6, each entry has its own timer to check for stale arp cache. 2.4.29 to 2.4.32 kernels (atleast) use neither of these timers. This causes problems

<    1   2