Re: [PATCH] net: hns: dereference ppe_cb->ppe_common_cb if it is non-null

2016-08-25 Thread Yisen Zhuang
en assigning dsaf_dev. Fix this > by moving the initialisation of dsaf_dev once we know > ppe_cb->ppe_common_cb is OK to dereference. > > Signed-off-by: Colin Ian King <colin.k...@canonical.com> Acked-by: Yisen Zhuang <yisen.zhu...@huawei.com>

Re: [PATCH 1/1 linux-next] net: hns: fix typo in g_gmac_stats_string[]

2016-08-10 Thread Yisen Zhuang
Hi Fabian, This patch is fine to me, many thanks. Yisen 在 2016/8/10 23:48, Fabian Frederick 写道: > s/gamc/gmac/ > > Signed-off-by: Fabian Frederick > --- > drivers/net/ethernet/hisilicon/hns/hns_dsaf_gmac.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff

Re: [PATCH 06/15] ethernet: hisilicon: hns: hns_dsaf_mac: add missing of_node_put after calling of_parse_phandle

2016-07-27 Thread Yisen Zhuang
在 2016/7/27 10:20, Peter Chen 写道: > of_node_put needs to be called when the device node which is got > from of_parse_phandle has finished using. > > Signed-off-by: Peter Chen > --- > drivers/net/ethernet/hisilicon/hns/hns_dsaf_mac.c | 9 ++--- > 1 file changed, 6

[PATCH v3 net-next 4/9] net: hns: delete redundant parenthese

2016-07-01 Thread Yisen Zhuang
From: Daode Huang <huangda...@hisilicon.com> According to the previous review comments from Andy, this patch deletes the redundant parens in the patch. Signed-off-by: Daode Huang <huangda...@hisilicon.com> Signed-off-by: Yisen Zhuang <yisen.zhu...@huawei.com> --- drivers/net/

[PATCH v3 net-next 1/9] MAINTAINERS: add maintainers for hns driver

2016-07-01 Thread Yisen Zhuang
From: Daode Huang <huangda...@hisilicon.com> This patch adds maintainers for hisilicon network subsystem driver Signed-off-by: Daode Huang <huangda...@hisilicon.com> Signed-off-by: Yisen Zhuang <yisen.zhu...@huawei.com> --- change log: v3: match all files in and below dr

[PATCH v3 net-next 6/9] net: hns: normalize two different loop

2016-07-01 Thread Yisen Zhuang
From: Daode Huang <huangda...@hisilicon.com> There are two approaches to assign data, one does 2 loops, another does 1 loop. This patch normalize the different methods to 1 loop. Signed-off-by: Daode Huang <huangda...@hisilicon.com> Signed-off-by: Yisen Zhuang <yisen.zh

[PATCH v3 net-next 0/9] net: hns: fix the typo of hns

2016-07-01 Thread Yisen Zhuang
This series includes typo fixes which review by Andy, adding the hns maintainer to MAINTAINERS, as below: > from Daode: adds the maintainer for hns driver; > from Daode: fix the typo of hns reviewed by Andy Shevchenko; > from Kejian: one remove redundant function and two fix to get

[PATCH v3 net-next 7/9] net: hns: remove redundant hns_mac_dev_to_enet_if()

2016-07-01 Thread Yisen Zhuang
he mac mode is obviously redundant. Reported-by: Jinchuan Tian <tianjinchu...@huawei.com> Signed-off-by: Kejian Yan <yankej...@huawei.com> Signed-off-by: Yisen Zhuang <yisen.zhu...@huawei.com> --- drivers/net/ethernet/hisilicon/hns/hns_dsaf_mac.c | 15 --- 1 file change

[PATCH v3 net-next 2/9] net: hns: fix code style about hns driver

2016-07-01 Thread Yisen Zhuang
From: Daode Huang <huangda...@hisilicon.com> This patch fixes code sytle of hns driver to make it simple. Signed-off-by: Daode Huang <huangda...@hisilicon.com> Signed-off-by: Yisen Zhuang <yisen.zhu...@huawei.com> --- drivers/net/ethernet/hisilicon/hns/hns_dsaf_misc.c | 16 +

[PATCH v3 net-next 5/9] net: hns: add a space before "*/"

2016-07-01 Thread Yisen Zhuang
From: Daode Huang <huangda...@hisilicon.com> In comment line, some time miss a space before */, so this patch adds a space before */. Signed-off-by: Daode Huang <huangda...@hisilicon.com> Signed-off-by: Yisen Zhuang <yisen.zhu...@huawei.com> --- drivers/net/ethernet/hisilicon/

[PATCH v3 net-next 9/9] net: hns: get reset registers from DT

2016-07-01 Thread Yisen Zhuang
From: Kejian Yan <yankej...@huawei.com> Since the registers of subctrl may be different, it is better to mv the registers from hns mdio driver routine to device tree node. Signed-off-by: Kejian Yan <yankej...@huawei.com> Signed-off-by: Yisen Zhuang <yisen.zhu...@huawei.com> -

[PATCH v3 net-next 3/9] net: hns: change code style from a = a + x to a += x

2016-07-01 Thread Yisen Zhuang
ned-off-by: Daode Huang <huangda...@hisilicon.com> Signed-off-by: Yisen Zhuang <yisen.zhu...@huawei.com> --- drivers/net/ethernet/hisilicon/hns/hns_dsaf_main.c | 32 +++--- 1 file changed, 16 insertions(+), 16 deletions(-) diff --git a/drivers/net/ethernet/hisilicon/hns/hns_dsaf_

[PATCH v3 net-next 8/9] net: hns: add media-type property for hns

2016-07-01 Thread Yisen Zhuang
Yan <yankej...@huawei.com> Signed-off-by: Yisen Zhuang <yisen.zhu...@huawei.com> --- drivers/net/ethernet/hisilicon/hns/hnae.h | 9 drivers/net/ethernet/hisilicon/hns/hns_ae_adapt.c | 1 + drivers/net/ethernet/hisilicon/hns/hns_dsaf_mac.c | 26 +++ driver

[PATCH v2 net-next 9/9] net: hns: get reset registers from DT

2016-06-30 Thread Yisen Zhuang
From: Kejian Yan Since the registers of subctrl may be different, it is better to mv the registers from hns mdio driver routine to device tree node. Signed-off-by: Kejian Yan --- change log: v2: fix the wrong indentations v1: first submit link:

[PATCH v2 net-next 8/9] net: hns: add media-type property for hns

2016-06-30 Thread Yisen Zhuang
From: Kejian Yan It is PORT_TP type if the service port is GE mode. It is wrong to judge the port type by using if it is service port. Adding the media type to know port type. Reported-by: Jinchuan Tian Signed-off-by: Kejian Yan

[PATCH v2 net-next 2/9] net: hns: fix code style about hns driver

2016-06-30 Thread Yisen Zhuang
From: Daode Huang This patch fixes code sytle of hns driver to make it simple. Signed-off-by: Daode Huang --- drivers/net/ethernet/hisilicon/hns/hns_dsaf_misc.c | 16 +++- 1 file changed, 7 insertions(+), 9 deletions(-) diff

[PATCH v2 net-next 5/9] net: hns: add a space before "*/"

2016-06-30 Thread Yisen Zhuang
From: Daode Huang In comment line, some time miss a space before */, so this patch adds a space before */. Signed-off-by: Daode Huang --- drivers/net/ethernet/hisilicon/hns/hns_enet.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)

[PATCH v2 net-next 3/9] net: hns: change code style from a = a + x to a += x

2016-06-30 Thread Yisen Zhuang
From: Daode Huang This patch fixes the code style in hns driver. Change it from "buff = buff + xxx" to "buff += xxx". The reveiw comments is from andy. Reviewed-by: Andriy Shevchenko Signed-off-by: Daode Huang

[PATCH v2 net-next 1/9] MAINTAINERS: add maintainers for hns driver

2016-06-30 Thread Yisen Zhuang
1a9..c819659 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -5421,6 +5421,15 @@ F: include/uapi/linux/if_hippi.h F: net/802/hippi.c F: drivers/net/hippi/ +HISILICON NETWORK SUBSYSTEM DRIVER +M: Yisen Zhuang <yisen.zhu...@huawei.com> +M: Salil Mehta <salil.me...@huawe

[PATCH v2 net-next 0/9] net: hns: fix the typo of hns

2016-06-30 Thread Yisen Zhuang
This series includes typo fixes which review by Andy, adding the hns maintainer to MAINTAINERS, as below: > from Daode: adds the maintainer for hns driver; > from Daode: fix the typo of hns reviewed by Andy Shevchenko; > from Kejian: one remove redundant function and two fix to get

[PATCH v2 net-next 6/9] net: hns: normalize two different loop

2016-06-30 Thread Yisen Zhuang
From: Daode Huang There are two approaches to assign data, one does 2 loops, another does 1 loop. This patch normalize the different methods to 1 loop. Signed-off-by: Daode Huang --- drivers/net/ethernet/hisilicon/hns/hns_dsaf_main.c | 18

[PATCH v2 net-next 4/9] net: hns: delete redundant parenthese

2016-06-30 Thread Yisen Zhuang
From: Daode Huang According to the previous review comments from Andy, this patch deletes the redundant parens in the patch. Signed-off-by: Daode Huang --- drivers/net/ethernet/hisilicon/hns/hns_dsaf_main.c | 4 ++-- 1 file changed, 2

[PATCH v2 net-next 7/9] net: hns: remove redundant hns_mac_dev_to_enet_if()

2016-06-30 Thread Yisen Zhuang
From: Kejian Yan The sequence of hns_mac_dev_to_enet_if() is the same as hns_get_enet_interface(), and hns_get_enet_interface() is called by initialization to get the mac mode. And the mode is not changed anywhere. Thus add hns_mac_dev_to_enet_if() function to get the mac

[PATCH net-next 7/9] net: hns: remove redundant hns_mac_dev_to_enet_if()

2016-06-27 Thread Yisen Zhuang
From: Kejian Yan The sequence of hns_mac_dev_to_enet_if() is the same as hns_get_enet_interface(), and hns_get_enet_interface() is called by initialization to get the mac mode. And the mode is not changed anywhere. Thus add hns_mac_dev_to_enet_if() function to get the mac

[PATCH net-next 1/9] MAINTAINERS: add maintainers for hns driver

2016-06-27 Thread Yisen Zhuang
1a9..c819659 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -5421,6 +5421,15 @@ F: include/uapi/linux/if_hippi.h F: net/802/hippi.c F: drivers/net/hippi/ +HISILICON NETWORK SUBSYSTEM DRIVER +M: Yisen Zhuang <yisen.zhu...@huawei.com> +M: Salil Mehta <salil.me...@huawe

[PATCH net-next 3/9] net: hns: change code style from a = a + x to a += x

2016-06-27 Thread Yisen Zhuang
From: Daode Huang This patch fixes the code style in hns driver. Change it from "buff = buff + xxx" to "buff += xxx". The reveiw comments is from andy. Reviewed-by: Andriy Shevchenko Signed-off-by: Daode Huang

[PATCH net-next 4/9] net: hns: delete redundant parens

2016-06-27 Thread Yisen Zhuang
From: Daode Huang According to the previous review comments from Andy, this patch deletes the redundant parens in the patch. Signed-off-by: Daode Huang --- drivers/net/ethernet/hisilicon/hns/hns_dsaf_main.c | 4 ++-- 1 file changed, 2

[PATCH net-next 9/9] net: hns: get reset registers from DT

2016-06-27 Thread Yisen Zhuang
From: Kejian Yan Since the registers of subctrl may be different, it is better to mv the registers from hns mdio driver routine to device tree node. Signed-off-by: Kejian Yan --- drivers/net/ethernet/hisilicon/hns_mdio.c | 80

[PATCH net-next 2/9] net: hns: fix code style about hns driver

2016-06-27 Thread Yisen Zhuang
From: Daode Huang This patch fixes code sytle of hns driver to make it simple. Signed-off-by: Daode Huang --- drivers/net/ethernet/hisilicon/hns/hns_dsaf_misc.c | 16 +++- 1 file changed, 7 insertions(+), 9 deletions(-) diff

[PATCH net-next 5/9] net: hns: add a space before "*/"

2016-06-27 Thread Yisen Zhuang
From: Daode Huang In comment line, some time miss a space before */, so this patch adds a space before */. Signed-off-by: Daode Huang --- drivers/net/ethernet/hisilicon/hns/hns_enet.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)

[PATCH net-next 6/9] net: hns: normalize two different loop

2016-06-27 Thread Yisen Zhuang
From: Daode Huang There are two approaches to assign data, one does 2 loops, another does 1 loop. This patch normalize the different methods to 1 loop. Signed-off-by: Daode Huang --- drivers/net/ethernet/hisilicon/hns/hns_dsaf_main.c | 18

[PATCH net-next 8/9] net: hns: add media-type property for hns

2016-06-27 Thread Yisen Zhuang
From: Kejian Yan It is PORT_TP type if the service port is GE mode. It is wrong to judge the port type by using if it is service port. Adding the media type to know port type. Reported-by: Jinchuan Tian Signed-off-by: Kejian Yan

[PATCH net-next 0/9] net: hns: fix the typo of hns

2016-06-27 Thread Yisen Zhuang
This series includes typo fixes which review by Andy, adding the hns maintainer to MAINTAINERS, > adds the maintainer for hns driver from Daode; > from Daode: fix the typo of hns reviewed by Andy Shevchenko; > from Kejian: one remove redundant function and two fix to get configuration from

Re: [PATCH net-next 10/19] net: hns: bugfix about pfc pause frame statistics

2016-06-22 Thread Yisen Zhuang
在 2016/6/22 17:41, Andy Shevchenko 写道: > On Wed, 2016-06-22 at 09:43 +0800, Yisen Zhuang wrote: >> >> 在 2016/6/21 18:32, Andy Shevchenko 写道: >>> On Tue, 2016-06-21 at 11:56 +0800, Yisen Zhuang wrote: >>>> From: Daode Huang <huangda...@hisilicon.com>

Re: [PATCH net-next 16/19] net: hns: fix bug that alloc skb fail lead to port unavailable

2016-06-21 Thread Yisen Zhuang
在 2016/6/21 21:25, Sergei Shtylyov 写道: > Hello. > > On 6/21/2016 6:56 AM, Yisen Zhuang wrote: > >> From: Jun He <hjat2...@huawei.com> >> >> When hns_nic_poll_rx_skb alloc skb fail, it will break receive cycle and >> read new fbd_num to start

Re: [PATCH net-next 10/19] net: hns: bugfix about pfc pause frame statistics

2016-06-21 Thread Yisen Zhuang
在 2016/6/21 18:32, Andy Shevchenko 写道: > On Tue, 2016-06-21 at 11:56 +0800, Yisen Zhuang wrote: >> From: Daode Huang <huangda...@hisilicon.com> >> >> For SoC hip06, PFC pause handled in dsaf, while hip05 in XGMAC, >> so change the statistics of pfc pause in dsa

Re: [PATCH net-next 01/19] net: hns: bug fix of ge reset sequence

2016-06-21 Thread Yisen Zhuang
在 2016/6/21 18:35, Andy Shevchenko 写道: > On Tue, 2016-06-21 at 11:56 +0800, Yisen Zhuang wrote: >> From: Qianqian Xie <xieqianq...@huawei.com> >> >> The bit fileds of PPE reset register are different between HNS v1 and >> HNS v2, but the current proce

[PATCH net-next 05/19] net: hns: Remove unnecessary device resource free

2016-06-20 Thread Yisen Zhuang
From: Qianqian Xie <xieqianq...@huawei.com> The driver uses devm_ioremap_resource, it will unmap the map automatically, remove the unnecessary the resource free. Signed-off-by: Qianqian Xie <xieqianq...@huawei.com> Reported-by: Kefeng Wang <wangkefeng.w...@huawei.com> Signed-of

[PATCH net-next 06/19] net: hns: fix the error info when dma_set_mask_and_coherent fail

2016-06-20 Thread Yisen Zhuang
From: Qianqian Xie <xieqianq...@huawei.com> The error info should be printed as "set mask to 64bit fail!" instead of "set mask to 32bit fail!" in dma_set_mask_and_coherent(). Signed-off-by: Qianqian Xie <xieqianq...@huawei.com> Signed-off-by: Yisen Zhuang <yi

[PATCH net-next 16/19] net: hns: fix bug that alloc skb fail lead to port unavailable

2016-06-20 Thread Yisen Zhuang
about the port unavailable. So we will goto out when alloc skb fail to fix this bug. Signed-off-by: Jun He <hjat2...@huawei.com> Signed-off-by: Ding Tianhong <dingtianh...@huawei.com> Signed-off-by: Yisen Zhuang <yisen.zhu...@huawei.com> --- drivers/net/ethernet/hisilicon/hns/hns_

[PATCH net-next 04/19] net: hns: typo fix of annotation info for hns_nic_reset_subtask()

2016-06-20 Thread Yisen Zhuang
From: Qianqian Xie <xieqianq...@huawei.com> The annotation info for hns_nic_reset_subtask() should be "for resetting subtask" instead of "for resetting suntask". Signed-off-by: Qianqian Xie <xieqianq...@huawei.com> Signed-off-by: Yisen Zhuang <yisen.zhu...@hu

[PATCH net-next 08/19] net: hns: fix ethtool loopback fail bug

2016-06-20 Thread Yisen Zhuang
right status. Reported-by: hejun <hjat2...@huawei.com> Signed-off-by: Kejian Yan <yankej...@huawei.com> Signed-off-by: Yisen Zhuang <yisen.zhu...@huawei.com> --- drivers/net/ethernet/hisilicon/hns/hns_ethtool.c | 35 ++-- 1 file changed, 14 insertions(+), 21

[PATCH net-next 19/19] net: hns: bug fix about TSO on|off when there is traffic

2016-06-20 Thread Yisen Zhuang
riptor. Signed-off-by: Daode Huang <huangda...@hisilicon.com> Signed-off-by: Yisen Zhuang <yisen.zhu...@huawei.com> --- drivers/net/ethernet/hisilicon/hns/hns_enet.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/net/ethernet/hisilicon/hns/hns_ene

[PATCH net-next 03/19] net: hns: add skb_reset_mac_header() after skb being alloc

2016-06-20 Thread Yisen Zhuang
From: Kejian Yan <yankej...@huawei.com> HNS receives a packet without doing anything, but it should call skb_reset_mac_header() to initialize the header before using eth_hdr(). Fixes: 0d6b425a3773c3445b0f51b2f333821beaacb619 Signed-off-by: Kejian Yan <yankej...@huawei.com> Signed-o

[PATCH net-next 02/19] net: hns: fix hns dsaf v1 dont support tx_pause close

2016-06-20 Thread Yisen Zhuang
From: Qianqian Xie <xieqiaq...@huawei.com> For service port, hns dsaf v1 support to close tx_pause. However, the port will be invalid when it run command ethtool to close tx_pause. This patch will fix it. Signed-off-by: Qianqian Xie <xieqiaq...@huawei.com> Signed-off-by: Yisen Zhuan

[PATCH net-next 17/19] net: hns: fix sbm default parameters config error

2016-06-20 Thread Yisen Zhuang
; Signed-off-by: Yisen Zhuang <yisen.zhu...@huawei.com> --- drivers/net/ethernet/hisilicon/hns/hns_dsaf_main.c | 40 ++ drivers/net/ethernet/hisilicon/hns/hns_dsaf_reg.h | 16 +++-- 2 files changed, 39 insertions(+), 17 deletions(-) diff --git a/drivers/net/ethe

[PATCH net-next 15/19] net: hns: bug fix about led control logic when link down

2016-06-20 Thread Yisen Zhuang
blink frequece other than the driver itself. Signed-off-by: Daode Huang <huangda...@hisilicon.com> Signed-off-by: Yisen Zhuang <yisen.zhu...@huawei.com> --- drivers/net/ethernet/hisilicon/hns/hns_dsaf_misc.c | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-) diff -

[PATCH net-next 12/19] net: hns: fix bug of getting the wrong tcam data

2016-06-20 Thread Yisen Zhuang
licon.com> Signed-off-by: Yisen Zhuang <yisen.zhu...@huawei.com> --- drivers/net/ethernet/hisilicon/hns/hns_dsaf_main.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/net/ethernet/hisilicon/hns/hns_dsaf_main.c b/drivers/net/ethernet/hisilicon/hns/hns

[PATCH net-next 14/19] net: hns: delete redundancy ring enable operations

2016-06-20 Thread Yisen Zhuang
t;huangda...@hisilicon.com> Signed-off-by: Yisen Zhuang <yisen.zhu...@huawei.com> --- drivers/net/ethernet/hisilicon/hns/hnae.c | 1 - drivers/net/ethernet/hisilicon/hns/hnae.h | 1 - drivers/net/ethernet/hisilicon/hns/hns_ae_adapt.c | 22 +- dr

[PATCH net-next 00/19] net: hns: fix some bugs in hns driver

2016-06-20 Thread Yisen Zhuang
This series includes some bugs fixed. All these patches needs to be applied after the patchset about ACPI support, so this series is floated to net-next list. The patches are: > from Daode, fixes about pfc pause frame, getting coaslesce, led control logic, TSO on|off and tcam table

[PATCH net-next 10/19] net: hns: bugfix about pfc pause frame statistics

2016-06-20 Thread Yisen Zhuang
From: Daode Huang <huangda...@hisilicon.com> For SoC hip06, PFC pause handled in dsaf, while hip05 in XGMAC, so change the statistics of pfc pause in dsaf and remove the old pfc pause frame statistics. Signed-off-by: Daode Huang <huangda...@hisilicon.com> Signed-off-by: Yisen Zhuan

[PATCH net-next 13/19] net: hns: add get_coalesce_range api for hns

2016-06-20 Thread Yisen Zhuang
From: Daode Huang <huangda...@hisilicon.com> This patch adds get_coalesce_range api for hns, it shows range of coalesce usecs and frames that can be set on this interface. Signed-off-by: Daode Huang <huangda...@hisilicon.com> Signed-off-by: Yisen Zhuang <yisen.zhu...@huawei.com>

[PATCH net-next 09/19] net: hns: fix the wrong speed for bond

2016-06-20 Thread Yisen Zhuang
value at that time.That make for bond's wrong speed. Thus only one state machine should be used and if phy_state_machine is used, it does not need to do hns_nic_update_link_status(). Signed-off-by: Qianqian Xie <xieqianq...@huawei.com> Signed-off-by: Yisen Zhuang <yisen.zhu...@huawei.com>

[PATCH net-next 18/19] net: hns: change the default coalesce usecs

2016-06-20 Thread Yisen Zhuang
t;huangda...@hisilicon.com> Signed-off-by: Yisen Zhuang <yisen.zhu...@huawei.com> --- drivers/net/ethernet/hisilicon/hns/hns_dsaf_rcb.c | 2 +- drivers/net/ethernet/hisilicon/hns/hns_dsaf_rcb.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/hisilicon/hns

[PATCH net-next 01/19] net: hns: bug fix of ge reset sequence

2016-06-20 Thread Yisen Zhuang
ie <xieqianq...@huawei.com> Signed-off-by: Yisen Zhuang <yisen.zhu...@huawei.com> --- drivers/net/ethernet/hisilicon/hns/hns_dsaf_misc.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/hisilicon/hns/hns_dsaf_misc.c b/drivers/net/ethernet/hisilicon/h

[PATCH net-next 11/19] net: hns: add spin lock for tcam table operation

2016-06-20 Thread Yisen Zhuang
From: Daode Huang <huangda...@hisilicon.com> This patch adds spin lock for tcam table operation, there maybe a race condition happens when more than one thread try to change the tcam talbe entries. Signed-off-by: Daode Huang <huangda...@hisilicon.com> Signed-off-by: Yisen Zhuan

[PATCH net-next 07/19] net: hns: select Hilink before serdes loopback for HNS V2

2016-06-20 Thread Yisen Zhuang
uawei.com> Signed-off-by: Yisen Zhuang <yisen.zhu...@huawei.com> --- drivers/net/ethernet/hisilicon/hns/hns_dsaf_misc.c | 26 +- 1 file changed, 20 insertions(+), 6 deletions(-) diff --git a/drivers/net/ethernet/hisilicon/hns/hns_dsaf_misc.c b/drivers/net/ethe

Re: [patch net-next] net: hns: add skb_reset_mac_header() after skb being alloc

2016-06-20 Thread Yisen Zhuang
在 2016/6/15 18:30, Yisen Zhuang 写道: > Hi David, > > Thanks for your suggestions. > > Please see my comments below. > > Thanks, > > Yisen > > 在 2016/6/15 13:41, David Miller 写道: >> From: Yisen Zhuang <yisen.zhu...@huawei.com> >> Date: Mon,

Re: [patch net-next] net: hns: add skb_reset_mac_header() after skb being alloc

2016-06-15 Thread Yisen Zhuang
Hi David, Thanks for your suggestions. Please see my comments below. Thanks, Yisen 在 2016/6/15 13:41, David Miller 写道: > From: Yisen Zhuang <yisen.zhu...@huawei.com> > Date: Mon, 13 Jun 2016 20:41:22 +0800 > >> From: Kejian Yan <yankej...@huawei.com> >> >&

Re: [PATCH] net: hns: update the dependency

2016-06-15 Thread Yisen Zhuang
Hi David, I'm really sorry for this. Because i didn't receive the first two emails, i resented it a few times. I will pay more attention next time. Thanks, Yisen 在 2016/6/15 14:24, David Miller 写道: > From: Yisen Zhuang <yisen.zhu...@huawei.com> > Date: Wed, 15 Jun 2016 14

Re: [PATCH] net: hns: update the dependency

2016-06-15 Thread Yisen Zhuang
Hi David, You mean that i send this patch 3 times? I am sorry for this. I don't know why you can receive 3 times. I can only receive an email for this patch. Thanks, Yisen 在 2016/6/15 13:26, David Miller 写道: > From: Yisen Zhuang <yisen.zhu...@huawei.com> > Date: Mon, 13 Jun 2

[patch net-next] net: hns: add skb_reset_mac_header() after skb being alloc

2016-06-13 Thread Yisen Zhuang
From: Kejian Yan <yankej...@huawei.com> HNS receives a packet without doing anything, but it should call skb_reset_mac_header() to initialize the header before using eth_hdr(). Fixes: 0d6b425a3773c3445b0f51b2f333821beaacb619 Signed-off-by: Kejian Yan <yankej...@huawei.com> Signed-o

[PATCH] net: hns: update the dependency

2016-06-13 Thread Yisen Zhuang
From: Kejian Yan <yankej...@huawei.com> After the patchset about adding support of ACPI (commit id is 6343488) being applied, HNS does not depend on OF. It depends on OF or ACPI, so the Kconfig file needs to be updated. Signed-off-by: Kejian Yan <yankej...@huawei.com> Signed-off-by:

[PATCH] net: hns: update the dependency

2016-06-13 Thread Yisen Zhuang
From: Kejian Yan <yankej...@huawei.com> After the patchset about adding support of ACPI (commit id is 6343488) being applied, HNS does not depend on OF. It depends on OF or ACPI, so the Kconfig file needs to be updated. Signed-off-by: Kejian Yan <yankej...@huawei.com> Signed-off-by:

[PATCH] net: hns: update the dependency

2016-06-13 Thread Yisen Zhuang
From: Kejian Yan <yankej...@huawei.com> After the patchset about adding support of ACPI (commit id is 6343488) being applied, HNS does not depend on OF. It depends on OF or ACPI, so the Kconfig file needs to be updated. Signed-off-by: Kejian Yan <yankej...@huawei.com> Signed-off-by:

[PATCH v4 net-next 06/13] net: hns: use platform_get_irq instead of irq_of_parse_and_map

2016-06-02 Thread Yisen Zhuang
From: Kejian Yan <yankej...@huawei.com> As irq_of_parse_and_map is only used by DT case, it is excepted to use a uniform interface. So it is used platform_get_irq() instead. Signed-off-by: Kejian Yan <yankej...@huawei.com> Signed-off-by: Yisen Zhuang <yisen.zhu...@huawei.com>

[PATCH v4 net-next 09/13] net: hns: add dsaf misc operation method

2016-06-02 Thread Yisen Zhuang
uawei.com> Signed-off-by: Yisen Zhuang <yisen.zhu...@huawei.com> --- drivers/net/ethernet/hisilicon/hns/hns_ae_adapt.c | 4 +- drivers/net/ethernet/hisilicon/hns/hns_dsaf_gmac.c | 6 +- drivers/net/ethernet/hisilicon/hns/hns_dsaf_mac.c | 14 ++-- drivers/net/ethernet/hisilicon/hns/hn

[PATCH v4 net-next 08/13] net: hns: add uniform interface for phy connection

2016-06-02 Thread Yisen Zhuang
needs to use uniform interface to handle that sequence by both DT and ACPI. Signed-off-by: Kejian Yan <yankej...@huawei.com> Signed-off-by: Yisen Zhuang <yisen.zhu...@huawei.com> --- change log: v2: 1. remove the redundant functions, and 2. adds fwnode match method beside DT and

[PATCH v4 net-next 00/13] net: hns: add support of ACPI

2016-06-02 Thread Yisen Zhuang
From: Kejian Yan This series adds HNS support of acpi. The routine will call some ACPI helper functions, like acpi_dev_found() and acpi_evaluate_dsm(), which are not included in other cases. In order to make system compile successfully in other cases except ACPI, it needs

[PATCH v4 net-next 01/13] ACPI: bus: add stub acpi_dev_found() to linux/acpi.h

2016-06-02 Thread Yisen Zhuang
acpi.h to make compiled successfully in non-ACPI cases. Cc: Rafael J. Wysocki <r...@rjwysocki.net> Signed-off-by: Kejian Yan <yankej...@huawei.com> Signed-off-by: Yisen Zhuang <yisen.zhu...@huawei.com> --- include/linux/acpi.h | 5 + 1 file changed, 5 insertions(+) diff --git

[PATCH v4 net-next 12/13] net: hns: implement the miscellaneous operation by asl

2016-06-02 Thread Yisen Zhuang
From: Kejian Yan <yankej...@huawei.com> The miscellaneous operation is implemented in BIOS, the kernel can call _DSM method help to call the implementation in ACPI case. Here is a patch to do that. Signed-off-by: Kejian Yan <yankej...@huawei.com> Signed-off-by: Yisen Zhuan

[PATCH v4 net-next 04/13] net: hisilicon: add support of acpi for hns-mdio

2016-06-02 Thread Yisen Zhuang
quence by _RST method in DSDT in ACPI case. Signed-off-by: Kejian Yan <yankej...@huawei.com> Signed-off-by: Yisen Zhuang <yisen.zhu...@huawei.com> --- change log: v2: 1. use dev_of_node instead of IS_ENABLED macro 2. Add ACPI bits v1: first submit Link: https://lk

[PATCH v4 net-next 03/13] net: hisilicon: cleanup to prepare for other cases

2016-06-02 Thread Yisen Zhuang
From: Kejian Yan <yankej...@huawei.com> Hns-mdio only supports DT case now. do some cleanup to prepare for introducing other cases later, no functional change. Signed-off-by: Kejian Yan <yankej...@huawei.com> Signed-off-by: Yisen Zhuang <yisen.zhu...@huawei.com> --- change

[PATCH v4 net-next 07/13] net: hns: enet specify a reference to dsaf by fwnode_handle

2016-06-02 Thread Yisen Zhuang
From: Kejian Yan <yankej...@huawei.com> As device_node is only used by DT case, it is expected to find uniform ways. So fwnode_handle is the suitable method. Signed-off-by: Kejian Yan <yankej...@huawei.com> Signed-off-by: Yisen Zhuang <yisen.zhu...@huawei.com> --- chang

[PATCH v4 net-next 13/13] net: hns: net: hns: enet adds support of acpi

2016-06-02 Thread Yisen Zhuang
From: Kejian Yan <yankej...@huawei.com> Enet needs to get configration parameter by acpi. This patch adds support of ACPI for enet. The configuration parameter will be configed in BIOS. Signed-off-by: Kejian Yan <yankej...@huawei.com> Signed-off-by: Yisen Zhuang <yisen.zh

[PATCH v4 net-next 10/13] net: hns: dsaf adds support of acpi

2016-06-02 Thread Yisen Zhuang
From: Kejian Yan <yankej...@huawei.com> Dsaf needs to get configuration parameter by ACPI, so this patch add support of ACPI. Signed-off-by: Kejian Yan <yankej...@huawei.com> Signed-off-by: Yisen Zhuang <yisen.zhu...@huawei.com> --- change log: v2: 1. use dev_of_node() ins

[PATCH v4 net-next 11/13] net: hns: register phy device in each mac initial sequence

2016-06-02 Thread Yisen Zhuang
PHY PHY Signed-off-by: Kejian Yan <yankej...@huawei.com> Signed-off-by: Yisen Zhuang <yisen.zhu...@huawei.com> --- change log: v2: fix the build error by kbuild test robot v1: first submit link: https://lkml.org/lkml/2016/5/13/97 --- drivers/net/ethernet/hisilicon/hns/hn

[PATCH v4 net-next 02/13] ACPI: bus: add stub acpi_evaluate_dsm() to linux/acpi.h

2016-06-02 Thread Yisen Zhuang
o make compiled successfully in non-ACPI cases. Cc: Rafael J. Wysocki <r...@rjwysocki.net> Signed-off-by: Kejian Yan <yankej...@huawei.com> Signed-off-by: Yisen Zhuang <yisen.zhu...@huawei.com> --- include/linux/acpi.h | 8 1 file changed, 8 insertions(+) diff --git a/includ

[PATCH v4 net-next 05/13] net: hns: use device_* APIs instead of of_* APIs

2016-06-02 Thread Yisen Zhuang
From: Kejian Yan <yankej...@huawei.com> OF series functions can be used only for DT case. Use unified device property function instead to support both DT and ACPI. Signed-off-by: Kejian Yan <yankej...@huawei.com> Signed-off-by: Yisen Zhuang <yisen.zhu...@huawei.com> --- dr

Re: [PATCH v3 net-next 03/13] net: hisilicon: cleanup to prepare for other cases

2016-06-02 Thread Yisen Zhuang
Hi David, Thanks for your comment, i will use dev name of this mdio bus instead of address. Thanks, Yisen 在 2016/6/2 7:07, David Miller 写道: > From: Yisen Zhuang <yisen.zhu...@huawei.com> > Date: Mon, 30 May 2016 20:34:14 +0800 > >> -static void hns_mdio_bus_na

[PATCH v3 net-next 10/13] net: hns: dsaf adds support of acpi

2016-05-30 Thread Yisen Zhuang
From: Kejian Yan <yankej...@huawei.com> Dsaf needs to get configuration parameter by ACPI, so this patch add support of ACPI. Signed-off-by: Kejian Yan <yankej...@huawei.com> Reviewed-by: Andy Shevchenko <andriy.shevche...@linux.intel.com> Signed-off-by: Yisen Zhuang <yi

[PATCH v3 net-next 00/13] net: hns: add support of ACPI

2016-05-30 Thread Yisen Zhuang
From: Kejian Yan This series adds HNS support of acpi. The routine will call some ACPI helper functions, like acpi_dev_found() and acpi_evaluate_dsm(), which are not included in other cases. In order to make system compile successfully in other cases except ACPI, it needs

[PATCH v3 net-next 01/13] ACPI: bus: add stub acpi_dev_found() to linux/acpi.h

2016-05-30 Thread Yisen Zhuang
acpi.h to make compiled successfully in non-ACPI cases. Cc: Rafael J. Wysocki <r...@rjwysocki.net> Signed-off-by: Kejian Yan <yankej...@huawei.com> Signed-off-by: Yisen Zhuang <yisen.zhu...@huawei.com> --- include/linux/acpi.h | 5 + 1 file changed, 5 insertions(+) diff --git

[PATCH v3 net-next 08/13] net: hns: add uniform interface for phy connection

2016-05-30 Thread Yisen Zhuang
needs to use uniform interface to handle that sequence by both DT and ACPI. Signed-off-by: Kejian Yan <yankej...@huawei.com> Reviewed-by: Andy Shevchenko <andriy.shevche...@linux.intel.com> Signed-off-by: Yisen Zhuang <yisen.zhu...@huawei.com> --- change log: v3: add Reviewed-

[PATCH v3 net-next 02/13] ACPI: bus: add stub acpi_evaluate_dsm() to linux/acpi.h

2016-05-30 Thread Yisen Zhuang
o make compiled successfully in non-ACPI cases. Cc: Rafael J. Wysocki <r...@rjwysocki.net> Signed-off-by: Kejian Yan <yankej...@huawei.com> Signed-off-by: Yisen Zhuang <yisen.zhu...@huawei.com> --- include/linux/acpi.h | 8 1 file changed, 8 insertions(+) diff --git a/includ

[PATCH v3 net-next 06/13] net: hns: use platform_get_irq instead of irq_of_parse_and_map

2016-05-30 Thread Yisen Zhuang
From: Kejian Yan <yankej...@huawei.com> As irq_of_parse_and_map is only used by DT case, it is excepted to use a uniform interface. So it is used platform_get_irq() instead. Signed-off-by: Kejian Yan <yankej...@huawei.com> Signed-off-by: Yisen Zhuang <yisen.zhu...@huawei.com>

[PATCH v3 net-next 04/13] net: hisilicon: add support of acpi for hns-mdio

2016-05-30 Thread Yisen Zhuang
quence by _RST method in DSDT in ACPI case. Signed-off-by: Kejian Yan <yankej...@huawei.com> Reviewed-by: Andy Shevchenko <andriy.shevche...@linux.intel.com> Signed-off-by: Yisen Zhuang <yisen.zhu...@huawei.com> --- change log: v3: add Reviewed-by: Andy Shevchenko v2:

[PATCH v3 net-next 11/13] net: hns: register phy device in each mac initial sequence

2016-05-30 Thread Yisen Zhuang
PHY PHY Signed-off-by: Kejian Yan <yankej...@huawei.com> Signed-off-by: Yisen Zhuang <yisen.zhu...@huawei.com> --- change log: v2: fix the build error by kbuild test robot v1: first submit link: https://lkml.org/lkml/2016/5/13/97 --- drivers/net/ethernet/hisilicon/hns/hn

[PATCH v3 net-next 05/13] net: hns: use device_* APIs instead of of_* APIs

2016-05-30 Thread Yisen Zhuang
From: Kejian Yan <yankej...@huawei.com> OF series functions can be used only for DT case. Use unified device property function instead to support both DT and ACPI. Signed-off-by: Kejian Yan <yankej...@huawei.com> Signed-off-by: Yisen Zhuang <yisen.zhu...@huawei.com> --- dr

[PATCH v3 net-next 13/13] net: hns: net: hns: enet adds support of acpi

2016-05-30 Thread Yisen Zhuang
From: Kejian Yan <yankej...@huawei.com> Enet needs to get configration parameter by acpi. This patch adds support of ACPI for enet. The configuration parameter will be configed in BIOS. Signed-off-by: Kejian Yan <yankej...@huawei.com> Signed-off-by: Yisen Zhuang <yisen.zh

[PATCH v3 net-next 07/13] net: hns: enet specify a reference to dsaf by fwnode_handle

2016-05-30 Thread Yisen Zhuang
From: Kejian Yan <yankej...@huawei.com> As device_node is only used by DT case, it is expected to find uniform ways. So fwnode_handle is the suitable method. Signed-off-by: Kejian Yan <yankej...@huawei.com> Reviewed-by: Andy Shevchenko <andriy.shevche...@linux.intel.com> Si

[PATCH v3 net-next 12/13] net: hns: implement the miscellaneous operation by asl

2016-05-30 Thread Yisen Zhuang
;andriy.shevche...@linux.intel.com> Signed-off-by: Yisen Zhuang <yisen.zhu...@huawei.com> --- change log: v3: fix potential memory leak add Reviewed-by: Andy Shevchenko v2: use a serial function to implement the reset sequence link: https://lkml.org/lkml/2016/5/29/186 v1: fi

[PATCH v3 net-next 09/13] net: hns: add dsaf misc operation method

2016-05-30 Thread Yisen Zhuang
uawei.com> Signed-off-by: Yisen Zhuang <yisen.zhu...@huawei.com> --- drivers/net/ethernet/hisilicon/hns/hns_ae_adapt.c | 4 +- drivers/net/ethernet/hisilicon/hns/hns_dsaf_gmac.c | 6 +- drivers/net/ethernet/hisilicon/hns/hns_dsaf_mac.c | 14 ++-- drivers/net/ethernet/hisilicon/hns/hn

[PATCH v3 net-next 03/13] net: hisilicon: cleanup to prepare for other cases

2016-05-30 Thread Yisen Zhuang
From: Kejian Yan <yankej...@huawei.com> Hns-mdio only supports DT case now. do some cleanup to prepare for introducing other cases later, no functional change. Signed-off-by: Kejian Yan <yankej...@huawei.com> Signed-off-by: Yisen Zhuang <yisen.zhu...@huawei.com> --- dr

Re: [PATCH 1/1] net: hns: avoid null pointer dereference

2016-05-17 Thread Yisen Zhuang
Hi Heinrich, This patch is fine to me. Thanks, Yisen 在 2016/5/18 4:01, Heinrich Schuchardt 写道: > In the statement > assert(priv || priv->ae_handle); > the right side of || is only evaluated if priv is null. > > Signed-off-by: Heinrich Schuchardt > --- >

[patch net-next 07/11] net: hns: dsaf adds support of acpi

2016-05-13 Thread Yisen Zhuang
From: Kejian Yan <yankej...@huawei.com> Dsaf needs to get configuration parameter by ACPI, so this patch add support of ACPI. Signed-off-by: Kejian Yan <yankej...@huawei.com> Signed-off-by: Yisen Zhuang <yisen.zhu...@huawei.com> --- drivers/net/ethernet/hisilicon/hns/hns

[patch net-next 03/11] net: hns: use platform_get_irq instead of irq_of_parse_and_map

2016-05-13 Thread Yisen Zhuang
From: Kejian Yan <yankej...@huawei.com> As irq_of_parse_and_map is only used by OF case, it is excepted to use a uniform interface. So it is used platform_get_irq() instead. Signed-off-by: Kejian Yan <yankej...@huawei.com> Signed-off-by: Yisen Zhuang <yisen.zhu...@huawei.com>

[patch net-next 05/11] net: hns: add uniform interface for phy connection

2016-05-13 Thread Yisen Zhuang
needs to add uniform interface to handle that sequence by both OF and ACPI. Signed-off-by: Kejian Yan <yankej...@huawei.com> Signed-off-by: Yisen Zhuang <yisen.zhu...@huawei.com> --- drivers/net/ethernet/hisilicon/hns/hnae.h | 2 +- drivers/net/ethernet/hisilicon/hns/hn

[patch net-next 09/11] ACPI: bus: add stub acpi_evaluate_dsm() to linux/acpi.h

2016-05-13 Thread Yisen Zhuang
o make compiled successfully in non-ACPI cases. Cc: Rafael J. Wysocki <r...@rjwysocki.net> Signed-off-by: Kejian Yan <yankej...@huawei.com> Signed-off-by: Yisen Zhuang <yisen.zhu...@huawei.com> --- include/linux/acpi.h | 8 1 file changed, 8 insertions(+) diff --git a/includ

[patch net-next 08/11] net: hns: register phy device in each mac initial sequence

2016-05-13 Thread Yisen Zhuang
PHY PHY Signed-off-by: Kejian Yan <yankej...@huawei.com> Signed-off-by: Yisen Zhuang <yisen.zhu...@huawei.com> --- drivers/net/ethernet/hisilicon/hns/hns_dsaf_mac.c | 119 +- 1 file changed, 115 insertions(+), 4 deletions(-) diff --git a/drivers/net/ethe

  1   2   >