Hi Stephen,
> From: Stephen Rothwell, Sent: Wednesday, February 17, 2021 6:18 AM
> On Tue, 16 Feb 2021 11:53:56 + Yoshihiro Shimoda
> wrote:
> >
> > > From: Stephen Rothwell, Sent: Tuesday, February 16, 2021 11:05 AM
> >
> > > diff --cc arch/arm6
/dts/toshiba/tmpv7708-rm-mbrc.dtb' failed
make[2]: *** [arch/arm64/boot/dts/toshiba/tmpv7708-rm-mbrc.dtb] Error 1
scripts/Makefile.build:530: recipe for target 'arch/arm64/boot/dts/toshiba'
failed
Best regards,
Yoshihiro Shimoda
Hi Andrew,
> From: Andrew Lunn, Sent: Wednesday, September 9, 2020 10:47 PM
>
> On Wed, Sep 09, 2020 at 04:18:56AM +, Yoshihiro Shimoda wrote:
> > Hi David,
> >
> > > From: David Miller, Sent: Wednesday, September 9, 2020 12:25 PM
> > >
> > >
after the ethernet cable was
disconnected.
Note that other drivers (like at803x.c) also calls phy_init_hw().
So, perhaps, the driver caused a similar issue too.
Fixes: 9886a4dbd2aa ("net: phy: call phy_disable_interrupts() in phy_init_hw()")
Signed-off-by: Yoshihiro Shimoda
---
Cha
Hi David,
> From: David Miller, Sent: Wednesday, September 9, 2020 12:25 PM
>
> From: Yoshihiro Shimoda
> Date: Wed, 9 Sep 2020 08:55:38 +0900
>
> > Changes from v1:
> > - Fix build error.
>
> When such a fundamental build failure is fixed (it could never
after the ethernet cable was
disconnected.
Note that other drivers (like at803x.c) also calls phy_init_hw().
So, perhaps, the driver caused a similar issue too.
Fixes: 9886a4dbd2aa ("net: phy: call phy_disable_interrupts() in phy_init_hw()")
Signed-off-by: Yoshihiro Shimoda
---
Cha
after the ethernet cable was
disconnected.
Note that other drivers (like at803x.c) also calls phy_init_hw().
So, perhaps, the driver caused a similar issue too.
Fixes: 9886a4dbd2aa ("net: phy: call phy_disable_interrupts() in phy_init_hw()")
Signed-off-by: Yoshihiro Shimoda
---
I obser
Hello!
> From: Sergei Shtylyov, Sent: Friday, July 31, 2020 1:24 AM
>
> Hello!
>
> On 7/30/20 2:37 PM, Yoshihiro Shimoda wrote:
>
> >> From: Yuusuke Ashizuka, Sent: Thursday, July 30, 2020 7:02 PM
> >> Subject: [PATCH v2] ravb: Fixed the problem that rmmod c
o send this patch to the following maintainers
too:
# We can get it by using scripts/get_maintainers.pl.
David S. Miller (maintainer:NETWORKING
DRIVERS,commit_signer:8/8=100%)
Jakub Kicinski (maintainer:NETWORKING DRIVERS)
Best regards,
Yoshihiro Shimoda
> possible in the ifdown state.
&
Behme
Signed-off-by: Yoshihiro Shimoda
Reviewed-by: Sergei Shtylyov
---
Changes from RFC v2:
- Check the return value of ravb_init_dmac() too.
- Update the subject and description.
- Fix the comment in the code.
- Add Reviewed-by Sergei.
https://patchwork.kernel.org/patch/11673621/
Changes from
Hello!
Thank you for your review!
> From: Sergei Shtylyov, Sent: Tuesday, July 21, 2020 2:15 AM
>
> Hello!
>
> On 7/20/20 2:58 PM, Yoshihiro Shimoda wrote:
>
> > According to the report of [1], this driver is possible to cause
> > the following error in ravb_t
the return value of ravb_stop_dma() whether this hardware can be
re-initialized or not. If ravb_stop_dma() fails, ravb_tx_timeout_work()
re-enables TX and RX and just exits.
[1]
https://lore.kernel.org/linux-renesas-soc/20200518045452.2390-1-dirk.be...@de.bosch.com/
Reported-by: Dirk Behme
Sign
Hello!
> From: Sergei Shtylyov, Sent: Monday, July 20, 2020 4:20 AM
>
> Hello!
>
>Sorry about another late reply, was having h/w issues on the new work...
No problem! :) Thank you for your reply!
> On 07/06/2020 12:25 PM, Yoshihiro Shimoda wrote:
> >> May
Hi Geert-san,
> From: Geert Uytterhoeven, Sent: Tuesday, July 14, 2020 9:40 PM
>
> Hi Shimoda-san,
>
> On Tue, Jul 14, 2020 at 1:42 PM Yoshihiro Shimoda
> wrote:
> > > From: Geert Uytterhoeven, Sent: Tuesday, July 14, 2020 5:42 PM
> > > On Tue, Jul
gt; > Also the recent patch to add
> > "r8a77961" just adds to soc_rcar_gen3_whitelist.
>
> Oops, commit 17fe16181639801b ("iommu/renesas: Add support for r8a77961")
> did it wrong, too.
Thank you for the point it out. We should add r8a77961 to the soc_rcar_gen3[].
However, I don't know why I could not realize this issue...
So, I investigated this a little and then, IIUC, glob_match() which
soc_device_match() uses seems to return true, if *pat = "r8a7796" and *str =
"r8a77961".
Best regards,
Yoshihiro Shimoda
Hello!
> From: Sergei Shtylyov, Sent: Monday, July 6, 2020 5:29 AM
>
> Hello!
>
> On 30.06.2020 8:22, Yoshihiro Shimoda wrote:
>
> >>>>>>> From: Yoshihiro Shimoda, Sent: Tuesday, May 26, 2020 6:47 PM
> >>>>>>>
> >
Hello!
> From: Sergei Shtylyov, Sent: Monday, June 29, 2020 5:40 PM
>
> Hello!
>
> On 29.06.2020 8:24, Yoshihiro Shimoda wrote:
>
> >>>>> From: Yoshihiro Shimoda, Sent: Tuesday, May 26, 2020 6:47 PM
> >>>>>
> >>>>> Acco
Hello!
> From: Sergei Shtylyov, Sent: Monday, June 29, 2020 5:40 PM
>
> Hello!
>
> On 29.06.2020 8:24, Yoshihiro Shimoda wrote:
>
> >>>>> From: Yoshihiro Shimoda, Sent: Tuesday, May 26, 2020 6:47 PM
> >>>>>
> >>>>> Acco
Hello!
> From: Yoshihiro Shimoda, Sent: Friday, June 19, 2020 2:46 PM
>
> Hello!
>
> > From: Sergei Shtylyov, Sent: Monday, June 15, 2020 5:13 PM
> >
> > Hello!
> >
> > On 15.06.2020 8:58, Yoshihiro Shimoda wrote:
> >
> > >>
Hello!
> From: Sergei Shtylyov, Sent: Monday, June 15, 2020 5:13 PM
>
> Hello!
>
> On 15.06.2020 8:58, Yoshihiro Shimoda wrote:
>
> >> From: Yoshihiro Shimoda, Sent: Tuesday, May 26, 2020 6:47 PM
> >>
> >> According to the report of [1], this d
Hi Sergei-san,
(add your private email address to CC.)
> From: Yoshihiro Shimoda, Sent: Tuesday, May 26, 2020 6:47 PM
>
> According to the report of [1], this driver is possible to cause
> the following error in ravb_tx_timeout_work().
>
> ravb e680.ethernet ethernet
all queues of TX and RX).
[1]
https://lore.kernel.org/linux-renesas-soc/20200518045452.2390-1-dirk.be...@de.bosch.com/
Reported-by: Dirk Behme
Signed-off-by: Yoshihiro Shimoda
---
I'm guessing that this issue is possible to happen if:
- ravb_start_xmit() calls netif_stop_subqueue(), and
, this patch adds a condition and set the RMII mode
regiseter in sh_eth_dev_exit() for some SoCs.
Note that when I have tried to move the sh_eth_dev_exit() calling
after phy_stop() on sh_eth_close(), but it gets worse.
Signed-off-by: Yoshihiro Shimoda
---
drivers/net/ethernet/renesas/sh_eth.c | 4
the current code of phy_device.c to avoid any side effects.
- Fix the mdio_bus_phy_resume() in phy_device.c.
- Add toggling the phy reset in micrel.c if the PHY is not attached.
Yoshihiro Shimoda (2):
net: phy: Fix not to call phy_resume() if PHY is not attached
net: phy: assert the phy reset during
This patch fixes an issue that mdio_bus_phy_resume() doesn't call
phy_resume() if the PHY is not attached.
Fixes: 803dd9c77ac3 ("net: phy: avoid suspending twice a PHY")
Signed-off-by: Yoshihiro Shimoda
---
drivers/net/phy/phy_device.c | 11 ++-
1 file changed, 6 i
he reset doesn't happen,
it cannot link up.
Signed-off-by: Yoshihiro Shimoda
---
drivers/net/phy/phy_device.c | 8
1 file changed, 8 insertions(+)
diff --git a/drivers/net/phy/phy_device.c b/drivers/net/phy/phy_device.c
index d86356f..09ab62a 100644
--- a/drivers/net/phy/phy_d
phydev, 1); if !phydev->attached_dev in phy_resume()
Idea 2: Toggle the reset in phy_resume().
- call phy_device_reset(phydev, 0); udelay(1); phy_device_reset(phydev, 1);
if !phydev->attached_dev in phy_resume ()
I think the idea 1 is better. But, what do you think?
Best regards,
Yoshihiro Shimoda
Hi,
> From: Sasha Levin, Sent: Thursday, December 13, 2018 1:32 PM
>
> From: Yoshihiro Shimoda
>
> [ Upstream commit ef1b5bf506b1f0ee3edc98533e1f3ecb105eb46a ]
This upstream commit is reverted on mainline as I mentioned other email thread
[1].
So, we should not backport
Hi,
> From: Sasha Levin, Sent: Thursday, December 13, 2018 1:31 PM
>
> From: Yoshihiro Shimoda
>
> [ Upstream commit ef1b5bf506b1f0ee3edc98533e1f3ecb105eb46a ]
This upstream commit is also reverted on mainline
as I mentioned other email thread [1]. So, we should not backport
Hi,
> From: Sasha Levin, Sent: Thursday, December 13, 2018 1:28 PM
>
> From: Yoshihiro Shimoda
>
> [ Upstream commit ef1b5bf506b1f0ee3edc98533e1f3ecb105eb46a ]
This upstream commit is also reverted on mainline
as I mentioned other email thread[1]
[1]
https://lore.
Hi,
> From: Sasha Levin , Sent: Thursday, December 13, 2018 1:28
> PM
>
> From: Yoshihiro Shimoda
>
> [ Upstream commit 8c85f4b81296a530b8af2796c110fa482ac42d4f ]
Since this upstream commit are reverted by the following commit,
we should not backpo
annot link up.
5) ifconfig eth0 down
6) ifconfig eth0 up
--> In this case, it can link up.
Reported-by: Hiromitsu Yamasaki
Signed-off-by: Yoshihiro Shimoda
---
drivers/net/phy/micrel.c | 8
1 file changed, 8 insertions(+)
diff --git a/drivers/net/phy/micrel.c b/drivers/net/phy/mi
This patch fixes an issue that mdio_bus_phy_resume() doesn't call
phy_resume() if the PHY is not attached.
Fixes: 803dd9c77ac3 ("net: phy: avoid suspending twice a PHY")
Signed-off-by: Yoshihiro Shimoda
---
drivers/net/phy/phy_device.c | 11 ++-
1 file changed, 6 i
s from v1 (as RFC):
- No remove the current code of phy_device.c to avoid any side effects.
- Fix the mdio_bus_phy_resume() in phy_device.c.
- Add toggling the phy reset in micrel.c if the PHY is not attached.
Yoshihiro Shimoda (2):
net: phy: Fix not to call phy_resume() if PHY is not attache
Hi Heiner,
> From: Heiner Kallwei, Sent: Wednesday, November 28, 2018 4:46 AM
>
> On 27.11.2018 17:44, Andrew Lunn wrote:
> > On Tue, Nov 27, 2018 at 12:18:20PM +0000, Yoshihiro Shimoda wrote:
> >> Some PHY device needs edge signal of the reset, but the previous co
Hi Andrew,
> From: Andrew Lunn, Sent: Wednesday, November 28, 2018 1:44 AM
>
> On Tue, Nov 27, 2018 at 12:18:20PM +, Yoshihiro Shimoda wrote:
> > Some PHY device needs edge signal of the reset, but the previous code
> > is impossible to achieve it like following:
> &
6) ifconfig eth0 up
--> In this case, it can link up.
This patch is possible to break if ->probe() in a phy driver will
access the PHY. But, I believe ->config_init() only initializes
the PHY. However, I think this patch should be RFC at first.
Reported-by: Hiromitsu Yamasaki
Signed
Add documentation for r8a77990 compatible string to renesas ravb device
tree bindings documentation.
Signed-off-by: Yoshihiro Shimoda
---
Documentation/devicetree/bindings/net/renesas,ravb.txt | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/net/renesas
?
Best regards,
Yoshihiro Shimoda
Add a new compatible string for the R8A77995 (R-Car D3) RAVB.
Acked-by: Geert Uytterhoeven
Signed-off-by: Yoshihiro Shimoda
---
Changes from v1:
- Based on r8a77970 patch.
https://marc.info/?l=linux-renesas-soc&m=150524655515476
- Add Acked-by (Thanks Geert-san!).
Documenta
Hello!
> From: Sergei Shtylyov
> Sent: Thursday, September 14, 2017 1:02 AM
>
> Hello!
>
> On 09/13/2017 03:17 PM, Yoshihiro Shimoda wrote:
>
> > Add a new compatible string for the R8A77995 (R-Car D3) RAVB.
> >
> > Signed-off-by: Yoshihiro Shimoda
Add a new compatible string for the R8A77995 (R-Car D3) RAVB.
Signed-off-by: Yoshihiro Shimoda
---
Documentation/devicetree/bindings/net/renesas,ravb.txt | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/net/renesas,ravb.txt
b/Documentation/devicetree
Hi,
> From: Willem de Bruijn
> Sent: Saturday, July 16, 2016 12:31 AM
>
> On Thu, Jul 14, 2016 at 10:49 PM, Yoshihiro Shimoda
> wrote:
> > Since the sendto syscall doesn't have msg_control buffer,
> > the sock_tx_timestamp() in packet_snd() cannot work correctly
to sk->sk_tsflags as default.
Fixes: c14ac9451c34 ("sock: enable timestamping using control messages")
Cc:
Reported-by: Kazuya Mizuguchi
Reported-by: Keita Kobayashi
Signed-off-by: Yoshihiro Shimoda
---
Changes from v2:
- Fix build error...
Changes from v1:
- Set socks.tsflags to
> -Original Message-
> From: Yoshihiro Shimoda
> Sent: Tuesday, July 19, 2016 2:15 PM
>
> This patch fixes an issue that a syscall (e.g. sendto syscall) cannot
> work correctly. Since the sendto syscall doesn't have msg_control buffer,
> the sock_tx_timestamp() i
to sk->sk_tsflags as default.
Fixes: c14ac9451c34 ("sock: enable timestamping using control messages")
Cc:
Reported-by: Kazuya Mizuguchi
Reported-by: Keita Kobayashi
Signed-off-by: Yoshihiro Shimoda
---
Changes from v1:
- Set socks.tsflags to sk->sk_tsflags as default instead of a con
ot;sock: enable timestamping using control messages")
Cc:
Reported-by: Kazuya Mizuguchi
Reported-by: Keita Kobayashi
Signed-off-by: Yoshihiro Shimoda
---
I'm not sure the network stack world. So, I submit this patch as RFC.
This patch looks like a quick hack, but it could resolve an our issue.
Andrew Morton wrote:
> On Thu, 07 Feb 2008 17:39:23 +0900 Yoshihiro Shimoda <[EMAIL PROTECTED]>
> wrote:
>
>> Add support for Renesas SuperH Ethernet controller.
>> This driver supported SH7710 and SH7712.
>>
>
> Nice looking driver.
>
> Quick co
Add support for Renesas SuperH Ethernet controller.
This driver supported SH7710 and SH7712.
Signed-off-by: Yoshihiro Shimoda <[EMAIL PROTECTED]>
---
drivers/net/Kconfig | 12
drivers/net/Makefile |1
drivers/net/sh_eth.c | 1178 +
drive
Add support for Renesas SuperH Ethernet controller.
This driver supported SH7710 and SH7712.
Signed-off-by: Yoshihiro Shimoda <[EMAIL PROTECTED]>
---
Kconfig | 12
Makefile |1
sh_eth.c | 1175 +++
sh_eth.h
50 matches
Mail list logo
