[PATCH v3] net/mlx5e: Delete unneeded function argument

priv argument is not used by the function, delete it. Fixes: a89842811ea98 ("net/mlx5e: Merge per priority stats groups") Signed-off-by: Yuval Shaia --- v1 -> v2: * Remove blank line as pointed by Leon. v2 -> v3: * Change prefix to mlx5e --- drivers/net/ethern

Re: [PATCH v2] net/mlx5: Delete unneeded function argument

On Thu, Aug 16, 2018 at 09:41:34AM +0300, Gal Pressman wrote: > On 15-Aug-18 18:08, Yuval Shaia wrote: > > priv argument is not used by the function, delete it. > > > > Fixes: a89842811ea98 ("net/mlx5e: Merge per priority stats groups") > > Signed-off-by:

[PATCH v2] net/mlx5: Delete unneeded function argument

priv argument is not used by the function, delete it. Fixes: a89842811ea98 ("net/mlx5e: Merge per priority stats groups") Signed-off-by: Yuval Shaia --- v1 -> v2: * Remove blank line as pointed by Leon. --- drivers/net/ethernet/mellanox/mlx5/core/en_stats.c | 4 ++-- 1 fi

[PATCH] net/mlx5: Delete unneeded function argument

priv argument is not used by the function, delete it. Fixes: a89842811ea98 ("net/mlx5e: Merge per priority stats groups") Signed-off-by: Yuval Shaia --- drivers/net/ethernet/mellanox/mlx5/core/en_stats.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/d

Re: [PATCH net 2/2] net/mlx5e: Cleanup of dcbnl related fields

; Fixes: 2a5e7a1344f4 ("net/mlx5e: Add dcbnl dscp to priority support") > Signed-off-by: Huy Nguyen > Cc: Yuval Shaia > Reviewed-by: Parav Pandit > Signed-off-by: Saeed Mahameed > --- > drivers/net/ethernet/mellanox/mlx5/core/en.h | 2 -- > .../ethernet/mellanox/m

Re: [PATCH 2/3] IB/ipoib: Stop using dev_id to expose port numbers

On Mon, Aug 13, 2018 at 02:42:23PM +0300, Arseny Maslennikov wrote: > Some InfiniBand network devices have multiple ports on the same PCI > function. Prior to this the kernel erroneously used the `dev_id' sysfs > field of those network interfaces to convey the port number to userspace. > >

Re: [PATCH net 2/2] net/mlx5e: Cleanup of dcbnl related fields

Add dcbnl dscp to priority support") > Signed-off-by: Huy Nguyen > Cc: Yuval Shaia > Reviewed-by: Parav Pandit > Signed-off-by: Saeed Mahameed FWIW: Reviewed-by: Yuval Shaia Tested-by: Yuval Shaia > --- > drivers/net/ethernet/mellanox/mlx5/core/en.h | 2 -- >

Re: [PATCH] net/mlx4_en: Fix an error handling path in 'mlx4_en_init_netdev()'

On Thu, May 10, 2018 at 09:02:26AM +0200, Christophe JAILLET wrote: > If an error occurs, 'mlx4_en_destroy_netdev()' is called. > It then calls 'mlx4_en_free_resources()' which does the needed resources > cleanup. > > So, doing some explicit kfree in the error handling path would lead to > some

Re: [PATCH] net: ks8851: fix ks_start_xmit()'s return type

this driver too. > > Signed-off-by: Luc Van Oostenryck <luc.vanoostenr...@gmail.com> Reviewed-by: Yuval Shaia <yuval.sh...@oracle.com> > --- > drivers/net/ethernet/micrel/ks8851_mll.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drive

Re: [PATCH] net/mlx5/core/fpga/ipsec: Fix use-after-free

e as this is enough. net/mlx5: Fix use-after-free Besides that - lgtm. Reviewed-by: Yuval Shaia <yuval.sh...@oracle.com> > --- > drivers/net/ethernet/mellanox/mlx5/core/fpga/ipsec.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/net/ether

Re: [PATCH] net: dev_forward_skb(): Scrub packet's per-netns info only when crossing netns

On Tue, Mar 13, 2018 at 06:13:45PM +0200, Yuval Shaia wrote: > On Tue, Mar 13, 2018 at 05:07:22PM +0200, Liran Alon wrote: > > Before this commit, dev_forward_skb() always cleared packet's > > per-network-namespace info. Even if the packet doesn't cross > > network namespaces.

Re: [PATCH] net: dev_forward_skb(): Scrub packet's per-netns info only when crossing netns

tc filter add dev veth-b parent : basic match 'meta(nf_mark eq 1337)' > action simple "skb->mark 1337!" > dmesg -C > ping 12.0.0.2 > dmesg > > Before this change, the above will print nothing to dmesg. > After this change, "skb->mark 1337!" will

Re: [PATCH net] RDS: Check cmsg_len before dereferencing CMSG_DATA

if (cmsg->cmsg_len < > + CMSG_LEN(sizeof(struct rds_rdma_args))) > + return -EINVAL; > args = CMSG_DATA(cmsg); > *rdma_bytes += args->remote_vec.bytes; > } Reviewed-by: Yuval Shaia

Re: [PATCH V2 net] net: hns3: Updates MSI/MSI-X alloc/free APIs(depricated) to new APIs

Christoph Hellwig <h...@lst.de> > --- > PATCH V2: Yuval Shaia <yuval.sh...@oracle.com> > Link -> https://lkml.org/lkml/2017/11/9/138 > PATCH V1: Initial Submit > --- > .../ethernet/hisilicon/hns3/hns3pf/hclge_main.c| 107 > +++-- > .../e

Re: [PATCH net] net: hns3: Updates MSI/MSI-X alloc/free APIs(depricated) to new APIs

On Wed, Nov 08, 2017 at 11:56:06AM +, Salil Mehta wrote: > This patch migrates the HNS3 driver code from use of depricated PCI > MSI/MSI-X interrupt vector allocation/free APIs to new common APIs. > > Signed-off-by: Salil Mehta > Suggested-by: Christoph Hellwig

Re: [PATCH] net/mlx4: fix spelling mistake: "availible" -> "available"

u16 *availible_vpp, u8 *vpp_p_up); > + u16 *available_vpp, u8 *vpp_p_up); > /** > * mlx4_ALLOCATE_VPP_set - Distribution of VPPs among differnt priorities. > * The total number of VPPs assigned to all for a port must not exceed > - * the valu

Re: [PATCH 1/1] mlx4_en: remove unnecessary returned value check

ruct mlx4_zone_allocator > *zones, u32 uid) > goto out; > } > > - res = __mlx4_zone_remove_one_entry(zone); > + __mlx4_zone_remove_one_entry(zone); > + res = 0; Will look better if initialization will move to variable declaration. Besides this minor thing - lgtm. Reviewed-by: Yuval Shaia <yuval.sh...@oracle.com> > > out: > spin_unlock(>lock); > -- > 2.7.4 >

Re: [PATCH iproute2 V2 1/4] rdma: Add basic infrastructure for RDMA tool

On Mon, Jul 03, 2017 at 05:06:55PM +0300, Leon Romanovsky wrote: > From: Leon Romanovsky > > RDMA devices are cross-functional devices from one side, > but very tailored for the specific markets from another. > > Such diversity caused to spread of RDMA related configuration

Re: [PATCH 1/1] mlx4_en: make mlx4_log_num_mgm_entry_size static

edb 100644 > --- a/drivers/net/ethernet/mellanox/mlx4/mlx4.h > +++ b/drivers/net/ethernet/mellanox/mlx4/mlx4.h > @@ -231,7 +231,6 @@ do { > \ > #define mlx4_warn(mdev, format, ...) \ > dev_

Re: [Patch net] net_sched: move tcf_lock down after gen_replace_estimator()

On Tue, Jun 13, 2017 at 01:36:24PM -0700, Cong Wang wrote: > Laura reported a sleep-in-atomic kernel warning inside Since you added a Reported-by tag below i don't see a reason to specifically mention it in commit log message. > tcf_act_police_init() which calls gen_replace_estimator() with >

Re: [net-next] macvlan: propagate the mac address change status for lowerdev

On Tue, Jun 13, 2017 at 10:45:11PM +0800, Zhang Shengju wrote: > The macvlan dev should propagate the return value of mac address change for > lower device in the passthru mode, instead of always return 0. > > Signed-off-by: Zhang Shengju > --- >

[PATCH v3] net: phy: Make phy_ethtool_ksettings_get return void

Make return value void since function never return meaningfull value Signed-off-by: Yuval Shaia <yuval.sh...@oracle.com> Acked-by: Sergei Shtylyov <sergei.shtyl...@cogentembedded.com> --- v0 ->v1: * These files were missing in v0 * drivers/net/ethernet/rene

[PATCH v2] net: phy: Make phy_ethtool_ksettings_get return void

Make return value void since function never return meaningfull value Signed-off-by: Yuval Shaia <yuval.sh...@oracle.com> Acked-by: Sergei Shtylyov <sergei.shtyl...@cogentembedded.com> --- v0 ->v1: * These files were missing in v0 * drivers/net/ethernet/rene

[PATCH v1] net/phy: Make phy_ethtool_ksettings_get return void

Make return value void since function never return meaningfull value Signed-off-by: Yuval Shaia <yuval.sh...@oracle.com> Acked-by: Sergei Shtylyov <sergei.shtyl...@cogentembedded.com> --- Re-sending since last time forgot to add netdev-list v0 ->v1: * These files wer

[no subject]

subscribe netdev

[PATCH] net/ethtool: Replace memset with compiler directive

Take advantage of compiler variable zero-ing and remove calls to memset. Signed-off-by: Yuval Shaia <yuval.sh...@oracle.com> --- net/core/ethtool.c | 21 +++-- 1 file changed, 7 insertions(+), 14 deletions(-) diff --git a/net/core/ethtool.c b/net/core/ethtool.c index 0

[PATCH v1] net: phy: Delete unused function phy_ethtool_gset

It's unused, so remove it. Signed-off-by: Yuval Shaia <yuval.sh...@oracle.com> --- v0 -> v1: * Add commit message * Update Documentation/networking/phy.txt * Modify commit header message --- Documentation/networking/phy.txt | 1 - drivers/net/phy/phy.c

Re: [PATCH] net/{mii,smsc}: Make mii_ethtool_get_link_ksettings and smc_netdev_get_ecmd return void

On Sun, Jun 04, 2017 at 09:01:33PM +0200, Andrew Lunn wrote: > > diff --git a/drivers/net/cris/eth_v10.c b/drivers/net/cris/eth_v10.c > > index da02041..017f48c 100644 > > --- a/drivers/net/cris/eth_v10.c > > +++ b/drivers/net/cris/eth_v10.c > > @@ -1417,10 +1417,9 @@ static int

Re: [PATCH] net/dec: Make __de_get_link_ksettings return void

On Sun, Jun 04, 2017 at 08:22:05PM +0300, Sergei Shtylyov wrote: > Hello! > > On 6/4/2017 8:08 PM, Yuval Shaia wrote: > > > Make return value void since function never return meaningfull value > > You only make 1 of 2 functions void. It looks like there should be 2 &g

[PATCH] net/{mii,smsc}: Make mii_ethtool_get_link_ksettings and smc_netdev_get_ecmd return void

Make return value void since functions never returns meaningfull value. Signed-off-by: Yuval Shaia <yuval.sh...@oracle.com> --- drivers/net/cris/eth_v10.c | 5 ++--- drivers/net/ethernet/3com/3c59x.c | 4 +++- drivers/net/ethernet/amd/p

[PATCH] net/3com: Make el3_netdev_get_ecmd return void

Make return value void since function never returns meaningfull value. Signed-off-by: Yuval Shaia <yuval.sh...@oracle.com> --- drivers/net/ethernet/3com/3c509.c | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/drivers/net/ethernet/3com/3c509.c b/drivers/net/et

[PATCH] net/phy: Make phy_ethtool_ksettings_get return void

Make return value void since function never return meaningfull value Signed-off-by: Yuval Shaia <yuval.sh...@oracle.com> --- drivers/net/ethernet/broadcom/b44.c| 3 ++- drivers/net/ethernet/broadcom/bcm63xx_enet.c | 3 ++- drivers/net/ethernet/broadcom/genet/bcmg

[PATCH] net/phy: Delete unused function phy_ethtool_gset

Signed-off-by: Yuval Shaia <yuval.sh...@oracle.com> --- drivers/net/phy/phy.c | 24 include/linux/phy.h | 1 - 2 files changed, 25 deletions(-) diff --git a/drivers/net/phy/phy.c b/drivers/net/phy/phy.c index 9c372bf..8e26af5 100644 --- a/drivers/net/phy/phy.c

Re: [PATCH net-next] net/mlx5e: Fix possible memory leak

} > > err = mlx5_encap_alloc(priv->mdev, e->tunnel_type, > @@ -1510,8 +1510,8 @@ static int mlx5e_create_encap_header_ipv6(struct > mlx5e_priv *priv, > > if (!(nud_state & NUD_VALID)) { > neigh_event_send(n, NULL); > - neigh_release(n); > -

Re: [PATCH v4] net/mlx4_core: Use min3 to select number of MSI-X vectors

On Mon, May 15, 2017 at 07:43:04AM +0300, Leon Romanovsky wrote: > On Sun, May 14, 2017 at 10:01:34PM +0300, Yuval Shaia wrote: > > On Fri, May 12, 2017 at 09:10:51AM +0300, Yuval Shaia wrote: > > > Signed-off-by: Yuval Shaia <yuval.sh...@oracle.com> > > > --- &

Re: [PATCH v4] net/mlx4_core: Use min3 to select number of MSI-X vectors

On Fri, May 12, 2017 at 09:10:51AM +0300, Yuval Shaia wrote: > Signed-off-by: Yuval Shaia <yuval.sh...@oracle.com> > --- > v0 -> v1: > * s/"min_t("/"min_t(int" > v1 -> v2: > * Use min3 instead of min_t twice > v2 -> v3: >

[PATCH v4] net/mlx4_core: Use min3 to select number of MSI-X vectors

Signed-off-by: Yuval Shaia <yuval.sh...@oracle.com> --- v0 -> v1: * s/"min_t("/"min_t(int" v1 -> v2: * Use min3 instead of min_t twice v2 -> v3: * Change commit log header message to reflect the changes made in v2 v3 ->

[PATCH v3] net/mlx4_core: Use min3 to select number of MSI-X vectors

Signed-off-by: Yuval Shaia <yuval.sh...@oracle.com> --- v0 -> v1: * s/"min_t("/"min_t(int" v1 -> v2: * Use min3 instead of min_t twice v2 -> v3: * Change commit log header message to reflect the changes made in v2 --- drivers/ne

[PATCH v2] net/mlx4_core: Use min_t instead of if for consistency

Signed-off-by: Yuval Shaia <yuval.sh...@oracle.com> --- v0 -> v1: * s/"min_t("/"min_t(int" v1 -> v2: * Use min3 instead of min_t twice --- drivers/net/ethernet/mellanox/mlx4/main.c | 9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) d

Re: [PATCH v1] net/mlx4_core: Use min_t instead of if for consistency

On Thu, May 11, 2017 at 01:23:29PM +0300, Leon Romanovsky wrote: > On Thu, May 11, 2017 at 11:46:29AM +0300, Yuval Shaia wrote: > > Signed-off-by: Yuval Shaia <yuval.sh...@oracle.com> > > --- > > v0 -> v1: > > * s/"min_t("/"min_t(int" &g

[PATCH v1] net/mlx4_core: Use min_t instead of if for consistency

Signed-off-by: Yuval Shaia <yuval.sh...@oracle.com> --- v0 -> v1: * s/"min_t("/"min_t(int" --- drivers/net/ethernet/mellanox/mlx4/main.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/drivers/net/ethernet/mellanox/mlx4/main.c b/

[PATCH] net/mlx4_core: Use min_t instead of if for consistency

Signed-off-by: Yuval Shaia <yuval.sh...@oracle.com> --- drivers/net/ethernet/mellanox/mlx4/main.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/drivers/net/ethernet/mellanox/mlx4/main.c b/drivers/net/ethernet/mellanox/mlx4/main.c index 7032054..a58b15a

Re: [PATCH] IB/IPoIB: Check the headroom size

back IB LL address into the hard header') > Reported-by: Norbert P <n...@physik.uzh.ch> > Signed-off-by: Honggang Li <ho...@redhat.com> > --- > drivers/infiniband/ulp/ipoib/ipoib_main.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/infiniband/ulp

Re: [PATCH v4] {net,IB}/{rxe,usnic}: Utilize generic mac to eui32 function

On Tue, Mar 14, 2017 at 07:58:43PM +0200, Leon Romanovsky wrote: > On Tue, Mar 14, 2017 at 04:01:57PM +0200, Yuval Shaia wrote: > > This logic seems to be duplicated in (at least) three separate files. > > Move it to one place so code can be re-use. > > > > Signed-of

[PATCH v4] {net,IB}/{rxe,usnic}: Utilize generic mac to eui32 function

This logic seems to be duplicated in (at least) three separate files. Move it to one place so code can be re-use. Signed-off-by: Yuval Shaia <yuval.sh...@oracle.com> --- v0 -> v1: * Add missing #include * Rename to genaddrconf_ifid_eui48 v1 -> v2: * Reset eui[0

Re: [PATCHv2 3/5] rds: ib: remove redundant ib_dealloc_fmr

gt;fmr); > - kfree(ibmr); > - } > + kfree(ibmr); > atomic_dec(>item_count); > + Reviewed-by: Yuval Shaia <yuval.sh...@oracle.com> > return ERR_PTR(err); > } > > -- > 2.7.4 > > -- > To unsubscribe from this list: send t

Re: [PATCH v3] {net,IB}/{rxe,usnic}: Utilize generic mac to eui32 function

On Wed, Mar 08, 2017 at 09:40:41AM +0200, Leon Romanovsky wrote: > On Tue, Mar 07, 2017 at 09:31:58PM +0200, Yuval Shaia wrote: > > This logic seems to be duplicated in (at least) three separate files. > > Move it to one place so code can be re-use. > > > > Signed-of

[PATCH v3] {net,IB}/{rxe,usnic}: Utilize generic mac to eui32 function

This logic seems to be duplicated in (at least) three separate files. Move it to one place so code can be re-use. Signed-off-by: Yuval Shaia <yuval.sh...@oracle.com> --- v0 -> v1: * Add missing #include * Rename to genaddrconf_ifid_eui48 v1 -> v2: * Reset eui[0

Re: [PATCH v2] {net,IB}/{rxe,usnic}: Utilize generic mac to eui32 function

On Tue, Mar 07, 2017 at 04:27:11PM +0200, Leon Romanovsky wrote: > On Mon, Mar 06, 2017 at 08:54:06PM +0200, Yuval Shaia wrote: > > This logic seems to be duplicated in (at least) three separate files. > > Move it to one place so code can be re-use. > > > > Signed-of

[PATCH v2] {net,IB}/{rxe,usnic}: Utilize generic mac to eui32 function

This logic seems to be duplicated in (at least) three separate files. Move it to one place so code can be re-use. Signed-off-by: Yuval Shaia <yuval.sh...@oracle.com> --- v0 -> v1: * Add missing #include * Rename to genaddrconf_ifid_eui48 v1 -> v2: * Reset eui[0

Re: [PATCH 1/1] rds: remove unnecessary returned value check

port *transports[RDS_TRANS_COUNT]; > static DECLARE_RWSEM(rds_trans_sem); > > -int rds_trans_register(struct rds_transport *trans) > +void rds_trans_register(struct rds_transport *trans) > { > BUG_ON(strlen(trans->t_name) + 1 > TRANSNAMSIZ); > > @@ -55,8 +55,6 @@ int rds_trans_register(struct rds_transport *trans) > } > > up_write(_trans_sem); > - > - return 0; > } > EXPORT_SYMBOL_GPL(rds_trans_register); Reviewed-by: Yuval Shaia <yuval.sh...@oracle.com> > > -- > 2.7.4 >

Re: [PATCH 1/1] rds: ib: add the static type to the variables

t/rds/ib_mr.h > index 24c086d..5d6e98a 100644 > --- a/net/rds/ib_mr.h > +++ b/net/rds/ib_mr.h > @@ -107,8 +107,6 @@ struct rds_ib_mr_pool { > }; > > extern struct workqueue_struct *rds_ib_mr_wq; > -extern unsigned int rds_ib_mr_1m_pool_size; > -extern unsigned int rds_ib

Re: [PATCH net 1/3] qed: Release CQ resource under lock on failure

On Tue, Jan 24, 2017 at 11:15:21PM +0200, Yuval Mintz wrote: > From: Ram Amrani > > The CQ resource pool is protected by a spin lock. When a CQ creation > fails it now deallocates under that lock as well. > > Signed-off-by: Ram Amrani >

Re: [for-next V2 06/10] net/mlx5: Add interface to get reference to a UAR

On Sun, Jan 08, 2017 at 05:54:47PM +0200, Saeed Mahameed wrote: > From: Eli Cohen > > A reference to a UAR is required to generate CQ or EQ doorbells. Since > CQ or EQ doorbells can all be generated using the same UAR area without > any effect on performance, we are just

Re: [PATCH] net: return value of skb_linearize should be handled in Linux kernel

W compiled also on SPARC Reviewed-by: Yuval Shaia <yuval.sh...@oracle.com> > > Signed-off-by: Zhouyi Zhou <zhouzho...@gmail.com> > --- > drivers/infiniband/hw/nes/nes_nic.c | 5 +++-- > drivers/net/ethernet/intel/ixgbe/ixgbe_fcoe.c | 6 +- > driv

Re: [PATCH v3] ethernet :mellanox :mlx4: Replace pci_pool_alloc by pci_pool_zalloc

sues You mean remove extra empty line? Reviewed-by: Yuval Shaia <yuval.sh...@oracle.com> > > v2: > - Address comment from sergei > Alignment was not proper > > drivers/net/ethernet/mellanox/mlx4/cmd.c | 6 ++ > 1 file changed, 2 insertions(+), 4 deletions(-

Re: [PATCH v5 13/16] IB/pvrdma: Add the main driver module for PVRDMA

On Sat, Sep 24, 2016 at 04:21:37PM -0700, Adit Ranadive wrote: > + > + /* Currently, the driver only supports RoCE mode. */ > + if (dev->dsr->caps.mode != PVRDMA_DEVICE_MODE_ROCE) { > + dev_err(>dev, "unsupported transport %d\n", > + dev->dsr->caps.mode); >

Re: [PATCH v5 08/16] IB/pvrdma: Add device command support

Minor question/suggestion inline. (sorry for missing it till now). Yuval On Sat, Sep 24, 2016 at 04:21:32PM -0700, Adit Ranadive wrote: > This patch enables posting Verb requests and receiving responses to/from > the backend PVRDMA emulation layer. > > Reviewed-by: Yuval Sha

Re: [PATCH v4 01/16] vmxnet3: Move PCI Id to pci_ids.h

Besides that no more comments. Reviewed-by: Yuval Shaia <yuval.sh...@oracle.com> On Wed, Sep 14, 2016 at 07:36:34PM +, Adit Ranadive wrote: > On Wed, Sep 14, 2016 at 09:25:18 -0700, Yuval Shaia wrote: > > On Wed, Sep 14, 2016 at 04:00:25PM +, Adit Ranadive wrote: >

Re: [PATCH v4 09/16] IB/pvrdma: Add support for Completion Queues

Hi Adit, Please see my comments inline. Besides that I have no more comment for this patch. Reviewed-by: Yuval Shaia <yuval.sh...@oracle.com> Yuval On Thu, Sep 15, 2016 at 12:07:29AM +, Adit Ranadive wrote: > On Wed, Sep 14, 2016 at 05:43:37 -0700, Yuval Shaia wrote: > >

Re: [PATCH v4 13/16] IB/pvrdma: Add the main driver module for PVRDMA

On Sun, Sep 11, 2016 at 09:49:23PM -0700, Adit Ranadive wrote: + > +static void pvrdma_netdevice_event_handle(struct pvrdma_dev *dev, > + unsigned long event) > +{ > + struct net_device *netdev; > + > + netdev = dev->netdev; Please remove the above

Re: [PATCH v4 12/16] IB/pvrdma: Add Queue Pair support

No more comments. Reviewed-by: Yuval Shaia <yuval.sh...@oracle.com> On Sun, Sep 11, 2016 at 09:49:22PM -0700, Adit Ranadive wrote: > This patch adds the ability to create, modify, query and destroy QPs. The > PVRDMA device supports RC, UD and GSI QPs. > > Reviewed-by: J

Re: [PATCH v4 01/16] vmxnet3: Move PCI Id to pci_ids.h

On Wed, Sep 14, 2016 at 04:00:25PM +, Adit Ranadive wrote: > On Wed, Sep 14, 2016 at 04:09:12 -0700, Yuval Shaia wrote: > > Please update vmxnet3_drv.c accordingly. > > Any reason why? I don't think we need to. Vmxnet3 should just pick up the > moved > PCI device id fro

Re: [PATCH v4 11/16] IB/pvrdma: Add support for memory regions

No more comments. Reviewed-by: Yuval Shaia <yuval.sh...@oracle.com> On Sun, Sep 11, 2016 at 09:49:21PM -0700, Adit Ranadive wrote: > This patch adds support for creating and destroying memory regions. The > PVRDMA device supports User MRs, DMA MRs (no Remote Read/Write support), >

Re: [PATCH v4 09/16] IB/pvrdma: Add support for Completion Queues

On Sun, Sep 11, 2016 at 09:49:19PM -0700, Adit Ranadive wrote: > + > +static int pvrdma_poll_one(struct pvrdma_cq *cq, struct pvrdma_qp **cur_qp, > +struct ib_wc *wc) > +{ > + struct pvrdma_dev *dev = to_vdev(cq->ibcq.device); > + int has_data; > + unsigned int

Re: [PATCH v4 05/16] IB/pvrdma: Add functions for Verbs support

On Sun, Sep 11, 2016 at 09:49:15PM -0700, Adit Ranadive wrote: > + > +/** > + * pvrdma_alloc_pd - allocate protection domain > + * @ibdev: the IB device > + * @context: user context > + * @udata: user data > + * > + * @return: the ib_pd protection domain pointer on success, otherwise errno. > + */

Re: [PATCH v4 07/16] IB/pvrdma: Add helper functions

No more comments. Reviewed-by: Yuval Shaia <yuval.sh...@oracle.com> On Sun, Sep 11, 2016 at 09:49:17PM -0700, Adit Ranadive wrote: > This patch adds helper functions to store guest page addresses in a page > directory structure. The page directory pointer is passed down to the >

Re: [PATCH v4 06/16] IB/pvrdma: Add paravirtual rdma device

No more comments. Reviewed-by: Yuval Shaia <yuval.sh...@oracle.com> On Sun, Sep 11, 2016 at 09:49:16PM -0700, Adit Ranadive wrote: > This patch adds the main device-level structures and functions to be used > to provide RDMA functionality. Also, we define conversion functions from &

Re: [PATCH v4 01/16] vmxnet3: Move PCI Id to pci_ids.h

Please update vmxnet3_drv.c accordingly. Yuval On Sun, Sep 11, 2016 at 09:49:11PM -0700, Adit Ranadive wrote: > The VMXNet3 PCI Id will be shared with our paravirtual RDMA driver. > Moved it to the shared location in pci_ids.h. > > Suggested-by: Leon Romanovsky >

Re: [PATCH net-next] net/mlx4_core: Fix backward compatibility on VFs

On Fri, Mar 18, 2016 at 11:11:06PM -0400, David Miller wrote: > From: Eli Cohen > Date: Thu, 17 Mar 2016 18:49:42 +0200 > > > Commit 85743f1eb345 ("net/mlx4_core: Set UAR page size to 4KB regardless > > of system page size") introduced dependency where old VF drivers without >