Re: [PATCH v2] dec: tulip: de4x5: Replace mdelay with usleep_range in de4x5_hw_init

On Thursday 12 April 2018 07:00 AM, Jia-Ju Bai wrote: On 2018/4/12 0:16, James Bottomley wrote: On Wed, 2018-04-11 at 23:39 +0800, Jia-Ju Bai wrote: de4x5_hw_init() is never called in atomic context. de4x5_hw_init() is only called by de4x5_pci_probe(), which is only set as ".probe" in

Re: [PATCH] net: hns: use put_device() if device_register fail

On Monday 12 March 2018 10:59 PM, Richard Weinberger wrote: On Mon, Mar 12, 2018 at 5:27 PM, arvindY <arvind.yadav...@gmail.com> wrote: On Monday 12 March 2018 08:13 PM, David Miller wrote: From: Arvind Yadav <arvind.yadav...@gmail.com> Date: Fri, 9 Mar 2018 16

Re: [PATCH] net: hns: use put_device() if device_register fail

On Monday 12 March 2018 08:13 PM, David Miller wrote: From: Arvind Yadav Date: Fri, 9 Mar 2018 16:11:17 +0530 if device_register() returned an error! Always use put_device() to give up the reference initialized. Signed-off-by: Arvind Yadav

Re: [PATCH 4/7 v2] net: ethernet: i825xx: Fix platform_get_irq's error checking

Hi David, On Wednesday 06 December 2017 05:49 PM, Sergei Shtylyov wrote: On 12/05/2017 06:49 PM, David Miller wrote: From: Arvind Yadav Date: Mon, 4 Dec 2017 23:18:20 +0530 @@ -120,9 +120,10 @@ static int sni_82596_probe(struct platform_device *dev)

Re: [PATCH 03/10] net: ezchip: nps_enet: Fix platform_get_irq's error checking

On Monday 04 December 2017 10:12 PM, Russell King - ARM Linux wrote: On Mon, Dec 04, 2017 at 11:34:48AM -0500, David Miller wrote: From: Russell King - ARM Linux Date: Mon, 4 Dec 2017 16:24:47 + On Mon, Dec 04, 2017 at 11:20:49AM -0500, David Miller wrote: From:

Re: [PATCH 08/10] net: fjes: Handle return value of platform_get_irq and platform_get_resource

Hi Sergei, On Sunday 03 December 2017 01:36 AM, Sergei Shtylyov wrote: Hello! On 12/02/2017 10:26 PM, Arvind Yadav wrote: platform_get_irq() and platform_get_resource() can fail here and we must check its return value. Signed-off-by: Arvind Yadav ---

Re: [PATCH 05/10] net: ethernet: i825xx: Fix platform_get_irq's error checking

Hi Sergei, On Sunday 03 December 2017 01:38 AM, Sergei Shtylyov wrote: Hello. On 12/02/2017 10:26 PM, Arvind Yadav wrote: The platform_get_irq() function returns negative if an error occurs. zero or positive number on success. platform_get_irq() error checking for zero is not correct.

Re: [PATCH 2/3] staging: irda: Handle return value of platform_get_irq

Hi Greg, On Thursday 30 November 2017 10:11 PM, Greg KH wrote: On Thu, Nov 30, 2017 at 09:13:35PM +0530, Arvind Yadav wrote: platform_get_irq() can fail here and we must check its return value. Signed-off-by: Arvind Yadav ---