Re: [PATCH v5 0/7] Reduce cache miss for snmp_fold_field

On 9/28/16 5:08 PM, David Miller wrote: From: Jia He Date: Wed, 28 Sep 2016 14:22:21 +0800 v5: - order local variables from longest to shortest line I still see many cases where this problem still exists. Please do not resubmit this patch series until you fix all of

Re: [RFC PATCH v3 2/7] proc: Reduce cache miss in {snmp,netstat}_seq_show

On 9/22/16 2:24 AM, Marcelo wrote: On Thu, Sep 22, 2016 at 12:18:46AM +0800, hejianet wrote: Hi Marcelo sorry for the late, just came back from a vacation. Hi, no problem. Hope your batteries are recharged now :-) On 9/14/16 7:55 PM, Marcelo wrote: Hi Jia, On Wed, Sep 14, 2016 at 01:58

Re: [RFC PATCH v3 2/7] proc: Reduce cache miss in {snmp,netstat}_seq_show

Hi Marcelo sorry for the late, just came back from a vacation. On 9/14/16 7:55 PM, Marcelo wrote: Hi Jia, On Wed, Sep 14, 2016 at 01:58:42PM +0800, hejianet wrote: Hi Marcelo On 9/13/16 2:57 AM, Marcelo wrote: On Fri, Sep 09, 2016 at 02:33:57PM +0800, Jia He wrote: This is to use

Re: [RFC PATCH v3 2/7] proc: Reduce cache miss in {snmp,netstat}_seq_show

Hi Marcelo On 9/13/16 2:57 AM, Marcelo wrote: On Fri, Sep 09, 2016 at 02:33:57PM +0800, Jia He wrote: This is to use the generic interface snmp_get_cpu_field{,64}_batch to aggregate the data by going through all the items of each cpu sequentially. Then snmp_seq_show and netstat_seq_show are

Re: [RFC PATCH v3 3/7] proc: Reduce cache miss in snmp6_seq_show

On 9/13/16 3:05 AM, Marcelo wrote: On Fri, Sep 09, 2016 at 02:33:58PM +0800, Jia He wrote: This is to use the generic interface snmp_get_cpu_field{,64}_batch to aggregate the data by going through all the items of each cpu sequentially. Signed-off-by: Jia He ---

Re: [RFC PATCH v3 2/7] proc: Reduce cache miss in {snmp,netstat}_seq_show

Hi Marcelo On 9/13/16 2:57 AM, Marcelo wrote: On Fri, Sep 09, 2016 at 02:33:57PM +0800, Jia He wrote: This is to use the generic interface snmp_get_cpu_field{,64}_batch to aggregate the data by going through all the items of each cpu sequentially. Then snmp_seq_show and netstat_seq_show are

Re: [RFC PATCH v2 0/6] Reduce cache miss for snmp_fold_field

Hi Marcelo Thanks for the suggestion Will consider that B.R. Jia On 9/6/16 8:44 PM, Marcelo Ricardo Leitner wrote: On Tue, Sep 06, 2016 at 10:30:03AM +0800, Jia He wrote: ... v2: - 1/6 fix bug in udplite statistics. - 1/6 snmp_seq_show is split into 2 parts Jia He (6): proc: Reduce

Re: [RFC PATCH v2 1/6] proc: Reduce cache miss in {snmp,netstat}_seq_show

On 9/7/16 6:57 AM, David Miller wrote: From: Jia He Date: Tue, 6 Sep 2016 10:30:04 +0800 +#define MAX(a, b) ((u32)(a) >= (u32)(b) ? (a) : (b)) Thanks B.R. Jia Please do not define private min/max macros, use the existing max_t() or similar as needed.

Re: [RFC PATCH 1/6] proc: Reduce cache miss in {snmp,netstat}_seq_show

Hi Eric On 8/30/16 12:41 AM, Eric Dumazet wrote: On Tue, 2016-08-30 at 00:03 +0800, Jia He wrote: This patch exchanges the two loop for collecting the percpu statistics data. This can aggregate the data by going through all the items of each cpu sequentially. In snmp_seq_show, just use one

Re: [RFC PATCH 1/3] net: Remove unnecessary memset in __snmp6_fill_stats64

Yes, sorry about it，I am too hasty B.R. Jia He On 8/8/16 7:12 PM, Florian Westphal wrote: Jia He wrote: buff[] will be assigned later, so memset is not necessary. Signed-off-by: Jia He Cc: "David S. Miller" Cc: Alexey Kuznetsov