Re: "ss -p" segfaults (updated to 4.2)

2015-10-10 Thread j...@openmailbox.org
Hi Willy, It seems fine to me. You may reword the commit message at will. Thx, Jose On 2015-10-06 11:09, Willy Tarreau wrote: > Hi guys, > > I've updated Jose's patch to make it slightly simpler (eg: calloc instead > of malloc+memset), and ported it to 4.2.0 which requires it as well, and >

Re: ss -p segfaults

2015-07-21 Thread j...@openmailbox.org
. Signed-off-by: Jose P Santos j...@openmailbox.org --- iproute2-4.1.1/misc/ss.c.orig 2015-07-06 22:57:34.0 +0100 +++ iproute2-4.1.1/misc/ss.c2015-07-21 10:26:45.0 +0100 @@ -456,7 +456,10 @@ static void user_ent_hash_build(void) user_ent_hash_build_init = 1

Re: Segmentation fault in iproute2 ss -p (versions 4.0.0, 4.1.0 and 4.1.1)

2015-07-21 Thread j...@openmailbox.org
: As far as I know strlcpy isn't (yet) available in glibc. Signed-off-by: Jose P Santos j...@openmailbox.org --- iproute2-4.1.1/misc/ss.c.orig 2015-07-06 22:57:34.0 +0100 +++ iproute2-4.1.1/misc/ss.c2015-07-21 10:26:45.0 +0100 @@ -456,7 +456,10 @@ static void

Re: Segmentation fault in iproute2 ss -p (versions 4.0.0, 4.1.0 and 4.1.1)

2015-07-20 Thread j...@openmailbox.org
--- iproute2-4.1.1-orig/misc/ss.c 2015-07-06 22:57:34.0 +0100 +++ iproute2-4.1.1/misc/ss.c2015-07-19 12:16:25.0 +0100 @@ -428,9 +428,12 @@ while (cnt != USER_ENT_HASH_SIZE) { p = user_ent_hash[cnt]; while (p) { -

ss -p segfaults

2015-07-20 Thread j...@openmailbox.org
Please find attached one simple patch for the code 4.1.0/4.1.1. Essentially all that is needed to get rid of this issue is the addition of: memset(u, 0, sizeof(*u)); after: if (!(u = malloc(sizeof(*u break; During the analysis of this issue I also found some other