IG_FUNCTION_ERROR_INJECTION is the config item of this
> feature. It is automatically enabled if the arch supports
> error injection feature for kprobe or ftrace etc.
>
> Signed-off-by: Masami Hiramatsu <mhira...@kernel.org>
Reviewed-by: Josef Bacik <jba...@fb.com>
Thanks,
Josef
2
>
> mount: mount /dev/loop2 on /opt/tmpmnt failed: Cannot allocate memory
> SUCCESS!
> ===
>
>
> Signed-off-by: Masami Hiramatsu <mhira...@kernel.org>
Reviewed-by: Josef Bacik <jba...@fb.com>
Thanks,
Josef
jection_whitelist[];
> +extern struct error_injection_entry __stop_error_injection_whitelist[];
>
> static void __init populate_kernel_ei_list(void)
> {
> @@ -157,11 +171,26 @@ static void *ei_seq_next(struct seq_file *m, void *v,
> loff_t *pos)
> return seq_list_
here,
and change the users of ALLOW_ERROR_INJECTION() to include error-injection.h
instead?
> +/*
> + * error_injection/whitelist -- shows which functions can be overridden for
> + * error injection.
> + */
> +static void *ei_seq_start(struct seq_file *m, loff_t *pos)
> +{
> + mutex_lock(_mutex);
> + return seq_list_start(_injection_list, *pos);
> +}
> +
> +static void ei_seq_stop(struct seq_file *m, void *v)
> +{
> + mutex_unlock(_mutex);
> +}
> +
> +static void *ei_seq_next(struct seq_file *m, void *v, loff_t *pos)
> +{
> + return seq_list_next(v, _injection_list, pos);
> +}
> +
> +static int ei_seq_show(struct seq_file *m, void *v)
> +{
> + struct ei_entry *ent = list_entry(v, struct ei_entry, list);
> +
> + seq_printf(m, "%pf\n", (void *)ent->start_addr);
Can we bring back the sprint_symbol() thing I did originally here so it's nice
and easy to sanity check stuff is working? Thanks
Josef
ose can be done
> in one place.
>
> Signed-off-by: Masami Hiramatsu <mhira...@kernel.org>
Reviewed-by: Josef Bacik <jba...@fb.com>
Thanks,
Josef
sw-breakpoint based kprobe
> events too.
>
> Signed-off-by: Masami Hiramatsu <mhira...@kernel.org>
Reviewed-by: Josef Bacik <jba...@fb.com>
Thanks,
Josef
if this dropouts are related to this topic.
If of any help I could provide perf output on raspberry with libreelec and
tvheadend.
Regards,
Josef
Gesendet: Montag, 08. Januar 2018 um 23:16 Uhr
Von: "Jesper Dangaard Brouer" <jbro...@redhat.com>
An: "Peter Zijlstra"
No I can't sorry. There's no sat connection near to my workstation.
Gesendet: Montag, 08. Januar 2018 um 17:31 Uhr
Von: "Alan Stern" <st...@rowland.harvard.edu>
An: "Josef Griebichler" <griebichler.jo...@gmx.at>
Cc: "Mauro Carvalho Chehab" <m
on libreelec so I can't provide
further logs.
Regards,
Josef
> On Sun, 7 Jan 2018, Mauro Carvalho Chehab wrote:
>
> > > > It seems that the original patch were designed to solve some IRQ issues
> > > > with network cards with causes data losses on high traffic. Howev
(libreelec on rpi3 with kernel 4.14.10 with revert of the
mentioned commit).
http://ix.io/DM2
Regards
Josef
Gesendet: Sonntag, 07. Januar 2018 um 16:41 Uhr
Von: "Alan Stern" <st...@rowland.harvard.edu>
An: "Mauro Carvalho Chehab" <mche...@s-opensource.com>
Cc: &qu
this is of some help.
Regards,
Josef
Hi Josef,
Em Sat, 6 Jan 2018 16:04:16 +0100
"Josef Griebichler" <griebichler.jo...@gmx.at> escreveu:
> Hi,
>
> the causing commit has been identified.
> After reverting commit
> https://git.kernel.org/pub/scm/linux/kernel/gi
On Tue, Dec 26, 2017 at 04:46:28PM +0900, Masami Hiramatsu wrote:
> Hi Josef and Alexei,
>
> Here are the 2nd version of patches to moving error injection
> table from kprobes. In this series I did a small fixes and
> add function-based fault injection.
>
> Here is
From: Josef Bacik <jba...@fb.com>
Things got moved around between the original bpf_override_return patches
and the final version, and now the ftrace kprobe dispatcher assumes if
you modified the ip that you also enabled preemption. Make a comment of
this and enable preemption, this
From: Josef Bacik <jba...@fb.com>
Using BPF we can override kprob'ed functions and return arbitrary
values. Obviously this can be a bit unsafe, so make this feature opt-in
for functions. Simply tag a function with KPROBE_ERROR_INJECT_SYMBOL in
order to give BPF access to that function for
From: Josef Bacik <jba...@fb.com>
This was instrumental in reproducing a space cache bug.
Signed-off-by: Josef Bacik <jba...@fb.com>
Acked-by: Ingo Molnar <mi...@kernel.org>
---
fs/btrfs/free-space-cache.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/fs/btrfs/free-
From: Josef Bacik <jba...@fb.com>
This adds a basic test for bpf_override_return to verify it works. We
override the main function for mounting a btrfs fs so it'll return
-ENOMEM and then make sure that trying to mount a btrfs fs will fail.
Acked-by: Alexei Starovoitov <a...@kernel.o
From: Josef Bacik <jba...@fb.com>
This allows us to do error injection with BPF for open_ctree.
Signed-off-by: Josef Bacik <jba...@fb.com>
Acked-by: Ingo Molnar <mi...@kernel.org>
---
fs/btrfs/disk-io.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/fs/btrfs/disk-io
From: Josef Bacik <jba...@fb.com>
Error injection is sloppy and very ad-hoc. BPF could fill this niche
perfectly with it's kprobe functionality. We could make sure errors are
only triggered in specific call chains that we care about with very
specific situations. Acco
to actual do the error injection part.
It is very simple, we just set the return value of the pt_regs we're given to
whatever we provide, and then override the PC with a dummy function that simply
returns.
Right now this only works on x86, but it would be simple enough to expand to
other architectures. Thanks,
Josef
On Wed, Dec 13, 2017 at 10:07:32AM -0800, Darrick J. Wong wrote:
> On Wed, Dec 13, 2017 at 01:03:57PM -0500, Josef Bacik wrote:
> > On Tue, Dec 12, 2017 at 03:11:50PM -0800, Darrick J. Wong wrote:
> > > On Mon, Dec 11, 2017 at 11:36:45AM -0500, Josef Bacik wrote:
> > &g
On Tue, Dec 12, 2017 at 03:11:50PM -0800, Darrick J. Wong wrote:
> On Mon, Dec 11, 2017 at 11:36:45AM -0500, Josef Bacik wrote:
> > This is the same as v8, just rebased onto the bpf tree.
> >
> > v8->v9:
> > - rebased onto the bpf tree.
> >
> > v7->v
From: Josef Bacik <jba...@fb.com>
Using BPF we can override kprob'ed functions and return arbitrary
values. Obviously this can be a bit unsafe, so make this feature opt-in
for functions. Simply tag a function with KPROBE_ERROR_INJECT_SYMBOL in
order to give BPF access to that function for
From: Josef Bacik <jba...@fb.com>
This adds a basic test for bpf_override_return to verify it works. We
override the main function for mounting a btrfs fs so it'll return
-ENOMEM and then make sure that trying to mount a btrfs fs will fail.
Acked-by: Alexei Starovoitov <a...@kernel.o
From: Josef Bacik <jba...@fb.com>
This allows us to do error injection with BPF for open_ctree.
Signed-off-by: Josef Bacik <jba...@fb.com>
Acked-by: Ingo Molnar <mi...@kernel.org>
---
fs/btrfs/disk-io.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/fs/btrfs/disk-io
From: Josef Bacik <jba...@fb.com>
This was instrumental in reproducing a space cache bug.
Signed-off-by: Josef Bacik <jba...@fb.com>
Acked-by: Ingo Molnar <mi...@kernel.org>
---
fs/btrfs/free-space-cache.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/fs/btrfs/free-
n override the PC with a dummy function that simply
returns.
Right now this only works on x86, but it would be simple enough to expand to
other architectures. Thanks,
Josef
From: Josef Bacik <jba...@fb.com>
Error injection is sloppy and very ad-hoc. BPF could fill this niche
perfectly with it's kprobe functionality. We could make sure errors are
only triggered in specific call chains that we care about with very
specific situations. Acco
From: Josef Bacik <jba...@fb.com>
Error injection is sloppy and very ad-hoc. BPF could fill this niche
perfectly with it's kprobe functionality. We could make sure errors are
only triggered in specific call chains that we care about with very
specific situations. Acco
From: Josef Bacik <jba...@fb.com>
This adds a basic test for bpf_override_return to verify it works. We
override the main function for mounting a btrfs fs so it'll return
-ENOMEM and then make sure that trying to mount a btrfs fs will fail.
Acked-by: Alexei Starovoitov <a...@kernel.o
From: Josef Bacik <jba...@fb.com>
Using BPF we can override kprob'ed functions and return arbitrary
values. Obviously this can be a bit unsafe, so make this feature opt-in
for functions. Simply tag a function with KPROBE_ERROR_INJECT_SYMBOL in
order to give BPF access to that function for
From: Josef Bacik <jba...@fb.com>
This was instrumental in reproducing a space cache bug.
Signed-off-by: Josef Bacik <jba...@fb.com>
Acked-by: Ingo Molnar <mi...@kernel.org>
---
fs/btrfs/free-space-cache.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/fs/btrfs/free-
From: Josef Bacik <jba...@fb.com>
This allows us to do error injection with BPF for open_ctree.
Signed-off-by: Josef Bacik <jba...@fb.com>
Acked-by: Ingo Molnar <mi...@kernel.org>
---
fs/btrfs/disk-io.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/fs/btrfs/disk-io
works on x86, but it would be simple enough to expand to
other architectures. Thanks,
Josef
On Wed, Nov 29, 2017 at 05:59:39PM +0100, Daniel Borkmann wrote:
> On 11/28/2017 09:02 PM, Josef Bacik wrote:
> > On Tue, Nov 28, 2017 at 11:58:41AM -0700, Jonathan Corbet wrote:
> >> On Wed, 22 Nov 2017 16:23:30 -0500
> >> Josef Bacik <jo...@toxicpanda.com> wr
On Tue, Nov 28, 2017 at 11:58:41AM -0700, Jonathan Corbet wrote:
> On Wed, 22 Nov 2017 16:23:30 -0500
> Josef Bacik <jo...@toxicpanda.com> wrote:
>
> > From: Josef Bacik <jba...@fb.com>
> >
> > Using BPF we can override kprob'ed functions and return ar
From: Josef Bacik <jba...@fb.com>
This was instrumental in reproducing a space cache bug.
Signed-off-by: Josef Bacik <jba...@fb.com>
Acked-by: Ingo Molnar <mi...@kernel.org>
---
fs/btrfs/free-space-cache.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/fs/btrfs/free-
From: Josef Bacik <jba...@fb.com>
This adds a basic test for bpf_override_return to verify it works. We
override the main function for mounting a btrfs fs so it'll return
-ENOMEM and then make sure that trying to mount a btrfs fs will fail.
Acked-by: Alexei Starovoitov <a...@kernel.o
From: Josef Bacik <jba...@fb.com>
Error injection is sloppy and very ad-hoc. BPF could fill this niche
perfectly with it's kprobe functionality. We could make sure errors are
only triggered in specific call chains that we care about with very
specific situations. Acco
From: Josef Bacik <jba...@fb.com>
This allows us to do error injection with BPF for open_ctree.
Signed-off-by: Josef Bacik <jba...@fb.com>
Acked-by: Ingo Molnar <mi...@kernel.org>
---
fs/btrfs/disk-io.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/fs/btrfs/disk-io
From: Josef Bacik <jba...@fb.com>
Using BPF we can override kprob'ed functions and return arbitrary
values. Obviously this can be a bit unsafe, so make this feature opt-in
for functions. Simply tag a function with KPROBE_ERROR_INJECT_SYMBOL in
order to give BPF access to that function for
w this only works on x86, but it would be simple enough to expand to
other architectures. Thanks,
Josef
From: Josef Bacik <jba...@fb.com>
Error injection is sloppy and very ad-hoc. BPF could fill this niche
perfectly with it's kprobe functionality. We could make sure errors are
only triggered in specific call chains that we care about with very
specific situations. Acco
From: Josef Bacik <jba...@fb.com>
This adds a basic test for bpf_override_return to verify it works. We
override the main function for mounting a btrfs fs so it'll return
-ENOMEM and then make sure that trying to mount a btrfs fs will fail.
Acked-by: Alexei Starovoitov <a...@kernel.or
From: Josef Bacik <jba...@fb.com>
Using BPF we can override kprob'ed functions and return arbitrary
values. Obviously this can be a bit unsafe, so make this feature opt-in
for functions. Simply tag a function with KPROBE_ERROR_INJECT_SYMBOL in
order to give BPF access to that function for
From: Josef Bacik <jba...@fb.com>
This allows us to do error injection with BPF for open_ctree.
Signed-off-by: Josef Bacik <jba...@fb.com>
---
fs/btrfs/disk-io.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/fs/btrfs/disk-io.c b/fs/btrfs/disk-io.c
index dfdab849037b..c6b4e1f
imply
returns.
Right now this only works on x86, but it would be simple enough to expand to
other architectures. Thanks,
Josef
g for getting EINTR back from
kernel_sendmsg, which was a pain to trigger properly without this patch. Opt-in
is going to make it so we're just flagging important function calls anwyay
because those are the ones that fail rarely and that we want to test, which puts
us back in the same situation you are worried about, so it doesn't make much
sense to me to do it this way. Thanks,
Josef
On Sat, Nov 11, 2017 at 09:14:55AM +0100, Ingo Molnar wrote:
>
> * Josef Bacik <jo...@toxicpanda.com> wrote:
>
> > On Fri, Nov 10, 2017 at 10:34:59AM +0100, Ingo Molnar wrote:
> > >
> > > * Josef Bacik <jo...@toxicpanda.com> wrote:
> >
On Fri, Nov 10, 2017 at 10:34:59AM +0100, Ingo Molnar wrote:
>
> * Josef Bacik <jo...@toxicpanda.com> wrote:
>
> > @@ -551,6 +578,10 @@ static const struct bpf_func_proto
> > *kprobe_prog_func_proto(enum bpf_func_id func
> > return
From: Josef Bacik <jba...@fb.com>
Error injection is sloppy and very ad-hoc. BPF could fill this niche
perfectly with it's kprobe functionality. We could make sure errors are
only triggered in specific call chains that we care about with very
specific situations. Acco
From: Josef Bacik <jba...@fb.com>
This adds a basic test for bpf_override_return to verify it works. We
override the main function for mounting a btrfs fs so it'll return
-ENOMEM and then make sure that trying to mount a btrfs fs will fail.
Acked-by: Alexei Starovoitov <a...@kernel.or
nction that simply
returns.
Right now this only works on x86, but it would be simple enough to expand to
other architectures. Thanks,
Josef
On Fri, Nov 03, 2017 at 12:12:13AM +0100, Daniel Borkmann wrote:
> Hi Josef,
>
> one more issue I just noticed, see comment below:
>
> On 11/02/2017 03:37 PM, Josef Bacik wrote:
> [...]
> > diff --git a/include/linux/filter.h b/include/linux/filter.h
> > index cdd
ven to
whatever we provide, and then override the PC with a dummy function that simply
returns.
Right now this only works on x86, but it would be simple enough to expand to
other architectures. Thanks,
Josef
From: Josef Bacik <jba...@fb.com>
This adds a basic test for bpf_override_return to verify it works. We
override the main function for mounting a btrfs fs so it'll return
-ENOMEM and then make sure that trying to mount a btrfs fs will fail.
Acked-by: Alexei Starovoitov <a...@kernel.or
From: Josef Bacik <jba...@fb.com>
Error injection is sloppy and very ad-hoc. BPF could fill this niche
perfectly with it's kprobe functionality. We could make sure errors are
only triggered in specific call chains that we care about with very
specific situations. Acco
imple enough to expand to
other architectures. Thanks,
Josef
From: Josef Bacik <jba...@fb.com>
Error injection is sloppy and very ad-hoc. BPF could fill this niche
perfectly with it's kprobe functionality. We could make sure errors are
only triggered in specific call chains that we care about with very
specific situations. Acco
From: Josef Bacik <jba...@fb.com>
This adds a basic test for bpf_override_return to verify it works. We
override the main function for mounting a btrfs fs so it'll return
-ENOMEM and then make sure that trying to mount a btrfs fs will fail.
Signed-off-by: Josef Bacik <jba.
art.
It is very simple, we just set the return value of the pt_regs we're given to
whatever we provide, and then override the PC with a dummy function that simply
returns.
Right now this only works on x86, but it would be simple enough to expand to
other architectures. Thanks,
Josef
From: Josef Bacik <jba...@fb.com>
Error injection is sloppy and very ad-hoc. BPF could fill this niche
perfectly with it's kprobe functionality. We could make sure errors are
only triggered in specific call chains that we care about with very
specific situations. Acco
From: Josef Bacik <jba...@fb.com>
This adds a basic test for bpf_override_return to verify it works. We
override the main function for mounting a btrfs fs so it'll return
-ENOMEM and then make sure that trying to mount a btrfs fs will fail.
Signed-off-by: Josef Bacik <jba.
with a dummy function that simply
returns.
Right now this only works on x86, but it would be simple enough to expand to
other architectures. Thanks,
Josef
From: Josef Bacik <jba...@fb.com>
This adds a basic test for bpf_override_return to verify it works. We
override the main function for mounting a btrfs fs so it'll return
-ENOMEM and then make sure that trying to mount a btrfs fs will fail.
Signed-off-by: Josef Bacik <jba.
From: Josef Bacik <jba...@fb.com>
Error injection is sloppy and very ad-hoc. BPF could fill this niche
perfectly with it's kprobe functionality. We could make sure errors are
only triggered in specific call chains that we care about with very
specific situations. Acco
so that it actually has your full
> name rather than just your email address. This matter when I apply
> your patches.
>
> Second, remove the stable CC:. For networking changes, you simply ask
> me to queue the changes up for -stable.
>
Sorry Dave, I've fixed my git email settings and I droped the stable cc and sent
a new round. Didn't see this until just now, my bad.
Josef
From: Josef Bacik <jba...@fb.com>
We need to set the tb->fast_sk_family properly so we can use the proper
comparison function for all subsequent reuseport bind requests.
Fixes: 637bc8bbe6c0 ("inet: reset tb->fastreuseport when adding a reuseport sk")
Reported-and-tested-by
obviously is not
correct.
Dave could you please queue these changes up for -stable, I've run them through
the net tests and added another test to check for this problem specifically.
Thanks,
Josef
From: Josef Bacik <jba...@fb.com>
In ipv6_rcv_saddr_equal() we need to use inet6_rcv_saddr(sk) for the
ipv6 compare with the fast socket information to make sure we're doing
the proper comparisons.
Fixes: 637bc8bbe6c0 ("inet: reset tb->fastreuseport when adding a reuseport
From: Josef Bacik <jba...@fb.com>
When doing my reuseport rework I screwed up and changed a
if (hlist_empty(>owners))
to
if (!hlist_empty(>owners))
This is obviously bad as all of the reuseport/reuse logic was reversed,
which caused weird problems like allowing an ipv4 bind co
From: Josef Bacik <jba...@fb.com>
These self tests are just self contained binaries, they are not run by
any of the scripts in the directory. This means they need to be marked
with TEST_GEN_PROGS to actually be run, not TEST_GEN_FILES.
Signed-off-by: Josef Bacik <jba...@fb.com>
From: Josef Bacik <jba...@fb.com>
This is to test for a regression introduced by
b9470c27607b ("inet: kill smallest_size and smallest_port")
which introduced a problem with reuseaddr and bind conflicts.
Signed-off-by: Josef Bacik <jba...@fb.com>
---
tools/testing/se
From: Josef Bacik <jba...@fb.com>
Some of the networking tests are very noisy and make it impossible to
see if we actually passed the tests as they run. Default to suppressing
the output from any tests run in order to make it easier to track what
failed.
Signed-off-by: Josef Baci
On Mon, Sep 18, 2017 at 04:14:41PM -0600, Shuah Khan wrote:
> On 09/18/2017 11:32 AM, jo...@toxicpanda.com wrote:
> > From: Josef Bacik <jba...@fb.com>
> >
> > These self tests are just self contained binaries, they are not run by
> > any of the scripts in the
On Mon, Sep 18, 2017 at 01:48:31PM -0600, Shuah Khan wrote:
> On 09/18/2017 12:24 PM, Josef Bacik wrote:
> > On Mon, Sep 18, 2017 at 12:13:40PM -0600, Shuah Khan wrote:
> >> On 09/18/2017 11:52 AM, Josef Bacik wrote:
> >>> On Mon, Sep 18, 2017 at 11:46:18AM -0600, Shu
On Mon, Sep 18, 2017 at 12:13:40PM -0600, Shuah Khan wrote:
> On 09/18/2017 11:52 AM, Josef Bacik wrote:
> > On Mon, Sep 18, 2017 at 11:46:18AM -0600, Shuah Khan wrote:
> >> On 09/18/2017 11:37 AM, jo...@toxicpanda.com wrote:
> >>> From: Josef Bacik &l
On Mon, Sep 18, 2017 at 11:46:18AM -0600, Shuah Khan wrote:
> On 09/18/2017 11:37 AM, jo...@toxicpanda.com wrote:
> > From: Josef Bacik <jba...@fb.com>
> >
> > Some of the networking tests are very noisy and make it impossible to
> > see if we actually passe
From: Josef Bacik <jba...@fb.com>
Some of the networking tests are very noisy and make it impossible to
see if we actually passed the tests as they run. Default to suppressing
the output from any tests run in order to make it easier to track what
failed.
Signed-off-by: Josef Baci
From: Josef Bacik <jba...@fb.com>
This is to test for a regression introduced by
b9470c27607b ("inet: kill smallest_size and smallest_port")
which introduced a problem with reuseaddr and bind conflicts.
Signed-off-by: Josef Bacik <jba...@fb.com>
---
tools/testing/se
From: Josef Bacik <jba...@fb.com>
These self tests are just self contained binaries, they are not run by
any of the scripts in the directory. This means they need to be marked
with TEST_GEN_PROGS to actually be run, not TEST_GEN_FILES.
Signed-off-by: Josef Bacik <jba...@fb.com>
From: Josef Bacik <jba...@fb.com>
We need to set the tb->fast_sk_family properly so we can use the proper
comparison function for all subsequent reuseport bind requests.
Cc: sta...@vger.kernel.org
Fixes: 637bc8bbe6c0 ("inet: reset tb->fastreuseport when adding a reusep
, which
obviously is not correct.
Dave I have follow up patches that will add a selftest for this case and I ran
the other reuseport related tests as well. These need to go in pretty quickly
as it breaks kvm, I've marked them for stable. Sorry for the regression,
Josef
From: Josef Bacik <jba...@fb.com>
When doing my reuseport rework I screwed up and changed a
if (hlist_empty(>owners))
to
if (!hlist_empty(>owners))
This is obviously bad as all of the reuseport/reuse logic was reversed,
which caused weird problems like allowing an ipv4 bind co
From: Josef Bacik <jba...@fb.com>
In ipv6_rcv_saddr_equal() we need to use inet6_rcv_saddr(sk) for the
ipv6 compare with the fast socket information to make sure we're doing
the proper comparisons.
Cc: sta...@vger.kernel.org
Fixes: 637bc8bbe6c0 ("inet: reset tb->fastreusepo
Finally got access to a box to run this down myself. This patch on top of the
other patches fixes the problem for me, could you verify it works for you?
Thanks,
Josef
On 9/13/17, 3:49 PM, "Cole Robinson" <crobi...@redhat.com> wrote:
On 09/13/2017 03:44 PM, Josef Bacik
> On Sep 13, 2017, at 12:46 PM, Chuck Ebbert <cebbert.l...@gmail.com> wrote:
>
> On Wed, 13 Sep 2017 17:28:25 +
> Josef Bacik <jba...@fb.com> wrote:
>
>> Sorry I thought I had made this other fix, can you apply this on top
>> of the other one a
Alright thanks, this should fix it.
Josef
On 9/13/17, 12:14 PM, "Cole Robinson" <crobi...@redhat.com> wrote:
On 09/13/2017 01:40 PM, Cole Robinson wrote:
> On 09/13/2017 01:28 PM, Josef Bacik wrote:
>> Sorry I thought I had made this other fix, can you apply this on
. Thanks,
Josef
On 9/13/17, 8:45 AM, "Laura Abbott" <labb...@redhat.com> wrote:
On 09/12/2017 04:12 PM, Josef Bacik wrote:
> First I’m super sorry for the top post, I’m at plumbers and I forgot to
> upload my muttrc to my new cloud instance, so I’m screwed using outlook.
&g
First I’m super sorry for the top post, I’m at plumbers and I forgot to upload
my muttrc to my new cloud instance, so I’m screwed using outlook.
I have a completely untested, uncompiled patch that I think will fix the
problem, would you mind giving it a go? Thanks,
Josef
On 9/12/17, 3:36 PM
reg, val). This currently sets
> > false_reg->min_value to zero, but if val >= (1<<63), the false branch could
> > be taken for a value that's negative (when interpreted as signed).
>
> I think the way Josef intended it to behave is min/max_value are
> absolute values
that resulted in the commit.
Acked-by: Alexei Starovoitov <a...@kernel.org>
Acked-by: Daniel Borkmann <dan...@iogearbox.net>
Signed-off-by: Josef Bacik <jba...@fb.com>
---
v1->v2:
-rebased onto net-next
tools/testing/selftests/bpf/test_verifier.c | 55
On Fri, 2017-02-03 at 16:03 -0500, David Miller wrote:
> From: Josef Bacik <jba...@fb.com>
> Date: Thu, 2 Feb 2017 12:00:38 -0500
>
> >
> > These two tests are based on the work done for f23cc643f9ba. The
> > first test is
> > just a basic one to ma
On Thu, 2017-02-02 at 09:06 -0800, Eric Dumazet wrote:
> On Thu, 2017-02-02 at 10:56 -0500, Josef Bacik wrote:
>
> >
> > The problem is we set skb->pfmemalloc a bunch of different places,
> > such
> > as __skb_fill_page_desc, which appears to be used in both
that resulted in the commit.
Signed-off-by: Josef Bacik <jba...@fb.com>
---
tools/testing/selftests/bpf/test_verifier.c | 55 +
1 file changed, 55 insertions(+)
diff --git a/tools/testing/selftests/bpf/test_verifier.c
b/tools/testing/selftests/bpf/test_verifier.c
index 8
On Wed, 2017-02-01 at 15:38 -0800, Eric Dumazet wrote:
> On Wed, 2017-02-01 at 16:04 -0500, Josef Bacik wrote:
> >
> > I was seeing random disconnects while testing NBD over
> > loopback. This turned
> > out to be because NBD sets pfmemalloc on it's socket, how
On Wed, 2017-02-01 at 20:47 -0800, Eric Dumazet wrote:
> From: Eric Dumazet <eduma...@google.com>
>
> Debugging issues caused by pfmemalloc is often tedious.
>
> Add a new SNMP counter to more easily diagnose these problems.
>
> Signed-off-by: Eric Dumazet <ed
, under the assumption
that the other side will simply retransmit. Well we do retransmit, and then the
packet is just dropped again for the same reason. To keep this from happening
simply clear skb->pfmemalloc on transmit so that we don't drop the packet on the
receive side.
Signed-off-by: Jo
On Wed, 2017-01-25 at 06:39 -0800, Eric Dumazet wrote:
> On Wed, 2017-01-25 at 09:26 -0500, Josef Bacik wrote:
>
> >
> > Nope ftrace isn't broken, I'm just dumb, the space is being
> > reclaimed
> > by sk_wmem_free_skb(). So I guess I need to figure out why
On Wed, Jan 25, 2017 at 9:14 AM, Josef Bacik <jba...@fb.com> wrote:
On Tue, Jan 24, 2017 at 9:07 AM, Eric Dumazet
<eric.duma...@gmail.com> wrote:
On Tue, 2017-01-24 at 06:20 -0500, Josef Bacik wrote:
Hello,
I've been trying to test some NBD changes I had made recently and I
st
On Tue, Jan 24, 2017 at 9:07 AM, Eric Dumazet <eric.duma...@gmail.com>
wrote:
On Tue, 2017-01-24 at 06:20 -0500, Josef Bacik wrote:
Hello,
I've been trying to test some NBD changes I had made recently and I
started having packet timeouts. I traced this down to tcp just
stopping s
1 - 100 of 170 matches
Mail list logo
