[PATCH net-next v2 3/5] ipv6: fib6_rules: support for match on sport, dport and ip proto

2018-02-27 Thread Roopa Prabhu
From: Roopa Prabhu support to match on src port, dst port and ip protocol. Signed-off-by: Roopa Prabhu --- net/ipv6/fib6_rules.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/net/ipv6/fib6_rules.c b/net/ipv6/fib6_rules.c index 95a2c9e..bcd1f22 100644 --- a/net/ipv6

[PATCH net-next v2 5/5] ipv6: route: dissect flow in input path if fib rules need it

2018-02-27 Thread Roopa Prabhu
From: Roopa Prabhu Dissect flow in fwd path if fib rules require it. Controlled by a flag to avoid penatly for the common case. Flag is set when fib rules with sport, dport and proto match that require flow dissect are installed. Also passes the dissected hash keys to the multipath hash function

[PATCH net-next v2 2/5] ipv4: fib_rules: support match on sport, dport and ip proto

2018-02-27 Thread Roopa Prabhu
From: Roopa Prabhu support to match on src port, dst port and ip protocol. Signed-off-by: Roopa Prabhu --- net/ipv4/fib_rules.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/net/ipv4/fib_rules.c b/net/ipv4/fib_rules.c index 35d646a..16083b8 100644 --- a/net/ipv4/fib_rules.c

[PATCH net-next v2 4/5] ipv4: route: dissect flow in input path if fib rules need it

2018-02-27 Thread Roopa Prabhu
From: Roopa Prabhu Dissect flow in fwd path if fib rules require it. Controlled by a flag to avoid penatly for the common case. Flag is set when fib rules with sport, dport and proto match that require flow dissect are installed. Also passes the dissected hash keys to the multipath hash function

[PATCH net-next v2 0/5] fib_rules: support sport, dport and proto match

2018-02-27 Thread Roopa Prabhu
From: Roopa Prabhu This series extends fib rule match support to include sport, dport and ip proto match (to complete the 5-tuple match support). Common use-cases of Policy based routing in the data center require 5-tuple match. The last 2 patches in the series add a call to flow dissect in the

Re: [PATCH net-next 4/5] ipv4: route: dissect flow in input path if fib rules need it

2018-02-26 Thread Roopa Prabhu
On Mon, Feb 26, 2018 at 1:10 AM, Paolo Abeni wrote: > On Sat, 2018-02-24 at 21:44 -0800, Roopa Prabhu wrote: >> From: Roopa Prabhu >> >> Dissect flow in fwd path if fib rules require it. Controlled by >> a flag to avoid penatly for the common case. Flag is set when fib

Re: [PATCH net-next 5/5] ipv6: route: dissect flow in input path if fib rules need it

2018-02-25 Thread Roopa Prabhu
On Sun, Feb 25, 2018 at 7:19 PM, David Ahern wrote: > On 2/24/18 10:44 PM, Roopa Prabhu wrote: > >> @@ -1847,12 +1858,27 @@ void ip6_route_input(struct sk_buff *skb) >> .flowi6_mark = skb->mark, >> .flowi6_proto = iph->nexthdr, >>

Re: [PATCH net-next 0/5] fib_rules: support sport, dport and ip proto match

2018-02-25 Thread Roopa Prabhu
On Sun, Feb 25, 2018 at 7:20 PM, David Ahern wrote: > On 2/24/18 10:44 PM, Roopa Prabhu wrote: >> From: Roopa Prabhu >> >> This series extends fib rule match support to include sport, dport >> and ip proto match (to complete the 5-tuple match support). >> Common

Re: [PATCH net-next 1/5] net: fib_rules: support for match on ip_proto, sport and dport

2018-02-25 Thread Roopa Prabhu
On Sun, Feb 25, 2018 at 7:08 PM, David Ahern wrote: > On 2/24/18 10:44 PM, Roopa Prabhu wrote: >> From: Roopa Prabhu >> >> uapi for ip_proto, sport and dport range match >> in fib rules. >> >> Signed-off-by: Roopa Prabhu >> --- >> include/net

Re: [PATCH net-next 1/5] net: fib_rules: support for match on ip_proto, sport and dport

2018-02-25 Thread Roopa Prabhu
On Sun, Feb 25, 2018 at 7:04 AM, Nikolay Aleksandrov wrote: > On 25/02/18 07:44, Roopa Prabhu wrote: >> From: Roopa Prabhu >> >> uapi for ip_proto, sport and dport range match >> in fib rules. >> >> Signed-off-by: Roopa Prabhu >>

Re: [PATCH net-next 5/5] ipv6: route: dissect flow in input path if fib rules need it

2018-02-25 Thread Roopa Prabhu
On Sun, Feb 25, 2018 at 7:10 AM, Nikolay Aleksandrov wrote: > On 25/02/18 07:44, Roopa Prabhu wrote: >> From: Roopa Prabhu >> >> Dissect flow in fwd path if fib rules require it. Controlled by >> a flag to avoid penatly for the common case. Flag is set when fib >

[PATCH net-next 3/5] ipv6: fib6_rules: support for match on sport, dport and ip proto

2018-02-24 Thread Roopa Prabhu
From: Roopa Prabhu support to match on src port, dst port and ip protocol. Signed-off-by: Roopa Prabhu --- net/ipv6/fib6_rules.c | 9 + 1 file changed, 9 insertions(+) diff --git a/net/ipv6/fib6_rules.c b/net/ipv6/fib6_rules.c index 95a2c9e..678d664 100644 --- a/net/ipv6/fib6_rules.c

[PATCH net-next 5/5] ipv6: route: dissect flow in input path if fib rules need it

2018-02-24 Thread Roopa Prabhu
From: Roopa Prabhu Dissect flow in fwd path if fib rules require it. Controlled by a flag to avoid penatly for the common case. Flag is set when fib rules with sport, dport and proto match that require flow dissect are installed. Also passes the dissected hash keys to the multipath hash function

[PATCH net-next 4/5] ipv4: route: dissect flow in input path if fib rules need it

2018-02-24 Thread Roopa Prabhu
From: Roopa Prabhu Dissect flow in fwd path if fib rules require it. Controlled by a flag to avoid penatly for the common case. Flag is set when fib rules with sport, dport and proto match that require flow dissect are installed. Also passes the dissected hash keys to the multipath hash function

[PATCH net-next 2/5] ipv4: fib_rules: support match on sport, dport and ip proto

2018-02-24 Thread Roopa Prabhu
From: Roopa Prabhu support to match on src port, dst port and ip protocol. Signed-off-by: Roopa Prabhu --- net/ipv4/fib_rules.c | 9 + 1 file changed, 9 insertions(+) diff --git a/net/ipv4/fib_rules.c b/net/ipv4/fib_rules.c index 35d646a..9d55c90 100644 --- a/net/ipv4/fib_rules.c

[PATCH net-next 0/5] fib_rules: support sport, dport and ip proto match

2018-02-24 Thread Roopa Prabhu
From: Roopa Prabhu This series extends fib rule match support to include sport, dport and ip proto match (to complete the 5-tuple match support). Common use-cases of Policy based routing in the data center require 5-tuple match. The last 2 patches in the series add a call to flow dissect in the

[PATCH net-next 1/5] net: fib_rules: support for match on ip_proto, sport and dport

2018-02-24 Thread Roopa Prabhu
From: Roopa Prabhu uapi for ip_proto, sport and dport range match in fib rules. Signed-off-by: Roopa Prabhu --- include/net/fib_rules.h| 31 +- include/uapi/linux/fib_rules.h | 8 net/core/fib_rules.c | 94 +- 3 files

[PATCH iproute2 net-next] ss: print skmeminfo for packet sockets

2018-02-21 Thread Roopa Prabhu
From: Roopa Prabhu before: $ss --packet -p -m p_raw0 0*:eth0 users:(("lldpd",pid=2240,fd=11)) after: $ss --packet -p -m p_raw0 0*:eth0 users:(("lldpd",pid=2240,fd=11))

Re: [PATCH iproute2-next 1/8] iplink: Return from function instead of calling exit()

2018-02-20 Thread Roopa Prabhu
On Tue, Feb 20, 2018 at 12:49 PM, David Ahern wrote: > On 2/20/18 1:44 PM, Roopa Prabhu wrote: >> On Tue, Feb 20, 2018 at 12:33 PM, Stephen Hemminger >> wrote: >>> On Tue, 20 Feb 2018 13:27:21 -0700 >>> David Ahern wrote: >>> >>>> On

Re: [PATCH iproute2-next 1/8] iplink: Return from function instead of calling exit()

2018-02-20 Thread Roopa Prabhu
On Tue, Feb 20, 2018 at 12:33 PM, Stephen Hemminger wrote: > On Tue, 20 Feb 2018 13:27:21 -0700 > David Ahern wrote: > >> On 2/20/18 1:17 PM, Serhey Popovych wrote: >> > Stephen Hemminger wrote: >> >> On Tue, 20 Feb 2018 21:39:51 +0200 >> >> Serhey Popovych wrote: >> >> >> >>> Signed-off-by: Ser

Re: [PATCH RFC net-next 1/4] ipv4: fib_rules: support match on sport, dport and ip proto

2018-02-13 Thread Roopa Prabhu
On Tue, Feb 13, 2018 at 8:34 AM, David Miller wrote: > From: Roopa Prabhu > Date: Tue, 13 Feb 2018 08:19:35 -0800 > >> - Regardless of this series, I think we should optimize ip rules or >> have a new implementation of policy based routing. happy to hear about >

Re: [PATCH RFC net-next 1/4] ipv4: fib_rules: support match on sport, dport and ip proto

2018-02-13 Thread Roopa Prabhu
On Mon, Feb 12, 2018 at 4:03 PM, David Miller wrote: > From: Eric Dumazet > Date: Mon, 12 Feb 2018 13:54:59 -0800 > >> We had project/teams using different routing tables for each vlan they >> setup :/ > > Indeed, people use FIB rules and think they can scale in software. As > currently implemen

Re: [PATCH RFC net-next 4/4] ipv6: route: dissect flow in input path if fib rules need it

2018-02-12 Thread Roopa Prabhu
On Sun, Feb 11, 2018 at 11:44 PM, Ido Schimmel wrote: > On Sun, Feb 11, 2018 at 02:26:29PM -0800, Roopa Prabhu wrote: >> From: Roopa Prabhu >> >> Dissect flow in fwd path if fib rules require it. Controlled by >> a flag to avoid penatly for the common case. Flag is

[PATCH RFC net-next 3/4] ipv4: route: dissect flow in input path if fib rules need it

2018-02-11 Thread Roopa Prabhu
From: Roopa Prabhu Dissect flow in fwd path if fib rules require it. Controlled by a flag to avoid penatly for the common case. Flag is set when fib rules with sport, dport and proto match that require flow dissect are installed. Also passes the dissected hash keys to the multipath hash function

[PATCH RFC net-next 1/4] ipv4: fib_rules: support match on sport, dport and ip proto

2018-02-11 Thread Roopa Prabhu
From: Roopa Prabhu Add support to match on src port, dst port and ip protocol. Signed-off-by: Roopa Prabhu --- include/uapi/linux/fib_rules.h | 3 +++ net/ipv4/fib_rules.c | 46 -- 2 files changed, 47 insertions(+), 2 deletions(-) diff --git

[PATCH RFC net-next 0/4] fib_rules: support sport, dport and proto match

2018-02-11 Thread Roopa Prabhu
From: Roopa Prabhu This series extends fib rule match support to include sport, dport and ip proto match (to complete the 5-tuple match support). Common use-cases of Policy based routing in the data center require 5-tuple match. The last 2 patches in the series add a call to flow dissect in the

[PATCH RFC net-next 4/4] ipv6: route: dissect flow in input path if fib rules need it

2018-02-11 Thread Roopa Prabhu
From: Roopa Prabhu Dissect flow in fwd path if fib rules require it. Controlled by a flag to avoid penatly for the common case. Flag is set when fib rules with sport, dport and proto match that require flow dissect are installed. Also passes the dissected hash keys to the multipath hash function

[PATCH RFC net-next 2/4] ipv6: fib6_rules: support for match on sport, dport and ip proto

2018-02-11 Thread Roopa Prabhu
From: Roopa Prabhu Add support to match on src port, dst port and ip protocol. Signed-off-by: Roopa Prabhu --- net/ipv6/fib6_rules.c | 49 ++--- 1 file changed, 46 insertions(+), 3 deletions(-) diff --git a/net/ipv6/fib6_rules.c b/net/ipv6

Re: [PATCH v3 net-next] net/ipv6: Do not allow route add with a device that is down

2018-01-25 Thread Roopa Prabhu
ice is admin down. > > Signed-off-by: David Ahern Reviewed-by: Roopa Prabhu > --- > v3 > - moved err=-ENETDOWN under the if check per Eric's request > - left the up check using dev->flags for consistency with IPv4 > and that it is used more often in ipv4 and ivp6 code

Re: [PATCH net-next] net/ipv6: Do not allow route add with a device that is down

2018-01-23 Thread Roopa Prabhu
On Tue, Jan 23, 2018 at 7:13 PM, David Ahern wrote: > IPv6 allows routes to be installed when the device is not up (admin up). > Worse, it does not mark it as LINKDOWN. IPv4 does not allow it and really > there is no reason for IPv6 to allow it, so check the flags and deny if > device is admin dow

[PATCH net-next v2] net: link_watch: mark bonding link events urgent

2018-01-22 Thread Roopa Prabhu
From: Roopa Prabhu It takes 1sec for bond link down notification to hit user-space when all slaves of the bond go down. 1sec is too long for protocol daemons in user-space relying on bond notification to recover (eg: multichassis lag implementations in user-space). Since the link event code

Re: [PATCH net-next] net: link_watch: mark bonding link events urgent

2018-01-22 Thread Roopa Prabhu
On Mon, Jan 22, 2018 at 12:13 AM, Jiri Pirko wrote: > Mon, Jan 22, 2018 at 07:07:53AM CET, ro...@cumulusnetworks.com wrote: >>From: Roopa Prabhu >> >>It takes 1sec for bond link down notification to hit user-space >>when all slaves of the bond go down. 1sec is too lon

[PATCH net-next] net: link_watch: mark bonding link events urgent

2018-01-21 Thread Roopa Prabhu
From: Roopa Prabhu It takes 1sec for bond link down notification to hit user-space when all slaves of the bond go down. 1sec is too long for protocol daemons in user-space relying on bond link notification to failover/recover (eg: multichassis lag implementations in user-space). Since the link

Re: [RFC PATCH net-next 02/12] selftests: forwarding: Add a test for FDB learning

2018-01-17 Thread Roopa Prabhu
On Wed, Jan 17, 2018 at 2:46 PM, Roopa Prabhu wrote: > On Wed, Jan 17, 2018 at 1:01 PM, Jiri Pirko wrote: >> Wed, Jan 17, 2018 at 09:48:54PM CET, dsah...@gmail.com wrote: >>>On 1/15/18 11:18 AM, Ido Schimmel wrote: >>>> diff --git a/tools/testing/selftests/forwardin

Re: [RFC PATCH net-next 02/12] selftests: forwarding: Add a test for FDB learning

2018-01-17 Thread Roopa Prabhu
On Wed, Jan 17, 2018 at 1:01 PM, Jiri Pirko wrote: > Wed, Jan 17, 2018 at 09:48:54PM CET, dsah...@gmail.com wrote: >>On 1/15/18 11:18 AM, Ido Schimmel wrote: >>> diff --git a/tools/testing/selftests/forwarding/lib.sh >>> b/tools/testing/selftests/forwarding/lib.sh >>> index bb423371f4de..264bf0af

Re: [patch net-next v7 09/13] net: sched: allow ingress and clsact qdiscs to share filter blocks

2018-01-11 Thread Roopa Prabhu
On Thu, Jan 11, 2018 at 7:07 AM, Jiri Pirko wrote: > Thu, Jan 11, 2018 at 03:46:09PM CET, j...@mojatatu.com wrote: >>On 18-01-11 09:41 AM, Jiri Pirko wrote: >>> Thu, Jan 11, 2018 at 03:37:08PM CET, j...@mojatatu.com wrote: >>> > On 18-01-11 09:24 AM, Jiri Pirko wrote: >>> > > Thu, Jan 11, 2018 at

Re: [patch net-next v2 00/10] Add support for resource abstraction

2017-12-27 Thread Roopa Prabhu
On Wed, Dec 27, 2017 at 8:34 AM, David Ahern wrote: > On 12/27/17 2:09 AM, Jiri Pirko wrote: >> Wed, Dec 27, 2017 at 05:05:09AM CET, d...@cumulusnetworks.com wrote: >>> On 12/26/17 5:23 AM, Jiri Pirko wrote: From: Jiri Pirko Many of the ASIC's internal resources are limited and are

Re: [PATCH v4 net-next 6/6] ila: Route notify

2017-12-19 Thread Roopa Prabhu
On Fri, Dec 15, 2017 at 10:28 AM, Tom Herbert wrote: > Implement RTM notifications for ILA routers. This adds support to > ILA LWT to send a netlink RTM message when a router is uses. > > THe ILA notify mechanism can be used in two contexts: > > - On an ILA forwarding cache a route prefix can be c

Re: [PATCH v4 net-next 1/6] lwt: Add net to build_state argument

2017-12-19 Thread Roopa Prabhu
On Fri, Dec 15, 2017 at 10:27 AM, Tom Herbert wrote: > Users of LWT need to know net if they want to have per net operations > in LWT. > > Signed-off-by: Tom Herbert Acked-by: Roopa Prabhu

Re: [RFC PATCH 0/9] ethtool netlink interface (WiP)

2017-12-12 Thread Roopa Prabhu
On Mon, Dec 11, 2017 at 5:53 AM, Michal Kubecek wrote: > This is still work in progress and only a very small part of the ioctl > interface is reimplemented but I would like to get some comments before > the patchset becomes too big and changing things becomes too tedious. > > The interface used f

Re: [PATCH] net: bridge: add max_fdb_count

2017-11-15 Thread Roopa Prabhu
On Wed, Nov 15, 2017 at 10:13 PM, Toshiaki Makita wrote: > On 2017/11/16 13:54, Sarah Newman wrote: >> On 11/15/2017 08:05 PM, Toshiaki Makita wrote: >>> On 2017/11/16 11:25, Andrew Lunn wrote: > Also what do the vendors using bridge for L2 offload to switch think? The Marvell L2 swi

[PATCH net-next] net-sysfs: trigger netlink notification on ifalias change via sysfs

2017-11-13 Thread Roopa Prabhu
From: Roopa Prabhu This patch adds netlink notifications on iflias changes via sysfs. makes it consistent with the netlink path which also calls netdev_state_change. Also makes it consistent with other sysfs netdev_store operations. Signed-off-by: Roopa Prabhu --- net/core/net-sysfs.c | 17

Re: [PATCH net] net: bridge: add vlan_tunnel to bridge port policies

2017-11-13 Thread Roopa Prabhu
On Mon, Nov 13, 2017 at 8:30 AM, Nikolay Aleksandrov wrote: > Found another missing port flag policy entry for IFLA_BRPORT_VLAN_TUNNEL > so add it now. > > CC: Roopa Prabhu > Fixes: efa5356b0d97 ("bridge: per vlan dst_metadata netlink support") > Signed-off-by: Ni

Re: VPLS in Linux

2017-10-31 Thread Roopa Prabhu
On Tue, Oct 31, 2017 at 6:42 AM, Алексей Болдырев wrote: > When will support for VPLS appear in Linux? 08/21/2017 David Lamparter has > already sent these patches, but they are not in the kernel for some reason, > not populi. Such question, when all the same these patches will get to a > kernel

Re: [PATCH net-next] net: bridge: add neigh_suppress to bridge port policies

2017-10-30 Thread Roopa Prabhu
On Mon, Oct 30, 2017 at 3:56 AM, Nikolay Aleksandrov wrote: > Add an entry for IFLA_BRPORT_NEIGH_SUPPRESS to bridge port policies. > > Fixes: 821f1b21cabb ("bridge: add new BR_NEIGH_SUPPRESS port flag to suppress > arp and nd flood") > Signed-off-by: Nikolay Aleksandrov

[PATCH iproute2 net-next v2 1/2] iplink: bridge: support bridge port vlan_tunnel attribute

2017-10-27 Thread Roopa Prabhu
From: Roopa Prabhu This config maps to IFLA_BRPORT_VLAN_TUNNEL bridge port netlink flag attribute. This flag enables vlan to tunnel mapping on a bridge port. It is off by default. set vlan_tunnel attribute on bridge port vxlan0: $ip link set dev vxlan0 type bridge_slave vlan_tunnel on $ip link

[PATCH iproute2 net-next v2 2/2] bridge: vlan: support for per vlan tunnel info

2017-10-27 Thread Roopa Prabhu
From: Roopa Prabhu This patch uses kernel bridge vlan attribute IFLA_BRIDGE_VLAN_TUNNEL_INFO to set/delete/show per vlan tunnel info. $bridge vlan add dev vxlan0 vid 2000 tunnel_info id 2000 $bridge vlan add dev vxlan0 vid 1000-1001 tunnel_info id 2000-2001 $bridge vlan tunnelshow portvlan

[PATCH iproute2 net-next v2 0/2] bridge: support for vlan to tunnel mapping

2017-10-27 Thread Roopa Prabhu
From: Roopa Prabhu This series adds the required options to iplink and bridge commands to enable per vlan tunnel info on a bridge port provided by netlink attributes IFLA_BRPORT_VLAN_TUNNEL (flag) and IFLA_BRIDGE_VLAN_TUNNEL_INFO enable vlan-tunnel mapping on a bridge port: $ip link set dev

[PATCH iproute2 net-next 2/2] bridge: vlan: support for per vlan tunnel info

2017-10-26 Thread Roopa Prabhu
From: Roopa Prabhu This patch uses kernel bridge vlan attribute IFLA_BRIDGE_VLAN_TUNNEL_INFO to set/delete/show per vlan tunnel info. $bridge vlan add dev vxlan0 vid 2000 tunnel_info id 2000 $bridge vlan add dev vxlan0 vid 1000-1001 tunnel_info id 2000-2001 $bridge vlan tunnelshow portvlan

[PATCH iproute2 net-next 1/2] iplink: bridge: support bridge port vlan_tunnel attribute

2017-10-26 Thread Roopa Prabhu
From: Roopa Prabhu This config maps to IFLA_BRPORT_VLAN_TUNNEL bridge port netlink flag attribute. This flag enables vlan to tunnel mapping on a bridge port. It is off by default. set vlan_tunnel attribute on bridge port vxlan0: $ip link set dev vxlan0 type bridge_slave vlan_tunnel on $ip link

[PATCH iproute2 net-next 0/2] bridge: support for vlan to tunnel mapping

2017-10-26 Thread Roopa Prabhu
From: Roopa Prabhu This series adds the required options to iplink and bridge commands to enable per vlan tunnel info on a bridge port provided by netlink attributes IFLA_BRPORT_VLAN_TUNNEL (flag) and IFLA_BRIDGE_VLAN_TUNNEL_INFO enable vlan-tunnel mapping on a bridge port: $ip link set dev

[PATCH iproute2] bridge: fdb: print NDA_SRC_VNI if available

2017-10-26 Thread Roopa Prabhu
From: Roopa Prabhu Signed-off-by: Roopa Prabhu --- bridge/fdb.c | 9 + 1 file changed, 9 insertions(+) diff --git a/bridge/fdb.c b/bridge/fdb.c index e5cebf9..081233a 100644 --- a/bridge/fdb.c +++ b/bridge/fdb.c @@ -204,6 +204,15 @@ int print_fdb(const struct sockaddr_nl *who, struct

Re: [PATCH net] net: bridge: fix returning of vlan range op errors

2017-10-19 Thread Roopa Prabhu
er vlan dst_metadata netlink support") > Signed-off-by: Nikolay Aleksandrov > --- Acked-by: Roopa Prabhu thanks

Re: [RFC 0/3] Adding config get/set to devlink

2017-10-13 Thread Roopa Prabhu
On Fri, Oct 13, 2017 at 12:11 AM, Jiri Pirko wrote: > Thu, Oct 12, 2017 at 11:53:56PM CEST, ro...@cumulusnetworks.com wrote: >>On Thu, Oct 12, 2017 at 12:20 PM, Florian Fainelli >>wrote: >>> On 10/12/2017 12:06 PM, David Miller wrote: From: Florian Fainelli Date: Thu, 12 Oct 2017 08:4

Re: Ethtool question

2017-10-12 Thread Roopa Prabhu
On Thu, Oct 12, 2017 at 2:45 PM, Ben Greear wrote: > On 10/11/2017 01:49 PM, David Miller wrote: >> >> From: "John W. Linville" >> Date: Wed, 11 Oct 2017 16:44:07 -0400 >> >>> On Wed, Oct 11, 2017 at 09:51:56AM -0700, Ben Greear wrote: I noticed today that setting some ethtool settings

Re: [RFC 0/3] Adding config get/set to devlink

2017-10-12 Thread Roopa Prabhu
On Thu, Oct 12, 2017 at 12:20 PM, Florian Fainelli wrote: > On 10/12/2017 12:06 PM, David Miller wrote: >> From: Florian Fainelli >> Date: Thu, 12 Oct 2017 08:43:59 -0700 >> >>> Once we move ethtool (or however we name its successor) over to >>> netlink there is an opportunity for accessing objec

Re: [RFC 0/3] Adding config get/set to devlink

2017-10-12 Thread Roopa Prabhu
On Thu, Oct 12, 2017 at 8:43 AM, Florian Fainelli wrote: > On October 12, 2017 8:04:19 AM PDT, Jiri Pirko wrote: >>Thu, Oct 12, 2017 at 04:46:24PM CEST, ro...@cumulusnetworks.com wrote: >>>On Thu, Oct 12, 2017 at 7:40 AM, Jiri Pirko wrote: Thu, Oct 12, 2017 at 04:35:10PM CEST, ro...@cumulus

Re: [RFC 0/3] Adding config get/set to devlink

2017-10-12 Thread Roopa Prabhu
On Thu, Oct 12, 2017 at 8:04 AM, Jiri Pirko wrote: > Thu, Oct 12, 2017 at 04:46:24PM CEST, ro...@cumulusnetworks.com wrote: >>On Thu, Oct 12, 2017 at 7:40 AM, Jiri Pirko wrote: >>> Thu, Oct 12, 2017 at 04:35:10PM CEST, ro...@cumulusnetworks.com wrote: On Thu, Oct 12, 2017 at 6:34 AM, Steve Li

Re: [RFC 0/3] Adding config get/set to devlink

2017-10-12 Thread Roopa Prabhu
On Thu, Oct 12, 2017 at 7:45 AM, Steve Lin wrote: > Hi Roopa, > > The attributes added in this patchset are not really the same type as > ethtool - these are more device configuration type attributes. The > speeds you saw, for example, affect the pre-OS [i.e. PXE boot time] > c

Re: [RFC 0/3] Adding config get/set to devlink

2017-10-12 Thread Roopa Prabhu
On Thu, Oct 12, 2017 at 7:40 AM, Jiri Pirko wrote: > Thu, Oct 12, 2017 at 04:35:10PM CEST, ro...@cumulusnetworks.com wrote: >>On Thu, Oct 12, 2017 at 6:34 AM, Steve Lin wrote: >>> Adds a devlink command for getting & setting device configuration >>> parameters, and enumerates a bunch of those par

Re: [RFC 0/3] Adding config get/set to devlink

2017-10-12 Thread Roopa Prabhu
On Thu, Oct 12, 2017 at 6:34 AM, Steve Lin wrote: > Adds a devlink command for getting & setting device configuration > parameters, and enumerates a bunch of those parameters as devlink > attributes. Also introduces an attribute that can be set by a > driver to indicate that the config change doe

[PATCH iproute2] iplink: new option to set neigh suppression on a bridge port

2017-10-09 Thread Roopa Prabhu
From: Roopa Prabhu neigh suppression can be used to suppress arp and nd flood to bridge ports. It maps to the recently added kernel support for bridge port flag IFLA_BRPORT_NEIGH_SUPPRESS. Signed-off-by: Roopa Prabhu --- bridge/link.c| 13 + ip/iplink_bridge_slave.c

[PATCH net-next v6 1/3] bridge: add new BR_NEIGH_SUPPRESS port flag to suppress arp and nd flood

2017-10-06 Thread Roopa Prabhu
From: Roopa Prabhu This patch adds a new bridge port flag BR_NEIGH_SUPPRESS to suppress arp and nd flood on bridge ports. It implements rfc7432, section 10. https://tools.ietf.org/html/rfc7432#section-10 for ethernet VPN deployments. It is similar to the existing BR_PROXYARP* flags but has a few

[PATCH net-next v6 0/3] bridge: neigh msg proxy and flood suppression support

2017-10-06 Thread Roopa Prabhu
From: Roopa Prabhu This series implements arp and nd suppression in the bridge driver for ethernet vpns. It implements rfc7432, section 10 https://tools.ietf.org/html/rfc7432#section-10 for ethernet VPN deployments. It is similar to the existing BR_PROXYARP* flags but has a few semantic

[PATCH net-next v6 2/3] bridge: suppress arp pkts on BR_NEIGH_SUPPRESS ports

2017-10-06 Thread Roopa Prabhu
From: Roopa Prabhu This patch avoids flooding and proxies arp packets for BR_NEIGH_SUPPRESS ports. Moves existing br_do_proxy_arp to br_do_proxy_suppress_arp to support both proxy arp and neigh suppress. Signed-off-by: Roopa Prabhu --- net/bridge/br_arp_nd_proxy.c | 188

[PATCH net-next v6 3/3] bridge: suppress nd pkts on BR_NEIGH_SUPPRESS ports

2017-10-06 Thread Roopa Prabhu
From: Roopa Prabhu This patch avoids flooding and proxies ndisc packets for BR_NEIGH_SUPPRESS ports. Signed-off-by: Roopa Prabhu --- net/bridge/br_arp_nd_proxy.c | 249 +++ net/bridge/br_device.c | 11 ++ net/bridge/br_input.c| 11

Re: [PATCH net-next v5 0/3] bridge: neigh msg proxy and flood suppression support

2017-10-06 Thread Roopa Prabhu
On Fri, Oct 6, 2017 at 11:34 AM, Roopa Prabhu wrote: > From: Roopa Prabhu > > This series implements arp and nd suppression in the bridge > driver for ethernet vpns. It implements rfc7432, section 10 > https://tools.ietf.org/html/rfc7432#section-10 > for ethernet VPN deployme

[PATCH net-next v5 2/3] bridge: suppress arp pkts on BR_NEIGH_SUPPRESS ports

2017-10-06 Thread Roopa Prabhu
From: Roopa Prabhu This patch avoids flooding and proxies arp packets for BR_NEIGH_SUPPRESS ports. Moves existing br_do_proxy_arp to br_do_proxy_suppress_arp to support both proxy arp and neigh suppress. Signed-off-by: Roopa Prabhu --- net/bridge/br_arp_nd_proxy.c | 188

[PATCH net-next v5 1/3] bridge: add new BR_NEIGH_SUPPRESS port flag to suppress arp and nd flood

2017-10-06 Thread Roopa Prabhu
From: Roopa Prabhu This patch adds a new bridge port flag BR_NEIGH_SUPPRESS to suppress arp and nd flood on bridge ports. It implements rfc7432, section 10. https://tools.ietf.org/html/rfc7432#section-10 for ethernet VPN deployments. It is similar to the existing BR_PROXYARP* flags but has a few

[PATCH net-next v5 3/3] bridge: suppress nd pkts on BR_NEIGH_SUPPRESS ports

2017-10-06 Thread Roopa Prabhu
From: Roopa Prabhu This patch avoids flooding and proxies ndisc packets for BR_NEIGH_SUPPRESS ports. Signed-off-by: Roopa Prabhu --- net/bridge/br_arp_nd_proxy.c | 249 +++ net/bridge/br_device.c | 11 ++ net/bridge/br_input.c| 11

[PATCH net-next v5 0/3] bridge: neigh msg proxy and flood suppression support

2017-10-06 Thread Roopa Prabhu
From: Roopa Prabhu This series implements arp and nd suppression in the bridge driver for ethernet vpns. It implements rfc7432, section 10 https://tools.ietf.org/html/rfc7432#section-10 for ethernet VPN deployments. It is similar to the existing BR_PROXYARP* flags but has a few semantic

Re: [PATCH net-next v2 0/3] ethtool: support for forward error correction mode setting on a link

2017-10-06 Thread Roopa Prabhu
On Thu, Oct 5, 2017 at 11:30 AM, Jakub Kicinski wrote: > On Fri, 28 Jul 2017 23:28:26 -0700, Roopa Prabhu wrote: >> On Fri, Jul 28, 2017 at 9:46 AM, Jakub Kicinski wrote: >> > On Fri, 28 Jul 2017 07:53:01 -0700, Roopa Prabhu wrote: >> >> On Thu, Jul 27, 2017 at

Re: [PATCH net-next v4 1/3] bridge: add new BR_NEIGH_SUPPRESS port flag to suppress arp and nd flood

2017-10-05 Thread Roopa Prabhu
On Wed, Oct 4, 2017 at 3:52 PM, David Miller wrote: > From: Roopa Prabhu > Date: Tue, 3 Oct 2017 22:12:31 -0700 > >> BR_ARP_PROXY flag but has a few semantic differences to conform > > This should be "BR_PROXYARP". ack, will fix. > > Otherwise this ser

Re: [Bridge] [PATCH net-next v4 1/3] bridge: add new BR_NEIGH_SUPPRESS port flag to suppress arp and nd flood

2017-10-04 Thread Roopa Prabhu
On Wed, Oct 4, 2017 at 12:21 AM, Toshiaki Makita wrote: > On 2017/10/04 14:12, Roopa Prabhu wrote: >> From: Roopa Prabhu >> >> This patch adds a new bridge port flag BR_NEIGH_SUPPRESS to >> suppress arp and nd flood on bridge ports. It implements >> rfc7432, sect

[PATCH net-next v4 2/3] bridge: suppress arp pkts on BR_NEIGH_SUPPRESS ports

2017-10-03 Thread Roopa Prabhu
From: Roopa Prabhu This patch avoids flooding and proxies arp packets for BR_NEIGH_SUPPRESS ports. Moves existing br_do_proxy_arp to br_do_proxy_suppress_arp to support both proxy arp and neigh suppress. Signed-off-by: Roopa Prabhu --- net/bridge/br_arp_nd_proxy.c | 186

[PATCH net-next v4 0/3] bridge: neigh msg proxy and flood suppression support

2017-10-03 Thread Roopa Prabhu
From: Roopa Prabhu This series implements arp and nd suppression in the bridge driver for ethernet vpns. It implements rfc7432, section 10 https://tools.ietf.org/html/rfc7432#section-10 for ethernet VPN deployments. It is similar to the existing BR_ARP_PROXY flag but has a few semantic

[PATCH net-next v4 3/3] bridge: suppress nd pkts on BR_NEIGH_SUPPRESS ports

2017-10-03 Thread Roopa Prabhu
From: Roopa Prabhu This patch avoids flooding and proxies ndisc packets for BR_NEIGH_SUPPRESS ports. Signed-off-by: Roopa Prabhu --- net/bridge/br_arp_nd_proxy.c | 246 +++ net/bridge/br_device.c | 11 ++ net/bridge/br_input.c| 10

[PATCH net-next v4 1/3] bridge: add new BR_NEIGH_SUPPRESS port flag to suppress arp and nd flood

2017-10-03 Thread Roopa Prabhu
From: Roopa Prabhu This patch adds a new bridge port flag BR_NEIGH_SUPPRESS to suppress arp and nd flood on bridge ports. It implements rfc7432, section 10. https://tools.ietf.org/html/rfc7432#section-10 for ethernet VPN deployments. It is similar to the existing BR_ARP_PROXY flag but has a few

Re: [PATCH net-next v2 1/3] bridge: add new BR_NEIGH_SUPPRESS port flag to suppress arp and nd flood

2017-10-03 Thread Roopa Prabhu
On Tue, Oct 3, 2017 at 11:29 AM, Stephen Hemminger wrote: > On Tue, 3 Oct 2017 11:21:14 -0700 > Roopa Prabhu wrote: > >> diff --git a/net/bridge/br_forward.c b/net/bridge/br_forward.c >> index 48fb174..7a50dc5 100644 >> --- a/net/bridge/br_forward.c >> +++ b/net

[PATCH net-next v3 1/3] bridge: add new BR_NEIGH_SUPPRESS port flag to suppress arp and nd flood

2017-10-03 Thread Roopa Prabhu
From: Roopa Prabhu This patch adds a new bridge port flag BR_NEIGH_SUPPRESS to suppress arp and nd flood on bridge ports. It implements rfc7432, section 10. https://tools.ietf.org/html/rfc7432#section-10 for ethernet VPN deployments. It is similar to the existing BR_ARP_PROXY flag but has a few

[PATCH net-next v3 0/3] bridge: neigh msg proxy and flood suppression support

2017-10-03 Thread Roopa Prabhu
From: Roopa Prabhu This series implements arp and nd suppression in the bridge driver for ethernet vpns. It implements rfc7432, section 10 https://tools.ietf.org/html/rfc7432#section-10 for ethernet VPN deployments. It is similar to the existing BR_ARP_PROXY flag but has a few semantic

[PATCH net-next v3 3/3] bridge: suppress nd pkts on BR_NEIGH_SUPPRESS ports

2017-10-03 Thread Roopa Prabhu
From: Roopa Prabhu This patch avoids flooding and proxies ndisc packets for BR_NEIGH_SUPPRESS ports. Signed-off-by: Roopa Prabhu --- net/bridge/br_arp_nd_proxy.c | 246 +++ net/bridge/br_device.c | 11 ++ net/bridge/br_input.c| 10

[PATCH net-next v3 2/3] bridge: suppress arp pkts on BR_NEIGH_SUPPRESS ports

2017-10-03 Thread Roopa Prabhu
From: Roopa Prabhu This patch avoids flooding and proxies arp packets for BR_NEIGH_SUPPRESS ports. Moves existing br_do_proxy_arp to br_do_proxy_suppress_arp to support both proxy arp and neigh suppress. Signed-off-by: Roopa Prabhu --- net/bridge/br_arp_nd_proxy.c | 186

[PATCH net-next v2 1/3] bridge: add new BR_NEIGH_SUPPRESS port flag to suppress arp and nd flood

2017-10-03 Thread Roopa Prabhu
From: Roopa Prabhu This patch adds a new bridge port flag BR_NEIGH_SUPPRESS to suppress arp and nd flood on bridge ports. It implements rfc7432, section 10. https://tools.ietf.org/html/rfc7432#section-10 for ethernet VPN deployments. It is similar to the existing BR_ARP_PROXY flag but has a few

[PATCH net-next v2 0/3] bridge: neigh msg proxy and flood suppression support

2017-10-03 Thread Roopa Prabhu
From: Roopa Prabhu This series implements arp and nd suppression in the bridge driver for ethernet vpns. It implements rfc7432, section 10 https://tools.ietf.org/html/rfc7432#section-10 for ethernet VPN deployments. It is similar to the existing BR_ARP_PROXY flag but has a few semantic

[PATCH net-next v2 3/3] bridge: suppress nd pkts on BR_NEIGH_SUPPRESS ports

2017-10-03 Thread Roopa Prabhu
From: Roopa Prabhu This patch avoids flooding and proxies ndisc packets for BR_NEIGH_SUPPRESS ports. Signed-off-by: Roopa Prabhu --- net/bridge/br_arp_nd_proxy.c | 246 +++ net/bridge/br_device.c | 11 ++ net/bridge/br_input.c| 10

[PATCH net-next v2 2/3] bridge: suppress arp pkts on BR_NEIGH_SUPPRESS ports

2017-10-03 Thread Roopa Prabhu
From: Roopa Prabhu This patch avoids flooding and proxies arp packets for BR_NEIGH_SUPPRESS ports. Moves existing br_do_proxy_arp to br_do_proxy_suppress_arp to support both proxy arp and neigh suppress. Signed-off-by: Roopa Prabhu --- net/bridge/br_arp_nd_proxy.c | 184

Re: [PATCH net] net: rtnetlink: fix info leak in RTM_GETSTATS call

2017-10-03 Thread Roopa Prabhu
anks > to Alexander Potapenko for the detailed report and bisection. > > Reported-by: Alexander Potapenko > Fixes: 10c9ead9f3c6 ("rtnetlink: add new RTM_GETSTATS message to dump link > stats") > Signed-off-by: Nikolay Aleksandrov Acked-by: Roopa Prabhu Thanks Nikolay!.

Re: [PATCH net-next 0/3] bridge: neigh msg proxy and flood suppression support

2017-10-02 Thread Roopa Prabhu
On Sun, Oct 1, 2017 at 9:36 PM, Roopa Prabhu wrote: > From: Roopa Prabhu > > This series implements arp and nd suppression in the bridge > driver for ethernet vpns. It implements rfc7432, section 10 > https://tools.ietf.org/html/rfc7432#section-10 > for ethernet VPN deployments

[PATCH net-next 0/3] bridge: neigh msg proxy and flood suppression support

2017-10-01 Thread Roopa Prabhu
From: Roopa Prabhu This series implements arp and nd suppression in the bridge driver for ethernet vpns. It implements rfc7432, section 10 https://tools.ietf.org/html/rfc7432#section-10 for ethernet VPN deployments. It is similar to the existing BR_ARP_PROXY flag but has a few semantic

[PATCH net-next 1/3] bridge: add new BR_NEIGH_SUPPRESS port flag to suppress arp and nd flood

2017-10-01 Thread Roopa Prabhu
From: Roopa Prabhu This patch adds a new bridge port flag BR_NEIGH_SUPPRESS to suppress arp and nd flood on bridge ports. It implements rfc7432, section 10. https://tools.ietf.org/html/rfc7432#section-10 for ethernet VPN deployments. It is similar to the existing BR_ARP_PROXY flag but has a few

[PATCH net-next 3/3] bridge: suppress nd pkts on BR_NEIGH_SUPPRESS ports

2017-10-01 Thread Roopa Prabhu
From: Roopa Prabhu This patch avoids flooding and proxies ndisc packets for BR_NEIGH_SUPPRESS ports. Signed-off-by: Roopa Prabhu --- net/bridge/br_arp_nd_proxy.c | 246 +++ net/bridge/br_device.c | 10 ++ net/bridge/br_input.c| 10

[PATCH net-next 2/3] bridge: suppress arp pkts on BR_NEIGH_SUPPRESS ports

2017-10-01 Thread Roopa Prabhu
From: Roopa Prabhu This patch avoids flooding and proxies arp packets for BR_NEIGH_SUPPRESS ports. Moves existing br_do_proxy_arp to br_do_proxy_suppress_arp to support both proxy arp and neigh suppress. Signed-off-by: Roopa Prabhu --- net/bridge/br_arp_nd_proxy.c | 186

Re: [PATCH net-next] net: bridge: add per-port group_fwd_mask with less restrictions

2017-09-29 Thread Roopa Prabhu
On Fri, Sep 29, 2017 at 3:11 PM, Nikolay Aleksandrov wrote: > On 30/09/17 00:51, Stephen Hemminger wrote: >> On Sat, 30 Sep 2017 00:01:24 +0300 >> Nikolay Aleksandrov wrote: >> >>> On 29/09/17 18:14, Stephen Hemminger wrote: On Wed, 27 Sep 2017 16:12:44 +0300 Nikolay Aleksandrov wrote:

Re: [PATCH v3 1/1] ip_tunnel: add mpls over gre encapsulation

2017-09-27 Thread Roopa Prabhu
On Wed, Sep 27, 2017 at 9:08 AM, Amine Kherbouche wrote: > > > On 09/27/2017 05:36 PM, Roopa Prabhu wrote: >> >> Amine, one small nit here.., if you define mpls_gre_rcv in gre header >> (like you had initially), you could do the below... >> >> #if

Re: [PATCH v3 1/1] ip_tunnel: add mpls over gre encapsulation

2017-09-27 Thread Roopa Prabhu
you had initially), you could do the below... #if IS_ENABLED(CONFIG_MPLS) mpls_gre_rcv() { /* real func */ } #else mpls_gre_rcv() { kfree_skb(skb) return NET_RX_DROP } #endif and the check in gre_rcv() reduces to if (unlikely(tpi.proto == htons(ETH_P_MPLS_UC))) return mpls_gre_rcv(skb, hdr_len); Which looks much cleaner. Other than that, looks great. pls add my Acked-by: Roopa Prabhu to your next version. thanks!

Re: [PATCH v2 2/2] ip_tunnel: add mpls over gre encapsulation

2017-09-26 Thread Roopa Prabhu
On Tue, Sep 26, 2017 at 10:58 AM, Amine Kherbouche wrote: > Hi Roopa, > > Thanks for the feedback, I have just one question: > > > On 09/26/2017 05:15 PM, Roopa Prabhu wrote: >>> >>> +static int ipgre_tunnel_encap_add_mpls_ops(void) >>> > +

Re: [PATCH v2 2/2] ip_tunnel: add mpls over gre encapsulation

2017-09-26 Thread Roopa Prabhu
On Tue, Sep 26, 2017 at 2:22 AM, Amine Kherbouche wrote: > This commit introduces the MPLSoGRE support (RFC 4023), using ip tunnel > API. > > Encap: > - Add a new iptunnel type mpls. > - Share tx path: gre type mpls loaded from skb->protocol. > > Decap: > - pull gre hdr and call mpls_forward

Re: [PATCH 2/2] ip_tunnel: add mpls over gre encapsulation

2017-09-21 Thread Roopa Prabhu
On Thu, Sep 21, 2017 at 2:25 AM, Amine Kherbouche wrote: > This commit introduces the MPLSoGRE support (RFC 4023), using ip tunnel > API. > > Encap: > - Add a new iptunnel type mpls. > > Decap: > - pull gre hdr and call mpls_forward(). > > Signed-off-by: Amine Kherbouche > --- > include/net/

Re: [net-next v3] bridge: trigger RTM_NEWLINK when interface is modified by bridge ioctl

2017-09-21 Thread Roopa Prabhu
On Thu, Sep 21, 2017 at 9:43 AM, David Ahern wrote: > On 9/21/17 4:05 AM, Vincent Bernat wrote: >> Currently, there is a difference in netlink events received when an >> interface is modified through bridge ioctl() or through netlink. This >> patch generates additional events when an interface is

<    1   2   3   4   5   6   7   8   9   10   >