[PATCH iproute2] bridge: support for static fdb entries

From: Roopa Prabhu <ro...@cumulusnetworks.com> There is no intuitive option to add static fdb entries today. 'temp' seems to have a side effect of adding 'static' fdb entries. But the name and intent of 'temp' does not say anything about it being static. example: bridge fdb add op

Re: [PATCH net 1/4] mpls: validate L2 via address length

On 12/10/15, 11:30 AM, Robert Shearman wrote: > If an L2 via address for an mpls nexthop is specified, the length of > the L2 address must match that expected by the output device, > otherwise it could access memory beyond the end of the via address > buffer in the route. > > This check was

Re: [PATCH net 1/4] mpls: validate L2 via address length

On 12/11/15, 2:51 PM, roopa wrote: > On 12/10/15, 11:30 AM, Robert Shearman wrote: >> If an L2 via address for an mpls nexthop is specified, the length of >> the L2 address must match that expected by the output device, >> otherwise it could access memory beyond the e

[PATCH net-next] mpls_iptunnel: add static qualifier to mpls_output

From: Roopa Prabhu <ro...@cumulusnetworks.com> This gets rid of the following compile warn: net/mpls/mpls_iptunnel.c:40:5: warning: no previous prototype for mpls_output [-Wmissing-prototypes] Signed-off-by: Roopa Prabhu <ro...@cumulusnetworks.com> --- net/mpls/mpls_iptunnel.c |

Re: [PATCH net-next v2] net: Add fib rules at vrf device create

On 12/8/15, 7:41 PM, David Miller wrote: > From: David Ahern > Date: Tue, 8 Dec 2015 20:21:51 -0700 > >> On 12/8/15 8:08 PM, David Ahern wrote: >>> root@kenny-jessie2:~# ip ru add oif vrf-red lookup vrf-red >>> >>> root@kenny-jessie2:~# ip ru ls >>> 0:from all lookup

Re: MPLS decap with iproute2

On 12/7/15, 11:42 AM, Sam Russell wrote: > Hi, > > I've had success with the iproute2 manpage example for encapsulating > outgoing traffic in MPLS, but I've not found a way to add decap routes > inbound. > > I've tried "ip route -f mpls add 100 dev lo" and other variations, but I > get netlink

[PATCH net-next v7] mpls: support for dead routes

From: Roopa Prabhu <ro...@cumulusnetworks.com> Adds support for RTNH_F_DEAD and RTNH_F_LINKDOWN flags on mpls routes due to link events. Also adds code to ignore dead routes during route selection. Unlike ip routes, mpls routes are not deleted when the route goes dead. This is curren

Re: [PATCH net-next v6] mpls: support for dead routes

On 12/1/15, 12:43 PM, David Miller wrote: > From: Roopa Prabhu <ro...@cumulusnetworks.com> > Date: Sat, 28 Nov 2015 19:38:33 -0800 > >> Adds support for RTNH_F_DEAD and RTNH_F_LINKDOWN flags on mpls >> routes due to link events. Also adds code to ignore dead >> r

[PATCH net-next v6] mpls: support for dead routes

From: Roopa Prabhu <ro...@cumulusnetworks.com> Adds support for RTNH_F_DEAD and RTNH_F_LINKDOWN flags on mpls routes due to link events. Also adds code to ignore dead routes during route selection. Unlike ip routes, mpls routes are not deleted when the route goes dead. This is curren

Re: [PATCH net-next v5] mpls: support for dead routes

On 11/25/15, 8:18 AM, David Miller wrote: > From: Roopa Prabhu <ro...@cumulusnetworks.com> > Date: Tue, 24 Nov 2015 15:22:22 -0800 > >> v4 -v5 >> - if kmemdup fails, modify the original route in place. This is a >> corner case and only side

[PATCH net-next v5] mpls: support for dead routes

From: Roopa Prabhu <ro...@cumulusnetworks.com> Adds support for RTNH_F_DEAD and RTNH_F_LINKDOWN flags on mpls routes due to link events. Also adds code to ignore dead routes during route selection. Unlike ip routes, mpls routes are not deleted when the route goes dead. This is curren

Re: [PATCH net-next v4] mpls: support for dead routes

On 11/23/15, 6:15 AM, Robert Shearman wrote: > On 21/11/15 05:16, Roopa Prabhu wrote: >> From: Roopa Prabhu <ro...@cumulusnetworks.com> >> >> Adds support for RTNH_F_DEAD and RTNH_F_LINKDOWN flags on mpls >> routes due to link events. Also adds code to ignore dead

[PATCH net-next v4] mpls: support for dead routes

From: Roopa Prabhu <ro...@cumulusnetworks.com> Adds support for RTNH_F_DEAD and RTNH_F_LINKDOWN flags on mpls routes due to link events. Also adds code to ignore dead routes during route selection. Unlike ip routes, mpls routes are not deleted when the route goes dead. This is curren

Re: [PATCH net-next v2] mpls: support for dead routes

On 11/3/15, 7:08 AM, Robert Shearman wrote: > On 03/11/15 05:13, Roopa Prabhu wrote: >> From: Roopa Prabhu <ro...@cumulusnetworks.com> >> >> Adds support for RTNH_F_DEAD and RTNH_F_LINKDOWN flags on mpls >> routes due to link events. Also adds code to ignore dead

Re: [PATCH net-next v2] mpls: support for dead routes

On 11/3/15, 10:54 AM, Eric W. Biederman wrote: > roopa <ro...@cumulusnetworks.com> writes: > >> On 11/3/15, 7:08 AM, Robert Shearman wrote: >>> On 03/11/15 05:13, Roopa Prabhu wrote: >>>> From: Roopa Prabhu <ro...@cumulusnetworks.com> >>>&

[PATCH net-next v3] mpls: support for dead routes

From: Roopa Prabhu <ro...@cumulusnetworks.com> Adds support for RTNH_F_DEAD and RTNH_F_LINKDOWN flags on mpls routes due to link events. Also adds code to ignore dead routes during route selection Signed-off-by: Roopa Prabhu <ro...@cumulusnetworks.com> --- Dave, I know you are onl

Re: [PATCH net-next] mpls: support for dead routes

Thanks fixed in v3. On 11/2/15, 11:11 PM, Julia Lawall wrote: > Please check on what was intended. > > julia > > On Tue, 3 Nov 2015, kbuild test robot wrote: > >> CC: kbuild-...@01.org >> In-Reply-To: <1446498529-50275-1-git-send-email-ro...@cumulusnetw

Re: [PATCH net-next v2] mpls: support for dead routes

On 11/3/15, 7:28 AM, David Miller wrote: > From: Roopa Prabhu <ro...@cumulusnetworks.com> > Date: Mon, 2 Nov 2015 21:13:01 -0800 > >> From: Roopa Prabhu <ro...@cumulusnetworks.com> >> >> Adds support for RTNH_F_DEAD and RTNH_F_LINKDOWN flags on mpls >&

Re: [PATCH net-next] mpls: Don't accept multipath configuration until the support is complete

On 11/2/15, 10:09 PM, Eric W. Biederman wrote: > Sergei Shtylyov writes: > >> Hello. >>> diff --git a/net/mpls/af_mpls.c b/net/mpls/af_mpls.c >>> index c70d750148b6..893cd2dc3979 100644 >>> --- a/net/mpls/af_mpls.c >>> +++ b/net/mpls/af_mpls.c >>> @@ -1162,6

[PATCH net-next v2] mpls: support for dead routes

From: Roopa Prabhu <ro...@cumulusnetworks.com> Adds support for RTNH_F_DEAD and RTNH_F_LINKDOWN flags on mpls routes due to link events. Also adds code to ignore dead routes during route selection Signed-off-by: Roopa Prabhu <ro...@cumulusnetworks.com> --- RFC to v1: Add

Re: [PATCH net-next RFC] mpls: support for dead routes

On 11/1/15, 9:08 PM, Eric W. Biederman wrote: > roopa <ro...@cumulusnetworks.com> writes: > >> On 11/1/15, 1:27 PM, Eric W. Biederman wrote: >>> Roopa Prabhu <ro...@cumulusnetworks.com> writes: >>> >>>> diff --git a/net/mpls/af_mpls.c b

[PATCH net-next] mpls: support for dead routes

From: Roopa Prabhu <ro...@cumulusnetworks.com> Adds support for RTNH_F_DEAD and RTNH_F_LINKDOWN flags on mpls routes due to link events. Also adds code to ignore dead routes during route selection Signed-off-by: Roopa Prabhu <ro...@cumulusnetworks.com> --- RFC to v1: Add

Re: [PATCH net-next RFC] mpls: support for dead routes

On 11/1/15, 1:27 PM, Eric W. Biederman wrote: > Roopa Prabhu <ro...@cumulusnetworks.com> writes: > >> diff --git a/net/mpls/af_mpls.c b/net/mpls/af_mpls.c >> index c70d750..7db9678 100644 >> --- a/net/mpls/af_mpls.c >> +++ b/net/mpls/af_mpls.c >

[PATCH net-next RFC] mpls: support for dead routes

From: Roopa Prabhu <ro...@cumulusnetworks.com> Adds support for both RTNH_F_DEAD and RTNH_F_LINKDOWN flags. This resembles ipv4 fib code. I also picked fib_rebalance from ipv4. Enabled weights support for nexthop, just because the infrastructure is already there. Signed-off-by: Roopa Prab

Re: [PATCH net-next RFC] mpls: support for dead routes

On 10/29/15, 9:53 AM, Robert Shearman wrote: > On 29/10/15 15:49, Roopa Prabhu wrote: >> From: Roopa Prabhu <ro...@cumulusnetworks.com> >> >> Adds support for both RTNH_F_DEAD and RTNH_F_LINKDOWN flags. >> This resembles ipv4 fib code. I also picked fib_rebala

[PATCH net-next v2] bridge: set is_local and is_static before fdb entry is added to the fdb hashtable

From: Roopa Prabhu <ro...@cumulusnetworks.com> Problem Description: We can add fdbs pointing to the bridge with NULL ->dst but that has a few race conditions because br_fdb_insert() is used which first creates the fdb and then, after the fdb has been published/linked, sets "

Re: [PATCH net-next] bridge: set is_local and is_static before fdb entry is added to the fdb hashtable

On 10/26/15, 9:16 PM, kbuild test robot wrote: > Hi Roopa, > > [auto build test ERROR on net-next/master -- if it's inappropriate base, > please suggest rules for selecting the more suitable base] > > url: > https://github.com/0day-ci/linux/commits/Roopa-Prabh

[PATCH net-next v3] bridge: set is_local and is_static before fdb entry is added to the fdb hashtable

From: Roopa Prabhu <ro...@cumulusnetworks.com> Problem Description: We can add fdbs pointing to the bridge with NULL ->dst but that has a few race conditions because br_fdb_insert() is used which first creates the fdb and then, after the fdb has been published/linked, sets "

Re: [PATCH net-next v2] bridge: set is_local and is_static before fdb entry is added to the fdb hashtable

On 10/27/15, 7:02 AM, David Miller wrote: > From: Nikolay Aleksandrov <niko...@cumulusnetworks.com> > Date: Tue, 27 Oct 2015 14:31:48 +0100 > >> On 10/27/2015 01:12 PM, Roopa Prabhu wrote: >>> From: Roopa Prabhu <ro...@cumulusnetworks.com> >>> >>

Re: [PATCH net-next 1/2] mpls: fix forwarding using v4/v6 explicit null

> rt2->rt_payload_type = MPT_IPV6; > rt2->rt_nh->nh_via_table = NEIGH_LINK_TABLE; > + rt2->rt_nh->nh_via_alen = lo->addr_len; > memcpy(rt2->rt_nh->nh_via, lo->dev_addr, lo->addr_len); > } > A

Re: [PATCH net-next 2/2] mpls: reduce memory usage of routes

On 10/26/15, 5:37 PM, Robert Shearman wrote: > Nexthops for MPLS routes have a via address field sized for the > largest via address that is expected, which is 32 bytes. This means > that in the most common case of having ipv4 via addresses, 28 bytes of > memory more than required are used per

[PATCH net-next] bridge: set is_local and is_static before fdb entry is added to the fdb hashtable

From: Roopa Prabhu <ro...@cumulusnetworks.com> Problem Description: We can add fdbs pointing to the bridge with NULL ->dst but that has a few race conditions because br_fdb_insert() is used which first creates the fdb and then, after the fdb has been published/linked, sets "

[PATCH net-next v6 1/2] mpls: multipath route support

From: Roopa Prabhu <ro...@cumulusnetworks.com> This patch adds support for MPLS multipath routes. Includes following changes to support multipath: - splits struct mpls_route into 'struct mpls_route + struct mpls_nh' - 'struct mpls_nh' represents a mpls nexthop label forwarding entry -

[PATCH net-next v6 0/2] mpls: multipath support

From: Roopa Prabhu <ro...@cumulusnetworks.com> This patch adds support for MPLS multipath routes. Includes following changes to support multipath: - splits struct mpls_route into 'struct mpls_route + struct mpls_nh'. - struct mpls_nh represents a mpls nexthop label forwarding entry

[PATCH net-next v6 2/2] mpls: flow-based multipath selection

<rshea...@brocade.com> Signed-off-by: Roopa Prabhu <ro...@cumulusnetworks.com> --- net/mpls/af_mpls.c | 87 +++--- 1 file changed, 83 insertions(+), 4 deletions(-) diff --git a/net/mpls/af_mpls.c b/net/mpls/af_mpls.c index ee3097a..cc972e3 100

Re: [PATCH net-next v5 0/2] mpls: multipath support

On 10/22/15, 5:16 PM, Roopa Prabhu wrote: > From: Roopa Prabhu <ro...@cumulusnetworks.com> > > This patch adds support for MPLS multipath routes. > > Includes following changes to support multipath: > - splits struct mpls_route into 'struct mpls_route + struct mpls_n

[PATCH net-next v5 0/2] mpls: multipath support

From: Roopa Prabhu <ro...@cumulusnetworks.com> This patch adds support for MPLS multipath routes. Includes following changes to support multipath: - splits struct mpls_route into 'struct mpls_route + struct mpls_nh'. - struct mpls_nh represents a mpls nexthop label forwarding entry

[PATCH net-next v5 1/2] mpls: multipath route support

From: Roopa Prabhu <ro...@cumulusnetworks.com> This patch adds support for MPLS multipath routes. Includes following changes to support multipath: - splits struct mpls_route into 'struct mpls_route + struct mpls_nh' - 'struct mpls_nh' represents a mpls nexthop label forwarding entry -

[PATCH net-next v5 2/2] mpls: flow-based multipath selection

From: Robert Shearman Change the selection of a multipath route to use a flow-based hash. This more suitable for traffic sensitive to reordering within a flow (e.g. TCP, L2VPN) and whilst still allowing a good distribution of traffic given enough flows. Selection of the

Re: [PATCH net-next v4 1/2] mpls: multipath route support

On 10/22/15, 3:24 AM, Robert Shearman wrote: > On 19/10/15 02:20, Roopa Prabhu wrote: >> @@ -159,6 +137,7 @@ static int mpls_forward(struct sk_buff *skb, struct >> net_device *dev, >> struct net *net = dev_net(dev); >> struct mpls_shim_hdr *hdr; >

Re: [PATCH net-next v4 1/2] mpls: multipath route support

On 10/21/15, 7:00 PM, Eric W. Biederman wrote: > Roopa Prabhu <ro...@cumulusnetworks.com> writes: > >> From: Roopa Prabhu <ro...@cumulusnetworks.com> >> >> This patch adds support for MPLS multipath routes. >> >> Includes following changes to

Re: [PATCH net-next v4 0/2] mpls: multipath support

On 10/21/15, 9:04 PM, Eric W. Biederman wrote: > Roopa Prabhu <ro...@cumulusnetworks.com> writes: > >> From: Roopa Prabhu <ro...@cumulusnetworks.com> >> >> This patch adds support for MPLS multipath routes. >> >> Includes following changes to

[PATCH net-next v4 1/2] mpls: multipath route support

From: Roopa Prabhu <ro...@cumulusnetworks.com> This patch adds support for MPLS multipath routes. Includes following changes to support multipath: - splits struct mpls_route into 'struct mpls_route + struct mpls_nh' - 'struct mpls_nh' represents a mpls nexthop label forwarding entry -

[PATCH net-next v4 0/2] mpls: multipath support

From: Roopa Prabhu <ro...@cumulusnetworks.com> This patch adds support for MPLS multipath routes. Includes following changes to support multipath: - splits struct mpls_route into 'struct mpls_route + struct mpls_nh'. - struct mpls_nh represents a mpls nexthop label forwarding entry

[PATCH net-next v4 2/2] mpls: flow-based multipath selection

From: Robert Shearman Change the selection of a multipath route to use a flow-based hash. This more suitable for traffic sensitive to reordering within a flow (e.g. TCP, L2VPN) and whilst still allowing a good distribution of traffic given enough flows. Selection of the

Re: [PATCH net-next] uapi: add mpls_iptunnel.h

On 10/16/15, 4:12 PM, Stephen Hemminger wrote: > Add missing rule to export mpls iptunnel header needed by iproute2 > > Signed-off-by: Stephen Hemminger <step...@networkplumber.org> Acked-by: Roopa Prabhu <ro...@cumulusnetworks.com> Thanks Stephen. -- To unsubscribe from thi

Re: [PATCH iproute2] ip route get: change exit to return to support batch commands

On 10/15/15, 7:38 PM, David Ahern wrote: > Hi Roopa: > > On 10/15/15 4:23 PM, Roopa Prabhu wrote: >> From: Roopa Prabhu <ro...@cumulusnetworks.com> >> >> replace exit with return -2 on rtnl_talk failure >> >> Signed-off-by: Roopa Prabhu <ro...@c

[PATCH iproute2] bridge: add calls to fflush in fdb and mdb print functions

From: Wilson Kok <w...@cumulusnetworks.com> This patch adds fflush in fdb and mdb print functions Signed-off-by: Wilson Kok <w...@cumulusnetworks.com> Signed-off-by: Roopa Prabhu <ro...@cumulusnetworks.com> --- bridge/fdb.c | 2 ++ bridge/mdb.c | 2 ++ 2 files changed, 4 i

[PATCH iproute2] ip route get: change exit to return to support batch commands

From: Roopa Prabhu <ro...@cumulusnetworks.com> replace exit with return -2 on rtnl_talk failure Signed-off-by: Roopa Prabhu <ro...@cumulusnetworks.com> --- ip/iproute.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ip/iproute.c b/ip/iproute.c index da25548..b1

[PATCH iproute2] ip monitor neigh: Change 'delete' to 'Deleted' to be consistent with ip route

From: Roopa Prabhu <ro...@cumulusnetworks.com> It helps to grep for one string "Deleted" when monitoring all events. Fixes: 6ea3ebafe077 ("iproute2: inform user when a neighbor is removed") Signed-off-by: Roopa Prabhu <ro...@cumulusnetworks.com> ---

[PATCH net-next v3 1/2] mpls: multipath route support

From: Roopa Prabhu <ro...@cumulusnetworks.com> This patch adds support for MPLS multipath routes. Includes following changes to support multipath: - splits struct mpls_route into 'struct mpls_route + struct mpls_nh' - 'struct mpls_nh' represents a mpls nexthop label forwarding entry -

[PATCH net-next v3 0/2] mpls: multipath support

From: Roopa Prabhu <ro...@cumulusnetworks.com> This patch adds support for MPLS multipath routes. Includes following changes to support multipath: - splits struct mpls_route into 'struct mpls_route + struct mpls_nh'. - struct mpls_nh represents a mpls nexthop label forwarding entry

[PATCH net-next v3 2/2] mpls: flow-based multipath selection

From: Robert Shearman Change the selection of a multipath route to use a flow-based hash. This more suitable for traffic sensitive to reordering within a flow (e.g. TCP, L2VPN) and whilst still allowing a good distribution of traffic given enough flows. Selection of the

[PATCH iproute2 v2] bridge: add batch command support

From: Wilson Kok <w...@cumulusnetworks.com> This patch adds support to batch bridge commands. Follows ip batch code. Signed-off-by: Wilson Kok <w...@cumulusnetworks.com> Signed-off-by: Roopa Prabhu <ro...@cumulusnetworks.com> Acked-by: Christophe Gouault <christophe.goua

Re: [PATCH net-next v3 1/2] mpls: multipath route support

On 10/11/15, 1:41 PM, Eric W. Biederman wrote: > Roopa Prabhu <ro...@cumulusnetworks.com> writes: > >> From: Roopa Prabhu <ro...@cumulusnetworks.com> >> >> This patch adds support for MPLS multipath routes. >> >> Includes following changes to

Re: [PATCH net-next v3 2/2] mpls: flow-based multipath selection

On 10/11/15, 12:43 PM, Eric W. Biederman wrote: > Roopa Prabhu <ro...@cumulusnetworks.com> writes: > >> From: Robert Shearman <rshea...@brocade.com> >> >> Change the selection of a multipath route to use a flow-based >> hash. This more suitable for traffi

Re: [PATCH net-next v3] bridge: allow adding of fdb entries pointing to the bridge device

o nla_put_failure; > @@ -785,7 +786,7 @@ static int fdb_add_entry(struct net_bridge_port *source, > const __u8 *addr, > } > } > > - if (fdb_to_nud(fdb) != state) { > + if (fdb_to_nud(br, fdb) != state) { > > Hi Roopa, > > Are the above

[PATCH net-next v2] ipv6 route: use err pointers instead of returning pointer by reference

From: Roopa Prabhu <ro...@cumulusnetworks.com> This patch makes ip6_route_info_create return err pointer instead of returning the rt pointer by reference as suggested by Dave Signed-off-by: Roopa Prabhu <ro...@cumulusnetworks.com> --- v1 - v2: remove unnecessary NULL initiali

[PATCH net-next v3] bridge: allow adding of fdb entries pointing to the bridge device

From: Roopa Prabhu <ro...@cumulusnetworks.com> This patch enables adding of fdb entries pointing to the bridge device. This can be used to propagate mac address of vlan interfaces configured on top of the vlan filtering bridge. Before: $bridge fdb add 44:38:39:00:27:9f dev bridge RTN

[PATCH net-next] ipv6 route: use err pointers instead of returning pointer by reference

From: Roopa Prabhu <ro...@cumulusnetworks.com> This patch makes ip6_route_info_create return err pointer instead of returning the rt pointer by reference as suggested by Dave Signed-off-by: Roopa Prabhu <ro...@cumulusnetworks.com> --- Dave, sorry abt the delay on this one. net-nex

[PATCH iproute2] bridge: add batch command support

From: Wilson Kok <w...@cumulusnetworks.com> This patch adds support to batch bridge commands. Follows ip batch code. Signed-off-by: Wilson Kok <w...@cumulusnetworks.com> Signed-off-by: Roopa Prabhu <ro...@cumulusnetworks.com> --- brid

[PATCH net-next] bridge: allow adding of fdb entries pointing to the bridge device

From: Roopa Prabhu <ro...@cumulusnetworks.com> This patch enables adding of fdb entries pointing to the bridge device. This can be used to propagate mac address of vlan interfaces configured on top of the vlan filtering bridge. Before: $bridge fdb add 44:38:39:00:27:9f dev bridge RTN

[PATCH net-next v2 1/2] mpls: multipath support

From: Roopa Prabhu <ro...@cumulusnetworks.com> This patch adds support for MPLS multipath routes. Includes following changes to support multipath: - splits struct mpls_route into 'struct mpls_route + struct mpls_nh' - 'struct mpls_nh' represents a mpls nexthop label forwarding entry -

[PATCH net-next v2 0/2] mpls: multipath support

From: Roopa Prabhu <ro...@cumulusnetworks.com> This patch adds support for MPLS multipath routes. Includes following changes to support multipath: - splits struct mpls_route into 'struct mpls_route + struct mpls_nh'. - struct mpls_nh represents a mpls nexthop label forwarding entry

[PATCH net-next v2 2/2] mpls: flow-based multipath selection

From: Robert Shearman Change the selection of a multipath route to use a flow-based hash. This more suitable for traffic sensitive to reordering within a flow (e.g. TCP, L2VPN) and whilst still allowing a good distribution of traffic given enough flows. Selection of the

Re: [PATCH net-next v2 1/2] mpls: multipath support

On 10/6/15, 12:44 PM, Eric W. Biederman wrote: > Roopa Prabhu <ro...@cumulusnetworks.com> writes: > >> From: Roopa Prabhu <ro...@cumulusnetworks.com> >> >> This patch adds support for MPLS multipath routes. >> >> Includes following changes to

Re: [PATCH net-next v2 1/2] mpls: multipath support

On 10/6/15, 1:11 PM, Eric W. Biederman wrote: > ebied...@xmission.com (Eric W. Biederman) writes: > >> Roopa Prabhu <ro...@cumulusnetworks.com> writes: >> >>> From: Roopa Prabhu <ro...@cumulusnetworks.com> >>> >>> This patch adds supp

[PATCH net-next] iproute2: document -timestamp option

From: Satish Ashok This patch documents bridge and ip -timestamp option Signed-off-by: Satish Ashok --- man/man8/bridge.8 | 3 +++ man/man8/ip.8 | 4 2 files changed, 7 insertions(+) diff --git a/man/man8/bridge.8

[PATCH net-next v2] bridge: allow adding of fdb entries pointing to the bridge device

From: Roopa Prabhu <ro...@cumulusnetworks.com> This patch enables adding of fdb entries pointing to the bridge device. This can be used to propagate mac address of vlan interfaces configured on top of the vlan filtering bridge. Before: $bridge fdb add 44:38:39:00:27:9f dev bridge RTN

Re: [PATCH net-next] bridge: allow adding of fdb entries pointing to the bridge device

On 10/6/15, 8:29 AM, kbuild test robot wrote: > Hi Roopa, > > [auto build test WARNING on next-20151006 -- if it's inappropriate base, > please ignore] > > config: sh-titan_defconfig (attached as .config) > reproduce: > wget > https://git.kernel.org/cg

Re: [PATCH net] fib_rules: fix fib rule dumps across multiple skbs

On 10/2/15, 10:18 AM, Roland Dreier wrote: > On Tue, Sep 22, 2015 at 9:40 PM, Roopa Prabhu <ro...@cumulusnetworks.com> > wrote: >> + err = fib_nl_fill_rule(skb, rule, NETLINK_CB(cb->skb).portid, >> + cb-&

Re: [PATCH net-next v2] net: Add support for filtering neigh dump by master device

-by: David Ahern <d...@cumulusnetworks.com> Acked-by: Roopa Prabhu <ro...@cumulusnetworks.com> -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: Per-flow IPv4 ECMP

On 9/28/15, 1:57 AM, Matthew Dupre wrote: Hi, I'm interested in the Linux kernel's support for per-flow IPv4 ECMP (i.e. consistent path selection based on a hash of the connection tuple). I'd been led to believe[1] that this depended on the route cache, which was removed in 3.6. However, I

[PATCH net-next] rtnl_fdb_dump: catch errors from ndo_fdb_dump and ndo_dflt_fdb_dump

return the status and pass the idx by reference for update. The dump aborts if non-zero status is returned. Signed-off-by: Wilson Kok <w...@cumulusnetworks.com> Signed-off-by: Roopa Prabhu <ro...@cumulusnetworks.com> --- drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c | 6 +++--- d

[PATCH net] fib_rules: fix fib rule dumps across multiple skbs

Wilson Kok <w...@cumulusnetworks.com> Signed-off-by: Roopa Prabhu <ro...@cumulusnetworks.com> --- net/core/fib_rules.c | 14 +- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/net/core/fib_rules.c b/net/core/fib_rules.c index bf77e36..365de66 100644 --- a/net/core

Re: [PATCH net-next 7/7] switchdev: update documentation on FDB ageing_time

On 9/19/15, 7:21 PM, Scott Feldman wrote: Yes, your switch driver is in user-space so you have to use NTF_USE to refresh the entry since you cannot use the kernel driver model to call_switchdev_notifiers(SWITCHDEV_FDB_ADD, ...). Consequently, your entries are not marked with NTF_EXT_LEARNED, so

Re: [PATCH net-next 7/7] switchdev: update documentation on FDB ageing_time

h driver will need to refresh the entries anyways to keep the "last-used" time to now. In which case is there much value in switch driver doing the ageing ?. I am thinking keeping the default behavior of the bridge driver to age and anything else configurable might be a better option. Tha

Re: kernel 4.2 : "bridge vlan" command return empty result (works with kernel 4.1.3)

On 9/16/15, 8:36 PM, Alexandre DERUMIER wrote: he problem went away on my box with the following patch. I will submit an official patch in a bit. Hi, I confirm that your patch fix the problem for me too. Thanks for confirming. -- To unsubscribe from this list: send the line "unsubscribe

[PATCH net v2] rtnetlink: catch -EOPNOTSUPP errors from ndo_bridge_getlink

From: Roopa Prabhu <ro...@cumulusnetworks.com> problem reported: kernel 4.1.3 # bridge vlan portvlan ids eth0 1 PVID Egress Untagged 90 91 92 93

Re: kernel 4.2 : "bridge vlan" command return empty result (works with kernel 4.1.3)

On 9/15/15, 10:39 AM, Alexandre DERUMIER wrote: Hi, since kernel 4.2, "bridge vlan" command return empty result. kernel 4.1.3 # bridge vlan portvlan ids eth0 1 PVID Egress Untagged 90 91 92 93 94 95 96

[PATCH net] rtnetlink: catch -EOPNOTSUPP errors from ndo_bridge_getlink

From: Roopa Prabhu <ro...@cumulusnetworks.com> problem reported: kernel 4.1.3 # bridge vlan portvlan ids eth0 1 PVID Egress Untagged 90 91 92 93

[PATCH net] ipv6: include NLM_F_REPLACE in route replace notifications

From: Roopa Prabhu <ro...@cumulusnetworks.com> This patch adds NLM_F_REPLACE flag to ipv6 route replace notifications. This makes nlm_flags in ipv6 replace notifications consistent with ipv4. Signed-off-by: Roopa Prabhu <ro...@cumulusnetworks.com> --- Submitting this to net since it

Re: IFLA_INET6_[ICMP6]STATS

On 9/9/15, 2:45 PM, Sowmini Varadhan wrote: On (09/09/15 14:43), David Miller wrote: But what we could do is add a flag in the netlink request which elides the stats. GLIBC et al. could then start setting the flag. Yes, interestingly that's what I was experimenting with myself (though I was

Re: [pve-devel] bridge vlan range, kernel 4.1 : "message truncated" warning when too much vlans defined

On 9/9/15, 11:40 PM, Alexandre DERUMIER wrote: Hi, This still not fixed in iproute 4.2. Is they any plan to increase the rtnl_dump_filter buffer size soon ? Instead of increasing the default size, it would be nicer if this was configurable for iproute2 (I haven't looked yet). -- To

Re: [pve-devel] bridge vlan range, kernel 4.1 : "message truncated" warning when too much vlans defined

On 9/10/15, 3:58 PM, David Miller wrote: From: roopa <ro...@cumulusnetworks.com> Date: Thu, 10 Sep 2015 15:26:30 -0700 On 9/9/15, 11:40 PM, Alexandre DERUMIER wrote: Hi, This still not fixed in iproute 4.2. Is they any plan to increase the rtnl_dump_filter buffer size soon ? I

Re: [PATCH net v4] ipv6: fix multipath route replace error recovery

On 9/9/15, 2:10 PM, David Miller wrote: From: Roopa Prabhu <ro...@cumulusnetworks.com> Date: Tue, 8 Sep 2015 10:53:04 -0700 This patch reduces the possibility of this by doing the following: a) Changes the existing multipath route add code to a two stage process: build rt6_infos +

Re: [PATCH] ipv6: fix ifnullfree.cocci warnings

some freeing functions is not needed. Based on checkpatch warning "kfree(NULL) is safe this check is probably not required" and kfreeaddr.cocci by Julia Lawall. Generated by: scripts/coccinelle/free/ifnullfree.cocci CC: Roopa Prabhu <ro...@cumulusnetworks.com> Signed-off-

Re: [PATCH net v3] ipv6: fix multipath route replace error recovery

On 9/8/15, 2:55 AM, Nicolas Dichtel wrote: Le 08/09/2015 02:42, roopa a écrit : On 9/6/15, 1:46 PM, Roopa Prabhu wrote: From: Roopa Prabhu <ro...@cumulusnetworks.com> Problem: The ecmp route replace support for ipv6 in the kernel, deletes the existing ecmp route too early, ie when it in

[PATCH net v4] ipv6: fix multipath route replace error recovery

From: Roopa Prabhu <ro...@cumulusnetworks.com> Problem: The ecmp route replace support for ipv6 in the kernel, deletes the existing ecmp route too early, ie when it installs the first nexthop. If there is an error in installing the subsequent nexthops, its too late to recover the already d

Re: parsing the output of ethtool programmatically

On 9/5/15, 2:53 AM, Ben Hutchings wrote: On Thu, 2015-06-25 at 03:28 +0200, Robert Urban wrote: Hello, there doesn't seem to be any flag to request ethtool to present its output in a script-friendly form. Things like: Link partner advertised link modes: 10baseT/Half 10baseT/Full

Re: [PATCH net-next v2] ipv6: fix multipath route replace error recovery

m that existed then..which was introduced by "51ebd3181572 ("ipv6: add support of equal cost multipath (ECMP)")". Commit "35f1b4e96b9258a3668872b1139c51e5a23eb876 ipv6: do not delete previously existing ECMP routes if add fails" subsequently fixed it. Thanks, Roopa --

Re: [PATCH net v3] ipv6: fix multipath route replace error recovery

On 9/6/15, 1:46 PM, Roopa Prabhu wrote: From: Roopa Prabhu <ro...@cumulusnetworks.com> Problem: The ecmp route replace support for ipv6 in the kernel, deletes the existing ecmp route too early, ie when it installs the first nexthop. If there is an error in installing the subsequent ne

Re: [PATCH net v3] ipv6: fix multipath route replace error recovery

On 9/7/15, 5:37 AM, Nicolas Dichtel wrote: Le 06/09/2015 22:46, Roopa Prabhu a écrit : From: Roopa Prabhu <ro...@cumulusnetworks.com> I've sent you some comments about the v2, so please keep me in CC for the next versions. Problem: The ecmp route replace support for ipv6 in the

[PATCH net v3] ipv6: fix multipath route replace error recovery

From: Roopa Prabhu <ro...@cumulusnetworks.com> Problem: The ecmp route replace support for ipv6 in the kernel, deletes the existing ecmp route too early, ie when it installs the first nexthop. If there is an error in installing the subsequent nexthops, its too late to recover the already d

Re: [PATCH net-next v2] ipv6: fix multipath route replace error recovery

On 9/4/15, 1:12 AM, Nicolas Dichtel wrote: Le 03/09/2015 01:44, Roopa Prabhu a écrit : From: Roopa Prabhu <ro...@cumulusnetworks.com> Problem: The ecmp route replace support for ipv6 in the kernel, deletes the existing ecmp route too early, ie when it installs the first n

Re: [PATCH net-next] ipv6: fix multipath route replace error recovery

On 9/1/15, 10:54 PM, Roopa Prabhu wrote: From: Roopa Prabhu <ro...@cumulusnetworks.com> Problem: The ecmp route replace support for ipv6 in the kernel, deletes the existing ecmp route too early, ie when it installs the first nexthop. If there is an error in installing the subsequent ne

[PATCH net-next v2] ipv6: fix multipath route replace error recovery

From: Roopa Prabhu <ro...@cumulusnetworks.com> Problem: The ecmp route replace support for ipv6 in the kernel, deletes the existing ecmp route too early, ie when it installs the first nexthop. If there is an error in installing the subsequent nexthops, its too late to recover the already d

[PATCH net-next] ipv6: fix multipath route replace error recovery

From: Roopa Prabhu <ro...@cumulusnetworks.com> Problem: The ecmp route replace support for ipv6 in the kernel, deletes the existing ecmp route too early, ie when it installs the first nexthop. If there is an error in installing the subsequent nexthops, its too late to recover the already d

Re: [PATCH net-next v2] bridge: vlan: allow to suppress local mac install for all vlans

On 8/26/15, 4:33 AM, Nikolay Aleksandrov wrote: On Aug 25, 2015, at 11:06 PM, David Miller da...@davemloft.net wrote: From: Nikolay Aleksandrov niko...@cumulusnetworks.com Date: Tue, 25 Aug 2015 22:28:16 -0700 Certainly, that should be done and I will look into it, but the essence of this

Re: [PATCH net-next 06/13] route: move lwtunnel state to dst_entry

it needs the lwtstate data. Moving the lwtstate data to dst_entry makes such inter-protocol tunneling possible. As a bonus, this brings a nice diffstat. Signed-off-by: Jiri Benc jb...@redhat.com Acked-by: Roopa Prabhu ro...@cumulusnetworks.com great..! thanks for doing this. I was working

<    2   3   4   5   6   7   8   9   >