Re: [PATCH net-next 4/5] rds: invoke socket sg filter attached to rds socket

On 9/11/18 12:38 PM, Tushar Dave wrote: RDS module sits on top of TCP (rds_tcp) and IB (rds_rdma), so messages arrive in form of skb (over TCP) and scatterlist (over IB/RDMA). However, because socket filter only deal with skb (e.g. struct skb as bpf context) we can only use socket filter for

Re: [PATCH 1/1] net/rds: Use rdma_read_gids to get connection SGID/DGID in IPv6

On 8/25/18 12:19 AM, Zhu Yanjun wrote: In IPv4, the newly introduced rdma_read_gids is used to read the SGID/DGID for the connection which returns GID correctly for RoCE transport as well. In IPv6, rdma_read_gids is also used. The following are why rdma_read_gids is introduced.

Re: [PATCH v5 net-next 2/3] rds: Enable RDS IPv6 support

On 7/23/18 8:51 PM, Ka-Cheong Poon wrote: This patch enables RDS to use IPv6 addresses. For RDS/TCP, the listener is now an IPv6 endpoint which accepts both IPv4 and IPv6 connection requests. RDS/RDMA/IB uses a private data (struct rds_ib_connect_private) exchange between endpoints at RDS

Re: [PATCH v5 net-next 3/3] rds: Extend RDS API for IPv6 support

On 7/23/18 8:51 PM, Ka-Cheong Poon wrote: There are many data structures (RDS socket options) used by RDS apps which use a 32 bit integer to store IP address. To support IPv6, struct in6_addr needs to be used. To ensure backward compatibility, a new data structure is introduced for each of those

Re: [PATCH v5 net-next 1/3] rds: Changing IP address internal representation to struct in6_addr

On 7/23/18 8:51 PM, Ka-Cheong Poon wrote: This patch changes the internal representation of an IP address to use struct in6_addr. IPv4 address is stored as an IPv4 mapped address. All the functions which take an IP address as argument are also changed to use struct in6_addr. But RDS socket

Re: [PATCH v2 net-next 1/3] rds: Changing IP address internal representation to struct in6_addr

On 7/6/18 2:08 AM, Ka-Cheong Poon wrote: On 07/06/2018 01:58 AM, Santosh Shilimkar wrote: diff --git a/net/rds/connection.c b/net/rds/connection.c index abef75d..ca72563 100644 --- a/net/rds/connection.c +++ b/net/rds/connection.c @@ -142,9 +151,12 @@ static void

Re: general protection fault in rds_ib_get_mr

On 5/13/18 2:10 PM, Eric Biggers wrote: On Wed, Mar 21, 2018 at 09:00:01AM -0700, syzbot wrote: [...] Still reproducible on Linus' tree (commit 66e1c94db3cd4) and linux-next (next-20180511). Here's a simplified reproducer: Thanks for the test case !! Regards, Santosh

Re: [PATCH 1/1] Revert "rds: ib: add error handle"

On 4/23/18 6:39 PM, Zhu Yanjun wrote: This reverts commit 3b12f73a5c2977153f28a224392fd4729b50d1dc. After long time discussion and investigations, it seems that there is no mem leak. So this patch is reverted. Signed-off-by: Zhu Yanjun --- Well your fix was not for any

Re: [PATCH net] rds: MP-RDS may use an invalid c_path

be non-MP capable, the message will be lost as only the zero c_path can be used. Signed-off-by: Ka-Cheong Poon <ka-cheong.p...@oracle.com> --- Thanks for posting the fix upstream as well. Acked-by: Santosh Shilimkar <santosh.shilim...@oracle.com>

Re: [PATCH 2/2] net: rds: drop VLA in rds_walk_conn_path_info()

On 3/11/18 2:07 PM, Salvatore Mesoraca wrote: Avoid VLA[1] by using an already allocated buffer passed by the caller. [1] https://lkml.org/lkml/2018/3/7/621 Signed-off-by: Salvatore Mesoraca <s.mesorac...@gmail.com> --- Acked-by: Santosh Shilimkar <santosh.shilim...@oracle.com>

Re: [PATCH 1/2] net: rds: drop VLA in rds_for_each_conn_info()

limkar <santosh.shilim...@oracle.com>

Re: [PATCH][rds-next] rds: make functions rds_info_from_znotifier and rds_message_zcopy_from_user static

On 3/11/18 11:54 PM, santosh.shilim...@oracle.com wrote: On 3/11/18 10:03 AM, Colin King wrote: From: Colin Ian King <colin.k...@canonical.com> Functions rds_info_from_znotifier and rds_message_zcopy_from_user are local to the source and do not need to be in global scope, so make them

Re: [PATCH][rds-next] rds: make functions rds_info_from_znotifier and rds_message_zcopy_from_user static

e changed, 4 insertions(+), 2 deletions(-) Acked-by: Santosh Shilimkar <santosh.shilim...@oracle.com>

Re: [PATCH][rds-next] rds: remove redundant variable 'sg_off'

Signed-off-by: Colin Ian King <colin.k...@canonical.com> --- net/rds/message.c | 2 -- 1 file changed, 2 deletions(-) Thanks Colin !! Acked-by: Santosh Shilimkar <santosh.shilim...@oracle.com>

Re: [PATCH v2 net] rds: Incorrect reference counting in TCP socket creation

e comments Versioning comment typically goes below "---" and not part of commit message. Signed-off-by: Ka-Cheong Poon <ka-cheong.p...@oracle.com> --- Patch looks fine. Acked-by: Santosh Shilimkar <santosh.shilim...@oracle.com>

Re: BUG: spinlock bad magic (2)

On 1/30/18 2:28 PM, Eric Biggers wrote: On Mon, Dec 18, 2017 at 06:01:30PM +0100, 'Dmitry Vyukov' via syzkaller-bugs wrote: On Mon, Dec 18, 2017 at 5:46 PM, Santosh Shilimkar <santosh.shilim...@oracle.com> wrote: On 12/18/2017 4:36 AM, syzbot wrote: Hello, syzkaller hit the fol

Re: [PATCH] rds: fix use-after-free read in rds_find_bound

On 12/31/17 4:33 AM, Sowmini Varadhan wrote: On (12/30/17 21:09), santosh.shilim...@oracle.com wrote: Right. This was loop transport in action so xmit will just flip the direction with receive. And rds_recv_incoming() can race with socket_release. rds_find_bound() is suppose to add ref count

Re: [PATCH] rds: fix use-after-free read in rds_find_bound

On 12/30/17 2:32 PM, Sowmini Varadhan wrote: On (12/30/17 13:37), santosh.shilim...@oracle.com wrote: [...] Thats what I thought as well initially but since the reported case, the rs seems to be valid where as sk seems to be freed up as part of sock_release callback. I dont understand

Re: [PATCH] rds: fix use-after-free read in rds_find_bound

On 12/30/17 12:26 PM, Sowmini Varadhan wrote: On (12/30/17 11:36), Santosh Shilimkar wrote: socket buffer can get freed as part of sock_close callback so before adding reference check underneath socket validity. I'm not sure I understand this fix- struct rds_sock is: struct rds_sock {

Re: KASAN: use-after-free Read in rds_find_bound

On 12/30/17 1:17 AM, syzbot wrote: Hello, syzkaller hit the following crash on fba961ab29e5ffb055592442808bb0f7962e05da git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git/master compiler: gcc (GCC) 7.1.1 20170620 .config is attached Raw console output is attached. Unfortunately,

Re: [PATCH net] RDS: Check cmsg_len before dereferencing CMSG_DATA

that the cmsg_len is large enough to hold the data to be read, before proceeding further. Reported-by: syzbot <syzkaller-b...@googlegroups.com> Signed-off-by: Avinash Repaka <avinash.rep...@oracle.com> --- Thanks !! Acked-by: Santosh Shilimkar <santosh.shilim...@oracle.com>

Re: [PATCH v2 4/5] rds: Add runchecks.cfg for net/rds

On 12/16/17 10:24 AM, Joe Perches wrote: On Sat, 2017-12-16 at 09:45 -0800, Stephen Hemminger wrote: On Sat, 16 Dec 2017 15:42:29 +0100 Knut Omang wrote: +# Code simplification: +# +except ALLOC_WITH_MULTIPLY ib.c +except PREFER_PR_LEVEL ib_cm.c ib_recv.c ib_send.c

Re: [PATCH] RDS: constify rhashtable_params

On 8/30/17 4:49 AM, Arvind Yadav wrote: rhashtable_params are not supposed to change at runtime. All Functions rhashtable_* working with const rhashtable_params provided by . So mark the non-const structs as const. Signed-off-by: Arvind Yadav --- This is already

Re: [PATCH 0/3] ARM: dts: keystone-k2g: Add DCAN instances to 66AK2G

On 8/7/17 2:31 PM, Franklin S Cooper Jr wrote: Hi Santosh, On 08/04/2017 12:07 PM, Santosh Shilimkar wrote: Hi Franklin, On 8/2/2017 1:18 PM, Franklin S Cooper Jr wrote: Add D CAN nodes to 66AK2G based SoC dtsi. Franklin S Cooper Jr (2): dt-bindings: net: c_can: Update binding for clock

Re: [PATCH] RDS: IB: NULL dereference on error in rds_ib_alloc_frmr()

Carpenter <dan.carpen...@oracle.com> Thanks Dan for fix. Acked-by: Santosh Shilimkar <santosh.shilim...@oracle.com> You haven't copied netdev. Can you please resend the patch with my ack on netdev so that Dave can pick it up.

Re: [PATCH net-next 2/2] rds: tcp: canonical connection order for all paths with index > 0

address via rds_start_mprds. To achieve this, rds_connection_worker should check that cp_index > 0. Signed-off-by: Sowmini Varadhan <sowmini.varad...@oracle.com> --- Acked-by: Santosh Shilimkar <santosh.shilim...@oracle.com>

Re: [PATCH net-next 1/2] rds: tcp: allow progress of rds_conn_shutdown if the rds_connection is marked ERROR by an intervening FIN

was processed in softirq context. This is not a fatal error: rds_conn_shutdown() should continue the shutdown, and there is no need to log noisy messages about this event. Signed-off-by: Sowmini Varadhan <sowmini.varad...@oracle.com> --- Acked-by: Santosh Shilimkar <santosh.shilim...@oracle.com>

Re: [PATCHv2 1/4] rds: ib: drop unnecessary rdma_reject

om> Acked-by: Santosh Shilimkar <santosh.shilim...@oracle.com> Signed-off-by: Zhu Yanjun <yanjun@oracle.com> --- Change from v1 to v2: Add the acker. net/rds/ib_cm.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/net/rds/ib_cm.c b/net/rds/ib_cm.c index

Re: [PATCH 2/5] rds: ib: replace spin_lock_irq with spin_lock_irqsave

On 3/11/17 6:33 PM, Yanjun Zhu wrote: Sorry. I have no test case to show some issue. But from Linux Kernel Development Second Edition by Robert Love. Yes I know the book and what the API does :D Use spin_lock_irq is dangerous since spin_unlock_irq unconditionally enables interrupts. We can

Re: [PATCH net 0/3] rds: tcp: fix various rds-tcp issues during netns create/delete sequences

the series and see if it fixes the issue(s). The fixes looks good to me. FWIW, Acked-by: Santosh Shilimkar <santosh.shilim...@oracle.com>

Re: [PATCH 1/1] rds: fix memory leak error

On 2/24/17 11:12 AM, David Miller wrote: From: Santosh Shilimkar <santosh.shilim...@oracle.com> Date: Fri, 24 Feb 2017 08:49:19 -0800 On 2/24/2017 1:28 AM, Zhu Yanjun wrote: When the function register_netdevice_notifier fails, the memory allocated by kmem_cache_create should be

Re: [net-next][PATCH] RDS: keep data type consistent in the user visible header

On 2/21/17 6:29 AM, David Laight wrote: The entire file should use the proper "__uX" kernel types rather than the uint* ones. The uint* ones are part of the C standard :-) Should have been uint*_t :-)

Re: [net-next][PATCH v2] RDS: Make user visible data types consistent with rest of the kernel

On 2/20/17 7:18 PM, David Miller wrote: From: Santosh Shilimkar <santosh.shilim...@oracle.com> Date: Mon, 20 Feb 2017 14:16:53 -0800 Use "__uX/__sX" kernel types rather than current uint*/int* for entire file. Reviewed-by: Sowmini Varadhan <sowmini.varad...@oracle.com>

Re: [PATCH 7/9] RDS: IB: Remove an unused structure member

On 1/10/17 4:56 PM, Bart Van Assche wrote: Signed-off-by: Bart Van Assche <bart.vanass...@sandisk.com> Acked-by: Santosh Shilimkar <santosh.shilim...@oracle.com>

Re: [PATCH] RDS: Simplify code

On 9/4/16 11:23 AM, Leon Romanovsky wrote: On Sun, Sep 04, 2016 at 05:57:20PM +0200, Christophe JAILLET wrote: Le 04/09/2016 à 14:20, Leon Romanovsky a écrit : On Sat, Sep 03, 2016 at 07:33:29AM +0200, Christophe JAILLET wrote: Calling 'list_splice' followed by 'INIT_LIST_HEAD' is equivalent

Re: [PATCH] net: rds: fix coding style issues

spaces to tabs tcp_send.c: convert spaces to tabs transport.c: move brace up one line on for statement Signed-off-by: Joshua Houghton <j...@awful.name> --- Thanks for doing it. Acked-by: Santosh Shilimkar <santosh.shilim...@oracle.com>

Re: [net-next][PATCH 0/2] RDS: couple of fixes for 4.6

On 4/13/16 8:36 PM, David Miller wrote: From: Santosh Shilimkar <santosh.shilim...@oracle.com> Date: Fri, 8 Apr 2016 15:26:38 -0700 Patches are also available at below git tree. git://git.kernel.org/pub/scm/linux/kernel/git/ssantosh/linux.git for_4.6/net-next/rds-fixes "Bug fi

Re: [PATCH] RDS: sync congestion map updating

ell. From 5614b61f6fdcd6ae0c04e50b97efd13201762294 Mon Sep 17 00:00:00 2001 From: Santosh Shilimkar <santosh.shilim...@oracle.com> Date: Wed, 30 Mar 2016 23:26:47 -0700 Subject: [PATCH] RDS: Fix the atomicity for congestion map update Two different threads with different rds so

Re: [PATCH] rds: rds-stress show all zeros after few minutes

due to far cong map corruption. Reviewed-by: Wengang Wang <wen.gang.w...@oracle.com> Reviewed-by: Ajaykumar Hotchandani <ajaykumar.hotchand...@oracle.com> Acked-by: Santosh Shilimkar <santosh.shilim...@oracle.com> Tested-by: Anand Bibhuti <anand.bibh...@oracle.com> Signed

Re: [net-next][PATCH v2 01/13] RDS: Drop stale iWARP RDMA transport

On 2/28/16 11:51 AM, Or Gerlitz wrote: On Sun, Feb 28, 2016 at 4:19 AM, Santosh Shilimkar <santosh.shilim...@oracle.com> wrote: RDS iWarp support code has become stale and non testable. As indicated earlier, am dropping the support for it. If new iWarp user(s) shows up in future, we can

Re: [net-next][PATCH v2 11/13] RDS: IB: add Fastreg MR (FRMR) detection support

ed-off-by: Santosh Shilimkar <santosh.shilim...@oracle.com> --- v2: Dropped the module parameter as suggested by David Miller This means we only use the safer method if the HCA doesn't support the other one. All other RDMA ULP that support both methods have a module_param so the veto from D

Re: [net-next][PATCH v2 01/13] RDS: Drop stale iWARP RDMA transport

On 2/28/16 1:05 AM, Christoph Hellwig wrote: On Sat, Feb 27, 2016 at 06:19:38PM -0800, Santosh Shilimkar wrote: RDS iWarp support code has become stale and non testable. As indicated earlier, am dropping the support for it. If new iWarp user(s) shows up in future, we can adapat the RDS IB

Re: [net-next][PATCH 00/13] RDS: Major clean-up with couple of new features for 4.6

Hi Dave, On 2/26/16 9:43 PM, Santosh Shilimkar wrote: Series is generated against net-next but also applies against Linus's tip cleanly. The diff-stat looks bit scary since almost ~4K lines of code is getting removed. [...] Entire patchset is available below git tree:

Re: [PATCH] net: rds: don't pretend to use cpu notifiers

Hi Sebastian, On 11/27/15 8:00 AM, Sebastian Andrzej Siewior wrote: It looks like an attempt to use CPU notifier here which was never completed. Nobody tried to wire it up completely since 2k9. So I unwind this code and get rid of everything not required. Oh look! 19 lines were removed while

Re: [RFC PATCH] RDS: convert bind hash table to re-sizable hashtable

.@davemloft.net> Signed-off-by: Santosh Shilimkar <santosh.shilim...@oracle.com> --- As promised in last series review, here is an RFC to conver RDS to make use of re-sizable hash tables. I haven't turned on auto shrinking on by purpose. Ignore the automatic_shrinking remark since patch has

Re: [PATCH net-next] RDS: Invoke ->laddr_check() in rds_bind() for explicitly bound transports.

rds_remove_bound(rs); + } else { + ret = 0; + } Acked-by: Santosh Shilimkar <santosh.shilim...@oracle.com> -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger

Re: [PATCH net-next] RDS-TCP: Reset tcp callbacks if re-using an outgoing socket in rds_tcp_accept_one()

ff-by: Sowmini Varadhan <sowmini.varad...@oracle.com> --- Looks fine to me. Acked-by: Santosh Shilimkar <santosh.shilim...@oracle.com> -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v3 00/14] RDS: connection scalability and performance improvements

On 10/7/15 2:16 AM, David Miller wrote: From: Santosh Shilimkar <santosh.shilim...@oracle.com> Date: Mon, 5 Oct 2015 10:56:23 -0700 [v3] Updated patch "[PATCH v2 05/14] RDS: defer the over_batch work to send worker" as per David Miller's comment [4] to avoid the magic value

Re: [PATCH v2 00/14] RDS: connection scalability and performance improvements

On 10/1/15 9:19 AM, David Laight wrote: From: Santosh Shilimkar Sent: 30 September 2015 18:24 ... This is being addressed by simply using per bucket rw lock which makes the locking simple and very efficient. The hash table size is still an issue and I plan to address it by using re-sizable

Re: [PATCH] RDS: verify the underlying transport exists before creating a connection

e send. Anyway, we can't control the application so having this hole plugged is good. Please include the back trace in the commit log. With that update, Acked-by: Santosh Shilimkar <santosh.shilim...@oracle.com> -- To unsubscribe from this list: send the line "unsubscribe netdev" in

Re: [PATCH net-next] RDS: rds_conn_lookup() should factor in the struct net for a match

sowmini.varad...@oracle.com> --- Acked-by: Santosh Shilimkar <santosh.shilim...@oracle.com> -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [net-next:master 1267/1290] net/rds/ib_recv.c:382:28: sparse: incorrect type in initializer (different base types)

On 8/25/15 3:55 PM, David Miller wrote: From: kbuild test robot fengguang...@intel.com Date: Wed, 26 Aug 2015 06:42:39 +0800 sparse warnings: (new ones prefixed by ) net/rds/ib_recv.c:382:28: sparse: incorrect type in initializer (different base types) net/rds/ib_recv.c:382:28: