On 2018/10/30 17:11, Sergei Shtylyov wrote:
On 10/29/2018 4:54 PM, Huazhong Tan wrote:
When hns3_nic_init_vector_data() fails to map ring to vector,
it should cancel the netif_napi_add() that has been successfully
done and then exits.
Fixes: 76ad4f0ee747 ("net: hns3: Add support of HNS3
On 2018/10/30 17:09, Sergei Shtylyov wrote:
Hello!
On 10/29/2018 4:54 PM, Huazhong Tan wrote:
When hns3_get_ring_config()/hns3_queue_to_ring() failed during resetting,
the allocated memory has not been freed before hns3_get_ring_config() and
hns3_queue_to_ring() return. So this patch fixes
On 2018/10/30 9:31, Joe Perches wrote:
On Tue, 2018-10-30 at 09:21 +0800, tanhuazhong wrote:
On 2018/10/30 1:44, Joe Perches wrote:
On Mon, 2018-10-29 at 21:54 +0800, Huazhong Tan wrote:
When hns3_nic_init_vector_data() fails to map ring to vector,
it should cancel the netif_napi_add
On 2018/10/30 1:44, Joe Perches wrote:
On Mon, 2018-10-29 at 21:54 +0800, Huazhong Tan wrote:
When hns3_nic_init_vector_data() fails to map ring to vector,
it should cancel the netif_napi_add() that has been successfully
done and then exits.
[]
diff --git
On 2018/10/28 16:09, Sergei Shtylyov wrote:
Hello!
On 28.10.2018 6:34, Huazhong Tan wrote:
It is not necessary to reset the queue in the hns3_uninit_all_ring(),
since the queue is stopped in the down operation, and will be reset
in the up operaton. And the judgment of the
On 2018/10/28 3:05, Sergei Shtylyov wrote:
On 27.10.2018 5:41, Huazhong Tan wrote:
In a multi-core machine, the mailbox service and reset service
will be executed at the same time. The reset server will re-initialize
the commond queue, before that, the mailbox handler can only get some
On 2018/10/28 3:02, Sergei Shtylyov wrote:
Hello!
On 27.10.2018 5:41, Huazhong Tan wrote:
It is not necessary to reset the queue in the hns3_uninit_all_ring(),
since the queue is stopped in the down operation, and will be resetted
s/resetted/reset/.
OK, thanks.
in the up
On 2018/8/2 1:03, David Miller wrote:
From: Huazhong Tan
Date: Wed, 1 Aug 2018 17:53:28 +0800
From: fredalu
While cleaning the command queue, the value of the HEAD register is not
in the range of next_to_clean and next_to_use, meaning that this value
is invalid. This also means that
Sorry, please ignore this patch. I will resend it.
-邮件原件-
发件人: netdev-ow...@vger.kernel.org [mailto:netdev-ow...@vger.kernel.org] 代表
Huazhong Tan
发送时间: 2018年8月1日 17:53
收件人: da...@davemloft.net
抄送: netdev@vger.kernel.org; Linuxarm
主题: [Patch net-next] net: hns3: fix return value error
