Re: [2.6 patch] net/decnet/dn_route.c: fix inconsequent NULL checking

2006-03-14 Thread David S. Miller
From: Adrian Bunk [EMAIL PROTECTED] Date: Sat, 11 Mar 2006 00:02:33 +0100 The Coverity checker noted this inconsequent NULL checking in dnrt_drop(). Since all callers ensure that NULL isn't passed, we can simply remove the check. Signed-off-by: Adrian Bunk [EMAIL PROTECTED] Applied,

[2.6 patch] net/decnet/dn_route.c: fix inconsequent NULL checking

2006-03-10 Thread Adrian Bunk
The Coverity checker noted this inconsequent NULL checking in dnrt_drop(). Since all callers ensure that NULL isn't passed, we can simply remove the check. Signed-off-by: Adrian Bunk [EMAIL PROTECTED] --- linux-2.6.16-rc5-mm3-full/net/decnet/dn_route.c.old 2006-03-10 23:34:57.0 +0100

Re: [2.6 patch] net/decnet/dn_route.c: fix inconsequent NULL checking

2006-03-10 Thread Herbert Xu
Adrian Bunk [EMAIL PROTECTED] wrote: The Coverity checker noted this inconsequent NULL checking in dnrt_drop(). Since all callers ensure that NULL isn't passed, we can simply remove the check. Ack. In fact it's pointless even if the caller didn't check as dst_release checks it anyway.