Re: [Bugme-new] [Bug 8107] New: dev-header_cache_update has a random value

2007-03-02 Thread Krzysztof Halasa
Andrew Morton [EMAIL PROTECTED] writes: However, in drivers/net/wan/hdlc_cisco.c, in function static int cisco_ioctl(struct net_device *dev, struct ifreq *ifr), where dev-hard_header is assigned a valid function, and dev-hard_header_cache is assigned a known value (NULL), dev-

Re: [Bugme-new] [Bug 8107] New: dev-header_cache_update has a random value

2007-03-02 Thread David Miller
From: Krzysztof Halasa [EMAIL PROTECTED] Date: Fri, 02 Mar 2007 16:29:06 +0100 Andrew Morton [EMAIL PROTECTED] writes: However, in drivers/net/wan/hdlc_cisco.c, in function static int cisco_ioctl(struct net_device *dev, struct ifreq *ifr), where dev-hard_header is assigned a valid

Re: [Bugme-new] [Bug 8107] New: dev-header_cache_update has a random value

2007-03-02 Thread Krzysztof Halasa
Switching HDLC devices from Ethernet-framing mode caused stale ethernet function assignments within net_device. Signed-off-by: Krzysztof Halasa [EMAIL PROTECTED] diff --git a/drivers/net/wan/hdlc.c b/drivers/net/wan/hdlc.c index db354e0..f6e6b63 100644 --- a/drivers/net/wan/hdlc.c +++

Re: [Bugme-new] [Bug 8107] New: dev-header_cache_update has a random value

2007-03-02 Thread Krzysztof Halasa
David Miller [EMAIL PROTECTED] writes: I disagree, you can't leave dangling references to functions which are potentially inside of unloaded modules, as this code does. All such pointers were thought to be initialized by all HDLC protocol handlers before device activation, but they were

Re: [Bugme-new] [Bug 8107] New: dev-header_cache_update has a random value

2007-03-02 Thread David Miller
From: Krzysztof Halasa [EMAIL PROTECTED] Date: Sat, 03 Mar 2007 00:38:05 +0100 Switching HDLC devices from Ethernet-framing mode caused stale ethernet function assignments within net_device. Signed-off-by: Krzysztof Halasa [EMAIL PROTECTED] This looks good to me, I think I'll apply it :-)

Re: [Bugme-new] [Bug 8107] New: dev-header_cache_update has a random value

2007-03-01 Thread Andrew Morton
On Thu, 1 Mar 2007 11:33:05 -0800 [EMAIL PROTECTED] wrote: http://bugzilla.kernel.org/show_bug.cgi?id=8107 Summary: dev-header_cache_update has a random value Kernel Version: 2.6.20 Status: NEW Severity: high Owner: [EMAIL PROTECTED]

Re: [Bugme-new] [Bug 8107] New: dev-header_cache_update has a random value

2007-03-01 Thread Stephen Hemminger
On Thu, 1 Mar 2007 14:34:17 -0800 Andrew Morton [EMAIL PROTECTED] wrote: On Thu, 1 Mar 2007 11:33:05 -0800 [EMAIL PROTECTED] wrote: http://bugzilla.kernel.org/show_bug.cgi?id=8107 Summary: dev-header_cache_update has a random value Kernel Version: 2.6.20

Re: [Bugme-new] [Bug 8107] New: dev-header_cache_update has a random value

2007-03-01 Thread Andrew Morton
On Thu, 1 Mar 2007 14:37:27 -0800 Stephen Hemminger [EMAIL PROTECTED] wrote: On Thu, 1 Mar 2007 14:34:17 -0800 Andrew Morton [EMAIL PROTECTED] wrote: On Thu, 1 Mar 2007 11:33:05 -0800 [EMAIL PROTECTED] wrote: http://bugzilla.kernel.org/show_bug.cgi?id=8107 Summary:

Re: [Bugme-new] [Bug 8107] New: dev-header_cache_update has a random value

2007-03-01 Thread Stephen Hemminger
On Thu, 1 Mar 2007 14:54:23 -0800 Andrew Morton [EMAIL PROTECTED] wrote: On Thu, 1 Mar 2007 14:37:27 -0800 Stephen Hemminger [EMAIL PROTECTED] wrote: On Thu, 1 Mar 2007 14:34:17 -0800 Andrew Morton [EMAIL PROTECTED] wrote: On Thu, 1 Mar 2007 11:33:05 -0800 [EMAIL PROTECTED]