Stephen Hemminger wrote:
This looks good, but you could use a structure assignment rather memcpy
(just a personal style preference because assignment is typed and memcpy
is not).
That doesn't work in this case since nf_bridge_info contains
unsigned long data[32 / sizeof(unsigned long)]
On Wed, 16 Jan 2008 05:59:21 +0100
Patrick McHardy <[EMAIL PROTECTED]> wrote:
> Patrick McHardy wrote:
> > Very nice catch, that explains quite a few bug reports about
> > refcnt leaks. Your patch looks correct and performs the copying
> > in the logically correct place, it would be nicer to keep
Patrick McHardy wrote:
Very nice catch, that explains quite a few bug reports about
refcnt leaks. Your patch looks correct and performs the copying
in the logically correct place, it would be nicer to keep this
crap limited to bridge netfilter however.
What should work is to perform the copying
Andrew Morton wrote:
On Tue, 15 Jan 2008 15:28:31 -0800 (PST)
[EMAIL PROTECTED] wrote:
http://bugzilla.kernel.org/show_bug.cgi?id=9758
The bug is probably around since the combination bridge+NFQUEUE is possible,
and does not depend on distro or environment:
Packets that are to be sent out ove
On Tue, 15 Jan 2008 15:28:31 -0800 (PST)
[EMAIL PROTECTED] wrote:
> http://bugzilla.kernel.org/show_bug.cgi?id=9758
>
>Summary: net_device refcnt bug when NFQUEUEing bridged packets
>Product: Networking
>Version: 2.5
> KernelVersion: 2.6.24-rc7
>
