On Tue, 04 Sep 2007 16:14:06 +0800 Micah Gruber [EMAIL PROTECTED] wrote:
This patch fixes a potential null dereference bug where we dereference dev
before a null check. This patch simply moves the dereferencing after the null
check.
Signed-off-by: Micah Gruber [EMAIL PROTECTED]
---
On Thu, Sep 13, 2007 at 02:03:46AM -0700, Andrew Morton wrote:
I suspect the fix we want is:
ack. The trend seems to be to avoid this redundant check in the
interrupt handler.
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More
Andrew Morton wrote:
---
a/drivers/net/tulip/uli526x.c~fix-a-potential-null-pointer-dereference-in-uli526x_interrupt
+++ a/drivers/net/tulip/uli526x.c
@@ -666,11 +666,6 @@ static irqreturn_t uli526x_interrupt(int
unsigned long ioaddr = dev-base_addr;
unsigned long flags;
- if
Micah Gruber wrote:
This patch fixes a potential null dereference bug where we dereference dev
before a null check. This patch simply moves the dereferencing after the null
check.
Signed-off-by: Micah Gruber [EMAIL PROTECTED]
---
--- a/drivers/net/tulip/uli526x.c
+++
This patch fixes a potential null dereference bug where we dereference dev
before a null check. This patch simply moves the dereferencing after the null
check.
Signed-off-by: Micah Gruber [EMAIL PROTECTED]
---
--- a/drivers/net/tulip/uli526x.c
+++ b/drivers/net/tulip/uli526x.c
@@ -663,7 +663,7
