Re: [Cake] [PATCH net-next v12 3/7] sch_cake: Add optional ACK filter

2018-05-18 Thread Eric Dumazet
On 05/18/2018 04:18 AM, Kevin Darbyshire-Bryant wrote: > > Speaking as a user of cake’s ack filtering, although it may be an odd place, > it is incredibly useful in my linux based home router middle box that > usefully extracts extra usable bandwidth from my asymmetric link. And whilst >

Re: [Cake] [PATCH net-next v12 3/7] sch_cake: Add optional ACK filter

2018-05-18 Thread Sebastian Moeller
Hi Kevin, > On May 18, 2018, at 13:18, Kevin Darbyshire-Bryant > wrote: > > > >> On 18 May 2018, at 05:27, Cong Wang wrote: >> >> On Thu, May 17, 2018 at 4:23 AM, Toke Høiland-Jørgensen wrote: >>> Eric Dumazet

Re: [Cake] [PATCH net-next v12 3/7] sch_cake: Add optional ACK filter

2018-05-18 Thread Kevin Darbyshire-Bryant
> On 18 May 2018, at 05:27, Cong Wang wrote: > > On Thu, May 17, 2018 at 4:23 AM, Toke Høiland-Jørgensen wrote: >> Eric Dumazet writes: >> >>> On 05/16/2018 01:29 PM, Toke Høiland-Jørgensen wrote: The ACK filter is an

Re: [Cake] [PATCH net-next v12 3/7] sch_cake: Add optional ACK filter

2018-05-18 Thread Ryan Mounce
On 18 May 2018 at 13:38, Eric Dumazet wrote: > > > On 05/17/2018 07:36 PM, Ryan Mounce wrote: >> On 17 May 2018 at 22:41, Toke Høiland-Jørgensen wrote: >>> Eric Dumazet writes: >>> On 05/17/2018 04:23 AM, Toke Høiland-Jørgensen

Re: [Cake] [PATCH net-next v12 3/7] sch_cake: Add optional ACK filter

2018-05-17 Thread Eric Dumazet
On 05/17/2018 07:36 PM, Ryan Mounce wrote: > On 17 May 2018 at 22:41, Toke Høiland-Jørgensen wrote: >> Eric Dumazet writes: >> >>> On 05/17/2018 04:23 AM, Toke Høiland-Jørgensen wrote: >>> We don't do full parsing of SACKs, no; we were trying to

Re: [Cake] [PATCH net-next v12 3/7] sch_cake: Add optional ACK filter

2018-05-17 Thread Ryan Mounce
On 17 May 2018 at 22:41, Toke Høiland-Jørgensen wrote: > Eric Dumazet writes: > >> On 05/17/2018 04:23 AM, Toke Høiland-Jørgensen wrote: >> >>> >>> We don't do full parsing of SACKs, no; we were trying to keep things >>> simple... We do detect the presence