Re: [REPOST][GENETLINK]: Fix race in genl_unregister_mc_groups()

2007-07-24 Thread David Miller
From: Thomas Graf <[EMAIL PROTECTED]> Date: Tue, 24 Jul 2007 23:52:57 +0200 > family->mcast_groups is protected by genl_lock so it must > be held while accessing the list in genl_unregister_mc_groups(). > Requires adding a non-locking variant of genl_unregister_mc_group(). > > Signed-off-by: Thom

[REPOST][GENETLINK]: Fix race in genl_unregister_mc_groups()

2007-07-24 Thread Thomas Graf
family->mcast_groups is protected by genl_lock so it must be held while accessing the list in genl_unregister_mc_groups(). Requires adding a non-locking variant of genl_unregister_mc_group(). Signed-off-by: Thomas Graf <[EMAIL PROTECTED]> Index: net-2.6/net/netlink/genetlink.c ===

Re: [GENETLINK]: Fix race in genl_unregister_mc_groups()

2007-07-24 Thread Thomas Graf
* Brian Haley <[EMAIL PROTECTED]> 2007-07-24 12:14 > Thomas Graf wrote: > >@@ -217,14 +229,8 @@ EXPORT_SYMBOL(genl_register_mc_group); > > void genl_unregister_mc_group(struct genl_family *family, > > struct genl_multicast_group *grp) > > { > >-BUG_ON(grp->family != fa

Re: [GENETLINK]: Fix race in genl_unregister_mc_groups()

2007-07-24 Thread Brian Haley
Thomas Graf wrote: @@ -217,14 +229,8 @@ EXPORT_SYMBOL(genl_register_mc_group); void genl_unregister_mc_group(struct genl_family *family, struct genl_multicast_group *grp) { - BUG_ON(grp->family != family); genl_lock(); - netlink_clear_multicast_

[GENETLINK]: Fix race in genl_unregister_mc_groups()

2007-07-24 Thread Thomas Graf
family->mcast_groups is protected by genl_lock so it must be held while accessing the list in genl_unregister_mc_groups(). Requires adding a non-locking variant of genl_unregister_mc_group(). Signed-off-by: Thomas Graf <[EMAIL PROTECTED]> Index: net-2.6/net/netlink/genetlink.c ===