A lot of Thanksgiving turkey leftovers accumulated, here goes:
1) Fix bluetooth l2cap_chan object leak, from Johan Hedberg.
2) IDs for some new iwlwifi chips, from Oren Givon.
3) Fix rtlwifi lockups on boot, from Larry Finger.
4) Fix memory leak in fm10k, from Stephen Hemminger.
5) We have a
1) Fix list tests in netfilter ingress support, from Florian Westphal.
2) Fix reversal of input and output interfaces in ingress hook
invocation, from Pablo Neira Ayuso.
3) We have a use after free in r8169, caught by Dave Jones, fixed by
Francois Romieu.
4) Splice use-after-free fix in
On Mon, Nov 09 2015, Hannes Frederic Sowa wrote:
> Hi,
>
> On Wed, Oct 28, 2015, at 15:27, Rasmus Villemoes wrote:
>>
>> I agree - proper overflow checking can be really hard. Quick, assuming a
>> and b have the same unsigned integer type, is 'a+b>
Hello,
Ingo Molnar writes:
> * Linus Torvalds wrote:
>
>> Does anybody have any particular other "uhhuh, overflow in multiplication"
>> issues in mind? Because the interface for a saturating multiplication (or
>> addition, for that matter)
Hello,
Ingo Molnar writes:
> * Linus Torvalds wrote:
>
>> Does anybody have any particular other "uhhuh, overflow in multiplication"
>> issues in mind? Because the interface for a saturating multiplication (or
>> addition, for that matter)
* Linus Torvalds wrote:
> Does anybody have any particular other "uhhuh, overflow in multiplication"
> issues in mind? Because the interface for a saturating multiplication (or
> addition, for that matter) would actually be much easier. And would be
> trivial
Hi,
On Wed, Oct 28, 2015, at 15:27, Rasmus Villemoes wrote:
> On Wed, Oct 28 2015, Hannes Frederic Sowa
> wrote:
>
> > Hi Linus,
> >
> > On Wed, Oct 28, 2015, at 10:39, Linus Torvalds wrote:
> >> Get rid of it. And I don't *ever* want to see that shit again.
> >
> >
On Fri, Nov 6, 2015 at 7:27 AM, David Laight wrote:
>> From: Linus Torvalds
>> Sent: 03 November 2015 20:45
>> On Tue, Nov 3, 2015 at 12:05 PM, Linus Torvalds
>> wrote:
>> > result = add_overflow(
>> > mul_overflow(sec,
> From: Linus Torvalds
> Sent: 03 November 2015 20:45
> On Tue, Nov 3, 2015 at 12:05 PM, Linus Torvalds
> wrote:
> > result = add_overflow(
> > mul_overflow(sec, SEC_CONVERSION, ),
> > mul_overflow(nsec, NSEC_CONVERSION, ),
> > );
> >
>
Hello,
On Tue, Nov 3, 2015, at 03:38, Linus Torvalds wrote:
> On Mon, Nov 2, 2015 at 5:58 PM, Andy Lutomirski
> wrote:
> >
> > Based in part on an old patch by Sasha, what if we relied on CSE:
> >
> > if (mul_would_overflow(size, n))
> > return NULL;
> >
On Tue, Nov 3, 2015 at 4:53 AM, Hannes Frederic Sowa
wrote:
>
> And furthermore we don't actually have to rely on CSE if we want to, our
> overflow checks could look much more simpler as in "ordinary" C code
> because we tell the compiler that signed overflow is
On Tue, Nov 3, 2015 at 12:05 PM, Linus Torvalds
wrote:
> result = add_overflow(
> mul_overflow(sec, SEC_CONVERSION, ),
> mul_overflow(nsec, NSEC_CONVERSION, ),
> );
>
> return overflow ? MAX_JIFFIES : result;
Thinking more about
On 10/28/2015 02:39 AM, Linus Torvalds wrote:
I'm sorry, but we don't add idiotic new interfaces like this for
idiotic new code like that.
As one of the people who encouraged gcc to add this interface, I'll
speak up in its favor:
Getting overflow checking right in more complicated cases is
On Mon, Nov 2, 2015 at 1:16 PM, Linus Torvalds
wrote:
> On Mon, Nov 2, 2015 at 12:34 PM, Andy Lutomirski wrote:
>>
>> Getting overflow checking right in more complicated cases is a PITA.
>
> No it is not. Not for unsigned values.
Just to clarify.
Hello,
On Mon, Nov 2, 2015, at 22:30, Andy Lutomirski wrote:
> On Mon, Nov 2, 2015 at 1:19 PM, Linus Torvalds
> wrote:
> > On Mon, Nov 2, 2015 at 1:16 PM, Linus Torvalds
> > wrote:
> >> On Mon, Nov 2, 2015 at 12:34 PM, Andy
On Mon, Nov 2, 2015 at 1:19 PM, Linus Torvalds
wrote:
> On Mon, Nov 2, 2015 at 1:16 PM, Linus Torvalds
> wrote:
>> On Mon, Nov 2, 2015 at 12:34 PM, Andy Lutomirski wrote:
>>>
>>> Getting overflow checking right in
On Mon, Nov 2, 2015 at 12:34 PM, Andy Lutomirski wrote:
> On 10/28/2015 02:39 AM, Linus Torvalds wrote:
>>
>> I'm sorry, but we don't add idiotic new interfaces like this for
>> idiotic new code like that.
>
>
> As one of the people who encouraged gcc to add this interface, I'll
On Mon, Nov 2, 2015 at 2:14 PM, Hannes Frederic Sowa
wrote:
>
> overflow_usub was part of a larger header I already prepared to offer
> support for *all* overflow_* checking builtins. While fixing this IPv6
> bug I thought I could hopefully introduce this interface
On Mon, 2015-11-02 at 13:30 -0800, Andy Lutomirski wrote:
>
> I'll stop making inane arguments if you stop bashing arguments I
> didn't make. :) I said the helpers were useful for multiplication (by
> which I meant both signed and unsigned) and, to a lesser extent, for
> signed addition and
On Mon, Nov 2, 2015 at 4:56 PM, Benjamin Herrenschmidt
wrote:
>
> Also how much of the problem is simply that the function signature
> (naming and choice of arguments) just plain sucks ?
Some of that is pretty much inevitable.
C really has no good way to return
On Mon, Nov 2, 2015 at 5:54 PM, Linus Torvalds
wrote:
>
> The biggest problem - and where the compiler could actually help us -
> tends to be multiplication overflows. We have several (not *many*, but
> certainly more than just a couple) cases where we simply check
On Mon, Nov 2, 2015 at 5:58 PM, Andy Lutomirski wrote:
>
> Based in part on an old patch by Sasha, what if we relied on CSE:
>
> if (mul_would_overflow(size, n))
> return NULL;
> do_something_with(size * n);
I suspect we wouldn't even have to rely on CSE. Are these things
From: David Miller
Date: Thu, 29 Oct 2015 08:19:41 -0700 (PDT)
> This is the same as the previous pull request, with the ipv6 overflow
> fix redone. The merge conflict is therefore gone too.
...
> Please pull, thanks a lot.
>
> The following changes since commit
This is the same as the previous pull request, with the ipv6 overflow
fix redone. The merge conflict is therefore gone too.
1) Fix two regressions in ipv6 route lookups, particularly wrt. output
interface specifications in the lookup key. From David Ahern.
2) Fix checks in ipv6 IPSEC
From: Linus Torvalds
Date: Wed, 28 Oct 2015 18:39:56 +0900
> Get rid of it. And I don't *ever* want to see that shit again.
No problem, I'll revert it all.
I asked Hannes to repost his patches to linux-kernel hoping someone
would review and say it stunk or not,
On Wed, Oct 28 2015, Hannes Frederic Sowa wrote:
> Hi Linus,
>
> On Wed, Oct 28, 2015, at 10:39, Linus Torvalds wrote:
>> Get rid of it. And I don't *ever* want to see that shit again.
>
> I don't want to give up on that this easily:
>
> In future I would like to see
This may look a bit scary this late in the release cycle, but as is typically
the case it's predominantly small driver fixes all over the place.
1) Fix two regressions in ipv6 route lookups, particularly wrt. output
interface specifications in the lookup key. From David Ahern.
2) Fix checks
On Wed, Oct 28, 2015 at 3:32 PM, David Miller wrote:
>
> This may look a bit scary this late in the release cycle, but as is typically
> the case it's predominantly small driver fixes all over the place.
Christ people. This is just sh*t.
The conflict I get is due to stupid
Hi Linus,
On Wed, Oct 28, 2015, at 10:39, Linus Torvalds wrote:
> On Wed, Oct 28, 2015 at 3:32 PM, David Miller
> wrote:
> >
> > This may look a bit scary this late in the release cycle, but as is
> > typically
> > the case it's predominantly small driver fixes all over the
1) Account for extra headroom in ath9k driver, from Felix Fietkau.
2) Fix OOPS in pppoe driver due to incorrect socket state transition,
from Guillaume Nault.
3) Kill memory leak in amd-xgbe debugfx, from Geliang Tang.
4) Power management fixes for iwlwifi, from Johannes Berg.
5) Fix races
1) Fix regression in SKB partial checksum handling, from Pravin B
Shalar.
2) Fix VLAN inside of VXLAN handling in i40e driver, from Jesse
Brandeburg.
3) Cure softlockups during accept() in SCTP, from Karl Heiss.
4) MSG_PEEK should return multiple SKBs worth of data in AF_UNIX,
from
1) When we run a tap on netlink sockets, we have to copy mmap'd SKBs
instead of cloning them. From Daniel Borkmann.
2) When converting classical BPF into eBPF, fix the setting of
the source reg to BPF_REG_X. From Tycho Andersen.
3) Fix igmpv3/mldv2 report parsing in the bridge multicast
1) Fix out-of-bounds array access in netfilter ipset, from Jozsef
Kadlecsik.
2) Use correct free operation on netfilter conntrack templates, from
Daniel Borkmann.
3) Fix route leak in SCTP, from Marcelo Ricardo Leitner.
4) Fix sizeof(pointer) in mac80211, from Thierry Reding.
5) Fix
On Sep 8 22:16, Konrad Rzeszutek Wilk wrote:
> On Tue, Sep 8, 2015 at 10:14 PM, Konrad Rzeszutek Wilk
> wrote:
> >
> > (Removed Linus and Andrew from the To, added Corinna ..)
>
> and resending again without HTML (sorry, thought I had HTML-emails
> disabled by default)
> >
>
On Tue, Sep 8, 2015 at 10:14 PM, Konrad Rzeszutek Wilk
wrote:
>
> (Removed Linus and Andrew from the To, added Corinna ..)
and resending again without HTML (sorry, thought I had HTML-emails
disabled by default)
>
> On Thu, Sep 3, 2015 at 1:35 AM, David Miller
> On Sep 7, 2015, at 4:02 AM, David Laight wrote:
>
> Feed:
> int bar(int (*f)[10]) { return sizeof *f; }
> into cc -O2 -S and look at the generated code - returns 40 not 4.
Yes, indeed it does. And with clang too. I guess I was too easily discouraged
when looking for
From: Rustad, Mark D
...
> >> static int smp_ah(struct crypto_blkcipher *tfm, const u8 irk[16],
> >> const u8 r[3], u8 res[3])
> >
> > Expect that it looks like you are passing arrays by value,
> > but instead you are passing by reference.
> >
> > Explicitly pass by reference and
Hi all,
> On Wed, Sep 2, 2015 at 10:35 PM, David Miller wrote:
>>
>> Another merge window, another set of networking changes. I've heard
>> rumblings that the lightweight tunnels infrastructure has been voted
>> networking change of the year.
>
> .. and others say that the
> I find them useful as syntactic sugar. We have not used them a lot, but there
> are cases in our crypto
> handling code where we have fixed size array inputs/outputs and there we
> opted to use them. They make
> it easy to remember what the expected sizes of input and output are without
>
> On Sep 4, 2015, at 2:07 AM, David Laight wrote:
>
>> I find them useful as syntactic sugar. We have not used them a lot, but
>> there are cases in our crypto
>> handling code where we have fixed size array inputs/outputs and there we
>> opted to use them. They make
On Wed, Sep 2, 2015 at 10:35 PM, David Miller wrote:
>
> Another merge window, another set of networking changes. I've heard
> rumblings that the lightweight tunnels infrastructure has been voted
> networking change of the year.
.. and others say that the most notable
On Thu, 3 Sep 2015, Joe Perches wrote:
> On Thu, 2015-09-03 at 11:22 -0700, Linus Torvalds wrote:
> > On Thu, Sep 3, 2015 at 10:40 AM, David Miller wrote:
> > >
> > > Linus, what GCC version are you using and what does the warning look
> > > like?
> >
> > I'm on whatever
On Thu, Sep 3, 2015 at 11:22 AM, Linus Torvalds
wrote:
> [-Wsizeof-array-argument]
Ahh. Google shows that it's an old clang warning that gcc has recently
picked up.
But even clang doesn't seem to have any way for a project to say
"please warn about arrays in
On Thu, Sep 3, 2015 at 10:40 AM, David Miller wrote:
>
> Linus, what GCC version are you using and what does the warning look
> like?
I'm on whatever is in F22. gcc -v says
gcc version 5.1.1 20150618 (Red Hat 5.1.1-4) (GCC)
and the warning looks like so:
On Thu, 2015-09-03 at 11:22 -0700, Linus Torvalds wrote:
> On Thu, Sep 3, 2015 at 10:40 AM, David Miller wrote:
> >
> > Linus, what GCC version are you using and what does the warning look
> > like?
>
> I'm on whatever is in F22. gcc -v says
>
>gcc version 5.1.1
From: Linus Torvalds
Date: Thu, 3 Sep 2015 11:22:10 -0700
> (note the lack of warning about the use of an array in the function
> definition parameter list - I tried to find if there's any way to
> enable such a warning, but couldn't find anything. Maybe my
On Thu, Sep 3, 2015 at 12:32 PM, Julia Lawall wrote:
>
> I find 518 occurrences of a function parameter declaration that contains
> an explicit size. But only the sizeof(mcs_mask) where there is a sizeof
> on such a parameter. I also checked for ARRAY_SIZE on such
From: Linus Torvalds
Date: Thu, 3 Sep 2015 09:45:44 -0700
> But happily gcc has a really really valid warning (kudos - I often end
> up ragging on the bad warnings gcc has, but this one is a keeper),
> because a few lines down the mistake then turns into pure and
On Thu, 3 Sep 2015, Linus Torvalds wrote:
> On Thu, Sep 3, 2015 at 12:32 PM, Julia Lawall wrote:
> >
> > I find 518 occurrences of a function parameter declaration that contains
> > an explicit size. But only the sizeof(mcs_mask) where there is a sizeof
> > on such a
On Thu, Sep 3, 2015 at 1:55 PM, Julia Lawall wrote:
>
> There are 32 2-dimensional arrays in function parameters, and 1
> 3-dimensional array. No 4-dimensional arrays. I didn't check past that.
> None of these has a sizeof or ARRAY_SIZE.
>
> The three dimensional array is
On Thu, 3 Sep 2015, Linus Torvalds wrote:
> On Thu, Sep 3, 2015 at 1:55 PM, Julia Lawall wrote:
> >
> > There are 32 2-dimensional arrays in function parameters, and 1
> > 3-dimensional array. No 4-dimensional arrays. I didn't check past that.
> > None of these has a
Hi David,
On Wed, 02 Sep 2015 22:35:22 -0700 (PDT) David Miller
wrote:
>
> The following changes since commit 4941b8f0c2b9d88e8a6dacebf8b7faf603b98368:
>
> Merge tag 'powerpc-4.2-4' of
> git://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux (2015-08-27
> 17:59:17
On 9/2/15 11:35 PM, David Miller wrote:
Another merge window, another set of networking changes. I've heard
rumblings that the lightweight tunnels infrastructure has been voted
networking change of the year. But what do I know?
...
9) Add support for "light weight tunnels", which allow
Hi Linus,
>> [-Wsizeof-array-argument]
>
> Ahh. Google shows that it's an old clang warning that gcc has recently
> picked up.
>
> But even clang doesn't seem to have any way for a project to say
> "please warn about arrays in function argument declaration". It *is*
> very traditional idiomatic
Some straggler bug fixes here:
1) Netlink_sendmsg() doesn't check iterator type properly in mmap case,
from Ken-ichirou MATSUZAWA.
2) Don't sleep in atomic context in bcmgenet driver, from Florian
Fainelli.
3) The pfkey_broadcast() code patch can't actually ever use anything other
1) Out of bounds array access in 802.11 minstrel code, from Adrien
Schildknecht.
2) Don't use skb_get() in IGMP/MLD code paths, as this makes
pskb_may_pull() BUG. From Linus Luessing.
3) Fix off by one in ipv4 route dumping code, from Andy Whitcroft.
4) Fix deadlock in
1) Workaround hw bug when acquiring PCI bos ownership of iwlwifi
devices, from Emmanuel Grumbach.
2) Falling back to vmalloc in conntrack should not emit a warning,
from Pablo Neira Ayuso.
3) Fix NULL deref when rtlwifi driver is used as an AP, from Luis
Felipe Dominguez Vega.
4)
1) Must tearodnw SR-IOV before unregistering netdev in igb driver, from
Alex Williamson.
2) Fix ipv6 route unreachable crash in IPVS, from Alex Gartrell.
3) Default route selection in ipv4 should take the prefix length,
table ID, and TOS into account, from Julian Anastasov.
4) sch_plug
1) Don't use shared bluetooth antenna in iwlwifi driver for
management frames, from Emmanuel Grumbach.
2) Fix device ID check in ath9k driver, from Felix Fietkau.
3) Off by one in xen-netback BUG checks, from Dan Carpenter.
4) Fix IFLA_VF_PORT netlink attribute validation, from Daniel
On Mon, 2015-07-20 at 18:11 +0800, Xiong Zhou wrote:
Hi
On Wed, Jun 24, 2015 at 9:39 PM, David Miller da...@davemloft.net
wrote:
1) Add TX fast path in mac80211, from Johannes Berg.
[snip far far far FAR too big quote]
was there any content whatsoever in your email?
johannes
--
To
1) Missing list head init in bluetooth hidp session creation, from
Tedd Ho-Jeong An.
2) Don't leak SKB in bridge netfilter error paths, from Florian
Westphal.
3) ipv6 netdevice private leak in netfilter bridging, fixed
by Julien Grall.
4) Fix regression in IP over hamradio bpq
1) mlx4 driver bug fixes (TX queue wakeups, csum complete indications)
from Ido Shamay, Eran Ben Elisha, and Or Gerlitz.
2) Missing unlock in error path of PTP support in renesas driver, from
Dan Carpenter.
3) Add Vitesse 8641 phy IDs to vitesse PHY driver, from Shaohui Xie.
4) Bnx2x
On Thu, Jun 25, 2015 at 2:38 AM, Linus Torvalds
torva...@linux-foundation.org wrote:
On Wed, Jun 24, 2015 at 6:39 AM, David Miller da...@davemloft.net wrote:
git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git master
Just going through the conflicts, I see commit
On Thu, 2015-06-25 at 12:24 -0400, Paul Gortmaker wrote:
On Wed, Jun 24, 2015 at 7:38 PM, Linus Torvalds
torva...@linux-foundation.org wrote:
I'm getting *real* tired of that BUG_ON() shit.
[]
Killing the machine for idiotic things like that is truly offensive,
and truly horrible horrible
On Wed, Jun 24, 2015 at 7:38 PM, Linus Torvalds
torva...@linux-foundation.org wrote:
[...]
I'm getting *real* tired of that BUG_ON() shit. I realize that
infiniband is a niche market, and those commercial grade niche
markets are more-than-used-to crap code and horrible hacks, but this
is
Linus,
On the *other* side of the same conflict, I find an even more offensive
commit,
namely commit 4cd7c9479aff (IB/mad: Add support for additional MAD info
to/from drivers) which adds a BUG_ON() for a sanity check, rather than just
returning -EINVAL or something sane like that.
I'm
On Wed, Jun 24, 2015 at 6:39 AM, David Miller da...@davemloft.net wrote:
git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git master
Just going through the conflicts, I see commit 7193a141eb74 (IB/mlx4:
Set VF to read from QP counters), and wonder...
Is that code really supposed
1) Fix uninitialized struct station_info in cfg80211_wireless_stats(), from
Johannes Berg.
2) Revert commit attempt to fix ipv6 protocol resubmission, it adds
regressions.
3) Endless loops can be created in bridge port lists, fix from Nikolay
Aleksandrov.
4) Don't WARN_ON() if
1) Fix stack allocation in s390 BPF JIT, from Michael Holzheu.
2) Disable LRO on openvswitch paths, from Jiri Benc.
3) UDP early demux doesn't handle multicast group membership
properly, fix from Shawn Bohrer.
4) Fix TX queue hang due to incorrect handling of mixed sized fragments
and
1) Various VTI tunnel (mark handling, PMTU) bug fixes from Alexander Duyck
and Steffen Klassert.
2) Revert ethtool PHY query change, it wasn't correct. The PHY address
selected by the driver running the PHY to MAC connection decides
what PHY address GET ethtool operations return
1) Don't use MMIO on certain iwlwifi devices otherwise we get a firmware
crash.
2) Don't corrupt the GRO lists of mac80211 contexts by doing sends
via timer interrupt, from Johannes Berg.
3) SKB tailroom is miscalculated in AP_VLAN crypto code, from Michal
Kazior.
4) Fix fw_status
1) Don't leak ipvs-sysctl_tbl, from Tommi Rentala.
2) Fix neighbour table entry leak in rocker driver, from Ying Xue.
3) Do not emit bonding notifications for unregistered interfaces, from
Nicolas Dichtel.
4) Set ipv6 flow label properly when in TIME_WAIT state, from Florent
Fourcot.
5)
1) Handle max TX power properly wrt. VIFs and the MAC in iwlwifi,
from Avri Altman.
2) Use the correct FW API for scan completions in iwlwifi, from
Avraham Stern.
3) FW monitor in iwlwifi accidently uses unmapped memory, fix from
Liad Kaufman.
4) rhashtable conversion of mac80211
1) Receive packet length needs to be adjust by 2 on RX to accomodate
the two padding bytes in altera_tse driver. From Vlastimil Setka.
2) If rx frame is dropped due to out of memory in macb driver, we
leave the receive ring descriptors in an undefined state. From
Punnaiah Choudary
On Wed, Apr 1, 2015 at 9:48 PM, David Miller da...@davemloft.net wrote:
D.S. Ljungmark (1):
ipv6: Don't reduce hop limit for an interface
https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=6fd99094de2b83d1d4c8457f2c83483b2828e75a
I was testing this change and
On Wed, 2015-04-29 at 17:17 +0200, D.S. Ljungmark wrote:
On 29/04/15 16:51, Denys Vlasenko wrote:
On Wed, Apr 1, 2015 at 9:48 PM, David Miller da...@davemloft.net wrote:
D.S. Ljungmark (1):
ipv6: Don't reduce hop limit for an interface
1) mlx4 doesn't check fully for supported valid RSS hash function, fix from
Amir Vadai.
2) Off by one in ibmveth_change_mtu(), from David Gibson.
3) Prevent altera chip from reporting false error interrupts in some
circumstances, from Chee Nouk Phoon.
4) Get rid of that stupid endless
Just a few fixes trickling in at this point.
1) If we see an attached socket on an skb in the ipv4 forwarding
path, bail. This can happen due to races with FIB rule addition,
and deletion, and we should just drop such frames. From Sebastian
Pöhn.
2) pppoe receive should only accept
1) Fix verifier memory corruption and other bugs in BPF layer, from
Alexei Starovoitov.
2) Add a conservative fix for doing BPF properly in the BPF classifier
of the packet scheduler on ingress. Also from Alexei.
3) The SKB scrubber should not clear out the packet MARK and security
201 - 279 of 279 matches
Mail list logo