Re: [IPV6]: Audit all ip6_dst_lookup/ip6_dst_store calls

2006-08-01 Thread Andrew Morton
On Mon, 31 Jul 2006 19:04:33 +1000 Herbert Xu [EMAIL PROTECTED] wrote: 2) There is something broken in the x86_64 unwind code which is causing it to panic just about everytime somebody calls dump_stack(). Andi, this is the second time I've seen a report where an otherwise harmless

Re: [IPV6]: Audit all ip6_dst_lookup/ip6_dst_store calls

2006-08-01 Thread Andi Kleen
On Tuesday 01 August 2006 16:41, Andrew Morton wrote: On Mon, 31 Jul 2006 19:04:33 +1000 Herbert Xu [EMAIL PROTECTED] wrote: 2) There is something broken in the x86_64 unwind code which is causing it to panic just about everytime somebody calls dump_stack(). Andi, this is the second

Re: [IPV6]: Audit all ip6_dst_lookup/ip6_dst_store calls

2006-07-31 Thread Herbert Xu
On Sun, Jul 30, 2006 at 10:32:10PM -0500, Matt Domsch wrote: I applied this on 2.6.18-rc3, and it panics immediately as the first IPv6 TCP (ssh) session is initiated to the system. Executive summary: 1) We resolved one lockdep warning only to stumble onto another lockdep validator bug. 2)

Re: [IPV6]: Audit all ip6_dst_lookup/ip6_dst_store calls

2006-07-30 Thread David Miller
From: Herbert Xu [EMAIL PROTECTED] Date: Sat, 29 Jul 2006 14:33:25 +1000 [IPV6]: Audit all ip6_dst_lookup/ip6_dst_store calls The current users of ip6_dst_lookup can be divided into two classes: 1) The caller holds no locks and is in user-context (UDP). 2) The caller does not want

Re: [IPV6]: Audit all ip6_dst_lookup/ip6_dst_store calls

2006-07-30 Thread Matt Domsch
On Sun, Jul 30, 2006 at 03:44:16PM -0700, David Miller wrote: From: Herbert Xu [EMAIL PROTECTED] Date: Sat, 29 Jul 2006 14:33:25 +1000 [IPV6]: Audit all ip6_dst_lookup/ip6_dst_store calls The current users of ip6_dst_lookup can be divided into two classes: 1) The caller holds

Re: [IPV6]: Audit all ip6_dst_lookup/ip6_dst_store calls

2006-07-30 Thread Matt Domsch
On Sun, Jul 30, 2006 at 10:32:10PM -0500, Matt Domsch wrote: On Sun, Jul 30, 2006 at 03:44:16PM -0700, David Miller wrote: From: Herbert Xu [EMAIL PROTECTED] Date: Sat, 29 Jul 2006 14:33:25 +1000 [IPV6]: Audit all ip6_dst_lookup/ip6_dst_store calls The current users

[IPV6]: Audit all ip6_dst_lookup/ip6_dst_store calls

2006-07-28 Thread Herbert Xu
one is a UDP while the other is TCP. However, here is a patch which should shut up the validator as well as removing unnecessary locking from most callers of ip6_dst_lookup. [IPV6]: Audit all ip6_dst_lookup/ip6_dst_store calls The current users of ip6_dst_lookup can be divided into two classes: 1