Re: [Intel-wired-lan] [next] igb: allow setting MAC address on i211 using a device tree blob V5

> On 02.03.2016, at 00:55, Jeff Kirsher wrote: > >> On Tue, 2016-03-01 at 07:56 +0100, John Holland wrote: >> On Mar 1, 2016, at 03:52, Brown, Aaron F >> wrote: >> >>> This throws a few checkpatch warnings, but I won't withhold my >>

Re: [Intel-wired-lan] [next] igb: allow setting MAC address on i211 using a device tree blob V5

On Tue, 2016-03-01 at 07:56 +0100, John Holland wrote: > On Mar 1, 2016, at 03:52, Brown, Aaron F > wrote: > > > This throws a few checkpatch warnings, but I won't withhold my > tested by for these: > >  > > total: 0 errors, 2 warnings, 0 checks, 21 lines checked > >  >

RE: [Intel-wired-lan] [next] igb: allow setting MAC address on i211 using a device tree blob V5

> From: John Holland [mailto:jotih...@gmail.com] > Sent: Monday, February 29, 2016 10:56 PM > To: Brown, Aaron F <aaron.f.br...@intel.com> > Cc: intel-wired-...@lists.osuosl.org; netdev@vger.kernel.org > Subject: Re: [Intel-wired-lan] [next] igb: allow setting MAC address on

Re: [Intel-wired-lan] [next] igb: allow setting MAC address on i211 using a device tree blob V5

On Mar 1, 2016, at 03:52, Brown, Aaron F wrote: > This throws a few checkpatch warnings, but I won't withhold my tested by for > these: > > total: 0 errors, 2 warnings, 0 checks, 21 lines checked > > Your patch has style problems, please review. > > NOTE: If any of

RE: [Intel-wired-lan] [next] igb: allow setting MAC address on i211 using a device tree blob V5

> From: netdev-ow...@vger.kernel.org [mailto:netdev- > ow...@vger.kernel.org] On Behalf Of John Holland > Sent: Thursday, February 18, 2016 3:11 AM > To: intel-wired-...@lists.osuosl.org; netdev@vger.kernel.org > Subject: [Intel-wired-lan] [next] igb: allow setting MAC addres

Re: [Intel-wired-lan] [next] igb: allow setting MAC address on i211 using a device tree blob V4

> On Feb 18, 2016, at 16:22, David Miller wrote: > > From: John Holland > Date: Thu, 18 Feb 2016 08:53:07 +0100 > >> The PCI path in eth_platform_get_mac_address() didn't return a devicetree >> node... > > Then fix your platform such that

Re: [Intel-wired-lan] [next] igb: allow setting MAC address on i211 using a device tree blob V4

From: John Holland Date: Thu, 18 Feb 2016 08:53:07 +0100 > The PCI path in eth_platform_get_mac_address() didn't return a devicetree > node... Then fix your platform such that pci_device_to_OF_node() works properly instead of adding localized hacks to device drivers. Jeff,

Re: [Intel-wired-lan] [next] igb: allow setting MAC address on i211 using a device tree blob V5

On 02/18/2016 12:10 PM, John Holland wrote: Hello, The Intel i211 LOM PCIe Ethernet controllers' iNVM operates as an OTP and has no external EEPROM interface [1]. The following allows the driver to pickup the MAC address from a device tree blob when CONFIG_OF has been enabled. + if

[Intel-wired-lan] [next] igb: allow setting MAC address on i211 using a device tree blob V5

Hello, The Intel i211 LOM PCIe Ethernet controllers' iNVM operates as an OTP and has no external EEPROM interface [1]. The following allows the driver to pickup the MAC address from a device tree blob when CONFIG_OF has been enabled. [1]

Re: [Intel-wired-lan] [next] igb: allow setting MAC address on i211 using a device tree blob V4

On Thu, 2016-02-18 at 08:53 +0100, John Holland wrote: > > > On Feb 18, 2016, at 03:29, David Miller > wrote: > >  > > From: John Holland > > Date: Thu, 18 Feb 2016 00:49:17 +0100 > >  > >> The Intel i211 LOM pcie ethernet controllers' iNVM operates as

Re: [Intel-wired-lan] [next] igb: allow setting MAC address on i211 using a device tree blob V4

> On Feb 18, 2016, at 03:29, David Miller wrote: > > From: John Holland > Date: Thu, 18 Feb 2016 00:49:17 +0100 > >> The Intel i211 LOM pcie ethernet controllers' iNVM operates as an OTP >> and has no externel EEPROM interface [1]. The following allows

Re: [Intel-wired-lan] [next] igb: allow setting MAC address on i211 using a device tree blob V4

From: John Holland Date: Thu, 18 Feb 2016 00:49:17 +0100 > The Intel i211 LOM pcie ethernet controllers' iNVM operates as an OTP > and has no externel EEPROM interface [1]. The following allows the > driver to pickup the MAC address from a device tree blob when > CONFIG_OF >

[Intel-wired-lan] [next] igb: allow setting MAC address on i211 using a device tree blob V4

Hello, The Intel i211 LOM pcie ethernet controllers' iNVM operates as an OTP and has no externel EEPROM interface [1]. The following allows the driver to pickup the MAC address from a device tree blob when CONFIG_OF has been enabled.

Re: [Intel-wired-lan] [next] igb: allow setting MAC address on i211 using a device tree blob V3

On Wed, 2016-02-17 at 07:43 +0100, John Holland wrote: > Hello, > > The Intel i211 LOM pcie ethernet controllers' iNVM operates as an OTP > and has no externel EEPROM interface [1]. The following allows the > driver to pickup the MAC address from a device tree blob when > CONFIG_OF > has been

[Intel-wired-lan] [next] igb: allow setting MAC address on i211 using a device tree blob V3

Hello, The Intel i211 LOM pcie ethernet controllers' iNVM operates as an OTP and has no externel EEPROM interface [1]. The following allows the driver to pickup the MAC address from a device tree blob when CONFIG_OF has been enabled.

Re: [Intel-wired-lan] [next] igb: allow setting MAC address on i211 using a device tree blob V2

> I can supply some kind of usage description/example, showing how to > use this feature to pull in the MAC address from u-boot and route it > to the i210. Just uncertain as how to name the respective > file. igb.txt or i210.txt come to mind. Do you prefer one over the > other? Hi John It is

Re: [Intel-wired-lan] [next] igb: allow setting MAC address on i211 using a device tree blob V2

> On Feb 16, 2016, at 17:58, Andrew Lunn wrote: > >> On Sat, Feb 13, 2016 at 11:04:45PM +0100, John Holland wrote: >> Hello, >> >> The Intel i211 LOM pcie ethernet controllers' iNVM operates as an >> OTP and has no externel EEPROM interface [1]. The following allows >> the

Re: [Intel-wired-lan] [next] igb: allow setting MAC address on i211 using a device tree blob V2

On Sat, Feb 13, 2016 at 11:04:45PM +0100, John Holland wrote: > Hello, > > The Intel i211 LOM pcie ethernet controllers' iNVM operates as an > OTP and has no externel EEPROM interface [1]. The following allows > the driver to pickup the MAC address from a device tree blob when > CONFIG_OF has

[Intel-wired-lan] [next] igb: allow setting MAC address on i211 using a device tree blob V2

Hello, The Intel i211 LOM pcie ethernet controllers' iNVM operates as an OTP and has no externel EEPROM interface [1]. The following allows the driver to pickup the MAC address from a device tree blob when CONFIG_OF has been enabled. [1]

Re: [Intel-wired-lan] [next] igb: allow setting MAC address on i211 using a device tree blob

On Wed, Feb 10, 2016 at 10:13:56AM +0100, John Holland wrote: > > > > Sent from my iPad > On Feb 9, 2016, at 12:54, Andrew Lunn wrote: > > >>> +static void igb_read_mac_addr_dts(struct e1000_hw *hw) > >>> +{ > >>> + const u8 *mac; > >>> + struct device_node *dn; >

Re: [Intel-wired-lan] [next] igb: allow setting MAC address on i211 using a device tree blob

> On Feb 9, 2016, at 12:02, Jeff Kirsher wrote: > >> On Fri, 2016-01-29 at 23:11 +0100, John Holland wrote: >> The Intel i211 LOM pcie ethernet controllers' iNVM operates as an >> OTP >> and has no externel EEPROM interface [1]. The following allows the >> driver

Re: [Intel-wired-lan] [next] igb: allow setting MAC address on i211 using a device tree blob

Sent from my iPad On Feb 9, 2016, at 12:54, Andrew Lunn wrote: >>> +static void igb_read_mac_addr_dts(struct e1000_hw *hw) >>> +{ >>> + const u8 *mac; >>> + struct device_node *dn; >>> + >>> + dn = of_find_compatible_node(NULL, NULL, "intel,i211"); > > Hi

Re: [Intel-wired-lan] [next] igb: allow setting MAC address on i211 using a device tree blob

On Feb 9, 2016, at 12:59, Andrew Lunn wrote: >>> + dn = of_find_compatible_node(NULL, NULL, "intel,i211"); > > Humm, NULL, NULL. That means find the first node anywhere in the > device tree which matches. This is not going to work too well when you > have multiple i211s.

Re: [Intel-wired-lan] [next] igb: allow setting MAC address on i211 using a device tree blob

> On Feb 9, 2016, at 18:42, Shannon Nelson wrote: > > It seem to me this should be using eth_platform_get_mac_address(), a > slightly more generic method to do this. See the i40e driver for an > example, commit d9a84324e6 I believe. > I believe you are referring to

Re: [Intel-wired-lan] [next] igb: allow setting MAC address on i211 using a device tree blob

On Fri, 2016-01-29 at 23:11 +0100, John Holland wrote: > The Intel i211 LOM pcie ethernet controllers' iNVM operates as an > OTP  > and has no externel EEPROM interface [1]. The following allows the  > driver to pickup the MAC address from a device tree blob when > CONFIG_OF  > has been enabled. >

Re: [Intel-wired-lan] [next] igb: allow setting MAC address on i211 using a device tree blob

> > +static void igb_read_mac_addr_dts(struct e1000_hw *hw) > > +{ > > +   const u8 *mac; > > +   struct device_node *dn; > > + > > +   dn = of_find_compatible_node(NULL, NULL, "intel,i211"); Hi John Would this also work for the i210? If so, you normally use the compatible string

Re: [Intel-wired-lan] [next] igb: allow setting MAC address on i211 using a device tree blob

> > +   dn = of_find_compatible_node(NULL, NULL, "intel,i211"); Humm, NULL, NULL. That means find the first node anywhere in the device tree which matches. This is not going to work too well when you have multiple i211s. There is a way so specify a DT node is attached to a specific PCIe

Re: [Intel-wired-lan] [next] igb: allow setting MAC address on i211 using a device tree blob

From: Shannon Nelson Date: Tue, 9 Feb 2016 09:42:45 -0800 > It seem to me this should be using eth_platform_get_mac_address(), a > slightly more generic method to do this. See the i40e driver for an > example, commit d9a84324e6 I believe. +1

Re: [Intel-wired-lan] [next] igb: allow setting MAC address on i211 using a device tree blob

It seem to me this should be using eth_platform_get_mac_address(), a slightly more generic method to do this. See the i40e driver for an example, commit d9a84324e6 I believe. sln On Tue, Feb 9, 2016 at 3:59 AM, Andrew Lunn wrote: >> > + dn = of_find_compatible_node(NULL,

[Intel-wired-lan] [next] igb: allow setting MAC address on i211 using a device tree blob

The Intel i211 LOM pcie ethernet controllers' iNVM operates as an OTP and has no externel EEPROM interface [1]. The following allows the driver to pickup the MAC address from a device tree blob when CONFIG_OF has been enabled. [1]