Re: [LAST CALL] [PATCH] [NET_SCHED]make qdisc_restart more readable

2007-05-14 Thread Patrick McHardy
jamal wrote: > On Mon, 2007-14-05 at 12:40 +0200, Patrick McHardy wrote: >>>+if (unlikely (ret != NETDEV_TX_BUSY && net_ratelimit())) >>>+printk(KERN_DEBUG " BUG %s code %d qlen %d\n",dev->name, ret, >>>q->q.qlen); > > What whitespace issue? Space between unlikely and '(', missi

Re: [LAST CALL] [PATCH] [NET_SCHED]make qdisc_restart more readable

2007-05-14 Thread jamal
On Mon, 2007-14-05 at 12:40 +0200, Patrick McHardy wrote: > Two final suggestions, sorry for not mentioning this earlier. np > > + printk(KERN_DEBUG > > + "Dead loop on netdevice %s, fix it urgently!\n", > > + dev->name); > > >

Re: [LAST CALL] [PATCH] [NET_SCHED]make qdisc_restart more readable

2007-05-14 Thread Patrick McHardy
jamal wrote: > Ok, I am upgrading this to last call after taking in Patricks feedback. > Speak now - or send patches against it later. > Dave, just let it simmer down for a day or two, then if no complaints, > go ahead and apply it. It is against net-2.6 > Many thanks to Thomas, Peter and Patrick

[LAST CALL] [PATCH] [NET_SCHED]make qdisc_restart more readable

2007-05-13 Thread jamal
Ok, I am upgrading this to last call after taking in Patricks feedback. Speak now - or send patches against it later. Dave, just let it simmer down for a day or two, then if no complaints, go ahead and apply it. It is against net-2.6 Many thanks to Thomas, Peter and Patrick for their reviews. ch