Re: [PATCH/RFC 2/3] net/sched: act_tunnel_key: add extended ack support

2018-03-22 Thread Simon Horman
On Fri, Mar 09, 2018 at 12:22:48PM +0100, Jiri Benc wrote: > On Tue, 6 Mar 2018 18:08:04 +0100, Simon Horman wrote: > > - if (!tb[TCA_TUNNEL_KEY_PARMS]) > > + if (!tb[TCA_TUNNEL_KEY_PARMS]) { > > + NL_SET_ERR_MSG(extack, "Missing tunnel key parameter"); > > "parameters" (it's not ju

Re: [PATCH/RFC 2/3] net/sched: act_tunnel_key: add extended ack support

2018-03-09 Thread Jiri Benc
On Tue, 6 Mar 2018 18:08:04 +0100, Simon Horman wrote: > - if (!tb[TCA_TUNNEL_KEY_PARMS]) > + if (!tb[TCA_TUNNEL_KEY_PARMS]) { > + NL_SET_ERR_MSG(extack, "Missing tunnel key parameter"); "parameters" (it's not just one parameter) > @@ -107,6 +109,7 @@ static int tunnel_key_in

[PATCH/RFC 2/3] net/sched: act_tunnel_key: add extended ack support

2018-03-06 Thread Simon Horman
Add extended ack support for the tunnel key action by using NL_SET_ERR_MSG during validation of user input. Signed-off-by: Simon Horman Signed-off-by: Pieter Jansen van Vuuren Reviewed-by: Jakub Kicinski --- net/sched/act_tunnel_key.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(