Re: [PATCH/RFC net-next] rocker: forward packets to CPU when a port in promiscuous mode

2015-07-15 Thread Simon Horman
On Wed, Jul 15, 2015 at 07:50:32AM -0700, Scott Feldman wrote: > On Wed, Jul 15, 2015 at 12:54 AM, Simon Horman > wrote: > > On Wed, Jul 15, 2015 at 12:18:20AM -0700, Scott Feldman wrote: > >> On Tue, Jul 14, 2015 at 11:34 PM, Simon Horman > >> wrote: > >> > On Tue, Jul 14, 2015 at 10:32:54PM -07

Re: [PATCH/RFC net-next] rocker: forward packets to CPU when a port in promiscuous mode

2015-07-15 Thread Scott Feldman
On Wed, Jul 15, 2015 at 12:54 AM, Simon Horman wrote: > On Wed, Jul 15, 2015 at 12:18:20AM -0700, Scott Feldman wrote: >> On Tue, Jul 14, 2015 at 11:34 PM, Simon Horman >> wrote: >> > On Tue, Jul 14, 2015 at 10:32:54PM -0700, Scott Feldman wrote: >> >> >> > @@ -5263,11 +5301,16 @@ static int rock

Re: [PATCH/RFC net-next] rocker: forward packets to CPU when a port in promiscuous mode

2015-07-15 Thread Simon Horman
On Wed, Jul 15, 2015 at 12:18:20AM -0700, Scott Feldman wrote: > On Tue, Jul 14, 2015 at 11:34 PM, Simon Horman > wrote: > > On Tue, Jul 14, 2015 at 10:32:54PM -0700, Scott Feldman wrote: > > >> > @@ -5263,11 +5301,16 @@ static int rocker_port_master_changed(struct > >> > net_device *dev) > >> >

Re: [PATCH/RFC net-next] rocker: forward packets to CPU when a port in promiscuous mode

2015-07-15 Thread Scott Feldman
On Tue, Jul 14, 2015 at 11:34 PM, Simon Horman wrote: > On Tue, Jul 14, 2015 at 10:32:54PM -0700, Scott Feldman wrote: >> > @@ -5263,11 +5301,16 @@ static int rocker_port_master_changed(struct >> > net_device *dev) >> > * 3. Other, e.g. being added to or removed from a bond or >> > ope

Re: [PATCH/RFC net-next] rocker: forward packets to CPU when a port in promiscuous mode

2015-07-14 Thread Simon Horman
On Tue, Jul 14, 2015 at 10:32:54PM -0700, Scott Feldman wrote: > On Tue, Jul 14, 2015 at 9:45 PM, Simon Horman [snip] > > How about this? > > Looks good, some inline comments... [snip] > > @@ -321,9 +322,21 @@ static u16 rocker_port_vlan_to_vid(const struct > > rocker_port *rocker_port, > >

Re: [PATCH/RFC net-next] rocker: forward packets to CPU when a port in promiscuous mode

2015-07-14 Thread Scott Feldman
On Tue, Jul 14, 2015 at 9:45 PM, Simon Horman wrote: > Hi Scott, > > On Mon, Jul 13, 2015 at 11:37:59PM -0700, Scott Feldman wrote: >> On Wed, Jul 8, 2015 at 9:25 PM, Simon Horman >> wrote: >> > This change allows the CPU to see all packets seen by a port when the >> > netdev associated with the

Re: [PATCH/RFC net-next] rocker: forward packets to CPU when a port in promiscuous mode

2015-07-14 Thread Simon Horman
Hi Scott, On Mon, Jul 13, 2015 at 11:37:59PM -0700, Scott Feldman wrote: > On Wed, Jul 8, 2015 at 9:25 PM, Simon Horman > wrote: > > This change allows the CPU to see all packets seen by a port when the > > netdev associated with the port is in promiscuous mode. > > > > This change was previousl

Re: [PATCH/RFC net-next] rocker: forward packets to CPU when a port in promiscuous mode

2015-07-13 Thread Scott Feldman
On Wed, Jul 8, 2015 at 9:25 PM, Simon Horman wrote: > This change allows the CPU to see all packets seen by a port when the > netdev associated with the port is in promiscuous mode. > > This change was previously posted as part of a larger patch and in turn > patchset which also aimed to allow roc

Re: [PATCH/RFC net-next] rocker: forward packets to CPU when a port in promiscuous mode

2015-07-08 Thread John Fastabend
On 15-07-08 09:25 PM, Simon Horman wrote: > This change allows the CPU to see all packets seen by a port when the > netdev associated with the port is in promiscuous mode. > > This change was previously posted as part of a larger patch and in turn > patchset which also aimed to allow rocker interf

[PATCH/RFC net-next] rocker: forward packets to CPU when a port in promiscuous mode

2015-07-08 Thread Simon Horman
This change allows the CPU to see all packets seen by a port when the netdev associated with the port is in promiscuous mode. This change was previously posted as part of a larger patch and in turn patchset which also aimed to allow rocker interfaces to receive packets when not bridged. That probl