Re: [PATCH][af_key]pfkey_add: Optimize SA adds and algorithm probes

2007-05-24 Thread David Miller
From: Mark Huth <[EMAIL PROTECTED]> Date: Thu, 24 May 2007 17:15:30 -0700 > I'm a bit curious why all of the crypto modules got loaded, but it > doesn't matter. When SADB_REGISTER is performed on a PF_KEY socket, it calls xfrm_probe_algs() which iterates over the lists and loads all the availble

Re: [PATCH][af_key]pfkey_add: Optimize SA adds and algorithm probes

2007-05-24 Thread Herbert Xu
On Thu, May 24, 2007 at 05:15:30PM -0700, Mark Huth wrote: > > I'm a bit curious why all of the crypto modules got loaded, but it > doesn't matter. If anybody does a PFKEY_REGISTER call then all the algorithms will get loaded so that the key manager can find out what algorithms are actually avai

Re: [PATCH][af_key]pfkey_add: Optimize SA adds and algorithm probes

2007-05-24 Thread Mark Huth
Herbert Xu wrote: On Fri, May 18, 2007 at 02:34:12PM +1000, Herbert Xu wrote: Actually, I think we should just probe for the specific algorithm requested rather than everything. See patch below. Doh, forgot to actually remove the probe call :) [IPSEC] pfkey: Load specific algorithm in pfk

Re: [PATCH][af_key]pfkey_add: Optimize SA adds and algorithm probes

2007-05-19 Thread David Miller
From: Herbert Xu <[EMAIL PROTECTED]> Date: Sat, 19 May 2007 07:21:48 +1000 > On Fri, May 18, 2007 at 02:34:12PM +1000, Herbert Xu wrote: > > > > Actually, I think we should just probe for the specific algorithm > > requested rather than everything. See patch below. > > Doh, forgot to actually r

Re: [PATCH][af_key]pfkey_add: Optimize SA adds and algorithm probes

2007-05-18 Thread Herbert Xu
On Fri, May 18, 2007 at 02:34:12PM +1000, Herbert Xu wrote: > > Actually, I think we should just probe for the specific algorithm > requested rather than everything. See patch below. Doh, forgot to actually remove the probe call :) [IPSEC] pfkey: Load specific algorithm in pfkey_add rather than

Re: [PATCH][af_key]pfkey_add: Optimize SA adds and algorithm probes

2007-05-18 Thread Mark Huth
Herbert Xu wrote: Mark Huth <[EMAIL PROTECTED]> wrote: This patch provides a performance optimization in the pfkey_add path. Prior versions have a serious performance problem when adding a large number of SAs to a node. For example, if a backup node needs to be loaded with the SAs previously

Re: [PATCH][af_key]pfkey_add: Optimize SA adds and algorithm probes

2007-05-17 Thread Herbert Xu
Mark Huth <[EMAIL PROTECTED]> wrote: > > This patch provides a performance optimization in the pfkey_add path. > Prior versions have a serious performance problem when adding a large > number of SAs to a node. For example, if a backup node needs to be > loaded with the SAs previously held by a fa

[PATCH][af_key]pfkey_add: Optimize SA adds and algorithm probes

2007-05-10 Thread Mark Huth
Sorry about previous html/non-inline version which escaped. This patch provides a performance optimization in the pfkey_add path. Prior versions have a serious performance problem when adding a large number of SAs to a node. For example, if a backup node needs to be loaded with the SAs previousl

[PATCH][af_key]pfkey_add: Optimize SA adds and algorithm probes

2007-05-10 Thread Mark Huth
This patch provides a performance optimization in the pfkey_add path. Prior versions have a serious performance problem when adding a large number of SAs to a node. For example, if a backup node needs to be loaded with the SAs previously held by a failed active node, thousands of SAs may need to