Re: [PATCH][netdev-next] net: hns: make guid hns_dsaf_acpi_dsm_guid static

2017-06-13 Thread Colin Ian King
On 13/06/17 20:24, Andy Shevchenko wrote: > On Tue, Jun 13, 2017 at 8:56 PM, David Miller wrote: >> From: Colin King >> Date: Tue, 13 Jun 2017 14:03:21 +0100 >> >>> From: Colin Ian King >>> >>> The guid hns_dsaf_acpi_dsm_guid does not need to be in global >>> scope, so make it static. >>> >>> Cl

Re: [PATCH][netdev-next] net: hns: make guid hns_dsaf_acpi_dsm_guid static

2017-06-13 Thread Andy Shevchenko
On Tue, Jun 13, 2017 at 8:56 PM, David Miller wrote: > From: Colin King > Date: Tue, 13 Jun 2017 14:03:21 +0100 > >> From: Colin Ian King >> >> The guid hns_dsaf_acpi_dsm_guid does not need to be in global >> scope, so make it static. >> >> Cleans up sparse warning: >> "symbol 'hns_dsaf_acpi_dsm

Re: [PATCH][netdev-next] net: hns: make guid hns_dsaf_acpi_dsm_guid static

2017-06-13 Thread David Miller
From: Colin King Date: Tue, 13 Jun 2017 14:03:21 +0100 > From: Colin Ian King > > The guid hns_dsaf_acpi_dsm_guid does not need to be in global > scope, so make it static. > > Cleans up sparse warning: > "symbol 'hns_dsaf_acpi_dsm_guid' was not declared. Should it be static?" > > Signed-off-b

Re: [PATCH][netdev-next] net: hns: make guid hns_dsaf_acpi_dsm_guid static

2017-06-13 Thread Andy Shevchenko
On Tue, 2017-06-13 at 14:03 +0100, Colin King wrote: > From: Colin Ian King > > The guid hns_dsaf_acpi_dsm_guid does not need to be in global > scope, so make it static. > > Cleans up sparse warning: > "symbol 'hns_dsaf_acpi_dsm_guid' was not declared. Should it be > static?" Reviewed-by: Andy

[PATCH][netdev-next] net: hns: make guid hns_dsaf_acpi_dsm_guid static

2017-06-13 Thread Colin King
From: Colin Ian King The guid hns_dsaf_acpi_dsm_guid does not need to be in global scope, so make it static. Cleans up sparse warning: "symbol 'hns_dsaf_acpi_dsm_guid' was not declared. Should it be static?" Signed-off-by: Colin Ian King --- drivers/net/ethernet/hisilicon/hns/hns_dsaf_misc.c