Re: [PATCH] [PATCH net] net: Do not hold the reference for the same sk_rx_dst.

2017-03-16 Thread Eric Dumazet
On Thu, 2017-03-16 at 16:13 -0700, Cong Wang wrote: > On Thu, Mar 16, 2017 at 2:33 PM, Eric Dumazet wrote: > > Have you backported the redirect fix ? > > > > commit 45caeaa5ac0b4b11784ac6f932c0ad4c6b67cda0 > > > > Or other fixes that went very recently (pick David Miller net tree) > > Why the com

Re: [PATCH] [PATCH net] net: Do not hold the reference for the same sk_rx_dst.

2017-03-16 Thread Cong Wang
On Thu, Mar 16, 2017 at 2:33 PM, Eric Dumazet wrote: > Have you backported the redirect fix ? > > commit 45caeaa5ac0b4b11784ac6f932c0ad4c6b67cda0 > > Or other fixes that went very recently (pick David Miller net tree) Why the commit above is relevant here? It fixes a double-release, while Kevin's

Re: [PATCH] [PATCH net] net: Do not hold the reference for the same sk_rx_dst.

2017-03-16 Thread Eric Dumazet
On Thu, 2017-03-16 at 01:08 -0700, Kevin Xu wrote: > In some rare cases, inet_sk_rx_dst_set() may be called multiple times > on the same dst, causing reference count leakage. Eventually, it > prevents net_device to be destroyed. The bug then manifested as > > unregister_netdevice: waiting for lo t

Re: [PATCH] [PATCH net] net: Do not hold the reference for the same sk_rx_dst.

2017-03-16 Thread Cong Wang
On Thu, Mar 16, 2017 at 11:18 AM, Kaiwen Xu wrote: > On Thu, Mar 16, 2017 at 11:45:03AM +0100, Jakub Sitnicki wrote: >> On Thu, Mar 16, 2017 at 10:12 AM GMT, Kevin Xu wrote: >> > Do you mean the message looping endlessly? >> >> No, the message is emitted just once. Around 100 seconds after >> dest

Re: [PATCH] [PATCH net] net: Do not hold the reference for the same sk_rx_dst.

2017-03-16 Thread Kaiwen Xu
On Thu, Mar 16, 2017 at 11:45:03AM +0100, Jakub Sitnicki wrote: > On Thu, Mar 16, 2017 at 10:12 AM GMT, Kevin Xu wrote: > > Do you mean the message looping endlessly? > > No, the message is emitted just once. Around 100 seconds after > destroying a few namespaces. Occurs not so often, maybe once p

Re: [PATCH] [PATCH net] net: Do not hold the reference for the same sk_rx_dst.

2017-03-16 Thread David Miller
From: Kevin Xu Date: Thu, 16 Mar 2017 01:08:30 -0700 > In some rare cases, inet_sk_rx_dst_set() may be called multiple times > on the same dst, causing reference count leakage. Eventually, it > prevents net_device to be destroyed. The bug then manifested as > > unregister_netdevice: waiting for

Re: [PATCH] [PATCH net] net: Do not hold the reference for the same sk_rx_dst.

2017-03-16 Thread Jakub Sitnicki
On Thu, Mar 16, 2017 at 10:12 AM GMT, Kevin Xu wrote: > Do you mean the message looping endlessly? No, the message is emitted just once. Around 100 seconds after destroying a few namespaces. Occurs not so often, maybe once per ten runs. -Jakub > If so, then I suppose it's a different bug. > > Ke

Re: [PATCH] [PATCH net] net: Do not hold the reference for the same sk_rx_dst.

2017-03-16 Thread Kevin Xu
Do you mean the message looping endlessly? If so, then I suppose it's a different bug. Kevin > On Mar 16, 2017, at 3:01 AM, Jakub Sitnicki wrote: > >> On Thu, Mar 16, 2017 at 08:08 AM GMT, Kevin Xu wrote: >> In some rare cases, inet_sk_rx_dst_set() may be called multiple times >> on the same d

Re: [PATCH] [PATCH net] net: Do not hold the reference for the same sk_rx_dst.

2017-03-16 Thread Jakub Sitnicki
On Thu, Mar 16, 2017 at 08:08 AM GMT, Kevin Xu wrote: > In some rare cases, inet_sk_rx_dst_set() may be called multiple times > on the same dst, causing reference count leakage. Eventually, it > prevents net_device to be destroyed. The bug then manifested as > > unregister_netdevice: waiting for lo

[PATCH] [PATCH net] net: Do not hold the reference for the same sk_rx_dst.

2017-03-16 Thread Kevin Xu
In some rare cases, inet_sk_rx_dst_set() may be called multiple times on the same dst, causing reference count leakage. Eventually, it prevents net_device to be destroyed. The bug then manifested as unregister_netdevice: waiting for lo to become free. Usage count = 1 in the kernel log, preventing